⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 9, 2007:

6:36 PM Known incompatibilities between open-source WebKit and Safari edited by bdash@webkit.org
(diff)
6:05 PM Changeset in webkit [20815] by adele
  • 1 edit
    1 add in trunk/WebKitSite
  • blog/wp-content/chrome.jpg: Added.
5:55 PM Changeset in webkit [23250] by beidson
  • 4 edits in branches/WindowsMerge

Build fix for my recent OpenSource checkin

5:06 PM Changeset in webkit [20814] by andersca
  • 4 edits in trunk

WebCore:

Reviewed by John.

  • WebCore.exp: Add ZNK7WebCore11FrameLoader10isCompleteEv.

WebKit:

Reviewed by John.

<rdar://problem/5081860>
REGRESSION: Select All for standalone image has no visible effect but does change state


<rdar://problem/5081840>
REGRESSION: context menu in white space beyond standalone image is different after Select All


Have validateUserInterface emulate the old behavior for full-frame images and plugins, which is:


  • For full-frame plugins, always return false.
  • For images, only return true if the selector is copy: and the image has finished loading.


  • WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItem:]):
5:00 PM Changeset in webkit [20813] by beidson
  • 7 edits
    3 adds in trunk

LayoutTests:

Reviewed by Darin

Layout test for the fix for <rdar://4921797> and ​http://bugs.webkit.org/show_bug.cgi?id=12005

  • http/tests/navigation/multiple-back-forward-entries-expected.txt: Added.
  • http/tests/navigation/multiple-back-forward-entries.html: Added.
  • http/tests/navigation/resources/slow-resource.pl: Added.

WebCore:

Reviewed by Darin

Fixes <rdar://4921797> and ​http://bugs.webkit.org/show_bug.cgi?id=12005

The original regression was to claim that more loads were the result of a "user gesture" than really
were. A lot of the ways a frame load could be kicked off didn't properly set up this flag, and it
wasn't properly propagated and respected where it should've been.

This patch cleans much of that up. One loose end is the "treatAsUserGesture" flag which is a stop
gap measure to keep "slow redirects" working to create a new history item. In the future, we need
to cleanup the meaning and use of "userGesture" and "lockHistory." This includes integrating them
in to FrameLoadRequest and being very clear of what their meaning actually is at different stages of
the Frame load process.

  • dom/Document.cpp: (WebCore::Document::processHttpEquiv): Pass only the delay for the redirect
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Pass "lockHistory" false, "userGesture" true
  • ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): Pass "lockHistory" false, "userGesture" true
  • loader/FrameLoader.cpp: (WebCore::ScheduledRedirection::ScheduledRedirection): Figure "lockHistory" and "userGesture" from the delay here, instead of at 3 other different sites that call this method (WebCore::FrameLoader::changeLocation): Set userGesture correctly (WebCore::FrameLoader::urlSelected): Propagate userGesture down (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::scheduleRedirection): Pass only the delay here (WebCore::FrameLoader::redirectionTimerFired): Set userGesture correctly (WebCore::FrameLoader::load): (WebCore::FrameLoader::updateHistoryForInternalLoad): Insteading of asserting we aren't a redirect, handle the case where we *are* a redirect by updating the previous history item
  • loader/FrameLoader.h:
4:31 PM Changeset in webkit [20812] by andersca
  • 2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/5026893>
REGRESSION: "Mail Contents of this Page" for standalone image in Safari results in a broken image in Mail


  • WebView/WebFrame.mm: (-[WebFrame DOMDocument]): We can't check for _isHTMLDocument here since image and plugin documents inherit from HTMLDocument. Instead, check for those two document types explicitly.
3:52 PM Changeset in webkit [20811] by andersca
  • 3 edits in trunk/WebKit

Reviewed by Geoff, Ada and John.

<rdar://problem/4600978> Would like a way to test whether a WebView is displaying a standalone image

  • WebView/WebFrame.mm: (-[WebFrame _isDisplayingStandaloneImage]):
  • WebView/WebFramePrivate.h: Add _isDisplayingStandaloneImage SPI.
3:30 PM Changeset in webkit [23249] by thatcher
  • 2 edits in branches/WindowsMerge/WebKitWin

Merge in r20810.

<rdar://problem/5121757> WebInspector focuses elements on mouse up instead of mouse down

Make selecting a tree node happen on mousedown to match the NSOutlineView behavior.
Also makes selecting rows in the style pane happen on mousedown for consistency.

3:14 PM Changeset in webkit [20810] by thatcher
  • 1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/inspector.js

Make selecting a tree node happen on mousedown to match the NSOutlineView behavior. Also makes selecting rows in the style pane happen on mousedown for consistency.

3:11 PM Changeset in webkit [20809] by andersca
  • 1 edit in trunk/LayoutTests/ChangeLog

Add bug number to ChangeLog.

1:07 PM Changeset in webkit [20808] by justing
  • 31 edits in trunk/LayoutTests

Reviewed by ggaren


These were never checked in:

  • editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum: Added.
  • editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: Added.


New results were never checked in after some selection
gap filling fixes:

  • editing/style/remove-underline-across-paragraph-expected.checksum:
  • editing/style/remove-underline-across-paragraph-expected.png:
  • editing/style/remove-underline-across-paragraph-in-bold-expected.checksum:
  • editing/style/remove-underline-across-paragraph-in-bold-expected.png:
  • editing/style/style-3690704-fix-expected.checksum:
  • editing/style/style-3690704-fix-expected.png:
  • editing/style/table-selection-expected.checksum:
  • editing/style/table-selection-expected.png:
  • editing/undo/4063751-expected.checksum:
  • editing/undo/4063751-expected.png:
  • editing/style/apple-style-editable-mix-expected.checksum:
  • editing/style/apple-style-editable-mix-expected.png:
  • editing/inserting/paragraph-separator-in-table-1-expected.checksum:
  • editing/inserting/paragraph-separator-in-table-1-expected.png:
  • editing/inserting/paragraph-separator-in-table-2-expected.checksum:
  • editing/inserting/paragraph-separator-in-table-2-expected.png:


Checking in incorrect results and adding a FIXME that references the
bug that this test demonstrates:

  • editing/style/smoosh-styles-003-expected.checksum:
  • editing/style/smoosh-styles-003-expected.png:
  • editing/style/smoosh-styles-003-expected.txt:
  • editing/style/smoosh-styles-003.html:


Misspelling marker correctly removed:

  • editing/deleting/delete-to-select-table-expected.checksum:
  • editing/deleting/delete-to-select-table-expected.png:


Horizontal rules and parts of table borders were made very slightly
darker, and these results were never updated:

  • editing/inserting/4278698-expected.checksum:
  • editing/inserting/4278698-expected.png:
  • editing/unsupported-content/table-type-after-expected.checksum:
  • editing/unsupported-content/table-type-after-expected.png:
  • editing/unsupported-content/table-type-before-expected.checksum:
  • editing/unsupported-content/table-type-before-expected.png:
  • editing/deleting/table-cells-expected.checksum:
  • editing/deleting/table-cells-expected.png:
12:51 PM Changeset in webkit [20807] by andersca
  • 2 edits in trunk/LayoutTests

Reviewed by Mitz.

  • plugins/resources/open-and-close-window-with-plugin.html: Try to fix the ASSERT on the build bot by scheduling a timeout that schedules a timeout.
11:48 AM Changeset in webkit [20806] by spadma
  • 5 edits in S60/trunk/WebKit

raalexan, reviewed by <spadma>

DESC: removed the webkit warnings
​http://bugs.webkit.org/show_bug.cgi?id=13143

  • BrowserView/src/PluginContentPlayer.cpp:
  • BrowserView/src/WebKitLoader.cpp:
  • BrowserView/src/WebKitView.cpp:
  • ResourceLoader/CacheSrc/HttpCacheManager.cpp:
11:40 AM Changeset in webkit [23248] by aroben
  • 3 edits in branches/WindowsMerge/WebKitWin

Fixed copyrights.

  • WebInspector/WebInspector.cpp:
  • WebInspector/WebInspector.h:
11:19 AM Changeset in webkit [20805] by andersca
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.


<rdar://problem/5120801>
​http://bugs.webkit.org/show_bug.cgi?id=13247
Closing a page during slow cloning causes crash in setJSStatusBarText (13247)


  • fast/dom/Window/setting-properties-on-closed-window-expected.txt: Added.
  • fast/dom/Window/setting-properties-on-closed-window.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/5120801>
​http://bugs.webkit.org/show_bug.cgi?id=13247
Closing a page during slow cloning causes crash in setJSStatusBarText (13247)

  • bindings/js/kjs_window.cpp: (KJS::Window::put): Return early if m_frame is null. A closed window only has one property, "closed" so no properties should be settable in that case.
11:13 AM Changeset in webkit [23247] by aroben
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Oliver.

Fix two Web Inspector bugs:

  • The WebView wasn't focused when the inspector first appeared.
  • Resizing the upper pane did not resize the whole window.
  • WebInspector/WebInspector.cpp: (WebInspector::show): Focus the WebView. (WebInspector::setFrame): Implemented. (WebInspector::webViewFrame): Implemented.
  • WebInspector/WebInspector.h:
10:48 AM Changeset in webkit [20804] by spadma
  • 4 edits in S60/trunk/WebKit

borges, reviewed by <sachin>

DESC: Part of S60 task 15095: Removed exporting of header files RecentUrlStore.h. Moved all keys from BrowserUiInternalCRKeys.h to BrowserUiSDKCRKeys.h
​http://bugs.webkit.org/show_bug.cgi?id=13310

  • BrowserView/src/WebKitControl.cpp:
  • Plugin/src/PluginSkin.cpp:
  • ResourceLoader/src/HttpLoaderAcceptHeader.cpp:
10:27 AM Changeset in webkit [23246] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin
  • WebInspector/WebInspector.cpp: (WebInspector::WebInspector): Removed two fixed FIXMEs and some commented-out code.
10:19 AM Changeset in webkit [23245] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):
7:33 AM Changeset in webkit [20803] by yongjzha
  • 2 edits in S60/branches/3.1m/WebCore

2007-04-05 winship <​steven.winship@nokia.com>

Reviewed by Yongjun <​yongjun.zhang@nokia.com>
DESC: ASAA-6Y2BLC - Crash when opening NT dialog twice

fix: set pointer to null so static data is re-initialized

​http://bugs.webkit.org/show_bug.cgi?id=13288

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQTextCodec.cpp: (QTextCodec::PrepareForExit):
4:48 AM Changeset in webkit [20802] by andrew
  • 8 edits
    4 adds in trunk

2007-04-09 Andrew Wellington <​proton@wiretapped.net>

Reviewed by Justin Garcia.


Layout test for ​http://bugs.webkit.org/show_bug.cgi?id=12959
"REGRESSION: Edit -> Copy not enabled on standalone images"

  • editing/pasteboard/copy-standalone-image-expected.checksum: Added.
  • editing/pasteboard/copy-standalone-image-expected.png: Added.
  • editing/pasteboard/copy-standalone-image-expected.txt: Added.
  • editing/pasteboard/copy-standalone-image.html: Added.

2007-04-09 Andrew Wellington <​proton@wiretapped.net>

Reviewed by Justin Garcia.


Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12959
"REGRESSION: Edit -> Copy not enabled on standalone images"

  • dom/Document.h: Add support for determining if a document is an image (WebCore::Document::isImageDocument):
  • editing/Editor.cpp: (WebCore::Editor::canCopy): Image documents are copyable (WebCore::Editor::copy): If copying an image document, call appropriate pasteboard methods
  • loader/ImageDocument.h: (WebCore::ImageDocument::isImageDocument): Override to return true for image documents
  • platform/Pasteboard.h: Add new writeImage function to pasteboard
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeImage): Add writeImage implementation that takes Node and URL
  • platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeImage): Stub for Qt implementation of pasteboard

Apr 8, 2007:

11:32 PM Changeset in webkit [23244] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

When does "merge" != "merge"? When you make the change yourself
pre-emptively and make a typo.

11:32 PM Changeset in webkit [20801] by oliver
  • 2 edits in trunk/WebCore

2007-04-08 Oliver Hunt <​oliver@apple.com>

rs=Adam.

Add ASSERT(selectedRange) to previous change

  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection):
11:25 PM Changeset in webkit [23243] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Merge in r20800.

11:18 PM Changeset in webkit [20800] by thatcher
  • 1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/inspector.js

Use keyIdentifier instead of keyCode.

11:14 PM Changeset in webkit [20799] by oliver
  • 2 edits in trunk/WebCore

2007-04-08 Oliver Hunt <​oliver@apple.com>

rs=Adam.

Fix minor error when writing selection to pasteboard.
This shouldn't have an effect as selectedRange should be the
selected range from source frame, however this is safer.

  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection):
11:11 PM Changeset in webkit [20798] by hyatt
  • 3 edits in trunk/WebCore

Fix mouseover/out failing layout tests.

Reviewed by aroben

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::updateMouseEventTargetNode): (WebCore::EventHandler::dispatchMouseEvent):
  • page/EventHandler.h:
10:50 PM Changeset in webkit [23242] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Merge in r20797.

10:49 PM Changeset in webkit [23241] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Merge in r20796.

10:46 PM Changeset in webkit [23240] by aroben
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Anders.

<rdar://problem/5119804> Web Inspector isn't resizable
<rdar://problem/5119805> Can't move Web Inspector

  • WebInspector/WebInspector.cpp: (WebInspectorPrivate::WebInspectorPrivate): (WebInspector::WebInspector): Subclass the WebView so we can intercept its messages. (WebInspector::onDestroy): Undo the subclassing. (WebInspector::handleMessageSentToWebView): Added. (WebInspector::onLButtonDown): Added. (WebInspector::onLButtonUp): Added. (WebInspector::onMouseMove): Added. (WebInspectorWndProc): Added cases for mouse messages. (SubclassedWebViewWndProc): Added.
  • WebInspector/WebInspector.h:
10:04 PM Changeset in webkit [20797] by thatcher
  • 1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/inspector.js

Search comment nodes also.

9:51 PM Changeset in webkit [20796] by thatcher
  • 1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/inspector.js

A better Xpath query for the simple search case.

9:30 PM Changeset in webkit [20795] by oliver
  • 2 edits in trunk/WebCore

2007-04-08 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Fix for <rdar://problem/5113621> REGRESSION: Dragging PDF as image does not give any feedback

If we fail when attempting to create a drag image for a dragged
image, we fall back to the appropriate icon.

  • page/DragController.cpp: (WebCore::DragController::doImageDrag):
8:55 PM Changeset in webkit [23239] by aroben
  • 4 edits
    3 adds
    2 deletes in branches/WindowsMerge/WebKitWin

Merge in r20793.

8:42 PM Changeset in webkit [23238] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Merge in r20792.

8:41 PM Changeset in webkit [23237] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Merge in r20791.

8:38 PM Changeset in webkit [23236] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Stubbed out Frame::dashboardRegionsChanged now that it's not
Mac-specific.

  • bridge/win/FrameWin.cpp: (WebCore::Frame::dashboardRegionsChanged):
8:32 PM Changeset in webkit [20794] by aroben
  • 18 edits
    1 delete in trunk/WebCore

Reviewed by Oliver.

Bestowed the gift of -webkit-dashboard-region upon all platforms, since
there's nothing Mac-specific about it other than the name. This also
allowed me to get rid of FrameViewMac.mm.

Removed a lot of #if PLATFORM(MAC):

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::cssText):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::getDashboardRegionValue): (WebCore::CSSPrimitiveValue::):
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseDashboardRegions):
  • css/cssparser.h:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/Document.h:
  • page/Frame.cpp: (WebCore::Frame::paint):
  • page/Frame.h:
  • page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::updateDashboardRegions): Moved from FrameViewMac.mm.
  • page/FrameView.h:
  • page/qt/FrameQt.cpp: (WebCore::Frame::dashboardRegionsChanged): Stubbed out.
  • platform/gdk/FrameGdk.cpp: (WebCore::Frame::dashboardRegionsChanged): Ditto.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar): (WebCore::RenderLayer::updateScrollInfoAfterLayout):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle):
  • WebCore.xcodeproj/project.pbxproj: Removed FrameViewMac.mm.
  • bridge/mac/FrameViewMac.mm: Removed.
7:52 PM Changeset in webkit [20793] by thatcher
  • 3 edits
    2 moves
    1 add in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector

Rename our AppleScrollbar and AppleScrollArea classes and copy in the resize.png image.

5:51 PM Changeset in webkit [20792] by thatcher
  • 1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/inspector.js

Fixes a typo that was showing the id attribute twice in the tree.

5:50 PM Changeset in webkit [20791] by thatcher
  • 1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/inspector.js

Use Xpath for the plain text search case. This is faster than walking the DOM in JavaScript.

5:48 PM Changeset in webkit [20790] by bdash
  • 2 edits in branches/WebInspectorRefresh/WebKit

2007-04-09 Mark Rowe <​mrowe@apple.com>

Build fix.

  • WebInspector/WebInspector.m:
5:20 PM Changeset in webkit [23235] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Merge in r20789.

2:15 PM Changeset in webkit [20789] by thatcher
  • 3 edits in branches/WebInspectorRefresh/WebKit

Implement document searching in JavaScript.

12:08 PM WikiStart edited by kevino@theolliviers.com
Making the page more general so it can fit more info. (diff)
12:02 PM WikiStart edited by kevino@theolliviers.com
Adding page about the Bakefile build system (diff)
11:57 AM Changeset in webkit [23234] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fix.

  • WebInspector/WebInspector.cpp:
4:32 AM BuildingQtOnLinux created by sil-webkit@kryogenix.org
4:26 AM WikiStart edited by sil-webkit@kryogenix.org
(diff)
3:15 AM Changeset in webkit [20788] by bdash
  • 2 edits in trunk/WebCore

2007-04-08 Mark Rowe <​mrowe@apple.com>

Qt build fix.

  • platform/qt/TemporaryLinkStubs.cpp:
2:45 AM Changeset in webkit [20787] by mjs
  • 3 edits in branches/js-collector-tweaks/JavaScriptCore

Not reviewed, experimental change.

  • shrink RegexpObjectImp by 4 bytes


Somewhat inexplicably, this seems to be a .33% speedup on JS iBench.


  • kjs/regexp_object.cpp: (KJS::RegExpObjectImpPrivate::RegExpObjectImpPrivate): (RegExpObjectImp::RegExpObjectImp): (RegExpObjectImp::performMatch): (RegExpObjectImp::arrayOfMatches): (RegExpObjectImp::getBackref): (RegExpObjectImp::getLastMatch): (RegExpObjectImp::getLastParen): (RegExpObjectImp::getLeftContext): (RegExpObjectImp::getRightContext): (RegExpObjectImp::getValueProperty): (RegExpObjectImp::putValueProperty):
  • kjs/regexp_object.h:
2:33 AM Changeset in webkit [20786] by mjs
  • 3 edits in branches/js-collector-tweaks/JavaScriptCore

Not reviewed, experimental change.


  • shrink ArrayInstance objects by 4 bytes


I did this by storing the capacity before the beginning of the storage array. It turns out
it is rarely needed and is by definition 0 when the storage array is null.

  • kjs/array_instance.h: (KJS::ArrayInstance::capacity):
  • kjs/array_object.cpp: (allocateStorage): (reallocateStorage): (ArrayInstance::ArrayInstance): (ArrayInstance::~ArrayInstance): (ArrayInstance::resizeStorage):
2:22 AM Changeset in webkit [20785] by mjs
  • 3 edits in branches/js-collector-tweaks/JavaScriptCore

Not reviewed, experimental change.

  • fix build issue with last change


  • kjs/function.h:
  • kjs/function.cpp: (KJS::ActivationImp::createArgumentsObject):
1:51 AM Changeset in webkit [23233] by aroben
  • 12 edits
    1 move
    2 adds in branches/WindowsMerge/WebKitWin

Reviewed by Oliver.

<rdar://problem/4769828> Web Inspector

  • WebInspector/WebInspector.cpp: Renamed from WebInspector.m. Ported Mac code. Some parts are left commented out to aid later implementation.
  • WebInspector/WebInspector.h: Ditto.
1:48 AM Changeset in webkit [20784] by mjs
  • 6 edits in branches/js-collector-tweaks/JavaScriptCore

Not reviewed, experimental change.


  • discard the arguments List for an ActivationImp when the corresponding Context is destroyed (1.7% speedup)

Based an idea by Christopher E. Hyde <​C.Hyde@parableuk.force9.co.uk>. His patch to do
this also had many other List changes and I found this much simpler subset of the changes
was actually a hair faster.


This optimization is valid because the arguments list is only kept around to
lazily make the arguments object. If it's not made by the time the function
exits, it never will be, since any function that captures the continuation will
have its own local arguments variable in scope.


Besides the 1.7% speed improvement, it shrinks List by 4 bytes
(which in turn shrinks ActivationImp by 4 bytes).


  • kjs/Context.cpp: (KJS::Context::~Context): Clear the activation's arguments list.
  • kjs/function.cpp: (KJS::ActivationImp::ActivationImp): Adjusted for list changes. (KJS::ActivationImp::mark): No need to mark, lists are always protected (this doesn't cause a ref-cycle for reasons stated above). (KJS::ActivationImp::createArgumentsObject): Clear arguments list.
  • kjs/function.h:
  • kjs/list.cpp: (KJS::List::List): No more needsMarking boolean (KJS::List::operator=): ditto
  • kjs/list.h: (KJS::List::List): ditto (KJS::List::reset): ditto (KJS::List::deref): ditto
Note: See TracTimeline for information about the timeline view.