⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 12, 2007:

11:38 PM Changeset in webkit [20868] by oliver
  • 2 edits in trunk/WebCore

2007-04-12 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

This fixes <rdar://problem/5060766> -- Frameset with
an empty frame crashes due to null document. Debug
builds hit the frame->document() assertion in
EventHandler::prepareMouseEvent

This null check seems necessary now, having run through
all the logic on the path to this crash it appears that
we can't avoid this null check.

  • page/EventHandler.cpp: (WebCore::EventHandler::updateDragAndDrop):
9:32 PM Changeset in webkit [20867] by ggaren
  • 13 edits
    4 adds in trunk

JavaScriptCore:

Reviewed by Darin Adler.

​http://bugs.webkit.org/show_bug.cgi?id=13029
rdar://problem/4994849
Bug 13029: Permit NPAPI plug-ins to see HTTP response headers.
This doesn't actually change JavaScriptCore, but that's where npapi.h is.

  • bindings/npapi.h: Add headers member to NPStream struct. Also increase NP_VERSION_MINOR to 18. Increasing to >= 17 allows plug-ins to safely detect whether to look for NPStream::headers. Increasing from 17 to 18 reflects presence of NPObject enumeration, which was added in a prior patch, and which has been agreed to constitute version 18 by the plugin-futures list. Also add other missing bits of npapi.h to catch up from 14 to 18. This includes features that are not implemented in WebKit, but those are safely stubbed.

LayoutTests:

Reviewed by Darin Adler.

​http://bugs.webkit.org/show_bug.cgi?id=13029
rdar://problem/4994849
Bug 13029: Permit NPAPI plug-ins to see HTTP response headers.

  • http/tests/plugins/npapi-response-headers-expected.txt: Added.
  • http/tests/plugins/npapi-response-headers.html: Added.
  • http/tests/plugins/resources/load-me-1.txt: Added.
  • http/tests/plugins/resources/load-me-2.txt: Added.

WebKit:

Reviewed by Darin Adler.

​http://bugs.webkit.org/show_bug.cgi?id=13029
rdar://problem/4994849
Bug 13029: Permit NPAPI plug-ins to see HTTP response headers.

  • Plugins/WebBaseNetscapePluginStream.h: declarations.
  • Plugins/WebBaseNetscapePluginStream.mm: main implementation. (-[WebBaseNetscapePluginStream dealloc]): cleanup. (-[WebBaseNetscapePluginStream finalize]): cleanup. (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]): Pass headers along. (-[WebBaseNetscapePluginStream startStreamWithResponse:]): Main work is here. Extract headers from NSHTTPURLResponse object into a byte sequence. See comments here about how it would be nice to have low-level access to the HTTP response. (-[WebBaseNetscapePluginStream _destroyStream]): cleanup.
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Conform to new startStream params. Not applicable here, pass nil.

WebKitTools:

Reviewed by Darin Adler.

​http://bugs.webkit.org/show_bug.cgi?id=13029
rdar://problem/4994849
Bug 13029: Permit NPAPI plug-ins to see HTTP response headers.
Changes in WebKitTools are only for the NPAPI test plugin.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: main test logic. (pluginInvoke): support null window argument for NPStream creation. (pluginAllocate): initialization. (pluginDeallocate): cleanup. (handleCallback): add second JS callback arg: header dump. (notifyStream): added; hook from NPP_NewStream to record headers.
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: declarations.
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.c: call new header hook. (NPP_NewStream): call new header hook.
9:15 PM Changeset in webkit [23272] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests
  • win/Skipped: Added a pre-existing radar reference.
9:05 PM Changeset in webkit [23271] by sfalken
  • 4 edits in branches/WindowsMerge/WebKitWin

2007-04-12 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Geoff, Adam.


Changes required for search history content.

  • Interfaces/IWebFramePrivate.idl:
  • WebFrame.cpp: (WebFrame::isFrameSet): Added (WebFrame::string): Added
  • WebFrame.h:
8:47 PM Changeset in webkit [23270] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests
  • win/Skipped: Filed some more bugs.
6:10 PM Changeset in webkit [20866] by justing
  • 3 edits
    16 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/5131716>
Clicking just before a ToDo doesn't put the caret before the ToDo


  • editing/selection/5131716-1-expected.checksum: Added.
  • editing/selection/5131716-1-expected.png: Added.
  • editing/selection/5131716-1-expected.txt: Added.
  • editing/selection/5131716-1.html: Added.
  • editing/selection/5131716-2-expected.checksum: Added.
  • editing/selection/5131716-2-expected.png: Added.
  • editing/selection/5131716-2-expected.txt: Added.
  • editing/selection/5131716-2.html: Added.
  • editing/selection/5131716-3-expected.checksum: Added.
  • editing/selection/5131716-3-expected.png: Added.
  • editing/selection/5131716-3-expected.txt: Added.
  • editing/selection/5131716-3.html: Added.
  • editing/selection/5131716-4-expected.checksum: Added.
  • editing/selection/5131716-4-expected.png: Added.
  • editing/selection/5131716-4-expected.txt: Added.
  • editing/selection/5131716-4.html: Added.

WebCore:

Reviewed by darin


<rdar://problem/5131716>
Clicking just before a ToDo doesn't put the caret before the ToDo


  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForCoordinates): Consider clicks inside the blocks padding, instead of incorrectly sending them to the position before the block.
5:55 PM Changeset in webkit [23269] by aroben
  • 4 edits
    1 copy
    1 delete in branches/WindowsMerge

WebCoreWin:

Rubberstamped by Steve.

Removed unused file.

  • WebCore.vcproj/WebCore.sln: Removed.

WebKitWin:

Rubberstamped by Steve.

Copied WebKit.sln to WebKit.submit.sln, and added missing projects to
WebKit.sln so that opensource contributors can use it to build a
working WebKit.

  • WebKit.vcproj/WebKit.make: Changed to use WebKit.submit.sln.
  • WebKit.vcproj/WebKit.sln: Added JavaScriptCore, WebCore, DumpRenderTree projects.
  • WebKit.vcproj/WebKit.submit.sln: Added.
5:40 PM Changeset in webkit [23268] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Didn't mean to commit this.

  • WebCore.vcproj/WebCore.vcproj:
5:28 PM Changeset in webkit [23267] by aroben
  • 8 edits
    2 copies in branches/WindowsMerge
1:33 PM Changeset in webkit [23266] by kmccullo
  • 2 edits in branches/WindowsMerge/LayoutTests
  • win/Skipped: Continued to organize the list and file bugs for failures that do not have radars.
12:14 PM Changeset in webkit [20865] by brmorris
  • 2 edits in S60/trunk/WebKit

raalexan, reviewed by Yongjun

DESC: removed const from CWmlDispatcher::HeadersL
​http://bugs.webkit.org/show_bug.cgi?id=13206

12:01 PM Changeset in webkit [23265] by kmccullo
  • 2 edits in branches/WindowsMerge/LayoutTests
  • win/Skipped: Organized the Skipped. Failed tests are either filed under existing bugs, filed under new bugs, or are grouped by failure but do not have a bug yet.
10:27 AM Changeset in webkit [20864] by brmorris
  • 2 edits in S60/trunk/WebKit

borges, reviewed by spadma

DESC: related to S60 task 15118 for ccb - Fix for Symbian wk14 update related to ContentAccess class
​http://bugs.webkit.org/show_bug.cgi?id=13331

9:56 AM Changeset in webkit [20863] by beidson
  • 3 edits in trunk/WebKit

Build fix for case sensitive file systems

  • Misc/WebNSPasteboardExtras.mm:
  • WebCoreSupport/WebPasteboardHelper.mm:
9:19 AM Changeset in webkit [23264] by sullivan
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Anders

  • Interfaces/IWebUIDelegate.idl: added new PDF-related context menu items to enum to keep it in sync with WebCore
9:12 AM Changeset in webkit [20862] by sullivan
  • 8 edits
    2 adds in trunk

WebCore:

Reviewed by Anders

  • WebCore part of fix for: <rdar://problem/5128697> REGRESSION: At least one PDF context menu item isn't appearing on Leopard
  • platform/ContextMenuItem.h: (WebCore::): add two PDF-related context menu items to enum to keep it in sync with WebKit
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded): add the new context menu items to the do-nothing case of a big switch statement

WebKit:

Reviewed by Anders

  • WebKit part of fix for: <rdar://problem/5128697> REGRESSION: At least one PDF context menu item isn't appearing on Leopard
  • Misc/WebNSArrayExtras.h: Added.
  • Misc/WebNSArrayExtras.m: Added. (-[NSMutableArray _webkit_removeUselessMenuItemSeparators]): New file, includes this method to strip leading, trailing, and duplicate separators from arrays of NSMenuItems (copied from Safari)
  • WebView/WebUIDelegatePrivate.h: new MenuItemTag enum values for new PDFKit context menu items
  • WebKit.xcodeproj/project.pbxproj: updated for new files
  • WebView/WebPDFView.mm: (-[WebPDFView _anyPDFTagsFoundInMenu:]): check for new PDFKit context menu items (-[WebPDFView _menuItemsFromPDFKitForEvent:]): associate new PDFKit context menu item selectors with the new tags; skip certain selectors that correspond to menu items that WebKit already includes; remove useless menu item separators when we're done, since we might have removed arbitrarily-placed menu items
8:40 AM Changeset in webkit [20861] by thatcher
  • 2 edits in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector

Make removeChildren not a recursive removeChildren. Also resue root tree elements when building the root, to keep items that are already visible and prevent rebuilding the tree as much.

8:28 AM Changeset in webkit [20860] by hausmann
  • 2 edits in trunk/WebCore

Fixed drawing of justified text in the Qt port.

7:53 AM Changeset in webkit [20859] by yongjzha
  • 3 edits in S60/trunk/WebKit

raalexan, reviewed by Yongjun

DESC: Connection shown as Normal in secure page
​http://bugs.webkit.org/show_bug.cgi?id=13206
TSW ID: HMNN-6ZGH6J

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::CertInfo):
  • BrowserControl/src/WmlDispatcher.cpp: (CWmlDispatcher::HeadersL):

Apr 11, 2007:

11:42 PM Changeset in webkit [20858] by oliver
  • 13 edits in trunk

2007-04-11 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej.

WebCore:

Adding RetainPtr to the many global obj-c pointers we use in
C/C++ methods. This is necessary to prevent GC from collecting
globals we want to keep around.

We use RetainPtr in obj-c++ and c++ files, and CFRetain/Release in pure
obj-c.

Also made the Pasteboard::m_pasteboard a RetainPtr although it
shouldn't be necessary as the only NSPasteboard instances that
should ever be inserted are the system clipboard and dragging
pasteboard. Neither of which should ever be collected.

  • page/mac/WebCoreFrameBridge.mm: (_getPreSmartSet): (_getPostSmartSet):
  • platform/Pasteboard.h:
  • platform/graphics/mac/ColorMac.mm: (WebCore::nsColor):
  • platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
  • platform/mac/FontDataMac.mm: (WebCore::webFallbackFontFamily):
  • platform/mac/PasteboardMac.mm: (WebCore::writableTypesForURL): (WebCore::writableTypesForImage): (WebCore::Pasteboard::clear): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::writeFileWrapperAsRTFDAttachment): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment):

WebKit:

Adding RetainPtr to the many global obj-c pointers we use in
C/C++ methods. This is necessary to prevent GC from collecting
globals we want to keep around.

We use RetainPtr in obj-c++ and c++ files, and CFRetain/Release in pure
obj-c.

This fixes <rdar://problem/5058731> -- Crash in
WebCore::DragData::containsCompatibleContent due to early release
of types array

9:45 PM Changeset in webkit [20857] by bdash
  • 5 edits
    4 adds in trunk

2007-04-11 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Test: fast/forms/menulist-option-wrap.html

  • css/html4.css: Added white-space declaration for select[size="0"] and select[size="1"]. Added border-radius declaration for select.

2007-04-11 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/forms/menulist-option-wrap-expected.checksum: Added.
  • fast/forms/menulist-option-wrap-expected.png: Added.
  • fast/forms/menulist-option-wrap-expected.txt: Added.
  • fast/forms/menulist-option-wrap.html: Added.
  • fast/forms/select-empty-option-height-expected.checksum:
  • fast/forms/select-empty-option-height-expected.png:
9:28 PM Changeset in webkit [23263] by bdash
  • 3 edits in branches/WindowsMerge/WebKitWin

2007-04-12 Mark Rowe <​mrowe@apple.com>

Not reviewed. Internal counterpart to open-source r20856.

  • WebChromeClient.cpp: (WebChromeClient::createWindow): (WebChromeClient::createModalDialog):
  • WebChromeClient.h:
9:21 PM Changeset in webkit [20856] by bdash
  • 15 edits in trunk

2007-04-11 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Maciej.

Add a Frame pointer to ChromeClient methods:
​http://bugs.webkit.org/show_bug.cgi?id=13127

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow):
  • page/Chrome.cpp: (WebCore::Chrome::createWindow): (WebCore::Chrome::createModalDialog):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/ContextMenuController.cpp: (WebCore::openNewWindow):
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::createWindow): (WebCore::SVGEmptyChromeClient::createModalDialog):

2007-04-11 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Maciej.

Add a Frame pointer to ChromeClient methods:
​http://bugs.webkit.org/show_bug.cgi?id=13127

  • COM/ChromeClientWin.cpp: (ChromeClientWin::createWindow): (ChromeClientWin::createModalDialog):
  • COM/ChromeClientWin.h:
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createWindow): (WebChromeClient::createModalDialog):

2007-04-11 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Maciej.

Add a Frame pointer to ChromeClient methods:
​http://bugs.webkit.org/show_bug.cgi?id=13127

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createWindow): (WebCore::ChromeClientQt::createModalDialog):
  • WebCoreSupport/ChromeClientQt.h:
6:38 PM Changeset in webkit [20855] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Ada

<rdar://problem/5080987> - Crash in DocumentLoader::frameLoader() const

This was free nil checking lost during the ObjC -> C++ conversion

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Null check the DocumentLoader
6:25 PM Changeset in webkit [20854] by justing
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/5126166>
Deleting selection starting at before ToDo checkbox to end of line, inserts a BR in the subsequent ToDo

  • editing/deleting/5126166-expected.checksum: Added.
  • editing/deleting/5126166-expected.png: Added.
  • editing/deleting/5126166-expected.txt: Added.
  • editing/deleting/5126166.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/5126166>
Deleting selection starting at before ToDo checkbox to end of line, inserts a BR in the subsequent ToDo


If a selection ends in a table cell, we shouldn't perform
a merge after deleting that selection. We have code in
place to prevent those merges, but it failed here.


It fails because the end of the selection was [tableCell, 0],
(normally not a valid VisiblePosition, but valid here
because the table cell is empty). We prevent the merge
if the node of the position at the end of the selection
has an enclosingTableCell. Even though [tableCell, 0] has
an enclosing table cell, the node tableCell doesn't, so
the check fails.


Fixed this by changing enclosingTableCell to take in
a position, instead of a node. The other enclosing element
getters should be changed in this way as well.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): Call the new enclosingTableCell.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMerge): Ditto.
  • editing/htmlediting.cpp: (WebCore::enclosingTableCell): Take in a position instead of a node.
  • editing/htmlediting.h:
5:37 PM Changeset in webkit [23262] by aroben
  • 3 edits
    1 move
    1 add
    1 delete in branches/WindowsMerge

LayoutTestsWin:

Reviewed by Tim.

Moved the Skipped file into win/Skipped in anticipation of the opensource merge.

  • Skipped: Removed.

WebCoreWin:

Reviewed by Tim.

Get rid of FrameViewWin.cpp, since it's empty.

  • WebCore.vcproj/WebCore.vcproj:
  • bridge/win/FrameViewWin.cpp: Removed.
5:33 PM Changeset in webkit [20853] by bdash
  • 1 edit in tags/WebKit-5522.6.1/WebKit/Configurations/Version.xcconfig

Versioning.

5:32 PM Changeset in webkit [20852] by bdash
  • 1 edit in tags/WebKit-5522.6.1/WebKit/Plugins/WebBaseNetscapePluginView.mm

Merge in r20765.

5:30 PM Changeset in webkit [20851] by bdash
  • 1 copy in tags/WebKit-5522.6.1/WebKit

New tag (part 2).

5:29 PM Changeset in webkit [20850] by bdash
  • 1 add in tags/WebKit-5522.6.1

New tag (part 1).

5:11 PM Changeset in webkit [23261] by adachan
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-04-11 Ada Chan <​adachan@apple.com>

Reviewed by Steve.


<rdar://4919560> Implement reopen last window, last session

WebKitWin:

Implemented WebHistoryItem::originalURLString(). Added parameter checks to other methods.

  • WebHistoryItem.cpp: (WebHistoryItem::originalURLString): (WebHistoryItem::URLString): (WebHistoryItem::title): (WebHistoryItem::lastVisitedTimeInterval):
2:30 PM Changeset in webkit [20849] by bdash
  • 3 edits in trunk/WebKitQt

2007-04-12 Mark Rowe <​mrowe@apple.com>

Second part of Qt build fix.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::loadedFromCachedPage): (WebCore::FrameLoaderClientQt::setDocumentViewFromCachedPage): (WebCore::FrameLoaderClientQt::saveDocumentViewToCachedPage):
  • WebCoreSupport/FrameLoaderClientQt.h:
1:58 PM Changeset in webkit [20848] by bdash
  • 3 edits
    1 move in trunk/WebCore

2007-04-12 Mark Rowe <​mrowe@apple.com>

Qt build fix.

  • WebCore.pro:
  • editing/qt/EditorQt.cpp: (WebCore::Editor::markBadGrammar):
  • history/qt/CachedPageQt.cpp: Added. (WebCore::CachedPage::close):
  • history/qt/PageCacheQt.cpp: Removed.
11:22 AM Changeset in webkit [20847] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Antti

<rdar://problem/5125648> and ​http://bugs.webkit.org/show_bug.cgi?id=13326

Crash opening a link in a new window from Gmail

Problem here is that the currentHistoryItem in the new window is null. This *shouldn't* be the case,
and is the cause of a very long standing bug -
​http://bugs.webkit.org/show_bug.cgi?id=3546 - Can't go back to first page in new window opened from gmail

For now, adding a null check prevents this crash and restores the original, long standing regression


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::updateHistoryForInternalLoad): NULL check
10:58 AM Changeset in webkit [23260] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Anders.

Update for changes to Pasteboard.

  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):
10:51 AM Changeset in webkit [20846] by aroben
  • 6 edits in trunk/WebCore

Reviewed by Anders.

Made image document copying more cross-platform.

All layout tests pass.

  • editing/Editor.cpp: (WebCore::imageNodeFromImageDocument): Added. (WebCore::Editor::canCopy): Called imageNodeFromImageDocument. (WebCore::Editor::copy): Ditto. (WebCore::Editor::copyImage): Updated for changes to Pasteboard.
  • platform/Pasteboard.h: Made writeImage more general, which allowed getting rid of its second incarnation.
  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeImage): Collapsed logic from the two writeImage methods into one. (Pasteboard::writeImage): Updated for Pasteboard changes.
  • platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeImage): Ditto.
7:31 AM Changeset in webkit [20845] by thatcher
  • 1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/inspector.js

Properly reveal and select the focused node when the tree is updated.

6:54 AM Changeset in webkit [20844] by thatcher
  • 1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/inspector.js

Update the disabled state of the traverse buttons when selection changes.

6:28 AM Changeset in webkit [20843] by thatcher
  • 4 edits in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector

Use the script equality operator in almost all cases. Other various cleanup.

5:59 AM Changeset in webkit [20842] by thatcher
  • 2 edits
    1 add in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector

Move DOM and String prototype additions to utilities.js.

12:50 AM Changeset in webkit [20841] by darin
  • 2 edits in trunk/WebCore
  • css/CSSValueKeywords.in: Fix a comment.
12:28 AM Changeset in webkit [23259] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests
  • Skipped: Consolidated some failures that have the same underlying cause, and removed some tests that were duplicated in this file.
12:16 AM Changeset in webkit [20840] by thatcher
  • 2 edits
    1 add in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector

Factored out the tree outline control into a generic JavaScript class. This fixed a couple of issues with the previous implementation.

Note: See TracTimeline for information about the timeline view.