Timeline

Apr 13, 2007:

6:26 PM Changeset in webkit [20889] by ddkilzer

• 12 edits
  4 moves
  8 adds in trunk

LayoutTests:

Patch and review by hyatt. Testing and landing by ddkilzer.

<rdar://problem/5078866>
tables don't inherit text-align (in strict mode; they're not supposed to in quirks mode)

Test tables/mozilla_expected_failures/bugs/bug11384s.html progressed after this fix, so
it was moved to tables/mozilla/bugs/bug11384s.html.

• fast/css/table-text-align-quirk-expected.checksum: Added.
• fast/css/table-text-align-quirk-expected.png: Added.
• fast/css/table-text-align-quirk-expected.txt: Added.
• fast/css/table-text-align-quirk.html: Added.
• fast/css/table-text-align-strict-expected.checksum: Added.
• fast/css/table-text-align-strict-expected.png: Added.
• fast/css/table-text-align-strict-expected.txt: Added.
• fast/css/table-text-align-strict.html: Added.
• fast/table/border-collapsing/rtl-border-collapsing.html: Replaced "text-align: -khtml-center" style with "text-align: center" style.
• tables/mozilla/bugs/bug11384s-expected.checksum: Added.
• tables/mozilla/bugs/bug11384s-expected.png: Added.
• tables/mozilla/bugs/bug11384s-expected.txt: Added.
• tables/mozilla/bugs/bug11384s.html: Added.
• tables/mozilla_expected_failures/bugs/bug11384s-expected.checksum: Removed.
• tables/mozilla_expected_failures/bugs/bug11384s-expected.png: Removed.
• tables/mozilla_expected_failures/bugs/bug11384s-expected.txt: Removed.
• tables/mozilla_expected_failures/bugs/bug11384s.html: Removed.

WebCore:

Patch and review by hyatt. Testing and landing by ddkilzer.

<rdar://problem/5078866>
tables don't inherit text-align (in strict mode; they're not supposed to in quirks mode)

Test: fast/css/table-text-align-quirk.html

fast/css/table-text-align-strict.html

Previous commit (r20731) removed the wrong property from WebCore/css/html4.css. However,
when the correct property was removed, it caused tables to inherit alignment properties
from tags like <center> and <div align="center">. This is fixed in
WebCore::CSSStyleSelector::adjustRenderStyle() by special-casing tables to reset the
text-align property.

• css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForTextAlign): Renamed KHTML_CENTER, KHTML_LEFT and KHTML_RIGHT to WEBKIT_CENTER, WEBKIT_LEFT and WEBKIT_RIGHT.
• css/cssparser.cpp: (WebCore::CSSParser::parseValue): Ditto.
• css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): Tables should not support -webkit-center, -webkit-left or -webkit-right values for text-align, so reset them back to auto.
• css/html4.css: Removed "text-align: -webkit-auto;" property from tables selector. It was previously added to css/quirks.css in r20731.
• rendering/RenderBlock.cpp: (WebCore::RenderBlock::determineHorizontalPosition): Renamed KHTML_* to WEBKIT_*.
• rendering/RenderBox.cpp: (WebCore::RenderBox::calcHorizontalMargins): Ditto.
• rendering/RenderFlow.cpp: (WebCore::RenderFlow::caretRect): Ditto.
• rendering/RenderStyle.h: Ditto. (WebCore::):
• rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine): Ditto.

5:57 PM Changeset in webkit [20888] by oliver

• 2 edits in trunk/WebKit

2007-04-13 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Due to rdar://problem/5133910 -- WebArchives should not be constructed
using resource from the cache -- We may try to create a potentially
incorrect WebArchive when dragging an image multiple times.

This patch retains the assertion for invalid behaviour, but adds a
branch to make sure we don't try to do anything with the WebArchive
in release builds.

• Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]):

5:47 PM Changeset in webkit [23281] by aroben

• 3 edits in branches/WindowsMerge/WebCore

Reviewed by Tim.

Sync our config.h with the OpenSource version so we can merge ours in
later.

• config.h: Added #defines from the OpenSource version, moved Windows-specific defines inside #if PLATFORM(WIN[_OS]), and got rid of assert.h
• platform/win/CursorWin.cpp: (WebCore::Cursor::Cursor): Use ASSERT instead of assert.

5:15 PM Changeset in webkit [23280] by kmccullo

• 2 edits in branches/WindowsMerge/LayoutTests

• win/Skipped: Continued filtering.

3:45 PM Changeset in webkit [20887] by bdash

• 1 copy in tags/Safari-4522.5.5/WebKit

New tag (part 2).

3:45 PM Changeset in webkit [20886] by bdash

• 1 add in tags/Safari-4522.5.5

New tag (part 1).

3:44 PM Changeset in webkit [20885] by bdash

• 1 edit in branches/Safari-522/WebKit/Configurations/Version.xcconfig

Versioning.

3:42 PM Changeset in webkit [20884] by bdash

• 2 edits in branches/Safari-522/WebKit

Merge r20869.

2:56 PM Changeset in webkit [23279] by beidson

• 1 edit in branches/WindowsMerge/LayoutTests/win/Skipped

Updated to reflect new location of the history test which is now http

2:47 PM Changeset in webkit [20883] by beidson

• 1 edit
  4 adds
  1 delete in trunk/LayoutTests

Reviewed by a sanity check

My layout test *has* to be http, since dumping history in DRT with hard coded file paths
will never match up to expected results across machines.

Lame

• history/new-window-redirect-history-expected.txt: Removed.
• history/new-window-redirect-history.html: Removed.
• history/resources/redirect-1.html: Removed.
• history/resources/redirect-2.html: Removed.
• http/tests/navigation/new-window-redirect-history-expected.txt: Added.
• http/tests/navigation/new-window-redirect-history.html: Added.
• http/tests/navigation/resources/redirect-1.html: Added.
• http/tests/navigation/resources/redirect-2.html: Added.

2:45 PM Changeset in webkit [23278] by kmccullo

• 2 edits in branches/WindowsMerge/LayoutTests

• win/Skipped: Re-enabled the tests that are actual failures.

2:33 PM Changeset in webkit [20882] by thatcher

• 1 copy in tags/Safari-4522.5.4/WebKit

New tag (part 2).

2:32 PM Changeset in webkit [20881] by thatcher

• 1 add in tags/Safari-4522.5.4

New tag (part 1).

2:27 PM Changeset in webkit [20880] by thatcher

• 4 edits in branches/Safari-522

Versioning.

1:48 PM Changeset in webkit [23277] by beidson

• 1 edit in branches/WindowsMerge/LayoutTests/win/Skipped

Added history/new-window-redirect-history.html to the skipped file pending addition of multiple windows to DRT

1:39 PM Changeset in webkit [23276] by aroben

• 2 edits
  1 delete in branches/WindowsMerge/WebCore

Rubberstamped by Tim.

Removed the loader/win directory since it only contains empty files.

• WebCore.vcproj/WebCore.vcproj: Removed empty files.
• loader/win/FrameLoaderWin.cpp: Removed.
• loader/win/ResourceLoaderWin.cpp: Removed.

1:34 PM Changeset in webkit [20879] by aroben

• 2 edits in trunk/WebKitTools

Rubberstamped by Anders.

• DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: #include stdio.h so that snprintf is defined.

1:31 PM Changeset in webkit [23275] by andersca

• 2 edits in branches/WindowsMerge/WebKitTools

Fix the release build too!

• DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj:

1:28 PM Changeset in webkit [20878] by beidson

• 4 edits
  6 adds in trunk

LayoutTests:

Reviewed by Geoose

<rdar://problem/4664154> and ​http://bugs.webkit.org/show_bug.cgi?id=3546

Layout test that covers opening an empty new window, then starting to navigate around in it

• history/new-window-redirect-history-expected.txt: Added.
• history/new-window-redirect-history.html: Added.
• history/resources/redirect-1.html: Added.
• history/resources/redirect-2.html: Added.

WebCore:

Reviewed by Black Sheep

<rdar://problem/4664154> and ​http://bugs.webkit.org/show_bug.cgi?id=3546

When you click on a link that opens in a new window from within gmail, they first create a new window
with an empty URL, then immediately document.write() into the window to schedule a redirect.

Since the initial page doesn't have a URL associated with it, a history item never gets created. The
reasonable solution? To actually create the history item after the redirect (in updateHistoryForInternalLoad)

• loader/FrameLoader.cpp: (WebCore::FrameLoader::addHistoryForCurrentLocation): Updates global and B/F history with a new history item (WebCore::FrameLoader::updateHistoryForStandardLoad): Call addHistoryForCurrentLocation (WebCore::FrameLoader::updateHistoryForInternalLoad): Call addHistoryForCurrentLocation if there is not already a current history item
• loader/FrameLoader.h:

1:09 PM Changeset in webkit [20877] by beidson

• 2 edits in trunk/WebKitTools

Reviewed by Anders

Add the ability to dump the back/forward history of all windows open at the end of a test

• DumpRenderTree/DumpRenderTree.m: (dumpBackForwardListForWebView): Dump B/F list for the given WebView (dump): Call dumpBackForwardListForWebView for each WebView open after the test

12:54 PM Changeset in webkit [20876] by andersca

• 4 edits in trunk

LayoutTests:

Reviewed by Brady.

• plugins/open-and-close-window-with-plugin.html: Manage open windows manually for this test.

WebKitTools:

Reviewed by Brady.

By default, close any windows that have been opened during a test. This can be overridden by
calling setCloseRemainingWindowsWhenComplete(false).

Change the windows set to an array so we can gurantee the enumeration order.

• DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setCloseRemainingWindowsWhenComplete:]): (runTest): (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): (-[DumpRenderTreeWindow dealloc]):

12:14 PM Changeset in webkit [20875] by thatcher

• 2 edits in branches/Safari-522/WebKit

Merge fix from r20874.

12:13 PM Changeset in webkit [20874] by thatcher

• 2 edits in trunk/WebKit

Reviewed by Dave Harrison.

<rdar://problem/5132727> Soho Mail build fails because of renamed SPI

• WebView/WebUIDelegatePrivate.h: define WebMenuItemTagSearchInGoogle as OldWebMenuItemTagSearchWeb

12:12 PM Changeset in webkit [20873] by ggaren

• 2 edits in trunk/WebKitTools

Build fix.

• DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (handleCallback): Explicitly cast the void* returned by malloc.

11:42 AM Changeset in webkit [23274] by kmccullo

• 2 edits in branches/WindowsMerge/LayoutTests

• win/Skipped: Commented out some that may not be actually failing.

10:54 AM Changeset in webkit [23273] by andersca

• 2 edits in branches/WindowsMerge/WebKitTools

Fix build.

• DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: #define snprintf to be _snprintf and dd two defines to disable warnings for strdup and _snprintf.

10:02 AM Changeset in webkit [20872] by thatcher

• 2 edits in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector

Share more code between the TreeOutline and TreeElement classes. Remember the expanded state for elements when the tree is rebuilt with the same represented objects. Toggling ignore whitespace correct repopulates the tree again.

9:59 AM Changeset in webkit [20871] by sfalken

• 2 edits in branches/Safari-522/WebCore

Merged fix from r20847

9:54 AM BuildingQtOnLinux edited by ed@uping.com

Updating dependencies (diff)

5:59 AM Changeset in webkit [20870] by zbujtas

• 2 edits in S60/trunk/WebCore

anapatil <​anand.1.patil@nokia.com>

Reviewed by ​zbujtas@gmail.com
DESC: Fix for : Browser - extra content seen when browsing www.kartta.ouka.fi

​http://bugs.webkit.org/show_bug.cgi?id=13308
TSW ID : MRAA-6X4FVQ

WARNING: NO TEST CASES ADDED OR CHANGED

• khtml/rendering/render_frames.cpp:

12:56 AM Changeset in webkit [20869] by bdash

• 2 edits in trunk/WebKit

2007-04-13 Mark Rowe <​mrowe@apple.com>

Reviewed by Oliver.

<rdar://problem/5130686> Using WebPreferencesPrivate.h requires modifying framework search path

• WebView/WebPreferencesPrivate.h: Remove unneeded #ifdef.

Apr 12, 2007:

11:38 PM Changeset in webkit [20868] by oliver

• 2 edits in trunk/WebCore

2007-04-12 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

This fixes <rdar://problem/5060766> -- Frameset with
an empty frame crashes due to null document. Debug
builds hit the frame->document() assertion in
EventHandler::prepareMouseEvent

This null check seems necessary now, having run through
all the logic on the path to this crash it appears that
we can't avoid this null check.

• page/EventHandler.cpp: (WebCore::EventHandler::updateDragAndDrop):

9:32 PM Changeset in webkit [20867] by ggaren

• 13 edits
  4 adds in trunk

JavaScriptCore:

Reviewed by Darin Adler.

​http://bugs.webkit.org/show_bug.cgi?id=13029
rdar://problem/4994849
Bug 13029: Permit NPAPI plug-ins to see HTTP response headers.
This doesn't actually change JavaScriptCore, but that's where npapi.h is.

• bindings/npapi.h: Add headers member to NPStream struct. Also increase NP_VERSION_MINOR to 18. Increasing to >= 17 allows plug-ins to safely detect whether to look for NPStream::headers. Increasing from 17 to 18 reflects presence of NPObject enumeration, which was added in a prior patch, and which has been agreed to constitute version 18 by the plugin-futures list. Also add other missing bits of npapi.h to catch up from 14 to 18. This includes features that are not implemented in WebKit, but those are safely stubbed.

LayoutTests:

Reviewed by Darin Adler.

​http://bugs.webkit.org/show_bug.cgi?id=13029
rdar://problem/4994849
Bug 13029: Permit NPAPI plug-ins to see HTTP response headers.

• http/tests/plugins/npapi-response-headers-expected.txt: Added.
• http/tests/plugins/npapi-response-headers.html: Added.
• http/tests/plugins/resources/load-me-1.txt: Added.
• http/tests/plugins/resources/load-me-2.txt: Added.

WebKit:

Reviewed by Darin Adler.

​http://bugs.webkit.org/show_bug.cgi?id=13029
rdar://problem/4994849
Bug 13029: Permit NPAPI plug-ins to see HTTP response headers.

• Plugins/WebBaseNetscapePluginStream.h: declarations.
• Plugins/WebBaseNetscapePluginStream.mm: main implementation. (-[WebBaseNetscapePluginStream dealloc]): cleanup. (-[WebBaseNetscapePluginStream finalize]): cleanup. (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]): Pass headers along. (-[WebBaseNetscapePluginStream startStreamWithResponse:]): Main work is here. Extract headers from NSHTTPURLResponse object into a byte sequence. See comments here about how it would be nice to have low-level access to the HTTP response. (-[WebBaseNetscapePluginStream _destroyStream]): cleanup.
• Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Conform to new startStream params. Not applicable here, pass nil.

WebKitTools:

Reviewed by Darin Adler.

​http://bugs.webkit.org/show_bug.cgi?id=13029
rdar://problem/4994849
Bug 13029: Permit NPAPI plug-ins to see HTTP response headers.
Changes in WebKitTools are only for the NPAPI test plugin.

• DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: main test logic. (pluginInvoke): support null window argument for NPStream creation. (pluginAllocate): initialization. (pluginDeallocate): cleanup. (handleCallback): add second JS callback arg: header dump. (notifyStream): added; hook from NPP_NewStream to record headers.
• DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: declarations.
• DumpRenderTree/TestNetscapePlugIn.subproj/main.c: call new header hook. (NPP_NewStream): call new header hook.

9:15 PM Changeset in webkit [23272] by aroben

• 2 edits in branches/WindowsMerge/LayoutTests

• win/Skipped: Added a pre-existing radar reference.

9:05 PM Changeset in webkit [23271] by sfalken

• 4 edits in branches/WindowsMerge/WebKitWin

2007-04-12 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Geoff, Adam.

Changes required for search history content.

• Interfaces/IWebFramePrivate.idl:
• WebFrame.cpp: (WebFrame::isFrameSet): Added (WebFrame::string): Added
• WebFrame.h:

8:47 PM Changeset in webkit [23270] by aroben

• 2 edits in branches/WindowsMerge/LayoutTests

• win/Skipped: Filed some more bugs.

6:10 PM Changeset in webkit [20866] by justing

• 3 edits
  16 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/5131716>
Clicking just before a ToDo doesn't put the caret before the ToDo

• editing/selection/5131716-1-expected.checksum: Added.
• editing/selection/5131716-1-expected.png: Added.
• editing/selection/5131716-1-expected.txt: Added.
• editing/selection/5131716-1.html: Added.
• editing/selection/5131716-2-expected.checksum: Added.
• editing/selection/5131716-2-expected.png: Added.
• editing/selection/5131716-2-expected.txt: Added.
• editing/selection/5131716-2.html: Added.
• editing/selection/5131716-3-expected.checksum: Added.
• editing/selection/5131716-3-expected.png: Added.
• editing/selection/5131716-3-expected.txt: Added.
• editing/selection/5131716-3.html: Added.
• editing/selection/5131716-4-expected.checksum: Added.
• editing/selection/5131716-4-expected.png: Added.
• editing/selection/5131716-4-expected.txt: Added.
• editing/selection/5131716-4.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/5131716>
Clicking just before a ToDo doesn't put the caret before the ToDo

• rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForCoordinates): Consider clicks inside the blocks padding, instead of incorrectly sending them to the position before the block.

5:55 PM Changeset in webkit [23269] by aroben

• 4 edits
  1 copy
  1 delete in branches/WindowsMerge

WebCoreWin:

Rubberstamped by Steve.

Removed unused file.

• WebCore.vcproj/WebCore.sln: Removed.

WebKitWin:

Rubberstamped by Steve.

Copied WebKit.sln to WebKit.submit.sln, and added missing projects to
WebKit.sln so that opensource contributors can use it to build a
working WebKit.

• WebKit.vcproj/WebKit.make: Changed to use WebKit.submit.sln.
• WebKit.vcproj/WebKit.sln: Added JavaScriptCore, WebCore, DumpRenderTree projects.
• WebKit.vcproj/WebKit.submit.sln: Added.

5:40 PM Changeset in webkit [23268] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Didn't mean to commit this.

• WebCore.vcproj/WebCore.vcproj:

5:28 PM Changeset in webkit [23267] by aroben

• 8 edits
  2 copies in branches/WindowsMerge

1:33 PM Changeset in webkit [23266] by kmccullo

• 2 edits in branches/WindowsMerge/LayoutTests

• win/Skipped: Continued to organize the list and file bugs for failures that do not have radars.

12:14 PM Changeset in webkit [20865] by brmorris

• 2 edits in S60/trunk/WebKit

raalexan, reviewed by Yongjun

DESC: removed const from CWmlDispatcher::HeadersL
​http://bugs.webkit.org/show_bug.cgi?id=13206

12:01 PM Changeset in webkit [23265] by kmccullo

• 2 edits in branches/WindowsMerge/LayoutTests

• win/Skipped: Organized the Skipped. Failed tests are either filed under existing bugs, filed under new bugs, or are grouped by failure but do not have a bug yet.

10:27 AM Changeset in webkit [20864] by brmorris

• 2 edits in S60/trunk/WebKit

borges, reviewed by spadma

DESC: related to S60 task 15118 for ccb - Fix for Symbian wk14 update related to ContentAccess class
​http://bugs.webkit.org/show_bug.cgi?id=13331

9:56 AM Changeset in webkit [20863] by beidson

• 3 edits in trunk/WebKit

Build fix for case sensitive file systems

• Misc/WebNSPasteboardExtras.mm:
• WebCoreSupport/WebPasteboardHelper.mm:

9:19 AM Changeset in webkit [23264] by sullivan

• 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Anders

• Interfaces/IWebUIDelegate.idl: added new PDF-related context menu items to enum to keep it in sync with WebCore

9:12 AM Changeset in webkit [20862] by sullivan

• 8 edits
  2 adds in trunk

WebCore:

Reviewed by Anders

• WebCore part of fix for: <rdar://problem/5128697> REGRESSION: At least one PDF context menu item isn't appearing on Leopard

• platform/ContextMenuItem.h: (WebCore::): add two PDF-related context menu items to enum to keep it in sync with WebKit

• platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded): add the new context menu items to the do-nothing case of a big switch statement

WebKit:

Reviewed by Anders

• WebKit part of fix for: <rdar://problem/5128697> REGRESSION: At least one PDF context menu item isn't appearing on Leopard

• Misc/WebNSArrayExtras.h: Added.
• Misc/WebNSArrayExtras.m: Added. (-[NSMutableArray _webkit_removeUselessMenuItemSeparators]): New file, includes this method to strip leading, trailing, and duplicate separators from arrays of NSMenuItems (copied from Safari)

• WebView/WebUIDelegatePrivate.h: new MenuItemTag enum values for new PDFKit context menu items

• WebKit.xcodeproj/project.pbxproj: updated for new files

• WebView/WebPDFView.mm: (-[WebPDFView _anyPDFTagsFoundInMenu:]): check for new PDFKit context menu items (-[WebPDFView _menuItemsFromPDFKitForEvent:]): associate new PDFKit context menu item selectors with the new tags; skip certain selectors that correspond to menu items that WebKit already includes; remove useless menu item separators when we're done, since we might have removed arbitrarily-placed menu items

8:40 AM Changeset in webkit [20861] by thatcher

• 2 edits in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector

Make removeChildren not a recursive removeChildren. Also resue root tree elements when building the root, to keep items that are already visible and prevent rebuilding the tree as much.

8:28 AM Changeset in webkit [20860] by hausmann

• 2 edits in trunk/WebCore

Fixed drawing of justified text in the Qt port.

7:53 AM Changeset in webkit [20859] by yongjzha

• 3 edits in S60/trunk/WebKit

raalexan, reviewed by Yongjun

DESC: Connection shown as Normal in secure page
​http://bugs.webkit.org/show_bug.cgi?id=13206
TSW ID: HMNN-6ZGH6J

• BrowserControl/src/BrCtl.cpp: (CBrCtl::CertInfo):
• BrowserControl/src/WmlDispatcher.cpp: (CWmlDispatcher::HeadersL):