Context Navigation

fast/css/table-text-align-quirk-expected.checksum: Added.
fast/css/table-text-align-quirk-expected.png: Added.
fast/css/table-text-align-quirk-expected.txt: Added.
fast/css/table-text-align-quirk.html: Added.
fast/css/table-text-align-strict-expected.checksum: Added.
fast/css/table-text-align-strict-expected.png: Added.
fast/css/table-text-align-strict-expected.txt: Added.
fast/css/table-text-align-strict.html: Added.
fast/table/border-collapsing/rtl-border-collapsing.html: Replaced "text-align: -khtml-center" style with "text-align: center" style.
tables/mozilla/bugs/bug11384s-expected.checksum: Added.
tables/mozilla/bugs/bug11384s-expected.png: Added.
tables/mozilla/bugs/bug11384s-expected.txt: Added.
tables/mozilla/bugs/bug11384s.html: Added.
tables/mozilla_expected_failures/bugs/bug11384s-expected.checksum: Removed.
tables/mozilla_expected_failures/bugs/bug11384s-expected.png: Removed.
tables/mozilla_expected_failures/bugs/bug11384s-expected.txt: Removed.
tables/mozilla_expected_failures/bugs/bug11384s.html: Removed.

WebCore:

Patch and review by hyatt. Testing and landing by ddkilzer.

<rdar://problem/5078866>
tables don't inherit text-align (in strict mode; they're not supposed to in quirks mode)

Test: fast/css/table-text-align-quirk.html

fast/css/table-text-align-strict.html

Previous commit (r20731) removed the wrong property from WebCore/css/html4.css. However,
when the correct property was removed, it caused tables to inherit alignment properties
from tags like <center> and <div align="center">. This is fixed in
WebCore::CSSStyleSelector::adjustRenderStyle() by special-casing tables to reset the
text-align property.

css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForTextAlign): Renamed KHTML_CENTER, KHTML_LEFT and KHTML_RIGHT to WEBKIT_CENTER, WEBKIT_LEFT and WEBKIT_RIGHT.
css/cssparser.cpp: (WebCore::CSSParser::parseValue): Ditto.
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): Tables should not support -webkit-center, -webkit-left or -webkit-right values for text-align, so reset them back to auto.
css/html4.css: Removed "text-align: -webkit-auto;" property from tables selector. It was previously added to css/quirks.css in r20731.
rendering/RenderBlock.cpp: (WebCore::RenderBlock::determineHorizontalPosition): Renamed KHTML_* to WEBKIT_*.
rendering/RenderBox.cpp: (WebCore::RenderBox::calcHorizontalMargins): Ditto.
rendering/RenderFlow.cpp: (WebCore::RenderFlow::caretRect): Ditto.
rendering/RenderStyle.h: Ditto. (WebCore::):
rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine): Ditto.

5:57 PM Changeset in webkit [20888] by oliver

2 edits in trunk/WebKit

2007-04-13 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

Due to rdar://problem/5133910 -- WebArchives should not be constructed
using resource from the cache -- We may try to create a potentially
incorrect WebArchive when dragging an image multiple times.

This patch retains the assertion for invalid behaviour, but adds a
branch to make sure we don't try to do anything with the WebArchive
in release builds.

Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]):

5:47 PM Changeset in webkit [23281] by aroben

3 edits in branches/WindowsMerge/WebCore

Reviewed by Tim.

Sync our config.h with the OpenSource version so we can merge ours in
later.

config.h: Added #defines from the OpenSource version, moved Windows-specific defines inside #if PLATFORM(WIN[_OS]), and got rid of assert.h
platform/win/CursorWin.cpp: (WebCore::Cursor::Cursor): Use ASSERT instead of assert.

5:15 PM Changeset in webkit [23280] by kmccullo

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Continued filtering.

3:45 PM Changeset in webkit [20887] by bdash

1 copy in tags/Safari-4522.5.5/WebKit

New tag (part 2).

3:45 PM Changeset in webkit [20886] by bdash

1 add in tags/Safari-4522.5.5

New tag (part 1).

3:44 PM Changeset in webkit [20885] by bdash

1 edit in branches/Safari-522/WebKit/Configurations/Version.xcconfig

Versioning.

3:42 PM Changeset in webkit [20884] by bdash

2 edits in branches/Safari-522/WebKit

Merge r20869.

2:56 PM Changeset in webkit [23279] by beidson

1 edit in branches/WindowsMerge/LayoutTests/win/Skipped

Updated to reflect new location of the history test which is now http

2:47 PM Changeset in webkit [20883] by beidson

1 edit
4 adds
1 delete in trunk/LayoutTests

Reviewed by a sanity check

My layout test *has* to be http, since dumping history in DRT with hard coded file paths
will never match up to expected results across machines.

Lame

history/new-window-redirect-history-expected.txt: Removed.
history/new-window-redirect-history.html: Removed.
history/resources/redirect-1.html: Removed.
history/resources/redirect-2.html: Removed.
http/tests/navigation/new-window-redirect-history-expected.txt: Added.
http/tests/navigation/new-window-redirect-history.html: Added.
http/tests/navigation/resources/redirect-1.html: Added.
http/tests/navigation/resources/redirect-2.html: Added.

2:45 PM Changeset in webkit [23278] by kmccullo

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Re-enabled the tests that are actual failures.

2:33 PM Changeset in webkit [20882] by thatcher

1 copy in tags/Safari-4522.5.4/WebKit

New tag (part 2).

2:32 PM Changeset in webkit [20881] by thatcher

1 add in tags/Safari-4522.5.4

New tag (part 1).

2:27 PM Changeset in webkit [20880] by thatcher

4 edits in branches/Safari-522

Versioning.

1:48 PM Changeset in webkit [23277] by beidson

1 edit in branches/WindowsMerge/LayoutTests/win/Skipped

Added history/new-window-redirect-history.html to the skipped file pending addition of multiple windows to DRT

1:39 PM Changeset in webkit [23276] by aroben

2 edits
1 delete in branches/WindowsMerge/WebCore

Rubberstamped by Tim.

Removed the loader/win directory since it only contains empty files.

WebCore.vcproj/WebCore.vcproj: Removed empty files.
loader/win/FrameLoaderWin.cpp: Removed.
loader/win/ResourceLoaderWin.cpp: Removed.

1:34 PM Changeset in webkit [20879] by aroben

2 edits in trunk/WebKitTools

Rubberstamped by Anders.

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: #include stdio.h so that snprintf is defined.

1:31 PM Changeset in webkit [23275] by andersca

2 edits in branches/WindowsMerge/WebKitTools

Fix the release build too!

DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj:

1:28 PM Changeset in webkit [20878] by beidson

4 edits
6 adds in trunk

LayoutTests:

Reviewed by Geoose

<rdar://problem/4664154> and http://bugs.webkit.org/show_bug.cgi?id=3546

Layout test that covers opening an empty new window, then starting to navigate around in it

history/new-window-redirect-history-expected.txt: Added.
history/new-window-redirect-history.html: Added.
history/resources/redirect-1.html: Added.
history/resources/redirect-2.html: Added.

WebCore:

Reviewed by Black Sheep

<rdar://problem/4664154> and http://bugs.webkit.org/show_bug.cgi?id=3546

When you click on a link that opens in a new window from within gmail, they first create a new window
with an empty URL, then immediately document.write() into the window to schedule a redirect.

Since the initial page doesn't have a URL associated with it, a history item never gets created. The
reasonable solution? To actually create the history item after the redirect (in updateHistoryForInternalLoad)

loader/FrameLoader.cpp: (WebCore::FrameLoader::addHistoryForCurrentLocation): Updates global and B/F history with a new history item (WebCore::FrameLoader::updateHistoryForStandardLoad): Call addHistoryForCurrentLocation (WebCore::FrameLoader::updateHistoryForInternalLoad): Call addHistoryForCurrentLocation if there is not already a current history item
loader/FrameLoader.h:

1:09 PM Changeset in webkit [20877] by beidson

2 edits in trunk/WebKitTools

Reviewed by Anders

Add the ability to dump the back/forward history of all windows open at the end of a test

DumpRenderTree/DumpRenderTree.m: (dumpBackForwardListForWebView): Dump B/F list for the given WebView (dump): Call dumpBackForwardListForWebView for each WebView open after the test

12:54 PM Changeset in webkit [20876] by andersca

4 edits in trunk

LayoutTests:

Reviewed by Brady.

plugins/open-and-close-window-with-plugin.html: Manage open windows manually for this test.

WebKitTools:

Reviewed by Brady.

By default, close any windows that have been opened during a test. This can be overridden by
calling setCloseRemainingWindowsWhenComplete(false).

Change the windows set to an array so we can gurantee the enumeration order.

DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setCloseRemainingWindowsWhenComplete:]): (runTest): (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): (-[DumpRenderTreeWindow dealloc]):

12:14 PM Changeset in webkit [20875] by thatcher

2 edits in branches/Safari-522/WebKit

Merge fix from r20874.

12:13 PM Changeset in webkit [20874] by thatcher

2 edits in trunk/WebKit

Reviewed by Dave Harrison.

<rdar://problem/5132727> Soho Mail build fails because of renamed SPI

WebView/WebUIDelegatePrivate.h: define WebMenuItemTagSearchInGoogle as OldWebMenuItemTagSearchWeb

12:12 PM Changeset in webkit [20873] by ggaren

2 edits in trunk/WebKitTools

Build fix.

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (handleCallback): Explicitly cast the void* returned by malloc.

11:42 AM Changeset in webkit [23274] by kmccullo

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Commented out some that may not be actually failing.

10:54 AM Changeset in webkit [23273] by andersca

2 edits in branches/WindowsMerge/WebKitTools

Fix build.

DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: #define snprintf to be _snprintf and dd two defines to disable warnings for strdup and _snprintf.

10:02 AM Changeset in webkit [20872] by thatcher

2 edits in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector

Share more code between the TreeOutline and TreeElement classes. Remember the expanded state for elements when the tree is rebuilt with the same represented objects. Toggling ignore whitespace correct repopulates the tree again.

9:59 AM Changeset in webkit [20871] by sfalken

2 edits in branches/Safari-522/WebCore

Merged fix from r20847

9:54 AM BuildingQtOnLinux edited by ed@uping.com

Updating dependencies (diff)

5:59 AM Changeset in webkit [20870] by zbujtas

2 edits in S60/trunk/WebCore

anapatil <anand.1.patil@nokia.com>

Reviewed by zbujtas@gmail.com
DESC: Fix for : Browser - extra content seen when browsing www.kartta.ouka.fi

http://bugs.webkit.org/show_bug.cgi?id=13308
TSW ID : MRAA-6X4FVQ

WARNING: NO TEST CASES ADDED OR CHANGED

khtml/rendering/render_frames.cpp:

12:56 AM Changeset in webkit [20869] by bdash

2 edits in trunk/WebKit

2007-04-13 Mark Rowe <mrowe@apple.com>

Reviewed by Oliver.

<rdar://problem/5130686> Using WebPreferencesPrivate.h requires modifying framework search path

WebView/WebPreferencesPrivate.h: Remove unneeded #ifdef.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed