Context Navigation

WebDragClient.cpp: Removed unused header (atlsafe.h)
WebKit.vcproj/WebKit.rc: Removed afxres.h and related code
WebKit.vcproj/WebKit.sln: Don't use a sln folder - they aren't supported by express
WebKit.vcproj/WebKit.vcproj: Add explicit lib references for Windows system libs (VS express doesn't include these)
WebView.cpp: Removed unused header (atldef.h)

2:06 PM Changeset in webkit [20912] by justing

4 edits
4 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/5134759>
GMail Editor: Hang after pasting underlined text multiple times

Demonstrates the bug:

editing/pasteboard/5134759-expected.checksum: Added.
editing/pasteboard/5134759-expected.png: Added.
editing/pasteboard/5134759-expected.txt: Added.
editing/pasteboard/5134759.html: Added.

A unnecessary extra space was added to an element's
inline style declaration, because of the way cssText behaves:

editing/pasteboard/paste-table-002-expected.txt:

WebCore:

Reviewed by darin

<rdar://problem/5134759>
GMail Editor: Hang after pasting underlined text multiple times

The moveParagraphs call that ReplaceSelectionCommand
performs must receive only inline content from createMarkup,
or else it will result in another call to moveParagraphs
when it performs the move, resulting in infinite recursion.

editing/markup.cpp: (WebCore::startMarkup): We were only converting a block to an inline if it had an inline style declaration or styles coming from matched rules. Cleaned up this code a bit by handling an element's style separately from its other attributes.

1:29 PM Changeset in webkit [20911] by spadma

5 edits in S60/trunk

2007-04-16 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by Sachin.
DESC: [S60] Browser crashes if original page is closed and user downloads something after closing in 3.1m.
Fix: Make CBrCtlDownloadObserver a singleton class to support multiple windows download.
http://bugs.webkit.org/show_bug.cgi?id=13296

BrowserControl/inc/BrCtl.h:
BrowserControl/src/BrCtl.cpp: (CBrCtl::ConstructL): (CBrCtl::~CBrCtl): (CBrCtl::SendCommandsToClient): (CBrCtl::BrCtlDownloadObserver):
BrowserView/inc/WebKitControl.h:
BrowserView/src/WebKitControl.cpp: (CStaticObjectContainer::~CStaticObjectContainer): (CStaticObjectContainer::DownloadObserver): (CStaticObjectContainer::InitializeFactoryObjectsL):

1:28 PM Changeset in webkit [20910] by spadma

5 edits in S60/branches/3.1m/WebKit

2007-04-16 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by Sachin.
DESC: [S60] Browser crashes if original page is closed and user downloads something after closing in 3.1m.
Fix: Make CBrCtlDownloadObserver a singleton class to support multiple windows download.
http://bugs.webkit.org/show_bug.cgi?id=13296

BrowserControl/inc/BrCtl.h:
BrowserControl/src/BrCtl.cpp: (CBrCtl::ConstructL): (CBrCtl::~CBrCtl): (CBrCtl::SendCommandsToClient): (CBrCtl::BrCtlDownloadObserver):
BrowserView/inc/WebKitControl.h:
BrowserView/src/WebKitControl.cpp: (CStaticObjectContainer::~CStaticObjectContainer): (CStaticObjectContainer::DownloadObserver): (CStaticObjectContainer::InitializeFactoryObjectsL):

11:39 AM Changeset in webkit [23295] by aroben

2 edits in branches/WindowsMerge/WebCore

11:38 AM Changeset in webkit [20909] by spadma

3 edits in S60/trunk/WebKit

2007-04-16 spadma

Reviewed by Zalan
DESC: Unable to play flash content in embedded browser Averell 3.1
http://bugs.webkit.org/show_bug.cgi?id=13363
TSW ID: EDHV-6YDHC2

Plugin/inc/PluginHandler.h:
Plugin/src/PluginHandler.cpp: (CPluginInfo::ParseDefaultDataL): (CPluginInfo::ParseDisplayNameL): (CPluginHandler::ConstructL): (CPluginHandler::Initialize): (CPluginHandler::LoadPluginsL): (CPluginHandler::FindPlugin): (CPluginHandler::FindPluginByExtension): (CPluginHandler::LoadPluginL): (CPluginHandler::UnloadPlugin): (CPluginHandler::GetIndexFromHandle): (CPluginHandler::ReloadPlugins): (CPluginHandler::GetPluginName): (CPluginHandler::GetPluginFileName): (CPluginHandler::GetPluginDescription): (CPluginHandler::GetPluginCount): (CPluginHandler::GetMimeTypes): (CPluginHandler::GetMimeExtensions): (CPluginHandler::GetMimeDescriptions): (CPluginHandler::ReloadPluginsL):

11:38 AM Changeset in webkit [20908] by spadma

3 edits in S60/branches/3.1m/WebKit

2007-04-16 spadma

Reviewed by Zalan
DESC: Unable to play flash content in embedded browser Averell 3.1
http://bugs.webkit.org/show_bug.cgi?id=13363
TSW ID: EDHV-6YDHC2

Plugin/inc/PluginHandler.h:
Plugin/src/PluginHandler.cpp: (CPluginInfo::ParseDefaultDataL): (CPluginInfo::ParseDisplayNameL): (CPluginHandler::ConstructL): (CPluginHandler::Initialize): (CPluginHandler::LoadPluginsL): (CPluginHandler::FindPlugin): (CPluginHandler::FindPluginByExtension): (CPluginHandler::LoadPluginL): (CPluginHandler::UnloadPlugin): (CPluginHandler::GetIndexFromHandle): (CPluginHandler::ReloadPlugins): (CPluginHandler::GetPluginName): (CPluginHandler::GetPluginFileName): (CPluginHandler::GetPluginDescription): (CPluginHandler::GetPluginCount): (CPluginHandler::GetMimeTypes): (CPluginHandler::GetMimeExtensions): (CPluginHandler::GetMimeDescriptions): (CPluginHandler::ReloadPluginsL):

11:31 AM Changeset in webkit [20907] by thatcher

2 edits in trunk/WebKitTools

Drosera/debugger.css: hide the borders for iframes

11:29 AM Changeset in webkit [20906] by darin

2 edits in trunk/WebKit

Rubber stamped by Tim Hatcher.

WebKit.xcodeproj/project.pbxproj: Added Radar bug number to the error message for the "version number ending in 4" check so folks from Apple can find the original bug that motivated for this. To summarize what's in that bug, it says that <http://my.fedex.com> was failing, that it was because of the OpenCube DHTML Menu, and that some other affected sites were not using OpenCube (so the error is presumably more widespread).

11:07 AM Changeset in webkit [20905] by yongjzha

2 edits in S60/trunk/JavaScriptCore

rathnasa, reviewed by yongjun

DESC: TSW ID : EWGO-6YVB4L: Web application jams and closed when browsing.
http://bugs.webkit.org/show_bug.cgi?id=13361

pcre/pcre-config.h:

11:04 AM Changeset in webkit [20904] by yongjzha

2 edits in S60/branches/3.1m/JavaScriptCore

2007-04-16 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by yongjun.
DESC: TSW ID : EWGO-6YVB4L: Web application jams and closed when browsing.

http://bugs.webkit.org/show_bug.cgi?id=13361

pcre/pcre-config.h:

10:26 AM Changeset in webkit [20903] by brmorris

2 edits in S60/trunk/WebKit

bradley, rs'd by padma

DESC: move ContentAcceess namespace declaration

BrowserCore/Renderers/src/StaticImageDecoder.cpp: (CRawData::DecodeDRMImageContentL):

10:17 AM Changeset in webkit [23294] by aroben

3 edits in branches/WindowsMerge/WebKitWin

Merge in r20872.

WebInspector/webInspector/inspector.js:
WebInspector/webInspector/treeoutline.js:

10:14 AM Changeset in webkit [23293] by aroben

3 edits in branches/WindowsMerge/WebKitWin

Merge in r20861.

WebInspector/webInspector/inspector.js:
WebInspector/webInspector/treeoutline.js:

10:11 AM Changeset in webkit [23292] by aroben

2 edits in branches/WindowsMerge/WebKitWin

Merge in r20845.

WebInspector/webInspector/inspector.js:

10:06 AM Changeset in webkit [23291] by aroben

2 edits in branches/WindowsMerge/WebKitWin

Merge in r20844.

WebInspector/webInspector/inspector.js:

10:05 AM Changeset in webkit [23290] by aroben

5 edits in branches/WindowsMerge/WebKitWin

Merge in r20843.

WebInspector/webInspector/inspector.js:
WebInspector/webInspector/scrollarea.js:
WebInspector/webInspector/scrollbar.js:
WebInspector/webInspector/utilities.js:

10:04 AM Changeset in webkit [23289] by aroben

3 edits
1 add in branches/WindowsMerge/WebKitWin

Merge in r20842.

WebInspector/webInspector/inspector.html:
WebInspector/webInspector/inspector.js:
WebInspector/webInspector/utilities.js: Added.

10:02 AM Changeset in webkit [23288] by aroben

3 edits
1 add in branches/WindowsMerge/WebKitWin

Merge in r20840.

WebInspector/webInspector/inspector.html:
WebInspector/webInspector/inspector.js:
WebInspector/webInspector/treeoutline.js: Added.

9:52 AM Changeset in webkit [20902] by darin

2 edits in trunk/WebCore

get layout tests going again

page/mac/FrameMac.mm: (WebCore::Frame::setUseSecureKeyboardEntry): Replace assertion with a runtime check. We can consider changing it back to an assertion some day, but it's not important.

9:51 AM Changeset in webkit [23287] by aroben

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Removed another non-crasher.

9:39 AM Changeset in webkit [23286] by aroben

2 edits in branches/WindowsMerge/LayoutTests

win/Skipped: Removed two tests that no longer crash.

8:41 AM Changeset in webkit [20901] by darin

13 edits in trunk

WebCore:

Reviewed by John Sullivan.

fix http://bugs.webkit.org/show_bug.cgi?id=13303 <rdar://problem/5126341> REGRESSION: controls in a background Safari window maintain active appearance if the address bar has focus (13303)

fix a related problem where elements could look focused in non-active windows

simplify secure keyboard entry logic in Frame::setIsActive

WebCore.exp: Add two new symbols for use by WebKit.

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::dispatchFocusEvent): Call setUseSecureKeyboardEntryWhenActive rather than calling setSecureKeyboardEntry directly -- does nothing if the frame is not active. (WebCore::HTMLInputElement::dispatchBlurEvent): Ditto.

page/Frame.cpp: (WebCore::Frame::setUseSecureKeyboardEntryWhenActive): Added. Calls setUseSecureKeyboardEntry only if the frame is active, but also stores away the state, so that the setIsActive function doesn't have to recompute it. (WebCore::Frame::setIsActive): Rewrote all the comments in the function. Removed the code to manage control tints, which are not based on the whether the frame is active but rather on AppKit's concept of whether the window should have "key appearance". Simplified the logic about when to call setUseSecureKeyboardEntry by using the value of m_useSecureKeyboardEntryWhenActive. (WebCore::FramePrivate::FramePrivate): Initialize m_useSecureKeyboardEntryWhenActive.
page/Frame.h: Made setSecureKeyboardEntry private and renamed it to setUseSecureKeyboardEntry, removed isSecureKeyboardEntry, and added a public setUseSecureKeyboardEntryWhenActive.
page/FramePrivate.h: Added m_useSecureKeyboardEntryWhenActive.
page/mac/FrameMac.mm: (WebCore::Frame::setUseSecureKeyboardEntry): Added an assertion, and removed isSecureKeyboardEntry().

page/FrameView.h: Added updateControlTints.
page/FrameView.cpp: (WebCore::FrameView::updateControlTints): Added. Code was moved here from setIsActive for two reasons: (1) it makes more sense in the view class, and (2) it needs to be called at the appropriate time for AppKit, not when active changes.

rendering/RenderTheme.cpp: (WebCore::RenderTheme::isFocused): Added an isActive check here to match the logic in the implementation of the CSS pseudo-state.
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::updateFocusedState): Use the isFocused function instead of repeating the logic here. Removed the "need to add a key window test here" comment. (WebCore::RenderThemeMac::controlSupportsTints): Added a comment about the NSCell SPI that's related to the _windowChangedKeyState method we now use in WebHTMLView.

WebKit:

Reviewed by John Sullivan.

fix http://bugs.webkit.org/show_bug.cgi?id=13303 <rdar://problem/5126341> REGRESSION: controls in a background Safari window maintain active appearance if the address bar has focus (13303)

WebView/WebHTMLView.mm: (-[WebHTMLView _windowChangedKeyState]): Added. Calls FrameView::updateControlTints.

8:15 AM Changeset in webkit [20900] by darin

2 edits in trunk/WebCore

Reviewed by John Sullivan.

fix http://bugs.webkit.org/show_bug.cgi?id=13227 StringImpl::isLower incorrectly assumes islower returns 1 (it can return any non-0)

platform/StringImpl.cpp: (WebCore::StringImpl::isLower): Based on test application results, changed to use && instead of trying to use & to avoid branches. Use U16_NEXT so we can handle characters outside the BMP. Improved comments. (WebCore::StringImpl::lower): Improved comments. (WebCore::equalIgnoringCase): Changed to use && instead of trying to use & to avoid branches. Improved comments. Added an assertion about the assumption we're making that characters in the char* are all ASCII.