⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 17, 2007:

11:30 PM Changeset in webkit [23307] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Rubberstamped by Oliver.

  • platform/network/cf/ResourceHandleCFNet.cpp: Removed an unnecessary include.
11:16 PM Changeset in webkit [23306] by sfalken
  • 6 edits in branches/WindowsMerge/WebKitTools

2007-04-17 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Hyatt.


Eliminate more ATL use (CComBSTR)

10:06 PM Changeset in webkit [23305] by sfalken
  • 10 edits in branches/WindowsMerge/WebKitTools

2007-04-16 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.


Eliminate some ATL use in our future open source tree.


ATL headers are not included in any free download, so we'll need to
remove all use of ATL from our open source for compatibility with
Visual Studio Express.


Replace CComPtr and CComQIPtr with COMPtr.

9:58 PM Changeset in webkit [20931] by bdash
  • 3 edits
    4 adds in trunk

2007-04-17 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/table/invisible-cell-background.html

  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell): Don't paint any background if the cell is not visible. This behavior matches WinIE and Opera.

2007-04-17 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/table/invisible-cell-background-expected.checksum: Added.
  • fast/table/invisible-cell-background-expected.png: Added.
  • fast/table/invisible-cell-background-expected.txt: Added.
  • fast/table/invisible-cell-background.html: Added.
8:50 PM Changeset in webkit [20930] by justing
  • 6 edits in trunk

Rolling out my previous checkin, as the compiler bug still exists on Leopard.

8:22 PM Changeset in webkit [20929] by aroben
  • 2 edits in trunk/WebKitTools
  • Scripts/find-included-framework-headers: Search Obj-C and Obj-C++ files as well.
8:18 PM Changeset in webkit [20928] by aroben
  • 1 edit
    1 add in trunk/WebKitTools

Added a simple shell script to find all the headers from a specified
framework or frameworks that are included by files beneath the working
directory.

  • Scripts/find-included-framework-headers: Added.
7:23 PM Changeset in webkit [20927] by justing
  • 6 edits in trunk

WebCore:

Reviewed by adam

Removed workarounds for compiler bug 4213314.

  • platform/mac/CursorMac.mm: (WebCore::leakNamedCursor):
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::contentsToWindow): (WebCore::ScrollView::windowToContents):

WebKit:

Reviewed by adam


Removed workarounds for compiler bug 4213314.

  • Misc/WebNSAttributedStringExtras.mm: (+[NSAttributedString _web_attributedStringFromRange:]):
  • WebKit.xcodeproj/project.pbxproj:
6:20 PM Changeset in webkit [20926] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison

<rdar://problem/5119244>
Crash when indenting a selected ToDo


  • editing/execCommand/5119244-expected.checksum: Added.
  • editing/execCommand/5119244-expected.png: Added.
  • editing/execCommand/5119244-expected.txt: Added.
  • editing/execCommand/5119244.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/5119244>
Crash when indenting a selected ToDo


indentRegion() was using the old (incorrect) editable root
getter, which returned null for a valid, editable position,
causing the crash.

  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::indentRegion): The editable root for a position is editableRootForPosition(p), not p.node()->rootEditableElement(), because of VisiblePositions before/after tables, replaced elements and others.
5:13 PM Changeset in webkit [20925] by justing
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by hyatt


<rdar://problem/5138441>
GoogleDocs: Indented text looks like text that's been Quoted

Demonstrates the bug:

  • editing/execCommand/5138441-expected.checksum: Added.
  • editing/execCommand/5138441-expected.png: Added.
  • editing/execCommand/5138441-expected.txt: Added.
  • editing/execCommand/5138441.html: Added.


Added inline style declarations for indent blockquotes
to match those that the engine creates:

  • editing/execCommand/indent-selection.html:
  • editing/execCommand/outdent-selection.html:

WebCore:

Reviewed by hyatt

<rdar://problem/5138441>
GoogleDocs: Indented text looks like text that's been Quoted


GoogleDocs uses FormatBlock, blockquotes and a style rule
for blockquotes to implement a "Quote Text" feature. Styles
intended only for those blockquotes were added to the
blockquotes that we use for indenting.

  • css/html4.css: Removed the webkit-indent-blockquote class rule.
  • editing/IndentOutdentCommand.cpp: (WebCore::createIndentBlockquoteElement): Use custom margins and turn off border and padding to override author rules for blockquotes.
4:04 PM Changeset in webkit [23304] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-04-17 Oliver Hunt <​oliver@apple.com>

Whoops, had code commented out from manual failure test.
Also fixed date of previous changelog entry

  • platform/win/ClipboardWin.cpp: (WebCore::writeFileToDataObject):
4:00 PM Changeset in webkit [20924] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Tim Hatcher

  • fixed <rdar://problem/5138492> Safari doesn't remember some changes to the PDF scale and display mode

Some of the user interactions that could change the PDF scale and display mode were not going through
the proxy mechanism in WebPDFView that updates preferences. Now we also listen to PDFKit notifications
in order to catch the other cases.

  • WebView/WebPDFView.h: new _ignoreScaleAndDisplayModeNotifications and _updatePreferencesTimer ivars
  • WebView/WebPDFView.mm: (-[WebPDFView setPDFDocument:]): ignore scale and display mode notifications while we're setting up a fresh document (-[WebPDFView dealloc]): cancel the new timer (which releases it) (-[WebPDFView viewDidMoveToWindow]): listen for two PDFKit notifications (-[WebPDFView viewWillMoveToWindow:]): stop listening to the two PDFKit notifications (-[WebPDFView _applyPDFDefaults]): white space change (-[WebPDFView _cancelUpdatePreferencesTimer]): invalidate, release, and nil out the timer (-[WebPDFView _scaleOrDisplayModeChanged:]): update preferences soon, unless deliberately ignoring these notifications (-[WebPDFView _updatePreferencesNow]): cancel timer, then save data to preferences (code for saving the data was extracted from -[PDFPrefUpdatingProxy forwardInvocation:]) (-[WebPDFView _updatePreferencesSoon]): use timer to consolidate multiple calls into one action; formerly we were setting preferences multiple times for some atomic user actions (-[PDFPrefUpdatingProxy forwardInvocation:]): call _updatePreferencesSoon where we used to immediately set preferences
3:31 PM Changeset in webkit [23303] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-04-16 Oliver Hunt <​oliver@apple.com>

Reviewed by Ada.

Partial fix for <rdar://problem/5035948> -- Dragging image
or link from boomer doesn't create webloc or image file.


Add all the ground work to set up FileDescriptors and FileContent
for allowing files to be created from drag and drop actions,
and hook up logic for links to create WebLoc data for drag and drop.

  • platform/win/ClipboardWin.cpp: (WebCore::fileDescriptorFormat): (WebCore::fileContentFormat): Clipboard formats


(WebCore::pathRemoveBadFSCharacters):
(WebCore::filesystemPathFromUrlOrTitle):

Helper functions for create filenames


(WebCore::createGlobalDataForURLContent):

Create the WebLoc content


(WebCore::createGlobalDataForUrlFileDescriptor):

Create a file descriptor for the WebLoc data


(WebCore::writeFileToDataObject):

Basic helper function to push generated file info
into the target DataObject


(WebCore::ClipboardWin::writeURL):

Now puts WebLoc file onto the Clipboard

1:27 PM Changeset in webkit [20923] by justing
  • 10 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/5136770>
Gmail Editor: Hang when turning a particular multi-line selection into a list

Demonstrates the bug:

  • editing/execCommand/5136770-expected.checksum: Added.
  • editing/execCommand/5136770-expected.png: Added.
  • editing/execCommand/5136770-expected.txt: Added.
  • editing/execCommand/5136770.html: Added.


Added placeholders in empty list items:

  • editing/execCommand/4747450-expected.txt:
  • editing/execCommand/insert-list-empty-div-expected.txt:
  • editing/execCommand/4917055-expected.txt:


A horizontal rule pushed into a list item appears *before*
the list marker in the render tree, although, the new results
look more correct (13376):

  • editing/execCommand/create-list-with-hr-expected.checksum:
  • editing/execCommand/create-list-with-hr-expected.png:
  • editing/execCommand/create-list-with-hr-expected.txt:
  • editing/execCommand/create-list-with-hr.html:

WebCore:

Reviewed by darin

<rdar://problem/5136770>
Gmail Editor: Hang when turning a particular multi-line selection into a list


When InsertListCommand pushes content into list items,
it creates an empty list item and then calls moveParagraphs.
But moveParagraphs' selection preservation code fails when
it encounters empty list items (list items w/o placeholders).
This causes InsertListCommand to lose track of where it has
already been performed, which causes the hang.

  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): Use brs to hold open empty list items.
1:03 PM Changeset in webkit [20922] by sfalken
  • 1 copy in tags/Safari-522.6.1b

New tag.

12:58 PM Changeset in webkit [20921] by darin
  • 6 edits in trunk/WebCore

Oops, rolled that last change out. I'll redo it again later after making
som additional refinments.

12:00 PM Changeset in webkit [20920] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Kevin Decker

  • fixed <rdar://problem/4184640> "Look Up in Dictionary" item is always disabled for PDF pages
  • WebView/WebPDFView.mm: (-[WebPDFView validateUserInterfaceItem:]): enable "Look Up in Dictionary" only if we're using a version of PDFKit that knows how to do so (-[WebPDFView _canLookUpInDictionary]): use respondsToSelector to test whether the current version of PDFKit supports this non-API feature (-[WebPDFView _lookUpInDictionaryFromMenu:]): implement this method, which WebKit includes in the context menu when there's selected text (-[WebPDFView _menuItemsFromPDFKitForEvent:]): updated comment for this change
11:44 AM Changeset in webkit [20919] by darin
  • 6 edits in trunk/WebCore

Reviewed by Brady.

  • a few baby steps to try to make lockHistory and userGesture less confusing
  • page/FrameLoadRequest.h: (WebCore::FrameLoadRequest::FrameLoadRequest): Add initialization of m_isUserGesture to true. (WebCore::FrameLoadRequest::shouldLockHistory): Renamed from lockHistory to avoid having a getter that sounds like a verb phrase. (WebCore::FrameLoadRequest::setShouldLockHistory): Ditto. (WebCore::FrameLoadRequest::isUserGesture): Added. (WebCore::FrameLoadRequest::setIsUserGesture): Ditto.
  • loader/FrameLoader.h: Remove userGesture parameter from load that takes FrameLoadRequest. Remove default values for lockHistory and userGesture parameters, since that just makes it more likely we'll forget to pass them in. Remove one of the overloads of urlSelected, since it's only called one place.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): Remove userGesture parameter, relying on the true default in FrameLoadRequest. (WebCore::FrameLoader::urlSelected): Call setShouldLockHistory and setIsUserGesture on the FrameLoadRequest, and call load directly; also eliminate the other urlSelected overload since this was the only place it was called. (WebCore::FrameLoader::load): Remove userGesture parameter, relying on the true default in FrameLoadRequest. In the other overload, clean up logic to eliminate the argsReferrer variable and get rid of the userGesture parameter, using the value from FrameLoadRequest. (WebCore::FrameLoader::submitForm): Remove userGesture parameter, relying on the value in the FrameLoadRequest. This actually changes behavior.
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::putValueProperty): Pass false for userGesture explicitly instead of relying on default argument.
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Remove userGesture parameter, relying on the true default in FrameLoadRequest.
10:49 AM Changeset in webkit [20918] by thatcher
  • 1 edit in trunk/WebKit/Plugins/WebBaseNetscapePluginStream.mm

More elegant fix for the 64-bit build failure.

7:45 AM Changeset in webkit [20917] by yongjzha
  • 5 edits in S60/branches/3.1m/WebKit

2007-04-11 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by Yongjun Zhang.
DESC: Enhanced Input feature not working in 3.1 [TSW TMCN-6XYSLY] fix for chinese variant
​http://bugs.webkit.org/show_bug.cgi?id=12533

  • BrowserCore/Formcontrols/inc/FControlInputSkin.h:
  • BrowserCore/Formcontrols/inc/FControlInputWidget.h:
  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::SelectedLanguage): (CFormInputSkin::ActivateL):
  • BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::ConstructTextEditorL): (CControlInputWidget::OfferKeyEventL): (CControlInputWidget::SetCursorPositionL): (CControlInputWidget::SetWebKitCursorPosition):
7:00 AM Changeset in webkit [20916] by yongjzha
  • 2 edits in S60/trunk/WebCore

2007-04-17 bujtas <​zbujtas@gmail.com>

Reviewed by Yongjun.
DESC: else if (p == "cssValueType"); <-
​http://bugs.webkit.org/show_bug.cgi?id=13372

  • khtml/ecma/kjs_css.cpp: (cssPropertyName): (DOMCSSStyleDeclaration::tryPut): (DOMCSSValue::tryGet): (DOMRGBColor::tryGet): (DOMRect::tryGet): (DOMCounter::tryGet):
6:59 AM Changeset in webkit [20915] by yongjzha
  • 2 edits in S60/branches/3.1m/WebCore

2007-04-17 bujtas <​zbujtas@gmail.com>

Reviewed by Yongjun.
DESC: else if (p == "cssValueType"); <-
​http://bugs.webkit.org/show_bug.cgi?id=13372

  • khtml/ecma/kjs_css.cpp: (cssPropertyName): (DOMCSSStyleDeclaration::tryPut): (DOMCSSValue::tryGet): (DOMRGBColor::tryGet): (DOMRect::tryGet): (DOMCounter::tryGet):

Apr 16, 2007:

11:23 PM Changeset in webkit [23302] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Rubberstamped by Steve.

  • WebKit.vcproj/WebKit.sln: Removed the Debug_Internal configuration.
11:22 PM Changeset in webkit [23301] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin
9:43 PM Changeset in webkit [23300] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin
  • WebKit.vcproj/WebKit.sln: Added WTF to the solution.
7:13 PM Changeset in webkit [23299] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests
  • win/Skipped: Fixed a path.
7:10 PM Changeset in webkit [23298] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests
  • win/Skipped: Removed a fixed test.
6:46 PM Changeset in webkit [23297] by kmccullo
  • 2 edits in branches/WindowsMerge/LayoutTests
  • win/Skipped: Continued sorting/filing bugs.
6:15 PM Changeset in webkit [20914] by ddkilzer
  • 1 edit
    1 move in trunk/WebCore

WebCore:

Reviewed by NOBODY (fixed misspelling).

  • manual-tests/containing-block-position-chage.html: Removed.
  • manual-tests/containing-block-position-change.html: Added.
5:25 PM Changeset in webkit [20913] by thatcher
  • 1 edit in trunk/WebKit/Plugins/WebBaseNetscapePluginStream.mm

64-bit build fix.

4:05 PM Changeset in webkit [23296] by sfalken
  • 7 edits in branches/WindowsMerge

2007-04-16 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.


Visual Studio Express compatibility for WebKit build (except for DRT)

  • WebDragClient.cpp: Removed unused header (atlsafe.h)
  • WebKit.vcproj/WebKit.rc: Removed afxres.h and related code
  • WebKit.vcproj/WebKit.sln: Don't use a sln folder - they aren't supported by express
  • WebKit.vcproj/WebKit.vcproj: Add explicit lib references for Windows system libs (VS express doesn't include these)
  • WebView.cpp: Removed unused header (atldef.h)
2:06 PM Changeset in webkit [20912] by justing
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/5134759>
GMail Editor: Hang after pasting underlined text multiple times

Demonstrates the bug:

  • editing/pasteboard/5134759-expected.checksum: Added.
  • editing/pasteboard/5134759-expected.png: Added.
  • editing/pasteboard/5134759-expected.txt: Added.
  • editing/pasteboard/5134759.html: Added.


A unnecessary extra space was added to an element's
inline style declaration, because of the way cssText behaves:

  • editing/pasteboard/paste-table-002-expected.txt:

WebCore:

Reviewed by darin

<rdar://problem/5134759>
GMail Editor: Hang after pasting underlined text multiple times


The moveParagraphs call that ReplaceSelectionCommand
performs must receive only inline content from createMarkup,
or else it will result in another call to moveParagraphs
when it performs the move, resulting in infinite recursion.

  • editing/markup.cpp: (WebCore::startMarkup): We were only converting a block to an inline if it had an inline style declaration or styles coming from matched rules. Cleaned up this code a bit by handling an element's style separately from its other attributes.
1:29 PM Changeset in webkit [20911] by spadma
  • 5 edits in S60/trunk

2007-04-16 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by Sachin.
DESC: [S60] Browser crashes if original page is closed and user downloads something after closing in 3.1m.
Fix: Make CBrCtlDownloadObserver a singleton class to support multiple windows download.
​http://bugs.webkit.org/show_bug.cgi?id=13296

  • BrowserControl/inc/BrCtl.h:
  • BrowserControl/src/BrCtl.cpp: (CBrCtl::ConstructL): (CBrCtl::~CBrCtl): (CBrCtl::SendCommandsToClient): (CBrCtl::BrCtlDownloadObserver):
  • BrowserView/inc/WebKitControl.h:
  • BrowserView/src/WebKitControl.cpp: (CStaticObjectContainer::~CStaticObjectContainer): (CStaticObjectContainer::DownloadObserver): (CStaticObjectContainer::InitializeFactoryObjectsL):
1:28 PM Changeset in webkit [20910] by spadma
  • 5 edits in S60/branches/3.1m/WebKit

2007-04-16 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by Sachin.
DESC: [S60] Browser crashes if original page is closed and user downloads something after closing in 3.1m.
Fix: Make CBrCtlDownloadObserver a singleton class to support multiple windows download.
​http://bugs.webkit.org/show_bug.cgi?id=13296

  • BrowserControl/inc/BrCtl.h:
  • BrowserControl/src/BrCtl.cpp: (CBrCtl::ConstructL): (CBrCtl::~CBrCtl): (CBrCtl::SendCommandsToClient): (CBrCtl::BrCtlDownloadObserver):
  • BrowserView/inc/WebKitControl.h:
  • BrowserView/src/WebKitControl.cpp: (CStaticObjectContainer::~CStaticObjectContainer): (CStaticObjectContainer::DownloadObserver): (CStaticObjectContainer::InitializeFactoryObjectsL):
11:39 AM Changeset in webkit [23295] by aroben
  • 2 edits in branches/WindowsMerge/WebCore
11:38 AM Changeset in webkit [20909] by spadma
  • 3 edits in S60/trunk/WebKit

2007-04-16 spadma

Reviewed by Zalan
DESC: Unable to play flash content in embedded browser Averell 3.1
​http://bugs.webkit.org/show_bug.cgi?id=13363
TSW ID: EDHV-6YDHC2

  • Plugin/inc/PluginHandler.h:
  • Plugin/src/PluginHandler.cpp: (CPluginInfo::ParseDefaultDataL): (CPluginInfo::ParseDisplayNameL): (CPluginHandler::ConstructL): (CPluginHandler::Initialize): (CPluginHandler::LoadPluginsL): (CPluginHandler::FindPlugin): (CPluginHandler::FindPluginByExtension): (CPluginHandler::LoadPluginL): (CPluginHandler::UnloadPlugin): (CPluginHandler::GetIndexFromHandle): (CPluginHandler::ReloadPlugins): (CPluginHandler::GetPluginName): (CPluginHandler::GetPluginFileName): (CPluginHandler::GetPluginDescription): (CPluginHandler::GetPluginCount): (CPluginHandler::GetMimeTypes): (CPluginHandler::GetMimeExtensions): (CPluginHandler::GetMimeDescriptions): (CPluginHandler::ReloadPluginsL):
11:38 AM Changeset in webkit [20908] by spadma
  • 3 edits in S60/branches/3.1m/WebKit

2007-04-16 spadma

Reviewed by Zalan
DESC: Unable to play flash content in embedded browser Averell 3.1
​http://bugs.webkit.org/show_bug.cgi?id=13363
TSW ID: EDHV-6YDHC2

  • Plugin/inc/PluginHandler.h:
  • Plugin/src/PluginHandler.cpp: (CPluginInfo::ParseDefaultDataL): (CPluginInfo::ParseDisplayNameL): (CPluginHandler::ConstructL): (CPluginHandler::Initialize): (CPluginHandler::LoadPluginsL): (CPluginHandler::FindPlugin): (CPluginHandler::FindPluginByExtension): (CPluginHandler::LoadPluginL): (CPluginHandler::UnloadPlugin): (CPluginHandler::GetIndexFromHandle): (CPluginHandler::ReloadPlugins): (CPluginHandler::GetPluginName): (CPluginHandler::GetPluginFileName): (CPluginHandler::GetPluginDescription): (CPluginHandler::GetPluginCount): (CPluginHandler::GetMimeTypes): (CPluginHandler::GetMimeExtensions): (CPluginHandler::GetMimeDescriptions): (CPluginHandler::ReloadPluginsL):
11:31 AM Changeset in webkit [20907] by thatcher
  • 2 edits in trunk/WebKitTools
  • Drosera/debugger.css: hide the borders for iframes
11:29 AM Changeset in webkit [20906] by darin
  • 2 edits in trunk/WebKit

Rubber stamped by Tim Hatcher.

  • WebKit.xcodeproj/project.pbxproj: Added Radar bug number to the error message for the "version number ending in 4" check so folks from Apple can find the original bug that motivated for this. To summarize what's in that bug, it says that <​http://my.fedex.com> was failing, that it was because of the OpenCube DHTML Menu, and that some other affected sites were not using OpenCube (so the error is presumably more widespread).
11:07 AM Changeset in webkit [20905] by yongjzha
  • 2 edits in S60/trunk/JavaScriptCore

rathnasa, reviewed by yongjun

DESC: TSW ID : EWGO-6YVB4L: Web application jams and closed when browsing.
​http://bugs.webkit.org/show_bug.cgi?id=13361

  • pcre/pcre-config.h:
11:04 AM Changeset in webkit [20904] by yongjzha
  • 2 edits in S60/branches/3.1m/JavaScriptCore

2007-04-16 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by yongjun.
DESC: TSW ID : EWGO-6YVB4L: Web application jams and closed when browsing.

​http://bugs.webkit.org/show_bug.cgi?id=13361

  • pcre/pcre-config.h:
10:26 AM Changeset in webkit [20903] by brmorris
  • 2 edits in S60/trunk/WebKit

bradley, rs'd by padma

DESC: move ContentAcceess namespace declaration

  • BrowserCore/Renderers/src/StaticImageDecoder.cpp: (CRawData::DecodeDRMImageContentL):
10:17 AM Changeset in webkit [23294] by aroben
  • 3 edits in branches/WindowsMerge/WebKitWin

Merge in r20872.

10:14 AM Changeset in webkit [23293] by aroben
  • 3 edits in branches/WindowsMerge/WebKitWin

Merge in r20861.

10:11 AM Changeset in webkit [23292] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Merge in r20845.

10:06 AM Changeset in webkit [23291] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Merge in r20844.

10:05 AM Changeset in webkit [23290] by aroben
  • 5 edits in branches/WindowsMerge/WebKitWin

Merge in r20843.

10:04 AM Changeset in webkit [23289] by aroben
  • 3 edits
    1 add in branches/WindowsMerge/WebKitWin

Merge in r20842.

10:02 AM Changeset in webkit [23288] by aroben
  • 3 edits
    1 add in branches/WindowsMerge/WebKitWin

Merge in r20840.

9:52 AM Changeset in webkit [20902] by darin
  • 2 edits in trunk/WebCore
  • get layout tests going again
  • page/mac/FrameMac.mm: (WebCore::Frame::setUseSecureKeyboardEntry): Replace assertion with a runtime check. We can consider changing it back to an assertion some day, but it's not important.
9:51 AM Changeset in webkit [23287] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests
  • win/Skipped: Removed another non-crasher.
9:39 AM Changeset in webkit [23286] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests
  • win/Skipped: Removed two tests that no longer crash.
8:41 AM Changeset in webkit [20901] by darin
  • 13 edits in trunk

WebCore:

Reviewed by John Sullivan.

  • fix a related problem where elements could look focused in non-active windows
  • simplify secure keyboard entry logic in Frame::setIsActive
  • WebCore.exp: Add two new symbols for use by WebKit.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::dispatchFocusEvent): Call setUseSecureKeyboardEntryWhenActive rather than calling setSecureKeyboardEntry directly -- does nothing if the frame is not active. (WebCore::HTMLInputElement::dispatchBlurEvent): Ditto.
  • page/Frame.cpp: (WebCore::Frame::setUseSecureKeyboardEntryWhenActive): Added. Calls setUseSecureKeyboardEntry only if the frame is active, but also stores away the state, so that the setIsActive function doesn't have to recompute it. (WebCore::Frame::setIsActive): Rewrote all the comments in the function. Removed the code to manage control tints, which are not based on the whether the frame is active but rather on AppKit's concept of whether the window should have "key appearance". Simplified the logic about when to call setUseSecureKeyboardEntry by using the value of m_useSecureKeyboardEntryWhenActive. (WebCore::FramePrivate::FramePrivate): Initialize m_useSecureKeyboardEntryWhenActive.
  • page/Frame.h: Made setSecureKeyboardEntry private and renamed it to setUseSecureKeyboardEntry, removed isSecureKeyboardEntry, and added a public setUseSecureKeyboardEntryWhenActive.
  • page/FramePrivate.h: Added m_useSecureKeyboardEntryWhenActive.
  • page/mac/FrameMac.mm: (WebCore::Frame::setUseSecureKeyboardEntry): Added an assertion, and removed isSecureKeyboardEntry().
  • page/FrameView.h: Added updateControlTints.
  • page/FrameView.cpp: (WebCore::FrameView::updateControlTints): Added. Code was moved here from setIsActive for two reasons: (1) it makes more sense in the view class, and (2) it needs to be called at the appropriate time for AppKit, not when active changes.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::isFocused): Added an isActive check here to match the logic in the implementation of the CSS pseudo-state.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::updateFocusedState): Use the isFocused function instead of repeating the logic here. Removed the "need to add a key window test here" comment. (WebCore::RenderThemeMac::controlSupportsTints): Added a comment about the NSCell SPI that's related to the _windowChangedKeyState method we now use in WebHTMLView.

WebKit:

Reviewed by John Sullivan.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _windowChangedKeyState]): Added. Calls FrameView::updateControlTints.
8:15 AM Changeset in webkit [20900] by darin
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

  • platform/StringImpl.cpp: (WebCore::StringImpl::isLower): Based on test application results, changed to use && instead of trying to use & to avoid branches. Use U16_NEXT so we can handle characters outside the BMP. Improved comments. (WebCore::StringImpl::lower): Improved comments. (WebCore::equalIgnoringCase): Changed to use && instead of trying to use & to avoid branches. Improved comments. Added an assertion about the assumption we're making that characters in the char* are all ASCII.
Note: See TracTimeline for information about the timeline view.