Context Navigation

← Previous Period
Next Period →

Timeline

Apr 20, 2007:

11:43 PM Changeset in webkit [20988] by thatcher

1 edit in trunk/WebKit/WebInspector/WebInspector.m

Fixes the build.

11:19 PM Changeset in webkit [20987] by thatcher

1 delete in branches/WebInspectorRefresh

Remove the branch now that the changes were merged over to source:trunk in r20986.

11:14 PM Changeset in webkit [20986] by thatcher

2 edits
11 copies
2 deletes in trunk/WebKit

Reviewed by Darin.

Merge over the WebInspectorRefresh branch. This change removes the NSOutlineView and
is replaced with a HTML/JavaScript tree. Most of the inspector logic is now in the JavaScript.

A few bugs are fixed by these changes:

Bug 6615: Parent node drop-down list is upside-down
http://bugs.webkit.org/show_bug.cgi?id=6615

Bug 6643: REGRESSION: Tree view repaints lines without erasing them first
http://bugs.webkit.org/show_bug.cgi?id=6643

Bug 6650: Web Inspector HTML Hierarchy can't be scrolled with scrollwheel
http://bugs.webkit.org/show_bug.cgi?id=6650

Bug 6677: Can't drag inspector when tree view has focus
http://bugs.webkit.org/show_bug.cgi?id=6677

Bug 7326: Web Inspector tree scrollbar always shows up when resizing the top pane down
http://bugs.webkit.org/show_bug.cgi?id=7326

WebInspector/WebInspector.h: Removed the searchQuery methods.
WebInspector/WebInspector.m: Removed the DOMNode category and code for the old outline view.
WebInspector/WebInspectorOutlineView.h: Removed.
WebInspector/WebInspectorOutlineView.m: Removed.
WebInspector/WebInspectorInternal.h: Remove some methods and instance variables.
WebInspector/webInspector/Images/resize.png: Added.
WebInspector/webInspector/inspector.css:
WebInspector/webInspector/inspector.html: Include the new classes and remove the plugin.
WebInspector/webInspector/inspector.js: Changes to use the new tree outline and other fixes.
WebInspector/webInspector/scrollarea.js: Copied from the Dashboard widget resources.
WebInspector/webInspector/scrollbar.js: Ditto.
WebInspector/webInspector/treeoutline.js: New tree outline class.
WebInspector/webInspector/utilities.js: DOM and String prototype additions.
WebKit.xcodeproj/project.pbxproj: Remove WebInspectorOutlineView.

7:00 PM Changeset in webkit [20985] by bdash

1 copy in tags/Safari-4522.6.1

New tag.

6:49 PM Changeset in webkit [20984] by bdash

4 edits in branches/Safari-522

Versioning.

6:46 PM Changeset in webkit [20983] by bdash

8 edits in branches/Safari-522

Merge r20445.

6:00 PM Changeset in webkit [20982] by bdakin

1 edit
2 adds in trunk/LayoutTests

Reviewed by Adam.

Test I meant to check in a while ago.

fast/events/fire-scroll-event-expected.txt: Added.
fast/events/fire-scroll-event.html: Added.

5:58 PM Changeset in webkit [23329] by adachan

11 edits in branches/WindowsMerge

5:55 PM Changeset in webkit [23328] by bdakin

2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Fix for <rdar://problem/5089822> Boomer does not send scroll events

platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::valueChanged):

5:26 PM Changeset in webkit [20981] by beidson

6 edits in trunk

WebCore:

Reviewed by Oliver (Black Sheep)

<rdar://problem/3559794>
[WebView setMaintainsBackForwardList:] doesn't actually flush out the current page caches

WebCore.exp:
history/BackForwardList.cpp: (WebCore::BackForwardList::BackForwardList): Set the flag to true by default (WebCore::BackForwardList::addItem): Check the flag and bail if its false (WebCore::BackForwardList::setCapacity): More correct if it set the m_current to NoCurrentItemIndex if we're setting capacity to 0 (WebCore::BackForwardList::enabled): (WebCore::BackForwardList::setEnabled): If we're disabling, cycle capacity to 0 and back to flush things out
history/BackForwardList.h: Add enabled(), setEnabled(bool), and m_enabled

WebKit:

Reviewed by Oliver (Black Sheep)

<rdar://problem/3559794>
[WebView setMaintainsBackForwardList:] doesn't actually flush out the current page caches

WebView/WebView.mm: Remove _private->useBackForwardList (-[WebView _setInitiatedDrag:]): Use _private->page instead of [self page] (-[WebView initWithCoder:]): Manipulate the flag that is now in WebCore::BackForwardList (-[WebView encodeWithCoder:]): Ditto (-[WebView backForwardList]): Use _private->page instead of [self page] (-[WebView setMaintainsBackForwardList:]): Manipulate the flag that is now in WebCore::BackForwardList

5:24 PM Changeset in webkit [20980] by hyatt

5 edits in trunk/WebCore

Bug 13424, firstLineStyle and verticalPositionHint together take
33% of the time on the new tag nesting PLT. Don't waste time even
looking for first-line styles if no stylesheet used them.

Reviewed by beth

css/CSSGrammar.y:
dom/Document.cpp: (WebCore::Document::Document):
dom/Document.h: (WebCore::Document::usesFirstLineRules): (WebCore::Document::setUsesFirstLineRules):
rendering/RenderObject.cpp: (WebCore::RenderObject::verticalPositionHint): (WebCore::RenderObject::firstLineStyle):

5:14 PM Changeset in webkit [20979] by thatcher

1 copy in tags/Safari-4522.6

New tag.

5:13 PM Changeset in webkit [20978] by thatcher

4 edits in branches/Safari-522

Versioning

3:50 PM Changeset in webkit [20977] by mjs

2 edits in trunk/JavaScriptCore

Not reviewed, build fix.

fix build problem with last change - -O3 complains more about uninitialized variables

pcre/pcre_compile.c: (compile_branch): (pcre_compile2):

3:33 PM Changeset in webkit [20976] by aroben

2 edits in trunk/WebKitTools

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13421
Bug 13421: prepare-ChangeLog should use svn-create-patch when spewing diffs

Scripts/prepare-ChangeLog: Use svn-create-patch instead of svn diff.

3:26 PM Changeset in webkit [20975] by oliver

2 edits in trunk/WebCore

2007-04-20 Peter Kasting <pkasting@google.com>

Reviewed by Oliver.

fix http://bugs.webkit.org/show_bug.cgi?id=13420

platform/TextEncodingRegistry.cpp: (WebCore::addToTextEncodingNameMap): Change a pointer comparison to a strcmp(), since the strings here are not necessarily pointer-equivalent.

3:20 PM Changeset in webkit [23327] by aroben

2 edits in branches/WindowsMerge/WebKitTools

DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Use WebKitConfigSuffix instead of ConfigSuffix.

3:20 PM Changeset in webkit [20974] by mjs

3 edits in trunk/JavaScriptCore

Reviewed by Darin.

<rdar://problem/5149915> use mergesort when possible, since it leads to fewer compares (2% JS iBench speedup)

kjs/array_object.cpp: (ArrayInstance::sort): Use mergesort(3) on platforms that have it, since it tends to do fewer compares than qsort; but avoid it very on large arrays since it uses extra memory. Also added comments identifying possibly even better sorting algorithms for sort by string value and sort by compare function.
kjs/config.h:

3:00 PM Changeset in webkit [20973] by mjs

2 edits in trunk/JavaScriptCore

Reviewed by Darin.

bump optimization flags up to -O3 for 1% JS iBench speed improvement

Configurations/Base.xcconfig:

2:52 PM Changeset in webkit [20972] by darin

7 edits
2 adds in trunk

LayoutTests:

Reviewed by Geoff Garen and John Sullivan.

test changes for <rdar://problem/4671964> document property on <iframe> elements causes problems for SAP application

fast/dom/iframe-document-expected.txt: Added.
fast/dom/iframe-document.html: Added.

fast/dom/attr_dead_doc.html: Changed to use contentDocument instead of relying on the document property on HTMLIFrameElement.
fast/events/mouseover-mouseout.html: Ditto.
fast/frames/repaint-display-none-crash.html: Ditto.

WebCore:

Reviewed by Geoff Garen and John Sullivan.

fix <rdar://problem/4671964> document property on <iframe> elements causes problems for SAP application

Test: fast/dom/iframe-document.html

bindings/js/kjs_html.h: Removed IFrameDocument.
bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::iFrameGetter): Ditto.

12:49 PM GtkAPIProposal edited by Kimmo Kinnunen

(diff)

12:47 PM GtkAPIProposal edited by Kimmo Kinnunen

(diff)

2:25 AM BuildingGdk edited by alp@atoker.com

Updated roadmap (diff)

2:01 AM Changeset in webkit [23326] by aroben

2 edits in branches/WindowsMerge/WebKitTools

Explicitly link DRT against some Win32 libs because VC++ Express
doesn't link against them by default.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:

1:47 AM Changeset in webkit [20971] by bdash

2 edits in trunk/JavaScriptCore

2007-04-20 Mark Rowe <mrowe@apple.com>

Reviewed by Maciej.

Fix bogus optimisation in the generic pthread code path.

kjs/collector.cpp: (KJS::currentThreadStackBase):

12:50 AM Changeset in webkit [20970] by bdash

2 edits in trunk/JavaScriptCore

2007-04-20 Mark Rowe <mrowe@apple.com>

Reviewed by Anders.

Improve FreeBSD compatibility, as suggested by Alexander Botero-Lowry.

kjs/collector.cpp: (KJS::currentThreadStackBase): FreeBSD requires that pthread_attr_t's are initialized via pthread_attr_init before being used in any context.

12:13 AM Changeset in webkit [20969] by andersca

2 edits in trunk/WebKit

Reviewed by Maciej.

<rdar://problem/5085897> REGRESSION: Some Flash links at www.jumpskyhigh.com just reload the page

Get rid of the check that would prevent plugin requests from being loaded if a new page load was underway.
www.jumpskyhigh.com had a flash movie that was embedded inside an <a> tag and clicking on the plug-in would cause the
URL pointed to by the <a> tag to start loading and thus preventing the plug-in from loading the real URL.

This check was added by Maciej and we should be able to remove it with the loader changes that have happened now,
(mainly the fact that resource loaders are handled by the document loader instead of the frame loader).

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):

Apr 19, 2007:

11:54 PM Changeset in webkit [20968] by bdash

3 edits in trunk/WebCore

2007-04-19 Alp Toker <alp@atoker.com>

Reviewed by Mark.

platform/gdk/FontGdk.cpp: (WebCore::Font::drawGlyphs):
platform/gdk/FontPlatformDataGdk.cpp: (WebCore::FontPlatformData::FontPlatformData): Fix font support in Gdk port.

10:43 PM Changeset in webkit [23325] by aroben

2 edits in branches/WindowsMerge/WebCore

WebCore.vcproj/WebCore.vcproj: Removed empty filter.

10:40 PM Changeset in webkit [23324] by aroben

2 edits in branches/WindowsMerge/WebCore

WebCore.vcproj/WebCore.vcproj: Removed unused files.

10:37 PM Changeset in webkit [23323] by aroben

1 delete in branches/WindowsMerge/WebCore/kcanvas

Removed empty directory.

10:02 PM Changeset in webkit [20967] by hyatt

11 edits
4 adds in trunk

Fix for bug 13208, implement word-break. This patch produces a partial
implementation of word-break. word-break: break-all is implemented. In
addition, a custom value, word-break: break-word is added that is a hybrid
of word-wrap: break-word and word-break: break-all (and more useful than
either).

Reviewed by beth

Added fast/text/word-break.html

css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSPropertyNames.in:
css/CSSValueKeywords.in:
css/cssparser.cpp: (WebCore::CSSParser::parseValue):
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
rendering/RenderStyle.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator==): (WebCore::RenderStyle::diff):
rendering/RenderStyle.h: (WebCore::): (WebCore::RenderStyle::breakWords): (WebCore::RenderStyle::wordBreak): (WebCore::RenderStyle::setWordBreak): (WebCore::RenderStyle::initialWordBreak): (WebCore::RenderStyle::initialWordWrap):
rendering/RenderText.cpp: (WebCore::RenderText::calcMinMaxWidthInternal):
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createInnerTextStyle): (WebCore::RenderTextControl::calcHeight):
rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak):

9:59 PM Changeset in webkit [20966] by bdash

2 edits in trunk/WebCore

2007-04-20 Mark Rowe <mrowe@apple.com>

Qt build fix for FreeBSD.

WebCore.pro: FreeBSD needs HAVE_PTHREAD_NP_H defined.

9:06 PM BuildingQtOnLinux edited by bdash@webkit.org

Info about another build error. (diff)

8:02 PM Changeset in webkit [23322] by aroben

6 edits in branches/WindowsMerge/WebKitTools

Reviewed by Steve.

Get rid of all uses of ATL CString in DumpRenderTree.

Also fixed a couple of bugs related to SAFEARRAY usage.

Unless otherwise noted, changes are simple converting CString usage to
std::wstring.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize): (dumpFrameScrollPosition): The bounds of a SAFEARRAY are inclusive, so the length is upper - lower + 1. (compareHistoryItems): The vector we're sorting now holds COMPtrs, so changed to reflect that. (dumpHistoryItem): Use a Vector of COMPtrs to hold the child items, and fixed length calculation. (dumpBackForwardList): Use a Vector of COMPtrs to hold the items so that they are retained properly. (main):
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: (dumpPath): (dump):
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (jsValueToWString): (queueLoadCallback): (queueScriptCallback):
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: (LoadItem::invoke): (ScriptItem::invoke):
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: (LoadItem::LoadItem): (LoadItem::url): (LoadItem::target): (ScriptItem::ScriptItem): (ScriptItem::script):

7:50 PM Changeset in webkit [20965] by oliver

2 edits in trunk/WebKit

2007-04-19 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

Fix for <rdar://problem/4960912> -- REGRESSION: Content-Disposition:
filename is ignored for drag-and-drop.

WebView/WebResource.mm: (-[WebResource _fileWrapperRepresentation]): When creating the NSFileWrapper check the response for a preferred filename, rather than just blindly hoping for the best.

7:09 PM Changeset in webkit [20964] by bdash

2 edits in trunk/WebCore

2007-04-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13403 REGRESSION (r18875-r18899): Can no longer type into search form field after searching and then clicking "back"

The problem was that the page was loaded from the page cache with a subtree
marked for layout and the layout timer stopped (having been stopped when the
page entered the page cache). FrameView::needsLayout() was returning false
which prevented the pending layout from completing.

page/FrameView.cpp: (WebCore::FrameView::clear): Removed the call to stop the layout timer, since reset() does that already. (WebCore::FrameView::needsLayout): Changed to return true if there's a subtree pending relayout.

7:08 PM Changeset in webkit [20963] by bdash

78 edits
1 add
2 deletes in trunk/LayoutTests

2007-04-19 Mitz Pettel <mitz@webkit.org>

Rubber-stamped by Adam.

http://bugs.webkit.org/show_bug.cgi?id=13412 Replace abe.jpg with a PNG file

editing/abe.jpg: Removed.
editing/deleting/4866671.html:
editing/deleting/delete-3608462-fix.html:
editing/deleting/delete-image-001.html:
editing/deleting/delete-image-002.html:
editing/deleting/delete-image-003.html:
editing/deleting/delete-image-004.html:
editing/execCommand/5080333-1-expected.checksum:
editing/execCommand/5080333-1-expected.png:
editing/execCommand/5080333-1.html:
editing/execCommand/5080333-2-expected.checksum:
editing/execCommand/5080333-2-expected.png:
editing/execCommand/5080333-2.html:
editing/execCommand/createLink-expected.txt:
editing/execCommand/createLink.html:
editing/execCommand/insertImage-expected.checksum:
editing/execCommand/insertImage-expected.png:
editing/execCommand/insertImage.html:
editing/execCommand/unlink-expected.txt:
editing/execCommand/unlink.html:
editing/inserting/12882.html:
editing/inserting/typing-around-image-001.html:
editing/pasteboard/4641033-expected.checksum:
editing/pasteboard/4641033-expected.png:
editing/pasteboard/4641033.html:
editing/pasteboard/4947130-expected.checksum:
editing/pasteboard/4947130-expected.png:
editing/pasteboard/4947130.html:
editing/pasteboard/4989774-expected.checksum:
editing/pasteboard/4989774-expected.png:
editing/pasteboard/4989774.html:
editing/pasteboard/copy-standalone-image.html:
editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum:
editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png:
editing/pasteboard/drag-image-to-contenteditable-in-iframe.html:
editing/pasteboard/drag-selected-image-to-contenteditable-expected.checksum:
editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
editing/pasteboard/drag-selected-image-to-contenteditable.html:
editing/pasteboard/styled-element-markup-expected.checksum:
editing/pasteboard/styled-element-markup-expected.png:
editing/pasteboard/styled-element-markup.html:
editing/resources/abe.jpg: Removed.
editing/resources/abe.png: Added.
editing/selection/4402375-expected.checksum:
editing/selection/4402375-expected.png:
editing/selection/4402375.html:
editing/selection/4932260-1-expected.checksum:
editing/selection/4932260-1-expected.png:
editing/selection/4932260-1.html:
editing/selection/4932260-2-expected.checksum:
editing/selection/4932260-2-expected.png:
editing/selection/4932260-2.html:
editing/selection/4932260-3-expected.checksum:
editing/selection/4932260-3-expected.png:
editing/selection/4932260-3.html:
editing/selection/drag-to-contenteditable-iframe-expected.checksum:
editing/selection/drag-to-contenteditable-iframe-expected.png:
editing/selection/drag-to-contenteditable-iframe.html:
editing/selection/extend-by-character-002-expected.checksum:
editing/selection/extend-by-character-002-expected.png:
editing/selection/extend-by-character-002.html:
editing/selection/extend-by-character-004-expected.checksum:
editing/selection/extend-by-character-004-expected.png:
editing/selection/extend-by-character-004.html:
editing/selection/image-before-linebreak-expected.checksum:
editing/selection/image-before-linebreak-expected.png:
editing/selection/image-before-linebreak.html:
editing/selection/legal-positions.html:
editing/selection/move-by-character-002-expected.checksum:
editing/selection/move-by-character-002-expected.png:
editing/selection/move-by-character-002.html:
editing/selection/move-by-character-004-expected.checksum:
editing/selection/move-by-character-004-expected.png:
editing/selection/move-by-character-004.html:
editing/selection/replaced-boundaries-1-expected.checksum:
editing/selection/replaced-boundaries-1-expected.png:
editing/selection/replaced-boundaries-1.html:
editing/selection/replaced-boundaries-2-expected.checksum:
editing/selection/replaced-boundaries-2-expected.png:
editing/selection/replaced-boundaries-2.html:

6:53 PM Changeset in webkit [20962] by justing

8 edits
4 adds in trunk

LayoutTests:

Reviewed by harrison

<rdar://problem/5144139>
On delete, <BR> inserted into non-editable ToDo <TABLE> element

editing/deleting/5144139-2-expected.checksum: Added.
editing/deleting/5144139-2-expected.png: Added.
editing/deleting/5144139-2-expected.txt: Added.
editing/deleting/5144139-2.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/5144139>
On delete, <BR> inserted into non-editable ToDo <TABLE> element

The fact that the br was being inserted at a bad position
(a non-editable position and one inside a table instead of
before it) was fixed in the previous checkin. This change
stops us from inserting a br at all, to fix the bug.

After a delete, we need a placeholder if the selection
started at the start of a paragraph and ended at the end
of a paragraph. But not if it starts just before a table
and ends inside that table. We need placeholders to hold
open emptied out table cells, but that is handled separately.

Also, moved lineBreakExistsAtPosition to htmlediting.cpp
so that it can be used in more places.

editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removePlaceholderAt): (WebCore::CompositeEditCommand::moveParagraphs):
editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply):
editing/InsertLineBreakCommand.cpp:
editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
editing/htmlediting.cpp: (WebCore::lineBreakExistsAtPosition):
editing/htmlediting.h:

6:10 PM Changeset in webkit [23321] by sfalken

3 edits in branches/WindowsMerge/WebKitTools

2007-04-19 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.

Eliminate more ATL use (CComSafeArray).

In one place, we were using SafeArray for something that was better served
by WTF::Vector. I added WTF to the vcproj as part of this patch.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dumpFrameScrollPosition): (dumpHistoryItem): (dumpBackForwardList):
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:

5:49 PM Changeset in webkit [20961] by sfalken

1 copy in tags/Safari-522.6.2b

New tag.

5:08 PM Changeset in webkit [20960] by justing

13 edits
4 adds in trunk

LayoutTests:

Reviewed by harrison

editing/execCommand/5144139-1-expected.checksum: Added.
editing/execCommand/5144139-1-expected.png: Added.
editing/execCommand/5144139-1-expected.txt: Added.
editing/execCommand/5144139-1.html: Added.

WebCore:

Reviewed by harrison

Fixes some issues found while investigating:
<rdar://problem/5144139> On delete, <BR> inserted into non-editable ToDo <TABLE> element

Move the code to handle inserting content before/after
tables for [table, 0/max] to insertNodeAt, so that
all insertions get it, not just some.
Changed insertNodeAt to take in a position instead of a
node and an offset.

editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNodeAt): (WebCore::CompositeEditCommand::insertNodeAtTabSpanPosition): (WebCore::CompositeEditCommand::insertBlockPlaceholder): (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): If paragrahStart.node() is an atomic node, insertNodeAt can handle insertion, we don't need to special case it. (WebCore::CompositeEditCommand::moveParagraphs): (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
editing/CompositeEditCommand.h:
editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): (WebCore::DeleteSelectionCommand::doApply):
editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::doApply):
editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::indentRegion): (WebCore::IndentOutdentCommand::outdentParagraph):
editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply):
editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::prepareForTextInsertion): Removed some dead code that handled insertion at non-editable positions. (WebCore::InsertTextCommand::insertTab):
editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): (WebCore::ReplaceSelectionCommand::insertNodeAtAndUpdateNodesInserted):
editing/ReplaceSelectionCommand.h:

3:35 PM Changeset in webkit [20959] by andrew

7 edits in trunk/WebCore

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13336 REGRESSION (r20646): editing/execCommand/hilitecolor.html crashes under guardMalloc

Avoid calling selectionRect() and selectionGapRects() on a renderer that needs
layout.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::selectionGapRects):
rendering/RenderBlock.h: (WebCore::RenderBlock::BlockSelectionInfo::BlockSelectionInfo):
rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::selectionRect):
rendering/RenderObject.h: (WebCore::RenderObject::SelectionInfo::SelectionInfo):
rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::selectionRect):
rendering/RenderText.cpp: (WebCore::RenderText::selectionRect):

1:27 PM Changeset in webkit [20958] by justing

7 edits
12 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/5142012>
GoogleDocs: Crash at WebCore::Range::startPosition() when creating a list from a link

Tests the change to pushAnchorElementDown, where we remove
the anchor element that has had copies of it pushed down:

editing/execCommand/5142012-1-expected.checksum: Added.
editing/execCommand/5142012-1-expected.png: Added.
editing/execCommand/5142012-1-expected.txt: Added.
editing/execCommand/5142012-1.html: Added.

Demonstrates the crash (fixed by adding nil-checks
to moveParagraphs):

editing/execCommand/5142012-2-expected.checksum: Added.
editing/execCommand/5142012-2-expected.png: Added.
editing/execCommand/5142012-2-expected.txt: Added.
editing/execCommand/5142012-2.html: Added.

Tests the changes to positionAvoidingSpecialElementBoundary,
where we push down anchors before we avoid them so that
we don't also avoid structural elements like lists and paragraphs:

editing/execCommand/5142012-3-expected.checksum: Added.
editing/execCommand/5142012-3-expected.png: Added.
editing/execCommand/5142012-3-expected.txt: Added.
editing/execCommand/5142012-3.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/5142012>
GoogleDocs: Crash at WebCore::Range::startPosition() when creating a list from a link

List creation uses moveParagraphs to push content into list items.
Its fragment creation (using createMarkup) incorrectly uses regular
spaces instead of nbsps for spaces that were rendered (11475), which
causes spaces to be collapsed during the move operation. This results
in a call to rangeFromLocationAndLength with a location past the end
of the document. We use the result from rangeFromLocationAndLength
(null) and crash.

Also when moveParagraphs tries to push content into a list item surrounded
by an anchor, it fails because positionAvoidingSpecialElementBoundary avoids
the anchor, which also avoids the list item. This was fixed by pushing
down anchors before avoiding them.

editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::pushAnchorElementDown): Remove the old anchor after we push down clones of it, this is what callers expect. (WebCore::CompositeEditCommand::pushPartiallySelectedAnchorElementsDown): Call the new enclosingAnchorElement, that takes in a position instead of a node. (WebCore::CompositeEditCommand::moveParagraphs): If spaces collapsed as a result of the move, rangeFromLocationAndLength can return null, bail and don't try to preserve the selection in that case. (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary): Moved from htmlediting.cpp. Make sure anchors are pushed down before avoiding them so that we don't also avoid structural elements like lists and blocks.
editing/CompositeEditCommand.h:
editing/TypingCommand.cpp: Moved isFirst/LastPositionBefore/AfterTable to htmlediting.cpp.
editing/htmlediting.cpp: Moved positionAvoidingSpecialElementBoundary so that it could call pushAnchorElementDown. (WebCore::isFirstPositionAfterTable): Moved here. (WebCore::isLastPositionBeforeTable): Moved here. (WebCore::enclosingAnchorElement): Moved here. (WebCore::enclosingListChild): Removed an extraneous space.
editing/htmlediting.h:

12:58 PM Changeset in webkit [20957] by bdakin

21 edits
2 moves
6 adds
6 deletes in trunk

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/5120889> Sized table cells w/borders not
drawn to correct size

When table cells have children with %-height, the cells were
incorrectly shrinking down to be the size of the child. This
exposed another problem with replaced children and sizing.

rendering/RenderBox.cpp: (WebCore::RenderBox::calcReplacedHeightUsing): The exposed problem. Subtract our borders and padding in the auto or percent table cell containing block case.
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows): When our children can flex, do not always set the cellTopExtra and cellBottomExtra to 0! That is bad! We should do the same as the non-flex case.

Layout Tests:

Reviewed by Hyatt.

Series of new/rearranged results after fix for <rdar://problem/
5120889> Sized table cells w/borders not drawn to correct size

These tests are different by tiny, barely noticeable amounts. The
new results are more correct. We didn't catch the problem before
because it was so subtle here:

fast/replaced/width100percent-expected.txt:
fast/table/003-expected.checksum:
fast/table/003-expected.png:
fast/table/003-expected.txt:

This is the test that exposed the other problem with replaced
children. Now we fit snugly inside the border on the bottom, which
is different than Firefox, but seems right.

tables/mozilla/bugs/bug131020-expected.checksum:
tables/mozilla/bugs/bug131020-expected.png:
tables/mozilla/bugs/bug131020-expected.txt:

This test actually always failed and was incorrectly filed as a
success. Moving to failures.

tables/mozilla/bugs/bug137388-2-expected.checksum: Removed.
tables/mozilla/bugs/bug137388-2-expected.png: Removed.
tables/mozilla/bugs/bug137388-2-expected.txt: Removed.
tables/mozilla/bugs/bug137388-2.html: Removed.
tables/mozilla_expected_failures/bugs/bug137388-2-expected.checksum: Added.
tables/mozilla_expected_failures/bugs/bug137388-2-expected.png: Added.
tables/mozilla_expected_failures/bugs/bug137388-2-expected.txt: Added.

This test was actually wrong before, and now it is right!

tables/mozilla/bugs/bug149275-2-expected.checksum:
tables/mozilla/bugs/bug149275-2-expected.png:
tables/mozilla/bugs/bug149275-2-expected.txt:

This was a failing test that now passes. YAY!

tables/mozilla/bugs/bug18440-expected.checksum: Added.
tables/mozilla/bugs/bug18440-expected.png: Added.
tables/mozilla/bugs/bug18440-expected.txt: Added.

tables/mozilla_expected_failures/bugs/bug18440-expected.checksum: Removed.
- tables/mozilla_expected_failures/bugs/bug18440-expected.png: Removed.
- tables/mozilla_expected_failures/bugs/bug18440-expected.txt: Removed.
- tables/mozilla_expected_failures/bugs/bug18440.html: Removed.

This was slightly wrong before and is now correct.

tables/mozilla/bugs/bug30692-expected.checksum:
tables/mozilla/bugs/bug30692-expected.png:
tables/mozilla/bugs/bug30692-expected.txt:

Still wrong, but slightly more correct.

tables/mozilla_expected_failures/bugs/bug137388-1-expected.checksum:
tables/mozilla_expected_failures/bugs/bug137388-1-expected.png:
tables/mozilla_expected_failures/bugs/bug137388-1-expected.txt:

So much closer to being correct!! But still slightly wrong.

tables/mozilla_expected_failures/bugs/bug19526-expected.txt:

12:57 PM Changeset in webkit [20956] by thatcher

6 edits in branches/WebInspectorRefresh/WebKit/WebInspector

Address review comments Darin made.

12:37 PM Changeset in webkit [20955] by brmorris

2 edits in S60/branches/3.1m/WebKit

brad, reviewed by zalan

DESC: add ContentAccess namespace to StaticImageDecoder.cpp

BrowserCore/Renderers/src/StaticImageDecoder.cpp:

12:19 PM Changeset in webkit [20954] by andersca

5 edits
2 adds in trunk

LayoutTests:

Reviewed by Geoff.

http://bugs.webkit.org/show_bug.cgi?id=13333
Support naturalWidth/naturalHeight on image elements

fast/dom/HTMLImageElement/image-natural-width-height-expected.txt: Added.
fast/dom/HTMLImageElement/image-natural-width-height.html: Added.

WebCore:

Reviewed by Geoff.

http://bugs.webkit.org/show_bug.cgi?id=13333
Support naturalWidth/naturalHeight on image elements

html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::naturalWidth): (WebCore::HTMLImageElement::naturalHeight):
html/HTMLImageElement.h:
html/HTMLImageElement.idl:

11:56 AM Changeset in webkit [20953] by pyeh

2 edits in trunk/WebCore

review suggestion for rdar://5145011 code change

bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject value]): return early if value attribute is not supported by the attachment view.

11:21 AM Changeset in webkit [20952] by pyeh

2 edits in trunk/WebCore

<rdar://problem/5145011> Allow attachment view of web object to handle accessibility actions

bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject value]): Only allow asking the attachmentView for value if attachmentView supports this value attribute (-[WebCoreAXObject title]): (-[WebCoreAXObject accessibilityAttributeNames]): Should not return that long list of unrelated attributes for attachmentView. (-[WebCoreAXObject accessibilityActionNames]): (-[WebCoreAXObject accessibilityPerformAction:]): Allow attachmentView a chance to handle actions. (-[WebCoreAXObject accessibilityParameterizedAttributeNames]): Should not return that long list of unrelated attributes for attachmentView.

9:47 AM Changeset in webkit [20951] by andersca

3 edits in trunk/WebKit

Reviewed by John.

<rdar://problem/5137002>
REGRESSION (r20812): [WebFrame DOMDocument] is returning non-nil value in bookmarks view, causing trouble in Safari

Put back the MIME type check as a workaround.

WebView/WebFrame.mm: (-[WebFrame DOMDocument]):

8:24 AM GtkAPIProposal edited by bdash@webkit.org

(diff)

8:20 AM GtkAPIProposal created by christian@twotoasts.de

7:47 AM Changeset in webkit [20950] by weinig

532 edits in trunk

LayoutTests:

Reviewed by Hyatt

updated results for http://bugs.webkit.org/show_bug.cgi?id=13291 REGRESSION (r19595): WebViewDidBeginEditingNotification not posted when focusing with the mouse

editing/deleting/4845371-expected.txt:
editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
editing/deleting/delete-3608430-fix-expected.txt:
editing/deleting/delete-3608445-fix-expected.txt:
editing/deleting/delete-3608462-fix-expected.txt:
editing/deleting/delete-3775172-fix-expected.txt:
editing/deleting/delete-3800834-fix-expected.txt:
editing/deleting/delete-3857753-fix-expected.txt:
editing/deleting/delete-3865854-fix-expected.txt:
editing/deleting/delete-3928305-fix-expected.txt:
editing/deleting/delete-3959464-fix-expected.txt:
editing/deleting/delete-4038408-fix-expected.txt:
editing/deleting/delete-4083333-fix-expected.txt:
editing/deleting/delete-after-span-ws-001-expected.txt:
editing/deleting/delete-after-span-ws-002-expected.txt:
editing/deleting/delete-after-span-ws-003-expected.txt:
editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
editing/deleting/delete-and-undo-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
editing/deleting/delete-at-start-or-end-expected.txt:
editing/deleting/delete-block-contents-001-expected.txt:
editing/deleting/delete-block-contents-002-expected.txt:
editing/deleting/delete-block-contents-003-expected.txt:
editing/deleting/delete-block-merge-contents-001-expected.txt:
editing/deleting/delete-block-merge-contents-002-expected.txt:
editing/deleting/delete-block-merge-contents-003-expected.txt:
editing/deleting/delete-block-merge-contents-004-expected.txt:
editing/deleting/delete-block-merge-contents-005-expected.txt:
editing/deleting/delete-block-merge-contents-006-expected.txt:
editing/deleting/delete-block-merge-contents-007-expected.txt:
editing/deleting/delete-block-merge-contents-008-expected.txt:
editing/deleting/delete-block-merge-contents-009-expected.txt:
editing/deleting/delete-block-merge-contents-010-expected.txt:
editing/deleting/delete-block-merge-contents-011-expected.txt:
editing/deleting/delete-block-merge-contents-012-expected.txt:
editing/deleting/delete-block-merge-contents-013-expected.txt:
editing/deleting/delete-block-merge-contents-014-expected.txt:
editing/deleting/delete-block-merge-contents-015-expected.txt:
editing/deleting/delete-block-merge-contents-016-expected.txt:
editing/deleting/delete-block-merge-contents-017-expected.txt:
editing/deleting/delete-block-merge-contents-018-expected.txt:
editing/deleting/delete-block-merge-contents-019-expected.txt:
editing/deleting/delete-block-merge-contents-020-expected.txt:
editing/deleting/delete-block-merge-contents-021-expected.txt:
editing/deleting/delete-block-merge-contents-022-expected.txt:
editing/deleting/delete-block-merge-contents-023-expected.txt:
editing/deleting/delete-block-merge-contents-024-expected.txt:
editing/deleting/delete-block-table-expected.txt:
editing/deleting/delete-br-001-expected.txt:
editing/deleting/delete-br-002-expected.txt:
editing/deleting/delete-br-003-expected.txt:
editing/deleting/delete-br-004-expected.txt:
editing/deleting/delete-br-005-expected.txt:
editing/deleting/delete-br-006-expected.txt:
editing/deleting/delete-br-007-expected.txt:
editing/deleting/delete-br-008-expected.txt:
editing/deleting/delete-br-009-expected.txt:
editing/deleting/delete-br-010-expected.txt:
editing/deleting/delete-br-011-expected.txt:
editing/deleting/delete-br-012-expected.txt:
editing/deleting/delete-by-word-001-expected.txt:
editing/deleting/delete-by-word-002-expected.txt:
editing/deleting/delete-character-001-expected.txt:
editing/deleting/delete-contiguous-ws-001-expected.txt:
editing/deleting/delete-first-list-item-expected.txt:
editing/deleting/delete-hr-expected.txt:
editing/deleting/delete-image-001-expected.txt:
editing/deleting/delete-image-002-expected.txt:
editing/deleting/delete-image-003-expected.txt:
editing/deleting/delete-image-004-expected.txt:
editing/deleting/delete-leading-ws-001-expected.txt:
editing/deleting/delete-line-001-expected.txt:
editing/deleting/delete-line-002-expected.txt:
editing/deleting/delete-line-003-expected.txt:
editing/deleting/delete-line-004-expected.txt:
editing/deleting/delete-line-005-expected.txt:
editing/deleting/delete-line-006-expected.txt:
editing/deleting/delete-line-007-expected.txt:
editing/deleting/delete-line-008-expected.txt:
editing/deleting/delete-line-009-expected.txt:
editing/deleting/delete-line-010-expected.txt:
editing/deleting/delete-line-011-expected.txt:
editing/deleting/delete-line-012-expected.txt:
editing/deleting/delete-line-013-expected.txt:
editing/deleting/delete-line-014-expected.txt:
editing/deleting/delete-line-015-expected.txt:
editing/deleting/delete-line-016-expected.txt:
editing/deleting/delete-line-017-expected.txt:
editing/deleting/delete-line-end-ws-001-expected.txt:
editing/deleting/delete-line-end-ws-002-expected.txt:
editing/deleting/delete-link-1-expected.txt:
editing/deleting/delete-listitem-001-expected.txt:
editing/deleting/delete-listitem-002-expected.txt:
editing/deleting/delete-mixed-editable-content-001-expected.txt:
editing/deleting/delete-select-all-001-expected.txt:
editing/deleting/delete-select-all-002-expected.txt:
editing/deleting/delete-select-all-003-expected.txt:
editing/deleting/delete-selection-001-expected.txt:
editing/deleting/delete-tab-001-expected.txt:
editing/deleting/delete-tab-002-expected.txt:
editing/deleting/delete-tab-003-expected.txt:
editing/deleting/delete-tab-004-expected.txt:
editing/deleting/delete-to-end-of-paragraph-expected.txt:
editing/deleting/delete-to-select-table-expected.txt:
editing/deleting/delete-trailing-ws-001-expected.txt:
editing/deleting/delete-trailing-ws-002-expected.txt:
editing/deleting/delete-ws-fixup-001-expected.txt:
editing/deleting/delete-ws-fixup-002-expected.txt:
editing/deleting/delete-ws-fixup-003-expected.txt:
editing/deleting/delete-ws-fixup-004-expected.txt:
editing/deleting/forward-delete-expected.txt:
editing/deleting/list-item-1-expected.txt:
editing/deleting/merge-different-styles-expected.txt:
editing/deleting/merge-endOfParagraph-expected.txt:
editing/deleting/merge-into-empty-block-1-expected.txt:
editing/deleting/merge-into-empty-block-2-expected.txt:
editing/deleting/merge-no-br-expected.txt:
editing/deleting/merge-unrendered-space-expected.txt:
editing/deleting/paragraph-in-preserveNewline-expected.txt:
editing/deleting/pruning-after-merge-1-expected.txt:
editing/deleting/pruning-after-merge-2-expected.txt:
editing/deleting/smart-delete-001-expected.txt:
editing/deleting/smart-delete-002-expected.txt:
editing/deleting/smart-delete-003-expected.txt:
editing/deleting/smart-delete-004-expected.txt:
editing/deleting/table-cells-expected.txt:
editing/deleting/transpose-empty-expected.txt:
editing/deleting/whitespace-pre-1-expected.txt:
editing/execCommand/4641880-1-expected.txt:
editing/execCommand/4641880-2-expected.txt:
editing/execCommand/boldSelection-expected.txt:
editing/execCommand/create-list-from-range-selection-expected.txt:
editing/execCommand/create-list-with-hr-expected.txt:
editing/execCommand/createLink-expected.txt:
editing/execCommand/format-block-expected.txt:
editing/execCommand/format-block-from-range-selection-expected.txt:
editing/execCommand/format-block-with-braces-expected.txt:
editing/execCommand/format-block-with-trailing-br-expected.txt:
editing/execCommand/hilitecolor-expected.txt:
editing/execCommand/indent-empty-root-expected.txt:
editing/execCommand/indent-list-item-expected.txt:
editing/execCommand/indent-selection-expected.txt:
editing/execCommand/insert-list-and-stitch-expected.txt:
editing/execCommand/insert-list-with-id-expected.txt:
editing/execCommand/insertHTML-expected.txt:
editing/execCommand/insertHorizontalRule-expected.txt:
editing/execCommand/insertImage-expected.txt:
editing/execCommand/italicizeByCharacter-expected.txt:
editing/execCommand/modifyForeColorByCharacter-expected.txt:
editing/execCommand/nsresponder-indent-expected.txt:
editing/execCommand/nsresponder-outdent-expected.txt:
editing/execCommand/outdent-selection-expected.txt:
editing/execCommand/print-expected.txt:
editing/execCommand/queryCommandState-01-expected.txt:
editing/execCommand/remove-formatting-2-expected.txt:
editing/execCommand/remove-formatting-expected.txt:
editing/execCommand/remove-list-from-range-selection-expected.txt:
editing/execCommand/remove-list-item-1-expected.txt:
editing/execCommand/remove-list-items-expected.txt:
editing/execCommand/selectAll-expected.txt:
editing/execCommand/strikethroughSelection-expected.txt:
editing/execCommand/switch-list-type-expected.txt:
editing/execCommand/unlink-expected.txt:
editing/input/firstrectforcharacterrange-plain-expected.txt:
editing/input/firstrectforcharacterrange-styled-expected.txt:
editing/input/wrapped-line-char-rect-expected.txt:
editing/inserting/4278698-expected.txt:
editing/inserting/before-after-input-element-expected.txt:
editing/inserting/editable-html-element-expected.txt:
editing/inserting/editing-empty-divs-expected.txt:
editing/inserting/insert-3654864-fix-expected.txt:
editing/inserting/insert-3659587-fix-expected.txt:
editing/inserting/insert-3775316-fix-expected.txt:
editing/inserting/insert-3778059-fix-expected.txt:
editing/inserting/insert-3786362-fix-expected.txt:
editing/inserting/insert-3800346-fix-expected.txt:
editing/inserting/insert-3851164-fix-expected.txt:
editing/inserting/insert-3907422-fix-expected.txt:
editing/inserting/insert-after-delete-001-expected.txt:
editing/inserting/insert-at-end-01-expected.txt:
editing/inserting/insert-at-end-02-expected.txt:
editing/inserting/insert-before-link-1-expected.txt:
editing/inserting/insert-br-001-expected.txt:
editing/inserting/insert-br-002-expected.txt:
editing/inserting/insert-br-003-expected.txt:
editing/inserting/insert-br-004-expected.txt:
editing/inserting/insert-br-005-expected.txt:
editing/inserting/insert-br-006-expected.txt:
editing/inserting/insert-br-007-expected.txt:
editing/inserting/insert-br-008-expected.txt:
editing/inserting/insert-br-009-expected.txt:
editing/inserting/insert-br-at-tabspan-001-expected.txt:
editing/inserting/insert-br-at-tabspan-002-expected.txt:
editing/inserting/insert-br-at-tabspan-003-expected.txt:
editing/inserting/insert-br-quoted-001-expected.txt:
editing/inserting/insert-br-quoted-002-expected.txt:
editing/inserting/insert-br-quoted-003-expected.txt:
editing/inserting/insert-br-quoted-004-expected.txt:
editing/inserting/insert-br-quoted-005-expected.txt:
editing/inserting/insert-br-quoted-006-expected.txt:
editing/inserting/insert-div-001-expected.txt:
editing/inserting/insert-div-002-expected.txt:
editing/inserting/insert-div-003-expected.txt:
editing/inserting/insert-div-004-expected.txt:
editing/inserting/insert-div-005-expected.txt:
editing/inserting/insert-div-006-expected.txt:
editing/inserting/insert-div-007-expected.txt:
editing/inserting/insert-div-008-expected.txt:
editing/inserting/insert-div-009-expected.txt:
editing/inserting/insert-div-010-expected.txt:
editing/inserting/insert-div-011-expected.txt:
editing/inserting/insert-div-012-expected.txt:
editing/inserting/insert-div-013-expected.txt:
editing/inserting/insert-div-014-expected.txt:
editing/inserting/insert-div-015-expected.txt:
editing/inserting/insert-div-016-expected.txt:
editing/inserting/insert-div-017-expected.txt:
editing/inserting/insert-div-018-expected.txt:
editing/inserting/insert-div-019-expected.txt:
editing/inserting/insert-div-020-expected.txt:
editing/inserting/insert-div-021-expected.txt:
editing/inserting/insert-div-022-expected.txt:
editing/inserting/insert-div-023-expected.txt:
editing/inserting/insert-div-024-expected.txt:
editing/inserting/insert-div-025-expected.txt:
editing/inserting/insert-div-026-expected.txt:
editing/inserting/insert-div-027-expected.txt:
editing/inserting/insert-paragraph-01-expected.txt:
editing/inserting/insert-paragraph-02-expected.txt:
editing/inserting/insert-paragraph-03-expected.txt:
editing/inserting/insert-paragraph-04-expected.txt:
editing/inserting/insert-space-in-empty-doc-expected.txt:
editing/inserting/insert-tab-001-expected.txt:
editing/inserting/insert-tab-002-expected.txt:
editing/inserting/insert-tab-003-expected.txt:
editing/inserting/insert-tab-004-expected.txt:
editing/inserting/insert-text-at-tabspan-001-expected.txt:
editing/inserting/insert-text-at-tabspan-002-expected.txt:
editing/inserting/insert-text-at-tabspan-003-expected.txt:
editing/inserting/insert-text-with-newlines-expected.txt:
editing/inserting/line-break-expected.txt:
editing/inserting/multiple-lines-selected-expected.txt:
editing/inserting/paragraph-separator-01-expected.txt:
editing/inserting/paragraph-separator-02-expected.txt:
editing/inserting/paragraph-separator-03-expected.txt:
editing/inserting/paragraph-separator-in-table-1-expected.txt:
editing/inserting/paragraph-separator-in-table-2-expected.txt:
editing/inserting/redo-expected.txt:
editing/inserting/return-key-with-selection-001-expected.txt:
editing/inserting/return-key-with-selection-002-expected.txt:
editing/inserting/return-key-with-selection-003-expected.txt:
editing/inserting/typing-001-expected.txt:
editing/inserting/typing-002-expected.txt:
editing/inserting/typing-003-expected.txt:
editing/inserting/typing-around-br-001-expected.txt:
editing/inserting/typing-around-image-001-expected.txt:
editing/pasteboard/3976872-expected.txt:
editing/pasteboard/4076267-2-expected.txt:
editing/pasteboard/4076267-3-expected.txt:
editing/pasteboard/4076267-expected.txt:
editing/pasteboard/4242293-1-expected.txt:
editing/pasteboard/4242293-expected.txt:
editing/pasteboard/4631972-expected.txt:
editing/pasteboard/4641033-expected.txt:
editing/pasteboard/4700297-expected.txt:
editing/pasteboard/4744008-expected.txt:
editing/pasteboard/8145-1-expected.txt:
editing/pasteboard/8145-2-expected.txt:
editing/pasteboard/8145-3-expected.txt:
editing/pasteboard/bad-placeholder-expected.txt:
editing/pasteboard/block-wrappers-necessary-expected.txt:
editing/pasteboard/copy-in-password-field-expected.txt:
editing/pasteboard/copy-standalone-image-expected.txt:
editing/pasteboard/cut-text-001-expected.txt:
editing/pasteboard/displaced-generic-placeholder-expected.txt:
editing/pasteboard/displaced-placeholder-expected.txt:
editing/pasteboard/display-block-on-spans-expected.txt:
editing/pasteboard/drag-drop-modifies-page-expected.txt:
editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt:
editing/pasteboard/drop-link-expected.txt:
editing/pasteboard/emacs-cntl-y-001-expected.txt:
editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
editing/pasteboard/interchange-newline-1-expected.txt:
editing/pasteboard/interchange-newline-2-expected.txt:
editing/pasteboard/interchange-newline-3-expected.txt:
editing/pasteboard/interchange-newline-4-expected.txt:
editing/pasteboard/merge-after-delete-1-expected.txt:
editing/pasteboard/merge-after-delete-2-expected.txt:
editing/pasteboard/merge-after-delete-expected.txt:
editing/pasteboard/merge-end-3-expected.txt:
editing/pasteboard/merge-end-4-expected.txt:
editing/pasteboard/merge-end-5-expected.txt:
editing/pasteboard/merge-end-blockquote-expected.txt:
editing/pasteboard/merge-end-borders-expected.txt:
editing/pasteboard/merge-end-list-expected.txt:
editing/pasteboard/merge-end-table-expected.txt:
editing/pasteboard/merge-start-blockquote-expected.txt:
editing/pasteboard/merge-start-list-expected.txt:
editing/pasteboard/nested-blocks-with-text-area-expected.txt:
editing/pasteboard/nested-blocks-with-text-field-expected.txt:
editing/pasteboard/paste-4035648-fix-expected.txt:
editing/pasteboard/paste-4038267-fix-expected.txt:
editing/pasteboard/paste-4039777-fix-expected.txt:
editing/pasteboard/paste-RTFD-expected.txt:
editing/pasteboard/paste-TIFF-expected.txt:
editing/pasteboard/paste-line-endings-001-expected.txt:
editing/pasteboard/paste-line-endings-002-expected.txt:
editing/pasteboard/paste-line-endings-003-expected.txt:
editing/pasteboard/paste-line-endings-004-expected.txt:
editing/pasteboard/paste-line-endings-005-expected.txt:
editing/pasteboard/paste-line-endings-006-expected.txt:
editing/pasteboard/paste-line-endings-007-expected.txt:
editing/pasteboard/paste-line-endings-008-expected.txt:
editing/pasteboard/paste-line-endings-009-expected.txt:
editing/pasteboard/paste-line-endings-010-expected.txt:
editing/pasteboard/paste-list-001-expected.txt:
editing/pasteboard/paste-match-style-001-expected.txt:
editing/pasteboard/paste-match-style-002-expected.txt:
editing/pasteboard/paste-pre-001-expected.txt:
editing/pasteboard/paste-pre-002-expected.txt:
editing/pasteboard/paste-table-001-expected.txt:
editing/pasteboard/paste-table-002-expected.txt:
editing/pasteboard/paste-table-003-expected.txt:
editing/pasteboard/paste-text-001-expected.txt:
editing/pasteboard/paste-text-002-expected.txt:
editing/pasteboard/paste-text-003-expected.txt:
editing/pasteboard/paste-text-004-expected.txt:
editing/pasteboard/paste-text-005-expected.txt:
editing/pasteboard/paste-text-006-expected.txt:
editing/pasteboard/paste-text-007-expected.txt:
editing/pasteboard/paste-text-008-expected.txt:
editing/pasteboard/paste-text-009-expected.txt:
editing/pasteboard/paste-text-010-expected.txt:
editing/pasteboard/paste-text-011-expected.txt:
editing/pasteboard/paste-text-012-expected.txt:
editing/pasteboard/paste-text-013-expected.txt:
editing/pasteboard/paste-text-014-expected.txt:
editing/pasteboard/paste-text-015-expected.txt:
editing/pasteboard/paste-text-016-expected.txt:
editing/pasteboard/paste-text-017-expected.txt:
editing/pasteboard/paste-text-018-expected.txt:
editing/pasteboard/paste-text-019-expected.txt:
editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
editing/pasteboard/paste-xml-expected.txt:
editing/pasteboard/pasting-object-expected.txt:
editing/pasteboard/pasting-tabs-expected.txt:
editing/pasteboard/prevent-block-nesting-01-expected.txt:
editing/pasteboard/quirks-mode-br-1-expected.txt:
editing/pasteboard/quirks-mode-br-2-expected.txt:
editing/pasteboard/smart-paste-001-expected.txt:
editing/pasteboard/smart-paste-002-expected.txt:
editing/pasteboard/smart-paste-003-expected.txt:
editing/pasteboard/smart-paste-004-expected.txt:
editing/pasteboard/smart-paste-005-expected.txt:
editing/pasteboard/smart-paste-006-expected.txt:
editing/pasteboard/smart-paste-007-expected.txt:
editing/pasteboard/smart-paste-008-expected.txt:
editing/pasteboard/styled-element-markup-expected.txt:
editing/pasteboard/subframe-dragndrop-1-expected.txt:
editing/pasteboard/testcase-9507-expected.txt:
editing/pasteboard/undoable-fragment-removes-expected.txt:
editing/pasteboard/unrendered-br-expected.txt:
editing/selection/3690703-2-expected.txt:
editing/selection/3690703-expected.txt:
editing/selection/3690719-expected.txt:
editing/selection/4397952-expected.txt:
editing/selection/4932260-1-expected.txt:
editing/selection/4932260-2-expected.txt:
editing/selection/4932260-3-expected.txt:
editing/selection/4947387-expected.txt:
editing/selection/6476-expected.txt:
editing/selection/7152-1-expected.txt:
editing/selection/7152-2-expected.txt:
editing/selection/after-line-wrap-expected.txt:
editing/selection/caret-rtl-2-expected.txt:
editing/selection/caret-rtl-expected.txt:
editing/selection/click-before-and-after-table-expected.txt:
editing/selection/click-start-of-line-expected.txt:
editing/selection/designmode-no-caret-expected.txt:
editing/selection/editable-links-expected.txt:
editing/selection/editable-non-editable-crash-expected.txt:
editing/selection/end-of-document-expected.txt:
editing/selection/expanding-selections-expected.txt:
editing/selection/expanding-selections2-expected.txt:
editing/selection/extend-by-character-001-expected.txt:
editing/selection/extend-by-character-002-expected.txt:
editing/selection/extend-by-character-003-expected.txt:
editing/selection/extend-by-character-004-expected.txt:
editing/selection/extend-by-character-005-expected.txt:
editing/selection/extend-by-character-006-expected.txt:
editing/selection/extend-by-sentence-001-expected.txt:
editing/selection/extend-by-word-001-expected.txt:
editing/selection/extend-by-word-002-expected.txt:
editing/selection/fake-doubleclick-expected.txt:
editing/selection/fake-drag-expected.txt:
editing/selection/iframe-expected.txt:
editing/selection/image-before-linebreak-expected.txt:
editing/selection/inline-table-expected.txt:
editing/selection/leave-requested-block-expected.txt:
editing/selection/mixed-editability-1-expected.txt:
editing/selection/mixed-editability-3-expected.txt:
editing/selection/mixed-editability-4-expected.txt:
editing/selection/mixed-editability-5-expected.txt:
editing/selection/move-3875618-fix-expected.txt:
editing/selection/move-3875641-fix-expected.txt:
editing/selection/move-backwords-by-word-001-expected.txt:
editing/selection/move-between-blocks-no-001-expected.txt:
editing/selection/move-between-blocks-yes-001-expected.txt:
editing/selection/move-by-character-001-expected.txt:
editing/selection/move-by-character-002-expected.txt:
editing/selection/move-by-character-003-expected.txt:
editing/selection/move-by-character-004-expected.txt:
editing/selection/move-by-character-005-expected.txt:
editing/selection/move-by-character-6-expected.txt:
editing/selection/move-by-line-001-expected.txt:
editing/selection/move-by-line-002-expected.txt:
editing/selection/move-by-word-001-expected.txt:
editing/selection/previous-line-position-expected.txt:
editing/selection/replace-selection-1-expected.txt:
editing/selection/replaced-boundaries-1-expected.txt:
editing/selection/replaced-boundaries-2-expected.txt:
editing/selection/replaced-boundaries-3-expected.txt:
editing/selection/select-all-001-expected.txt:
editing/selection/select-all-002-expected.txt:
editing/selection/select-all-003-expected.txt:
editing/selection/select-all-004-expected.txt:
editing/selection/select-all-005-expected.txt:
editing/selection/select-all-006-expected.txt:
editing/selection/select-all-iframe-expected.txt:
editing/selection/select-box-expected.txt:
editing/selection/select-element-paragraph-boundary-expected.txt:
editing/selection/select-missing-image-expected.txt:
editing/selection/selection-3748164-fix-expected.txt:
editing/selection/skip-non-editable-1-expected.txt:
editing/selection/skip-non-editable-2-expected.txt:
editing/selection/table-caret-1-expected.txt:
editing/selection/table-caret-2-expected.txt:
editing/selection/table-caret-3-expected.txt:
editing/selection/triple-click-in-pre-expected.txt:
editing/selection/unrendered-001-expected.txt:
editing/selection/unrendered-002-expected.txt:
editing/selection/unrendered-003-expected.txt:
editing/selection/unrendered-004-expected.txt:
editing/selection/unrendered-005-expected.txt:
editing/selection/unrendered-space-expected.txt:
editing/spelling/spelling-expected.txt:
editing/style/apple-style-editable-mix-expected.txt:
editing/style/block-style-001-expected.txt:
editing/style/block-style-002-expected.txt:
editing/style/block-style-003-expected.txt:
editing/style/block-style-004-expected.txt:
editing/style/block-style-005-expected.txt:
editing/style/block-style-006-expected.txt:
editing/style/block-styles-007-expected.txt:
editing/style/create-block-for-style-001-expected.txt:
editing/style/create-block-for-style-002-expected.txt:
editing/style/create-block-for-style-003-expected.txt:
editing/style/create-block-for-style-004-expected.txt:
editing/style/create-block-for-style-005-expected.txt:
editing/style/create-block-for-style-006-expected.txt:
editing/style/create-block-for-style-007-expected.txt:
editing/style/create-block-for-style-008-expected.txt:
editing/style/create-block-for-style-009-expected.txt:
editing/style/create-block-for-style-010-expected.txt:
editing/style/create-block-for-style-011-expected.txt:
editing/style/create-block-for-style-012-expected.txt:
editing/style/create-block-for-style-013-expected.txt:
editing/style/designmode-expected.txt:
editing/style/non-inheritable-styles-expected.txt:
editing/style/relative-font-size-change-001-expected.txt:
editing/style/relative-font-size-change-002-expected.txt:
editing/style/relative-font-size-change-003-expected.txt:
editing/style/relative-font-size-change-004-expected.txt:
editing/style/remove-underline-across-paragraph-expected.txt:
editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
editing/style/remove-underline-after-paragraph-expected.txt:
editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
editing/style/remove-underline-expected.txt:
editing/style/remove-underline-from-stylesheet-expected.txt:
editing/style/remove-underline-in-bold-expected.txt:
editing/style/smoosh-styles-001-expected.txt:
editing/style/smoosh-styles-002-expected.txt:
editing/style/smoosh-styles-003-expected.txt:
editing/style/style-3681552-fix-001-expected.txt:
editing/style/style-3681552-fix-002-expected.txt:
editing/style/style-3690704-fix-expected.txt:
editing/style/style-3998892-fix-expected.txt:
editing/style/style-boundary-001-expected.txt:
editing/style/style-boundary-002-expected.txt:
editing/style/style-boundary-003-expected.txt:
editing/style/style-boundary-004-expected.txt:
editing/style/style-boundary-005-expected.txt:
editing/style/table-selection-expected.txt:
editing/style/typing-style-001-expected.txt:
editing/style/typing-style-002-expected.txt:
editing/style/typing-style-003-expected.txt:
editing/style/unbold-in-bold-expected.txt:
editing/style/underline-expected.txt:
editing/undo/4063751-expected.txt:
editing/undo/redo-typing-001-expected.txt:
editing/undo/undo-iframe-location-change-expected.txt:
editing/undo/undo-misspellings-expected.txt:
editing/undo/undo-typing-001-expected.txt:
editing/unsupported-content/list-delete-001-expected.txt:
editing/unsupported-content/list-delete-002-expected.txt:
editing/unsupported-content/list-delete-003-expected.txt:
editing/unsupported-content/list-type-after-expected.txt:
editing/unsupported-content/list-type-before-expected.txt:
editing/unsupported-content/table-delete-001-expected.txt:
editing/unsupported-content/table-delete-002-expected.txt:
editing/unsupported-content/table-delete-003-expected.txt:
editing/unsupported-content/table-type-after-expected.txt:
editing/unsupported-content/table-type-before-expected.txt:
fast/forms/focus-selection-input-expected.txt:

WebCore:

Reviewed by Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13291 REGRESSION (r19595): WebViewDidBeginEditingNotification not posted when focusing with the mouse

Covered by editing tests.

dom/Document.cpp: (WebCore::Document::setFocusedNode): Moved the call to Editor::didBeginEditing() back into here.
dom/Element.cpp: (WebCore::Element::updateFocusAppearance): Removed the call to didBeginEditing().
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateFocusAppearance): Ditto.

7:02 AM Changeset in webkit [20949] by bdash

3 edits
3 adds in trunk

2007-04-19 Mark Rowe <mrowe@apple.com>

Reviewed by Darin.

Fix http://bugs.webkit.org/show_bug.cgi?id=13401
Bug 13401: Reproducible crash calling myArray.sort(compareFn) from within
a sort comparison function

kjs/array_object.cpp: (ArrayInstance::sort): Save/restore the static variables around calls to qsort to ensure nested calls to ArrayInstance::sort behave correctly.

2007-04-19 Mark Rowe <mrowe@apple.com>

Reviewed by Darin.

Test for http://bugs.webkit.org/show_bug.cgi?id=13401
Bug 13401: Reproducible crash calling myArray.sort(compareFn) from within
a sort comparison function