⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 22, 2007:

11:46 PM Changeset in webkit [21021] by bdash
  • 3 edits in trunk/WebCore

2007-04-22 Lars Naesbye Christensen <​lars@naesbye.dk>

Reviewed by Tim Hatcher.

Prettier, more modern 'cell' cursor
​http://bugs.webkit.org/show_bug.cgi?id=13441
Also updates past ChangeLog entries to new email address

  • ChangeLog:
  • ChangeLog-2006-12-31:
  • Resources/cellCursor.png:
11:17 PM Changeset in webkit [21020] by bdash
  • 2 edits in trunk/WebCore

2007-04-23 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Hyatt.

Rename cMaxPenderingSourceLengthInLowBandwidthDisplay to cMaxPendingSourceLengthInLowBandwidthDisplay.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
9:16 PM Changeset in webkit [21019] by mjs
  • 6 edits in trunk/JavaScriptCore

Reviewed by Darin.


Based an idea by Christopher E. Hyde <​C.Hyde@parableuk.force9.co.uk>. His patch to do
this also had many other List changes and I found this much simpler subset of the changes
was actually a hair faster.


This optimization is valid because the arguments list is only kept around to
lazily make the arguments object. If it's not made by the time the function
exits, it never will be, since any function that captures the continuation will
have its own local arguments variable in scope.


Besides the 1.7% speed improvement, it shrinks List by 4 bytes
(which in turn shrinks ActivationImp by 4 bytes).


  • kjs/Context.cpp: (KJS::Context::~Context): Clear the activation's arguments list.
  • kjs/function.cpp: (KJS::ActivationImp::ActivationImp): Adjusted for list changes. (KJS::ActivationImp::mark): No need to mark, lists are always protected (this doesn't cause a ref-cycle for reasons stated above). (KJS::ActivationImp::createArgumentsObject): Clear arguments list.
  • kjs/function.h:
  • kjs/list.cpp: (KJS::List::List): No more needsMarking boolean (KJS::List::operator=): ditto
  • kjs/list.h: (KJS::List::List): ditto (KJS::List::reset): ditto (KJS::List::deref): ditto
9:10 PM Changeset in webkit [21018] by mjs
  • 4 edits in trunk/JavaScriptCore

Reviewed by Darin.


Inspired by similar changes by Christopher E. Hyde <​C.Hyde@parableuk.force9.co.uk>
done in the kjs-tweaks branch of KDE's kjs. However, this version is somewhat
cleaner style-wise and avoids some of the negative speed impact (at least on gcc/x86)
of his version.


This is nearly a wash performance-wise, maybe a slight slowdown, but worth doing
to eventually reach cell size 32.


  • kjs/collector.cpp: (KJS::):
  • kjs/property_map.cpp: (KJS::PropertyMap::~PropertyMap): (KJS::PropertyMap::clear): (KJS::PropertyMap::get): (KJS::PropertyMap::getLocation): (KJS::PropertyMap::put): (KJS::PropertyMap::insert): (KJS::PropertyMap::expand): (KJS::PropertyMap::rehash): (KJS::PropertyMap::remove): (KJS::PropertyMap::mark): (KJS::PropertyMap::containsGettersOrSetters): (KJS::PropertyMap::getEnumerablePropertyNames): (KJS::PropertyMap::getSparseArrayPropertyNames): (KJS::PropertyMap::save): (KJS::PropertyMap::checkConsistency):
  • kjs/property_map.h: (KJS::PropertyMap::hasGetterSetterProperties): (KJS::PropertyMap::setHasGetterSetterProperties): (KJS::PropertyMap::): (KJS::PropertyMap::PropertyMap):
9:01 PM Changeset in webkit [21017] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.



  • kjs/collector.cpp: (KJS::allocateBlock): New function to allocate 64k of 64k-aligned memory (KJS::freeBlock): Corresponding free (KJS::Collector::allocate): (KJS::Collector::collect):
8:29 PM Changeset in webkit [21016] by mjs
  • 1 edit in trunk/WebCore/ChangeLog

Added bugzilla URL to earlier commit.

8:28 PM Changeset in webkit [21015] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin and Geoff.


This change is a .66% speedup on JS iBench for 32-bit platforms, probably much more
for 64-bit since it finally gives a reasonable cell size, but I did not test that.


  • kjs/collector.cpp: (KJS::): Use different cell size for 32-bit and 64-bit, now that there is no oversize allocation. (KJS::Collector::allocate): Remove oversize allocator. (KJS::Collector::markStackObjectsConservatively): Don't check oversize objects. (KJS::Collector::markMainThreadOnlyObjects): Ditto. (KJS::Collector::collect): Ditto.
8:09 PM Changeset in webkit [21014] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Darin and Geoff.

  • move most of Window's data members into a separate private object, to avoid needing to use the oversize allocator for it


It was the only remaining JSObject subclass to use the oversize
allocator on 32-bit platforms, and having oversize objects around
makes garbage collection slower so this would hurt performance
with many tabs/windows open.


No significant effect on JS iBench.

  • bindings/js/kjs_events.cpp: (KJS::JSUnprotectedEventListener::JSUnprotectedEventListener): (KJS::JSUnprotectedEventListener::~JSUnprotectedEventListener): (KJS::JSEventListener::JSEventListener): (KJS::JSEventListener::~JSEventListener): (KJS::JSLazyEventListener::parseCode):
  • bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::Window::Window): (KJS::Window::~Window): (KJS::Window::location): (KJS::Window::selection): (KJS::Window::locationbar): (KJS::Window::menubar): (KJS::Window::personalbar): (KJS::Window::statusbar): (KJS::Window::toolbar): (KJS::Window::scrollbars): (KJS::Window::mark): (KJS::Window::getValueProperty): (KJS::Window::findJSEventListener): (KJS::Window::findJSUnprotectedEventListener): (KJS::Window::clearHelperObjectProperties): (KJS::Window::clear): (KJS::Window::setCurrentEvent): (KJS::Window::setReturnValueSlot): (KJS::Window::clearAllTimeouts): (KJS::Window::installTimeout): (KJS::Window::pauseTimeouts): (KJS::Window::resumeTimeouts): (KJS::Window::clearTimeout): (KJS::Window::timerFired): (KJS::Window::disconnectFrame): (KJS::Window::jsEventListeners): (KJS::Window::jsHTMLEventListeners): (KJS::Window::jsUnprotectedEventListeners): (KJS::Window::jsUnprotectedHTMLEventListeners):
  • bindings/js/kjs_window.h:
8:08 PM Changeset in webkit [21013] by hyatt
  • 2 edits in trunk/WebCore

Fix 1% regression on the PLT. Make sure roundToDevicePixels does no
work when no scale is in effect.

Reviewed by mjs

5:44 PM Changeset in webkit [21012] by darin
  • 3 edits in trunk/WebCore

Reviewed by Oliver.

  • fix small things noticed while looking into a font subsitution bug
  • platform/Font.h: (WebCore::Font::operator==): Corrected a misleading comment.
  • platform/Font.cpp: (WebCore::Font::Font): Initialize m_pageZero to 0 in the empty constructor instead of leaving it uninitialized. Initialize m_fontList for tighter code. Remove unneeded initialization of RefPtr members to 0. Changed the copy constructor to use initialization for tighter code. (WebCore::Font::operator=): Sorted to match the order from the header and the copy constructor, and removed the uneeded self-assignment check.
5:38 PM Changeset in webkit [21011] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Darin.

The fix for <rdar://problem/4976681> ASSERTION failure on quit @ talkcrunch.com in _NPN_ReleaseObject
was #ifdefed out in Production builds.

  • WebView/WebView.mm: (+[WebView initialize]): Move the #ifdef REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM inside initialize around the specific code (+[WebView _applicationWillTerminate]): Moved outside the #ifdef REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM block
4:14 PM Changeset in webkit [21010] by darin
  • 5 edits
    1 add in trunk/WebCore

Reviewed by Maciej.

  • manual-tests/clear-input-file.html: Added.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::appendFormData): Remove check that prevents submission of form data when there is no renderer or the renderer is invisible. While well-intentioned, the rule does not match the behavior of other web browsers. (WebCore::HTMLInputElement::setValue): Instead of disallowing all value changes for file type, allow changes to the empty string. (WebCore::HTMLInputElement::storesValueSeparateFromAttribute): Made file type return true for this. 1) The file type does store its value separate from the value attribute. 2) The code in setInputType() should do the right thing given this new value, according to my inspection of the code. 3) The code in both reset() and setValue() will work properly if this is true, which was the motivation for changing it.
  • platform/FileChooser.h: Added a clear function.
  • platform/FileChooser.cpp: (WebCore::FileChooser::clear): Clear the filename and the icon.
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::valueChanged): Used a local variable to make the code a little bit more readable (and match the change below). (WebCore::RenderFileUploadControl::updateFromElement): Used local variables a bit more in the old code. Added code that will call clear on the FileChooser and repaint if the DOM element has an empty value and the FileChooser does not.
4:12 PM Changeset in webkit [21009] by darin
  • 9 edits in trunk/WebCore

Reviewed by Hyatt.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12279
Implemented two pass loading. Enabled by WTF_USE_LOW_BANDWIDTH_DISPLAY flag.

  • dom/Document.cpp: (WebCore::Document::Document): initialize member variable m_inLowBandwidthDisplay
  • dom/Document.h: (WebCore::Document::haveStylesheetsLoaded): while in low bandwidth display mode, ignore pending style sheets (WebCore::Document::setDocLoader): (WebCore::Document::inLowBandwidthDisplay): (WebCore::Document::setLowBandwidthDisplay):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): while in low bandwidth display mode, don't execute JavaScript
  • loader/Cache.cpp: (WebCore::Cache::requestResource): while in low bandwidth display mode, don't let style sheet and JavaScript block
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify): add notifyFinished() as client may need "this" pointer
  • loader/DocLoader.h: (WebCore::DocLoader::replaceDocument):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::requestFrame): while in low bandwidth display mode, don't load sub-frame (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::begin): set to low bandwidth display mode if the top frame is HTML document (WebCore::FrameLoader::write): (WebCore::FrameLoader::endIfNotLoading): (WebCore::FrameLoader::checkCompleted): while in low bandwidth display mode, don't set complete (WebCore::FrameLoader::requestObject): while in low bandwidth display mode, don't care Object (WebCore::FrameLoader::addLowBandwidthDisplayRequest): (WebCore::FrameLoader::removeAllLowbandwidthDisplayRequests): (WebCore::FrameLoader::notifyFinished): (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
  • loader/FrameLoader.h: (WebCore::FrameLoader::FrameLoader::needToSwitchOutLowBandwidthDisplay): (WebCore::FrameLoader::FrameLoader::setUseLowBandwidthDisplay): (WebCore::FrameLoader::FrameLoader::useLowBandwidthDisplay):
3:57 PM Changeset in webkit [21008] by darin
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Tim Hatcher.

  • fast/css/dashboard-region-parser.html: Added.
  • fast/css/dashboard-region-parser-expected.txt: Added.
  • fast/css/dashboard-regions-attr-crash.html: Updated bug URL to point to bugs.webkit.org instead of bugzilla.opendarwin.org. At some point we should do this for the roughly 100 other tests that have the old URL.
  • fast/css/dashboard-regions-attr-crash-expected.txt: Ditto.

WebCore:

Reviewed by Tim Hatcher.

Test: fast/css/dashboard-region-parser.html

  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText): Fix code that overwrote each additional region with the previous one to instead build a space-separated list. Check for the case of an identifier that's invalid, since that's (accidentally) how we represent a region value that doesn't have explicit top/right/bottom/left values. The old code would end up writing out four spaces after the region type.
  • css/cssparser.cpp: (WebCore::CSSParser::parseDashboardRegions): Fail to parse if there is something after the "none" identifier or after the arguments inside the dashboard-region "function". Also replaced code that produced a identifier with CSS_VAL_INVALID in a roundabout way with code that does it explicitly.
3:12 PM Changeset in webkit [21007] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Mitz.

Bug 13436: Make Option-clicking a disclosure triangle expand the entire subtree
​http://bugs.webkit.org/show_bug.cgi?id=13436

Makes option-click recursively expand and collapse the sub-tree. Pressing option-left
and -right also recursively expands and collapses the sub-tree.

3:05 PM Changeset in webkit [21006] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Mitz.

Bug 13437: Inspector does not update when navigating to a different page
​http://bugs.webkit.org/show_bug.cgi?id=13437

  • WebInspector/webInspector/inspector.js: Correctly update to a new root node if the new focus node and the old focus node don't have a common ancestor.
1:28 PM Changeset in webkit [21005] by kevino
  • 4 edits
    1 add in branches/wx-port-alpha/trunk

Get JavaScriptCore tests running on the wxWebKit branch. (use run-wxwebkit-tests to run them)

10:24 AM Changeset in webkit [23330] by darin
  • 2 edits in branches/WindowsMerge/LayoutTests
  • win/Skipped: Added a new test that requires emacs key bindings that we don't have implemented in Boomer.
10:17 AM Changeset in webkit [21004] by darin
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Adele.

  • test for <rdar://problem/5100240> REGRESSION: Control-O broken
  • editing/input/emacs-ctrl-o-expected.checksum: Added.
  • editing/input/emacs-ctrl-o-expected.png: Added.
  • editing/input/emacs-ctrl-o-expected.txt: Added.
  • editing/input/emacs-ctrl-o.html: Added.

WebCore:

Reviewed by Adele.

  • support for fix for <rdar://problem/5100240> REGRESSION: Control-O broken
  • dom/KeyboardEvent.h: Include a vector of command names in the KeypressCommand object instead of a single command name.

WebKit:

Reviewed by Adele.

  • fix for <rdar://problem/5100240> REGRESSION: Control-O broken
  • WebView/WebHTMLView.mm: (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): Update to handle a vector of command names instead of a single command. (-[WebHTMLView doCommandBySelector:]): Change logic so that we add the command to a vector and also so that the interpretKeyEvents parameters are still intact for a second call to doCommandBySelector:, since the key bindings mechanism can do more than one. (-[WebHTMLView insertText:]): Added comment.
1:23 AM Changeset in webkit [21003] by ap
  • 7 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13115
REGRESSION: 1000% performance regression in DOM access by index, which was already slow

  • dom/NodeList.h: Move cached data into a separate class, so it can be shared.
  • dom/Node.h: Replace the set of registered NodeLists with a struct that also contains a shared NodeList::Caches (so the size of Node doesn't change).
  • dom/NodeList.cpp: (WebCore::NodeList::NodeList): (WebCore::NodeList::~NodeList): (WebCore::NodeList::recursiveLength): (WebCore::NodeList::itemForwardsFromCurrent): (WebCore::NodeList::itemBackwardsFromCurrent): (WebCore::NodeList::recursiveItem): (WebCore::NodeList::itemWithName): (WebCore::NodeList::rootNodeChildrenChanged): (WebCore::NodeList::NodeListInfo::NodeListInfo): (WebCore::NodeList::NodeListInfo::reset):
  • dom/ChildNodeList.cpp: (WebCore::ChildNodeList::ChildNodeList): (WebCore::ChildNodeList::length): (WebCore::ChildNodeList::item): (WebCore::ChildNodeList::nodeMatches):
  • dom/ChildNodeList.h:
  • dom/Node.cpp: (WebCore::Node::childNodes): (WebCore::Node::registerNodeList): (WebCore::Node::unregisterNodeList): (WebCore::Node::notifyLocalNodeListsAttributeChanged): (WebCore::Node::notifyLocalNodeListsChildrenChanged): Adjust for the above changes.

Apr 21, 2007:

8:15 PM Changeset in webkit [21002] by andrew
  • 3 edits
    4 adds in trunk

LayoutTests:
2007-04-21 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/repaint/control-clip-expected.checksum: Added.
  • fast/repaint/control-clip-expected.png: Added.
  • fast/repaint/control-clip-expected.txt: Added.
  • fast/repaint/control-clip.html: Added.

WebCore:
2007-04-21 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/repaint/control-clip.html

Ignore controls' lightweight clip in repaint rect computation for now.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::computeAbsoluteRepaintRect):
6:41 PM Changeset in webkit [21001] by darin
  • 2 edits in trunk/WebCore

Reviewed by Adam.

  • fix <rdar://problem/4816343> :-khtml-drag CSS pseudo-class changed to :-webkit-drag, need alias
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Since Apple documentation claims "-khtml-drag" works, we need to keep it working, so add it back as an alias.
4:46 PM Changeset in webkit [21000] by darin
  • 3 edits in trunk/WebKit

Reviewed by Oliver.

  • fix some problems I ran into using the inspector
  • WebInspector/webInspector/inspector.js: Add some null checks.
4:46 PM Changeset in webkit [20999] by darin
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

  • fix <rdar://problem/4782422> REGRESSION: -[stringByEvaluatingJavaScriptFromString] returns an empty string instead of nil for non-string results
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Added a call to nsStringNilIfEmpty to restore the old behavior. It might be nice to distinguish the empty string from a non-string result, but there's no obvious way to do that, and for compatibility it's probably best to just restore the old behavior instead.
3:31 PM Changeset in webkit [20998] by hyatt
  • 3 edits in trunk/WebCore

Fix for bug 13432, determineFlowSpacing is O(n2).

Reviewed by aroben

  • rendering/InlineBox.cpp: (WebCore::InlineBox::nextOnLineExists): (WebCore::InlineBox::prevOnLineExists):
  • rendering/InlineBox.h: (WebCore::InlineBox::InlineBox):
2:38 AM Changeset in webkit [20997] by ap
  • 8 edits
    2 adds in trunk

2007-04-21 Lamar Goddard <​lamargoddard@gmail.com>

Reviewed by Darin.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=5262
<rdar://problem/5018778>
XMLSerializer drops Namespace information

WebCore:

Updated WebCore::markup to output namespace information for elements/attributes whose namespace information
doesn't appear in its scope in the output.

  • WebCore/editing/markup.cpp: (WebCore::createMarkup(const Node*, ...)): Changed call to WebCore::markup to match parameters (WebCore::markup): Changed recursive call to match tree structure, removed ASSERT and no longer needed includeSiblings parameter. (WebCore::startMarkup): Added optional parameter to track namespaces in the current scope. (WebCore::addNamespace): Function to add namespace information to markup. (WebCore::shouldAddNamespaceAttr): (WebCore::shouldAddNamespaceElem): Functions that test whether namespace information should be added for a given node.
  • WebCore/dom/Document.idl: (createElementNS): (createAttributeNS): (getElementsByTagNameNS): Added [ConvertNullToNullString] to namespaceURI parameter.
  • WebCore/dom/Node.cpp: (Node::getElementsByTagNameNS): removed test for namespaceURI being null as null can be a valid namespace.

LayoutTests:

  • fast/dom/serialize-nodes-expected.txt: Added.
  • fast/dom/serialize-nodes.xhtml: Added.
  • dom/xhtml/level3/core/nodeisequalnode14-expected.txt: This test fails because createAttribute is supposed to create an Attr with localName of null.
  • dom/xhtml/level3/core/nodeisequalnode15-expected.txt: Now succeeds.
  • fast/innerHTML/004-expected.txt: Added namespace information to head and body nodes as xhtml nodes now serialize with namespace information.
1:50 AM Changeset in webkit [20996] by ap
  • 4 edits
    4 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13300
Reproducible crash opening anekdot.ru

WebCore:

  • html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser): (WebCore::HTMLParser::getNode): (WebCore::HTMLParser::handleIsindex):
  • html/HTMLParser.h: Made HTMLParser::form a RefPtr, and renamed it to m_currentFormElement. Made m_currentMapElement a RefPtr.

LayoutTests:

  • fast/parser/rewrite-form-expected.txt: Added.
  • fast/parser/rewrite-form.html: Added.
  • fast/parser/rewrite-map-expected.txt: Added.
  • fast/parser/rewrite-map.html: Added.
1:20 AM Changeset in webkit [20995] by bdash
  • 9 edits
    4 adds in trunk

2007-04-21 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/overflow/hit-test-overflow-controls.html

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): Avoid activating scrollbars during layer resize.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInOverflowControl): Renamed isPointInScrollbar to this, to reflect that it returns true for points in the resize corner as well. Changed it to call the layer to do the actual work. (WebCore::RenderBlock::nodeAtPoint): Updated for the above rename.
  • rendering/RenderBlock.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::horizontalScrollbarWidget): Fixed typo in this function's name (it was horizontaScrollbarWidget). (WebCore::RenderLayer::hitTestOverflowControls): Added. Returns whether the hit point is in one of the scrollbars or the resize corner, and updates the platform scrollbar in the hit test result if a scrollbar was hit.
  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::isPointInOverflowControl): Rename.
  • rendering/RenderListBox.h:

2007-04-21 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/overflow/hit-test-overflow-controls-expected.checksum: Added.
  • fast/overflow/hit-test-overflow-controls-expected.png: Added.
  • fast/overflow/hit-test-overflow-controls-expected.txt: Added.
  • fast/overflow/hit-test-overflow-controls.html: Added.
1:17 AM Changeset in webkit [20994] by bdash
  • 6 edits in trunk

2007-04-21 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • DumpRenderTree/DumpRenderTree.m: (activateAhemFont): Added. Activates the copy of Ahem included in the DumpRenderTree binary. (dumpRenderTree): Replaced the check that Ahem is available with a call to activateAhemFont().
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linker options to include Ahem in the data section of the DumpRenderTree binary.

2007-04-21 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • quality/testing.html: Removed the requirement to download and install Ahem for running the tests.
  • quality/testwriting.html: Added information about Ahem.
1:14 AM Changeset in webkit [20993] by bdash
  • 3 edits
    2 adds in trunk

2007-04-21 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/dom/Window/getMatchedCSSRules-null-crash.html

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::styleRulesForElement): Added null check.

2007-04-21 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/dom/Window/getMatchedCSSRules-null-crash-expected.txt: Added.
  • fast/dom/Window/getMatchedCSSRules-null-crash.html: Added.
1:12 AM Changeset in webkit [20992] by bdash
  • 3 edits in trunk/WebCore

2007-04-21 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

No test included because DumpRenderTree does not support setting the user stylesheet.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::~CSSStyleSelector):
  • css/cssstyleselector.h: Made m_userSheet a RefPtr.
1:09 AM Changeset in webkit [20991] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-04-21 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adam.

  • kjs/array_object.cpp: (ArrayInstance::sort): Free the old storage, not the new one.
1:08 AM Changeset in webkit [20990] by bdash
  • 2 edits in trunk/WebCore

2007-04-21 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Adam.

NPObject should be forward declared using 'struct' instead of 'class'

  • page/Frame.h:
12:51 AM Changeset in webkit [20989] by bdash
  • 2 edits in trunk/WebCore

2007-04-21 Alp Toker <​alp@atoker.com>

Gdk build fix.

  • platform/gdk/FontPlatformDataGdk.cpp: (WebCore::FontPlatformData::FontPlatformData): Use the correct casts.
Note: See TracTimeline for information about the timeline view.