⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 25, 2007:

11:46 PM Changeset in webkit [21105] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Anders.


  • fix build problems
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Disable warning that gives often downright incorrect results based on guessing what will happen in 64-bit.
11:37 PM Changeset in webkit [21104] by andersca
  • 4 edits in trunk

WebCore:

Reviewed by Maciej.

<rdar://problem/5049099> documents no longer have a default base URL

Don't call canHandleRequest if we have valid substitute data and the protocol is "applewebdata".


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueAfterNavigationPolicy):

WebKit:

Reviewed by Maciej.

<rdar://problem/5049099> documents no longer have a default base URL


If the base URL is nil, then create a unique applewebdata URL to match what Tiger WebKit does.


  • WebView/WebFrame.mm: (createUniqueWebDataURL): (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
7:10 PM Changeset in webkit [21103] by slewis
  • 2 edits in trunk/WebCore

Fix the build for platforms which overload the abs function

5:26 PM Changeset in webkit [21102] by oliver
  • 2 edits in trunk/WebKit

2007-04-25 Oliver Hunt <​oliver@apple.com>

Rubber stamped by Adele.

Roll out WebKit changes from from r21052 to fix regression noted in
<rdar://problem/5159556> REGRESSION: In Mail, pressing option-command- ' doesn't decrease block quote in selection

  • WebView/WebHTMLView.mm: (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): (-[WebHTMLView doCommandBySelector:]):
5:24 PM Changeset in webkit [21101] by zbujtas
  • 18 edits in S60/trunk

rathnasa, reviewed by zbujtas

DESC: widet menu api implementation
​http://bugs.webkit.org/show_bug.cgi?id=13494

4:39 PM Changeset in webkit [23334] by sfalken
  • 5 edits in branches/WindowsMerge

Build fix

4:23 PM BuildingOnWindows edited by pkasting@google.com
(diff)
3:04 PM Changeset in webkit [21100] by hyatt
  • 4 adds in trunk/LayoutTests/fast/block/float

Add another test case that is fixed by the new lazy minmax width code.

2:46 PM Changeset in webkit [21099] by hyatt
  • 3 edits in trunk/WebCore

Fix for bug 13373, make sure to invalidate the pref widths for objects
with percentage padding.

Reviewed by beth

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::layoutPositionedObjects):
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
2:44 PM Changeset in webkit [21098] by hyatt
  • 4 adds in trunk/LayoutTests/fast/block/positioning

Add padding percent test.

2:36 PM Changeset in webkit [21097] by harrison
  • 2 edits in trunk/WebCore

Comment change. Correct the header name in the endif comment.


  • editing/FormatBlockCommand.h: Change InsertListCommand_h to FormatBlockCommand_h.
1:25 PM Changeset in webkit [21096] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoff.

  • tweak the allocator for a small speedup -- Shark showed this was a win, but I can't measure an improvement right now, but it's also clear these changes do no harm
  • wtf/FastMalloc.cpp: (WTF::LgFloor): Use ALWAYS_INLINE here; in testing I did a while back this was necessary to get this single-instruction function to be inlined. (WTF::SizeClass): Use ALWAYS_INLINE here too for the same reason. Also change the special case for a size of 0 to work without a branch for a bit of extra speed. (WTF::ByteSizeForClass): Use ALWAYS_INLINE here too for the same reason.
1:02 PM Changeset in webkit [21095] by darin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

  • platform/AtomicString.cpp: (WebCore::AtomicString::add): Removed unnecessary use of strlen to check if a string is empty.
12:59 PM Changeset in webkit [21094] by ddkilzer
  • 2 edits in trunk/WebCore

2007-04-25 Mitz Pettel <​mitz@webkit.org>

Build fix.

  • rendering/RenderListMarker.h: Undeleted the m_text member.
12:24 PM GtkAPIProposal edited by Kimmo Kinnunen
(diff)
12:10 PM Changeset in webkit [21093] by hyatt
  • 40 edits in trunk/WebCore

Rearchitect calcPrefWidths. The calculation is now done lazily only when minPrefWidth
or maxPrefWidth are asked for. The result of the calculation is cached.

The new invalidation scheme for pref width invalidation follows the
containing block hierarchy and knows to halt at positioned objects, since
they cannot influence the size of their containers.

Reviewed by darin

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::init): (WebCore::CSSStyleSelector::initForStyleResolve):
  • page/FrameView.cpp: (WebCore::FrameView::layout):
  • rendering/RenderApplet.cpp: (WebCore::RenderApplet::layout):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::makeChildrenNonInline): (WebCore::RenderBlock::removeChild): (WebCore::RenderBlock::layout): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::calcPrefWidths): (WebCore::InlineMinMaxIterator::endOfInline): (WebCore::shouldGrowTableCellForImage): (WebCore::RenderBlock::calcInlinePrefWidths): (WebCore::RenderBlock::calcBlockPrefWidths):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): (WebCore::RenderBox::minPrefWidth): (WebCore::RenderBox::maxPrefWidth): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcWidthUsing): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteHorizontalValues):
  • rendering/RenderBox.h:
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): (WebCore::RenderContainer::appendChildNode): (WebCore::RenderContainer::insertChildNode): (WebCore::RenderContainer::layout):
  • rendering/RenderContainer.h: (WebCore::RenderContainer::moveChildNode):
  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::dirtyLineBoxes): (WebCore::RenderCounter::calcPrefWidths):
  • rendering/RenderCounter.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::calcPrefWidths):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::calcHorizontalPrefWidths): (WebCore::RenderFlexibleBox::calcVerticalPrefWidths): (WebCore::RenderFlexibleBox::calcPrefWidths): (WebCore::RenderFlexibleBox::layoutBlock):
  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout):
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layout):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::layout):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::layout):
  • rendering/RenderInline.cpp:
  • rendering/RenderInline.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): (WebCore::RenderListBox::calcPrefWidths):
  • rendering/RenderListItem.cpp: (WebCore::firstNonMarkerChild): (WebCore::RenderListItem::updateMarkerLocation): (WebCore::RenderListItem::calcPrefWidths): (WebCore::RenderListItem::layout):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::layout): (WebCore::RenderListMarker::calcPrefWidths): (WebCore::RenderListMarker::updateMargins):
  • rendering/RenderListMarker.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::removeChildNode): (WebCore::RenderObject::moveChildNode): (WebCore::RenderObject::appendChildNode): (WebCore::RenderObject::insertChildNode): (WebCore::RenderObject::setPrefWidthsDirty): (WebCore::RenderObject::invalidateContainingBlockPrefWidths): (WebCore::RenderObject::information): (WebCore::RenderObject::setStyle):
  • rendering/RenderObject.h: (WebCore::RenderObject::layer): (WebCore::RenderObject::hasLayer): (WebCore::RenderObject::prefWidthsDirty): (WebCore::RenderObject::setNeedsLayoutAndPrefWidthsRecalc): (WebCore::RenderObject::setHasLayer):
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::layout):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGHiddenContainer.cpp:
  • rendering/RenderSVGHiddenContainer.h:
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::calcWidth): (WebCore::RenderTable::layout): (WebCore::RenderTable::removeChildNode):
  • rendering/RenderTable.h:
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::layout):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::removeChildNode):
  • rendering/RenderTableSection.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::trimmedPrefWidths): (WebCore::isSpaceAccordingToStyle): (WebCore::RenderText::minPrefWidth): (WebCore::RenderText::maxPrefWidth): (WebCore::RenderText::calcPrefWidths): (WebCore::RenderText::width):
  • rendering/RenderText.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::RenderView): (WebCore::RenderView::calcPrefWidths): (WebCore::RenderView::layout):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::layout):
12:01 PM Changeset in webkit [21092] by sfalken
  • 10 edits in trunk

2007-04-25 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

Mac callbacks for new spelling methods in WebEditorClient.
Not used yet.

  • WebCoreSupport/WebEditorClient.h: (WebEditorClient::ignoreWordInSpellDocument): (WebEditorClient::learnWord): (WebEditorClient::checkSpellingOfString): (WebEditorClient::checkGrammarOfString): (WebEditorClient::updateSpellingUIWithGrammarString): (WebEditorClient::updateSpellingUIWithMisspelledWord): (WebEditorClient::showSpellingUI): (WebEditorClient::spellingUIIsShowing): (WebEditorClient::getGuessesForWord):

2007-04-25 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

Fix spelling error in spelling method name.
Expose new spelling callback methods to all platforms.

  • bridge/EditorClient.h:
  • platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::updateSpellingUIWithGrammarString):
  • platform/gdk/EditorClientGdk.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::updateSpellingUIWithGrammarString): (WebCore::SVGEmptyEditorClient::getGuessesForWord):

2007-04-25 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.


Fix spelling error in spelling method name.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::updateSpellingUIWithGrammarString):
  • WebCoreSupport/EditorClientQt.h:
11:42 AM Changeset in webkit [21091] by ggaren
  • 10 edits in trunk

WebCore:

Reviewed by Darin Adler, Tim Hatcher.

Fixed a few NSAutoreleasePool issues I noticed while reviewing Brady's patch.

  • platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::setCompositeOperation): Call -drain instead of -release, since -release is a no-op in a GC world.

WebKit:

Reviewed by Darin Adler, Tim Hatcher.

Fixed a few NSAutoreleasePool issues I noticed while reviewing Brady's patch.

  • Carbon/CarbonUtils.m: (PoolCleaner): Call -drain instead of -release, since -release is a no-op in a GC world.
  • Misc/WebKitErrors.m: (registerErrors): Condensed onto one line.
  • Plugins/WebPluginDatabase.m: (-[WebPluginDatabase refresh]): Call -drain instead of -release, since -release is a no-op in a GC world.
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::setStatusbarText):
  • WebInspector/WebNodeHighlightView.m: (-[WebNodeHighlightView initWithHighlight:andRects:forView:]): Don't drain and then release because drain deallocates the receiver, so the release is an over-release.
  • WebView/WebView.mm: (-[WebView rectsForTextMatches]): Re-allocate the pool after draining it, because drain deallocates the receiver, so the drain would leave you without any autorelease pool, causing a leak and then an over-release at the bottom of the loop.
11:21 AM Changeset in webkit [21090] by ap
  • 3 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13445
NodeList access by index is slow

  • dom/ChildNodeList.cpp: (WebCore::ChildNodeList::item): Support iterating backwards from the last accessed node or from the last child.
  • dom/NodeList.h: Make cachedLength unsigned.
11:10 AM BuildingOnWindows edited by pkasting@google.com
(diff)
10:34 AM Changeset in webkit [21089] by bdash
  • 1 edit in trunk/WebCore/platform/gdk/TemporaryLinkStubs.cpp

Don't try and return a value from a stub function with return type of void.

10:32 AM Changeset in webkit [21088] by bdash
  • 2 edits in trunk/WebCore

2007-04-26 Mark Rowe <​mrowe@apple.com>

Gdk build fix. Add missing stub.

  • platform/gdk/TemporaryLinkStubs.cpp: (Editor::advanceToNextMisspelling):
10:21 AM Changeset in webkit [21087] by rwlbuis
  • 3 edits
    4 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12163
SVG text does not appear in a scrolling <div>

Make sure SVG text is painted when scrolling by taking into account the

relative offset of the non-SVG parent in the paintInfo rect.

10:08 AM Changeset in webkit [21086] by bdash
  • 5 edits in trunk/WebCore

2007-04-26 Mark Rowe <​mrowe@apple.com>

Fix non-Mac builds after r21081.

Stub out new Editor methods for Qt and Gdk, and new SVGEmptyEditorClient methods
for all non-Mac builds.

  • editing/qt/EditorQt.cpp: (WebCore::Editor::showSpellingGuessPanel): (WebCore::Editor::spellingPanelIsShowing):
  • page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::passWheelEventToWidget): (WebCore::EventHandler::passMousePressEventToScrollbar):
  • platform/gdk/TemporaryLinkStubs.cpp: (Editor::showSpellingGuessPanel): (Editor::spellingPanelIsShowing):
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::ignoreWordInSpellDocument): (WebCore::SVGEmptyEditorClient::learnWord): (WebCore::SVGEmptyEditorClient::checkSpellingOfString): (WebCore::SVGEmptyEditorClient::checkGrammarOfString): (WebCore::SVGEmptyEditorClient::udpateSpellingUIWithGrammarString): (WebCore::SVGEmptyEditorClient::updateSpellingUIWithMisspelledWord): (WebCore::SVGEmptyEditorClient::showSpellingUI): (WebCore::SVGEmptyEditorClient::spellingUIIsShowing): (WebCore::SVGEmptyEditorClient::getGuessesForWord):
9:35 AM Changeset in webkit [21085] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Ada.

<rdar://problem/5122153>
Crash occurs at WebCore::Frame::loader() when switching to Bookmarks view while loading standalone image

Don't call writeRawData if the data length is 0. (This is checked by the decoder for the non-raw case).

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::write):
6:57 AM Changeset in webkit [21084] by bdash
  • 2 edits in trunk/WebCore

2007-04-26 Mark Rowe <​mrowe@apple.com>

Gdk build fix courtesy of Alp Toker.

  • make-generated-sources.sh: Remove conditional logic to ensure the script exits with the correct exit code.
5:28 AM BuildingGdk edited by alp@atoker.com
List of build dependencies (diff)
12:47 AM Changeset in webkit [21083] by andersca
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Mitz.

<rdar://problem/4869095>
default content type for XMLHttpRequest POSTs changed (breaks Flickrator 0.1 widget)

  • http/tests/xmlhttprequest/default-content-type-dashboard-expected.txt: Added.
  • http/tests/xmlhttprequest/default-content-type-dashboard.html: Added.

WebCore:

Reviewed by Mitz.

<rdar://problem/4869095>
default content type for XMLHttpRequest POSTs changed (breaks Flickrator 0.1 widget)


Use the right MIME type.


  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):

WebKitTools:

Reviewed by Mitz.

Add a setUseDashboardCompatibilityMode method to LayoutTestController which is used to toggle
the dashboard compatibility mode.


  • DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setUseDashboardCompatibilityMode:]): (runTest):
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

Apr 24, 2007:

11:49 PM Changeset in webkit [21082] by darin
  • 20 edits in trunk/WebCore

Reviewed by Maciej.

These are small changes that are either safe to do first, or unrelated to the main
change in Hyatt's patch.

  • Preallocate 4 entries each in m_layoutStruct and m_spanCells to save allocation in AutoTableLayout.
  • Add an early exit to RenderFlow::dirtyLinesFromChangedChild.
  • Change InlineBox::hasTextChildren() to use a bit directly and never a virtual function.
  • Save a virtual function call by using a local bool variable for isTableCell().
  • Fix containingBlock() so it returns 0 for table cells with no parent.
  • Change all callers who are getting at layer() as a boolean to use hasLayer().
  • Change if statements to max() function calls (only the ones Hyatt had in his patch).
  • Remove some old kdDebug calls.
  • Tweak formatting of some code.
  • Add const in one place.
  • bindings/js/kjs_html.cpp: (KJS::HTMLElementFunction::callAsFunction):
  • page/EventHandler.cpp: (WebCore::EventHandler::eventMayStartDrag):
  • page/Frame.cpp: (WebCore::Frame::clearTimers):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn):
  • rendering/AutoTableLayout.h:
  • rendering/InlineBox.h: (WebCore::InlineBox::InlineBox): (WebCore::InlineBox::hasTextChildren):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint):
  • rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::InlineFlowBox):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::repaintOverhangingFloats): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::paintFloats): (WebCore::RenderBlock::fillBlockSelectionGaps): (WebCore::RenderBlock::insertFloatingObject): (WebCore::RenderBlock::floatRect): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::addOverhangingFloats): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestContents): (WebCore::RenderBlock::calcPrefWidths): (WebCore::InlineMinMaxIterator::next): (WebCore::getBorderPaddingMargin): (WebCore::RenderBlock::calcInlinePrefWidths): (WebCore::RenderBlock::calcBlockPrefWidths):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::appendChildNode): (WebCore::RenderContainer::insertChildNode):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::calcHorizontalPrefWidths): (WebCore::RenderFlexibleBox::calcVerticalPrefWidths):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::dirtyLinesFromChangedChild):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateVisibilityStatus): (WebCore::RenderLayer::updateLayerPosition):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paint):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::nodeAtPoint): (WebCore::RenderTableRow::paint):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::nodeAtPoint):
  • rendering/RenderTreeAsText.cpp: (WebCore::write):
9:35 PM Changeset in webkit [23333] by sfalken
  • 18 edits in branches/WindowsMerge

2007-04-24 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin, Oliver.


Checkpoint:
<rdar://problem/4602372> Spelling
<rdar://problem/4769763> Spell checking engine support

  • WebEditorClient.cpp: (WebEditorClient::isContinuousSpellCheckingEnabled): (WebEditorClient::toggleContinuousSpellChecking): (WebEditorClient::isGrammarCheckingEnabled): (WebEditorClient::toggleGrammarChecking): (initViewSpecificSpelling): (WebEditorClient::spellCheckerDocumentTag): (WebEditorClient::ignoreWordInSpellDocument): (WebEditorClient::learnWord): (WebEditorClient::checkSpellingOfString): (WebEditorClient::checkGrammarOfString): (WebEditorClient::udpateSpellingUIWithGrammarString): (WebEditorClient::updateSpellingUIWithMisspelledWord): (WebEditorClient::showSpellingUI): (WebEditorClient::spellingUIIsShowing): (WebEditorClient::getGuessesForWord):
  • WebPreferences.h:

2007-04-24 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin, Oliver.

Checkpoint:
<rdar://problem/4602372> Spelling
<rdar://problem/4769763> Spell checking engine support


Ported code from EditorMac.mm into EditorWin.cpp.
Once this works, I'll move this code into Editor.cpp and remove it
form EditorMac.mm.

  • platform/win/EditorWin.cpp: (WebCore::Editor::ignoreSpelling): (WebCore::Editor::learnSpelling): (WebCore::findFirstMisspellingInRange): (WebCore::paragraphAlignedRangeForRange): (WebCore::findFirstGrammarDetailInRange): (WebCore::findFirstBadGrammarInRange): (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::isSelectionMisspelled): (WebCore::isRangeUngrammatical): (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::Editor::guessesForMisspelledSelection): (WebCore::Editor::showSpellingGuessPanel): (WebCore::Editor::spellingPanelIsShowing): (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::markAllMisspellingsInRange): (WebCore::markAllBadGrammarInRange): (WebCore::markMisspellingsOrBadGrammar): (WebCore::Editor::markMisspellings): (WebCore::Editor::markBadGrammar):
  • platform/win/TemporaryLinkStubs.cpp:

2007-04-24 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin, Oliver.

Add spelling related delegate methods to EditingDelegate.
They are all unimplemented. Necesarry to match the new interfaces.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: (EditingDelegate::ignoreWordInSpellDocument): (EditingDelegate::learnWord): (EditingDelegate::checkSpellingOfString): (EditingDelegate::checkGrammarOfString): (EditingDelegate::udpateSpellingUIWithGrammarString): (EditingDelegate::updateSpellingUIWithMisspelledWord): (EditingDelegate::showSpellingUI): (EditingDelegate::spellingUIIsShowing): (EditingDelegate::guessesForWord): (EditingDelegate::closeSpellDocument): (EditingDelegate::sharedSpellCheckerExists): (EditingDelegate::preflightChosenSpellServer): (EditingDelegate::updateGrammar):
9:22 PM Changeset in webkit [21081] by sfalken
  • 9 edits in trunk

2007-04-24 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin, Oliver.

Refactor spelling codepaths

  • bridge/EditorClient.h:
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): (WebCore::ContextMenu::checkOrEnableIfNeeded):
  • platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::ignoreWordInSpellDocument): (WebCore::EditorClientGdk::learnWord): (WebCore::EditorClientGdk::checkSpellingOfString): (WebCore::EditorClientGdk::checkGrammarOfString): (WebCore::EditorClientGdk::udpateSpellingUIWithGrammarString): (WebCore::EditorClientGdk::updateSpellingUIWithMisspelledWord): (WebCore::EditorClientGdk::showSpellingUI): (WebCore::EditorClientGdk::spellingUIIsShowing): (WebCore::EditorClientGdk::getGuessesForWord):
  • platform/gdk/EditorClientGdk.h:

2007-04-24 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Oliver.


Spelling and grammar stubs

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::ignoreWordInSpellDocument): (WebCore::EditorClientQt::learnWord): (WebCore::EditorClientQt::checkSpellingOfString): (WebCore::EditorClientQt::checkGrammarOfString): (WebCore::EditorClientQt::udpateSpellingUIWithGrammarString): (WebCore::EditorClientQt::updateSpellingUIWithMisspelledWord): (WebCore::EditorClientQt::showSpellingUI): (WebCore::EditorClientQt::spellingUIIsShowing): (WebCore::EditorClientQt::getGuessesForWord):
  • WebCoreSupport/EditorClientQt.h:
7:11 PM Changeset in webkit [21080] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by Oliver.


  • use custom calling convention for everything in nodes.cpp on intel gcc for 1.5% speed boost

Nearly all functions in nodes.cpp were marked up to use the
regparm(3) calling convention under GCC for x86, since this is
faster and they are all guaranteed to be called only internally to
kjs.


The only exception is destructors, since delete doesn't know how to use a custom calling convention.


  • kjs/nodes.cpp: (dotExprDoesNotAllowCallsString):
  • kjs/nodes.h: (KJS::Node::): (KJS::StatementNode::): (KJS::NullNode::): (KJS::BooleanNode::): (KJS::NumberNode::): (KJS::StringNode::): (KJS::RegExpNode::): (KJS::ThisNode::): (KJS::ResolveNode::): (KJS::GroupNode::): (KJS::ElementNode::): (KJS::ArrayNode::): (KJS::PropertyNameNode::): (KJS::PropertyNode::): (KJS::PropertyListNode::): (KJS::ObjectLiteralNode::): (KJS::BracketAccessorNode::): (KJS::DotAccessorNode::): (KJS::ArgumentListNode::): (KJS::ArgumentsNode::): (KJS::NewExprNode::): (KJS::FunctionCallValueNode::): (KJS::FunctionCallResolveNode::): (KJS::FunctionCallBracketNode::): (KJS::FunctionCallParenBracketNode::): (KJS::FunctionCallDotNode::): (KJS::FunctionCallParenDotNode::): (KJS::PostfixResolveNode::): (KJS::PostfixBracketNode::): (KJS::PostfixDotNode::): (KJS::PostfixErrorNode::): (KJS::DeleteResolveNode::): (KJS::DeleteBracketNode::): (KJS::DeleteDotNode::): (KJS::DeleteValueNode::): (KJS::VoidNode::): (KJS::TypeOfResolveNode::): (KJS::TypeOfValueNode::): (KJS::PrefixResolveNode::): (KJS::PrefixBracketNode::): (KJS::PrefixDotNode::): (KJS::PrefixErrorNode::): (KJS::UnaryPlusNode::): (KJS::NegateNode::): (KJS::BitwiseNotNode::): (KJS::LogicalNotNode::): (KJS::MultNode::): (KJS::AddNode::): (KJS::ShiftNode::): (KJS::RelationalNode::): (KJS::EqualNode::): (KJS::BitOperNode::): (KJS::BinaryLogicalNode::): (KJS::ConditionalNode::): (KJS::AssignResolveNode::): (KJS::AssignBracketNode::): (KJS::AssignDotNode::): (KJS::AssignErrorNode::): (KJS::CommaNode::): (KJS::AssignExprNode::): (KJS::VarDeclListNode::): (KJS::VarStatementNode::): (KJS::EmptyStatementNode::): (KJS::ExprStatementNode::): (KJS::IfNode::): (KJS::DoWhileNode::): (KJS::WhileNode::): (KJS::ForNode::): (KJS::ContinueNode::): (KJS::BreakNode::): (KJS::ReturnNode::): (KJS::WithNode::): (KJS::LabelNode::): (KJS::ThrowNode::): (KJS::TryNode::): (KJS::ParameterNode::): (KJS::Parameter::): (KJS::FunctionBodyNode::): (KJS::FuncExprNode::): (KJS::FuncDeclNode::): (KJS::SourceElementsNode::): (KJS::CaseClauseNode::): (KJS::ClauseListNode::): (KJS::SwitchNode::):
6:14 PM Changeset in webkit [21079] by darin
  • 71 edits in trunk/WebCore

Reviewed by Adele.

This patch limits itself to renaming and making other super-simple
changes so that the above change will be smaller and easier to review
and understand.

Rename:

calcHorizontalMinMaxWidth -> calcHorizontalPrefWidths
calcMinMaxWidth -> calcPrefWidths
calcMinMaxWidthInternal -> calcPrefWidthsInternal
calcVerticalMinMaxWidth -> calcVerticalPrefWidths
setNeedsLayoutAndMinMaxRecalc -> setNeedsLayoutAndPrefWidthsRecalc
trimmedMinMaxWidth -> trimmedPrefWidths

RenderObject::m_maxWidth -> RenderObject::m_maxPrefWidth
RenderObject::m_minWidth -> RenderObject::m_minPrefWidth
RenderObject::maxWidth() -> RenderObject::maxPrefWidth()
RenderObject::minWidth() -> RenderObject::minPrefWidth()

Replace m_minMaxKnown, minMaxKnown(), and setMinMaxKnown() with
m_prefWidthsDirty, prefWidthsDirty(), and setPrefWidthsDirty(),
a boolean with the opposite sense.

Convert some uses of if statements into "max".

Change many uses of layer() to hasLayer(). For now it's just a boolean
version of layer(), but Hyatt's patch makes it faster by using a bit.

Added a guard to use of axObjectCache() to make RenderObject destruction
a little faster for the normal case.

Removed some assertions that will be removed in Hyatt's patch.

Made some functions const that will be const in Hyatt's patch.

Put in some revised comments from Hyatt's patch.

Removed an unneeded nil check from RenderListMarker::setStyle.

Moved RootInlineBox::setHorizontalOverflowPositions and
RootInlineBox::setVerticalSelectionPositions to the RootInlineBox.h
header and marked them inline.

  • dom/Document.cpp: (WebCore::Document::updateStyleSelector):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute):
  • page/Frame.cpp: (WebCore::Frame::forceLayoutWithPageWidthRange):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::calcPrefWidths): (WebCore::AutoTableLayout::calcEffectiveWidth):
  • rendering/AutoTableLayout.h:
  • rendering/CounterNode.cpp: (WebCore::CounterNode::recount):
  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcPrefWidths):
  • rendering/FixedTableLayout.h:
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint):
  • rendering/RenderApplet.cpp: (WebCore::RenderApplet::layout):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::handleCompactChild): (WebCore::RenderBlock::getClearDelta): (WebCore::RenderBlock::calcPrefWidths): (WebCore::RenderBlock::calcInlinePrefWidths): (WebCore::RenderBlock::calcBlockPrefWidths):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::RenderBox): (WebCore::RenderBox::nodeAtPoint): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcWidthUsing): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteHorizontalValues):
  • rendering/RenderBox.h: (WebCore::RenderBox::minPrefWidth): (WebCore::RenderBox::maxPrefWidth):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): (WebCore::RenderContainer::appendChildNode): (WebCore::RenderContainer::insertChildNode): (WebCore::RenderContainer::layout):
  • rendering/RenderContainer.h: (WebCore::RenderContainer::calcPrefWidths):
  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::calcPrefWidths):
  • rendering/RenderCounter.h:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::calcPrefWidths):
  • rendering/RenderFieldset.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::calcPrefWidths):
  • rendering/RenderFileUploadControl.h:
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::calcHorizontalPrefWidths): (WebCore::RenderFlexibleBox::calcVerticalPrefWidths): (WebCore::RenderFlexibleBox::calcPrefWidths): (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::allowedChildFlex):
  • rendering/RenderFlexibleBox.h: (WebCore::RenderFlexibleBox::hasMultipleLines): (WebCore::RenderFlexibleBox::isVertical): (WebCore::RenderFlexibleBox::isHorizontal):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::absoluteClippedOverflowRect):
  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout):
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layout):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::layout):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::layout): (WebCore::RenderImage::calcPrefWidths):
  • rendering/RenderImage.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::addChildToFlow): (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::splitFlow): (WebCore::RenderInline::calcPrefWidths):
  • rendering/RenderInline.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): (WebCore::RenderListBox::calcPrefWidths):
  • rendering/RenderListBox.h:
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::updateValue): (WebCore::RenderListItem::updateMarkerLocation): (WebCore::RenderListItem::calcPrefWidths): (WebCore::RenderListItem::layout): (WebCore::RenderListItem::explicitValueChanged):
  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::setStyle): (WebCore::RenderListMarker::layout): (WebCore::RenderListMarker::imageChanged): (WebCore::RenderListMarker::calcPrefWidths): (WebCore::RenderListMarker::calcWidth):
  • rendering/RenderListMarker.h:
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateOptionsWidth): (WebCore::RenderMenuList::calcPrefWidths):
  • rendering/RenderMenuList.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::addLayers): (WebCore::RenderObject::removeLayers): (WebCore::RenderObject::moveLayers): (WebCore::RenderObject::addAbsoluteRectForLayer): (WebCore::RenderObject::checkForRepaintDuringLayout): (WebCore::RenderObject::dump): (WebCore::RenderObject::setStyle): (WebCore::RenderObject::destroy): (WebCore::RenderObject::recalcMinMaxWidths):
  • rendering/RenderObject.h: (WebCore::RenderObject::hasLayer): (WebCore::RenderObject::prefWidthsDirty): (WebCore::RenderObject::setPrefWidthsDirty): (WebCore::RenderObject::setNeedsLayoutAndPrefWidthsRecalc): (WebCore::RenderObject::calcPrefWidths): (WebCore::RenderObject::minPrefWidth): (WebCore::RenderObject::maxPrefWidth):
  • rendering/RenderPart.cpp: (WebCore::RenderPart::setWidget):
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): (WebCore::RenderPartObject::layout):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::calcPrefWidths):
  • rendering/RenderReplaced.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::calcPrefWidths): (WebCore::RenderSVGContainer::layout):
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::calcPrefWidths):
  • rendering/RenderSVGHiddenContainer.h:
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::calcPrefWidths):
  • rendering/RenderSlider.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::calcWidth): (WebCore::RenderTable::layout): (WebCore::RenderTable::calcPrefWidths): (WebCore::RenderTable::splitColumn): (WebCore::RenderTable::appendColumn):
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::updateFromElement): (WebCore::RenderTableCell::styleOrColWidth): (WebCore::RenderTableCell::calcPrefWidths):
  • rendering/RenderTableCell.h:
  • rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::updateFromElement):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::layout):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint):
  • rendering/RenderText.cpp: (WebCore::RenderText::trimmedPrefWidths): (WebCore::RenderText::calcPrefWidths): (WebCore::RenderText::calcPrefWidthsInternal): (WebCore::RenderText::setText):
  • rendering/RenderText.h: (WebCore::RenderText::minPrefWidth): (WebCore::RenderText::maxPrefWidth):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::calcPrefWidths):
  • rendering/RenderTextControl.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::RenderView): (WebCore::RenderView::calcPrefWidths): (WebCore::RenderView::layout):
  • rendering/RenderView.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::layout):
  • rendering/RootInlineBox.cpp:
  • rendering/RootInlineBox.h: (WebCore::RootInlineBox::setHorizontalOverflowPositions): (WebCore::RootInlineBox::setVerticalSelectionPositions):
  • rendering/TableLayout.h:
5:51 PM Changeset in webkit [23332] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Ada.

<rdar://problem/5061022>
REGRESSION: Acrobat 8 plug-in fails to scroll with trackpad two-finger scroll or mouse wheel (12995)


  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::passWheelEventToWidget): Get rid of passWheelEventToSubframe and pass wheel events to all widgets.
4:50 PM Changeset in webkit [21078] by justing
  • 4 edits
    8 adds in trunk

LayoutTests:

Reviewed by oliver


<rdar://problem/5156401>
Crash when dragging text into a link inside a table cell

Test for the crash:

  • editing/pasteboard/5156401-1-expected.checksum: Added.
  • editing/pasteboard/5156401-1-expected.png: Added.
  • editing/pasteboard/5156401-1-expected.txt: Added.
  • editing/pasteboard/5156401-1.html: Added.


Test inserting at the end of a link where we would previously
insert in the wrong paragraph:

  • editing/inserting/5156401-2-expected.checksum: Added.
  • editing/inserting/5156401-2-expected.png: Added.
  • editing/inserting/5156401-2-expected.txt: Added.
  • editing/inserting/5156401-2.html: Added.

WebCore:

Reviewed by oliver


<rdar://problem/5156401>
Crash when dragging text into a link inside a table cell

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary): Don't avoid the anchor if doing so would skip over a line break, that would put content in the wrong paragraph, which can throw ReplaceSelectionCommand, which relies on moveParagraphs into infinite recursion. Renamed the input position. Don't need to re-fetch the enclosing anchor when preparing to push it down, since it hasn't changed since the top of the function.
3:59 PM Changeset in webkit [21077] by thatcher
  • 3 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5133011> 64-bit: Attempting to paste copied text in a input field results in a crash at WebCore::Range::startPosition()

Change a couple incorrect uses of LONG_MAX to INT_MAX to match the variable type they are used in.
The LONG_MAX on 64-bit was overflowing the int variables, causing this crash on paste.

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject value]):
  • editing/TextIterator.cpp: (WebCore::TextIterator::handleTextNode): (WebCore::TextIterator::handleTextBox):
2:06 PM Changeset in webkit [21076] by oliver
  • 2 edits in trunk/JavaScriptCore

GTK Build fix, ::findEntry->KJS::findEntry

  • kjs/lookup.cpp: (KJS::Lookup::findEntry): (KJS::Lookup::find):
1:37 PM Changeset in webkit [21075] by spadma
  • 6 edits in S60/trunk/WebKit

yadavall, reviewed by <​sachin.padma@nokia.com>

DESC: Windowless plugin support
​http://bugs.webkit.org/show_bug.cgi?id=13451

  • BrowserView/src/PluginContentPlayer.cpp: (CPluginContentPlayer::CPluginContentPlayer): (CPluginContentPlayer::CountComponentControls): (CPluginContentPlayer::Start):
  • Plugin/inc/PluginWin.h: (CPluginWin::IsPluginWindowed): (CPluginWin::SetWindowedPlugin):
  • Plugin/src/NpnImplementation.cpp: (NpnGetValue): (NpnSetValue): (NpnInvalidateRect): (NpnForceRedraw):
  • Plugin/src/PluginSkin.cpp: (CPluginSkin::Draw):
  • Plugin/src/PluginWin.cpp: (CPluginWin::CPluginWin): (CPluginWin::ConstructL): (CPluginWin::~CPluginWin): (CPluginWin::NewL): (CPluginWin::SizeChanged): (CPluginWin::OfferKeyEventL): (CPluginWin::CreateStreamL): (CPluginWin::WriteStreamToFileL): (CPluginWin::ProcessEventL): (CPluginWin::RefreshPlugin): (CPluginWin::MakeVisible): (CPluginWin::HandleControlEventL): (CPluginWin::HandleGainingForeground): (CPluginWin::HandleLosingForeground): (CPluginWin::PluginScriptableObject): (CPluginWin::ForceRedraw): (CPluginWin::IsContentInteractive):
1:28 PM Changeset in webkit [21074] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/4966982> 64-bit: In a unordered list, TYPE=DISC and TYPE=CIRCLE attribute values are ignored

We need to draw our full-circle arcs counter-clockwise, since a clockwise arc from 0 to 2π is no arc at all!
This only worked on 32-bit due to a rounding error in CoreGraphics, causing it to draw a full circle anyway.

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawEllipse):
1:21 PM Changeset in webkit [21073] by beidson
  • 8 edits in trunk

WebCore:

Reviewed by Beth, Hyatt, Ada, and Darin

<rdar://problem/5011477> and <rdar://problem/5011514>
Provide support for the icon.db to be moved to a different directory from the old WebKit-style
icons, and remove the old directory if that is the case

Support for this starts in WebCore, where we can use the metadata table in the icon.db to track
whether or not we've ever done the import

  • WebCore.exp:
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::defaultDatabaseFilename): Changed to "Icons.db" (WebCore::IconDatabase::IconDatabase): (WebCore::IconDatabase::deleteAllPreparedStatements): Delete the new statements added (WebCore::IconDatabase::imported): Grab this flag from the DB or return the cached flag (WebCore::IconDatabase::setImported): Store this flag into the DB (WebCore::IconDatabase::importedQuery): Actually do the DB query for this save (WebCore::IconDatabase::setImportedQuery): Actually do the DB query for this retrieval
  • loader/icon/IconDatabase.h:

WebKit:

Reviewed by Beth, Hyatt, Ada, and Darin

<rdar://problem/5011477> and <rdar://problem/5011514>
Provide support for the icon.db to be moved to a different directory from the old WebKit-style
icons, and remove the old directory if that is the case

  • Misc/WebIconDatabase.mm: (-[WebIconDatabase init]): (-[WebIconDatabase _importToWebCoreFormat]): Check "imported()" to determine if a conversion is needed
    • Look for WebIconDatabaseImportDirectoryDefaultsKey for the source location for the conversion
    • Set "imported" to true in the Icons.db
    • If the new Icons.db isn't in the same patch as the old icons, delete the entire directory when finished
    • Move old icon.db to Icons.db to reflect rename
  • Misc/WebIconDatabasePrivate.h: Add WebIconDatabaseImportDirectoryDefaultsKey so a WebKit client can tell WebKit where to look for the old icons if their location is different from the icon.db
  • WebKit.exp:
11:12 AM Changeset in webkit [21072] by thatcher
  • 3 edits in trunk/WebKitTools

Setting the valid architectures to 32-bit only, so these projects
will ignore requests to build them 64-bit. Once they can be built 64-bit,
the valid architectures can be updated.

  • Drosera/Drosera.xcodeproj/project.pbxproj:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
10:37 AM Changeset in webkit [21071] by darin
  • 7 edits
    24 adds in trunk

LayoutTests:

Reviewed by Justin.

  • test for <rdar://problem/4356361> Selection after multiple delete keypresses and undo selects only the last deleted character
  • editing/undo/undo-combined-delete-boundary-expected.checksum: Added.
  • editing/undo/undo-combined-delete-boundary-expected.png: Added.
  • editing/undo/undo-combined-delete-boundary-expected.txt: Added.
  • editing/undo/undo-combined-delete-boundary.html: Added.
  • editing/undo/undo-combined-delete-expected.checksum: Added.
  • editing/undo/undo-combined-delete-expected.png: Added.
  • editing/undo/undo-combined-delete-expected.txt: Added.
  • editing/undo/undo-combined-delete.html: Added.
  • editing/undo/undo-delete-boundary-expected.checksum: Added.
  • editing/undo/undo-delete-boundary-expected.png: Added.
  • editing/undo/undo-delete-boundary-expected.txt: Added.
  • editing/undo/undo-delete-boundary.html: Added.
  • editing/undo/undo-delete-expected.checksum: Added.
  • editing/undo/undo-delete-expected.png: Added.
  • editing/undo/undo-delete-expected.txt: Added.
  • editing/undo/undo-delete.html: Added.
  • editing/undo/undo-forward-delete-boundary-expected.checksum: Added.
  • editing/undo/undo-forward-delete-boundary-expected.png: Added.
  • editing/undo/undo-forward-delete-boundary-expected.txt: Added.
  • editing/undo/undo-forward-delete-boundary.html: Added.
  • editing/undo/undo-forward-delete-expected.checksum: Added.
  • editing/undo/undo-forward-delete-expected.png: Added.
  • editing/undo/undo-forward-delete-expected.txt: Added.
  • editing/undo/undo-forward-delete.html: Added.
  • editing/deleting/delete-and-undo-expected.txt: One of the delegate callbacks has changed in this test's result, because it reflects the selection after undoing a sequence of deletions.

WebCore:

Reviewed by Justin.

  • fix <rdar://problem/4356361> Selection after multiple delete keypresses and undo selects only the last deleted character

Test: editing/undo/undo-combined-delete-boundary.html
Test: editing/undo/undo-combined-delete.html
Test: editing/undo/undo-delete-boundary.html
Test: editing/undo/undo-delete.html
Test: editing/undo/undo-forward-delete-boundary.html
Test: editing/undo/undo-forward-delete.html

  • editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): Fix obviously-wrong code where there were missing braces. I couldn't find any real symptom of this, but I think the fix should go in anyway. All layout tests still pass. (WebCore::TypingCommand::deleteKeyPressed): Added code to compute a selection that goes back to the beginning of the composite editing operation. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
  • editing/Selection.h:
  • editing/Selection.cpp: (WebCore::Selection::setWithoutValidation): Added. Back door to allow setting the ends of a selection without revalidating, because we need to use it on a selection where the endpoints may no longer be valid due to mutations done by earlier pieces of the editing operation.
  • editing/EditCommand.h: (WebCore::EditCommand::startingSelection): Return a const& for speed. (WebCore::EditCommand::endingSelection): Ditto.
8:06 AM Changeset in webkit [21070] by weinig
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Mitz.

  • fast/forms/input-null-expected.txt: Added.
  • fast/forms/input-null.html: Added.

WebCore:

Reviewed by Mitz.

Test: fast/forms/input-null.html

  • html/HTMLInputElement.idl: Convert JS null to the empty string on setting DOMString attributes.
5:29 AM Changeset in webkit [21069] by bdash
  • 4 edits
    4 adds in trunk

2007-04-24 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Test: fast/forms/control-clip.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint): Apply the clip in all phases that paint children. Split PaintPhaseOutline and PaintPhaseChildBlockBackground into two phases each, applying the clip only to the children.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject): Treat the scrollbar as part of the background rather than as a child's background, now that children are clipped out.

2007-04-24 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/forms/control-clip-expected.checksum: Added.
  • fast/forms/control-clip-expected.png: Added.
  • fast/forms/control-clip-expected.txt: Added.
  • fast/forms/control-clip.html: Added.
5:27 AM Changeset in webkit [21068] by bdash
  • 2 edits in trunk/WebKit

2007-04-24 Mitz Pettel <​mitz@webkit.org>

Reviewed by Oliver Hunt.

Changed an apostrophe (') into a right single quotation mark (U+2019).

5:25 AM Changeset in webkit [21067] by bdash
  • 2 edits in trunk/WebKit

2007-04-24 Mitz Pettel <​mitz@webkit.org>

Reviewed by Timothy Hatcher.

  • WebInspector/webInspector/inspector.js: Added a check that the rule is mapped from an attribute.
4:51 AM Changeset in webkit [21066] by bdash
  • 2 edits in trunk/WebCore

2007-04-24 Benjamin Otte <​otte@gnome.org>

Reviewed by Mark Rowe.

Gdk build system improvements.

  • make-generated-sources.sh: Exit with failure status if make fails.
4:49 AM Changeset in webkit [21065] by bdash
  • 2 edits in trunk/WebCore

2007-04-24 Benjamin Otte <​otte@gnome.org>

Reviewed by Mark Rowe.

Gdk build system improvements.

  • Projects/gdk/webcore-gdk.bkl: fail if running any of the commands failed. In particular make-generated-sources.sh
1:44 AM Changeset in webkit [21064] by mjs
  • 4 edits
    1 add in trunk/JavaScriptCore

Reviewed by Geoff.


  • compile most of JavaScriptCore as one file for 4% JS iBench speed improvement
  • JavaScriptCore.xcodeproj/project.pbxproj: Add AllInOneFile.cpp, and remove files it includes from the build.
  • kjs/AllInOneFile.cpp: Added.
  • kjs/dtoa.cpp: Renamed CONST to CONST_ to avoid conflict. (Bigint::): (Bigint::nrv_alloc):
  • kjs/lookup.cpp: Use "namspace KJS { ... }" instead of "using namespace KJS;"
Note: See TracTimeline for information about the timeline view.