Context Navigation

← Previous Period
Next Period →

Timeline

Apr 27, 2007:

11:57 PM Changeset in webkit [21164] by aroben

2 edits in trunk/WebKitTools

Reviewed by Maciej.

Cleaned up prepare-ChangeLog

Scripts/prepare-ChangeLog: No code changes, but style now matches the prevalent style of our perl scripts.

11:48 PM Changeset in webkit [21163] by bdash

5 edits in trunk/LayoutTests

2007-04-27 Mitz Pettel <mitz@webkit.org>

Reviewed by Antti.

http://bugs.webkit.org/show_bug.cgi?id=13521 Update fast/css/percentage-non-integer for the new empty table cell behavior

fast/css/percentage-non-integer-expected.checksum:
fast/css/percentage-non-integer-expected.png:
fast/css/percentage-non-integer-expected.txt:
fast/css/percentage-non-integer.html:

11:40 PM Changeset in webkit [21162] by bdash

3 edits in trunk/WebCore

2007-04-27 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13525 Repainting a listbox schedules a relayout

No test possible as there is no change to functionality.

fix the root cause of http://bugs.webkit.org/show_bug.cgi?id=10862 REGRESSION: Collapsing form input on www.myspace.com

No test possible since text fields are no longer implemented as flexboxes.

rendering/RenderObject.cpp: (WebCore::RenderObject::scheduleRelayout): Added a check that the subtree root is in the tree and not free-floating.
rendering/bidi.cpp: (WebCore::RenderBlock::bidiReorderCharacters): Changed addChild and removeChild to appendChildNode and removeChildNode to save some unnecessary overhead. These calls still mark the tree for relayout, but the change in scheduleRelayout ensures that a layout won't be scheduled.

10:04 PM Changeset in webkit [21161] by thatcher

1 edit in trunk/WebKit/WebKit.xcodeproj/project.pbxproj

Add back in WebInspectorPanel.

9:54 PM Changeset in webkit [21160] by thatcher

2 edits in trunk/WebKit

Revert some unintended changes and fix the build.

9:48 PM Changeset in webkit [21159] by thatcher

8 edits
2 deletes in trunk/WebKit

2007-04-27 Timothy Hatcher <timothy@apple.com>

Reviewed by Darin.

There were only a couple calls to ResourceLoadDelegate forwarder left,
this removed the calls and added a new cached method for didFailLoad.

WebKit/DefaultDelegates/WebDefaultResourceLoadDelegate.h: Removed.
WebKit/DefaultDelegates/WebDefaultResourceLoadDelegate.m: Removed.
WebKit/Plugins/WebNullPluginView.mm: Call the resource load delegate directly.
WebKit/WebCoreSupport/WebFrameLoaderClient.mm: Call the cached didFailLoad delegate function.
WebKit/WebKit.xcodeproj/project.pbxproj: Remove WebDefaultResourceLoadDelegate.
WebKit/WebView/WebDataSource.mm: Remove the #import for WebDefaultResourceLoadDelegate.h
WebKit/WebView/WebView.mm: Remove the ResourceLoadDelegate forwarder, and remove a method that isn't used.
WebKit/WebView/WebViewInternal.h: Ditto.
WebKit/WebView/WebViewPrivate.h: Remove a method that is no longer used.

6:41 PM Changeset in webkit [21158] by pyeh

2 edits in trunk/WebCore

<rdar://problem/5153017> REPRODUCIBLE ASSERT: range != nil in WebViewFactory.mm:415 -[WebViewFactory startOfTextMarkerRange:] (13354)

bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject textMarkerRangeForRange:]): Fix the range length check. It was incorrectly assuming that the max range requested cannot be equal to the length of the string. Since NSRange location is index based, it's perfectly valid to have the max range equal to the the text length.

6:04 PM Changeset in webkit [21157] by harrison

14 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/5160627> Export JS list creation support as ObjC SPI for Mail

WebCore.exp:
editing/Editor.h:
editing/Editor.cpp: (WebCore::Editor::insertOrderedList): (WebCore::Editor::insertUnorderedList): (WebCore::Editor::canIncreaseSelectionListLevel): (WebCore::Editor::canDecreaseSelectionListLevel): (WebCore::Editor::increaseSelectionListLevel): (WebCore::Editor::increaseSelectionListLevelOrdered): (WebCore::Editor::increaseSelectionListLevelUnordered): (WebCore::Editor::decreaseSelectionListLevel): Add insertOrderedList() and insertUnorderedList(). Move existing list management functions from WebCoreFrameBridge. The level increasing functions now return a PassRefPtr<Node> instead of Node. Add check for canEditRichly.

in many other functions, condense the check for nil client().

editing/InsertListCommand.h:
editing/InsertListCommand.cpp: (WebCore::InsertListCommand::insertList): (WebCore::InsertListCommand::fixOrphanedListChild): (WebCore::InsertListCommand::doApply): Add insertList(), which returns the new list element. Don't set the list element's ID if the specified ID was an empty string.

editing/ModifySelectionListLevel.h:
editing/ModifySelectionListLevel.cpp: (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelWithType): (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevel): (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelOrdered): (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelUnordered): Return PassRefPtr<Node> instead of Node.

page/mac/WebCoreFrameBridge.h:
page/mac/WebCoreFrameBridge.mm: Move list management functions to Editor.h and Editor.cpp.

WebKit:

Reviewed by Darin.

<rdar://problem/5160627> Export JS list creation support as ObjC SPI for Mail

WebKit.xcodeproj/project.pbxproj:
WebView/WebHTMLView.mm: (-[WebHTMLView _selectedRange]): (-[WebHTMLView _shouldDeleteRange:]): (-[WebHTMLView _canEdit]): (-[WebHTMLView _canEditRichly]): (-[WebHTMLView _hasSelection]): (-[WebHTMLView _hasSelectionOrInsertionPoint]): (-[WebHTMLView _hasInsertionPoint]): (-[WebHTMLView _isEditable]): Condense the check for nil [self frame]. Remove canEditRichly checks and rely on the editor to do the check instead.

(-[WebHTMLView _insertOrderedList]):
(-[WebHTMLView _insertUnorderedList]):
New.

(-[WebHTMLView _canIncreaseSelectionListLevel]):
(-[WebHTMLView _canDecreaseSelectionListLevel]):
(-[WebHTMLView _increaseSelectionListLevel]):
(-[WebHTMLView _increaseSelectionListLevelOrdered]):
(-[WebHTMLView _increaseSelectionListLevelUnordered]):
(-[WebHTMLView _decreaseSelectionListLevel]):
Moved from bridge to frame editor.

WebView/WebHTMLViewPrivate.h: Add _insertOrderedList and _insertUnorderedList to WebHTMLView(WebPrivate)

5:48 PM Changeset in webkit [21156] by hyatt

2 edits in trunk/WebCore

Fix for <rdar://problem/5134254>, toolbar buttons don't work in gmail after double-click. Make sure
to clear out the capturing frame, since you don't get a second up when a double-click happens.

Reviewed by mjs

page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDoubleClickEvent):

2:59 PM Changeset in webkit [21155] by justing

4 edits
4 adds in trunk

LayoutTests:

Reviewed by oliver

<rdar://problem/5164796>
Enable execCommand("CreateLink", ...) for caret selections

editing/execCommand/5164796-expected.checksum: Added.
editing/execCommand/5164796-expected.png: Added.
editing/execCommand/5164796-expected.txt: Added.
editing/execCommand/5164796.html: Added.

WebCore:

Reviewed by oliver

<rdar://problem/5164796>
Enable execCommand("CreateLink", ...) for caret selections

editing/CreateLinkCommand.cpp: (WebCore::CreateLinkCommand::doApply): For a caret selection, insert a link at the caret position with the url as the link text.
editing/JSEditor.cpp: Enable CreateLink for caret selections.

1:03 PM Changeset in webkit [21154] by brmorris

2 edits in S60/branches/3.1m/WebKit

hongzhao <hong.a.zhao@nokia.com>

Reviewed by Yongjun.
DESC: To add .lib for linking problems in 3.1m.
http://bugs.webkit.org/show_bug.cgi?id=13523

12:58 PM Changeset in webkit [21153] by zbujtas

2 edits in S60/trunk/WebCore

2007-04-27 w3liu <wei.liu@nokia.com>

reviewed by Zalan <zbujtas@gmail.com>
DESC: handle codebase in HTMLImageLoader
http://bugs.webkit.org/show_bug.cgi?id=13491

WARNING: NO TEST CASES ADDED OR CHANGED

khtml/html/html_imageimpl.cpp: (HTMLImageLoader::updateFromElement):

12:56 PM Changeset in webkit [21152] by zbujtas

2 edits in S60/branches/3.1m/WebCore

2007-04-27 w3liu <wei.liu@nokia.com>

reviewed by Zalan <zbujtas@gmail.com>
DESC: handle codebase in HTMLImageLoader
http://bugs.webkit.org/show_bug.cgi?id=13491

WARNING: NO TEST CASES ADDED OR CHANGED

khtml/html/html_imageimpl.cpp: (HTMLImageLoader::updateFromElement):

12:48 PM Changeset in webkit [21151] by zbujtas

2 edits in S60/branches/3.1m/WebCore

2007-04-27 w3liu <wei.liu@nokia.com>

Reviewed by Zalan Bujtas (zbujtas@gmail.com).
DESC: NUPA-729B2V: WCSS dotted HORIZONTAL RULES not displaying at all
http://bugs.webkit.org/show_bug.cgi?id=13524

WARNING: NO TEST CASES ADDED OR CHANGED

khtml/rendering/render_object.cpp: (RenderObject::drawBorder):

12:23 PM Changeset in webkit [21150] by zbujtas

9 edits in S60/trunk

rathnasa, reviewed by zbujtas

DESC: Widget Menu API
http://bugs.webkit.org/show_bug.cgi?id=13494

WARNING: NO TEST CASES ADDED OR CHANGED

khtml/ecma/kjs_window.cpp: (Window::get):

10:02 AM Changeset in webkit [21149] by beidson

2 edits in trunk/WebKit

Rubberstamped by Mark

Remove default implementation of UIDelegate method that was removed

I have also been instructed to give Tim a hard time about this one - apparently
it was his job to clean it out and he failed... failed miserably.

:)

DefaultDelegates/WebDefaultUIDelegate.m: Removed webViewPrint:

7:55 AM Changeset in webkit [21148] by bdash

2 edits in trunk/WebKitTools

2007-04-27 Nazar Kulyk <schamane@myeburg.net>

Reviewed by Mark Rowe.

Basic auto-correction of user-entered URLs.

GdkLauncher/main.cpp: (autocorrectURL): (goToURLBarText): (main):

6:08 AM Changeset in webkit [21147] by antti

1 edit
1 add in trunk/LayoutTests

Forgot this png from previous commit.

fast/table/empty-cells-expected.png: Added.

5:36 AM Changeset in webkit [21146] by bdash

2 edits in trunk/WebKitTools

2007-04-28 Mark Rowe <mrowe@apple.com>

Rubber-stamped by Anders.

Rename some methods and variables to match the style guidelines.

GdkLauncher/main.cpp: (stringIsEmpty): (stringIsEqual): (goToURLBarText): (goButtonClickedCallback): (urlBarEnterCallback): (frameResizeCallback): (frameDestroyCallback): (menuMainBackCallback): (menuMainForwardCallback): (menuMainQuitCallback): (main):

4:32 AM Changeset in webkit [21145] by antti

38 edits
3 adds in trunk

LayoutTests:

Reviewed by Darin, Hyatt.

Test for http://bugs.webkit.org/show_bug.cgi?id=13081
Empty table cells not handled correctly
<rdar://problem/5067926>

Added test case and checked in updated results for others. Changes represent
progressions or are not visible in rendering output.

fast/block/positioning/negative-right-pos-expected.txt:
fast/css/acid2-expected.txt:
fast/css/acid2-pixel-expected.txt:
fast/css/percentage-non-integer-expected.checksum:
fast/css/percentage-non-integer-expected.png:
fast/css/percentage-non-integer-expected.txt:
fast/repaint/table-cell-move-expected.checksum:
fast/repaint/table-cell-move-expected.png:
fast/repaint/table-cell-move-expected.txt:
fast/table/012-expected.txt:
fast/table/032-expected.txt:
fast/table/empty-cells-expected.checksum: Added.
fast/table/empty-cells-expected.txt: Added.
fast/table/empty-cells.html: Added.
fast/table/empty-section-crash-expected.txt:
http/tests/misc/acid2-expected.txt:
http/tests/misc/acid2-pixel-expected.txt:
tables/mozilla/bugs/bug100334-expected.txt:
tables/mozilla/bugs/bug1188-expected.txt:
tables/mozilla/bugs/bug16012-expected.checksum:
tables/mozilla/bugs/bug16012-expected.png:
tables/mozilla/bugs/bug16012-expected.txt:
tables/mozilla/bugs/bug1818-6-expected.txt:
tables/mozilla/bugs/bug222336-expected.txt:
tables/mozilla/bugs/bug222467-expected.txt:
tables/mozilla/bugs/bug78162-expected.txt:
tables/mozilla/core/misc-expected.checksum:
tables/mozilla/core/misc-expected.png:
tables/mozilla/core/misc-expected.txt:
tables/mozilla_expected_failures/bugs/bug14007-1-expected.checksum:
tables/mozilla_expected_failures/bugs/bug14007-1-expected.png:
tables/mozilla_expected_failures/bugs/bug14007-1-expected.txt:
tables/mozilla_expected_failures/bugs/bug72393-expected.checksum:
tables/mozilla_expected_failures/bugs/bug72393-expected.png:
tables/mozilla_expected_failures/bugs/bug72393-expected.txt:
tables/mozilla_expected_failures/other/empty_cells-expected.txt:

WebCore:

Reviewed by Darin, Hyatt.

Fix http://bugs.webkit.org/show_bug.cgi?id=13081
Empty table cells not handled correctly
<rdar://problem/5067926>

To match Firefox and IE, empty table cells with variable width need to be
treated as special case. They generally get zero width.

rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout):
rendering/AutoTableLayout.h: (WebCore::AutoTableLayout::Layout::Layout):
rendering/RenderStyle.h: (WebCore::RenderStyle::hasPadding):

4:20 AM Changeset in webkit [21144] by rwlbuis

4 edits
4 adds in trunk

Reviewed by Oliver.

http://bugs.webkit.org/show_bug.cgi?id=13052
Text not rendered in a second inline SVG element

Correct the rendering of svg text when embedded in non-svg container.

1:43 AM Changeset in webkit [21143] by mjs

2 edits in trunk/WebKit

Reviewed by Mark.

<rdar://problem/5154113> Repro ASSERT (would be crash) in KJS::GCLock::GCLock (13462)
http://bugs.webkit.org/show_bug.cgi?id=13462

WebInspector/WebInspector.m: (-[WebInspectorPrivate dealloc]): Delay release of WebView to avoid GC re-entrancy.

1:40 AM Changeset in webkit [21142] by bdash

2 edits in trunk/WebCore

2007-04-27 Mark Rowe <mrowe@apple.com>

Reviewed by Maciej.

WebCore.pro: Remove non-existent paths from qmake files.

1:10 AM Changeset in webkit [21141] by andersca

2 edits in trunk/WebKit

Reviewed by Mitz.

<rdar://problem/5165755>
View Source is broken; empty window is shown

Return YES for applewebdata URLs.

WebView/WebView.mm: (+[WebView _canHandleRequest:]):

12:52 AM Changeset in webkit [21140] by bdash

5 edits in trunk/WebCore

2007-04-25 Lars Naesbye Christensen <lars@naesbye.dk>

Reviewed by Timothy Hatcher.

http://bugs.webkit.org/show_bug.cgi?id=13477
Bug 13477: Help and context menu cursors need dropshadows.

Resources/cellCursor.png:
Resources/contextMenuCursor.png:
Resources/helpCursor.png:
platform/mac/CursorMac.mm: (WebCore::contextMenuCursor): (WebCore::copyCursor): (WebCore::progressCursor): (WebCore::noDropCursor):

12:44 AM Changeset in webkit [21139] by bdash

1 edit
3 copies
2 adds
1 delete in trunk/JavaScriptCore

2007-04-27 Christopher Brichford <chrisb@adobe.com>

Reviewed by Timothy Hatcher.

Fix for: Bug 13211: Move JavaScriptCore mac project files for apollo port
http://bugs.webkit.org/show_bug.cgi?id=13211

JavaScriptCore.apolloproj/mac/JavaScriptCore.Debug.xcconfig: Added.
JavaScriptCore.apolloproj/mac/JavaScriptCore.Release.xcconfig: Added.
JavaScriptCore.apolloproj/mac/JavaScriptCore.xcconfig: Added.
JavaScriptCore.apolloproj/mac/JavaScriptCore.xcodeproj/project.pbxproj: Added.
JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Debug.xcconfig: Removed.
JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Release.xcconfig: Removed.
JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcconfig: Removed.
JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj: Removed.

12:37 AM Changeset in webkit [21138] by bdash

7 edits
7 deletes in trunk

2007-04-27 Holger Freyther <freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

CMakeLists.txt: Removed.

2007-04-27 Holger Freyther <freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

CMakeLists.txt: Removed.
pcre/CMakeLists.txt: Removed.

2007-04-27 Holger Freyther <freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

CMakeLists.txt: Removed.

2007-04-27 Holger Freyther <freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

QtLauncher/CMakeLists.txt: Removed.
WebKitPart/CMakeLists.txt: Removed.

2007-04-27 Holger Freyther <freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt: Removed.
Scripts/build-webkit: Remove references to CMake.
Scripts/webkitdirs.pm: Remove references to CMake.

Apr 26, 2007:

11:03 PM Changeset in webkit [21137] by bdash

4 edits in trunk

2007-04-27 Mark Rowe <mrowe@apple.com>

Reviewed by Oliver.

JavaScriptCore.xcodeproj/project.pbxproj: Improve dependencies in Xcode project by marking dftables as a dependency of Generate Derived Sources rather than of JavaScriptCore itself.

2007-04-27 Mark Rowe <mrowe@apple.com>

Reviewed by Oliver.

JavaScriptGlue.xcodeproj/project.pbxproj: Improve dependencies in Xcode project by marking JavaScriptGlue as a dependency of testjsglue.

10:48 PM Changeset in webkit [21136] by bdash

2 edits in trunk/WebCore

2007-04-26 Matt Perry <mpComplete@gmail.com>

Reviewed by Maciej.

Added a version check to hackAroundLibXMLEntityBug, since that bug has
been fixed in recent versions of libxml2.

dom/XMLTokenizer.cpp: (WebCore::hackAroundLibXMLEntityBug):

10:36 PM Changeset in webkit [21135] by bdash

1 edit
7 adds in trunk/WebCore

2007-04-26 Christopher Brichford <chrisb@adobe.com>

Reviewed by Timothy Hatcher.

Fix for Bug 13204: Submit initial version of mac project files for apollo port of WebCore http://bugs.webkit.org/show_bug.cgi?id=13204

WebCore.apolloproj/mac/WebCore.Debug.xcconfig: Added.
WebCore.apolloproj/mac/WebCore.Release.xcconfig: Added.
WebCore.apolloproj/mac/WebCore.xcconfig: Added.
WebCore.apolloproj/mac/WebCore.xcodeproj/project.pbxproj: Added.

10:11 PM Changeset in webkit [21134] by bdash

2 edits in trunk/WebCore

2007-04-26 Alp Toker <alp@atoker.com>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=13505
Cast loses precision on x86_64

platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): Use a stack of opacity values instead of Cairo user data.

10:09 PM Changeset in webkit [21133] by bdash

2 edits in trunk/WebKitTools

2007-04-26 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

GdkLauncher/main.cpp: (main): Avoid use of deprecated API.

10:00 PM Changeset in webkit [21132] by bdash

3 edits
4 adds in trunk

2007-04-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13500 REGRESSION: Listbox scrollbar does not reflect actual scrolled position when selected option is added after layout

Test: fast/forms/listbox-scrollbar-incremental-load.html

The scroller position was not updated correctly during insertion, since
scrollbar proportions are updated only during layout

rendering/RenderListBox.cpp: (WebCore::RenderListBox::selectionChanged): Delay scrolling to reveal the selection until after layout if m_optionsChanged is set. Layout is guaranteed to happen soon when the flag is set.

2007-04-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

pixel test for http://bugs.webkit.org/show_bug.cgi?id=13500 REGRESSION: Listbox scrollbar does not reflect actual scrolled position when selected option is added after layout

fast/forms/listbox-scrollbar-incremental-load-expected.checksum: Added.
fast/forms/listbox-scrollbar-incremental-load-expected.png: Added.
fast/forms/listbox-scrollbar-incremental-load-expected.txt: Added.
fast/forms/listbox-scrollbar-incremental-load.html: Added.

6:41 PM Changeset in webkit [21131] by ggaren

5 edits in trunk/JavaScriptCore

Build fix -- added #includes that we used to get implicitly through
JSStringRef.h.

API/JSNode.c:
API/JSNodeList.c:
API/minidom.c:
API/testapi.c:

6:15 PM Changeset in webkit [21130] by ggaren

2 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak, Adam Roben.

Fixed
<rdar://problem/4885130> Remove #include of JSStringRefCF.h from JSStringRef.h
<rdar://problem/4885123> JavaScriptCore is not cross-platform -- JSStringRef.h references CF datatypes

API/JSStringRef.h: Removed #include -- no clients need it anymore.

5:36 PM Changeset in webkit [21129] by hyatt

1 edit in trunk/LayoutTests/fast/dom/Range/surroundContents-1-expected.txt

Fix layout test results jnow that we no longer make empty render texts.

5:35 PM Changeset in webkit [21128] by hyatt

1 edit in trunk/LayoutTests/fast/dom/delete-contents-expected.txt

Fix layout test results jnow that we no longer make empty render texts.

5:34 PM Changeset in webkit [21127] by hyatt

3 edits in trunk/LayoutTests/editing/execCommand

Fix layout test results jnow that we no longer make empty render texts.

5:33 PM Changeset in webkit [21126] by hyatt

3 edits in trunk/LayoutTests/editing/deleting

Fix layout test results jnow that we no longer make empty render texts.

5:30 PM Changeset in webkit [21125] by hyatt

4 edits in trunk/WebCore

Fix for 13511, crash on a counters page. Make sure that RenderTexts
never get a null StringImpl. I would have added an assert that the length
had to be nonzero also, but unfortunately editing creates empty RenderTexts
because of its EditingText DOM subclass that always forces renderers to be
made. I suppose there is a good reason for this...

Reviewed by aroben

dom/CharacterData.cpp: (WebCore::CharacterData::setData): (WebCore::CharacterData::appendData): (WebCore::CharacterData::insertData): (WebCore::CharacterData::deleteData): (WebCore::CharacterData::replaceData):
rendering/RenderCounter.cpp: (WebCore::RenderCounter::RenderCounter):
rendering/RenderText.cpp: (WebCore::RenderText::RenderText): (WebCore::RenderText::trimmedPrefWidths): (WebCore::RenderText::setTextWithOffset): (WebCore::RenderText::setTextInternal): (WebCore::RenderText::setText):

4:21 PM Changeset in webkit [21124] by aliceli1

2 edits in trunk/WebCore

Reviewed by Oliver.

editing/SelectionController.cpp: (WebCore::SelectionController::selectAll): adding null check

2:53 PM Changeset in webkit [21123] by justing

3 edits
4 adds in trunk

LayoutTests:

Reviewed by oliver

<rdar://problem/5120591> Crash when creating a link in Leopard wiki server

editing/execCommand/5120591-expected.checksum: Added.
editing/execCommand/5120591-expected.png: Added.
editing/execCommand/5120591-expected.txt: Added.
editing/execCommand/5120591.html: Added.

WebCore:

Reviewed by oliver

<rdar://problem/5120591>
Crash when creating a link in Leopard wiki server

editing/CreateLinkCommand.cpp: (WebCore::CreateLinkCommand::doApply): Use a RefPtr, setting the anchor's href can destroy it if there is an ancestor with a subtree modified event listener.

2:15 PM Changeset in webkit [21122] by ddkilzer

2 edits in trunk/JavaScriptCore

2007-04-25 David Kilzer <ddkilzer@apple.com>

Reviewed by Maciej.

Add assertions for debug builds.

kjs/JSLock.cpp: (KJS::JSLock::lock): Assert the return value of pthread_mutex_lock() in debug builds. (KJS::JSLock::unlock): Assert the return value of pthread_mutex_unlock() in debug builds.

1:37 PM Changeset in webkit [21121] by kmccullo

2 edits in trunk/WebKitTools

Changed debugging statements for more information.

Scripts/run-webkit-tests:

12:51 PM Changeset in webkit [21120] by hyatt

7 edits in trunk/WebCore

Reviewed by hyatt

http://bugs.webkit.org/show_bug.cgi?id=13496 Eliminate repaintObjectsBeforeLayout

No tests added since there is no change to functionality. Several
tests in fast/repaint test repainting of objects that move during layout.

page/FrameView.cpp: (WebCore::FrameView::layout):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): Removed an early setNeedsLayout(false). Resetting the bit here prevents the full repaint that we rely on when we decide not to repaint children that move.
rendering/RenderBlock.h:
rendering/RenderObject.cpp:
rendering/RenderObject.h:
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::setCellWidths): Replaced the call to repaintObjectsBeforeLayout() if the cell didn't need layout with an unconditional repaint(). We don't bother with repainting only the delta between the old and new widths, since by marking the cell for layout results in a full repaint with the new width anyway.

12:24 PM Changeset in webkit [21119] by hyatt

2 edits in trunk/WebCore

Fix for 13509. Don't recur to parent inline flows if they have been
marked as needing layout themselves.

Reviewed by adele

rendering/RenderFlow.cpp: (WebCore::RenderFlow::dirtyLinesFromChangedChild):

12:21 PM Changeset in webkit [21118] by ap

3 edits
3 adds in trunk

2007-04-26 Matt Perry <mpComplete@gmail.com>

Reviewed and landed by Alexey.

http://bugs.webkit.org/show_bug.cgi?id=13495
Crash when referencing an undefined entity in an XHTML document

Test: fast/parser/badentity.xhtml

dom/XMLTokenizer.cpp: (WebCore::getEntityHandler): Check for a NULL returned from getXHTMLEntity

11:37 AM Changeset in webkit [21117] by andersca

2 edits in trunk/WebCore

Reviewed by Hyatt.

<rdar://problem/4851944>
REGRESSION: With TOT, BMP images can no longer be opened in the browser window

On Tiger, the MIME type for the com.microsoft.bmp UTI isn't in the registry, so add it manually.

platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes):

11:30 AM Changeset in webkit [21116] by hyatt

4 edits in trunk/WebCore

Fix for bug 13503, invalidateContainingBlockPrefWidths is 15% of the
nesting PLT. Avoid O(n^{2) behavior by including inlines in the minmax

dirty chain.}

Reviewed by kevin

rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlinePrefWidths):
rendering/RenderObject.cpp: (WebCore::RenderObject::setPrefWidthsDirty): (WebCore::RenderObject::invalidateContainerPrefWidths):
rendering/RenderObject.h:

11:11 AM Changeset in webkit [21115] by kmccullo

2 edits in trunk/WebKitTools

Adding debugging statements to see why these tests fail. These will be removed.

Scripts/run-webkit-tests:

10:37 AM Changeset in webkit [21114] by andersca

2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5067925>
Reproducible crash (infinite recursion) with a layout test that submits on unload (13078)

Ask the document loader whether it's loading the main resource, since there are cases where the frame
loader's variable isn't updated correctly.

In the distant future, the frame loader shouldn't have an instance variable but this is the least intrusive fix for now.

I couldn't come up with a good test case for this since it requires running three tests in a row and scheduleLoad didn't work. Also,
calling submit in the onunload prevents any new tests from loading!

loader/FrameLoader.cpp: (WebCore::FrameLoader::isLoading):

8:52 AM BuildingGdk edited by alp@atoker.com

(diff)

5:48 AM Changeset in webkit [21113] by zbujtas

2 edits in S60/trunk/WebKit

yadavall, reviewed by <zbujtas@gmail.com>

DESC: Fix build break
http://bugs.webkit.org/show_bug.cgi?id=13497

group/EABI/browserengineU.def:

3:10 AM Changeset in webkit [21112] by bdash

5 edits in tags/WebKit-419.1/WebKit

Merge r10259 and r15845.

2:41 AM Changeset in webkit [21111] by bdash

3 edits in tags/WebKit-419.1/WebKit

Merge r20042 and follow-ups from r20050, r20058, r20064, r20077 and r20668.

2:20 AM Changeset in webkit [21110] by oliver

2 edits in trunk/WebKit

2007-04-26 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

Fix <rdar://problem/5061252> REGRESSION: In Gmail, image fails
to be inserted into message field after dragging

Don't try to create <img> tags for local image files as it results
in the potential to submit forms that look like they have an image,
when in reality they don't.