⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 28, 2007:

11:42 PM Changeset in webkit [21178] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-04-28 Jungshik Shin <​jungshik.shin@gmail.com>

Reviewed by Sam Weinig.

  • bindings/npruntime.h:
10:32 PM Changeset in webkit [21177] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Added test to cover updated fix for <rdar://problem/5152299>

  • fast/events/no-blur-on-enter-button-expected.txt: Added.
  • fast/events/no-blur-on-enter-button.html: Added.

WebCore:

RS by Darin.

Update to fix for <rdar://problem/5152299>

Test: fast/events/no-blur-on-enter-button.html

  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::defaultEventHandler): Don't blur the button when handling the enter key. This matches our new behavior for input elements.
9:35 PM Changeset in webkit [21176] by darin
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Improved the ChangeLog comment. Maybe the code needs a comment like this too.

9:25 PM Changeset in webkit [21175] by darin
  • 3 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

  • fix <rdar://problem/5154144> Hamachi test fails: assertion failure in ListHashSet

Test: fast/forms/add-remove-form-elements-stress-test.html

  • wtf/ListHashSet.h: (WTF::ListHashSetNodeAllocator::ListHashSetNodeAllocator): Initialize m_isDoneWithInitialFreeList to false. (WTF::ListHashSetNodeAllocator::allocate): Added assertions based on a debug-only m_isAllocated flag that make sure we don't allocate a block that's already allocated. These assertions helped pinpoint the bug. Set m_isDoneWithInitialFreeList when we allocate the last block of the initial free list. Once we're done with the initial free list, turn off the rule that says that the next node in the pool after the last node in the free list is also free. This rule works because any free nodes are added to the head of the free list, so a node that hasn't been allocated even once is always at the tail of the free list. But it doesn't work any longer once the entire pool has been used at least once. (WTF::ListHashSetNodeAllocator::deallocate): Set the node's m_isAllocated to false. (WTF::ListHashSetNodeAllocator::pastPool): Added. Used above. (WTF::ListHashSetNodeAllocator::inPool): Changed to use the pastPool function. (WTF::ListHashSetNode::ListHashSetNode): Initialize m_isAllocated to true. (WTF::ListHashSetNode::operator new): Removed variable name for unused size parameter. (WTF::ListHashSetNode::destroy): Changed to call the destructor rather than delete -- this gets rid of the need to define an operator delete.

LayoutTests:

Reviewed by Maciej.

  • test for <rdar://problem/5154144> Hamachi test fails: assertion failure in ListHashSet
  • fast/forms/add-remove-form-elements-stress-test-expected.txt: Added.
  • fast/forms/add-remove-form-elements-stress-test.html: Added.
9:09 PM Changeset in webkit [21174] by adele
  • 4 edits
    4 adds in trunk

LayoutTests:

Tests for <rdar://problem/5152299> REGRESSION: <button> elements do not respond to space and return key as similar <input> elements do

  • fast/forms/button-enter-click-expected.txt: Added.
  • fast/forms/button-enter-click.html: Added.
  • fast/forms/button-spacebar-click-expected.txt: Added.
  • fast/forms/button-spacebar-click.html: Added.

WebCore:

Fix by Darin, reviewed by me.

Fix for <rdar://problem/5152299> REGRESSION: <button> elements do not respond to space and return key as similar <input> elements do

Tests:
fast/forms/button-spacebar-click.html
fast/forms/button-enter-click.html

  • html/HTMLButtonElement.h: (WebCore::HTMLButtonElement::): Made type enum private. Removed unnecessary m_value and m_currValue, and unused m_dirty.
  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::HTMLButtonElement): Removed initialization of m_dirty. (WebCore::HTMLButtonElement::parseMappedAttribute): Removed case to parse value and accesskey attributes, which don't do anything. (WebCore::HTMLButtonElement::defaultEventHandler): Removed unnecessary check for button type. Added cases to handle spacebar and enter keys in the same way that they're handled for <input type=button/reset/submit> buttons. (WebCore::HTMLButtonElement::isSuccessfulSubmitButton): Shortened comment. (WebCore::HTMLButtonElement::appendFormData): Use value() instead of m_currValue. Renamed encoding argument to formData.
6:36 PM Changeset in webkit [21173] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dynamic/anonymous-block-layer-lost-expected.checksum: Added.
  • fast/dynamic/anonymous-block-layer-lost-expected.png: Added.
  • fast/dynamic/anonymous-block-layer-lost-expected.txt: Added.
  • fast/dynamic/anonymous-block-layer-lost.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/dynamic/anonymous-block-layer-lost.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild): Avoid cutting off layers when removing the anonymous block.
6:34 PM Changeset in webkit [21172] by darin
  • 3 edits
    1 add in trunk/WebCore

Reviewed by Darin.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Replaced direct access to Frame's d->m_doc with a call to Frame::setDocument. (WebCore::FrameLoader::begin): Ditto. (WebCore::FrameLoader::open): Ditto. (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady): Ditto. (WebCore::FrameLoader::canCachePage): Added a comment.
  • manual-tests/secure-keyboard-enabled-after-submit.html: Added.
  • page/Frame.cpp: (WebCore::Frame::setDocument): Reset secure keyboard entry, in case the old document's focused node has set it.
6:30 PM Changeset in webkit [21171] by darin
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Adele.

  • manual-tests/update-empty-popup.html: Added.
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Added a call to the client's hidePopup() callback before returning in the case that the menu is empty. Otherwise the client thinks that the menu stayed open.
12:00 PM Changeset in webkit [21170] by adele
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/4806988> REGRESSION: history.go(0) doesn't reload page (affects buttons at facebook.com)

  • fast/history/history_reload-expected.txt: Added.
  • fast/history/history_reload.html: Added.
  • fast/history/resources/history_reload_window.html: Added.

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/4806988> REGRESSION: history.go(0) doesn't reload page (affects buttons at facebook.com)

Test: fast/history/history_reload.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::scheduleHistoryNavigation): We avoid doing a redirection when going to the same url in a history navigation, but we have to still schedule a redirection when the number of steps is zero so we can force a reload.
11:29 AM Changeset in webkit [21169] by ap
  • 5 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13514
REGRESSION (r20997-21003): Crash in WebCore::Node::document

Test: fast/dom/NodeList/childNodes-reset-cache.html

  • dom/Node.cpp: (WebCore::Node::notifyLocalNodeListsChildrenChanged): Reset the common caches for child node lists. We cannot rely on notifications, since there may be no list objects left around.
  • dom/ChildNodeList.cpp: (WebCore::ChildNodeList::rootNodeChildrenChanged):
  • dom/ChildNodeList.h: Override rootNodeChildrenChanged() with an empty implementation, now that caches are reset in Node::notifyLocalNodeListsChildrenChanged().
4:36 AM Changeset in webkit [21168] by bdash
  • 2 edits in trunk/WebCore

2007-04-28 Mark Rowe <​mrowe@apple.com>

Build fix. Change use of nil to 0 in C++ source file.

  • editing/Editor.cpp: (WebCore::Editor::increaseSelectionListLevel): (WebCore::Editor::increaseSelectionListLevelOrdered): (WebCore::Editor::increaseSelectionListLevelUnordered):
1:11 AM Changeset in webkit [21167] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adele.

  • fast/dom/namespaces-1-expected.txt: Added.
  • fast/dom/namespaces-1.html: Added.

WebCore:

Reviewed by Adele.

  • dom/Node.cpp: (WebCore::TagNodeList::TagNodeList): Changed parameter to PassRefPtr, tweaked formatting. (WebCore::TagNodeList::item): Tweaked formatting. (WebCore::TagNodeList::nodeMatches): Tweaked formatting. (WebCore::Node::setPrefix): Tweaked formatting. (WebCore::Node::getElementsByTagNameNS): Added special case to turn empty namespaces into null namespaces.
1:07 AM Changeset in webkit [21166] by darin
  • 4 edits in trunk

LayoutTests:

Reviewed by Kevin Decker.

  • update test result for fix for <rdar://problem/5148271> Chinese numbers are incorrect in numbered lists (including pasting from TextEdit to Mail)
  • fast/lists/w3-list-styles-expected.txt: Updated. The new test results match the behavior of Firefox.

WebCore:

Reviewed by Kevin Decker.

  • fix <rdar://problem/5148271> Chinese numbers are incorrect in numbered lists (including pasting from TextEdit to Mail)

Covered by an existing regression test, which had wrong results checked in.

Hyatt told me not to use the algorithm in the CSS 3 specification, but I didn't listen!
This corrects mistakes there and makes our results match current Firefox.

  • rendering/RenderListMarker.cpp: (WebCore::toCJKIdeographic): Added code to strip off trailing zero digits. Added special case for zero, since that's the one case where we don't want to strip off trailing zero digits. Fixed mixed-up logic that would put the digits in each group backwards. (WebCore::listMarkerText): Corrected character values for the CJK_IDEOGRAPHIC case.
1:02 AM Changeset in webkit [21165] by darin
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

  • fix <rdar://problem/5138250> REGRESSION (r18245): Changing any one aspect of a font applies all the aspects to selected text

Since this bug is only visible with the font panel, I don't
think there's any way to make a DumpRenderTree-driven test.

  • editing/Editor.cpp: (WebCore::Editor::fontForSelection): Set hasMultipleFonts properly. The old code had an early exit that was left over from when hasMultipleFonts was a pointer.

Apr 27, 2007:

11:57 PM Changeset in webkit [21164] by aroben
  • 2 edits in trunk/WebKitTools

Reviewed by Maciej.

Cleaned up prepare-ChangeLog

  • Scripts/prepare-ChangeLog: No code changes, but style now matches the prevalent style of our perl scripts.
11:48 PM Changeset in webkit [21163] by bdash
  • 5 edits in trunk/LayoutTests

2007-04-27 Mitz Pettel <​mitz@webkit.org>

Reviewed by Antti.

  • fast/css/percentage-non-integer-expected.checksum:
  • fast/css/percentage-non-integer-expected.png:
  • fast/css/percentage-non-integer-expected.txt:
  • fast/css/percentage-non-integer.html:
11:40 PM Changeset in webkit [21162] by bdash
  • 3 edits in trunk/WebCore

2007-04-27 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

No test possible as there is no change to functionality.

No test possible since text fields are no longer implemented as flexboxes.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::scheduleRelayout): Added a check that the subtree root is in the tree and not free-floating.
  • rendering/bidi.cpp: (WebCore::RenderBlock::bidiReorderCharacters): Changed addChild and removeChild to appendChildNode and removeChildNode to save some unnecessary overhead. These calls still mark the tree for relayout, but the change in scheduleRelayout ensures that a layout won't be scheduled.
10:04 PM Changeset in webkit [21161] by thatcher
  • 1 edit in trunk/WebKit/WebKit.xcodeproj/project.pbxproj

Add back in WebInspectorPanel.

9:54 PM Changeset in webkit [21160] by thatcher
  • 2 edits in trunk/WebKit

Revert some unintended changes and fix the build.

9:48 PM Changeset in webkit [21159] by thatcher
  • 8 edits
    2 deletes in trunk/WebKit

2007-04-27 Timothy Hatcher <​timothy@apple.com>

Reviewed by Darin.

There were only a couple calls to ResourceLoadDelegate forwarder left,
this removed the calls and added a new cached method for didFailLoad.

  • WebKit/DefaultDelegates/WebDefaultResourceLoadDelegate.h: Removed.
  • WebKit/DefaultDelegates/WebDefaultResourceLoadDelegate.m: Removed.
  • WebKit/Plugins/WebNullPluginView.mm: Call the resource load delegate directly.
  • WebKit/WebCoreSupport/WebFrameLoaderClient.mm: Call the cached didFailLoad delegate function.
  • WebKit/WebKit.xcodeproj/project.pbxproj: Remove WebDefaultResourceLoadDelegate.
  • WebKit/WebView/WebDataSource.mm: Remove the #import for WebDefaultResourceLoadDelegate.h
  • WebKit/WebView/WebView.mm: Remove the ResourceLoadDelegate forwarder, and remove a method that isn't used.
  • WebKit/WebView/WebViewInternal.h: Ditto.
  • WebKit/WebView/WebViewPrivate.h: Remove a method that is no longer used.
6:41 PM Changeset in webkit [21158] by pyeh
  • 2 edits in trunk/WebCore

<rdar://problem/5153017> REPRODUCIBLE ASSERT: range != nil in WebViewFactory.mm:415 -[WebViewFactory startOfTextMarkerRange:] (13354)

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject textMarkerRangeForRange:]): Fix the range length check. It was incorrectly assuming that the max range requested cannot be equal to the length of the string. Since NSRange location is index based, it's perfectly valid to have the max range equal to the the text length.
6:04 PM Changeset in webkit [21157] by harrison
  • 14 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/5160627> Export JS list creation support as ObjC SPI for Mail

  • WebCore.exp:
  • editing/Editor.h:
  • editing/Editor.cpp: (WebCore::Editor::insertOrderedList): (WebCore::Editor::insertUnorderedList): (WebCore::Editor::canIncreaseSelectionListLevel): (WebCore::Editor::canDecreaseSelectionListLevel): (WebCore::Editor::increaseSelectionListLevel): (WebCore::Editor::increaseSelectionListLevelOrdered): (WebCore::Editor::increaseSelectionListLevelUnordered): (WebCore::Editor::decreaseSelectionListLevel): Add insertOrderedList() and insertUnorderedList(). Move existing list management functions from WebCoreFrameBridge. The level increasing functions now return a PassRefPtr<Node> instead of Node. Add check for canEditRichly.


  • in many other functions, condense the check for nil client().


  • editing/InsertListCommand.h:
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::insertList): (WebCore::InsertListCommand::fixOrphanedListChild): (WebCore::InsertListCommand::doApply): Add insertList(), which returns the new list element. Don't set the list element's ID if the specified ID was an empty string.


  • editing/ModifySelectionListLevel.h:
  • editing/ModifySelectionListLevel.cpp: (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelWithType): (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevel): (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelOrdered): (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelUnordered): Return PassRefPtr<Node> instead of Node.
  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm: Move list management functions to Editor.h and Editor.cpp.

WebKit:

Reviewed by Darin.

<rdar://problem/5160627> Export JS list creation support as ObjC SPI for Mail

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLView.mm: (-[WebHTMLView _selectedRange]): (-[WebHTMLView _shouldDeleteRange:]): (-[WebHTMLView _canEdit]): (-[WebHTMLView _canEditRichly]): (-[WebHTMLView _hasSelection]): (-[WebHTMLView _hasSelectionOrInsertionPoint]): (-[WebHTMLView _hasInsertionPoint]): (-[WebHTMLView _isEditable]): Condense the check for nil [self frame]. Remove canEditRichly checks and rely on the editor to do the check instead.


(-[WebHTMLView _insertOrderedList]):
(-[WebHTMLView _insertUnorderedList]):
New.


(-[WebHTMLView _canIncreaseSelectionListLevel]):
(-[WebHTMLView _canDecreaseSelectionListLevel]):
(-[WebHTMLView _increaseSelectionListLevel]):
(-[WebHTMLView _increaseSelectionListLevelOrdered]):
(-[WebHTMLView _increaseSelectionListLevelUnordered]):
(-[WebHTMLView _decreaseSelectionListLevel]):
Moved from bridge to frame editor.

  • WebView/WebHTMLViewPrivate.h: Add _insertOrderedList and _insertUnorderedList to WebHTMLView(WebPrivate)
5:48 PM Changeset in webkit [21156] by hyatt
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/5134254>, toolbar buttons don't work in gmail after double-click. Make sure
to clear out the capturing frame, since you don't get a second up when a double-click happens.

Reviewed by mjs

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDoubleClickEvent):
2:59 PM Changeset in webkit [21155] by justing
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by oliver


<rdar://problem/5164796>
Enable execCommand("CreateLink", ...) for caret selections

  • editing/execCommand/5164796-expected.checksum: Added.
  • editing/execCommand/5164796-expected.png: Added.
  • editing/execCommand/5164796-expected.txt: Added.
  • editing/execCommand/5164796.html: Added.

WebCore:

Reviewed by oliver

<rdar://problem/5164796>
Enable execCommand("CreateLink", ...) for caret selections

  • editing/CreateLinkCommand.cpp: (WebCore::CreateLinkCommand::doApply): For a caret selection, insert a link at the caret position with the url as the link text.
  • editing/JSEditor.cpp: Enable CreateLink for caret selections.
1:03 PM Changeset in webkit [21154] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

hongzhao <​hong.a.zhao@nokia.com>

Reviewed by Yongjun.
DESC: To add .lib for linking problems in 3.1m.
​http://bugs.webkit.org/show_bug.cgi?id=13523

12:58 PM Changeset in webkit [21153] by zbujtas
  • 2 edits in S60/trunk/WebCore

2007-04-27 w3liu <​wei.liu@nokia.com>

reviewed by Zalan <​zbujtas@gmail.com>
DESC: handle codebase in HTMLImageLoader
​http://bugs.webkit.org/show_bug.cgi?id=13491

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/html/html_imageimpl.cpp: (HTMLImageLoader::updateFromElement):
12:56 PM Changeset in webkit [21152] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

2007-04-27 w3liu <​wei.liu@nokia.com>

reviewed by Zalan <​zbujtas@gmail.com>
DESC: handle codebase in HTMLImageLoader
​http://bugs.webkit.org/show_bug.cgi?id=13491

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/html/html_imageimpl.cpp: (HTMLImageLoader::updateFromElement):
12:48 PM Changeset in webkit [21151] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

2007-04-27 w3liu <​wei.liu@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: NUPA-729B2V: WCSS dotted HORIZONTAL RULES not displaying at all
​http://bugs.webkit.org/show_bug.cgi?id=13524

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/rendering/render_object.cpp: (RenderObject::drawBorder):
12:23 PM Changeset in webkit [21150] by zbujtas
  • 9 edits in S60/trunk

rathnasa, reviewed by zbujtas

DESC: Widget Menu API
​http://bugs.webkit.org/show_bug.cgi?id=13494

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/ecma/kjs_window.cpp: (Window::get):
10:02 AM Changeset in webkit [21149] by beidson
  • 2 edits in trunk/WebKit

Rubberstamped by Mark

Remove default implementation of UIDelegate method that was removed

I have also been instructed to give Tim a hard time about this one - apparently
it was his job to clean it out and he failed... failed miserably.

:)

  • DefaultDelegates/WebDefaultUIDelegate.m: Removed webViewPrint:
7:55 AM Changeset in webkit [21148] by bdash
  • 2 edits in trunk/WebKitTools

2007-04-27 Nazar Kulyk <​schamane@myeburg.net>

Reviewed by Mark Rowe.

Basic auto-correction of user-entered URLs.

  • GdkLauncher/main.cpp: (autocorrectURL): (goToURLBarText): (main):
6:08 AM Changeset in webkit [21147] by antti
  • 1 edit
    1 add in trunk/LayoutTests

Forgot this png from previous commit.

  • fast/table/empty-cells-expected.png: Added.
5:36 AM Changeset in webkit [21146] by bdash
  • 2 edits in trunk/WebKitTools

2007-04-28 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Anders.

Rename some methods and variables to match the style guidelines.

  • GdkLauncher/main.cpp: (stringIsEmpty): (stringIsEqual): (goToURLBarText): (goButtonClickedCallback): (urlBarEnterCallback): (frameResizeCallback): (frameDestroyCallback): (menuMainBackCallback): (menuMainForwardCallback): (menuMainQuitCallback): (main):
4:32 AM Changeset in webkit [21145] by antti
  • 38 edits
    3 adds in trunk

LayoutTests:

Reviewed by Darin, Hyatt.


Test for ​http://bugs.webkit.org/show_bug.cgi?id=13081
Empty table cells not handled correctly
<rdar://problem/5067926>


Added test case and checked in updated results for others. Changes represent
progressions or are not visible in rendering output.

  • fast/block/positioning/negative-right-pos-expected.txt:
  • fast/css/acid2-expected.txt:
  • fast/css/acid2-pixel-expected.txt:
  • fast/css/percentage-non-integer-expected.checksum:
  • fast/css/percentage-non-integer-expected.png:
  • fast/css/percentage-non-integer-expected.txt:
  • fast/repaint/table-cell-move-expected.checksum:
  • fast/repaint/table-cell-move-expected.png:
  • fast/repaint/table-cell-move-expected.txt:
  • fast/table/012-expected.txt:
  • fast/table/032-expected.txt:
  • fast/table/empty-cells-expected.checksum: Added.
  • fast/table/empty-cells-expected.txt: Added.
  • fast/table/empty-cells.html: Added.
  • fast/table/empty-section-crash-expected.txt:
  • http/tests/misc/acid2-expected.txt:
  • http/tests/misc/acid2-pixel-expected.txt:
  • tables/mozilla/bugs/bug100334-expected.txt:
  • tables/mozilla/bugs/bug1188-expected.txt:
  • tables/mozilla/bugs/bug16012-expected.checksum:
  • tables/mozilla/bugs/bug16012-expected.png:
  • tables/mozilla/bugs/bug16012-expected.txt:
  • tables/mozilla/bugs/bug1818-6-expected.txt:
  • tables/mozilla/bugs/bug222336-expected.txt:
  • tables/mozilla/bugs/bug222467-expected.txt:
  • tables/mozilla/bugs/bug78162-expected.txt:
  • tables/mozilla/core/misc-expected.checksum:
  • tables/mozilla/core/misc-expected.png:
  • tables/mozilla/core/misc-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug14007-1-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug14007-1-expected.png:
  • tables/mozilla_expected_failures/bugs/bug14007-1-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug72393-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug72393-expected.png:
  • tables/mozilla_expected_failures/bugs/bug72393-expected.txt:
  • tables/mozilla_expected_failures/other/empty_cells-expected.txt:

WebCore:

Reviewed by Darin, Hyatt.


Fix ​http://bugs.webkit.org/show_bug.cgi?id=13081
Empty table cells not handled correctly
<rdar://problem/5067926>


To match Firefox and IE, empty table cells with variable width need to be
treated as special case. They generally get zero width.

  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout):
  • rendering/AutoTableLayout.h: (WebCore::AutoTableLayout::Layout::Layout):
  • rendering/RenderStyle.h: (WebCore::RenderStyle::hasPadding):
4:20 AM Changeset in webkit [21144] by rwlbuis
  • 4 edits
    4 adds in trunk

Reviewed by Oliver.

​http://bugs.webkit.org/show_bug.cgi?id=13052
Text not rendered in a second inline SVG element

Correct the rendering of svg text when embedded in non-svg container.

1:43 AM Changeset in webkit [21143] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Mark.


<rdar://problem/5154113> Repro ASSERT (would be crash) in KJS::GCLock::GCLock (13462)
​http://bugs.webkit.org/show_bug.cgi?id=13462

  • WebInspector/WebInspector.m: (-[WebInspectorPrivate dealloc]): Delay release of WebView to avoid GC re-entrancy.
1:40 AM Changeset in webkit [21142] by bdash
  • 2 edits in trunk/WebCore

2007-04-27 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

  • WebCore.pro: Remove non-existent paths from qmake files.
1:10 AM Changeset in webkit [21141] by andersca
  • 2 edits in trunk/WebKit

Reviewed by Mitz.

<rdar://problem/5165755>
View Source is broken; empty window is shown


Return YES for applewebdata URLs.


  • WebView/WebView.mm: (+[WebView _canHandleRequest:]):
12:52 AM Changeset in webkit [21140] by bdash
  • 5 edits in trunk/WebCore

2007-04-25 Lars Naesbye Christensen <​lars@naesbye.dk>

Reviewed by Timothy Hatcher.

​http://bugs.webkit.org/show_bug.cgi?id=13477
Bug 13477: Help and context menu cursors need dropshadows.

  • Resources/cellCursor.png:
  • Resources/contextMenuCursor.png:
  • Resources/helpCursor.png:
  • platform/mac/CursorMac.mm: (WebCore::contextMenuCursor): (WebCore::copyCursor): (WebCore::progressCursor): (WebCore::noDropCursor):
12:44 AM Changeset in webkit [21139] by bdash
  • 1 edit
    3 copies
    2 adds
    1 delete in trunk/JavaScriptCore

2007-04-27 Christopher Brichford <​chrisb@adobe.com>

Reviewed by Timothy Hatcher.

Fix for: Bug 13211: Move JavaScriptCore mac project files for apollo port
​http://bugs.webkit.org/show_bug.cgi?id=13211

  • JavaScriptCore.apolloproj/mac/JavaScriptCore.Debug.xcconfig: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore.Release.xcconfig: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore.xcconfig: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore.xcodeproj/project.pbxproj: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Debug.xcconfig: Removed.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Release.xcconfig: Removed.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcconfig: Removed.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj: Removed.
12:37 AM Changeset in webkit [21138] by bdash
  • 7 edits
    7 deletes in trunk

2007-04-27 Holger Freyther <​freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

  • CMakeLists.txt: Removed.

2007-04-27 Holger Freyther <​freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

  • CMakeLists.txt: Removed.
  • pcre/CMakeLists.txt: Removed.

2007-04-27 Holger Freyther <​freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

  • CMakeLists.txt: Removed.

2007-04-27 Holger Freyther <​freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

  • QtLauncher/CMakeLists.txt: Removed.
  • WebKitPart/CMakeLists.txt: Removed.

2007-04-27 Holger Freyther <​freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

  • DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt: Removed.
  • Scripts/build-webkit: Remove references to CMake.
  • Scripts/webkitdirs.pm: Remove references to CMake.
Note: See TracTimeline for information about the timeline view.