⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 1, 2007:

6:40 PM Changeset in webkit [21215] by darin
  • 2 edits in trunk/WebCore
  • rendering/RenderReplaced.cpp: Fix typo in a comment.
3:31 PM Changeset in webkit [21214] by hyatt
  • 4 adds in trunk/LayoutTests/fast/css-generated-content

Add layout test for 13558.

3:27 PM Changeset in webkit [21213] by hyatt
  • 2 edits in trunk/WebCore

Fix for 13558, crash when using absolutely positioned generated content
inside an inline.

Reviewed by darin

fast/css-generated-content/absolute-position-inside-inline.html

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
3:20 PM Changeset in webkit [21212] by justing
  • 12 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/5002441>
Pressing space key does nothing above quoted content or a signature

Demonstrates the bug:

  • editing/inserting/5002441-expected.checksum: Added.
  • editing/inserting/5002441-expected.png: Added.
  • editing/inserting/5002441-expected.txt: Added.
  • editing/inserting/5002441.html: Added.


Fixed. Spaces passed to execCommand("InsertText", ...)
are no longer collapsed:

  • editing/inserting/editable-html-element-expected.checksum:
  • editing/inserting/editable-html-element-expected.png:
  • editing/inserting/editable-html-element-expected.txt:
  • editing/pasteboard/4989774-expected.checksum:
  • editing/pasteboard/4989774-expected.png:
  • editing/pasteboard/4989774-expected.txt:
  • editing/selection/4983858-expected.checksum:
  • editing/selection/4983858-expected.png:
  • editing/selection/4983858-expected.txt:

WebCore:

Reviewed by darin

<rdar://problem/5002441>
Pressing space key does nothing above quoted content or a signature


Inserting a space under these circumstances inserts a single
text node containing a regular space and then does a layout.
That space isn't rendered (which is correct). Whitespace
rebalancing is supposed to correct it but failed. It replaces
the space with a non-breaking space, but that change doesn't
dirty line boxes (9441) and so the space isn't rendered.


This workaround turns all incoming spaces into non-breaking
spaces before they're inserted (they're rebalanced after
insertion and turned back into regular spaces if possible).

  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::prepareForTextInsertion): Removed an old irrelevant FIXME. (WebCore::InsertTextCommand::input): Turn incoming spaces into non breaking spaces before inserting them.
3:10 PM Changeset in webkit [21211] by darin
  • 14 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/canvas/canvas-size-change-after-layout-expected.checksum: Added.
  • fast/canvas/canvas-size-change-after-layout-expected.png: Added.
  • fast/canvas/canvas-size-change-after-layout-expected.txt: Added.
  • fast/canvas/canvas-size-change-after-layout.html: Added.

WebCore:

Reviewed by Hyatt.

  • remove intrinsicWidth/Height functions from RenderObject

Test: fast/canvas/canvas-size-change-after-layout.html

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createRenderer): Removed code to set the intrinsic size, because the renderer now takes care of this in its constructor. (WebCore::HTMLCanvasElement::reset): Instead of calling the setIntrinsicWidth/Height functions, call canvasSizeChanged, which takes care of layout, but only if the size actually changed. Also call repaint if the contents of the canvas changed.
  • rendering/RenderApplet.h:
  • rendering/RenderApplet.cpp: (WebCore::RenderApplet::intrinsicSize): Override the new intrinsicSize function. This override still doesn't make sense, so left a FIXME in here.
  • rendering/RenderBox.h: Added an intrinsicSize function here to replace the intrinsicWidth/Height functions removed from RenderObject.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcReplacedWidthUsing): Use intrinsicSize instead of intrinsicWidth. (WebCore::RenderBox::calcReplacedHeightUsing): Ditto, but for height.
  • rendering/RenderHTMLCanvas.h: Changed the constructor parameter to be an HTMLCanvasElement* instead of Node*. Also added a canvasSizeChanged function.
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::RenderHTMLCanvas): Pass an initial intrinsic size based on the current size of the canvas element. This is now the responsibility of the renderer and the DOM element calls the canvasSizeChanged function when the size changes. (WebCore::RenderHTMLCanvas::paint): Removed checks of the type of the element, and used the node() function because we don't have to worry about the anonymous case in this class. (WebCore::RenderHTMLCanvas::canvasSizeChanged): Added. Changes the size and then calls setNeedsLayout and setPrefWidthsDirty as needed. I based the logic here on careful reading of RenderImage::imageChanged.
  • rendering/RenderImage.cpp: (WebCore::RenderImage::RenderImage): Pass a default intrinsic size of 0,0 instead of calling setIntrinsicWidth/Height. (WebCore::RenderImage::setImageSizeForAltText): Call the new intrinsic size functions instead of the width/height ones. Simplifies the logic since we handle both dimensions at once. (WebCore::RenderImage::imageChanged): Ditto. (WebCore::RenderImage::layout): Ditto. (WebCore::RenderImage::calcAspectRatioWidth): Ditto. (WebCore::RenderImage::calcAspectRatioHeight): Ditto.
  • rendering/RenderObject.h: Removed intrinsicWidth/Height virtual functions.
  • rendering/RenderReplaced.h: Replaced intrinsicWidth, intrinsicHeight, setIntrinsicWidth, setIntrinsicHeight, m_intrinsicWidth, and m_intrinsicHeight with intrinsicSize, setIntrinsicSize, and m_intrinsicSize.
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::RenderReplaced): Added a second contructor that takes an intrinsic size parameter. Also updated constructor since the intrinsic size is now an IntSize instead of two integers. (WebCore::RenderReplaced::intrinsicSize): Added. No point in making this inline because it's a virtual function. (WebCore::RenderReplaced::setIntrinsicSize): Added. Didn't make this inline, partly because in the future we might want this to be more than just a simple setter function, factoring in common code used in both RenderImage and RenderHTMLCanvas.
  • rendering/RenderWidget.h: Removed a stray using declaration that wasn't needed.
2:37 PM Changeset in webkit [21210] by spadma
  • 2 edits in S60/trunk/WebKit

yadavall, reviewed by <​sachin.padma@nokia.com>

DESC: Toolbar should be activated only on long keypress
​http://bugs.webkit.org/show_bug.cgi?id=12816

  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleOfferKeyEventL): (CKeyEventHandler::HandleActivateKeysL):
1:44 PM Changeset in webkit [23338] by sfalken
  • 4 edits in branches/WindowsMerge

2007-05-01 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Oliver.


Fix usage errors in COM enumeration.

  • WebEditorClient.cpp: (WebEditorClient::checkGrammarOfString): Call Next correctly. (WebEditorClient::getGuessesForWord): Call Next correctly.


2007-05-01 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Oliver.

Fix crash when retrieving title of context menu after it has been selected.
Necessary to get spelling corrections code working.

  • platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::itemWithAction): menu item info fType is a set of flags, MFT_STRING is 0, so we need to or off flags before comparing.
1:11 PM Changeset in webkit [21209] by hyatt
  • 4 edits in trunk/WebCore

Fix for hang when incorrectly trying to add before/after content to
a <select>. Disallow generated content in all selects and also turn it
off for <input> buttons.

Reviewed by aroben

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::setStyle):
  • rendering/RenderButton.cpp: (WebCore::RenderButton::canHaveChildren):
  • rendering/RenderButton.h:
12:59 PM Changeset in webkit [21208] by darin
  • 114 edits
    2 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • added a test for <rdar://problem/5172596> HTML-parser-created tbody elements are being ignored when processing CSS child rules
  • fast/css/child-selector-implicit-tbody.html: Added.
  • fast/css/child-selector-implicit-tbody-expected.txt: Added.
  • updated test results for <rdar://problem/5172607> XML parser is creating implicit tbody elements; the only change is the tag name that's dumped
  • fast/table/037-expected.txt:
  • tables/mozilla/marvin/x_caption_align_bottom-expected.txt:
  • tables/mozilla/marvin/x_caption_align_top-expected.txt:
  • tables/mozilla/marvin/x_caption_class-expected.txt:
  • tables/mozilla/marvin/x_caption_id-expected.txt:
  • tables/mozilla/marvin/x_caption_style-expected.txt:
  • tables/mozilla/marvin/x_col_align_center-expected.txt:
  • tables/mozilla/marvin/x_col_align_char-expected.txt:
  • tables/mozilla/marvin/x_col_align_justify-expected.txt:
  • tables/mozilla/marvin/x_col_align_left-expected.txt:
  • tables/mozilla/marvin/x_col_align_right-expected.txt:
  • tables/mozilla/marvin/x_col_span-expected.txt:
  • tables/mozilla/marvin/x_col_valign_baseline-expected.txt:
  • tables/mozilla/marvin/x_col_valign_bottom-expected.txt:
  • tables/mozilla/marvin/x_col_valign_middle-expected.txt:
  • tables/mozilla/marvin/x_col_valign_top-expected.txt:
  • tables/mozilla/marvin/x_col_width_pct-expected.txt:
  • tables/mozilla/marvin/x_col_width_px-expected.txt:
  • tables/mozilla/marvin/x_col_width_rel-expected.txt:
  • tables/mozilla/marvin/x_colgroup_align_center-expected.txt:
  • tables/mozilla/marvin/x_colgroup_align_char-expected.txt:
  • tables/mozilla/marvin/x_colgroup_align_justify-expected.txt:
  • tables/mozilla/marvin/x_colgroup_align_left-expected.txt:
  • tables/mozilla/marvin/x_colgroup_align_right-expected.txt:
  • tables/mozilla/marvin/x_colgroup_span-expected.txt:
  • tables/mozilla/marvin/x_colgroup_valign_baseline-expected.txt:
  • tables/mozilla/marvin/x_colgroup_valign_bottom-expected.txt:
  • tables/mozilla/marvin/x_colgroup_valign_middle-expected.txt:
  • tables/mozilla/marvin/x_colgroup_valign_top-expected.txt:
  • tables/mozilla/marvin/x_colgroup_width_rel-expected.txt:
  • tables/mozilla/marvin/x_table_align_center-expected.txt:
  • tables/mozilla/marvin/x_table_align_left-expected.txt:
  • tables/mozilla/marvin/x_table_align_right-expected.txt:
  • tables/mozilla/marvin/x_table_bgcolor_name-expected.txt:
  • tables/mozilla/marvin/x_table_bgcolor_rgb-expected.txt:
  • tables/mozilla/marvin/x_table_cellpadding-expected.txt:
  • tables/mozilla/marvin/x_table_cellpadding_pct-expected.txt:
  • tables/mozilla/marvin/x_table_cellspacing-expected.txt:
  • tables/mozilla/marvin/x_table_cellspacing_pct-expected.txt:
  • tables/mozilla/marvin/x_table_class-expected.txt:
  • tables/mozilla/marvin/x_table_id-expected.txt:
  • tables/mozilla/marvin/x_table_style-expected.txt:
  • tables/mozilla/marvin/x_table_width_pct-expected.txt:
  • tables/mozilla/marvin/x_table_width_px-expected.txt:
  • tables/mozilla/marvin/x_td_align_center-expected.txt:
  • tables/mozilla/marvin/x_td_align_char-expected.txt:
  • tables/mozilla/marvin/x_td_align_justify-expected.txt:
  • tables/mozilla/marvin/x_td_align_left-expected.txt:
  • tables/mozilla/marvin/x_td_align_right-expected.txt:
  • tables/mozilla/marvin/x_td_bgcolor_name-expected.txt:
  • tables/mozilla/marvin/x_td_bgcolor_rgb-expected.txt:
  • tables/mozilla/marvin/x_td_class-expected.txt:
  • tables/mozilla/marvin/x_td_colspan-expected.txt:
  • tables/mozilla/marvin/x_td_height-expected.txt:
  • tables/mozilla/marvin/x_td_id-expected.txt:
  • tables/mozilla/marvin/x_td_nowrap-expected.txt:
  • tables/mozilla/marvin/x_td_rowspan-expected.txt:
  • tables/mozilla/marvin/x_td_style-expected.txt:
  • tables/mozilla/marvin/x_td_valign_baseline-expected.txt:
  • tables/mozilla/marvin/x_td_valign_bottom-expected.txt:
  • tables/mozilla/marvin/x_td_valign_middle-expected.txt:
  • tables/mozilla/marvin/x_td_valign_top-expected.txt:
  • tables/mozilla/marvin/x_td_width-expected.txt:
  • tables/mozilla/marvin/x_th_align_center-expected.txt:
  • tables/mozilla/marvin/x_th_align_char-expected.txt:
  • tables/mozilla/marvin/x_th_align_justify-expected.txt:
  • tables/mozilla/marvin/x_th_align_left-expected.txt:
  • tables/mozilla/marvin/x_th_align_right-expected.txt:
  • tables/mozilla/marvin/x_th_bgcolor_name-expected.txt:
  • tables/mozilla/marvin/x_th_bgcolor_rgb-expected.txt:
  • tables/mozilla/marvin/x_th_class-expected.txt:
  • tables/mozilla/marvin/x_th_colspan-expected.txt:
  • tables/mozilla/marvin/x_th_height-expected.txt:
  • tables/mozilla/marvin/x_th_id-expected.txt:
  • tables/mozilla/marvin/x_th_nowrap-expected.txt:
  • tables/mozilla/marvin/x_th_rowspan-expected.txt:
  • tables/mozilla/marvin/x_th_style-expected.txt:
  • tables/mozilla/marvin/x_th_valign_baseline-expected.txt:
  • tables/mozilla/marvin/x_th_valign_bottom-expected.txt:
  • tables/mozilla/marvin/x_th_valign_middle-expected.txt:
  • tables/mozilla/marvin/x_th_valign_top-expected.txt:
  • tables/mozilla/marvin/x_th_width-expected.txt:
  • tables/mozilla/marvin/x_tr_align_center-expected.txt:
  • tables/mozilla/marvin/x_tr_align_char-expected.txt:
  • tables/mozilla/marvin/x_tr_align_justify-expected.txt:
  • tables/mozilla/marvin/x_tr_align_left-expected.txt:
  • tables/mozilla/marvin/x_tr_align_right-expected.txt:
  • tables/mozilla/marvin/x_tr_bgcolor_name-expected.txt:
  • tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.txt:
  • tables/mozilla/marvin/x_tr_class-expected.txt:
  • tables/mozilla/marvin/x_tr_id-expected.txt:
  • tables/mozilla/marvin/x_tr_style-expected.txt:
  • tables/mozilla/marvin/x_tr_valign_baseline-expected.txt:
  • tables/mozilla/marvin/x_tr_valign_bottom-expected.txt:
  • tables/mozilla/marvin/x_tr_valign_middle-expected.txt:
  • tables/mozilla/marvin/x_tr_valign_top-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug178855-expected.txt:
  • tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.txt:
  • tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.txt:
  • tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.txt:
  • tables/mozilla_expected_failures/marvin/x_colgroup_width_px-expected.txt:

WebCore:

Reviewed by Hyatt.

  • removed the m_implicit bit from Node, freeing up a bit
  • fixed <rdar://problem/5172607> XML parser is creating implicit tbody elements
  • fixed <rdar://problem/5172596> HTML-parser-created tbody elements are being ignored when processing CSS child rules

Test: fast/css/child-selector-implicit-tbody.html

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkSelector): Removed code that used to look at implicitNode(), which no longer exists.
  • css/html4.css: Added a style rule to handle cases where we have a tr inside a table with no intervening table section.
  • dom/Node.h: Removed the bit.
  • dom/Node.cpp: (WebCore::Node::Node): Don't initialize the bit. (WebCore::Node::dump): Don't dump the bit.
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startElementNs): Remove the code that made a table body element. This is handled in the render tree, the DOM tree should not be mangled. (WebCore::XMLTokenizer::endElementNs): Removed code that used to look at implicitNode(), which no longer exists.
  • html/HTMLElementFactory.cpp: (WebCore::tableSectionConstructor): Removed boolean parameter that was passed to the HTMLTableSectionElement constructor.
  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): Ditto.
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::createTHead): Ditto. (WebCore::HTMLTableElement::createTFoot): Ditto. (WebCore::HTMLTableElement::insertRow): Changed to return a PassRefPtr, because it's possible the row could be removed from the table by JavaScript code responding to DOM mutation events before the function returns. Just something I noticed by code inspection.
  • html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::HTMLTableSectionElement): Removed boolean "implicit" parameter to the constructor. (WebCore::HTMLTableSectionElement::insertRow): Changed to return a PassRefPtr for the same reason cited above.
  • html/HTMLTableElement.h: Changed the return value of insertRow to be a PassRefPtr.
  • html/HTMLTableSectionElement.h: Ditto.
12:04 PM Changeset in webkit [21207] by sfalken
  • 1 copy in tags/Safari-522.6.4b

New tag.

10:21 AM Changeset in webkit [21206] by bdash
  • 1 edit in tags/WebKit-419.1/WebKit/Info.plist

Versioning.

10:20 AM Changeset in webkit [21205] by bdash
  • 1 edit in tags/WebKit-419.1/WebKit/Plugins.subproj/WebBaseNetscapePluginView.m

Reinstate a small portion of r20042 that was lost during the merge in r21111.

6:48 AM Changeset in webkit [21204] by bdash
  • 10 edits
    4 copies in branches/Safari-522

Merge r20923.

6:38 AM Changeset in webkit [21203] by bdash
  • 3 edits
    4 copies in branches/Safari-522

Merge r21062.

6:22 AM Changeset in webkit [21202] by bdash
  • 3 edits
    4 copies in branches/Safari-522

Merge r20490.

6:04 AM Changeset in webkit [21201] by bdash
  • 3 edits
    2 copies in branches/Safari-522

Merge r21175.

2:03 AM Changeset in webkit [21200] by ap
  • 3 edits in trunk/JavaScriptCore

2007-05-01 Jungshik Shin <​jungshik.shin@gmail.com>

Reviewed by Alexey.


  • kjs/testkjs.cpp:
  • pcre/pcre_compile.c:

Apr 30, 2007:

11:05 PM Changeset in webkit [23337] by aliceli1
  • 7 edits in branches/WindowsMerge

WebKitToolsWin:

Reviewed by Adam.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (main): As a consequence of <rdar://5126201>, removed call to webView->close() and patched leak resulting from that change.

WebKitWin:

Reviewed by Adam.

Fixed <rdar://5126201> crash closing tab when the two following tabs are empty.
Basically this fix involved one thing, which lead to another thing. First, the crash
was fixed by moving the call to webView->close from SearchableWebView::onDestroy to
WebViewWndProc when WM_DESTROY message is processed. We now want only WebKit handling
the closure of a WebView, so all calls to WebView::close have been removed, save for
the one call in WebViewWndProc.

  • Interfaces/IWebView.idl: removed close() from public interface
  • WebInspector/WebInspector.cpp: (WebInspector::onDestroy): removed call to close()
  • WebView.cpp: (WebView::~WebView): move the deleting of m_page down a bit to avoid a crash (WebView::close): changed from public API to just a public function (WebViewWndProc): webView->close() was moved here from SearchableWebView::onDestroy
  • WebView.h: changed close() to a public function not exposed in the WebKit interface
9:57 PM Changeset in webkit [21199] by hyatt
  • 38 edits
    4 adds in trunk

LayoutTests:

Fix for bug 12691, generated content and display: table-cell duplicates
content on a size change. Make sure that the code to update before/after
content is smart enough to drill into anonymous containers to find the
old child.

Reviewed by olliej

  • fast/css-generated-content/table-cell-before-content-expected.checksum: Added.
  • fast/css-generated-content/table-cell-before-content-expected.png: Added.
  • fast/css-generated-content/table-cell-before-content-expected.txt: Added.
  • fast/css-generated-content/table-cell-before-content.html: Added.

WebCore:

Fix for bug 12691, generated content and display: table-cell duplicates
content on a size change. Make sure that the code to update before/after
content is smart enough to drill into anonymous containers to find the
old child.

Reviewed by olliej

Added fast/css-generated-content/table-cell-before-content.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::setStyle):
  • rendering/RenderButton.cpp: (WebCore::RenderButton::updateBeforeAfterContent):
  • rendering/RenderButton.h:
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::beforeAfterContainer): (WebCore::RenderContainer::updateBeforeAfterContent): (WebCore::RenderContainer::updateBeforeAfterContentForObject):
  • rendering/RenderContainer.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::setStyle): (WebCore::RenderInline::addChildToFlow): (WebCore::RenderInline::splitInlines):
9:32 PM Changeset in webkit [21198] by justing
  • 2 edits in trunk/WebCore

Reviewed by justin


<​http://bugs.webkit.org/show_bug.cgi?id=13552>
comment to Range::comparePoint in dom/Range.cpp has
'0xD0' in place of '-': leading to a compiler warning

  • dom/Range.cpp: (WebCore::Range::comparePoint):
4:45 PM Changeset in webkit [21197] by justing
  • 7 edits
    8 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/4875189> List gets deleted when replacing contents

Replacing the contents of a list:

  • editing/inserting/4875189-1-expected.checksum: Added.
  • editing/inserting/4875189-1-expected.png: Added.
  • editing/inserting/4875189-1-expected.txt: Added.
  • editing/inserting/4875189-1.html: Added. Of a floating div:
  • editing/inserting/4875189-2-expected.checksum: Added.
  • editing/inserting/4875189-2-expected.png: Added.
  • editing/inserting/4875189-2-expected.txt: Added.
  • editing/inserting/4875189-2.html: Added. Pasting a list on top of itself now creates a nested list:
  • editing/pasteboard/paste-4039777-fix-expected.checksum:
  • editing/pasteboard/paste-4039777-fix-expected.png:
  • editing/pasteboard/paste-4039777-fix-expected.txt:

WebCore:

Reviewed by darin

<rdar://problem/4875189> List gets deleted when replacing contents

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Don't expand to include elements, like lists, when deleting a selection to replace it.
3:06 PM Changeset in webkit [21196] by justing
  • 4 edits in trunk/WebCore

Reviewed by ggaren


Buildfix. Leave in grammar checking machinery to
keep WebKit building on other platforms but don't
operate on sentence sized chunks so that we don't
re-introduce 5157329.

  • editing/Editor.h:
  • editing/mac/EditorMac.mm: (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::markMisspellingsOrBadGrammar): (WebCore::Editor::markMisspellings): (WebCore::Editor::markBadGrammar):
  • page/Frame.cpp: (WebCore::Frame::respondToChangedSelection):
2:14 PM Changeset in webkit [21195] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/5168598> Crash when deleting a link inside an input field

  • editing/deleting/5168598-expected.checksum: Added.
  • editing/deleting/5168598-expected.png: Added.
  • editing/deleting/5168598-expected.txt: Added.
  • editing/deleting/5168598.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/5168598>
Crash when deleting a link inside an input field


Deletion code tries to update one of its positions to keep
it valid and nullifies it. Later in mergeParagraphs we try
to find out if it's valid by checking to see if it's still in
the document and crash.


The fix is just to not bother keeping the position,
m_upstreamStart, valid, since after the point in the code
under examination, it doesn't need to be valid anymore.
Besides, code to update DeleteSelectionCommand's positions
should go in the functions that handle the content removal
that might invalid them (there are already FIXMEs about this).


Also, users shouldn't be able to insert links (or any rich content)
into plaintext-only regions like text fields, even if those
text fields are inside richly editable regions. This is a
separate bug and is filed as 5171552.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete): Don't bother updating m_upstreamStart.
2:03 PM Changeset in webkit [21194] by pyeh
  • 7 edits
    1 add in trunk/WebCore

<rdar://problem/5108546> REGRESSION: Zoom follows keyboard focus does not work

  • WebCore.xcodeproj/project.pbxproj: Add new file SelectionControllerMac.mm
  • dom/Document.cpp: (WebCore::Document::updateSelection): Move the code to fire off AXSelectedTextChanged notification to a new method notifyAccessibilityForSelectionChange in SelectionControllerMac.mm
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): call notifyAccessibilityForSelectionChange to handle firing of accessibility notification and zoomFocusChange
  • editing/SelectionController.h: Add notifyAccessibilityForSelectionChange method for Mac platform
  • platform/Widget.h:
  • platform/mac/WidgetMac.mm: (WebCore::Widget::convertToScreenCoordinate): Add a helper routine that takes IntPoint in local coordinate and convert that to screen coordinate
12:43 PM Changeset in webkit [21193] by justing
  • 4 edits in trunk/WebCore

Reviewed by harrison

<rdar://problem/5157329>
REGRESSION: Crash at WTF::fastFree() when arrowing or deleting backward through editable text (13493)


Backing out the changes for 4859132.

  • editing/Editor.h:
  • editing/mac/EditorMac.mm: (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::Editor::markMisspellings):
  • page/Frame.cpp: (WebCore::Frame::respondToChangedSelection):
10:43 AM Changeset in webkit [21192] by kmccullo
  • 2 edits in trunk/WebKitTools
  • Removed debugging statements and took out the removal of the deletion of the symlink. This is because multiple instances of run-webkit-tests can be running at the same time.
  • Scripts/run-webkit-tests:
7:40 AM Changeset in webkit [21191] by spadma
  • 2 edits in S60/trunk/WebKit

raalexan, reviewed by <​sachin.padma@nokia.com>

DESC: Browser crashes while loading www.cnn.com
​http://bugs.webkit.org/show_bug.cgi?id=13488

TSW ID : AKUR-6UED6S

  • ResourceLoader/src/AboutTransaction.cpp:
7:40 AM Changeset in webkit [21190] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

raalexan, reviewed by <​sachin.padma@nokia.com>

DESC: Browser crashes while loading www.cnn.com
​http://bugs.webkit.org/show_bug.cgi?id=13488

TSW ID : AKUR-6UED6S

  • ResourceLoader/src/AboutTransaction.cpp:
7:35 AM Changeset in webkit [21189] by yongjzha
  • 4 edits in S60/trunk/WebKit

raalexan, reviewed by Yongjun

DESC: can't do the chinese keyword searching on the brower
​http://bugs.webkit.org/show_bug.cgi?id=13418
TSW ID: RLEA-6ZFCBF

  • BrowserCore/Formcontrols/inc/FControlInputSkin.h:
  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::SelectedLanguage):
  • BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::OfferKeyEventL):
3:44 AM Changeset in webkit [21188] by antti
  • 4 edits in trunk/WebCore

Reviewed by Oliver.

Fix <rdar://problem/5169261>
REGRESSION: Google Maps zooming too sensitive when using two fingers on trackpad


Use line based delta values when generating DOM wheel events, use pixel deltas
for scrolling only.


No test case, requires user interaction and specific hardware.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent):
  • platform/PlatformWheelEvent.h: (WebCore::PlatformWheelEvent::continuousDeltaX): (WebCore::PlatformWheelEvent::continuousDeltaY):
  • platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
Note: See TracTimeline for information about the timeline view.