Context Navigation

← Previous Period
Next Period →

Timeline

May 2, 2007:

9:39 PM Changeset in webkit [21226] by bdash

2 edits in trunk/WebCore

2007-05-03 Mark Rowe <mrowe@apple.com>

Qt build fix. In r21185 the Qt version of WebCore::scaleDragImage was
updated to have the incorrect signature.

platform/qt/DragImageQt.cpp: (WebCore::scaleDragImage):

3:27 PM Changeset in webkit [21225] by bdakin

2 edits in trunk/WebCore

dom/Node.h: Just fixing a variable name because it's driving me mad.

3:16 PM Changeset in webkit [21224] by bdakin

15 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/4513966> Never-ending identical repaint @
orbitz.com (Safari eating 85% CPU)

We need to be a little bit more savvy about when we do a FULL style
recalc since it can be unnecessary and expensive.

css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setChanged): Now takes a StyleChangeType as a parameter. (WebCore::CSSMutableStyleDeclaration::setProperty): Send InlineStyleChange as the paramter. This is the optimization!
css/CSSMutableStyleDeclaration.h: setChanged takes a StyleChangeType as a parameter.
dom/Document.cpp: setChanged now takes a StyleChangeType instead of a bool. (WebCore::Document::recalcStyle): Same.
dom/Element.cpp: (WebCore::Element::recalcStyle): This is the fix!! Only set change to Force is we use descendant rules AND it's a FullStyleChange.
dom/Node.cpp: m_hasStyle was an unused bit on Node, so this patch gets rid of it and uses that extra bit for m_changed to be a StyleChangeType instead of a bool. (WebCore::Node::Node): (WebCore::Node::setChanged): (WebCore::Node::dump):
dom/Node.h: Same. (WebCore::): Define the StyleChangeType enum. (WebCore::Node::hasClass): (WebCore::Node::changed): (WebCore::Node::styleChangeType): (WebCore::Node::setHasClass):
dom/StyledElement.cpp: (WebCore::StyledElement::parseMappedAttribute): Don't bother calling setHasStyle() since m_hasStyle is gone now. It was never used, and this was the only place it was set.
dom/Text.cpp: (WebCore::Text::recalcStyle): setChanged now takes a StyleChangeType instead of a bool.
html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::recalcStyle): Same.
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::restoreState): Same. (WebCore::HTMLSelectElement::reset): Same.
html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue): Same.
ksvg2/misc/SVGTimer.cpp: (WebCore::SVGTimer::applyAnimations): Same.
ksvg2/svg/SVGUseElement.cpp: (WebCore::SVGUseElement::recalcStyle): Same.
platform/graphics/svg/SVGResource.cpp: (WebCore::SVGResource::repaintClients): Same.

12:36 PM Changeset in webkit [21223] by andersca

2 edits in trunk/WebKit

Reviewed by Brady.

<rdar://problem/5151113> Assertion firing in [FrameProgressEntry addChild:forDataSource:] when navigating cnn.com

The assertion fired because a plug-in was trying to load a subresource when a new load had started but not yet
committed. The check that would have prevented this was removed in order to fix <rdar://problem/5085897>.

This puts back the check but changes it to allow loads where the target is the same frame as the plugin's parent frame.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):

7:54 AM Changeset in webkit [21222] by harrison

3 edits in trunk/WebCore

Reviewed by Antti.

<rdar://problem/4859132> Grammar must always be checked in entire-sentence chunks, and shouldn't show markers for current sentence

Restore the remainder of the original fix now that blocking bug rdar://5174862 is addressed.

John made the original patch on 2007-04-10, but this fell prey to rdar://5157329.
Justin backed out the whole patch on 2007-04-30 to avoid the crash.
Justin then restored most of the original patch, but used word granularity instead, to keep the build working.
I just addressed the root cause of rdar://5157329 in rdar://5174862.
This patch switches the temp uses of word granularity back to sentence granularity.

editing/mac/EditorMac.mm: (WebCore::Editor::markMisspellingsAfterTypingToPosition):
page/Frame.cpp: (WebCore::Frame::respondToChangedSelection):

6:11 AM Changeset in webkit [21221] by harrison

6 edits
4 adds in trunk

JavaScriptCore:

Reviewed by Antti.

<rdar://problem/5174862> Crash resulting from DeprecatedString::insert()

Added insertion support for more than one value.

wtf/Vector.h: (WTF::::insert): Added support for inserting multiple values.

(WTF::::prepend):
New. Insert at the start of vectors. Convenient for vectors used as strings.

LayoutTests:

Reviewed by Antti.

test for <rdar://problem/5174862> Crash resulting from DeprecatedString::insert()

editing/selection/move-by-sentence-001-expected.checksum: Added.
editing/selection/move-by-sentence-001-expected.png: Added.
editing/selection/move-by-sentence-001-expected.txt: Added.
editing/selection/move-by-sentence-001.html: Added.

WebCore:

Reviewed by Antti.

<rdar://problem/5174862> Crash resulting from DeprecatedString::insert()

Test added: editing/selection/move-by-sentence-001.html

editing/visible_units.cpp: (WebCore::previousBoundary): (WebCore::nextBoundary): Use a UChar Vector instead of DeprecatedString. Avoid creating an extra string for secure bullet replacement unless it is actually needed.

platform/DeprecatedString.cpp: (WebCore::DeprecatedString::insert): Call forceUnicode() before setLength(), so that only the unicode buffer is resized.

(WebCore::DeprecatedString::setLength):

Adjust the unicode buffer even if the ascii buffer is valid.

2:21 AM Changeset in webkit [21220] by bdash

3 edits in trunk/WebKitTools

2007-05-02 Holger Freyther <freyther@kde.org>

Reviewed by Mark Rowe.

Scripts/build-webkit: Remove the CMake call.
Scripts/webkitdirs.pm: Remove isQtWithQMake as QMake is now the only buildsystem for the Qt port.

2:20 AM Changeset in webkit [21219] by bdash

6 edits in trunk/WebCore

2007-05-02 Mitz Pettel <mitz@webkit.org>

Reviewed by Brady.

http://bugs.webkit.org/show_bug.cgi?id=13564 Remove friend class FrameLoader from Frame

No test added since there is no change in functionality.

loader/FrameLoader.cpp: (WebCore::FrameLoader::didOpenURL): (WebCore::FrameLoader::begin): (WebCore::FrameLoader::open):
loader/FrameLoader.h: Made clear() private.
page/Frame.cpp: (WebCore::Frame::setDocument): Changed the argument into a PassRefPtr.
page/Frame.h:
xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource):

2:17 AM Changeset in webkit [21218] by bdash

3 edits
5 adds in trunk

2007-05-02 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=9276 Quirksmode: Image swap resize bug

Test: fast/replaced/image-resize-width.html

rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged): Moved the call to dirtyPrefWidths() before the call to calcWidth().

2007-05-02 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

test for http://bugs.webkit.org/show_bug.cgi?id=9276 Quirksmode: Image swap resize bug

fast/replaced/image-resize-width-expected.checksum: Added.
fast/replaced/image-resize-width-expected.png: Added.
fast/replaced/image-resize-width-expected.txt: Added.
fast/replaced/image-resize-width.html: Added.
fast/replaced/resources/rectangle-red-200x100.png: Added.

1:44 AM Changeset in webkit [21217] by hyatt

4 adds in trunk/LayoutTests/fast/block/positioning

Add layout test for dashboard bug.

1:39 AM Changeset in webkit [21216] by hyatt

2 edits in trunk/WebCore

Fix for bug 13566, broken Dashboard widgets. setPrefWidthsDirty did
the wrong thing for text children of a positioned element.

Reviewed by mitz

fast/block/positioning/pref-width-change.html

rendering/RenderObject.cpp: (WebCore::RenderObject::setPrefWidthsDirty):

May 1, 2007:

6:40 PM Changeset in webkit [21215] by darin

2 edits in trunk/WebCore

rendering/RenderReplaced.cpp: Fix typo in a comment.

3:31 PM Changeset in webkit [21214] by hyatt

4 adds in trunk/LayoutTests/fast/css-generated-content

Add layout test for 13558.

3:27 PM Changeset in webkit [21213] by hyatt

2 edits in trunk/WebCore

Fix for 13558, crash when using absolutely positioned generated content
inside an inline.

Reviewed by darin

fast/css-generated-content/absolute-position-inside-inline.html

rendering/RenderContainer.cpp: (WebCore::RenderContainer::updateBeforeAfterContentForContainer):

3:20 PM Changeset in webkit [21212] by justing

12 edits
4 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/5002441>
Pressing space key does nothing above quoted content or a signature

Demonstrates the bug:

editing/inserting/5002441-expected.checksum: Added.
editing/inserting/5002441-expected.png: Added.
editing/inserting/5002441-expected.txt: Added.
editing/inserting/5002441.html: Added.

Fixed. Spaces passed to execCommand("InsertText", ...)
are no longer collapsed:

editing/inserting/editable-html-element-expected.checksum:
editing/inserting/editable-html-element-expected.png:
editing/inserting/editable-html-element-expected.txt:
editing/pasteboard/4989774-expected.checksum:
editing/pasteboard/4989774-expected.png:
editing/pasteboard/4989774-expected.txt:
editing/selection/4983858-expected.checksum:
editing/selection/4983858-expected.png:
editing/selection/4983858-expected.txt:

WebCore:

Reviewed by darin

<rdar://problem/5002441>
Pressing space key does nothing above quoted content or a signature

Inserting a space under these circumstances inserts a single
text node containing a regular space and then does a layout.
That space isn't rendered (which is correct). Whitespace
rebalancing is supposed to correct it but failed. It replaces
the space with a non-breaking space, but that change doesn't
dirty line boxes (9441) and so the space isn't rendered.

This workaround turns all incoming spaces into non-breaking
spaces before they're inserted (they're rebalanced after
insertion and turned back into regular spaces if possible).

editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::prepareForTextInsertion): Removed an old irrelevant FIXME. (WebCore::InsertTextCommand::input): Turn incoming spaces into non breaking spaces before inserting them.

3:10 PM Changeset in webkit [21211] by darin

14 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

test for http://bugs.webkit.org/show_bug.cgi?id=13559 REGRESSION: Canvas aspect ratio is incorrect

fast/canvas/canvas-size-change-after-layout-expected.checksum: Added.
fast/canvas/canvas-size-change-after-layout-expected.png: Added.
fast/canvas/canvas-size-change-after-layout-expected.txt: Added.
fast/canvas/canvas-size-change-after-layout.html: Added.

WebCore:

Reviewed by Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13559 REGRESSION: Canvas aspect ratio is incorrect

remove intrinsicWidth/Height functions from RenderObject

Test: fast/canvas/canvas-size-change-after-layout.html

html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createRenderer): Removed code to set the intrinsic size, because the renderer now takes care of this in its constructor. (WebCore::HTMLCanvasElement::reset): Instead of calling the setIntrinsicWidth/Height functions, call canvasSizeChanged, which takes care of layout, but only if the size actually changed. Also call repaint if the contents of the canvas changed.

rendering/RenderApplet.h:
rendering/RenderApplet.cpp: (WebCore::RenderApplet::intrinsicSize): Override the new intrinsicSize function. This override still doesn't make sense, so left a FIXME in here.

rendering/RenderBox.h: Added an intrinsicSize function here to replace the intrinsicWidth/Height functions removed from RenderObject.
rendering/RenderBox.cpp: (WebCore::RenderBox::calcReplacedWidthUsing): Use intrinsicSize instead of intrinsicWidth. (WebCore::RenderBox::calcReplacedHeightUsing): Ditto, but for height.

rendering/RenderHTMLCanvas.h: Changed the constructor parameter to be an HTMLCanvasElement* instead of Node*. Also added a canvasSizeChanged function.
rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::RenderHTMLCanvas): Pass an initial intrinsic size based on the current size of the canvas element. This is now the responsibility of the renderer and the DOM element calls the canvasSizeChanged function when the size changes. (WebCore::RenderHTMLCanvas::paint): Removed checks of the type of the element, and used the node() function because we don't have to worry about the anonymous case in this class. (WebCore::RenderHTMLCanvas::canvasSizeChanged): Added. Changes the size and then calls setNeedsLayout and setPrefWidthsDirty as needed. I based the logic here on careful reading of RenderImage::imageChanged.

rendering/RenderImage.cpp: (WebCore::RenderImage::RenderImage): Pass a default intrinsic size of 0,0 instead of calling setIntrinsicWidth/Height. (WebCore::RenderImage::setImageSizeForAltText): Call the new intrinsic size functions instead of the width/height ones. Simplifies the logic since we handle both dimensions at once. (WebCore::RenderImage::imageChanged): Ditto. (WebCore::RenderImage::layout): Ditto. (WebCore::RenderImage::calcAspectRatioWidth): Ditto. (WebCore::RenderImage::calcAspectRatioHeight): Ditto.

rendering/RenderObject.h: Removed intrinsicWidth/Height virtual functions.

rendering/RenderReplaced.h: Replaced intrinsicWidth, intrinsicHeight, setIntrinsicWidth, setIntrinsicHeight, m_intrinsicWidth, and m_intrinsicHeight with intrinsicSize, setIntrinsicSize, and m_intrinsicSize.
rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::RenderReplaced): Added a second contructor that takes an intrinsic size parameter. Also updated constructor since the intrinsic size is now an IntSize instead of two integers. (WebCore::RenderReplaced::intrinsicSize): Added. No point in making this inline because it's a virtual function. (WebCore::RenderReplaced::setIntrinsicSize): Added. Didn't make this inline, partly because in the future we might want this to be more than just a simple setter function, factoring in common code used in both RenderImage and RenderHTMLCanvas.

rendering/RenderWidget.h: Removed a stray using declaration that wasn't needed.

2:37 PM Changeset in webkit [21210] by spadma

2 edits in S60/trunk/WebKit

yadavall, reviewed by <sachin.padma@nokia.com>

DESC: Toolbar should be activated only on long keypress
http://bugs.webkit.org/show_bug.cgi?id=12816

BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleOfferKeyEventL): (CKeyEventHandler::HandleActivateKeysL):

1:44 PM Changeset in webkit [23338] by sfalken

4 edits in branches/WindowsMerge

2007-05-01 Steve Falkenburg <sfalken@apple.com>

Reviewed by Oliver.

Fix usage errors in COM enumeration.

WebEditorClient.cpp: (WebEditorClient::checkGrammarOfString): Call Next correctly. (WebEditorClient::getGuessesForWord): Call Next correctly.

2007-05-01 Steve Falkenburg <sfalken@apple.com>

Reviewed by Oliver.

Fix crash when retrieving title of context menu after it has been selected.
Necessary to get spelling corrections code working.

platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::itemWithAction): menu item info fType is a set of flags, MFT_STRING is 0, so we need to or off flags before comparing.

1:11 PM Changeset in webkit [21209] by hyatt

4 edits in trunk/WebCore

Fix for hang when incorrectly trying to add before/after content to
a <select>. Disallow generated content in all selects and also turn it
off for <input> buttons.

Reviewed by aroben

rendering/RenderBlock.cpp: (WebCore::RenderBlock::setStyle):
rendering/RenderButton.cpp: (WebCore::RenderButton::canHaveChildren):
rendering/RenderButton.h:

12:59 PM Changeset in webkit [21208] by darin

114 edits
2 adds in trunk

LayoutTests:

Reviewed by Hyatt.

added a test for <rdar://problem/5172596> HTML-parser-created tbody elements are being ignored when processing CSS child rules

fast/css/child-selector-implicit-tbody.html: Added.
fast/css/child-selector-implicit-tbody-expected.txt: Added.

updated test results for <rdar://problem/5172607> XML parser is creating implicit tbody elements; the only change is the tag name that's dumped

fast/table/037-expected.txt:
tables/mozilla/marvin/x_caption_align_bottom-expected.txt:
tables/mozilla/marvin/x_caption_align_top-expected.txt:
tables/mozilla/marvin/x_caption_class-expected.txt:
tables/mozilla/marvin/x_caption_id-expected.txt:
tables/mozilla/marvin/x_caption_style-expected.txt:
tables/mozilla/marvin/x_col_align_center-expected.txt:
tables/mozilla/marvin/x_col_align_char-expected.txt:
tables/mozilla/marvin/x_col_align_justify-expected.txt:
tables/mozilla/marvin/x_col_align_left-expected.txt:
tables/mozilla/marvin/x_col_align_right-expected.txt:
tables/mozilla/marvin/x_col_span-expected.txt:
tables/mozilla/marvin/x_col_valign_baseline-expected.txt:
tables/mozilla/marvin/x_col_valign_bottom-expected.txt:
tables/mozilla/marvin/x_col_valign_middle-expected.txt:
tables/mozilla/marvin/x_col_valign_top-expected.txt:
tables/mozilla/marvin/x_col_width_pct-expected.txt:
tables/mozilla/marvin/x_col_width_px-expected.txt:
tables/mozilla/marvin/x_col_width_rel-expected.txt:
tables/mozilla/marvin/x_colgroup_align_center-expected.txt:
tables/mozilla/marvin/x_colgroup_align_char-expected.txt:
tables/mozilla/marvin/x_colgroup_align_justify-expected.txt:
tables/mozilla/marvin/x_colgroup_align_left-expected.txt:
tables/mozilla/marvin/x_colgroup_align_right-expected.txt:
tables/mozilla/marvin/x_colgroup_span-expected.txt:
tables/mozilla/marvin/x_colgroup_valign_baseline-expected.txt:
tables/mozilla/marvin/x_colgroup_valign_bottom-expected.txt:
tables/mozilla/marvin/x_colgroup_valign_middle-expected.txt:
tables/mozilla/marvin/x_colgroup_valign_top-expected.txt:
tables/mozilla/marvin/x_colgroup_width_rel-expected.txt:
tables/mozilla/marvin/x_table_align_center-expected.txt:
tables/mozilla/marvin/x_table_align_left-expected.txt:
tables/mozilla/marvin/x_table_align_right-expected.txt:
tables/mozilla/marvin/x_table_bgcolor_name-expected.txt:
tables/mozilla/marvin/x_table_bgcolor_rgb-expected.txt:
tables/mozilla/marvin/x_table_cellpadding-expected.txt:
tables/mozilla/marvin/x_table_cellpadding_pct-expected.txt:
tables/mozilla/marvin/x_table_cellspacing-expected.txt:
tables/mozilla/marvin/x_table_cellspacing_pct-expected.txt:
tables/mozilla/marvin/x_table_class-expected.txt:
tables/mozilla/marvin/x_table_id-expected.txt:
tables/mozilla/marvin/x_table_style-expected.txt:
tables/mozilla/marvin/x_table_width_pct-expected.txt:
tables/mozilla/marvin/x_table_width_px-expected.txt:
tables/mozilla/marvin/x_td_align_center-expected.txt:
tables/mozilla/marvin/x_td_align_char-expected.txt:
tables/mozilla/marvin/x_td_align_justify-expected.txt:
tables/mozilla/marvin/x_td_align_left-expected.txt:
tables/mozilla/marvin/x_td_align_right-expected.txt:
tables/mozilla/marvin/x_td_bgcolor_name-expected.txt:
tables/mozilla/marvin/x_td_bgcolor_rgb-expected.txt:
tables/mozilla/marvin/x_td_class-expected.txt:
tables/mozilla/marvin/x_td_colspan-expected.txt:
tables/mozilla/marvin/x_td_height-expected.txt:
tables/mozilla/marvin/x_td_id-expected.txt:
tables/mozilla/marvin/x_td_nowrap-expected.txt:
tables/mozilla/marvin/x_td_rowspan-expected.txt:
tables/mozilla/marvin/x_td_style-expected.txt:
tables/mozilla/marvin/x_td_valign_baseline-expected.txt:
tables/mozilla/marvin/x_td_valign_bottom-expected.txt:
tables/mozilla/marvin/x_td_valign_middle-expected.txt:
tables/mozilla/marvin/x_td_valign_top-expected.txt:
tables/mozilla/marvin/x_td_width-expected.txt:
tables/mozilla/marvin/x_th_align_center-expected.txt:
tables/mozilla/marvin/x_th_align_char-expected.txt:
tables/mozilla/marvin/x_th_align_justify-expected.txt:
tables/mozilla/marvin/x_th_align_left-expected.txt:
tables/mozilla/marvin/x_th_align_right-expected.txt:
tables/mozilla/marvin/x_th_bgcolor_name-expected.txt:
tables/mozilla/marvin/x_th_bgcolor_rgb-expected.txt:
tables/mozilla/marvin/x_th_class-expected.txt:
tables/mozilla/marvin/x_th_colspan-expected.txt:
tables/mozilla/marvin/x_th_height-expected.txt:
tables/mozilla/marvin/x_th_id-expected.txt:
tables/mozilla/marvin/x_th_nowrap-expected.txt:
tables/mozilla/marvin/x_th_rowspan-expected.txt:
tables/mozilla/marvin/x_th_style-expected.txt:
tables/mozilla/marvin/x_th_valign_baseline-expected.txt:
tables/mozilla/marvin/x_th_valign_bottom-expected.txt:
tables/mozilla/marvin/x_th_valign_middle-expected.txt:
tables/mozilla/marvin/x_th_valign_top-expected.txt:
tables/mozilla/marvin/x_th_width-expected.txt:
tables/mozilla/marvin/x_tr_align_center-expected.txt:
tables/mozilla/marvin/x_tr_align_char-expected.txt:
tables/mozilla/marvin/x_tr_align_justify-expected.txt:
tables/mozilla/marvin/x_tr_align_left-expected.txt:
tables/mozilla/marvin/x_tr_align_right-expected.txt:
tables/mozilla/marvin/x_tr_bgcolor_name-expected.txt:
tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.txt:
tables/mozilla/marvin/x_tr_class-expected.txt:
tables/mozilla/marvin/x_tr_id-expected.txt:
tables/mozilla/marvin/x_tr_style-expected.txt:
tables/mozilla/marvin/x_tr_valign_baseline-expected.txt:
tables/mozilla/marvin/x_tr_valign_bottom-expected.txt:
tables/mozilla/marvin/x_tr_valign_middle-expected.txt:
tables/mozilla/marvin/x_tr_valign_top-expected.txt:
tables/mozilla_expected_failures/bugs/bug178855-expected.txt:
tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.txt:
tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.txt:
tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.txt:
tables/mozilla_expected_failures/marvin/x_colgroup_width_px-expected.txt:

WebCore:

Reviewed by Hyatt.

removed the m_implicit bit from Node, freeing up a bit

fixed <rdar://problem/5172607> XML parser is creating implicit tbody elements
fixed <rdar://problem/5172596> HTML-parser-created tbody elements are being ignored when processing CSS child rules

Test: fast/css/child-selector-implicit-tbody.html

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkSelector): Removed code that used to look at implicitNode(), which no longer exists.

css/html4.css: Added a style rule to handle cases where we have a tr inside a table with no intervening table section.

dom/Node.h: Removed the bit.
dom/Node.cpp: (WebCore::Node::Node): Don't initialize the bit. (WebCore::Node::dump): Don't dump the bit.

dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startElementNs): Remove the code that made a table body element. This is handled in the render tree, the DOM tree should not be mangled. (WebCore::XMLTokenizer::endElementNs): Removed code that used to look at implicitNode(), which no longer exists.

html/HTMLElementFactory.cpp: (WebCore::tableSectionConstructor): Removed boolean parameter that was passed to the HTMLTableSectionElement constructor.
html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): Ditto.
html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::createTHead): Ditto. (WebCore::HTMLTableElement::createTFoot): Ditto. (WebCore::HTMLTableElement::insertRow): Changed to return a PassRefPtr, because it's possible the row could be removed from the table by JavaScript code responding to DOM mutation events before the function returns. Just something I noticed by code inspection.

html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::HTMLTableSectionElement): Removed boolean "implicit" parameter to the constructor. (WebCore::HTMLTableSectionElement::insertRow): Changed to return a PassRefPtr for the same reason cited above.

html/HTMLTableElement.h: Changed the return value of insertRow to be a PassRefPtr.
html/HTMLTableSectionElement.h: Ditto.

12:04 PM Changeset in webkit [21207] by sfalken