Context Navigation

← Previous Period
Next Period →

Timeline

May 5, 2007:

10:17 PM Changeset in webkit [21274] by ap

5 edits in trunk/WebCore

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13304
REGRESSION(14784): WebKit doesn't dynamically reflect changes to the highlight color in System Preferences

Implemented a notification observer that invalidates cached system colors.

No automated test possible.

rendering/RenderTheme.cpp: (WebCore::RenderTheme::activeSelectionBackgroundColor): (WebCore::RenderTheme::inactiveSelectionBackgroundColor): (WebCore::RenderTheme::platformColorsDidChange):
rendering/RenderTheme.h:
rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm: (-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]): (-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]): (WebCore::theme): (WebCore::RenderThemeMac::RenderThemeMac): (WebCore::RenderThemeMac::~RenderThemeMac): (WebCore::RenderThemeMac::checkbox): (WebCore::RenderThemeMac::radio): (WebCore::RenderThemeMac::button): (WebCore::RenderThemeMac::popupButton): (WebCore::RenderThemeMac::search): (WebCore::RenderThemeMac::sliderThumbHorizontal): (WebCore::RenderThemeMac::sliderThumbVertical):

4:23 PM Changeset in webkit [21273] by kevino

1 edit in branches/wx-port-alpha/trunk/Bakefiles/presets.bkl

Run *-config scripts when running make, not when generating the makefiles.

3:53 AM Changeset in webkit [21272] by rwlbuis

28 edits in trunk/WebCore

Reviewed by Oliver.

http://bugs.webkit.org/show_bug.cgi?id=13592
parseMappedAttribute inconsistency

Do not use local vars in parseMappedAttribute for attr name and value.

12:10 AM Changeset in webkit [21271] by oliver

2 edits in trunk/WebCore

Reviewed by Hyatt.

Initialise default fill with Color::black rather than parsing
the string "black"

ksvg2/svg/SVGPaint.cpp: (WebCore::SVGPaint::defaultFill):

May 4, 2007:

9:19 PM Changeset in webkit [23344] by sfalken

5 edits in branches/WindowsMerge

2007-05-04 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin.

Fix crash when using "check spelling while typing".

WebCore.vcproj/WebCore.vcproj: Added TextBreakIteratorInternalICUWin.cpp
platform/win/TemporaryLinkStubs.cpp: Removed findSentenceBoundary, findNextSentenceFromIndex.

2007-05-04 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin.

Fix crash when using "check spelling while typing".

WebView.cpp: (WebView::preflightSpellChecker): Set delegate static global for use in spell checker init.

9:08 PM Changeset in webkit [21270] by sfalken

9 edits
2 adds in trunk/WebCore

Reviewed by Oliver.

Use TextBreakIterator for sentence breaking instead of TextBoundaries.

WebCore.xcodeproj/project.pbxproj: Added TextBreakIeratorInternalICUMac.mm
editing/visible_units.cpp: (WebCore::startSentenceBoundary): Call TextBreakIterator instead of TextBoundaries. (WebCore::endSentenceBoundary): Call TextBreakIterator instead of TextBoundaries. (WebCore::previousSentencePositionBoundary): Call TextBreakIterator instead of TextBoundaries. (WebCore::nextSentencePositionBoundary): Call TextBreakIterator instead of TextBoundaries.
platform/TextBoundaries.h: Removed findSentenceBoundary, findNextSentenceFromIndex.
platform/TextBreakIterator.h: Added sentenceBreakIterator.
platform/TextBreakIteratorICU.cpp: (WebCore::setUpIterator): Add locale parameter (needed to maintain functionality that TextBoundaries code had). (WebCore::characterBreakIterator): Pass en_us for locale (same as old code). (WebCore::wordBreakIterator): Pass en_us for locale (same as old code). (WebCore::lineBreakIterator): Pass en_us for locale (same as old code). (WebCore::sentenceBreakIterator): Added.
platform/TextBreakIteratorInternalICU.h: Added.
platform/gdk/TemporaryLinkStubs.cpp: Removed findNextSentenceFromIndex, findSentenceBoundary. (WebCore::currentTextBreakLocaleID): Added stub.
platform/mac/TextBoundaries.mm: Removed currentTextBreakLocaleID, findSentenceBoundary, findNextSentenceFromIndex.
platform/mac/TextBreakIteratorInternalICUMac.mm: Added. (WebCore::currentTextBreakLocaleID): Moved from TextBoundaries.mm
platform/qt/TextBoundaries.cpp: Removed findNextSentenceFromIndex, findSentenceBoundary.

5:17 PM Changeset in webkit [21269] by adele

2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/5116871> REGRESSION: Can't select options in widget's listbox

Don't use user-select to determine whether or not options can be selected in listboxes.
This will match Firefox behavior for -moz-user-select.

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::canSelectAll): (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):

4:50 PM Changeset in webkit [21268] by thatcher

1 edit in tags/JavaScriptCore-418.5/JavaScriptCore/Info.plist

Versioning

4:49 PM Changeset in webkit [21267] by thatcher

1 copy in tags/JavaScriptCore-418.5

New tag.

4:47 PM Changeset in webkit [21266] by thatcher

1 edit in branches/Safari-2-0-branch/JavaScriptCore/kjs/collector.cpp

Build fix.

4:46 PM Changeset in webkit [21265] by thatcher

2 edits in tags/JavaScriptCore-418.3/JavaScriptCore

Reverting commit to the wrong tag.

4:43 PM Changeset in webkit [21264] by thatcher

1 delete in tags/JavaScriptCore-418.4/JavaScriptCore-418.3

Removing bad tag.

4:40 PM Changeset in webkit [21263] by thatcher

1 edit in tags/JavaScriptCore-418.4/JavaScriptCore/kjs/collector.cpp

Build fix.

4:39 PM Changeset in webkit [21262] by thatcher

2 edits in tags/JavaScriptCore-418.3/JavaScriptCore

Versioning

4:39 PM Changeset in webkit [21261] by ggaren

8 edits in trunk

WebCore:

Reviewed by Tim Hatcher.

First step in fixing <rdar://problem/5055182> The back cache has no global cap

Stop giving SnapBack infinite cache-ability. Instead, make SnapBack rely
on the underlying back cache.

WebCore.exp:
history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem):
history/HistoryItem.h:
loader/FrameLoader.cpp: (WebCore::FrameLoader::purgePageCache):

WebKit:

Reviewed by Tim Hatcher.

First step in fixing <rdar://problem/5055182> The back cache has no global cap

Stop giving SnapBack infinite cache-ability. Instead, make SnapBack rely
on the underlying back cache.

I left -setAlwaysAttemptToUsePageCache: as an empty stub because we don't
want to break Safari 2.0, but I removed its header declaration so nobody
else starts using it.

History/WebHistoryItem.mm: (-[WebHistoryItem setAlwaysAttemptToUsePageCache:]):
History/WebHistoryItemPrivate.h:

4:38 PM Changeset in webkit [21260] by thatcher

1 copy in tags/JavaScriptCore-418.4/JavaScriptCore-418.3

New tag.

4:38 PM Changeset in webkit [21259] by thatcher

2 edits in tags/JavaScriptCore-418.3/JavaScriptCore

Merge fix from r16614 (with build fix).

2:15 PM Changeset in webkit [21258] by ggaren

10 edits in trunk

WebCore:

Reviewed by Brady Eidson.

Removed export of clearPageCache(), since it was unused externally. I plan
to remove its use from WebCore eventually, too.

Removed usesPageCache(), since it was unused and it duplicated pageCacheSize().

WebCore.exp:
history/BackForwardList.cpp:
history/BackForwardList.h: Moved statics to the top of the class definition.
loader/FrameLoader.cpp: (WebCore::FrameLoader::canCachePage):

WebKit:

Reviewed by Brady Eidson.

Some cleanup in preparation for fixing <rdar://problem/5055182> The
back/forward cache has no global cap

Unified naming of WebKit/WebCore b/f lists -- instead of the potpourri
of webBackForwardList, backForwardList, list, kitList, coreList, listWrapper,
and webCoreBackForwardList, we use webBackForwardList for WebKit and
backForwardList for WebCore, matching their respective class names.

Removed "private" versions of kit() and core() -- kit() and core() are
canonically used for converting between WebKit API objects and WebCore
API objects. I think it's clearer to have only one way to do this.

Removed COMPUTE_DEFAULT_PAGE_CACHE_SIZE, since it was unused.

Removed _clearPageCache, since it was unused and it duplicated -setPageCacheSize:0.

Removed _usesPageCache, since it was unused and it duplicated -pageCacheSize.

11:19 AM Changeset in webkit [23343] by aliceli1

3 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

changed use of DeprecatedString::fromUTF8 to UTF8Encoding().decode()

platform/win/DragDataWin.cpp: (WebCore::fragmentFromHTML):
platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::documentFragment):

10:38 AM Changeset in webkit [21257] by darin

2 edits in trunk

Added bugs.webkit.org URL.

10:14 AM Changeset in webkit [21256] by darin

5 edits in trunk

JavaScriptCore:

Reviewed by Adele.

fix <rdar://problem/5007921> Number.toExponential doesn't work for negative numbers

kjs/number_object.cpp: (NumberProtoFunc::callAsFunction): Added a call to fabs before calling log10.

LayoutTests:

Reviewed by Adele.

test for <rdar://problem/5007921> Number.toExponential doesn't work for negative numbers

fast/js/kde/resources/Number.js: Added negative number versions of some tests of toFixed, toExponential, toPrecision, etc.
fast/js/kde/Number-expected.txt: Updated, new tests all passing.

10:13 AM Changeset in webkit [21255] by beidson

2 edits in trunk/WebKit

Reviewed by Mark Rowe

Added main thread assertion to WebHTMLView to help make sure 3rd party clients aren't trying
to draw on secondary threads

WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]): Added ASSERT_MAIN_THREAD()

9:42 AM Changeset in webkit [21254] by bdash

7 edits in trunk

2007-05-04 Anders Carlsson <andersca@apple.com>

Reviewed by Antti.

<rdar://problem/5179977> Use the correct URLs when dispatching delegate methods for data loads.

Restore behavior to matching release WebKit by adding a response URL to SubstituteData. If a nil base URL is
passed, set the _request_ URL to "about:blank", but the response URL to a generated "applewebdata" URL.

loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): First, check for the SubstituteData's response URL.

(WebCore::FrameLoader::continueAfterNavigationPolicy):
No need to special case applewebdata URLs here, they're only used in the response.

loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::handleDataLoadNow): If the substitute data has a response URL, use it.

(WebCore::MainResourceLoader::loadNow):
Only load "about:blank" as an empty document if there's no substitute data.

loader/SubstituteData.h: (WebCore::SubstituteData::SubstituteData): (WebCore::SubstituteData::responseURL): Add responseURL member to SubstituteData.

2007-05-04 Anders Carlsson <andersca@apple.com>

Reviewed by Antti.

<rdar://problem/5179977> Use the correct URLs when dispatching delegate methods for data loads.

WebView/WebFrame.mm: (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): If the base URL is nil, set it to "about:blank", and set the response URL to a generated applewebdata URL.

WebView/WebView.mm: (+[WebView _canHandleRequest:]): No need to special-case applewebdata URLs here anymore, they're only used in responses.

5:25 AM Changeset in webkit [21253] by lars

2 edits in trunk/WebKitTools

Reviewed by Zack

Revert on line of the last commit. We still want to keep the RPATH
support in the pro file.

4:41 AM Changeset in webkit [21252] by lars

112 edits
1 add
15 deletes in trunk

Reviewed by Zack

Remove the old bitmap fonts I tried using to get reliable results from
DumpRenderTree on X11. Instead we now use the URW Type1 fonts from
ghostscript. I've added a mirror to simply check them out at
svn://labs.trolltech.com/svn/webkit/testfonts.

Fixed DumpRenderTree to make sure these fonts are the only ones we use
on X11 and added a fonts.conf file to get a well defined fontconfig
configuration.