⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 6, 2007:

8:07 PM Changeset in webkit [21281] by darin
  • 2 edits in trunk/WebCore
  • blind try at fixing the Qt build
  • platform/qt/TextBreakIteratorQt.cpp: (WebCore::sentenceBreakIterator): Added a placeholder.
8:03 PM Changeset in webkit [21280] by darin
  • 5 edits
    2 deletes in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/canvas/drawImage-with-invalid-args.html: Changed to a dumpAsText test. Added logging and a negative-size test.
  • fast/canvas/drawImage-with-invalid-args-expected.txt: Updated.
  • fast/canvas/drawImage-with-invalid-args-expected.checksum: Removed.
  • fast/canvas/drawImage-with-invalid-args-expected.png: Removed.

WebCore:

Reviewed by Hyatt.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): Don't raise an exception if the source or destination rectangle is empty.
7:57 PM Changeset in webkit [21279] by darin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

  • fix <rdar://problem/4585593> REGRESSION: Some 2-byte characters in printed page header are drawn with too-large font and clipped

Doesn't affect text within web pages, so no layout test.

  • platform/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters): Base the substitute font on the FontPlatformData rather than the FontDescription. Before, it was a mix of both. This works properly for fonts where we have no FontDescription and is also more internally consistent.
7:56 PM Changeset in webkit [21278] by darin
  • 12 edits in trunk/WebCore

Reviewed by Hyatt.

  • dom/Node.h: Made first/lastChild be inline functions that call virtual functions. This lets us hide the functions with another inline function in a derived class, yet still override the behavior here in the base class by overriding the virtual functions too.
  • dom/Node.cpp: (WebCore::Node::virtualFirstChild): Renamed virtual functions. There are now non-virtual inline functions that call these virtual functions. (WebCore::Node::virtualLastChild): Ditto.
  • dom/ContainerNode.h: Added non-virtual first/lastChild functions that hide the ones inherited from the Node class; these also replace the fastFirst/LastChild functions, and transparently give callers the faster form if they have a pointer of the right type. But still override the virtual functions named virtualFirst/LastChild, because those can still be called through a Node*. Removed the "fast" from the names of fastSetFirst/LastChild.
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::virtualFirstChild): Renamed virtual functions. There are now also non-virtual inline versions. (WebCore::ContainerNode::virtualLastChild): Ditto.
  • dom/CharacterData.cpp: Removed implementations of data and length functons.
  • dom/CharacterData.h: Made data, setData, length, substringData, appendData, insertData, deleteData, and replaceData all non-virtual, and made data and length both be inline.
  • dom/NamedAttrMap.h: (WebCore::NamedAttrMap::attributeItem): Removed a null check from this function. If the length of the map is known to be greater than 0, then the null check isn't needed. But if the length of the map hasn't been checked at all, then it's unsafe to call this function since it doesn't range check the array index. Thus the null check is never needed. I also looked at all callers.
  • dom/Attr.cpp: (WebCore::Attr::createTextChild):
  • dom/Document.cpp: (WebCore::Document::recalcStyle):
  • dom/Element.cpp: (WebCore::Element::recalcStyle):
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::haveLoadedRequiredResources): Removed "fast" prefix from calls to fastFirst/LastChild and fastSetFirst/LastChlld. It's not needed any more -- you still get fast behavior if the pointer has a type that's ContainerNode or derived from it.
7:36 PM Changeset in webkit [21277] by bdash
  • 3 edits in trunk

2007-05-06 Erik Bunce <​kde@bunce.us>

Reviewed by Mark Rowe.

  • WebKit.pri: Removed unnecessary dependency on MacPorts (/opt/local)

2007-05-06 Erik Bunce <​kde@bunce.us>

Reviewed by Mark Rowe.

  • WebCore.pro: Removed unnecessary dependency on MacPorts (/opt/local)
9:42 AM Changeset in webkit [21276] by ap
  • 4 edits
    4 adds in trunk

2007-05-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

Test: fast/css-generated-content/positioned-background-hit-test-crash.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::enclosingElement): Added. Factored out of hitTestLayer(). (WebCore::RenderLayer::hitTestLayer): Implemented the fix for <rdar://problem/3552346> from r6106 to the self hit test as well, namely: return the enclosing element for generated positioned content.
  • rendering/RenderLayer.h:
9:05 AM Changeset in webkit [21275] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13584
<script> code wrongly assumes requests can't fail

Test: fast/loader/unloadable-script.html

  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::parseMappedAttribute): (WebCore::HTMLScriptElement::insertedIntoDocument): Check the return value of requestScript().

May 5, 2007:

10:17 PM Changeset in webkit [21274] by ap
  • 5 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13304
REGRESSION(14784): WebKit doesn't dynamically reflect changes to the highlight color in System Preferences

Implemented a notification observer that invalidates cached system colors.

No automated test possible.

  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::activeSelectionBackgroundColor): (WebCore::RenderTheme::inactiveSelectionBackgroundColor): (WebCore::RenderTheme::platformColorsDidChange):
  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]): (-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]): (WebCore::theme): (WebCore::RenderThemeMac::RenderThemeMac): (WebCore::RenderThemeMac::~RenderThemeMac): (WebCore::RenderThemeMac::checkbox): (WebCore::RenderThemeMac::radio): (WebCore::RenderThemeMac::button): (WebCore::RenderThemeMac::popupButton): (WebCore::RenderThemeMac::search): (WebCore::RenderThemeMac::sliderThumbHorizontal): (WebCore::RenderThemeMac::sliderThumbVertical):
4:23 PM Changeset in webkit [21273] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/Bakefiles/presets.bkl

Run *-config scripts when running make, not when generating the makefiles.

3:53 AM Changeset in webkit [21272] by rwlbuis
  • 28 edits in trunk/WebCore

Reviewed by Oliver.

​http://bugs.webkit.org/show_bug.cgi?id=13592
parseMappedAttribute inconsistency

Do not use local vars in parseMappedAttribute for attr name and value.

12:10 AM Changeset in webkit [21271] by oliver
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Initialise default fill with Color::black rather than parsing
the string "black"

  • ksvg2/svg/SVGPaint.cpp: (WebCore::SVGPaint::defaultFill):
Note: See TracTimeline for information about the timeline view.