⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 7, 2007:

10:41 PM Changeset in webkit [21295] by oliver
  • 2 edits in trunk/WebCore

2007-05-07 Atul Mehrotra <​atul.mehrotra@celunite.com>

Reviewed by Maciej.

GDK Build fix

  • platform/gdk/TemporaryLinkStubs.cpp:
9:59 PM Changeset in webkit [21294] by oliver
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test the behaviour of canvas methods called with inf/nan parameters

  • fast/canvas/canvas-with-incorrect-args-expected.txt: Added.
  • fast/canvas/canvas-with-incorrect-args.html: Added.

WebCore:

Reviewed by Maciej.

Correcting comparisons to handle NaN in the same manner
as other Canvas methods.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::arcTo): (WebCore::CanvasRenderingContext2D::arc): Correcting arc/arcTo to match the WHAT WG draft. (WebCore::CanvasRenderingContext2D::rect): (WebCore::CanvasRenderingContext2D::clearRect): (WebCore::CanvasRenderingContext2D::fillRect): (WebCore::CanvasRenderingContext2D::strokeRect):
5:57 PM Changeset in webkit [21293] by hyatt
  • 4 edits in trunk/WebCore

Add some comments to the glyph/font code (patch from MarvinD, tweaked by
me to correct a few bits and to make it forward-compatible with the work
going on in 3315.

Reviewed by me

  • ChangeLog:
  • platform/Font.cpp: (WebCore::Font::glyphDataForCharacter):
  • platform/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage):
  • platform/GlyphPageTreeNode.h:
4:55 PM Changeset in webkit [21292] by justing
  • 2 edits in trunk/WebCore

Fix layout test failures.

  • editing/SelectionController.cpp: (WebCore::SelectionController::contains): Use comparePositions instead of Range::comparePoint, because comparePositions can handle positions inside shadow trees.
4:37 PM Changeset in webkit [23347] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-05-07 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin.

Fix typo in prefs code.

  • WebPreferences.cpp: (WebPreferences::preferencesPath): Fix typo in error handling.
4:01 PM Changeset in webkit [23346] by aliceli1
  • 5 edits
    2 adds in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Fixed <rdar://5087119> Paste fidelity isn't as good as it is on the mac
and <rdar://5087118> Plain text copy/paste yields bad line endings on Boomer
and re-organized standalone functions in DragDataWin.cpp and PasteboardWin.cpp
into ClipboardUtilitiesWin.h/cpp.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/ClipboardUtilitiesWin.cpp: Added. (WebCore::cfHDropFormat): (WebCore::getWebLocData): (WebCore::extractURL): (WebCore::texthtmlFormat): (WebCore::createGlobalData): (WebCore::markupToCF_HTML): (WebCore::urlToMarkup): (WebCore::replaceNewlinesWithWindowsStyleNewlines): (WebCore::replaceNBSPWithSpace): (WebCore::urlWFormat): (WebCore::urlFormat): (WebCore::plainTextFormat): (WebCore::plainTextWFormat): (WebCore::filenameWFormat): (WebCore::filenameFormat): (WebCore::htmlFormat): (WebCore::getURL): (WebCore::getPlainText): (WebCore::fragmentFromFilenames): (WebCore::containsFilenames): (WebCore::fragmentFromCF_HTML): (WebCore::fragmentFromHTML): (WebCore::containsHTML):
  • platform/win/ClipboardUtilitiesWin.h: Added.
  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::writeRange):
  • platform/win/DragDataWin.cpp:
  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::documentFragment):
3:15 PM Changeset in webkit [21291] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/4895428> Can't drag selected To Do if it is not showing a due date

  • editing/selection/4895428-1-expected.checksum: Added.
  • editing/selection/4895428-1-expected.png: Added.
  • editing/selection/4895428-1-expected.txt: Added.
  • editing/selection/4895428-1.html: Added.

WebCore:

Reviewed by darin


<rdar://problem/4895428> Can't drag selected To Do if it is not showing a due date


The code in SelectionController::contains returned false
incorrectly if the selection end just after a table
and the position was inside that table.

  • editing/SelectionController.cpp: (WebCore::SelectionController::contains): Compare the position with the ends of the selection and then use Range::comparePoint.
3:09 PM Changeset in webkit [21290] by beidson
  • 2 edits in trunk/WebKit

Actually finish the code move from my last checkin

  • History/WebHistoryItem.mm: (-[WebHistoryItem _transientPropertyForKey:]): (-[WebHistoryItem _setTransientProperty:forKey:]):
2:57 PM Changeset in webkit [21289] by beidson
  • 4 edits in trunk/WebKit

Rubberstamped by Kevin (Sarge)

Make _transientPropertyForKey: and _setTransientProperty:forKey: SPI

  • History/WebHistoryItemInternal.h:
  • History/WebHistoryItemPrivate.h:
1:23 PM Changeset in webkit [23345] by sfalken
  • 1 add in branches/WindowsMerge/WebCore/platform/win/TextBreakIteratorInternalICUWin.cpp

Forgot to check in this file.

10:25 AM Changeset in webkit [21288] by darin
  • 2 deletes in trunk/LayoutTests/fast/dom/HTMLElement

Removed files. Not sure why they didn't get removed before.

9:25 AM Changeset in webkit [21287] by darin
  • 4 edits in trunk

LayoutTests:

  • rolling out setInnerHTML optimization until I can figure out why tests are failing

WebCore:

  • rolling out setInnerHTML optimization until I can figure out why tests are failing
8:34 AM Changeset in webkit [21286] by brmorris
  • 1 edit
    1 delete in S60/trunk/LayoutTests

brmorris, reviewed by nobody

DESC: This is actually a resource file, not a test case.

  • fast/js/new-location.html: Removed.
8:04 AM Changeset in webkit [21285] by lars
  • 912 edits in trunk/LayoutTestResults

Reviewed by Zack.

New baseline for the table tests.
Skip the fast tests for now.

7:45 AM Changeset in webkit [21284] by darin
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/dom/HTMLElement/set-inner-outer-optimization-expected.txt: Added.
  • fast/dom/HTMLElement/set-inner-outer-optimization.html: Added.

WebCore:

Reviewed by Hyatt.

Optimize setInnerHTML, setOuterHTML, and setInnerText so they don't change the DOM at all
if they don't need to.

Test: fast/dom/HTMLElement/set-inner-outer-optimization.html

  • html/HTMLElement.cpp: (WebCore::equal): Added. Helper function that compares two Text nodes or two NamedAttrMap attribute maps. (WebCore::shallowEqual): Added. Helper function that compares two Element nodes or two arbitrary nodes. (WebCore::replaceChildrenWithFragment): Added. Helper function used by setInnerHTML and setInnerText. Optimizes the cases where all the nodes are the same, where both the current and the new content are single text nodes, and where the current content is a single node that can be replaced with replaceChild. (WebCore::replaceChildrenWithText): Added. Helper function used by setInnerText. Optimizes the case where the current content is a single text node or a single node that can be replaced with replaceChild. (WebCore::HTMLElement::setInnerHTML): Changed to call replaceChildrenWithFragment. (WebCore::HTMLElement::setOuterHTML): Added special case to optimize when the new content exactly matches the current node. (WebCore::HTMLElement::setInnerText): Changed to call replaceChildrenWithText in a few cases instead of doing removeChildren/appendChild. Changed code that was using DeprecatedString to instead use String. Changed general case to use a document fragment and replaceChildrenWithFragment.
  • dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent): Fixed bug where we would not dispatch the DOMSubtreeModified event unless someone was registered for the DOMCharacterDataModified event. Caused trouble in the test.
6:56 AM Changeset in webkit [21283] by lars
  • 8 edits
    6 adds in trunk

Change 5 results in css2.1 that were wrong due to a Qt bug.
Add css3 baseline.

Fix the default font in DRT to 9pt Sans Serif.

12:07 AM Changeset in webkit [21282] by lars
  • 486 edits in trunk/LayoutTestResults

New baseline for the css2.1 tests.

May 6, 2007:

8:07 PM Changeset in webkit [21281] by darin
  • 2 edits in trunk/WebCore
  • blind try at fixing the Qt build
  • platform/qt/TextBreakIteratorQt.cpp: (WebCore::sentenceBreakIterator): Added a placeholder.
8:03 PM Changeset in webkit [21280] by darin
  • 5 edits
    2 deletes in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/canvas/drawImage-with-invalid-args.html: Changed to a dumpAsText test. Added logging and a negative-size test.
  • fast/canvas/drawImage-with-invalid-args-expected.txt: Updated.
  • fast/canvas/drawImage-with-invalid-args-expected.checksum: Removed.
  • fast/canvas/drawImage-with-invalid-args-expected.png: Removed.

WebCore:

Reviewed by Hyatt.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): Don't raise an exception if the source or destination rectangle is empty.
7:57 PM Changeset in webkit [21279] by darin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

  • fix <rdar://problem/4585593> REGRESSION: Some 2-byte characters in printed page header are drawn with too-large font and clipped

Doesn't affect text within web pages, so no layout test.

  • platform/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters): Base the substitute font on the FontPlatformData rather than the FontDescription. Before, it was a mix of both. This works properly for fonts where we have no FontDescription and is also more internally consistent.
7:56 PM Changeset in webkit [21278] by darin
  • 12 edits in trunk/WebCore

Reviewed by Hyatt.

  • dom/Node.h: Made first/lastChild be inline functions that call virtual functions. This lets us hide the functions with another inline function in a derived class, yet still override the behavior here in the base class by overriding the virtual functions too.
  • dom/Node.cpp: (WebCore::Node::virtualFirstChild): Renamed virtual functions. There are now non-virtual inline functions that call these virtual functions. (WebCore::Node::virtualLastChild): Ditto.
  • dom/ContainerNode.h: Added non-virtual first/lastChild functions that hide the ones inherited from the Node class; these also replace the fastFirst/LastChild functions, and transparently give callers the faster form if they have a pointer of the right type. But still override the virtual functions named virtualFirst/LastChild, because those can still be called through a Node*. Removed the "fast" from the names of fastSetFirst/LastChild.
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::virtualFirstChild): Renamed virtual functions. There are now also non-virtual inline versions. (WebCore::ContainerNode::virtualLastChild): Ditto.
  • dom/CharacterData.cpp: Removed implementations of data and length functons.
  • dom/CharacterData.h: Made data, setData, length, substringData, appendData, insertData, deleteData, and replaceData all non-virtual, and made data and length both be inline.
  • dom/NamedAttrMap.h: (WebCore::NamedAttrMap::attributeItem): Removed a null check from this function. If the length of the map is known to be greater than 0, then the null check isn't needed. But if the length of the map hasn't been checked at all, then it's unsafe to call this function since it doesn't range check the array index. Thus the null check is never needed. I also looked at all callers.
  • dom/Attr.cpp: (WebCore::Attr::createTextChild):
  • dom/Document.cpp: (WebCore::Document::recalcStyle):
  • dom/Element.cpp: (WebCore::Element::recalcStyle):
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::haveLoadedRequiredResources): Removed "fast" prefix from calls to fastFirst/LastChild and fastSetFirst/LastChlld. It's not needed any more -- you still get fast behavior if the pointer has a type that's ContainerNode or derived from it.
7:36 PM Changeset in webkit [21277] by bdash
  • 3 edits in trunk

2007-05-06 Erik Bunce <​kde@bunce.us>

Reviewed by Mark Rowe.

  • WebKit.pri: Removed unnecessary dependency on MacPorts (/opt/local)

2007-05-06 Erik Bunce <​kde@bunce.us>

Reviewed by Mark Rowe.

  • WebCore.pro: Removed unnecessary dependency on MacPorts (/opt/local)
9:42 AM Changeset in webkit [21276] by ap
  • 4 edits
    4 adds in trunk

2007-05-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

Test: fast/css-generated-content/positioned-background-hit-test-crash.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::enclosingElement): Added. Factored out of hitTestLayer(). (WebCore::RenderLayer::hitTestLayer): Implemented the fix for <rdar://problem/3552346> from r6106 to the self hit test as well, namely: return the enclosing element for generated positioned content.
  • rendering/RenderLayer.h:
9:05 AM Changeset in webkit [21275] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13584
<script> code wrongly assumes requests can't fail

Test: fast/loader/unloadable-script.html

  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::parseMappedAttribute): (WebCore::HTMLScriptElement::insertedIntoDocument): Check the return value of requestScript().
Note: See TracTimeline for information about the timeline view.