Timeline

May 8, 2007:

11:04 PM Changeset in webkit [21326] by bdash

• 2 edits in branches/Safari-522/WebKit

Merge r21322 and 21323.

10:59 PM Changeset in webkit [21325] by bdash

• 3 edits in branches/Safari-522/WebKit

Merge r20668.

10:28 PM Changeset in webkit [21324] by ggaren

• 9 edits
  2 adds in trunk

LayoutTests:

Reviewed by Darin Adler.

Added test to verify that you get back the same JS/ObjC wrapper when
you access the same object twice.

• fast/dom/wrapper-identity-expected.txt: Added.
• fast/dom/wrapper-identity.html: Added.

WebCore:

Reviewed by Darin Adler.

More fix-ups to the WebScriptObject/WebScripting APIs, related to
<rdar://problem/5140447> API for fetching JSGlobalContextRef from WebView
or WebFrame

1. Added -scriptObjectForJSObject: SPI so you can bridge back from JavaScriptCore to WebScriptObject.

2. Fixed WebScriptObject bridging so that you always get the same WebScriptObject for a JSObject (like in the DOM). This makes -scriptObjectForJSObject: a lot more coherent as an API.

• bindings/objc/DOMInternal.mm: Renamed wrapperCache to DOMWrapperCache to distinguish from the JSWrapperCache. Added typedef for readability. (WebCore::getDOMWrapper): (WebCore::addDOMWrapper): (WebCore::removeDOMWrapper):
• bindings/objc/WebScriptObject.mm: Added JSWrapperCache, which works just like the DOMWrapperCache. (WebCore::getJSWrapper): (WebCore::addJSWrapper): (WebCore::removeJSWrapper): (WebCore::createJSWrapper): (+[WebScriptObject scriptObjectForJSObject:]): This is the new API. It attempts to return a specific DOM wrapper object, or, barring that, it returns a generic WebScriptObject. (+[WebScriptObject scriptObjectForJSObject:originRootObject:rootObject:]): Added this method to support our old WebScriptObject security and leak checking model, even though it doesn't work very well. (-[WebScriptObject _setImp:originRootObject:rootObject:]): (-[WebScriptObject dealloc]): (-[WebScriptObject finalize]): (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
• bindings/objc/WebScriptObjectPendingPublic.h:
• bindings/objc/WebScriptObjectPrivate.h:
• page/mac/FrameMac.mm: (WebCore::Frame::windowScriptObject): Changed to use the new API. This fixes a bug where the object sent to -windowScriptObjectAvailable: and returned from -windowScriptObject could not be round-tripped.

WebKitTools:

Reviewed by Darin Adler.

Added support for testing ObjC object identity.

Added ASSERT to verify that you can round-trip the object passed to you
in -didClearWindowObject:forFrame:.

• DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didClearWindowObject:forFrame:]): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController accessStoredWebScriptObject]): (-[LayoutTestController objCIdentityIsEqual::]):

10:15 PM Changeset in webkit [21323] by bdash

• 2 edits in trunk/WebKit

2007-05-09 Mark Rowe <​mrowe@apple.com>

Build fix to keep the buildbot happy.

• Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):

9:09 PM Changeset in webkit [21322] by bdash

• 2 edits in trunk/WebKit

2007-05-08 Bruce Q Hammond <​bruceq@apple.com>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13578
Bug 13578: When QD plugins draw to an offscreen bitmap the origin is not correct

Now we have correct handling of the origin when QD plugins draw to
offscreen bitmaps.
Also the clipping code for this path was doing unnecessary work which
caused incorrect results; it has been removed.

This change should not affect Safari and in general will only affect
plugins (e.g. Flash) drawing to a CGBitmapContext.

• Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):

9:07 PM Changeset in webkit [21321] by bdash

• 2 edits in trunk/WebCore

2007-05-09 Mark Rowe <​mrowe@apple.com>

Build fix.

• editing/Editor.cpp: (WebCore::findFirstGrammarDetailInRange): Use unsigned rather than int. (WebCore::findFirstBadGrammarInRange): Cast to unsigned in assertion. (WebCore::isRangeUngrammatical): Remove unused variables.

8:11 PM Changeset in webkit [21320] by eseidel

• 3 edits
  3 adds in trunk

2007-05-08 Kimmo Kinnunen <Kimmo Kinnunen>

Reviewed by darin. Landed by eseidel.

• ​http://bugs.webkit.org/show_bug.cgi?id=10880 (Do..while loop gains a semicolon each time it is toStringed) Grammar in Ecma-66262, 12.6: "do Statement while ( Expression );" EmptyStatement was created after every do..while(expr) which had semicolon at the end.

• kjs/grammar.y: Require semicolon at the end of do..while

6:45 PM Changeset in webkit [21319] by kevino

• 10 edits in branches/wx-port-alpha/trunk

Get WEBKITOUTPUTDIR working for the wx port and use it to store build files. Also add a way to specify custom args to make, and have the build script point users to the demo and JSCore tests upon completion.

6:14 PM Changeset in webkit [23350] by sfalken

• 2 edits in branches/WindowsMerge/WebCore

2007-05-08 Steve Falkenburg <​sfalken@apple.com>

Rubber-stamped by Geoff.

Moved shared EditorWin code to Editor.cpp in open source.

• platform/win/EditorWin.cpp: Deleted (moved) most of this file.

6:02 PM Changeset in webkit [21318] by sfalken

• 6 edits in trunk

Reviewed by Darin.

Implemented spelling/grammar related WebEditorClient methods.

• WebCoreSupport/WebEditorClient.h:
• WebCoreSupport/WebEditorClient.mm: (WebEditorClient::ignoreWordInSpellDocument): Added. Call through to NSSpellChecker. (WebEditorClient::learnWord): Added. Call through to NSSpellChecker. (WebEditorClient::checkSpellingOfString): Added. Call through to NSSpellChecker. (WebEditorClient::checkGrammarOfString): Added. Call through to NSSpellChecker. (WebEditorClient::updateSpellingUIWithGrammarString): Added. Call through to NSSpellChecker. (WebEditorClient::updateSpellingUIWithMisspelledWord): Added. Call through to NSSpellChecker. (WebEditorClient::showSpellingUI): Added. Call through to NSSpellChecker. (WebEditorClient::spellingUIIsShowing): Added. Call through to NSSpellChecker. (WebEditorClient::getGuessesForWord): Added. Call through to NSSpellChecker.

Reviewed by Darin.

Moved most spelling/grammar logic to C++. Now calls through to
WebKit to actually invoke NSSpellChecker.

• editing/Editor.cpp: (WebCore::Editor::ignoreSpelling): Added (ported from EditorMac). (WebCore::Editor::learnSpelling): Added (ported from EditorMac). (WebCore::findFirstMisspellingInRange): Added (ported from EditorMac). (WebCore::paragraphAlignedRangeForRange): Added (ported from EditorMac). (WebCore::findFirstGrammarDetailInRange): Added (ported from EditorMac). (WebCore::findFirstBadGrammarInRange): Added (ported from EditorMac). (WebCore::Editor::advanceToNextMisspelling): Added (ported from EditorMac). (WebCore::Editor::isSelectionMisspelled): Added (ported from EditorMac). (WebCore::isRangeUngrammatical): Added (ported from EditorMac). (WebCore::Editor::isSelectionUngrammatical): Added (ported from EditorMac). (WebCore::Editor::guessesForUngrammaticalSelection): Added (ported from EditorMac). (WebCore::Editor::guessesForMisspelledSelection): Added (ported from EditorMac). (WebCore::Editor::showSpellingGuessPanel): Added (ported from EditorMac). (WebCore::Editor::spellingPanelIsShowing): Added (ported from EditorMac). (WebCore::Editor::markMisspellingsAfterTypingToPosition): Added (ported from EditorMac). (WebCore::markAllMisspellingsInRange): Added (ported from EditorMac). (WebCore::markAllBadGrammarInRange): Added (ported from EditorMac). (WebCore::markMisspellingsOrBadGrammar): Added (ported from EditorMac). (WebCore::Editor::markMisspellings): Added (ported from EditorMac). (WebCore::Editor::markBadGrammar): Added (ported from EditorMac).
• editing/mac/EditorMac.mm: Removed Objective C version of spelling/grammar calls.

5:44 PM Changeset in webkit [21317] by kevino

• 2 edits in branches/wx-port-alpha/trunk/WebKit/wx

Update code to work with WebKit changes in the last update.

5:42 PM Changeset in webkit [23349] by sfalken

• 6 edits
  1 add in branches/WindowsMerge

2007-05-08 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin, Oliver.

Added UI_STRING versions of localized WebCore strings.

2007-05-08 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin, Oliver.

Removed localized string stubs.

• platform/win/TemporaryLinkStubs.cpp:

4:14 PM Changeset in webkit [21316] by oliver

• 3 edits
  2 adds in trunk

LayoutTests:

Reviewed by darin.

Test for <rdar://problem/5188938> arc method on
Canvas causes hang or crash work around.

• fast/canvas/arc-crash-expected.txt: Added.
• fast/canvas/arc-crash.html: Added.

WebCore:

Reviewed by Darin.

Fix <rdar://problem/5188938> arc method on Canvas causes hang or crash

Workaround bad behaviour of CGPathAddArc when passed inf as start or
end angles.

• platform/graphics/cg/PathCG.cpp: (WebCore::Path::addArc):

3:51 PM Changeset in webkit [21315] by darin

• 2 edits in trunk/WebCore

Reviewed by Hyatt and Hatcher.

• fix auto-activation code path so Tiger and Leopard aren't different

• platform/mac/WebFontCache.mm: (+[WebFontCache fontWithFamily:traits:size:]): Do the auto-activation dance first before doing anything else, and ignore the font that it returns.

3:43 PM Changeset in webkit [21314] by brmorris

• 2 edits in S60/trunk/WebKit

bradley, reviewed by nobody

DESC: fix bustage by wrapping EAknEditorFlagDeliverVirtualKeyEv

• BrowserCore/Formcontrols/src/FControlInputWidget.cpp

2:58 PM Changeset in webkit [21313] by spadma

• 3 edits in S60/trunk/WebKit

2007-05-08 ligman <​joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: recogniser enhancement.
​http://bugs.webkit.org/show_bug.cgi?id=13628

• BrowserRecognizers/inc/BrowserRec.h:
• BrowserRecognizers/src/BrowserRec.cpp: (:CApaDataRecognizerType): (CBrowserRecognizer::PreferredBufSize): (CBrowserRecognizer::SupportedDataTypeL): (CBrowserRecognizer::DoRecognizeL): (CBrowserRecognizer::CheckForOPML): (CBrowserRecognizer::CreateRecognizerL):

1:11 PM Changeset in webkit [21312] by yongjzha

• 3 edits in S60/branches/3.1m/JavaScriptCore

2007-05-08 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by yongjun.
DESC: TSW ID : EWGO-6YVB4L: Web application jams and closed when browsing.

​http://bugs.webkit.org/show_bug.cgi?id=13361

• pcre/pcre-config.h:
• pcre/pcre.c: (compile_branch): (pcre_compile):

12:41 PM Changeset in webkit [23348] by sfalken

• 8 edits in branches/WindowsMerge

2007-05-08 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada.

Update editing delegate

• Interfaces/IWebEditingDelegate.idl:
• WebEditorClient.cpp: (WebEditorClient::updateSpellingUIWithGrammarString):
• WebEditorClient.h:

2007-05-08 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada.

Updated for new editor interface.

• platform/win/EditorWin.cpp: (WebCore::Editor::advanceToNextMisspelling): (WebCore::isRangeUngrammatical):

2007-05-08 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada.

Update to new editing delegate interface.

• DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: (EditingDelegate::updateSpellingUIWithGrammarString):

12:27 PM Changeset in webkit [21311] by sfalken

• 10 edits in trunk

2007-05-08 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada.

Slight modification to last editor method fix.

• WebCoreSupport/WebEditorClient.h: (WebEditorClient::updateSpellingUIWithGrammarString):

2007-05-08 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada.

Slight modification to last editor method fix.

• bridge/EditorClient.h:
• platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::updateSpellingUIWithGrammarString):
• platform/gdk/EditorClientGdk.h:
• platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::updateSpellingUIWithGrammarString):

2007-05-08 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada.

Slight modification to last editor method fix.

• WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::updateSpellingUIWithGrammarString):
• WebCoreSupport/EditorClientQt.h:

11:31 AM Changeset in webkit [21310] by ggaren

• 2 edits in trunk/JavaScriptCore

Build fix -- this time for sure.

APICast.h, being private, ends up in a different folder than JSValueRef.h,
so we can't include one from the other using "". Instead, just forward
declare the relevant data types.

• API/APICast.h:

10:54 AM Changeset in webkit [21309] by ggaren

• 2 edits in trunk/JavaScriptCore

Build fix: export APICast.h for WebCore and WebKit.

• JavaScriptCore.xcodeproj/project.pbxproj:

10:41 AM Changeset in webkit [21308] by ap

• 15 edits
  2 adds in trunk

Reviewed by Hyatt.

​http://bugs.webkit.org/show_bug.cgi?id=13480
window.Attr is undefined

Test: fast/dom/Window/attr-constructor.html

• dom/Attr.idl:
• dom/CDATASection.idl:
• dom/CharacterData.idl:
• dom/Comment.idl:
• dom/DOMImplementation.idl:
• dom/DocumentType.idl:
• dom/Entity.idl:
• dom/EntityReference.idl:
• dom/Notation.idl:
• dom/ProcessingInstruction.idl:
• dom/Text.idl: Added GenerateConstructor.

• page/DOMWindow.idl: Added constructor properties for DOM interfaces.

10:34 AM Changeset in webkit [21307] by ggaren

• 13 edits
  1 add in trunk

WebCore:

Reviewed by Maciej Stachowiak.

Fixed <rdar://problem/5140447> API for fetching JSGlobalContextRef from
WebView or WebFrame

Added support for new -[WebScriptObject JSObject] and -[WebFrame globalContext]
APIs.

Also fixed some more cases of <rdar://problem/4395622> API:
WebScriptObject.h incorrectly reports that -isSelectorExcludedFromWebScript
returns NO by default, and generally cleaned up that documentation.

• WebCore.exp: A lot of the diff here is from sorting.
• WebCore.xcodeproj/project.pbxproj:
• bindings/objc/WebScriptObject.h:
• bindings/objc/WebScriptObject.mm: (-[WebScriptObject JSObject]):
• bindings/objc/WebScriptObjectPendingPublic.h: Added.

WebKit:

Reviewed by Maciej Stachowiak.

Fixed <rdar://problem/5140447> API for fetching JSGlobalContextRef from
WebView or WebFrame

Added -[WebFrame windowObject] and -[WebFrame globalContext], along with
a new frame load delegate method, - (void)webView:(WebView *)webView
didClearWindowObject:(WebScriptObject *)windowObject forFrame:(WebFrame *)frame.
This is all to support briding between the WebScriptObject and JavaScriptCore
APIs.

Also fixed more of <rdar://problem/4395622> API: WebScriptObject.h incorrectly
reports that -isSelectorExcludedFromWebScript returns NO by default, and
generally cleaned up the WebScriptObject headerdoc.

• WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge windowObjectCleared]):
• WebView/WebFrame.mm: (-[WebFrame windowObject]): (-[WebFrame globalContext]):
• WebView/WebFramePrivate.h:
• WebView/WebViewPrivate.h:

WebKitTools:

Reviewed by Maciej Stachowiak.

Added tests for new APIs: -[WebFrame windowObject], -[WebFrame globalContext],
and - (void)webView:(WebView *)webView didClearWindowObject:(WebScriptObject *)windowObject
forFrame:(WebFrame *)frame, in the form of ASSERTs.

• DumpRenderTree/DumpRenderTree.m: (runJavaScriptThread): Fixed quote mismatch that prepare-changelog likes to complain about.

(-[WaitUntilDoneDelegate webView:windowScriptObjectAvailable:]):
(-[WaitUntilDoneDelegate webView:didClearWindowObject:forFrame:]):

• DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

9:40 AM Changeset in webkit [21306] by thatcher

• 4 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/5180384> webView:validateUserInterfaceItem:defaultValidation: does not get called on WebUIDelegates

Call the delegate when the one of our views gets a validateUserInterfaceItem: call.

• WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Validate without the delegate. (-[WebHTMLView validateUserInterfaceItem:]): Call the delegate with the result of validateUserInterfaceItemWithoutDelegate:.
• WebView/WebPDFView.mm: (-[WebPDFView validateUserInterfaceItemWithoutDelegate:]): Validate without the delegate. (-[WebPDFView validateUserInterfaceItem:]): Call the delegate with the result of validateUserInterfaceItemWithoutDelegate:.
• WebView/WebView.mm: (-[WebView _responderValidateUserInterfaceItem:]): Call validateUserInterfaceItemWithoutDelegate: to prevent asking the delegate twice. (-[WebView validateUserInterfaceItemWithoutDelegate:]): Validate without the delegate. (-[WebView validateUserInterfaceItem:]): Call the delegate with the result of validateUserInterfaceItemWithoutDelegate:.

7:47 AM Changeset in webkit [21305] by zbujtas

• 2 edits in S60/branches/3.1m/WebCore

2007-05-07 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: Web Browser crashes when trying to browse to Hertz.com
​http://bugs.webkit.org/show_bug.cgi?id=13616

WARNING: NO TEST CASES ADDED OR CHANGED

• bridge/WebCoreBridge.cpp: (CWebCoreBridge::NodeTypeB):

7:35 AM Changeset in webkit [21304] by spadma

• 2 edits in S60/trunk/WebKit

winship, reviewed by <reviewer>

DESC: KPOY-72NW5X - Memory Testing: Phone resets while running

browser memory testing. Return from foreground event
without processing if in performance mode

​http://bugs.webkit.org/show_bug.cgi?id=13589

• BrowserView/src/WebKitControl.cpp: (CWebKitControl::ForegroundEvent):

7:31 AM Changeset in webkit [21303] by spadma

• 10 edits
  2 adds in S60/trunk/WebKit

yaharon, reviewed by <reviewer>

DESC: S60 3.2 Touch: Scrolling initial implementatoin
​http://bugs.webkit.org/show_bug.cgi?id=13561

• BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::ConstructTextEditorL):
• BrowserView/inc/PointerEventHandler.h:
• BrowserView/inc/ScrollingIndicatorDrawer.h: Added.
• BrowserView/inc/WebKitView.h:
• BrowserView/src/PointerEventHandler.cpp: (ContentScrollCallback): (CPointerEventHandler::~CPointerEventHandler): (CPointerEventHandler::HandlePointerEventL): (CPointerEventHandler::CheckSmartTextEntry): (CPointerEventHandler::GetFrameAt): (CPointerEventHandler::HandleScrollingPointerEventL): (CPointerEventHandler::HandleShouldStartScrollingL): (CPointerEventHandler::HandleDragL): (CPointerEventHandler::HandleContentScroll): (CPointerEventHandler::UpdateCursor):
• BrowserView/src/ScrollingIndicatorDrawer.cpp: Added. (CScrollingIndicatorDrawer::NewL): (CScrollingIndicatorDrawer::CScrollingIndicatorDrawer): (CScrollingIndicatorDrawer::~CScrollingIndicatorDrawer): (CScrollingIndicatorDrawer::ConstructSprite): (CScrollingIndicatorDrawerEdge::CScrollingIndicatorDrawerEdge): (CScrollingIndicatorDrawerEdge::ConstructL): (CScrollingIndicatorDrawerEdge::~CScrollingIndicatorDrawerEdge): (CScrollingIndicatorDrawerEdge::UpdateBitmapPositionL): (CScrollingIndicatorDrawerEdge::CreateBitmapAndContextL): (CScrollingIndicatorDrawerEdge::UpdateMaskL): (CScrollingIndicatorDrawerAccelerated::CScrollingIndicatorDrawerAccelerated): (CScrollingIndicatorDrawerAccelerated::ConstructL): (CScrollingIndicatorDrawerAccelerated::~CScrollingIndicatorDrawerAccelerated): (CScrollingIndicatorDrawerAccelerated::UpdateBitmapPositionL): (CScrollingIndicatorDrawerAccelerated::CheckNeedRefrech): (CScrollingIndicatorDrawerAccelerated::CreateBitmapAndContextL): (CScrollingIndicatorDrawerAccelerated::UpdateMaskL): (CScrollingIndicatorDrawerAccelerated::UpdateMaskExL):
• BrowserView/src/WebKitCursor.cpp: (CWebKitCursor::CursorUpdate):
• BrowserView/src/WebKitView.cpp: (CWebKitView::ContentIsScrolling):
• ChangeLog:
• Plugin/inc/PluginWin.h:
• Plugin/src/PluginWin.cpp: (CPluginWin::PluginConstructedL): (CPluginWin::ForceRedraw): (CPluginWin::HitRegionContains):
• group/BrowserView.mmp:

7:05 AM Changeset in webkit [21302] by lars

• 14 edits in trunk

Reviewed by Zack.

Adjust tests that have console output, now that it's added by
DumpRenderTree.

Dump JavaScript console messages as well. Also requires a slight
change in run-webkit-tests, so we still correctly differentiate
between text only and rendertree tests.

4:40 AM Changeset in webkit [21301] by lars

• 15 edits
  5 adds in trunk/LayoutTestResults

Update the baseline for traversal/ and add a few missing results in
tables/

3:57 AM Applications using WebKit edited by joe@funkeemonk.com

Added listing to FunkeeStory (diff)

3:26 AM Changeset in webkit [21300] by lars

• 3 edits in trunk/WebKitTools

Reviewed by Zack

Specify what the serif, sans-serif and monospace aliases
should map to and explicitly select the Gui style of
DRT to be plastique.

Fixes most of the test failures still seen on the build bot.

1:29 AM Changeset in webkit [21299] by lars

• 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix valgrind reported uninitialized memory read.

1:22 AM Changeset in webkit [21298] by justing

• 3 edits
  12 adds in trunk

LayoutTests:

Reviewed by oliver

<rdar://problem/4895428> Can't drag selected ToDo

This tests to see that the focus of a focusable node
inside an already focused node is delayed until mouse up:

• editing/selection/4895428-2-expected.checksum: Added.
• editing/selection/4895428-2-expected.png: Added.
• editing/selection/4895428-2-expected.txt: Added.
• editing/selection/4895428-2.html: Added.

We delay focus until mouse up, but only if that node is
inside an already focused node:

• editing/selection/4895428-3-expected.checksum: Added.
• editing/selection/4895428-3-expected.png: Added.
• editing/selection/4895428-3-expected.txt: Added.
• editing/selection/4895428-3.html: Added.

This demonstrates the bug:

• editing/selection/4895428-4-expected.checksum: Added.
• editing/selection/4895428-4-expected.png: Added.
• editing/selection/4895428-4-expected.txt: Added.
• editing/selection/4895428-4.html: Added.

WebCore:

Reviewed by oliver

<rdar://problem/4895428> Can't drag selected ToDo

The user tries to drag a selection by mousing down
on the editable part of a ToDo, which is focusable,
since it is an editable node within non-editable
content. But we focus focusable elements on mouse
down, and focusing the editable piece blows away
the selection and prevents the drag. This is how
IE behaves, but content seems generally difficult
to drag in IE, so this doesn't make it any worse.

Since focus doesn't appear to be cancelable, either
with a DOM event or an editing delegate, I fixed this
by delaying the focus of focusable nodes that are
selected and inside an already focused node. The
node will be focused if the user mouses up without
doing any dragging because the mouse up sets a
selection, which calls setFocusNodeIfNeeded.

• page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent):

1:07 AM Changeset in webkit [21297] by bdash

• 4 edits in trunk

Versioning.

1:03 AM Changeset in webkit [21296] by bdash

• 1 copy in tags/Safari-5522.7

New tag.

May 7, 2007:

10:41 PM Changeset in webkit [21295] by oliver

• 2 edits in trunk/WebCore

2007-05-07 Atul Mehrotra <​atul.mehrotra@celunite.com>

Reviewed by Maciej.

GDK Build fix

• platform/gdk/TemporaryLinkStubs.cpp:

9:59 PM Changeset in webkit [21294] by oliver

• 3 edits
  2 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test the behaviour of canvas methods called with inf/nan parameters

• fast/canvas/canvas-with-incorrect-args-expected.txt: Added.
• fast/canvas/canvas-with-incorrect-args.html: Added.

WebCore:

Reviewed by Maciej.

Correcting comparisons to handle NaN in the same manner
as other Canvas methods.

• html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::arcTo): (WebCore::CanvasRenderingContext2D::arc): Correcting arc/arcTo to match the WHAT WG draft. (WebCore::CanvasRenderingContext2D::rect): (WebCore::CanvasRenderingContext2D::clearRect): (WebCore::CanvasRenderingContext2D::fillRect): (WebCore::CanvasRenderingContext2D::strokeRect):

5:57 PM Changeset in webkit [21293] by hyatt

• 4 edits in trunk/WebCore

Add some comments to the glyph/font code (patch from MarvinD, tweaked by
me to correct a few bits and to make it forward-compatible with the work
going on in 3315.

Reviewed by me

• ChangeLog:
• platform/Font.cpp: (WebCore::Font::glyphDataForCharacter):
• platform/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage):
• platform/GlyphPageTreeNode.h:

4:55 PM Changeset in webkit [21292] by justing

• 2 edits in trunk/WebCore

Fix layout test failures.

• editing/SelectionController.cpp: (WebCore::SelectionController::contains): Use comparePositions instead of Range::comparePoint, because comparePositions can handle positions inside shadow trees.

4:37 PM Changeset in webkit [23347] by sfalken

• 2 edits in branches/WindowsMerge/WebKitWin

2007-05-07 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin.

Fix typo in prefs code.

• WebPreferences.cpp: (WebPreferences::preferencesPath): Fix typo in error handling.

4:01 PM Changeset in webkit [23346] by aliceli1

• 5 edits
  2 adds in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Fixed <rdar://5087119> Paste fidelity isn't as good as it is on the mac
and <rdar://5087118> Plain text copy/paste yields bad line endings on Boomer
and re-organized standalone functions in DragDataWin.cpp and PasteboardWin.cpp
into ClipboardUtilitiesWin.h/cpp.

• WebCore.vcproj/WebCore.vcproj:
• platform/win/ClipboardUtilitiesWin.cpp: Added. (WebCore::cfHDropFormat): (WebCore::getWebLocData): (WebCore::extractURL): (WebCore::texthtmlFormat): (WebCore::createGlobalData): (WebCore::markupToCF_HTML): (WebCore::urlToMarkup): (WebCore::replaceNewlinesWithWindowsStyleNewlines): (WebCore::replaceNBSPWithSpace): (WebCore::urlWFormat): (WebCore::urlFormat): (WebCore::plainTextFormat): (WebCore::plainTextWFormat): (WebCore::filenameWFormat): (WebCore::filenameFormat): (WebCore::htmlFormat): (WebCore::getURL): (WebCore::getPlainText): (WebCore::fragmentFromFilenames): (WebCore::containsFilenames): (WebCore::fragmentFromCF_HTML): (WebCore::fragmentFromHTML): (WebCore::containsHTML):
• platform/win/ClipboardUtilitiesWin.h: Added.
• platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::writeRange):
• platform/win/DragDataWin.cpp:
• platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::documentFragment):

3:15 PM Changeset in webkit [21291] by justing

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/4895428> Can't drag selected To Do if it is not showing a due date

• editing/selection/4895428-1-expected.checksum: Added.
• editing/selection/4895428-1-expected.png: Added.
• editing/selection/4895428-1-expected.txt: Added.
• editing/selection/4895428-1.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/4895428> Can't drag selected To Do if it is not showing a due date

The code in SelectionController::contains returned false
incorrectly if the selection end just after a table
and the position was inside that table.

• editing/SelectionController.cpp: (WebCore::SelectionController::contains): Compare the position with the ends of the selection and then use Range::comparePoint.

3:09 PM Changeset in webkit [21290] by beidson

• 2 edits in trunk/WebKit

Actually finish the code move from my last checkin

• History/WebHistoryItem.mm: (-[WebHistoryItem _transientPropertyForKey:]): (-[WebHistoryItem _setTransientProperty:forKey:]):

2:57 PM Changeset in webkit [21289] by beidson

• 4 edits in trunk/WebKit

Rubberstamped by Kevin (Sarge)

Make _transientPropertyForKey: and _setTransientProperty:forKey: SPI

• History/WebHistoryItemInternal.h:
• History/WebHistoryItemPrivate.h:

1:23 PM Changeset in webkit [23345] by sfalken

• 1 add in branches/WindowsMerge/WebCore/platform/win/TextBreakIteratorInternalICUWin.cpp

Forgot to check in this file.

10:25 AM Changeset in webkit [21288] by darin

• 2 deletes in trunk/LayoutTests/fast/dom/HTMLElement

Removed files. Not sure why they didn't get removed before.

9:25 AM Changeset in webkit [21287] by darin

• 4 edits in trunk

LayoutTests:

• rolling out setInnerHTML optimization until I can figure out why tests are failing

WebCore:

• rolling out setInnerHTML optimization until I can figure out why tests are failing

8:34 AM Changeset in webkit [21286] by brmorris

• 1 edit
  1 delete in S60/trunk/LayoutTests

brmorris, reviewed by nobody

DESC: This is actually a resource file, not a test case.

• fast/js/new-location.html: Removed.

8:04 AM Changeset in webkit [21285] by lars

• 912 edits in trunk/LayoutTestResults

Reviewed by Zack.

New baseline for the table tests.
Skip the fast tests for now.

7:45 AM Changeset in webkit [21284] by darin

• 4 edits
  2 adds in trunk

LayoutTests:

Reviewed by Hyatt.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=13602 Amazon product pages keep repainting over and over again

• fast/dom/HTMLElement/set-inner-outer-optimization-expected.txt: Added.
• fast/dom/HTMLElement/set-inner-outer-optimization.html: Added.

WebCore:

Reviewed by Hyatt.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=13602 Amazon product pages keep repainting over and over again

Optimize setInnerHTML, setOuterHTML, and setInnerText so they don't change the DOM at all
if they don't need to.

Test: fast/dom/HTMLElement/set-inner-outer-optimization.html

• html/HTMLElement.cpp: (WebCore::equal): Added. Helper function that compares two Text nodes or two NamedAttrMap attribute maps. (WebCore::shallowEqual): Added. Helper function that compares two Element nodes or two arbitrary nodes. (WebCore::replaceChildrenWithFragment): Added. Helper function used by setInnerHTML and setInnerText. Optimizes the cases where all the nodes are the same, where both the current and the new content are single text nodes, and where the current content is a single node that can be replaced with replaceChild. (WebCore::replaceChildrenWithText): Added. Helper function used by setInnerText. Optimizes the case where the current content is a single text node or a single node that can be replaced with replaceChild. (WebCore::HTMLElement::setInnerHTML): Changed to call replaceChildrenWithFragment. (WebCore::HTMLElement::setOuterHTML): Added special case to optimize when the new content exactly matches the current node. (WebCore::HTMLElement::setInnerText): Changed to call replaceChildrenWithText in a few cases instead of doing removeChildren/appendChild. Changed code that was using DeprecatedString to instead use String. Changed general case to use a document fragment and replaceChildrenWithFragment.

• dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent): Fixed bug where we would not dispatch the DOMSubtreeModified event unless someone was registered for the DOMCharacterDataModified event. Caused trouble in the test.

6:56 AM Changeset in webkit [21283] by lars

• 8 edits
  6 adds in trunk

Change 5 results in css2.1 that were wrong due to a Qt bug.
Add css3 baseline.

Fix the default font in DRT to 9pt Sans Serif.

12:07 AM Changeset in webkit [21282] by lars

• 486 edits in trunk/LayoutTestResults

New baseline for the css2.1 tests.