Context Navigation

Re-applying fix for <rdar://problem/5107538> REGRESSION: Page scroll when selecting characters from inline input candidate window by arrow buttons
http://bugs.webkit.org/show_bug.cgi?id=13263

We don't need to call interpretKeyEvents for cmd-key events as
they events will be interpreted by performKeyEquivalent.

WebView/WebHTMLView.mm: (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): (-[WebHTMLView doCommandBySelector:]):

7:26 PM Changeset in webkit [21345] by bdash

1 copy in tags/WebKit-419.2

New tag.

7:11 PM Changeset in webkit [21344] by oliver

1 edit in trunk/LayoutTests/ChangeLog

Remove random characters from changelog

7:08 PM Changeset in webkit [21343] by oliver

2 edits in trunk/LayoutTests

Reviewed by Adam.

Workaround for rdar://problem/5114296 need to allow for
download occuring, and thus not triggering subframeLoaded()

fast/encoding/char-encoding.html:

3:16 PM Changeset in webkit [21342] by ggaren

4 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Fixed #includes of JSStringRefCF.h and use of CF datatypes. I think I
misunderstood this issue before.

API/JavaScriptCore.h: #include JSStringRefCF.h. Platforms that don't want this behavior can just #include individual headers, instead of the umbrella framework header. But we definitely want Mac OS X clients to get the #include of JSStringRefCF.h "for free."
API/minidom.c: Don't #include JSStringRefCF.h. (Don't need to #include JavaScriptCore.h, either.)
API/testapi.c: Don't #include JSStringRefCF.h. Do use CF datatypes regardless of whether APPLE is defined. Platforms that don't support CF just shouldn't compile this file. (main):

3:04 PM Changeset in webkit [21341] by bdash

1 copy in branches/feature-branch

Branch for feature development.

2:42 PM Changeset in webkit [21340] by bdash

4 edits
1 add in trunk

2007-05-09 Holger Freyther <zecke@selfish.org>

Reviewed by Mark Rowe.

Gdk build fix with SVG enabled. Stub out ImageBufferCairo.

WebCore.pro: Build ImageBufferCairo.cpp
platform/graphics/cairo/ImageBufferCairo.cpp: Added. (WebCore::ImageBuffer::create): (WebCore::ImageBuffer::~ImageBuffer): (WebCore::ImageBuffer::context):

2007-05-09 Holger Freyther <zecke@selfish.org>

Reviewed by Mark Rowe.

GdkLauncher/main.cpp: Always include config.h.

1:37 PM BuildBot edited by bdash@webkit.org

(diff)

1:22 PM Changeset in webkit [21339] by zbujtas

2 edits in S60/trunk/WebCore

yadavall, reviewed by <zbujtas@gmail.com>

DESC: Web Browser crashes when trying to browse to Hertz.com
http://bugs.webkit.org/show_bug.cgi?id=13616

12:59 PM Changeset in webkit [21338] by justing

3 edits
8 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/5017613> Style changes don't effect fully selected ToDo content

Demonstrates the bug:

editing/style/5017613-1-expected.checksum: Added.
editing/style/5017613-1-expected.png: Added.
editing/style/5017613-1-expected.txt: Added.
editing/style/5017613-1.html: Added.

Tests to make sure that a plaintext-only region
will only be styled if it is fully selected:

editing/style/5017613-2-expected.checksum: Added.
editing/style/5017613-2-expected.png: Added.
editing/style/5017613-2-expected.txt: Added.
editing/style/5017613-2.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/5017613> Style changes don't effect fully selected ToDo content

editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle): Use a for loop instead of while(1). Simplify loop termination using Range::pastEndNode. Don't handle the start.node() == end.node() case specially, it's unnecessary. Apply the style change to fully selected plaintext-only regions, not with wrapper spans inside the region, but by changing the element's inline style declaration. Don't descend into nodes whose children we should ignore.

11:45 AM Changeset in webkit [21337] by adele

7 edits in trunk

LayoutTests:

Reviewed by Hyatt.

Updated results for <rdar://problem/5113578> REGRESSION: textfields that set the height but not the font
look different from IE & FF because the font is small

fast/block/float/032-expected.txt:
fast/forms/input-text-word-wrap-expected.checksum:
fast/forms/input-text-word-wrap-expected.png:
fast/forms/input-text-word-wrap-expected.txt:

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/5113578> REGRESSION: textfields that set the height but not the font
look different from IE & FF because the font is small

For plain text fields, don't stretch the inner text box. Center it vertically in the field.

rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::layout):

7:57 AM Changeset in webkit [21336] by darin

1 edit
1 add in trunk/LayoutTests

checked in a file that was accidentally left out of the last check-in

fast/js/cyclic-prototypes-expected.txt: Added.

7:39 AM Changeset in webkit [21335] by spadma

2 edits in S60/branches/3.1m/WebKit

2007-05-08 ligman <joseph.ligman@nokia.com>

Reviewed by sachin.
DESC: Check for NULL cursor prior getting it's position. This can happen when switching between tabbed and cursor navigations.
http://bugs.webkit.org/show_bug.cgi?id=13627

BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleOfferKeyEventL):

7:36 AM Changeset in webkit [21334] by spadma

2 edits in S60/trunk/WebKit

2007-05-08 ligman <joseph.ligman@nokia.com>

Reviewed by sachin.
DESC: Check for NULL cursor prior getting it's position. This can happen when switching between tabbed and cursor navigations.
http://bugs.webkit.org/show_bug.cgi?id=13627

BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleOfferKeyEventL):

7:00 AM Changeset in webkit [21333] by yongjzha

2 edits in S60/branches/3.1m/WebKit

2007-05-07 raalexan <rasvan.alexandrescu@nokia.com>

Reviewed by Yongjun Zhang.
DESC: Browser back goes to the beginning of the previous page
http://bugs.webkit.org/show_bug.cgi?id=13394
TSW ID : TMCN-6YDJDU

BrowserView/src/LoadListeners.cpp: (CPageLoadListener::HeadersL):

3:36 AM Changeset in webkit [21332] by eseidel

3 edits
2 adds in trunk

2007-05-09 Eric Seidel <eric@webkit.org>

Reviewed by mjs.

http://bugs.webkit.org/show_bug.cgi?id=6985
Cyclic proto values cause WebKit to hang

kjs/object.cpp: (KJS::JSObject::put): do a cycle check before setting proto

3:35 AM Changeset in webkit [21331] by bdash

2 edits in trunk/WebCore

2007-05-09 Atul Mehrotra <atul.mehrotra@celunite.com>

Gdk build fix.

platform/gdk/TemporaryLinkStubs.cpp: (Editor::newGeneralClipboard):

1:20 AM Changeset in webkit [21330] by bdash

2 edits in branches/Safari-2-0-branch/WebKit

Merge r21322.

12:52 AM Changeset in webkit [21329] by bdash

3 edits in trunk/WebCore

2007-05-09 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13037 REGRESSION: Copy-on-scroll not reset properly after back/forward navigation

page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Moved initialization of m_slowRepaintObjectCount here. (WebCore::FrameViewPrivate::reset): Do not reset the slow repaint object count here. (WebCore::FrameView::useSlowRepaints): (WebCore::FrameView::addSlowRepaintObject): (WebCore::FrameView::removeSlowRepaintObject): Added an assertion that the object count is positive.
rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): Corrected a mix up between old and new style, which caused the object count to be decremented when it was supposed to be incremented and vice versa.

12:48 AM Changeset in webkit [21328] by bdash

2 edits in trunk/WebCore

2007-05-09 Peter Müller <pm@one.com>

Reviewed by Dave Hyatt.

Changed the hardcoded colors that are used for CSS 2.1 system colors.
Previous colors had numerous conflicts in semantic pairs, which
made text invisible in highlight, info and menu colored areas.
The new hardcoded colors are inspired by Aqua.

Ideally these colors should be fetched through AppKit instead,
though I am not sure if it is possible to make a 1:1 mapping
between CSS2.1 system colors and Mac OS X.

css/cssstyleselector.cpp: (WebCore::):

12:32 AM Changeset in webkit [23351] by sfalken

1 edit in branches/WindowsMerge/WebKitWin/WebCoreLocalizedStrings.cpp

Fix build.

12:16 AM Changeset in webkit [21327] by lars

2 edits in trunk/WebCore

Fix the Qt build.

May 8, 2007:

11:04 PM Changeset in webkit [21326] by bdash

2 edits in branches/Safari-522/WebKit

Merge r21322 and 21323.

10:59 PM Changeset in webkit [21325] by bdash

3 edits in branches/Safari-522/WebKit

Merge r20668.

10:28 PM Changeset in webkit [21324] by ggaren

9 edits
2 adds in trunk

LayoutTests:

Reviewed by Darin Adler.

Added test to verify that you get back the same JS/ObjC wrapper when
you access the same object twice.

fast/dom/wrapper-identity-expected.txt: Added.
fast/dom/wrapper-identity.html: Added.

WebCore:

Reviewed by Darin Adler.

More fix-ups to the WebScriptObject/WebScripting APIs, related to
<rdar://problem/5140447> API for fetching JSGlobalContextRef from WebView
or WebFrame

Added -scriptObjectForJSObject: SPI so you can bridge back from JavaScriptCore to WebScriptObject.

Fixed WebScriptObject bridging so that you always get the same WebScriptObject for a JSObject (like in the DOM). This makes -scriptObjectForJSObject: a lot more coherent as an API.

bindings/objc/DOMInternal.mm: Renamed wrapperCache to DOMWrapperCache to distinguish from the JSWrapperCache. Added typedef for readability. (WebCore::getDOMWrapper): (WebCore::addDOMWrapper): (WebCore::removeDOMWrapper):
bindings/objc/WebScriptObject.mm: Added JSWrapperCache, which works just like the DOMWrapperCache. (WebCore::getJSWrapper): (WebCore::addJSWrapper): (WebCore::removeJSWrapper): (WebCore::createJSWrapper): (+[WebScriptObject scriptObjectForJSObject:]): This is the new API. It attempts to return a specific DOM wrapper object, or, barring that, it returns a generic WebScriptObject. (+[WebScriptObject scriptObjectForJSObject:originRootObject:rootObject:]): Added this method to support our old WebScriptObject security and leak checking model, even though it doesn't work very well. (-[WebScriptObject _setImp:originRootObject:rootObject:]): (-[WebScriptObject dealloc]): (-[WebScriptObject finalize]): (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
bindings/objc/WebScriptObjectPendingPublic.h:
bindings/objc/WebScriptObjectPrivate.h:
page/mac/FrameMac.mm: (WebCore::Frame::windowScriptObject): Changed to use the new API. This fixes a bug where the object sent to -windowScriptObjectAvailable: and returned from -windowScriptObject could not be round-tripped.

WebKitTools:

Reviewed by Darin Adler.

Added support for testing ObjC object identity.

Added ASSERT to verify that you can round-trip the object passed to you
in -didClearWindowObject:forFrame:.

DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didClearWindowObject:forFrame:]): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController accessStoredWebScriptObject]): (-[LayoutTestController objCIdentityIsEqual::]):

10:15 PM Changeset in webkit [21323] by bdash

2 edits in trunk/WebKit

2007-05-09 Mark Rowe <mrowe@apple.com>

Build fix to keep the buildbot happy.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):

9:09 PM Changeset in webkit [21322] by bdash

2 edits in trunk/WebKit

2007-05-08 Bruce Q Hammond <bruceq@apple.com>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13578
Bug 13578: When QD plugins draw to an offscreen bitmap the origin is not correct

Now we have correct handling of the origin when QD plugins draw to
offscreen bitmaps.
Also the clipping code for this path was doing unnecessary work which
caused incorrect results; it has been removed.

This change should not affect Safari and in general will only affect
plugins (e.g. Flash) drawing to a CGBitmapContext.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):

9:07 PM Changeset in webkit [21321] by bdash

2 edits in trunk/WebCore

2007-05-09 Mark Rowe <mrowe@apple.com>

Build fix.

editing/Editor.cpp: (WebCore::findFirstGrammarDetailInRange): Use unsigned rather than int. (WebCore::findFirstBadGrammarInRange): Cast to unsigned in assertion. (WebCore::isRangeUngrammatical): Remove unused variables.

8:11 PM Changeset in webkit [21320] by eseidel

3 edits
3 adds in trunk

2007-05-08 Kimmo Kinnunen <Kimmo Kinnunen>

Reviewed by darin. Landed by eseidel.

http://bugs.webkit.org/show_bug.cgi?id=10880 (Do..while loop gains a semicolon each time it is toStringed) Grammar in Ecma-66262, 12.6: "do Statement while ( Expression );" EmptyStatement was created after every do..while(expr) which had semicolon at the end.

kjs/grammar.y: Require semicolon at the end of do..while

6:45 PM Changeset in webkit [21319] by kevino

10 edits in branches/wx-port-alpha/trunk

Get WEBKITOUTPUTDIR working for the wx port and use it to store build files. Also add a way to specify custom args to make, and have the build script point users to the demo and JSCore tests upon completion.

6:14 PM Changeset in webkit [23350] by sfalken

2 edits in branches/WindowsMerge/WebCore

2007-05-08 Steve Falkenburg <sfalken@apple.com>

Rubber-stamped by Geoff.

Moved shared EditorWin code to Editor.cpp in open source.

platform/win/EditorWin.cpp: Deleted (moved) most of this file.

6:02 PM Changeset in webkit [21318] by sfalken

6 edits in trunk

Reviewed by Darin.

Implemented spelling/grammar related WebEditorClient methods.

WebCoreSupport/WebEditorClient.h:
WebCoreSupport/WebEditorClient.mm: (WebEditorClient::ignoreWordInSpellDocument): Added. Call through to NSSpellChecker. (WebEditorClient::learnWord): Added. Call through to NSSpellChecker. (WebEditorClient::checkSpellingOfString): Added. Call through to NSSpellChecker. (WebEditorClient::checkGrammarOfString): Added. Call through to NSSpellChecker. (WebEditorClient::updateSpellingUIWithGrammarString): Added. Call through to NSSpellChecker. (WebEditorClient::updateSpellingUIWithMisspelledWord): Added. Call through to NSSpellChecker. (WebEditorClient::showSpellingUI): Added. Call through to NSSpellChecker. (WebEditorClient::spellingUIIsShowing): Added. Call through to NSSpellChecker. (WebEditorClient::getGuessesForWord): Added. Call through to NSSpellChecker.

Reviewed by Darin.

Moved most spelling/grammar logic to C++. Now calls through to
WebKit to actually invoke NSSpellChecker.

editing/Editor.cpp: (WebCore::Editor::ignoreSpelling): Added (ported from EditorMac). (WebCore::Editor::learnSpelling): Added (ported from EditorMac). (WebCore::findFirstMisspellingInRange): Added (ported from EditorMac). (WebCore::paragraphAlignedRangeForRange): Added (ported from EditorMac). (WebCore::findFirstGrammarDetailInRange): Added (ported from EditorMac). (WebCore::findFirstBadGrammarInRange): Added (ported from EditorMac). (WebCore::Editor::advanceToNextMisspelling): Added (ported from EditorMac). (WebCore::Editor::isSelectionMisspelled): Added (ported from EditorMac). (WebCore::isRangeUngrammatical): Added (ported from EditorMac). (WebCore::Editor::isSelectionUngrammatical): Added (ported from EditorMac). (WebCore::Editor::guessesForUngrammaticalSelection): Added (ported from EditorMac). (WebCore::Editor::guessesForMisspelledSelection): Added (ported from EditorMac). (WebCore::Editor::showSpellingGuessPanel): Added (ported from EditorMac). (WebCore::Editor::spellingPanelIsShowing): Added (ported from EditorMac). (WebCore::Editor::markMisspellingsAfterTypingToPosition): Added (ported from EditorMac). (WebCore::markAllMisspellingsInRange): Added (ported from EditorMac). (WebCore::markAllBadGrammarInRange): Added (ported from EditorMac). (WebCore::markMisspellingsOrBadGrammar): Added (ported from EditorMac). (WebCore::Editor::markMisspellings): Added (ported from EditorMac). (WebCore::Editor::markBadGrammar): Added (ported from EditorMac).
editing/mac/EditorMac.mm: Removed Objective C version of spelling/grammar calls.

5:44 PM Changeset in webkit [21317] by kevino

2 edits in branches/wx-port-alpha/trunk/WebKit/wx

Update code to work with WebKit changes in the last update.

5:42 PM Changeset in webkit [23349] by sfalken

6 edits
1 add in branches/WindowsMerge

2007-05-08 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin, Oliver.

Added UI_STRING versions of localized WebCore strings.

2007-05-08 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin, Oliver.

Removed localized string stubs.

platform/win/TemporaryLinkStubs.cpp:

4:14 PM Changeset in webkit [21316] by oliver

3 edits
2 adds in trunk

LayoutTests:

Reviewed by darin.

Test for <rdar://problem/5188938> arc method on
Canvas causes hang or crash work around.

fast/canvas/arc-crash-expected.txt: Added.
fast/canvas/arc-crash.html: Added.

WebCore:

Reviewed by Darin.

Fix <rdar://problem/5188938> arc method on Canvas causes hang or crash

Workaround bad behaviour of CGPathAddArc when passed inf as start or
end angles.

platform/graphics/cg/PathCG.cpp: (WebCore::Path::addArc):

3:51 PM Changeset in webkit [21315] by darin

2 edits in trunk/WebCore

Reviewed by Hyatt and Hatcher.

fix auto-activation code path so Tiger and Leopard aren't different

platform/mac/WebFontCache.mm: (+[WebFontCache fontWithFamily:traits:size:]): Do the auto-activation dance first before doing anything else, and ignore the font that it returns.

3:43 PM Changeset in webkit [21314] by brmorris

2 edits in S60/trunk/WebKit

bradley, reviewed by nobody

DESC: fix bustage by wrapping EAknEditorFlagDeliverVirtualKeyEv

BrowserCore/Formcontrols/src/FControlInputWidget.cpp

2:58 PM Changeset in webkit [21313] by spadma

3 edits in S60/trunk/WebKit

2007-05-08 ligman <joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: recogniser enhancement.
http://bugs.webkit.org/show_bug.cgi?id=13628

BrowserRecognizers/inc/BrowserRec.h:
BrowserRecognizers/src/BrowserRec.cpp: (:CApaDataRecognizerType): (CBrowserRecognizer::PreferredBufSize): (CBrowserRecognizer::SupportedDataTypeL): (CBrowserRecognizer::DoRecognizeL): (CBrowserRecognizer::CheckForOPML): (CBrowserRecognizer::CreateRecognizerL):

1:11 PM Changeset in webkit [21312] by yongjzha

3 edits in S60/branches/3.1m/JavaScriptCore

2007-05-08 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by yongjun.
DESC: TSW ID : EWGO-6YVB4L: Web application jams and closed when browsing.

http://bugs.webkit.org/show_bug.cgi?id=13361

pcre/pcre-config.h:
pcre/pcre.c: (compile_branch): (pcre_compile):

12:41 PM Changeset in webkit [23348] by sfalken

8 edits in branches/WindowsMerge

2007-05-08 Steve Falkenburg <sfalken@apple.com>

Reviewed by Ada.

Update editing delegate

Interfaces/IWebEditingDelegate.idl:
WebEditorClient.cpp: (WebEditorClient::updateSpellingUIWithGrammarString):
WebEditorClient.h:

2007-05-08 Steve Falkenburg <sfalken@apple.com>

Reviewed by Ada.

Updated for new editor interface.

platform/win/EditorWin.cpp: (WebCore::Editor::advanceToNextMisspelling): (WebCore::isRangeUngrammatical):

2007-05-08 Steve Falkenburg <sfalken@apple.com>

Reviewed by Ada.

Update to new editing delegate interface.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: (EditingDelegate::updateSpellingUIWithGrammarString):

12:27 PM Changeset in webkit [21311] by sfalken

10 edits in trunk

2007-05-08 Steve Falkenburg <sfalken@apple.com>

Reviewed by Ada.

Slight modification to last editor method fix.

WebCoreSupport/WebEditorClient.h: (WebEditorClient::updateSpellingUIWithGrammarString):

2007-05-08 Steve Falkenburg <sfalken@apple.com>

Reviewed by Ada.

Slight modification to last editor method fix.

bridge/EditorClient.h:
platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::updateSpellingUIWithGrammarString):
platform/gdk/EditorClientGdk.h:
platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::updateSpellingUIWithGrammarString):

2007-05-08 Steve Falkenburg <sfalken@apple.com>

Reviewed by Ada.

Slight modification to last editor method fix.

WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::updateSpellingUIWithGrammarString):
WebCoreSupport/EditorClientQt.h:

11:31 AM Changeset in webkit [21310] by ggaren

2 edits in trunk/JavaScriptCore

Build fix -- this time for sure.

APICast.h, being private, ends up in a different folder than JSValueRef.h,
so we can't include one from the other using "". Instead, just forward
declare the relevant data types.

API/APICast.h:

10:54 AM Changeset in webkit [21309] by ggaren

2 edits in trunk/JavaScriptCore

Build fix: export APICast.h for WebCore and WebKit.

JavaScriptCore.xcodeproj/project.pbxproj:

10:41 AM Changeset in webkit [21308] by ap

15 edits
2 adds in trunk

Reviewed by Hyatt.

http://bugs.webkit.org/show_bug.cgi?id=13480
window.Attr is undefined

Test: fast/dom/Window/attr-constructor.html

dom/Attr.idl:
dom/CDATASection.idl:
dom/CharacterData.idl:
dom/Comment.idl:
dom/DOMImplementation.idl:
dom/DocumentType.idl:
dom/Entity.idl:
dom/EntityReference.idl:
dom/Notation.idl:
dom/ProcessingInstruction.idl:
dom/Text.idl: Added GenerateConstructor.

page/DOMWindow.idl: Added constructor properties for DOM interfaces.

10:34 AM Changeset in webkit [21307] by ggaren

13 edits
1 add in trunk

WebCore:

Reviewed by Maciej Stachowiak.

Fixed <rdar://problem/5140447> API for fetching JSGlobalContextRef from
WebView or WebFrame

Added support for new -[WebScriptObject JSObject] and -[WebFrame globalContext]
APIs.

Also fixed some more cases of <rdar://problem/4395622> API:
WebScriptObject.h incorrectly reports that -isSelectorExcludedFromWebScript
returns NO by default, and generally cleaned up that documentation.

WebCore.exp: A lot of the diff here is from sorting.
WebCore.xcodeproj/project.pbxproj:
bindings/objc/WebScriptObject.h:
bindings/objc/WebScriptObject.mm: (-[WebScriptObject JSObject]):
bindings/objc/WebScriptObjectPendingPublic.h: Added.

WebKit:

Reviewed by Maciej Stachowiak.

Fixed <rdar://problem/5140447> API for fetching JSGlobalContextRef from
WebView or WebFrame

Added -[WebFrame windowObject] and -[WebFrame globalContext], along with
a new frame load delegate method, - (void)webView:(WebView *)webView
didClearWindowObject:(WebScriptObject *)windowObject forFrame:(WebFrame *)frame.
This is all to support briding between the WebScriptObject and JavaScriptCore
APIs.

Also fixed more of <rdar://problem/4395622> API: WebScriptObject.h incorrectly
reports that -isSelectorExcludedFromWebScript returns NO by default, and
generally cleaned up the WebScriptObject headerdoc.

WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge windowObjectCleared]):
WebView/WebFrame.mm: (-[WebFrame windowObject]): (-[WebFrame globalContext]):
WebView/WebFramePrivate.h:
WebView/WebViewPrivate.h:

WebKitTools:

Reviewed by Maciej Stachowiak.

Added tests for new APIs: -[WebFrame windowObject], -[WebFrame globalContext],
and - (void)webView:(WebView *)webView didClearWindowObject:(WebScriptObject *)windowObject
forFrame:(WebFrame *)frame, in the form of ASSERTs.

DumpRenderTree/DumpRenderTree.m: (runJavaScriptThread): Fixed quote mismatch that prepare-changelog likes to complain about.

(-[WaitUntilDoneDelegate webView:windowScriptObjectAvailable:]):
(-[WaitUntilDoneDelegate webView:didClearWindowObject:forFrame:]):

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

9:40 AM Changeset in webkit [21306] by thatcher

4 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/5180384> webView:validateUserInterfaceItem:defaultValidation: does not get called on WebUIDelegates

Call the delegate when the one of our views gets a validateUserInterfaceItem: call.

WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Validate without the delegate. (-[WebHTMLView validateUserInterfaceItem:]): Call the delegate with the result of validateUserInterfaceItemWithoutDelegate:.
WebView/WebPDFView.mm: (-[WebPDFView validateUserInterfaceItemWithoutDelegate:]): Validate without the delegate. (-[WebPDFView validateUserInterfaceItem:]): Call the delegate with the result of validateUserInterfaceItemWithoutDelegate:.
WebView/WebView.mm: (-[WebView _responderValidateUserInterfaceItem:]): Call validateUserInterfaceItemWithoutDelegate: to prevent asking the delegate twice. (-[WebView validateUserInterfaceItemWithoutDelegate:]): Validate without the delegate. (-[WebView validateUserInterfaceItem:]): Call the delegate with the result of validateUserInterfaceItemWithoutDelegate:.

7:47 AM Changeset in webkit [21305] by zbujtas

2 edits in S60/branches/3.1m/WebCore

2007-05-07 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Zalan Bujtas (zbujtas@gmail.com).
DESC: Web Browser crashes when trying to browse to Hertz.com
http://bugs.webkit.org/show_bug.cgi?id=13616

WARNING: NO TEST CASES ADDED OR CHANGED

bridge/WebCoreBridge.cpp: (CWebCoreBridge::NodeTypeB):

7:35 AM Changeset in webkit [21304] by spadma

2 edits in S60/trunk/WebKit

winship, reviewed by <reviewer>

DESC: KPOY-72NW5X - Memory Testing: Phone resets while running

browser memory testing. Return from foreground event
without processing if in performance mode

http://bugs.webkit.org/show_bug.cgi?id=13589

BrowserView/src/WebKitControl.cpp: (CWebKitControl::ForegroundEvent):

7:31 AM Changeset in webkit [21303] by spadma

10 edits
2 adds in S60/trunk/WebKit

yaharon, reviewed by <reviewer>

DESC: S60 3.2 Touch: Scrolling initial implementatoin
http://bugs.webkit.org/show_bug.cgi?id=13561

BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::ConstructTextEditorL):
BrowserView/inc/PointerEventHandler.h:
BrowserView/inc/ScrollingIndicatorDrawer.h: Added.
BrowserView/inc/WebKitView.h:
BrowserView/src/PointerEventHandler.cpp: (ContentScrollCallback): (CPointerEventHandler::~CPointerEventHandler): (CPointerEventHandler::HandlePointerEventL): (CPointerEventHandler::CheckSmartTextEntry): (CPointerEventHandler::GetFrameAt): (CPointerEventHandler::HandleScrollingPointerEventL): (CPointerEventHandler::HandleShouldStartScrollingL): (CPointerEventHandler::HandleDragL): (CPointerEventHandler::HandleContentScroll): (CPointerEventHandler::UpdateCursor):
BrowserView/src/ScrollingIndicatorDrawer.cpp: Added. (CScrollingIndicatorDrawer::NewL): (CScrollingIndicatorDrawer::CScrollingIndicatorDrawer): (CScrollingIndicatorDrawer::~CScrollingIndicatorDrawer): (CScrollingIndicatorDrawer::ConstructSprite): (CScrollingIndicatorDrawerEdge::CScrollingIndicatorDrawerEdge): (CScrollingIndicatorDrawerEdge::ConstructL): (CScrollingIndicatorDrawerEdge::~CScrollingIndicatorDrawerEdge): (CScrollingIndicatorDrawerEdge::UpdateBitmapPositionL): (CScrollingIndicatorDrawerEdge::CreateBitmapAndContextL): (CScrollingIndicatorDrawerEdge::UpdateMaskL): (CScrollingIndicatorDrawerAccelerated::CScrollingIndicatorDrawerAccelerated): (CScrollingIndicatorDrawerAccelerated::ConstructL): (CScrollingIndicatorDrawerAccelerated::~CScrollingIndicatorDrawerAccelerated): (CScrollingIndicatorDrawerAccelerated::UpdateBitmapPositionL): (CScrollingIndicatorDrawerAccelerated::CheckNeedRefrech): (CScrollingIndicatorDrawerAccelerated::CreateBitmapAndContextL): (CScrollingIndicatorDrawerAccelerated::UpdateMaskL): (CScrollingIndicatorDrawerAccelerated::UpdateMaskExL):
BrowserView/src/WebKitCursor.cpp: (CWebKitCursor::CursorUpdate):
BrowserView/src/WebKitView.cpp: (CWebKitView::ContentIsScrolling):
ChangeLog:
Plugin/inc/PluginWin.h:
Plugin/src/PluginWin.cpp: (CPluginWin::PluginConstructedL): (CPluginWin::ForceRedraw): (CPluginWin::HitRegionContains):
group/BrowserView.mmp:

7:05 AM Changeset in webkit [21302] by lars

14 edits in trunk

Reviewed by Zack.

Adjust tests that have console output, now that it's added by
DumpRenderTree.

Dump JavaScript console messages as well. Also requires a slight
change in run-webkit-tests, so we still correctly differentiate
between text only and rendertree tests.

4:40 AM Changeset in webkit [21301] by lars

15 edits
5 adds in trunk/LayoutTestResults

Update the baseline for traversal/ and add a few missing results in
tables/

3:57 AM Applications using WebKit edited by joe@funkeemonk.com

Added listing to FunkeeStory (diff)

3:26 AM Changeset in webkit [21300] by lars

3 edits in trunk/WebKitTools

Reviewed by Zack

Specify what the serif, sans-serif and monospace aliases
should map to and explicitly select the Gui style of
DRT to be plastique.

Fixes most of the test failures still seen on the build bot.

1:29 AM Changeset in webkit [21299] by lars

2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix valgrind reported uninitialized memory read.

1:22 AM Changeset in webkit [21298] by justing

3 edits
12 adds in trunk

LayoutTests:

Reviewed by oliver

<rdar://problem/4895428> Can't drag selected ToDo

This tests to see that the focus of a focusable node
inside an already focused node is delayed until mouse up:

editing/selection/4895428-2-expected.checksum: Added.
editing/selection/4895428-2-expected.png: Added.
editing/selection/4895428-2-expected.txt: Added.
editing/selection/4895428-2.html: Added.

We delay focus until mouse up, but only if that node is
inside an already focused node:

editing/selection/4895428-3-expected.checksum: Added.
editing/selection/4895428-3-expected.png: Added.
editing/selection/4895428-3-expected.txt: Added.
editing/selection/4895428-3.html: Added.

This demonstrates the bug:

editing/selection/4895428-4-expected.checksum: Added.
editing/selection/4895428-4-expected.png: Added.
editing/selection/4895428-4-expected.txt: Added.
editing/selection/4895428-4.html: Added.

WebCore:

Reviewed by oliver

<rdar://problem/4895428> Can't drag selected ToDo

The user tries to drag a selection by mousing down
on the editable part of a ToDo, which is focusable,
since it is an editable node within non-editable
content. But we focus focusable elements on mouse
down, and focusing the editable piece blows away
the selection and prevents the drag. This is how
IE behaves, but content seems generally difficult
to drag in IE, so this doesn't make it any worse.

Since focus doesn't appear to be cancelable, either
with a DOM event or an editing delegate, I fixed this
by delaying the focus of focusable nodes that are
selected and inside an already focused node. The
node will be focused if the user mouses up without
doing any dragging because the mouse up sets a
selection, which calls setFocusNodeIfNeeded.

page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent):

1:07 AM Changeset in webkit [21297] by bdash

4 edits in trunk

Versioning.

1:03 AM Changeset in webkit [21296] by bdash

1 copy in tags/Safari-5522.7

New tag.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed