Context Navigation

This patch allows a file to be dropped on to a file input field. There
are a few changes for data handling and a few to allow the data to be
threaded to the appropriate places.

page/DragController.cpp: (WebCore::asFileInput):

When dropping a file onto a file input we may mouse over either
the element itself, or the contained button element. This method
returns the base element for the file input in either of these
cases.

(WebCore::DragController::tryDocumentDrag):

Don't try to set the drag caret to a file input.

(WebCore::DragController::concludeDrag):

Handle dropping onto a file input element.

(WebCore::DragController::canProcessDrag):

We can now process a file being dragged onto a file input element.

platform/DragData.h:

New accessors

platform/gdk/DragDataGdk.cpp: (WebCore::DragData::containsFiles): (WebCore::DragData::asFilenames):

Link stubs.

platform/mac/DragDataMac.mm: (WebCore::DragData::containsFiles): (WebCore::DragData::asFilenames):

Implement new accessors

(WebCore::DragData::containsCompatibleContent):

Update containsCompatibleContent to allow standalone files.

platform/qt/DragDataQt.cpp: (WebCore::DragData::containsFiles): (WebCore::DragData::asFilenames):

Link stubs

rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::receiveDroppedFile):
rendering/RenderFileUploadControl.h:

For security reasons we don't have an api to allow us to set
a value directly on a file input -- attempts to do so are
blocked. By adding a method to set the target through the
render we bypass such restrictions, and ensure the renderer
is updated correctly.

WebKitTools:

Reviewed by Hyatt.

Add new api to DRT to allow us to test a file being dragged
onto <input type="file">

DumpRenderTree/DumpRenderTree.h:
DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController addFileToPasteboardOnDrag]): (runTest):
DumpRenderTree/UIDelegate.m: (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):

7:31 PM Changeset in webkit [21436] by weinig

4 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

pixel test for http://bugs.webkit.org/show_bug.cgi?id=13695 REGRESSION (r21387): Replaced elements' highlight rects are wrongly positioned

fast/replaced/selection-rect-expected.checksum: Added.
fast/replaced/selection-rect-expected.png: Added.
fast/replaced/selection-rect-expected.txt: Added.
fast/replaced/selection-rect.html: Added.

WebCore:

Reviewed by Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13695 REGRESSION (r21387): Replaced elements' highlight rects are wrongly positioned

Test: fast/replaced/selection-rect.html

Also fixes the same problem with list markers, covered by existing test
fast/lists/markers-in-selection.html.

rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::selectionRect):
rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::selectionRect):

7:12 PM Changeset in webkit [21435] by weinig

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Darin.

repaint test for http://bugs.webkit.org/show_bug.cgi?id=13685 REGRESSION (r21368-r21388): Highlighting text in scrolled textareas behaves oddly

fast/repaint/text-selection-rect-in-overflow-expected.checksum: Added.
fast/repaint/text-selection-rect-in-overflow-expected.png: Added.
fast/repaint/text-selection-rect-in-overflow-expected.txt: Added.
fast/repaint/text-selection-rect-in-overflow.html: Added.

WebCore:

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13685 REGRESSION (r21368-r21388): Highlighting text in scrolled textareas behaves oddly

Test: fast/repaint/text-selection-rect-in-overflow.html

rendering/RenderText.cpp: (WebCore::RenderText::selectionRect):

5:50 PM Changeset in webkit [21434] by kevino

7 edits in branches/wx-port-alpha/trunk

Have Bakefile internally refer to WEBKITOUTPUTDIR and WEBKIT_ROOT using different names to avoid collisions when those are defined as environment variables on the user's machine.

5:39 PM Changeset in webkit [21433] by kevino

1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebView.cpp

Don't schedule a relayout, that triggers the if (root->needsLayout()) code path in FrameView::layout(). See #13455 for why this is a problem. Also, if frameView->needsLayout() is true, make sure to layout before painting rather than bailing out of the paint event.

3:24 PM Changeset in webkit [21432] by mjs

3 edits in trunk/WebKitQt

Reviewed by Rob Buis.

call Frame::init as needed - this prevents crashes but pages don't appear.

Api/qwebframe.cpp: (QWebFramePrivate::init):
WebKitPart/WebKitPart.cpp: (WebKitPart::initView):

2:56 PM Changeset in webkit [21431] by beidson

2 edits in trunk/WebCore

Rubber stamped by Mitz

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::attach): unregister->register - I screwed this one up in last minute renaming before committing :(

2:22 PM Changeset in webkit [21430] by beidson

12 edits in trunk/WebCore

Reviewed by Darin and Geoff

Fix for http://bugs.webkit.org/show_bug.cgi?id=13630
and
<rdar://problem/4873628>

Back/Forward cache should work with pages with login fields.

First change is to relocate the "useSecureKeyboardEntry" flag to the document. This lets
it persist through page cache transitions and it is truly a per-document concept more than
per-frame anyways since its the document that has a password field, not the frame.

Second change is to introduce the concept of an Element getting a "didRestoreFromCache()" callback.
The idea is for elements to register with the document if they need work to be done when the
page comes out of the back/forward cache. Currently the only client of this service is
HTMLInputElements that are input type == PASSWORD. Such an element's implementation for this
method is to call reset()

Finally, after a page is restored from the cache we have the document send the didRestoreFromCache()
callback to its registered Elements. The whole design is to clear the password fields after
restoring the page instead of when caching the page because we want to defer work for the common
case - there shouldn't be extra work here just to navigate away from a page when the common case
is that you'll never go back!

No layout tests possible until http://bugs.webkit.org/show_bug.cgi?id=13672 is resolved

dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::registerForDidRestoreFromCacheCallback): Add an Element to the special page-restoration callback list (WebCore::Document::unregisterForDidRestoreFromCacheCallback): Remove such an element (WebCore::Document::didRestoreFromCache): Called by FrameLoader - dispatch to all the registered elements (WebCore::Document::setUseSecureKeyboardEntryWhenActive): Set the local flag and call updateSecureKeyboardEntryIfActive on the Frame (WebCore::Document::useSecureKeyboardEntryWhenActive): Return the flag

dom/Document.h: (WebCore::Document::unregisterFormElementWithState): Renamed

dom/Element.h: (WebCore::Element::didRestoreFromCache): Added virtual base method

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::~HTMLInputElement): Deregister from the document if inputType == PASSWORD (WebCore::HTMLInputElement::dispatchFocusEvent): Set the flag on the document, not the frame (WebCore::HTMLInputElement::dispatchBlurEvent): Ditto (WebCore::HTMLInputElement::setInputType): If changing to/from PASSWORD, register/deregister in the document accordingly (WebCore::HTMLInputElement::attach): Call registerForDidRestoreFromCacheCallback(this) instead of passwordFieldAdded() (WebCore::HTMLInputElement::didRestoreFromCache): Call reset();
html/HTMLInputElement.h:

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::~HTMLSelectElement): Renamed deregisterFormElementWithState to unregisterFormElementWithState
html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::~HTMLTextAreaElement): Ditto

loader/FrameLoader.cpp: (WebCore::FrameLoader::canCachePage): Remove the check for password fields - they're allowed now! (WebCore::FrameLoader::opened): Tell the document to dispatch to the registered elements (WebCore::FrameLoader::saveDocumentState): Remove the check for password fields. Turns out that when we grab a copy a the form state we're only copying the state of form elements that are registered with the Document - and that set explicitly excludes Password elements

page/Frame.cpp: (WebCore::Frame::setDocument): If the frame is active, set the setUseSecureKeyboardEntry based on the setting contained in the new document (WebCore::Frame::updateSecureKeyboardEntryIfActive): Notification for the secure entry flag changing - if the Frame is active, then update to the new setting from the document (WebCore::Frame::setIsActive): Grab the useSecureKeyboardEntry flag from the document instead of FramePrivate (WebCore::FramePrivate::FramePrivate):
page/Frame.h:
page/FramePrivate.h:

2:18 PM Changeset in webkit [21429] by hyatt

28 edits
4 adds in trunk/LayoutTests/fast/invalid

Update existing invalid tests and add new test for 12740.

2:15 PM Changeset in webkit [21428] by hyatt

2 edits in trunk/WebCore

Fix for bug 12740, bmw.com doesn't work. We were missing a rule that is covered by the HTML5
parsing spec. A <table> encountered while inside stray table content should close up the
table responsible for the stray content and start the new table as a sibling of the first.

Reviewed by mjs

fast/invalid/table-inside-stray-table-content.html

1:35 AM Changeset in webkit [21427] by eseidel

2 edits in trunk/WebCore

2007-05-12 Eric Seidel <eric@webkit.org>

Reviewed by mjs.

Crash starting Safari with JavaScript disabled.
http://bugs.webkit.org/show_bug.cgi?id=13691

Test: none possible.

page/mac/FrameMac.mm: (WebCore::Frame::cleanupPlatformScriptObjects): NULL check d->m_script

May 11, 2007:

11:43 PM Changeset in webkit [21426] by hyatt

4 adds in trunk/LayoutTests/fast/table

Add layout test for colloquy display table baseline issue.

11:40 PM Changeset in webkit [21425] by hyatt

3 edits in trunk/WebCore

Fix for http://bugs.webkit.org/show_bug.cgi?id=13688, Colloquy is broken!

Make sure to adjust the baseline of a percentage height table cell's row if the
cell flexes (and lowers the baseline).

Reviewed by olliej

fast/tables/vertical-align-baseline-readjust.html

(WebCore::RenderTableSection::calcRowHeight):
(WebCore::RenderTableSection::layoutRows):

rendering/RenderTableSection.h: (WebCore::RenderTableSection::getBaseline):

5:26 PM Changeset in webkit [23357] by sfalken

88 edits
3 adds
1 delete in branches/WindowsMerge

2007-05-11 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin, Ada.

WebKit DCOM compatibility.
When a WebKit hosting app calls RunAsLocalServer, the class object for CLSID_WebDebugProgram
is registered to allow creation across processes. This is for future compatibility with
Drosera.

Added new exported function: RunAsLocalServer.
This exposes WebKit inside the running exe as a LocalServer32 (COM server), which
will allow Drosera to connect to it via DCOM.

We use the DCOM Universal Marshaller from oleaut32.dll, which performs marshalling
based on type libraries, so as part of this change, I've done some work on making our
interfaces compatible with this marshaller.

Updated for compatibility w/ COM automation, and fixed up our type library.
Added type library registration/unregistration code.
Marked methods not compatible w/ automation/marshalling as [local].

As a side-effect, with these changes, the .NET tlbimp tool can create a .NET interop
assembly to theoretically allow WebKit to be invoked from .NET apps. I haven't
tried this. It could end up being useful to drive API testing.

To test, I wrote a small app that calls:
::CoCreateInstance(CLSID_IWebDebugProgram, 0, CLSCTX_LOCAL_SERVER, IID_IUnknown, (void)&viewUnknown);
Using this instantiated class, I'm able to iterate the exisitng webviews and retrieve their
source, title, URL, etc.

2007-05-11 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin, Ada.

Updated for COM Automation changes in WebKit.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dumpFrameScrollPosition): Updated for WebKit API changes. (main): Updated for WebKit API changes.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (doMouseUp): Updated for WebKit API changes. (doMouseMove): Updated for WebKit API changes.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: (WaitUntilDoneDelegate::didReceiveIcon): Updated for WebKit API changes. (WaitUntilDoneDelegate::webViewFirstResponder): Updated for WebKit API changes. (WaitUntilDoneDelegate::makeFirstResponder): Updated for WebKit API changes. (WaitUntilDoneDelegate::contextMenuItemsForElement): Updated for WebKit API changes. (WaitUntilDoneDelegate::trackCustomPopupMenu): Updated for WebKit API changes. (WaitUntilDoneDelegate::cleanUpCustomMenuDrawingData): Updated for WebKit API changes. (WaitUntilDoneDelegate::addCustomMenuDrawingData): Updated for WebKit API changes. (WaitUntilDoneDelegate::webViewLostFocus): Updated for WebKit API changes.

5:17 PM Changeset in webkit [21424] by hyatt

2 edits in trunk/WebCore

Make sure focus rings are always using the exterior style, regardless
of what the OS default is.

Reviewed by beth

rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::checkbox): (WebCore::RenderThemeMac::radio): (WebCore::RenderThemeMac::popupButton): (WebCore::RenderThemeMac::search): (WebCore::RenderThemeMac::sliderThumbHorizontal): (WebCore::RenderThemeMac::sliderThumbVertical):

5:07 PM Changeset in webkit [21423] by oliver

3 edits
2 adds in trunk

2007-05-11 Oliver Hunt <oliver@apple.com>

LayoutTests:

Reviewed by Hyatt.

Layout test for x-mac-roman character encoding.

fast/encoding/xmacroman-encoding-test-expected.txt: Added.
fast/encoding/xmacroman-encoding-test.html: Added.

WebCore:

Reviewed by Hyatt.

<rdar://problem/5195473> REGRESSION: "Curly quote" fails to
be displayed correctly even when META tag specifies charset=x-mac-roman

platform/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames): Register the xmacroman encoding

4:05 PM Changeset in webkit [21422] by ggaren

1 edit in trunk/WebCore/ChangeLog

ChangeLog fixup

3:59 PM Changeset in webkit [21421] by mjs

2 edits in trunk/WebCore

Reviewed by Hyatt.

<rdar://problem/5193517> FrameLoader::canCachePage() might walk the entire DOM
http://bugs.webkit.org/show_bug.cgi?id=13662

loader/FrameLoader.cpp: (WebCore::FrameLoader::provisionalLoadStarted): Remove some useless and now harmful code - there's no need to clear in this case.

3:44 PM Changeset in webkit [23356] by adele

2 edits in branches/WindowsMerge/WebKitWin

Build fix.

WebView.cpp: (WebView::selectionImageRect):

3:06 PM Changeset in webkit [21420] by oliver

2 edits in trunk/WebCore

GDK Build fix

ChangeLog:
dom/Document.cpp: (WebCore::Document::importNode):

3:03 PM Changeset in webkit [21419] by mjs

2 edits in trunk/WebCore

Reviewed by Geoff.

fixed <rdar://problem/5197621> closing second window crashed webkit (13660) http://bugs.webkit.org/show_bug.cgi?id=13660

No test case; not testable.

page/mac/FrameMac.mm: (WebCore::Frame::cleanupPlatformScriptObjects): Check if the interpreter is null; if so, we don't want to do work that may lazily create it while the Frame is being destroyed.

2:54 PM Changeset in webkit [21418] by oliver

5 edits
11 adds in trunk

2007-05-11 Oliver Hunt <oliver@apple.com>

LayoutTests:

Reviewed by Brady.

Layout tests for <rdar://problem/5017375> WebKit should disable SVG in Dashboard
Tests attempt to use SVG in a number of ways, both direct and indirect.

http/tests/xmlhttprequest/resources/svgtest.svg: Added. Small test SVG

http/tests/xmlhttprequest/svg-created-by-xhr-disallowed-in-dashboard-expected.txt: Added.
http/tests/xmlhttprequest/svg-created-by-xhr-disallowed-in-dashboard.html: Added. Attempts to use an SVG doc created with XHR as content

svg/custom/embedded-svg-disallowed-in-dashboard-expected.txt: Added.
svg/custom/embedded-svg-disallowed-in-dashboard.xml: Added. Attempts to use SVG by embedding it in an SVG doc.

svg/custom/manually-parsed-embedded-svg-disallowed-in-dashboard-expected.txt: Added.
svg/custom/manually-parsed-embedded-svg-disallowed-in-dashboard.html: Added. Attempts to use SVG by using a DOMParser to manually parse XHMTL with embedded SVG

svg/custom/manually-parsed-svg-disallowed-in-dashboard-expected.txt: Added.
svg/custom/manually-parsed-svg-disallowed-in-dashboard.html: Added. Attempts to use SVG by using a DOMParser to manually create an SVG doc from a string

svg/custom/svg-disallowed-in-dashboard-object-expected.txt: Added.
svg/custom/svg-disallowed-in-dashboard-object.html: Added. Attempts to embed SVG with <embed>, <object>, and <iframe>

WebCore:

Reviewed by Brady.

<rdar://problem/5017375> WebKit should disable SVG in Dashboard

Prevents an SVG document or element from being created when in
dashboard compatibility mode.

Manually parsing, or using XHR to created a document removes our
ability to detect Dashboard compatibility mode, so we also perform
the check when importing nodes from one document into another.

dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Don't create an SVGDocument if we're in dashboard compatibility mode

dom/Document.cpp: (WebCore::Document::importNode): Don't import SVG nodes if we're in dashboard compatibility mode

ksvg2/scripts/make_names.pl: Don't create SVG elements for documents that are in dashboard compatibility mode

1:44 PM Changeset in webkit [21417] by bdash

2 edits in trunk/LayoutTests

2007-05-11 Mark Rowe <mrowe@apple.com>

Rubber-stamped by Oliver.

fast/encoding/char-encoding.html: Change from a 5 millisecond timeout to a 500 millisecond timeout to work around occasional timing-related test failures.

1:29 PM Changeset in webkit [21416] by bdash

2 edits in trunk/WebKitTools

2007-05-11 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Maciej.

Bug 13656: [gdk] Resize the drawing area of the GdkLauncher
http://bugs.webkit.org/show_bug.cgi?id=13656

GdkLauncher/main.cpp: Handle resizing the drawing area (frameResizeCallback): (main):

1:27 PM Changeset in webkit [21415] by bdash

3 edits in trunk/WebCore

2007-05-11 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Maciej.

Bug 13676: [cairo/gdk] Provide implementation for ImageBufferCairo
http://bugs.webkit.org/show_bug.cgi?id=13676

There are no test cases that explicitly cover platform/graphics at present.

platform/graphics/ImageBuffer.h: Add cairo bits
platform/graphics/cairo/ImageBufferCairo.cpp: Untested implementation of the ImagerBuffer using the image_surface (WebCore::ImageBuffer::create): Create a reasonable sized surface (WebCore::ImageBuffer::ImageBuffer): Use a cairo_surface and create a GraphicsContext. GraphicsContext takes the cairo_t ownership (WebCore::ImageBuffer::~ImageBuffer): Unref the surface (WebCore::ImageBuffer::context): simply return the GraphicsContext, it should be possible to directly draw on it.

1:12 PM Changeset in webkit [21414] by bdash

2 edits in trunk/WebCore

2007-05-11 Mitz Pettel <mitz@webkit.org>

Release build fix.

platform/mac/ShapeArabic.c: (shapeArabic):

12:43 PM Changeset in webkit [21413] by ggaren

7 edits in trunk

LayoutTests:

Reviewed by Darin Adler.

Updated test a little bit now that +[WebScriptObject scriptObjectForJSObject:frame:]
is gone.

fast/dom/wrapper-round-tripping.html:

WebCore:

Reviewed by Darin Adler.

Removed +[WebScriptObject scriptObjectForJSObject:frame:] because the
WebScriptObject API has some serious limitations that make it not ready
to be used everywhere the C API is used. Hopefully we can add a good
ObjC API in the future that doesn't suffer from this problem.

Preliminary notes about these limitations are in <rdar://problem/4876466>.

bindings/objc/WebScriptObject.mm:
bindings/objc/WebScriptObjectPendingPublic.h:

WebKitTools:

Reviewed by Darin Adler.

Updated test now that +[WebScriptObject scriptObjectForJSObject:frame:]
is gone.

DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didClearWindowObject:forFrame:]): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController testWrapperRoundTripping:]):

12:04 PM Changeset in webkit [21412] by brmorris

7 edits in S60/trunk

joe, reviewed by brad

DESC: new stub for CancelResetEntryPositionL

group/Bwinscw/HistoryProvider_sdkU.def:
inc/HistoryController.h:
src/HistoryController.cpp: (CHistoryController::CancelResetEntryPositionL):

11:26 AM Changeset in webkit [21411] by beidson

1 edit in trunk/WebCore/platform/mac/ShapeArabic.c

Build fix for case-sensitve file systems (which you should all be using!!!)

9:49 AM Changeset in webkit [21410] by bdash

6 edits
3 adds in trunk

2007-05-11 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13635 REGRESSION: Cannot log in to webmail.co.za account

Test: fast/dom/HTMLOptionElement/option-text.html

Despite the specification that the 'text' attribute of HTMLOptionElement
is "the text contained within the option element", other browsers return
the text as displayed in the list box or popup, which is without leading,
trailing and collapsible whitespace.

html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::text): Moved the code to trim and collapse whitespace and replace backslashes with the currency symbol into this function. (WebCore::HTMLOptionElement::optionText): Left only the code that adds the leading spaces for grouped options. Removed code that, in quirks mode, displayed the label if the option element contained no text. That behavior did not match WinIE and the description of the expected behavior in fast/forms/HTMLOptionElement_label06.html.

2007-05-11 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

test and updated results for http://bugs.webkit.org/show_bug.cgi?id=13635 REGRESSION: Cannot log in to webmail.co.za account

fast/dom/HTMLOptionElement/option-text-expected.txt: Added.
fast/dom/HTMLOptionElement/option-text.html: Added.
fast/forms/HTMLOptionElement_label06-expected.checksum:
fast/forms/HTMLOptionElement_label06-expected.png:
fast/forms/HTMLOptionElement_label06-expected.txt:

9:45 AM Changeset in webkit [21409] by bdash

3 edits
3 adds in trunk

2007-05-11 Kimmo Kinnunen <Kimmo Kinnunen>

Reviewed by Darin.

Fix for bug http://bugs.webkit.org/show_bug.cgi?id=13620 Bogus decompilation of "for (var j = 1 in [])"
ForInNode toString()'ed to syntax error if there was var decl and initializer
ForNode toStringed()'ed lost 'var ' if it was present

kjs/nodes2string.cpp: (VarDeclListNode::streamTo): Print "var " here (VarStatementNode::streamTo): Don't print "var " here (ForNode::streamTo): Remove TODO comment, VarDeclListNode will stream the "var " (ForInNode::streamTo): ForIn initializer is printed by VarDeclNode

2007-05-11 Kimmo Kinnunen <Kimmo Kinnunen>

Reviewed by Darin.

Tests for bug http://bugs.webkit.org/show_bug.cgi?id=13620 Bogus decompilation of "for (var j = 1 in [])"

Testcase covers toString()ing functions with
for-statements of form for (var j = 1 in []) and for (var j=0;j<10;j++)

fast/js/resources/toString-for-var-decl.js: Added.
fast/js/toString-for-var-decl-expected.txt: Added.
fast/js/toString-for-var-decl.html: Added.

9:25 AM Changeset in webkit [21408] by bdash

3 edits
2 adds in trunk/WebCore

2007-05-11 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13572 Arabic characters are not correctly joined when using Arial

No tests added because standard fonts do not use the character-based shaping
code path.

Added shapeArabic(), a private version of u_shapeArabic() from ICU,
patched to shape Arabic characters used in Persian, Urdu, Sindhi, etc.
(whose contextual forms belong to the Arabic Presentation Forms-A block).

WebCore.xcodeproj/project.pbxproj: Added ShapeArabic.{c,h}.
platform/mac/FontMac.mm: (WebCore::shapeArabic): Changed to call shapeArabic() instead of u_shapeArabic().
platform/mac/ShapeArabic.c: Added. Based on ushape.c from ICU, with additional shaping data and logic for Arabic Presentation Forms-A. Removed many options that are not used in WebKit and code that malloc()ed a temporary buffer and reversed the string. (changeLamAlef): (specialChar): (getLink): (isTashkeelChar): (shapeUnicode): (shapeArabic):
platform/mac/ShapeArabic.h: Added.

9:17 AM Changeset in webkit [21407] by bdash

1 edit
3 adds in trunk/LayoutTests

2007-05-11 Kimmo Kinnunen <Kimmo Kinnunen>

Reviewed by Darin.

Tests for http://bugs.webkit.org/show_bug.cgi?id=10878
Bug 10878: Incorrect decompilation for "4..x"

fast/js/resources/toString-number-dot-expr.js: Added.
fast/js/toString-number-dot-expr-expected.txt: Added.
fast/js/toString-number-dot-expr.html: Added.

9:15 AM Changeset in webkit [21406] by bdash

2 edits in trunk/JavaScriptCore

2007-05-11 Kimmo Kinnunen <Kimmo Kinnunen>

Reviewed by Darin.

Fixes http://bugs.webkit.org/show_bug.cgi?id=10878 (Incorrect decompilation for "4..x")
Group numbers in dotted expressions in toString() output, so we avoid the 4.x constructs when the original input is 4..x. 4..x means the same as 4. .x or (4).x or Number(4).x

kjs/nodes2string.cpp: (KJS::SourceStream::): Add boolean flag to indicate that if next item is a number, it should be grouped. Add new formatting enum which turns on the boolean flag. (KJS::SourceStream::SourceStream): Added. Initialize the flag. (SourceStream::operator<<): Added. New overloaded operator with double value as parameter. (NumberNode::streamTo): Use the double operator (ArrayNode::streamTo): (DotAccessorNode::streamTo): (FunctionCallDotNode::streamTo): (FunctionCallParenDotNode::streamTo): (PostfixDotNode::streamTo): (DeleteDotNode::streamTo): (PrefixDotNode::streamTo): (AssignDotNode::streamTo): Use the new formatting enum to turn on the grouping flag.

2007-05-11 Kimmo Kinnunen <Kimmo Kinnunen>

Reviewed by Darin.

Tests for http://bugs.webkit.org/show_bug.cgi?id=10878
Bug 10878: Incorrect decompilation for "4..x"

fast/js/resources/toString-number-dot-expr.js: Added.
fast/js/toString-number-dot-expr-expected.txt: Added.
fast/js/toString-number-dot-expr.html: Added.

8:56 AM Changeset in webkit [23355] by darin

2 edits in branches/WindowsMerge/WebCore

WebCore.vcproj/WebCore.vcproj: Added new RenderWordBreak.cpp/h files.

8:47 AM Changeset in webkit [21405] by darin

12 edits
16 adds in trunk

LayoutTests:

Reviewed by Mitz.

test for http://bugs.webkit.org/show_bug.cgi?id=7452 <rdar://problem/3211749> line breaks ignored after <wbr> in <pre> block (affects livejournal.com)

fast/text/wbr-pre-expected.checksum: Added.
fast/text/wbr-pre-expected.png: Added.
fast/text/wbr-pre-expected.txt: Added.
fast/text/wbr-pre.html: Added.

test for http://bugs.webkit.org/show_bug.cgi?id=10657 <rdar://problem/4274588> <wbr> tags are ignored

fast/text/wbr-expected.checksum: Added.
fast/text/wbr-expected.png: Added.
fast/text/wbr-expected.txt: Added.
fast/text/wbr.html: Added.

test for http://bugs.webkit.org/show_bug.cgi?id=12689 <wbr> :before/:after content causes line break

fast/css-generated-content/wbr-with-before-content-expected.checksum: Added.
fast/css-generated-content/wbr-with-before-content-expected.png: Added.
fast/css-generated-content/wbr-with-before-content-expected.txt: Added.
fast/css-generated-content/wbr-with-before-content.html: Added.

test for <rdar://problem/5127366> DOM tree isn't correct when parsing with <wbr>

fast/invalid/021-expected.txt: Updated result.
fast/parser/parse-wbr-expected.txt: Added.
fast/parser/parse-wbr.html: Added.

WebCore:

Reviewed by Mitz.

fix http://bugs.webkit.org/show_bug.cgi?id=7452 <rdar://problem/3211749> line breaks ignored after <wbr> in <pre> block (affects livejournal.com)

fix http://bugs.webkit.org/show_bug.cgi?id=10657 <rdar://problem/4274588> <wbr> tags are ignored

fix http://bugs.webkit.org/show_bug.cgi?id=12689 <wbr> :before/:after content causes line break

fix <rdar://problem/5127366> DOM tree isn't correct when parsing with <wbr>

Test: fast/text/wbr-pre.html
Test: fast/text/wbr.html
Test: fast/css-generated-content/wbr-with-before-content.html
Test: fast/parser/parse-wbr.html

html/HTMLElement.h:
html/HTMLElement.cpp: (WebCore::HTMLElement::endTagRequirement): Use the same end tag requirement for a <wbr> element as for a <br> element, TagStatusForbidden. (WebCore::HTMLElement::tagPriority): Use the same priority for a <wbr> element as for a <br> element, 0. (WebCore::HTMLElement::createRenderer): Added. Create a RenderWordBreak to trigger the new rendering code paths.

rendering/RenderFlow.h: Add a virtual isWordBreak so we can detect RenderWordBreak.

rendering/RenderWordBreak.h: Added.
rendering/RenderWordBreak.cpp: Added.

WebCore.pro: Added new files.
WebCore.xcodeproj/project.pbxproj: Added new files.
WebCoreSources.bkl: Added new files.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlinePrefWidths): Reset the line when we hit a <wbr>.
rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Add a line break when we hit a <wbr>.

dom/Node.cpp: (Node::createRendererIfNeeded): Fix a null check for the case where createRenderer returns 0 even though rendererIsNeeded returned true. I can't reproduce it on demand, but while running layout tests I hit this once. Since there was already a null check here, I rearranged it so it guards all the code that uses the renderer. Later we might want to figure out under exactly what circumstances rendererIsNeeded will return true but createRenderer return 0 and consider eliminating them.

8:09 AM Changeset in webkit [21404] by zbujtas

6 edits in S60/trunk

2007-05-11 bujtas <zbujtas@gmail.com>

Reviewed by Sriram.
DESC: disabled widgets should not get activated. add dimmed checkbox and radiobutton.
http://bugs.webkit.org/show_bug.cgi?id=13678

WARNING: NO TEST CASES ADDED OR CHANGED

bridge/WebCoreBridge.cpp: (CWebCoreBridge::NavigableNodeUnderCursor): (CWebCoreBridge::NodeTypeB):
kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::activateNodeAtPoint):

8:02 AM Changeset in webkit [21403] by zbujtas

6 edits in S60/branches/3.1m

2007-05-11 bujtas <zbujtas@gmail.com>

Reviewed by Sriram.
DESC: disabled widgets should not get activated. add dimmed checkbox and radiobutton.
http://bugs.webkit.org/show_bug.cgi?id=13678

WARNING: NO TEST CASES ADDED OR CHANGED

bridge/WebCoreBridge.cpp: (CWebCoreBridge::NavigableNodeUnderCursor): (CWebCoreBridge::NodeTypeB):
kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::activateNodeAtPoint):

7:37 AM Changeset in webkit [21402] by yongjzha

2 edits in S60/trunk/WebKit

raalexan, <rasvan.alexandrescu@nokia.com>

Reviewed by Yongjun Zhang.
DESC: Browser back goes to the beginning of the previous page
http://bugs.webkit.org/show_bug.cgi?id=13394
TSW ID : TMCN-6YDJDU

BrowserView/src/LoadListeners.cpp: (CPageLoadListener::HeadersL):

7:11 AM Changeset in webkit [21401] by yongjzha

3 edits in S60/trunk/WebKit

2007-05-09 vbradley <vincent.bradley@nokia.com>

Reviewed by Yongjun.
DESC: EAMO-6YSHHQ - Fonts overlap in browser
http://bugs.webkit.org/show_bug.cgi?id=13647

BrowserCore/Renderers/inc/TextRendererFactory.h: (CTextRendererFactory::Apac):
BrowserCore/Renderers/src/TextRenderer.cpp: (CTextRenderer::LineSpacing):

7:08 AM Changeset in webkit [21400] by yongjzha

3 edits in S60/branches/3.1m/WebKit

2007-05-09 vbradley <vincent.bradley@nokia.com>

Reviewed by Yongjun.
DESC: EAMO-6YSHHQ - Fonts overlap in browser
http://bugs.webkit.org/show_bug.cgi?id=13647

BrowserCore/Renderers/inc/TextRendererFactory.h: (CTextRendererFactory::Apac):
BrowserCore/Renderers/src/TextRenderer.cpp: (CTextRenderer::LineSpacing):

3:04 AM Changeset in webkit [21399] by bdash

3 edits
3 deletes in trunk

Roll out r21393 due to the JavaScriptCore test failure it introduced.

2:41 AM Changeset in webkit [21398] by hyatt

8 edits in trunk/LayoutTests/fast/inline

Tweak continuation tests to make sure the no content after case is covered.

2:36 AM Changeset in webkit [21397] by hyatt

6 edits in trunk/WebCore

Fix for bug 13675, focus rings don't repaint properly on editable
continuations.

Reviewed by olliej

(WebCore::InlineFlowBox::paint):

rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject): (WebCore::continuationOutlineTable): (WebCore::RenderBlock::addContinuationWithOutline): (WebCore::RenderBlock::paintContinuationOutlines):
rendering/RenderBlock.h:
rendering/RenderBox.cpp: (WebCore::RenderBox::absoluteClippedOverflowRect):
rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded): (WebCore::RenderObject::absoluteOutlineBox):

2:31 AM Changeset in webkit [21396] by hyatt