⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 14, 2007:

11:15 PM Changeset in webkit [21476] by justing
  • 5 edits in trunk

LayoutTests:

Reviewed by ggaren


Updated these expected results. We now clear the
selection inside a focused node *after* firing the
mousedown event handler, which matches FF:

  • fast/forms/focus-selection-input-expected.txt:
  • fast/forms/focus-selection-textarea-expected.txt:

WebCore:

Reviewed by ggaren


<​http://bugs.webkit.org/show_bug.cgi?id=13716>
REGRESSION: Three new layout test failures


Two failures are correct. Updated their expected results.


In fast/events/frame-tab-focus.html, as we advance
through focusable nodes, we descend into a subframe
to focus a node and then ascend out of it into the
main frame to focus the next. When we focus the main
frame, the node in that frame that was previously
focused and contains an inactive selection is focused
momentarily because setCaretVisible tries to focus the
node containing the caret.

  • page/Frame.cpp: (WebCore::Frame::setCaretVisible): Don't focus the node containing the caret. FocusController will focus the previously focused node (which will contain the caret) if necessary when the frame gains focus.
10:59 PM Changeset in webkit [21475] by justing
  • 17 edits in trunk/LayoutTests

Reviewed by ggaren

Spelling markers fixed:

  • editing/deleting/delete-to-select-table-expected.checksum:
  • editing/deleting/delete-to-select-table-expected.png:
  • editing/selection/end-of-document-expected.checksum:
  • editing/selection/end-of-document-expected.png:
  • editing/inserting/insert-paragraph-02-expected.checksum:
  • editing/inserting/insert-paragraph-02-expected.png:


Focus halo now painted:

  • editing/execCommand/format-block-with-braces-expected.checksum:
  • editing/execCommand/format-block-with-braces-expected.png:

Needed FIXMEs removed after fixing 4714993:

  • editing/pasteboard/merge-end-1-expected.checksum:
  • editing/pasteboard/merge-end-1-expected.png:
  • editing/pasteboard/merge-end-1-expected.txt:
  • editing/pasteboard/merge-end-1.html:
  • editing/pasteboard/merge-end-2-expected.checksum:
  • editing/pasteboard/merge-end-2-expected.png:
  • editing/pasteboard/merge-end-2-expected.txt:
  • editing/pasteboard/merge-end-2.html:
10:53 PM Changeset in webkit [21474] by mjs
  • 3 edits
    5 adds in trunk

LayoutTests:

Reviewed by Brady.

  • Test case for <rdar://problem/5203036> REGRESSION: Assertion failure in WebCore::FrameLoader::restoreScrollPositionAndViewState() going back from fark.com Photoshop contest (13684)
  • http/tests/incremental/slow-utf8-html.pl:
  • http/tests/navigation/back-to-slow-frame.html: Added.
  • http/tests/navigation/back-to-slow-frame-expected.txt: Added.
  • http/tests/navigation/resources/back-to-slow-frame-2.html: Added.
  • http/tests/navigation/resources/back-to-slow-frame-3.html: Added.
  • http/tests/navigation/resources/slow-resource-1-sec.pl: Added.

WebCore:

Reviewed by Brady.

  • fixed <rdar://problem/5203036> REGRESSION: Assertion failure in WebCore::FrameLoader::restoreScrollPositionAndViewState() going back from fark.com Photoshop contest (13684)

Test: http/tests/navigation/back-to-slow-frame.html


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::restoreScrollPositionAndViewState): Add needed early return.
9:17 PM Changeset in webkit [23367] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-05-14 Oliver Hunt <​oliver@apple.com>

Reviewed by Sam.

Fix for <rdar://problem/5147895> REGRESSION: Content-Disposition: filename is ignored for drag-and-drop.

If the image does not already have a title, fall back to the
name suggested by Content-Disposition.

  • platform/win/ClipboardWin.cpp: (WebCore::createGlobalImageFileDescriptor):
8:49 PM Changeset in webkit [23366] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-05-14 Oliver Hunt <​oliver@apple.com>

Reviewed by Sam.

Fix for <rdar://problem/5202805> Null dereference in createGlobalData(CString str)


Null terminate manually to prevent us from dereferencing null.

  • platform/win/ClipboardUtilitiesWin.cpp: (WebCore::createGlobalData):
7:05 PM Changeset in webkit [23365] by oliver
  • 4 edits in branches/WindowsMerge/WebCore

2007-05-14 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoff.


Windows side of fix for
<rdar://problem/4728842> Can't drag-and-drop files onto <input type="file">

  • platform/win/ClipboardUtilitiesWin.cpp: (WebCore::cfHDropFormat): Need to be able to access externally


  • platform/win/ClipboardUtilitiesWin.h: Declare cfHDropFormat


  • platform/win/DragDataWin.cpp: (WebCore::DragData::containsFiles): (WebCore::DragData::asFilenames): Add implementation of containsFiles and asFilenames
6:53 PM Changeset in webkit [21473] by bdash
  • 3 edits
    3 adds in trunk

2007-05-14 Kimmo Kinnunen <Kimmo Kinnunen>

Reviewed by Darin.

  • kjs/nodes2string.cpp: (ArrayNode::streamTo): print extra ',' in case there was elision commas (check opt member var) and array elements present in the array expression

2007-05-14 Kimmo Kinnunen <Kimmo Kinnunen>

Reviewed by Darin.

  • fast/js/resources/toString-elision-trailing-comma.js: Added.
  • fast/js/toString-elision-trailing-comma-expected.txt: Added.
  • fast/js/toString-elision-trailing-comma.html: Added.
6:41 PM Changeset in webkit [21472] by bdash
  • 3 edits
    2 adds in trunk

2007-05-14 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Test: fast/parser/residual-style-close-across-n-blocks.html

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Changed to deal with multiple block crossings instead of bailing out, by doing multiple reparenting passes, starting from the outermost block.

2007-05-14 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/parser/residual-style-close-across-n-blocks-expected.txt: Added.
  • fast/parser/residual-style-close-across-n-blocks.html: Added.
6:39 PM Changeset in webkit [21471] by bdash
  • 4 edits in trunk/WebCore

2007-05-14 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

No test possible since this patch affects only Safari chrome.

  • platform/Font.cpp: (WebCore::Font::Font): Initialize m_isPlatformFont according to whether the Font object is derived from a FontPlatformData or not.
  • platform/Font.h: (WebCore::Font::isPlatformFont): Added. Returns whether this Font was derived from a platform font.
  • platform/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters): Changed to not enable synthetic bold and italic in the fallback fonts if the original font was derived from a platform font.
6:32 PM Changeset in webkit [21470] by weinig
  • 58 edits
    4 adds
    2 deletes in trunk

LayoutTests:

Reviewed by Alice.

  • fast/dom/document-attribute-js-null-expected.txt: Added.
  • fast/dom/document-attribute-js-null.html: Added.
  • fast/dom/element-attribute-js-null-expected.txt: Added.
  • fast/dom/element-attribute-js-null.html: Added.
  • fast/forms/input-null-expected.txt: Removed.
  • fast/forms/input-null.html: Removed.

WebCore:

Reviewed by Alice!

Convert JS null to the empty string when passing it to an attribute that takes
a DOMString.

Test: fast/dom/document-attribute-js-null.html
Test: fast/dom/element-attribute-js-null.html

  • bindings/js/kjs_dom.cpp: (KJS::DOMNode::putValueProperty):
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::putValueProperty): (KJS::JSHTMLElement::objectSetter): (KJS::JSHTMLElement::embedSetter): (KJS::JSHTMLElement::tableSetter): (KJS::JSHTMLElement::tableCaptionSetter): (KJS::JSHTMLElement::tableColSetter): (KJS::JSHTMLElement::tableSectionSetter): (KJS::JSHTMLElement::tableRowSetter): (KJS::JSHTMLElement::tableCellSetter): (KJS::JSHTMLElement::frameSetSetter): (KJS::JSHTMLElement::frameSetter): (KJS::JSHTMLElement::iFrameSetter): (KJS::JSHTMLElement::marqueeSetter): (KJS::JSHTMLElement::putValueProperty):
  • bindings/js/kjs_html.h:
  • dom/Document.idl:
  • dom/Node.idl:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLBRElement.idl:
  • html/HTMLBaseElement.idl:
  • html/HTMLBaseFontElement.idl:
  • html/HTMLBlockquoteElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLDivElement.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFontElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLFrameSetElement.idl:
  • html/HTMLHRElement.idl:
  • html/HTMLHeadElement.idl:
  • html/HTMLHeadingElement.idl:
  • html/HTMLHtmlElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLIsIndexElement.idl:
  • html/HTMLLIElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLMapElement.idl:
  • html/HTMLMetaElement.idl:
  • html/HTMLModElement.idl:
  • html/HTMLOListElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptGroupElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLParagraphElement.idl:
  • html/HTMLParamElement.idl:
  • html/HTMLQuoteElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLStyleElement.idl:
  • html/HTMLTableCaptionElement.idl:
  • html/HTMLTableCellElement.idl:
  • html/HTMLTableColElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLTitleElement.idl:
  • html/HTMLUListElement.idl:
5:24 PM Changeset in webkit [21469] by ggaren
  • 2 edits in trunk/WebCore

Trying to fix the Qt build.

  • WebCore.pro:
5:20 PM Changeset in webkit [21468] by ggaren
  • 5 edits in trunk

JavaScriptCore:

Reviewed by Oliver Hunt.


Added HashMap::swap and HashSet::swap. WebCore now uses HashSet::swap.
I figured while I was in the neighborhood I might as well add HashMap::swap,
too.

  • wtf/HashMap.h: (WTF::::operator): (WTF::::swap):
  • wtf/HashSet.h: (WTF::::operator): (WTF::::swap):

WebCore:

Reviewed by Oliver Hunt.


Some improvements on my last patch, suggested by Darin.

  • history/PageCache.cpp: (WebCore::PageCache::autoreleaseNow): Swap with an empty set instead of building up an array and then calling clear(). This is slightly more efficient and the code is cleaner.
4:19 PM Changeset in webkit [23364] by ggaren
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
2:37 PM Changeset in webkit [21467] by justing
  • 7 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/5136696> Selection is removed when focusing a node in another frame

Demonstrates bug:

  • editing/selection/5136696-expected.checksum: Added.
  • editing/selection/5136696-expected.png: Added.
  • editing/selection/5136696-expected.txt: Added.
  • editing/selection/5136696.html: Added.

WebCore:

Reviewed by darin


<rdar://problem/5136696> Selection is removed when focusing a node in another frame
<rdar://problem/5192388> WordPress: Can't insert links/images


Don't clear a selection when changing focus if the new
focus node is in a different frame than the old selection.

  • dom/Document.cpp: (WebCore::Document::setFocusedNode): Moved code to clear selections to the FocusController, since it is Page level and will know about the frame/document that contained the old selection. Moved code to call shouldEndEditing to the FocusController because selections are now cleared before calling Document::setFocusedNode and shouldEndEditing must be called before selections are cleared.
  • dom/Element.cpp: (WebCore::Element::blur): Call FocusController::setFocusNode instead of Document::setFocusNode, if possible.
  • page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent): Ditto.
  • page/FocusController.cpp: (WebCore::relinquishesEditingFocus): Moved from Document.cpp. (WebCore::clearSelectionIfNeeded): Ditto. Don't clear if the old selection is in a frame that's different than the one that contains the new focus node. (WebCore::FocusController::setFocusedNode): Moved code here from Document::setFocusedNode.
  • page/Frame.cpp: (WebCore::Frame::setFocusedNodeIfNeeded): Call FocusController::setFocusNode.
2:37 PM Changeset in webkit [21466] by spadma
  • 2 edits in S60/trunk/WebKit

ligman, reviewed by Sachin

DESC: Inputbox callback gets canceled before it has a chance to run. Setting it's priority to EPriorityUserInput
​http://bugs.webkit.org/show_bug.cgi?id=13714

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::OkToExit):
2:36 PM Changeset in webkit [21465] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

ligman, reviewed by Sachin

DESC: Inputbox callback gets canceled before it has a chance to run. Setting it's priority to EPriorityUserInput
​http://bugs.webkit.org/show_bug.cgi?id=13714

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::OkToExit):
2:29 PM Changeset in webkit [21464] by ggaren
  • 8 edits
    2 adds
    2 deletes in trunk

WebCore:

Reviewed by Darin Adler.


Next step toward fixing <rdar://problem/5055182> The back cache has no
global cap.


Created a PageCache singleton. Right now, it only handles the timer-based
deallocation of cached pages. I plan to add HistoryItem->CachedPage tracking
and eviction logic in later patches.

Updated for renames and file changes:

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • history/BackForwardList.cpp: (WebCore::BackForwardList::setPageCacheSize): (WebCore::BackForwardList::clearPageCache):

Removed global timed release code, moved into new PageCache class, since
it's eventually going to be in charge of deciding when things are released:


  • history/HistoryItem.cpp: (WebCore::HistoryItem::setCachedPage):
  • history/HistoryItem.h:

Folded into PageCache:


  • history/HistoryItemTimer.cpp: Removed.
  • history/HistoryItemTimer.h: Removed.

New singleton. Right now, it just handles timed release of cached pages:


  • history/PageCache.cpp: Added. (WebCore::pageCache): (WebCore::PageCache::PageCache): (WebCore::PageCache::autoreleaseNowOrReschedule): (WebCore::PageCache::autoreleaseNow): (WebCore::PageCache::autorelease):
  • history/PageCache.h: Added.

WebKit:

Reviewed by Darin Adler.


Updated for WebCore move to PageCache singleton. Also removed some WebCore
prefixes and replaced them with 'using namespace WebCore'.
  • History/WebHistoryItem.mm: (+[WebHistoryItem _releaseAllPendingPageCaches]): (-[WebWindowWatcher windowWillClose:]):
2:16 PM Changeset in webkit [21463] by adele
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/5200081> Repro crash in PopupMenu::show clicking popup menu button after reload

  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Added call to dismissPopup so the cell gets unattached properly.
1:57 PM Changeset in webkit [21462] by adele
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Remove incorrect assertion.

  • page/FrameView.cpp: (WebCore::FrameView::setContentsPos):
1:43 PM Changeset in webkit [21461] by lars
  • 2 edits
    405 adds
    6 deletes in trunk/LayoutTestResults

Add another 1000 tests that we pass for the Qt build.

12:20 PM Changeset in webkit [21460] by lars
  • 284 edits
    21 adds
    9 deletes in trunk/LayoutTestResults

Add another 300 test cases, that are ok on the Qt build.
Add a few more tests that need examination to the Skipped list.

12:05 PM Changeset in webkit [23363] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Geoff.

<rdar://problem/5176940> Seed10: MS Silverlight 1.0 beta plug-in is not supported


  • plugins/win/PluginDatabaseWin.cpp: (WebCore::addPluginsFromRegistry): New function that adds plugins from the registry from HKEY_LOCAL_MACHINE/MozillaPlugins.
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::invalidateRect): (WebCore::PluginViewWin::forceRedraw): Make these work with windowed plugins.
11:53 AM Changeset in webkit [21459] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/5172056> Regression: cannot open txt file, get broken image

Never let plug-ins override text/plain.


  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
9:34 AM Changeset in webkit [23362] by aroben
  • 2 edits in branches/WindowsMerge/WebKitTools

Build fix.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h:
8:34 AM Changeset in webkit [21458] by spadma
  • 4 edits in S60/branches/3.1m/WebKit

hongzhao, reviewed by <Sachin>

DESC: [S60] Open to viewer option doesn't work in browser in video content.
​http://bugs.webkit.org/show_bug.cgi?id=13648

  • Plugin/inc/PluginWin.h:
  • Plugin/src/PluginSkin.cpp: (CPluginSkin::ConstructL):
  • Plugin/src/PluginWin.cpp: (CPluginWin::SetTopUrlL):
8:33 AM Changeset in webkit [21457] by spadma
  • 4 edits in S60/trunk/WebKit

hongzhao, reviewed by <Sachin>

DESC: [S60] Open to viewer option doesn't work in browser in video content.
​http://bugs.webkit.org/show_bug.cgi?id=13648

  • Plugin/inc/PluginWin.h:
  • Plugin/src/PluginSkin.cpp: (CPluginSkin::ConstructL):
  • Plugin/src/PluginWin.cpp: (CPluginWin::SetTopUrlL):
7:39 AM Changeset in webkit [21456] by zack
  • 2 edits in trunk/WebCore

Fix dependcy tracking in project files.

Add dependpath to project to get better dependency tracking for header
files in the qmake project files.

r=simon

6:41 AM Changeset in webkit [21455] by lars
  • 10 edits in trunk

Reviewed by Zack

Updates after Maciej's frame change.

This gets things to run again. The #ifdef PLATFORM(QT)
in the FrameLoader should not be needed (and adding the line
inside on the mac doesn't seem to trigger any failures there).
I'm submitting with it to be on the safe side for now, since I
really need our tests to run again.

Btw, post-commit-linux-qt should show up green on with this submit :))

6:30 AM Changeset in webkit [21454] by darin
  • 6 edits in trunk/WebCore

Reviewed by Antti.

  • fix <rdar://problem/3109180> VIP: after go back, page jumps after loading even if I scrolled while loading
  • history/CachedPage.cpp: (WebCore::CachedPage::clear): Call clearFrame rather than clearPart -- the "part" term was leftover prehistoric terminology.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::open): Call setWasScrolledByUser(false) on the page, so that we can detect any user scrolling that happens during the "go back" process. (WebCore::FrameLoader::restoreScrollPositionAndViewState): Don't scroll if the view's wasScrolledByUser flag is set. (WebCore::FrameLoader::loadItem): Call setWasScrolledByUser(false) false when we do a new "load" (actually just a scroll) using the same frame. Also moved the line of code that sets m_currentHistoryItem to make this code path mroe similar to recursiveGoToItem. (WebCore::FrameLoader::recursiveGoToItem): Ditto.
  • page/Frame.cpp: (WebCore::Frame::~Frame): Call clearFrame rather than stting m_frame directly. (WebCore::Frame::sendScrollEvent): Call setWasScrolledByUser(true) on FrameView. The FrameView itself knows to ignore this if the scrolling is being done programmatically instead of by the user.
  • page/FrameView.h: Added wasScrolledByUser and setWasScrolledByUser. Also removed unneeded include and class forward declarations, renamed clearPart to clearFrame, removed uneeded function haveDelayedLayoutScheduled, and removed unneeded friend declarations.
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Added m_inProgrammaticScroll and m_wasScrolledByUser. (WebCore::FrameViewPrivate::reset): Set m_wasScrolledByUser to false. (WebCore::FrameView::clearFrame): Renamed from clearPart. (WebCore::FrameView::scrollRectIntoViewRecursively): Added code to set the m_inProgrammaticScroll flag. (WebCore::FrameView::setContentsPos): Ditto. (WebCore::FrameView::wasScrolledByUser): Added. (WebCore::FrameView::setWasScrolledByUser): Added. Does nothing if called when m_inProgrammaticScroll is true.
6:26 AM Changeset in webkit [21453] by darin
  • 3 edits in trunk/LayoutTests

2007-05-14 Kimmo Kinnunen <Kimmo Kinnunen>

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=10878
Bug 10878: Incorrect decompilation for "4..x"

Test all the different forms of expressions that can contain
a dot following a number literal.
Includes new tests for PrefixDotNode, PostfixDotNode, DeleteDotNode,
AssignDotNode and FunctionCallParenDotNode.

  • fast/js/resources/toString-number-dot-expr.js:
  • fast/js/toString-number-dot-expr-expected.txt: Updated.
6:13 AM Changeset in webkit [23361] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin
6:12 AM Changeset in webkit [21452] by darin
  • 2 edits in trunk/WebCore

Reviewed by Antti.

  • <rdar://problem/4865655> REGRESSION: find function does not work for the character ß

The trick was to fold case consistently in the CircularSearchBuffer class.

The problem was that we were folding the search target string with full case folding and
the characters of the text we were searching with simple case folding. We now use full
case folding in both cases.

  • editing/TextIterator.cpp: (WebCore::CircularSearchBuffer::CircularSearchBuffer): Changed the buffer to be a Vector<UChar>. Added a Vector<bool> to record which characters were starts of characters in the text we are searching. Changed the cursor to be an int rather than a pointer. (WebCore::CircularSearchBuffer::append): New function that knows how to append multiple characters when folding case turns one character into many -- uses the full foldCase rather than the simplified single-character foldCase. Also removed the append function that did multiple characters at once; that was part of an optimization we don't need. (WebCore::CircularSearchBuffer::isMatch): Instead of asserting that the buffer is full, changed this to return false if it's not full, which lets us fill up the buffer with the normal loop. Also return false if the start of the buffer is half-way through a case-folded character and updated this since m_cursor is now an integer. (WebCore::CircularSearchBuffer::length): This returns the length in non-case-folded characters of the characters that were appended, which may not be the same as the length of the original target string. To do that we have to total up the character start booleans for the current state of the circular buffer. (WebCore::findPlainText): Streamlined the logic in a few ways: 1) Moved more of the return value setup to the top of the function so it could be shared with the early error exit. 2) Removed the separate "fill the buffer" logic, which allowed me to remove some of the functions from CircularSearchBuffer and eliminated the need for two nested loops. 3) Replaced the CharacterIterator and bool that were used to record the location we found with integers matchStart and matchLength. 4) Got rid of the use of goto since we don't have two nested loops any more.
5:16 AM Changeset in webkit [21451] by andrew
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=13275
Safari crashed when trying to login using the windows live contact control

Check for cleared windowObj in JSAbstractEventListener::handleEvent

  • bindings/js/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
4:16 AM Changeset in webkit [23360] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Antti.

Report an error to the resource load delegate if the Java plugin can't be loaded.


  • WebFrame.cpp: (WebFrame::createJavaAppletWidget):
12:17 AM Changeset in webkit [21450] by lars
  • 2 edits in trunk/LayoutTestResults

Skip a test that currently hangs

May 13, 2007:

10:13 PM Changeset in webkit [21449] by kevino
  • 5 edits in branches/wx-port-alpha/trunk

Restore the Windows build after WEBKITOUTPUTDIR changes, and also copy over dependency dlls to product dir so that testkjs and the sample app won't complain about missing dlls.

9:45 PM Changeset in webkit [21448] by ap
  • 4 edits
    2 adds
    2 deletes in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13690
JavaScript Form Validation issue on Banco do Brasil site

Test: fast/forms/input-setvalue-selection.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue): In other browsers, changing textInput.value always moves the insertion point past the text. In 10.4.9 WebKit, this only worked for inactive controls, and it never worked in ToT.
11:43 AM Changeset in webkit [23359] by darin
  • 2 edits in branches/WindowsMerge/WebCore

Requested by Hyatt.

  • platform/win/KeyEventWin.cpp: (WebCore::keyIdentifierForWindowsKeyCode): Use 4 digits for "U+" stuff.
8:28 AM Changeset in webkit [21447] by beidson
  • 5 edits in trunk/WebCore

Reviewed by Mitz

​http://bugs.webkit.org/show_bug.cgi?id=13701

Since HTMLInputElements register themselves with their Document for special handling, if their document
ever changes then bad things can happen.

Unfortunately, with adoptNode, the document can change. This has been a long standing crasher with all
input fields but was given recent high visibility by r21430

The solution is to add functionality for a Node to react to its owner document changing via a pair of
virtual callbacks. Then we can tap into those callbacks in HTMLInputElement.

No layout test possible until ​http://bugs.webkit.org/show_bug.cgi?id=13672 is resolved

  • dom/Node.cpp: (WebCore::Node::setDocument): Call willMoveToNewOwnerDocument and didMoveToNewOwnerDocument
  • dom/Node.h: (WebCore::Node::willMoveToNewOwnerDocument): Virtual callback to a node for before an owner document change (WebCore::Node::didMoveToNewOwnerDocument): Virtual callback to a node for after an owner document change
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::~HTMLInputElement): Unconditionally unregister both for both form state and the cache restoration callback (WebCore::HTMLInputElement::setInputType): Change registration with the document only if we're in one (WebCore::HTMLInputElement::attach): Don't bother registering for the callback here - that will be handled by setInputType() or by a change in owner document (WebCore::HTMLInputElement::willMoveToNewOwnerDocument): Unregister with the old owner document (WebCore::HTMLInputElement::didMoveToNewOwnerDocument): Register with the new owner document
  • html/HTMLInputElement.h:
7:05 AM Changeset in webkit [21446] by darin
  • 2 edits in trunk/WebCore
  • platform/mac/TextBreakIteratorInternalICUMac.mm: Fix comment typo.
7:00 AM Changeset in webkit [21445] by rwlbuis
  • 21 edits in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13529
DOM3 keyIdentifier text is incorrect

Use 4 digits for the Unicode based key identifiers.

6:21 AM Changeset in webkit [21444] by darin
  • 2 edits in trunk/WebKit
  • one more retain/release for a tiny bit more robustness
  • WebView/WebPDFView.mm: (-[WebPDFView _updatePreferences:]): [prefs release] (-[WebPDFView _updatePreferencesSoon]): [prefs retain]
6:16 AM Changeset in webkit [21443] by darin
  • 3 edits in trunk/WebKit

Reviewed by Geoff.

  • fix <rdar://problem/5188400> Webkit crashes going back from PDF at perl.org site
  • WebView/WebPDFView.h: Replace _updatePreferencesTimer with _willUpdatePreferencesSoon BOOL. Also remove unneeded @public that gives other classes access to our dataSource member.
  • WebView/WebPDFView.mm: Rearrange top of file a bit, remove forward declaration of the _cancelUpdatePreferencesTimer method. (-[WebPDFView dealloc]): Removed call to _cancelUpdatePreferencesTimer. (-[WebPDFView _updatePreferencesNow:]): Added WebPreferences parameter. This sidesteps problems where the dataSource is no longer present by not looking at the dataSource field at all. Also removed the call to _cancelUpdatePreferencesTimer, added code to set _willUpdatePreferencesSoon to NO and added a release to balance a retain I did in _updatePreferencesSoon. (-[WebPDFView _updatePreferencesSoon]): Changed to use performSelectorAfterDelay instead of an NSTimer. Pass in the preferences object as a parameter, since we might not be able to get to the dataSource when the timer fires.
5:55 AM Changeset in webkit [21442] by darin
  • 2 edits in trunk/WebCore

Reviewed by Antti.

  • fix <rdar://problem/5174903> Safari crashes opening the attached webarchive (made by OmniWeb)
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveResponse): Check ResourceHandle for nil before calling url() on it. (WebCore::IconLoader::didFail): Ditto. (WebCore::IconLoader::didFinishLoading): Ditto.
12:25 AM Changeset in webkit [21441] by rwlbuis
  • 6 edits in trunk/WebCore

Reviewed by Oliver.

Cleanup, get rid of the SVGStyledElement::view() call.

Note: See TracTimeline for information about the timeline view.