Context Navigation

bindings/js/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::put): (KJS::DOMMediaList::put): (KJS::DOMCSSRule::putValueProperty): (KJS::DOMCSSValue::put):
css/CSSPageRule.idl:
css/CSSRule.idl:
css/CSSStyleDeclaration.idl:
css/CSSStyleRule.idl:
css/CSSValue.idl:
css/MediaList.idl:

5:44 PM Changeset in webkit [23369] by sfalken

2 edits in branches/WindowsMerge/WebKitWin

2007-05-15 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin, Oliver.

WebLocalizableStrings.cpp: (WebLocalizedString): Make failure to load a localized string slightly less fatal

4:35 PM Changeset in webkit [21501] by aroben

2 edits in trunk/WebKitTools

Reviewed by David Kilzer.

http://bugs.webkit.org/show_bug.cgi?id=13732
prepare-ChangeLog should work with git

Scripts/prepare-ChangeLog: Added support for Git.

4:19 PM Changeset in webkit [21500] by bdash

2 edits in trunk/WebKit

2007-05-15 Bruce Q Hammond <bruceq@apple.com>

Reviewed by Darin.

Correction of previous patch for http://bugs.webkit.org/show_bug.cgi?id=13578
This corrects the sign of the Y-Axis origin adjustment.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):

4:15 PM Changeset in webkit [23368] by sfalken

2 edits in branches/WindowsMerge/WebKitWin

2007-05-15 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin.

<rdar://problem/4956541> Need to implement preference for how much History is maintained

WebHistory.cpp: (WebHistory::ageLimitDate): Remove extra +30 from history age in days.

3:35 PM Changeset in webkit [21499] by justing

95 edits in trunk/LayoutTests

Updating expected results for r21074.

css1/cascade/cascade_order-expected.checksum:
css1/cascade/cascade_order-expected.png:
css2.1/t0402-c71-fwd-parsing-02-f-expected.checksum:
css2.1/t0402-c71-fwd-parsing-02-f-expected.png:
css2.1/t0505-c16-descendant-01-e-expected.checksum:
css2.1/t0505-c16-descendant-01-e-expected.png:
css2.1/t050803-c14-classes-00-e-expected.checksum:
css2.1/t050803-c14-classes-00-e-expected.png:
css2.1/t0509-c15-ids-01-e-expected.checksum:
css2.1/t0509-c15-ids-01-e-expected.png:
css2.1/t0805-c5518-brdr-t-01-e-expected.checksum:
css2.1/t0805-c5518-brdr-t-01-e-expected.png:
css2.1/t0805-c5519-brdr-r-02-e-expected.checksum:
css2.1/t0805-c5519-brdr-r-02-e-expected.png:
css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
css2.1/t0805-c5520-brdr-b-01-e-expected.png:
css2.1/t0805-c5521-brdr-l-02-e-expected.checksum:
css2.1/t0805-c5521-brdr-l-02-e-expected.png:
css2.1/t1205-c563-list-type-00-b-expected.checksum:
css2.1/t1205-c563-list-type-00-b-expected.png:
css2.1/t1205-c564-list-img-00-b-g-expected.checksum:
css2.1/t1205-c564-list-img-00-b-g-expected.png:
fast/backgrounds/repeat/noRepeatCorrectClip-expected.checksum:
fast/backgrounds/repeat/noRepeatCorrectClip-expected.png:
fast/block/float/014-expected.checksum:
fast/block/float/014-expected.png:
fast/css/001-expected.checksum:
fast/css/001-expected.png:
fast/css/css2-system-fonts-expected.checksum:
fast/css/css2-system-fonts-expected.png:
fast/doctypes/001-expected.checksum:
fast/doctypes/001-expected.png:
fast/doctypes/002-expected.checksum:
fast/doctypes/002-expected.png:
fast/doctypes/003-expected.checksum:
fast/doctypes/003-expected.png:
fast/doctypes/004-expected.checksum:
fast/doctypes/004-expected.png:
fast/dom/Window/window-onFocus-expected.checksum:
fast/dom/Window/window-onFocus-expected.png:
fast/events/keydown-1-expected.checksum:
fast/events/keydown-1-expected.png:
fast/lists/002-expected.checksum:
fast/lists/002-expected.png:
fast/lists/003-expected.checksum:
fast/lists/003-expected.png:
fast/lists/005-expected.checksum:
fast/lists/005-expected.png:
fast/lists/007-expected.checksum:
fast/lists/007-expected.png:
fast/lists/008-expected.checksum:
fast/lists/008-expected.png:
fast/lists/big-list-marker-expected.checksum:
fast/lists/big-list-marker-expected.png:
fast/lists/dynamic-marker-crash-expected.checksum:
fast/lists/dynamic-marker-crash-expected.png:
fast/lists/item-not-in-list-line-wrapping-expected.checksum:
fast/lists/item-not-in-list-line-wrapping-expected.png:
fast/lists/marker-image-error-expected.checksum:
fast/lists/marker-image-error-expected.png:
fast/lists/ol-display-types-expected.checksum:
fast/lists/ol-display-types-expected.png:
fast/lists/scrolled-marker-paint-expected.checksum:
fast/lists/scrolled-marker-paint-expected.png:
fast/overflow/overflow-rtl-expected.checksum:
fast/overflow/overflow-rtl-expected.png:
fast/repaint/list-marker-2-expected.checksum:
fast/repaint/list-marker-2-expected.png:
fast/repaint/list-marker-expected.checksum:
fast/repaint/list-marker-expected.png:
fast/selectors/001-expected.checksum:
fast/selectors/001-expected.png:
fast/selectors/013-expected.checksum:
fast/selectors/013-expected.png:
fast/selectors/015-expected.checksum:
fast/selectors/015-expected.png:
fast/selectors/166-expected.checksum:
fast/selectors/166-expected.png:
tables/mozilla/bugs/bug23235-expected.checksum:
tables/mozilla/bugs/bug23235-expected.png:
tables/mozilla/bugs/bug30692-expected.checksum:
tables/mozilla/bugs/bug30692-expected.png:
tables/mozilla/bugs/bug3191-expected.checksum:
tables/mozilla/bugs/bug3191-expected.png:
tables/mozilla/marvin/backgr_index-expected.checksum:
tables/mozilla/marvin/backgr_index-expected.png:
tables/mozilla/marvin/backgr_layers-opacity-expected.checksum:
tables/mozilla/marvin/backgr_layers-opacity-expected.png:
tables/mozilla_expected_failures/bugs/bug1010-expected.checksum:
tables/mozilla_expected_failures/bugs/bug1010-expected.png:
tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum:
tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.checksum:
tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png:

3:19 PM Changeset in webkit [21498] by darin

2 edits in trunk/WebCore

Reviewed by Hyatt.

css/html4.css: Remove wbr style rule -- not needed any more.

3:03 PM Changeset in webkit [21497] by beidson

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Brady

test for http://bugs.webkit.org/show_bug.cgi?id=13360 REGRESSION: Crash closing live web cam viewer page

http/tests/misc/multipart-expected.txt: Added.
http/tests/misc/multipart.html: Added.
http/tests/misc/resources/1x1-blue.png: Added.
http/tests/misc/resources/multipart.php: Added.

WebCore:

Reviewed by Brady

fix http://bugs.webkit.org/show_bug.cgi?id=13360 REGRESSION: Crash closing live web cam viewer page

Test: http/tests/misc/multipart.html

loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didFail): Avoid calling didFailToLoad() if didFinishLoad() has already been called (when the first part of a multipart resource arrived). (WebCore::ResourceLoader::didCancel): Ditto.

2:42 PM Changeset in webkit [21496] by bdash

1 copy in tags/Safari-4522.8

New tag.

2:39 PM Changeset in webkit [21495] by bdash

4 edits in branches/Safari-522

Versioning.

12:04 PM Changeset in webkit [21494] by ggaren

2 edits in trunk/JavaScriptCore

Reviewed by Adele Peterson.

It helps if you swap the right variable.

wtf/HashSet.h: (WTF::::operator):

11:21 AM Changeset in webkit [21493] by spadma

2 edits in S60/trunk/WebKit

2007-05-15 spadma

Reviewed by Zalan.
DESC: [S60] User cannot detach from flash object after the object uses connection
http://bugs.webkit.org/show_bug.cgi?id=13731

BrowserView/src/WebKitControl.cpp: (CWebKitControl::FinalProgressComplete):

11:20 AM Changeset in webkit [21492] by spadma

2 edits in S60/branches/3.1m/WebKit

2007-05-15 spadma

Reviewed by Zalan.
DESC: [S60] User cannot detach from flash object after the object uses connection
http://bugs.webkit.org/show_bug.cgi?id=13731

BrowserView/src/WebKitControl.cpp: (CWebKitControl::FinalProgressComplete):

11:11 AM Changeset in webkit [21491] by spadma

2 edits in S60/trunk/WebCore

2007-05-15 spadma

Reviewed by Zalan.
DESC: Browser panics when trying to log into www.luukku.com
http://bugs.webkit.org/show_bug.cgi?id=13733
TSW ID: MLIO-7349EQ
WARNING: NO TEST CASES ADDED OR CHANGED

kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::submitForm):

11:10 AM Changeset in webkit [21490] by spadma

2 edits in S60/branches/3.1m/WebCore

2007-05-15 spadma

Reviewed by Zalan.
DESC: Browser panics when trying to log into www.luukku.com
http://bugs.webkit.org/show_bug.cgi?id=13733
TSW ID: MLIO-7349EQ
WARNING: NO TEST CASES ADDED OR CHANGED

kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::submitForm):

10:53 AM Changeset in webkit [21489] by weinig

6 edits
2 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for http://bugs.webkit.org/show_bug.cgi?id=13722 Finish testing and fixing the setting of DOM attributes to JS null

Tests for Core DOM attributes.

fast/dom/coreDOM-element-attribute-js-null-expected.txt: Added.
fast/dom/coreDOM-element-attribute-js-null.xhtml: Added.

WebCore:

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13722 Finish testing and fixing the setting of DOM attributes to JS null

Convert JS null to null string for remaining Core DOM attributes.

Test: fast/dom/coreDOM-element-attribute-js-null.xhtml

dom/Attr.cpp: (WebCore::Attr::setValue): Don't throw an expection for null values as this is not in the spec and Firefox does not do it either.
dom/Attr.idl:
dom/CharacterData.idl:
dom/ProcessingInstruction.idl:

10:50 AM Changeset in webkit [21488] by sfalken

6 edits in branches/Safari-522/WebCore

Merged fix from r21227.

9:47 AM Changeset in webkit [21487] by ggaren

7 edits
2 deletes in trunk/WebKit

Reviewed by Maciej Stachowiak.

Patch: fixed <rdar://problem/5198890> .5% performance regression caused
by r21307

The only code r21307 added that runs during the PLT is a frame load delegate
-respondsToSelector: call inside windowObjectCleared(), so it seems like
our message dispatch overhead for the frame load delegate is significant.

This patch is a straight port of Maciej's fix for the same problem in the
resource load delegate. The solution is simple enough: don't use Objective-C.
Instead, use a special structure that caches which methods the delegate
implements, along with pointers to those methods.

I verified each frame load delegate callback in the debugger, except for
-webView:didFailLoadWithError:forFrame:, which is not implemented by Safari
or DumpRenderTree.

WebKit/DefaultDelegates/WebDefaultFrameLoadDelegate.h: Removed.
WebKit/DefaultDelegates/WebDefaultFrameLoadDelegate.m: Removed.

WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge windowObjectCleared]): I also removed a misleading comment here. The JS debugger caches the windowScriptObject, so you do need to re-create the debugger every time you invalidate the old WebScriptObject wrapper for the window object and create a new one, or the debugger will stop working. We could fix this in a number of ways, but <rdar://problem/4608404> is not the key issue.

7:38 AM Changeset in webkit [21486] by lars

2 edits in trunk/LayoutTestResults

Update test result now that we have the eventSender object.

6:40 AM Changeset in webkit [21485] by lars

10 edits
1 add in trunk

Extend the QObject JavaScript bindings to work for slots with
arguments.

Add the EventSender object to DRT. Currently it implements
mouseDown, mouseUp and mouseMoveTo.

Make run-webkit-tests --strict work somewhat better for form elements.

one more test passing for Qt, the first one that uses
the eventSender in DRT.

5:45 AM Changeset in webkit [21484] by justing

67 edits in trunk/LayoutTests

Updating expected results for r21074.

editing/deleting/4866671-expected.checksum:
editing/deleting/4866671-expected.png:
editing/deleting/delete-first-list-item-expected.checksum:
editing/deleting/delete-first-list-item-expected.png:
editing/deleting/delete-listitem-002-expected.checksum:
editing/deleting/delete-listitem-002-expected.png:
editing/deleting/list-item-1-expected.checksum:
editing/deleting/list-item-1-expected.png:
editing/deleting/merge-into-empty-block-2-expected.checksum:
editing/deleting/merge-into-empty-block-2-expected.png:
editing/execCommand/4641880-1-expected.checksum:
editing/execCommand/4641880-1-expected.png:
editing/execCommand/4747450-expected.checksum:
editing/execCommand/4747450-expected.png:
editing/execCommand/4916402-expected.checksum:
editing/execCommand/4916402-expected.png:
editing/execCommand/4916583-expected.checksum:
editing/execCommand/4916583-expected.png:
editing/execCommand/5142012-2-expected.checksum:
editing/execCommand/5142012-2-expected.png:
editing/execCommand/5144139-1-expected.checksum:
editing/execCommand/5144139-1-expected.png:
editing/execCommand/create-list-with-hr-expected.checksum:
editing/execCommand/create-list-with-hr-expected.png:
editing/execCommand/indent-list-item-expected.checksum:
editing/execCommand/indent-list-item-expected.png:
editing/execCommand/indent-selection-expected.checksum:
editing/execCommand/indent-selection-expected.png:
editing/execCommand/insert-list-empty-div-expected.checksum:
editing/execCommand/insert-list-empty-div-expected.png:
editing/execCommand/remove-list-item-1-expected.checksum:
editing/execCommand/remove-list-item-1-expected.png:
editing/inserting/4959067-expected.checksum:
editing/inserting/4959067-expected.png:
editing/pasteboard/4861080-expected.checksum:
editing/pasteboard/4861080-expected.png:
editing/pasteboard/drag-selected-image-to-contenteditable-expected.checksum:
editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
editing/pasteboard/drop-link-expected.checksum:
editing/pasteboard/drop-link-expected.png:
editing/pasteboard/innerText-inline-table-expected.checksum:
editing/pasteboard/innerText-inline-table-expected.png:
editing/pasteboard/input-field-1-expected.checksum:
editing/pasteboard/input-field-1-expected.png:
editing/pasteboard/merge-end-list-expected.checksum:
editing/pasteboard/merge-end-list-expected.png:
editing/pasteboard/merge-start-list-expected.checksum:
editing/pasteboard/merge-start-list-expected.png:
editing/pasteboard/select-element-1-expected.checksum:
editing/pasteboard/select-element-1-expected.png:
editing/selection/drag-to-contenteditable-iframe-expected.checksum:
editing/selection/drag-to-contenteditable-iframe-expected.png:
editing/selection/extend-by-word-002-expected.checksum:
editing/selection/extend-by-word-002-expected.png:
editing/selection/select-all-iframe-expected.checksum:
editing/selection/select-all-iframe-expected.png:
editing/selection/selectNode-expected.checksum:
editing/selection/selectNode-expected.png:
editing/selection/selectNodeContents-expected.checksum:
editing/selection/selectNodeContents-expected.png:
editing/unsupported-content/list-delete-001-expected.checksum:
editing/unsupported-content/list-delete-001-expected.png:
editing/unsupported-content/list-type-after-expected.checksum:
editing/unsupported-content/list-type-after-expected.png:
editing/unsupported-content/list-type-before-expected.checksum:
editing/unsupported-content/list-type-before-expected.png:

3:00 AM Changeset in webkit [21483] by andrew

2 edits in trunk/WebCore

Reviewed by Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13718 REGRESSION (r21093): editing/execCommand/5136770.html failing pixel test

rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): Moved the code that clears the selection when moving a selection border into the fast path.

2:31 AM Changeset in webkit [21482] by rwlbuis

2 edits in trunk/WebCore

Reviewed by Hyatt.

http://bugs.webkit.org/show_bug.cgi?id=6487
"Make Text Bigger/Smaller" affects SVGs when it probably shouldn't

Ignore Make Text Bigger/Smaller for SVG text.

2:28 AM Changeset in webkit [21481] by andersca

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Maciej.

<rdar://problem/5183685>
http://bugs.webkit.org/show_bug.cgi?id=13301
ASSERT or null value when trying to use a getter defined on a window object

Add tests.

fast/dom/getter-on-window-object-expected.txt: Added.
fast/dom/getter-on-window-object.html: Added.

WebCore:

Reviewed by Maciej.

<rdar://problem/5183685>
http://bugs.webkit.org/show_bug.cgi?id=13301
ASSERT or null value when trying to use a getter defined on a window object

Handle the case where the value returned is a getter/setter object.

bindings/js/kjs_window.cpp: (KJS::Window::getOverridePropertySlot):

1:27 AM Changeset in webkit [21480] by andersca

3 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/5200816>
REGRESSION: With Shiira 1.2.2 , I can't open embedded link in flash object by clicking (http:/www.adobe.com )

Shiira under some circumstances passes nil as the request to -[WebFrame loadRequest:]. ToT WebKit doesn't call any policy
delegate methods in this case, which means that the page is actually being loaded.

This patch makes ToT WebKit behave in the same way as Tiger WebKit when the request is nil.

loader/FrameLoader.cpp: (WebCore::FrameLoader::checkNavigationPolicy): Don't continue without calling the navigation policy method if the request is null.

(WebCore::FrameLoader::continueAfterNavigationPolicy):
If the request can't be handled, don't continue the load.

platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest): Don't create an NSURLRequest object if the request is null.

1:24 AM Changeset in webkit [21479] by mjs

6 edits in trunk

WebCore:

Reviewed by Hyatt and Lars.

fixed <rdar://problem/5201758> REGRESSION: Stop button enabled and other problems caused by [WebView currentURL] returning non-nil for empty window

WebCore.exp: export new symbol
loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): move marker that we committed a real doc load from here... (WebCore::FrameLoader::transitionToCommitted): ...to here (WebCore::FrameLoader::frameHasLoaded): check that we have at least started loading something besides the initial empty doc.
loader/FrameLoader.h:

WebKit:

Reviewed by Hyatt and Lars.

fixed <rdar://problem/5201758> REGRESSION: Stop button enabled and other problems caused by [WebView currentURL] returning non-nil for empty window

WebView/WebDataSource.mm: (-[WebDataSource request]): Return nil when we are still showing the initial empty doc

12:37 AM Changeset in webkit [21478] by lars

2 edits
461 adds in trunk/LayoutTestResults

5319 -> 5879 passing test cases for the Qt build.

12:31 AM Changeset in webkit [21477] by justing

5 edits in trunk/LayoutTests

Spelling markers fixed:

editing/deleting/delete-block-table-expected.checksum:
editing/deleting/delete-block-table-expected.png:
editing/selection/move-by-line-001-expected.checksum:
editing/selection/move-by-line-001-expected.png:

May 14, 2007:

11:15 PM Changeset in webkit [21476] by justing

5 edits in trunk

LayoutTests:

Reviewed by ggaren

Updated these expected results. We now clear the
selection inside a focused node *after* firing the
mousedown event handler, which matches FF:

fast/forms/focus-selection-input-expected.txt:
fast/forms/focus-selection-textarea-expected.txt:

WebCore:

Reviewed by ggaren

<http://bugs.webkit.org/show_bug.cgi?id=13716>
REGRESSION: Three new layout test failures

Two failures are correct. Updated their expected results.

In fast/events/frame-tab-focus.html, as we advance
through focusable nodes, we descend into a subframe
to focus a node and then ascend out of it into the
main frame to focus the next. When we focus the main
frame, the node in that frame that was previously
focused and contains an inactive selection is focused
momentarily because setCaretVisible tries to focus the
node containing the caret.

page/Frame.cpp: (WebCore::Frame::setCaretVisible): Don't focus the node containing the caret. FocusController will focus the previously focused node (which will contain the caret) if necessary when the frame gains focus.

10:59 PM Changeset in webkit [21475] by justing

17 edits in trunk/LayoutTests

Reviewed by ggaren

Spelling markers fixed:

editing/deleting/delete-to-select-table-expected.checksum:
editing/deleting/delete-to-select-table-expected.png:
editing/selection/end-of-document-expected.checksum:
editing/selection/end-of-document-expected.png:
editing/inserting/insert-paragraph-02-expected.checksum:
editing/inserting/insert-paragraph-02-expected.png:

Focus halo now painted:

editing/execCommand/format-block-with-braces-expected.checksum:
editing/execCommand/format-block-with-braces-expected.png:

Needed FIXMEs removed after fixing 4714993:

editing/pasteboard/merge-end-1-expected.checksum:
editing/pasteboard/merge-end-1-expected.png:
editing/pasteboard/merge-end-1-expected.txt:
editing/pasteboard/merge-end-1.html:
editing/pasteboard/merge-end-2-expected.checksum:
editing/pasteboard/merge-end-2-expected.png:
editing/pasteboard/merge-end-2-expected.txt:
editing/pasteboard/merge-end-2.html:

10:53 PM Changeset in webkit [21474] by mjs

3 edits
5 adds in trunk

LayoutTests:

Reviewed by Brady.

Test case for <rdar://problem/5203036> REGRESSION: Assertion failure in WebCore::FrameLoader::restoreScrollPositionAndViewState() going back from fark.com Photoshop contest (13684)

http/tests/incremental/slow-utf8-html.pl:
http/tests/navigation/back-to-slow-frame.html: Added.
http/tests/navigation/back-to-slow-frame-expected.txt: Added.
http/tests/navigation/resources/back-to-slow-frame-2.html: Added.
http/tests/navigation/resources/back-to-slow-frame-3.html: Added.
http/tests/navigation/resources/slow-resource-1-sec.pl: Added.

WebCore:

Reviewed by Brady.

fixed <rdar://problem/5203036> REGRESSION: Assertion failure in WebCore::FrameLoader::restoreScrollPositionAndViewState() going back from fark.com Photoshop contest (13684)

Test: http/tests/navigation/back-to-slow-frame.html

loader/FrameLoader.cpp: (WebCore::FrameLoader::restoreScrollPositionAndViewState): Add needed early return.

9:17 PM Changeset in webkit [23367] by oliver

2 edits in branches/WindowsMerge/WebCore

2007-05-14 Oliver Hunt <oliver@apple.com>

Reviewed by Sam.

Fix for <rdar://problem/5147895> REGRESSION: Content-Disposition: filename is ignored for drag-and-drop.

If the image does not already have a title, fall back to the
name suggested by Content-Disposition.

platform/win/ClipboardWin.cpp: (WebCore::createGlobalImageFileDescriptor):

8:49 PM Changeset in webkit [23366] by oliver

2 edits in branches/WindowsMerge/WebCore

2007-05-14 Oliver Hunt <oliver@apple.com>

Reviewed by Sam.

Fix for <rdar://problem/5202805> Null dereference in createGlobalData(CString str)

Null terminate manually to prevent us from dereferencing null.

platform/win/ClipboardUtilitiesWin.cpp: (WebCore::createGlobalData):

7:05 PM Changeset in webkit [23365] by oliver

4 edits in branches/WindowsMerge/WebCore

2007-05-14 Oliver Hunt <oliver@apple.com>

Reviewed by Geoff.

Windows side of fix for
<rdar://problem/4728842> Can't drag-and-drop files onto <input type="file">

platform/win/ClipboardUtilitiesWin.cpp: (WebCore::cfHDropFormat): Need to be able to access externally

platform/win/ClipboardUtilitiesWin.h: Declare cfHDropFormat

platform/win/DragDataWin.cpp: (WebCore::DragData::containsFiles): (WebCore::DragData::asFilenames): Add implementation of containsFiles and asFilenames

6:53 PM Changeset in webkit [21473] by bdash

3 edits
3 adds in trunk

2007-05-14 Kimmo Kinnunen <Kimmo Kinnunen>

Reviewed by Darin.

Fixes http://bugs.webkit.org/show_bug.cgi?id=13622 (Decompiler omits trailing comma in array literal)

kjs/nodes2string.cpp: (ArrayNode::streamTo): print extra ',' in case there was elision commas (check opt member var) and array elements present in the array expression

2007-05-14 Kimmo Kinnunen <Kimmo Kinnunen>

Reviewed by Darin.

Tests for fix to http://bugs.webkit.org/show_bug.cgi?id=13622 (Decompiler omits trailing comma in array literal)

fast/js/resources/toString-elision-trailing-comma.js: Added.
fast/js/toString-elision-trailing-comma-expected.txt: Added.
fast/js/toString-elision-trailing-comma.html: Added.

6:41 PM Changeset in webkit [21472] by bdash

3 edits
2 adds in trunk

2007-05-14 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13603 style leaks in washingtonpost.com also known as http://bugs.webkit.org/show_bug.cgi?id=8750 w3c.org: incorrect recovery from unclosed <a> elements also known as http://bugs.webkit.org/show_bug.cgi?id=12808 Handling of misnested tags results in entire page appearing as link also known as http://bugs.webkit.org/show_bug.cgi?id=12861 Post text renders as link

Test: fast/parser/residual-style-close-across-n-blocks.html

html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Changed to deal with multiple block crossings instead of bailing out, by doing multiple reparenting passes, starting from the outermost block.

2007-05-14 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

test for http://bugs.webkit.org/show_bug.cgi?id=13603 style leaks in washingtonpost.com

fast/parser/residual-style-close-across-n-blocks-expected.txt: Added.
fast/parser/residual-style-close-across-n-blocks.html: Added.

6:39 PM Changeset in webkit [21471] by bdash

4 edits in trunk/WebCore

2007-05-14 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13711 REGRESSION - Bookmark Bar text rendering changed

No test possible since this patch affects only Safari chrome.

platform/Font.cpp: (WebCore::Font::Font): Initialize m_isPlatformFont according to whether the Font object is derived from a FontPlatformData or not.
platform/Font.h: (WebCore::Font::isPlatformFont): Added. Returns whether this Font was derived from a platform font.
platform/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters): Changed to not enable synthetic bold and italic in the fallback fonts if the original font was derived from a platform font.

6:32 PM Changeset in webkit [21470] by weinig

58 edits
4 adds
2 deletes in trunk

LayoutTests:

Reviewed by Alice.

Tests for http://bugs.webkit.org/show_bug.cgi?id=13541 REGRESSION: Setting a DOMString attribute to JS null in the JS bindings should default to converting to the empty string

fast/dom/document-attribute-js-null-expected.txt: Added.
fast/dom/document-attribute-js-null.html: Added.
fast/dom/element-attribute-js-null-expected.txt: Added.
fast/dom/element-attribute-js-null.html: Added.
fast/forms/input-null-expected.txt: Removed.
fast/forms/input-null.html: Removed.

WebCore:

Reviewed by Alice!

Patch for http://bugs.webkit.org/show_bug.cgi?id=13541 REGRESSION: Setting a DOMString attribute to JS null in the JS bindings should default to converting to the empty string

Convert JS null to the empty string when passing it to an attribute that takes
a DOMString.

Test: fast/dom/document-attribute-js-null.html
Test: fast/dom/element-attribute-js-null.html

bindings/js/kjs_dom.cpp: (KJS::DOMNode::putValueProperty):
bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::putValueProperty): (KJS::JSHTMLElement::objectSetter): (KJS::JSHTMLElement::embedSetter): (KJS::JSHTMLElement::tableSetter): (KJS::JSHTMLElement::tableCaptionSetter): (KJS::JSHTMLElement::tableColSetter): (KJS::JSHTMLElement::tableSectionSetter): (KJS::JSHTMLElement::tableRowSetter): (KJS::JSHTMLElement::tableCellSetter): (KJS::JSHTMLElement::frameSetSetter): (KJS::JSHTMLElement::frameSetter): (KJS::JSHTMLElement::iFrameSetter): (KJS::JSHTMLElement::marqueeSetter): (KJS::JSHTMLElement::putValueProperty):
bindings/js/kjs_html.h:
dom/Document.idl:
dom/Node.idl:
html/HTMLAnchorElement.idl:
html/HTMLAppletElement.idl:
html/HTMLAreaElement.idl:
html/HTMLBRElement.idl:
html/HTMLBaseElement.idl:
html/HTMLBaseFontElement.idl:
html/HTMLBlockquoteElement.idl:
html/HTMLBodyElement.idl:
html/HTMLButtonElement.idl:
html/HTMLDivElement.idl:
html/HTMLDocument.idl:
html/HTMLElement.idl:
html/HTMLEmbedElement.idl:
html/HTMLFontElement.idl:
html/HTMLFormElement.idl:
html/HTMLFrameElement.idl:
html/HTMLFrameSetElement.idl:
html/HTMLHRElement.idl:
html/HTMLHeadElement.idl:
html/HTMLHeadingElement.idl:
html/HTMLHtmlElement.idl:
html/HTMLIFrameElement.idl:
html/HTMLImageElement.idl:
html/HTMLInputElement.idl:
html/HTMLIsIndexElement.idl:
html/HTMLLIElement.idl:
html/HTMLLabelElement.idl:
html/HTMLLegendElement.idl:
html/HTMLLinkElement.idl:
html/HTMLMapElement.idl:
html/HTMLMetaElement.idl:
html/HTMLModElement.idl:
html/HTMLOListElement.idl:
html/HTMLObjectElement.idl:
html/HTMLOptGroupElement.idl:
html/HTMLOptionElement.idl:
html/HTMLParagraphElement.idl:
html/HTMLParamElement.idl:
html/HTMLQuoteElement.idl:
html/HTMLScriptElement.idl:
html/HTMLSelectElement.idl:
html/HTMLStyleElement.idl:
html/HTMLTableCaptionElement.idl:
html/HTMLTableCellElement.idl:
html/HTMLTableColElement.idl:
html/HTMLTableElement.idl:
html/HTMLTableRowElement.idl:
html/HTMLTableSectionElement.idl:
html/HTMLTextAreaElement.idl:
html/HTMLTitleElement.idl:
html/HTMLUListElement.idl:

5:24 PM Changeset in webkit [21469] by ggaren

2 edits in trunk/WebCore

Trying to fix the Qt build.

WebCore.pro:

5:20 PM Changeset in webkit [21468] by ggaren

5 edits in trunk

JavaScriptCore:

Reviewed by Oliver Hunt.

Added HashMap::swap and HashSet::swap. WebCore now uses HashSet::swap.
I figured while I was in the neighborhood I might as well add HashMap::swap,
too.

wtf/HashMap.h: (WTF::::operator): (WTF::::swap):
wtf/HashSet.h: (WTF::::operator): (WTF::::swap):

WebCore:

Reviewed by Oliver Hunt.

Some improvements on my last patch, suggested by Darin.

history/PageCache.cpp: (WebCore::PageCache::autoreleaseNow): Swap with an empty set instead of building up an array and then calling clear(). This is slightly more efficient and the code is cleaner.

4:19 PM Changeset in webkit [23364] by ggaren

2 edits in branches/WindowsMerge/WebCore

Build fix.

WebCore.vcproj/WebCore.vcproj:

2:37 PM Changeset in webkit [21467] by justing

7 edits
4 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/5136696> Selection is removed when focusing a node in another frame

Demonstrates bug:

editing/selection/5136696-expected.checksum: Added.
editing/selection/5136696-expected.png: Added.
editing/selection/5136696-expected.txt: Added.
editing/selection/5136696.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/5136696> Selection is removed when focusing a node in another frame
<rdar://problem/5192388> WordPress: Can't insert links/images

Don't clear a selection when changing focus if the new
focus node is in a different frame than the old selection.

dom/Document.cpp: (WebCore::Document::setFocusedNode): Moved code to clear selections to the FocusController, since it is Page level and will know about the frame/document that contained the old selection. Moved code to call shouldEndEditing to the FocusController because selections are now cleared before calling Document::setFocusedNode and shouldEndEditing must be called before selections are cleared.
dom/Element.cpp: (WebCore::Element::blur): Call FocusController::setFocusNode instead of Document::setFocusNode, if possible.
page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent): Ditto.
page/FocusController.cpp: (WebCore::relinquishesEditingFocus): Moved from Document.cpp. (WebCore::clearSelectionIfNeeded): Ditto. Don't clear if the old selection is in a frame that's different than the one that contains the new focus node. (WebCore::FocusController::setFocusedNode): Moved code here from Document::setFocusedNode.
page/Frame.cpp: (WebCore::Frame::setFocusedNodeIfNeeded): Call FocusController::setFocusNode.

2:37 PM Changeset in webkit [21466] by spadma

2 edits in S60/trunk/WebKit

ligman, reviewed by Sachin

DESC: Inputbox callback gets canceled before it has a chance to run. Setting it's priority to EPriorityUserInput
http://bugs.webkit.org/show_bug.cgi?id=13714

BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::OkToExit):

2:36 PM Changeset in webkit [21465] by spadma

2 edits in S60/branches/3.1m/WebKit

ligman, reviewed by Sachin

DESC: Inputbox callback gets canceled before it has a chance to run. Setting it's priority to EPriorityUserInput
http://bugs.webkit.org/show_bug.cgi?id=13714

BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::OkToExit):

2:29 PM Changeset in webkit [21464] by ggaren

8 edits
2 adds
2 deletes in trunk

WebCore:

Reviewed by Darin Adler.

Next step toward fixing <rdar://problem/5055182> The back cache has no
global cap.

Created a PageCache singleton. Right now, it only handles the timer-based
deallocation of cached pages. I plan to add HistoryItem->CachedPage tracking
and eviction logic in later patches.

Updated for renames and file changes:

WebCore.exp:
WebCore.xcodeproj/project.pbxproj:
history/BackForwardList.cpp: (WebCore::BackForwardList::setPageCacheSize): (WebCore::BackForwardList::clearPageCache):

Removed global timed release code, moved into new PageCache class, since
it's eventually going to be in charge of deciding when things are released:

history/HistoryItem.cpp: (WebCore::HistoryItem::setCachedPage):
history/HistoryItem.h:

Folded into PageCache:

history/HistoryItemTimer.cpp: Removed.
history/HistoryItemTimer.h: Removed.

New singleton. Right now, it just handles timed release of cached pages:

history/PageCache.cpp: Added. (WebCore::pageCache): (WebCore::PageCache::PageCache): (WebCore::PageCache::autoreleaseNowOrReschedule): (WebCore::PageCache::autoreleaseNow): (WebCore::PageCache::autorelease):
history/PageCache.h: Added.

WebKit:

Reviewed by Darin Adler.

Updated for WebCore move to PageCache singleton. Also removed some WebCore: prefixes and replaced them with 'using namespace WebCore'.

History/WebHistoryItem.mm: (+[WebHistoryItem _releaseAllPendingPageCaches]): (-[WebWindowWatcher windowWillClose:]):

2:16 PM Changeset in webkit [21463] by adele

2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/5200081> Repro crash in PopupMenu::show clicking popup menu button after reload

platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Added call to dismissPopup so the cell gets unattached properly.

1:57 PM Changeset in webkit [21462] by adele

2 edits in trunk/WebCore

Reviewed by Darin.

Remove incorrect assertion.

page/FrameView.cpp: (WebCore::FrameView::setContentsPos):

1:43 PM Changeset in webkit [21461] by lars

2 edits
405 adds
6 deletes in trunk/LayoutTestResults

Add another 1000 tests that we pass for the Qt build.

12:20 PM Changeset in webkit [21460] by lars

284 edits
21 adds
9 deletes in trunk/LayoutTestResults

Add another 300 test cases, that are ok on the Qt build.
Add a few more tests that need examination to the Skipped list.

12:05 PM Changeset in webkit [23363] by andersca

3 edits in branches/WindowsMerge/WebCore

Reviewed by Geoff.

<rdar://problem/5176940> Seed10: MS Silverlight 1.0 beta plug-in is not supported

plugins/win/PluginDatabaseWin.cpp: (WebCore::addPluginsFromRegistry): New function that adds plugins from the registry from HKEY_LOCAL_MACHINE/MozillaPlugins.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::invalidateRect): (WebCore::PluginViewWin::forceRedraw): Make these work with windowed plugins.

11:53 AM Changeset in webkit [21459] by andersca

2 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/5172056> Regression: cannot open txt file, get broken image

Never let plug-ins override text/plain.

dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):

9:34 AM Changeset in webkit [23362] by aroben

2 edits in branches/WindowsMerge/WebKitTools

Build fix.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h:

8:34 AM Changeset in webkit [21458] by spadma

4 edits in S60/branches/3.1m/WebKit

hongzhao, reviewed by <Sachin>

DESC: [S60] Open to viewer option doesn't work in browser in video content.
http://bugs.webkit.org/show_bug.cgi?id=13648

Plugin/inc/PluginWin.h:
Plugin/src/PluginSkin.cpp: (CPluginSkin::ConstructL):
Plugin/src/PluginWin.cpp: (CPluginWin::SetTopUrlL):

8:33 AM Changeset in webkit [21457] by spadma

4 edits in S60/trunk/WebKit

hongzhao, reviewed by <Sachin>

DESC: [S60] Open to viewer option doesn't work in browser in video content.
http://bugs.webkit.org/show_bug.cgi?id=13648

Plugin/inc/PluginWin.h:
Plugin/src/PluginSkin.cpp: (CPluginSkin::ConstructL):
Plugin/src/PluginWin.cpp: (CPluginWin::SetTopUrlL):

7:39 AM Changeset in webkit [21456] by zack

2 edits in trunk/WebCore

Fix dependcy tracking in project files.

Add dependpath to project to get better dependency tracking for header
files in the qmake project files.

r=simon

6:41 AM Changeset in webkit [21455] by lars

10 edits in trunk

Reviewed by Zack

Updates after Maciej's frame change.

This gets things to run again. The #ifdef PLATFORM(QT)
in the FrameLoader should not be needed (and adding the line
inside on the mac doesn't seem to trigger any failures there).
I'm submitting with it to be on the safe side for now, since I
really need our tests to run again.

Btw, post-commit-linux-qt should show up green on with this submit :))

6:30 AM Changeset in webkit [21454] by darin

6 edits in trunk/WebCore

Reviewed by Antti.

fix <rdar://problem/3109180> VIP: after go back, page jumps after loading even if I scrolled while loading

history/CachedPage.cpp: (WebCore::CachedPage::clear): Call clearFrame rather than clearPart -- the "part" term was leftover prehistoric terminology.

loader/FrameLoader.cpp: (WebCore::FrameLoader::open): Call setWasScrolledByUser(false) on the page, so that we can detect any user scrolling that happens during the "go back" process. (WebCore::FrameLoader::restoreScrollPositionAndViewState): Don't scroll if the view's wasScrolledByUser flag is set. (WebCore::FrameLoader::loadItem): Call setWasScrolledByUser(false) false when we do a new "load" (actually just a scroll) using the same frame. Also moved the line of code that sets m_currentHistoryItem to make this code path mroe similar to recursiveGoToItem. (WebCore::FrameLoader::recursiveGoToItem): Ditto.

page/Frame.cpp: (WebCore::Frame::~Frame): Call clearFrame rather than stting m_frame directly. (WebCore::Frame::sendScrollEvent): Call setWasScrolledByUser(true) on FrameView. The FrameView itself knows to ignore this if the scrolling is being done programmatically instead of by the user.

page/FrameView.h: Added wasScrolledByUser and setWasScrolledByUser. Also removed unneeded include and class forward declarations, renamed clearPart to clearFrame, removed uneeded function haveDelayedLayoutScheduled, and removed unneeded friend declarations.
page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Added m_inProgrammaticScroll and m_wasScrolledByUser. (WebCore::FrameViewPrivate::reset): Set m_wasScrolledByUser to false. (WebCore::FrameView::clearFrame): Renamed from clearPart. (WebCore::FrameView::scrollRectIntoViewRecursively): Added code to set the m_inProgrammaticScroll flag. (WebCore::FrameView::setContentsPos): Ditto. (WebCore::FrameView::wasScrolledByUser): Added. (WebCore::FrameView::setWasScrolledByUser): Added. Does nothing if called when m_inProgrammaticScroll is true.

6:26 AM Changeset in webkit [21453] by darin

3 edits in trunk/LayoutTests

2007-05-14 Kimmo Kinnunen <Kimmo Kinnunen>

Tests for http://bugs.webkit.org/show_bug.cgi?id=10878
Bug 10878: Incorrect decompilation for "4..x"

Test all the different forms of expressions that can contain
a dot following a number literal.
Includes new tests for PrefixDotNode, PostfixDotNode, DeleteDotNode,
AssignDotNode and FunctionCallParenDotNode.

fast/js/resources/toString-number-dot-expr.js:
fast/js/toString-number-dot-expr-expected.txt: Updated.

6:13 AM Changeset in webkit [23361] by andersca

2 edits in branches/WindowsMerge/WebKitWin

6:12 AM Changeset in webkit [21452] by darin

2 edits in trunk/WebCore

Reviewed by Antti.

<rdar://problem/4865655> REGRESSION: find function does not work for the character ß

The trick was to fold case consistently in the CircularSearchBuffer class.

The problem was that we were folding the search target string with full case folding and
the characters of the text we were searching with simple case folding. We now use full
case folding in both cases.

editing/TextIterator.cpp: (WebCore::CircularSearchBuffer::CircularSearchBuffer): Changed the buffer to be a Vector<UChar>. Added a Vector<bool> to record which characters were starts of characters in the text we are searching. Changed the cursor to be an int rather than a pointer. (WebCore::CircularSearchBuffer::append): New function that knows how to append multiple characters when folding case turns one character into many -- uses the full foldCase rather than the simplified single-character foldCase. Also removed the append function that did multiple characters at once; that was part of an optimization we don't need. (WebCore::CircularSearchBuffer::isMatch): Instead of asserting that the buffer is full, changed this to return false if it's not full, which lets us fill up the buffer with the normal loop. Also return false if the start of the buffer is half-way through a case-folded character and updated this since m_cursor is now an integer. (WebCore::CircularSearchBuffer::length): This returns the length in non-case-folded characters of the characters that were appended, which may not be the same as the length of the original target string. To do that we have to total up the character start booleans for the current state of the circular buffer. (WebCore::findPlainText): Streamlined the logic in a few ways: 1) Moved more of the return value setup to the top of the function so it could be shared with the early error exit. 2) Removed the separate "fill the buffer" logic, which allowed me to remove some of the functions from CircularSearchBuffer and eliminated the need for two nested loops. 3) Replaced the CharacterIterator and bool that were used to record the location we found with integers matchStart and matchLength. 4) Got rid of the use of goto since we don't have two nested loops any more.

5:16 AM Changeset in webkit [21451] by andrew