⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 16, 2007:

11:52 PM Changeset in webkit [21528] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

<rdar://problem/5205914> REGRESSION: PLT stops after loading first page due to r21479


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::frameHasLoaded):
11:28 PM Changeset in webkit [21527] by hyatt
  • 1 edit in trunk/LayoutTests/fast/frames/viewsource-attribute-expected.txt

Update the lone view source mode layout test.

11:27 PM Changeset in webkit [21526] by hyatt
  • 5 edits in trunk/WebCore

Improve the syntax-highlighted view source mode. It now preserves all whitespace properly
and highlights doctypes and comments (in addition to all the stuff it could highlight before).

Reviewed by aroben

  • html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute): (WebCore::HTMLTokenizer::parseTag):
  • html/HTMLTokenizer.h: (WebCore::Token::Token): (WebCore::Token::~Token): (WebCore::Token::reset): (WebCore::Token::addViewSourceChar):
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken):
  • html/HTMLViewSourceDocument.h:
10:37 PM Changeset in webkit [21525] by beidson
  • 2 edits in trunk/WebKitTools

Build fix for some dev configurations

  • DumpRenderTree/DumpRenderTree.m:
9:47 PM Changeset in webkit [21524] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5191024> Page never loads completely (emonome.vodpod.com)
<rdar://problem/5205162> REGRESSION (r21367): In the Address URL field, typing a site name doesn't redirect to site after pressing return
​http://bugs.webkit.org/show_bug.cgi?id=13683
<rdar://problem/5208951> REGRESSION: Progress bar never completes on link click that downloads (13694)
​http://bugs.webkit.org/show_bug.cgi?id=13694
<rdar://problem/5201598> REGRESSION: After uploading file to iDisk at mac.com, "loading" status remains and file does not appear in the list


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::mainReceivedCompleteError): Make sure to always check whether the overall load completed, even if we think the current frame load is already complete.
9:21 PM Changeset in webkit [21523] by mjs
  • 9 edits
    13 adds in trunk

LayoutTests:

Reviewed by Justin.


  • added a bunch of layout tests using the new load delegate testing mechanism
  • http/tests/loading/bad-scheme-subframe-expected.txt: Added.
  • http/tests/loading/bad-scheme-subframe.html: Added.
  • http/tests/loading/bad-server-subframe-expected.txt: Added.
  • http/tests/loading/bad-server-subframe.html: Added.
  • http/tests/loading/basic-expected.txt: Added.
  • http/tests/loading/basic.html: Added.
  • http/tests/loading/empty-subframe-expected.txt: Added.
  • http/tests/loading/empty-subframe.html: Added.
  • http/tests/loading/simple-subframe-expected.txt: Added.
  • http/tests/loading/simple-subframe.html: Added.

WebKitTools:

Reviewed by Justin.


  • created a new mechanism to log FrameLoadDelegate callbacks in directories named "loading"


The reason for doing things in this slightly odd way is to make sure we don't miss the load delegates
that happen before the load commits.


Basically I moved WaitUntilDoneDelegate into a separate file (FrameLoadDelegate.m) and added
optional logging for every FrameLoadDelegate callback, including SPI callbacks.

  • DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/DumpRenderTree.m: (createWebView): (dumpRenderTree): (dump): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController clearBackForwardList]): (-[LayoutTestController setUseDashboardCompatibilityMode:]): (-[LayoutTestController dumpFrameLoadCallbacks]): (-[LayoutTestController setWindowIsKey:]): (-[LayoutTestController setMainFrameIsFirstResponder:]): (-[LayoutTestController _doLoad:target:]): (-[LayoutTestController _doBackOrForwardNavigation:]): (-[LayoutTestController queueReload]): (-[LayoutTestController queueScript:]): (-[LayoutTestController queueLoad:target:]): (-[LayoutTestController setAcceptsEditing:]): (-[LayoutTestController setTabKeyCyclesThroughElements:]): (shouldLogFrameLoadDelegates): (runTest): (displayWebView): (+[DumpRenderTreeEvent mouseLocation]):
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/DumpRenderTreeDraggingInfo.m: (-[DumpRenderTreeDraggingInfo draggingDestinationWindow]):
  • DumpRenderTree/EventSendingController.m: (-[EventSendingController mouseDown]): (-[EventSendingController mouseUp]): (-[EventSendingController mouseMoveToX:Y:]): (-[EventSendingController contextClick]):
  • DumpRenderTree/FrameLoadDelegate.h: Added.
  • DumpRenderTree/FrameLoadDelegate.m: Added. (-[WebFrame _drt_descriptionSuitableForTestResult]): (-[FrameLoadDelegate processWork:]): (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): (-[FrameLoadDelegate webView:didCommitLoadForFrame:]): (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]): (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]): (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]): (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]): (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]): (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]): (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]): (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]): (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]): (-[FrameLoadDelegate webView:willCloseFrame:]): (-[FrameLoadDelegate webView:didFirstLayoutInFrame:]): (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]): (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
  • DumpRenderTree/ResourceLoadDelegate.m: (-[NSURL _drt_descriptionSuitableForTestResult]):
  • DumpRenderTree/UIDelegate.m: (-[UIDelegate webViewFocus:]):
5:34 PM Changeset in webkit [23372] by adele
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Hyatt.

Fix for:

<rdar://problem/5092645> PopupMenuWin needs bidiReorderCharacters logic from RenderListBox
<rdar://problem/5205654> Select popup menus should always be ltr to match the mac

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): Remove special cases for RTL menus, since we are always going to left align. (WebCore::PopupMenu::calculatePositionAndSize): ditto. (WebCore::PopupMenu::paint): Added call to bidiReorderCharacters.
2:47 PM Changeset in webkit [21522] by bdakin
  • 15 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Changes for <rdar://problem/5204107> REGRESSION: CSS web forum site
layout not displaying properly in latest WebKit

New test:

  • fast/table/tableInsideCaption-expected.checksum: Added.
  • fast/table/tableInsideCaption-expected.png: Added.
  • fast/table/tableInsideCaption-expected.txt: Added.
  • fast/table/tableInsideCaption.html: Added.


Good changes.

  • tables/mozilla/bugs/bug48028-1-expected.checksum:
  • tables/mozilla/bugs/bug48028-1-expected.png:
  • tables/mozilla/bugs/bug48028-1-expected.txt:
  • tables/mozilla_expected_failures/core/captions1- expected.checksum:
  • tables/mozilla_expected_failures/core/captions1-expected.png:
  • tables/mozilla_expected_failures/core/captions1-expected.txt:

Not great changes. These changes expose other bugs. Filing reports
for these.

  • tables/mozilla/bugs/bug48028-2-expected.txt:
  • tables/mozilla/bugs/bug55789-expected.checksum:
  • tables/mozilla/bugs/bug55789-expected.png:
  • tables/mozilla/bugs/bug55789-expected.txt:

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/5204107> REGRESSION: CSS web forum site
layout not displaying properly in latest WebKit

Hyatt's ​http://trac.webkit.org/projects/webkit/changeset/21428
exposed this bug. We were not handling error cases with <caption>
correctly. This patch makes them do the same thing as colgroup.

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
  • html/HTMLParserErrorCodes.cpp: No need any more for caption- specific errors. (WebCore::htmlParserErrorMessageTemplate):
  • html/HTMLParserErrorCodes.h: (WebCore::):
2:30 PM Changeset in webkit [23371] by kmccullo
  • 2 edits in branches/WindowsMerge/LayoutTests

Reviewed by .

  • win/Skipped: Added a new test that requires DRT to be able to handle multiple windows.
1:57 PM Changeset in webkit [21521] by kmccullo
  • 7 edits in trunk

LayoutTests:

Reviewed by Darin and Geoff.

  • rdar://problem/4981886
  • Added tests for allowing JS to close a window that was opened by the DOM.
  • fast/dom/open-and-close-by-DOM-expected.txt: Added.
  • fast/dom/open-and-close-by-DOM.html: Added.
  • fast/dom/resources/close.html: Added.
  • fast/dom/resources/middle.html: Added.

WebCore:

Reviewed by Darin and Geoff.

  • rdar://problem/4981886
  • Now windows opened by the DOM can be closed by JS.
  • bindings/js/kjs_window.cpp: (KJS::createNewWindow): (KJS::WindowFunc::callAsFunction):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::openedByDOM): (WebCore::FrameLoader::setOpenedByDOM): (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
  • loader/FrameLoader.h:

WebKitTools:

Reviewed by Darin and Geoff.

  • rdar://problem/4981886
  • Now windows opened by the DOM can be closed by JS.
  • DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController windowCount]):
1:15 PM Changeset in webkit [21520] by darin
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • test for <rdar://problem/4928671> Crash due to runaway recursion when fieldset has display: table-row (12066)
  • fast/css/fieldset-display-row-expected.checksum: Added.
  • fast/css/fieldset-display-row-expected.png: Added.
  • fast/css/fieldset-display-row-expected.txt: Added.
  • fast/css/fieldset-display-row.html: Added.

WebCore:

Reviewed by Hyatt.

  • fix <rdar://problem/4928671> Crash due to runaway recursion when fieldset has display: table-row (12066)

Test: fast/css/fieldset-display-row.html

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::addChild): Change all decision making about special handling for new children to use the class of the render object instead of the style, except for the cases where the style is the only way to tell (TABLE_COLUMN_GROUP and TABLE_CAPTION). Thus a RenderFieldset with table-row style won't get handled as if it was a table row.
  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Same thing. Except that here the styles that we ahave to look at are TABLE_CAPTION, TABLE_HEADER_GROUP, TABLE_FOOTER_GROUP, and TABLE_ROW_GROUP.
12:53 PM Changeset in webkit [21519] by spadma
  • 3 edits in S60/trunk/WebKit

ligman, reviewed by Sachin

DESC: Remove unused iIsVisible flag. Default return ETrue from CPluginSkin::IsVisible call, so placeholder can be selected for audio download.
​http://bugs.webkit.org/show_bug.cgi?id=13749

  • Plugin/inc/PluginSkin.h:
  • Plugin/src/PluginSkin.cpp: (CPluginSkin::IsVisible):
12:52 PM Changeset in webkit [21518] by spadma
  • 3 edits in S60/branches/3.1m/WebKit

ligman, reviewed by Sachin

DESC: Remove unused iIsVisible flag. Default return ETrue from CPluginSkin::IsVisible call, so placeholder can be selected for audio download.
​http://bugs.webkit.org/show_bug.cgi?id=13749

  • Plugin/inc/PluginSkin.h:
  • Plugin/src/PluginSkin.cpp: (CPluginSkin::IsVisible):
6:53 AM Changeset in webkit [21517] by zack
  • 5 edits in trunk/WebCore

Implement Canvas element in the Qt port.

Implementation of Context2D was completely missing in the
Qt port. This commit adds bigger parts of it.
r=Lars

6:50 AM Changeset in webkit [21516] by zack
  • 2 edits in trunk/WebCore

Fix shared timers.

Make the timers correctly use miliseconds. Based on a patch
from George.

4:12 AM Changeset in webkit [21515] by lars
  • 2 edits in trunk/WebKitQt

Reviewed by Zack

pass the mouse events to the event handler, not the frameview.

4:05 AM Changeset in webkit [21514] by lars
  • 2 edits in trunk/LayoutTestResults

Update layout tests for error handling changes.

2:25 AM Changeset in webkit [21513] by hyatt
  • 1 edit in trunk/LayoutTests/fast/dom/delete-contents-expected.txt

Update layout tests for error handling changes.

1:47 AM Changeset in webkit [21512] by hyatt
  • 1 edit in trunk/WebCore/WebCore.pro

Fix Qt build.

1:22 AM Changeset in webkit [23370] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/WebCore.vcproj/WebCore.vcproj

Add new HTMLParserErrorCodes files.

1:11 AM Changeset in webkit [21511] by hyatt
  • 5 edits
    2 adds in trunk/WebCore

Add rudimentary error reporting to the HTML parser. This is disabled
for now until it gets beefed up a bit more (and until we work out how
best to pass the messages up without hurting perf).

Clean up and remove dead error handling code and incorrect error handling
code as well.

Reviewed by mjs

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser): (WebCore::HTMLParser::handleError): (WebCore::HTMLParser::headCreateErrorCheck): (WebCore::HTMLParser::reportErrorToConsole):
  • html/HTMLParser.h: (WebCore::HTMLParser::reportError):
  • html/HTMLParserErrorCodes.cpp: Added. (WebCore::htmlParserErrorMessageTemplate):
  • html/HTMLParserErrorCodes.h: Added. (WebCore::):
  • html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::tagStartLineNumber):

May 15, 2007:

11:22 PM Changeset in webkit [21510] by hyatt
  • 2 edits in trunk/WebCore

Make FrameLoader write "<html><body>" instead of just "<body>".

Reviewed by aroben

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::init):
10:04 PM Changeset in webkit [21509] by staikos
  • 1 edit in trunk/WebCore/ChangeLog

repair changelog

9:47 PM Changeset in webkit [21508] by staikos
  • 2 edits in trunk/WebCore

Make the loader pass cookies through

9:25 PM Changeset in webkit [21507] by staikos
  • 2 edits in trunk/WebCore

2007-05-15 Adam Treat <​adam@staikos.net>

Reviewed by George Staikos.

  • Implement drawArc with proper units.
9:19 PM Changeset in webkit [21506] by staikos
  • 2 edits in trunk/WebCore

2007-05-15 Adam Treat <​adam@staikos.net>

Reviewed by George Staikos.

  • Add missing paint for nested subframes.
8:35 PM Changeset in webkit [21505] by weinig
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Oliver.

Tests for SVG attributes that take a DOMString.

  • fast/dom/svg-element-attribute-js-null-expected.txt: Added.
  • fast/dom/svg-element-attribute-js-null.xhtml: Added.

WebCore:

Reviewed by Oliver.

Convert JS null to null string for SVG attributes.

Test: fast/dom/svg-element-attribute-js-null.xhtml

  • ksvg2/svg/SVGAngle.idl:
  • ksvg2/svg/SVGElement.idl:
  • ksvg2/svg/SVGLength.idl:
  • ksvg2/svg/SVGScriptElement.idl:
8:24 PM Changeset in webkit [21504] by weinig
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Oliver.

Tests for CanvasRenderingContext2D attributes that take a DOMString.

  • fast/dom/canvasContext2d-element-attribute-js-null-expected.txt: Added.
  • fast/dom/canvasContext2d-element-attribute-js-null.html: Added.

WebCore:

Reviewed by Oliver.

Convert JS null to null string for CanvasRenderingContext2D attributes.

Test: fast/dom/canvasContext2d-element-attribute-js-null.html

  • html/CanvasRenderingContext2D.idl:
7:57 PM Changeset in webkit [21503] by oliver
  • 6 edits in trunk

2007-05-15 Oliver Hunt <​oliver@apple.com>

WebCore:

Reviewed by Sam and Geoff.

Removing dead code left behind from drag and drop refactoring.

  • page/mac/WebCoreFrameBridge.h:

WebKit:

Reviewed by Sam and Geoff.


Removing dead code left behind from drag and drop refactoring.

  • WebCoreSupport/WebFrameBridge.mm:
  • WebView/WebHTMLView.mm:
  • WebView/WebHTMLViewPrivate.h:
7:22 PM Changeset in webkit [21502] by weinig
  • 9 edits
    2 adds in trunk

LayoutTests:

Reviewed by Oliver.

Tests for CSSOM attributes that take a DOMString.

  • fast/dom/css-element-attribute-js-null-expected.txt: Added.
  • fast/dom/css-element-attribute-js-null.html: Added.

WebCore:

Reviewed by Oliver.

Convert JS null to null string for remaining CSSOM attributes.

Test: fast/dom/css-element-attribute-js-null.html

  • bindings/js/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::put): (KJS::DOMMediaList::put): (KJS::DOMCSSRule::putValueProperty): (KJS::DOMCSSValue::put):
  • css/CSSPageRule.idl:
  • css/CSSRule.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleRule.idl:
  • css/CSSValue.idl:
  • css/MediaList.idl:
5:44 PM Changeset in webkit [23369] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-05-15 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin, Oliver.


  • WebLocalizableStrings.cpp: (WebLocalizedString): Make failure to load a localized string slightly less fatal
4:35 PM Changeset in webkit [21501] by aroben
  • 2 edits in trunk/WebKitTools

Reviewed by David Kilzer.

​http://bugs.webkit.org/show_bug.cgi?id=13732
prepare-ChangeLog should work with git

  • Scripts/prepare-ChangeLog: Added support for Git.
4:19 PM Changeset in webkit [21500] by bdash
  • 2 edits in trunk/WebKit

2007-05-15 Bruce Q Hammond <​bruceq@apple.com>

Reviewed by Darin.

Correction of previous patch for ​http://bugs.webkit.org/show_bug.cgi?id=13578
This corrects the sign of the Y-Axis origin adjustment.

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
4:15 PM Changeset in webkit [23368] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-05-15 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin.


<rdar://problem/4956541> Need to implement preference for how much History is maintained

  • WebHistory.cpp: (WebHistory::ageLimitDate): Remove extra +30 from history age in days.
3:35 PM Changeset in webkit [21499] by justing
  • 95 edits in trunk/LayoutTests

Updating expected results for r21074.

  • css1/cascade/cascade_order-expected.checksum:
  • css1/cascade/cascade_order-expected.png:
  • css2.1/t0402-c71-fwd-parsing-02-f-expected.checksum:
  • css2.1/t0402-c71-fwd-parsing-02-f-expected.png:
  • css2.1/t0505-c16-descendant-01-e-expected.checksum:
  • css2.1/t0505-c16-descendant-01-e-expected.png:
  • css2.1/t050803-c14-classes-00-e-expected.checksum:
  • css2.1/t050803-c14-classes-00-e-expected.png:
  • css2.1/t0509-c15-ids-01-e-expected.checksum:
  • css2.1/t0509-c15-ids-01-e-expected.png:
  • css2.1/t0805-c5518-brdr-t-01-e-expected.checksum:
  • css2.1/t0805-c5518-brdr-t-01-e-expected.png:
  • css2.1/t0805-c5519-brdr-r-02-e-expected.checksum:
  • css2.1/t0805-c5519-brdr-r-02-e-expected.png:
  • css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
  • css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • css2.1/t0805-c5521-brdr-l-02-e-expected.checksum:
  • css2.1/t0805-c5521-brdr-l-02-e-expected.png:
  • css2.1/t1205-c563-list-type-00-b-expected.checksum:
  • css2.1/t1205-c563-list-type-00-b-expected.png:
  • css2.1/t1205-c564-list-img-00-b-g-expected.checksum:
  • css2.1/t1205-c564-list-img-00-b-g-expected.png:
  • fast/backgrounds/repeat/noRepeatCorrectClip-expected.checksum:
  • fast/backgrounds/repeat/noRepeatCorrectClip-expected.png:
  • fast/block/float/014-expected.checksum:
  • fast/block/float/014-expected.png:
  • fast/css/001-expected.checksum:
  • fast/css/001-expected.png:
  • fast/css/css2-system-fonts-expected.checksum:
  • fast/css/css2-system-fonts-expected.png:
  • fast/doctypes/001-expected.checksum:
  • fast/doctypes/001-expected.png:
  • fast/doctypes/002-expected.checksum:
  • fast/doctypes/002-expected.png:
  • fast/doctypes/003-expected.checksum:
  • fast/doctypes/003-expected.png:
  • fast/doctypes/004-expected.checksum:
  • fast/doctypes/004-expected.png:
  • fast/dom/Window/window-onFocus-expected.checksum:
  • fast/dom/Window/window-onFocus-expected.png:
  • fast/events/keydown-1-expected.checksum:
  • fast/events/keydown-1-expected.png:
  • fast/lists/002-expected.checksum:
  • fast/lists/002-expected.png:
  • fast/lists/003-expected.checksum:
  • fast/lists/003-expected.png:
  • fast/lists/005-expected.checksum:
  • fast/lists/005-expected.png:
  • fast/lists/007-expected.checksum:
  • fast/lists/007-expected.png:
  • fast/lists/008-expected.checksum:
  • fast/lists/008-expected.png:
  • fast/lists/big-list-marker-expected.checksum:
  • fast/lists/big-list-marker-expected.png:
  • fast/lists/dynamic-marker-crash-expected.checksum:
  • fast/lists/dynamic-marker-crash-expected.png:
  • fast/lists/item-not-in-list-line-wrapping-expected.checksum:
  • fast/lists/item-not-in-list-line-wrapping-expected.png:
  • fast/lists/marker-image-error-expected.checksum:
  • fast/lists/marker-image-error-expected.png:
  • fast/lists/ol-display-types-expected.checksum:
  • fast/lists/ol-display-types-expected.png:
  • fast/lists/scrolled-marker-paint-expected.checksum:
  • fast/lists/scrolled-marker-paint-expected.png:
  • fast/overflow/overflow-rtl-expected.checksum:
  • fast/overflow/overflow-rtl-expected.png:
  • fast/repaint/list-marker-2-expected.checksum:
  • fast/repaint/list-marker-2-expected.png:
  • fast/repaint/list-marker-expected.checksum:
  • fast/repaint/list-marker-expected.png:
  • fast/selectors/001-expected.checksum:
  • fast/selectors/001-expected.png:
  • fast/selectors/013-expected.checksum:
  • fast/selectors/013-expected.png:
  • fast/selectors/015-expected.checksum:
  • fast/selectors/015-expected.png:
  • fast/selectors/166-expected.checksum:
  • fast/selectors/166-expected.png:
  • tables/mozilla/bugs/bug23235-expected.checksum:
  • tables/mozilla/bugs/bug23235-expected.png:
  • tables/mozilla/bugs/bug30692-expected.checksum:
  • tables/mozilla/bugs/bug30692-expected.png:
  • tables/mozilla/bugs/bug3191-expected.checksum:
  • tables/mozilla/bugs/bug3191-expected.png:
  • tables/mozilla/marvin/backgr_index-expected.checksum:
  • tables/mozilla/marvin/backgr_index-expected.png:
  • tables/mozilla/marvin/backgr_layers-opacity-expected.checksum:
  • tables/mozilla/marvin/backgr_layers-opacity-expected.png:
  • tables/mozilla_expected_failures/bugs/bug1010-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug1010-expected.png:
  • tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.checksum:
  • tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png:
3:19 PM Changeset in webkit [21498] by darin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

  • css/html4.css: Remove wbr style rule -- not needed any more.
3:03 PM Changeset in webkit [21497] by beidson
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Brady

  • http/tests/misc/multipart-expected.txt: Added.
  • http/tests/misc/multipart.html: Added.
  • http/tests/misc/resources/1x1-blue.png: Added.
  • http/tests/misc/resources/multipart.php: Added.

WebCore:

Reviewed by Brady

Test: http/tests/misc/multipart.html

  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didFail): Avoid calling didFailToLoad() if didFinishLoad() has already been called (when the first part of a multipart resource arrived). (WebCore::ResourceLoader::didCancel): Ditto.
2:42 PM Changeset in webkit [21496] by bdash
  • 1 copy in tags/Safari-4522.8

New tag.

2:39 PM Changeset in webkit [21495] by bdash
  • 4 edits in branches/Safari-522

Versioning.

12:04 PM Changeset in webkit [21494] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Adele Peterson.


It helps if you swap the right variable.

  • wtf/HashSet.h: (WTF::::operator):
11:21 AM Changeset in webkit [21493] by spadma
  • 2 edits in S60/trunk/WebKit

2007-05-15 spadma

Reviewed by Zalan.
DESC: [S60] User cannot detach from flash object after the object uses connection
​http://bugs.webkit.org/show_bug.cgi?id=13731

  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::FinalProgressComplete):
11:20 AM Changeset in webkit [21492] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-05-15 spadma

Reviewed by Zalan.
DESC: [S60] User cannot detach from flash object after the object uses connection
​http://bugs.webkit.org/show_bug.cgi?id=13731

  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::FinalProgressComplete):
11:11 AM Changeset in webkit [21491] by spadma
  • 2 edits in S60/trunk/WebCore

2007-05-15 spadma

Reviewed by Zalan.
DESC: Browser panics when trying to log into www.luukku.com
​http://bugs.webkit.org/show_bug.cgi?id=13733
TSW ID: MLIO-7349EQ
WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::submitForm):
11:10 AM Changeset in webkit [21490] by spadma
  • 2 edits in S60/branches/3.1m/WebCore

2007-05-15 spadma

Reviewed by Zalan.
DESC: Browser panics when trying to log into www.luukku.com
​http://bugs.webkit.org/show_bug.cgi?id=13733
TSW ID: MLIO-7349EQ
WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::submitForm):
10:53 AM Changeset in webkit [21489] by weinig
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

Tests for Core DOM attributes.

  • fast/dom/coreDOM-element-attribute-js-null-expected.txt: Added.
  • fast/dom/coreDOM-element-attribute-js-null.xhtml: Added.

WebCore:

Reviewed by Darin.

Convert JS null to null string for remaining Core DOM attributes.

Test: fast/dom/coreDOM-element-attribute-js-null.xhtml

  • dom/Attr.cpp: (WebCore::Attr::setValue): Don't throw an expection for null values as this is not in the spec and Firefox does not do it either.
  • dom/Attr.idl:
  • dom/CharacterData.idl:
  • dom/ProcessingInstruction.idl:
10:50 AM Changeset in webkit [21488] by sfalken
  • 6 edits in branches/Safari-522/WebCore

Merged fix from r21227.

9:47 AM Changeset in webkit [21487] by ggaren
  • 7 edits
    2 deletes in trunk/WebKit

Reviewed by Maciej Stachowiak.


Patch: fixed <rdar://problem/5198890> .5% performance regression caused
by r21307


The only code r21307 added that runs during the PLT is a frame load delegate
-respondsToSelector: call inside windowObjectCleared(), so it seems like
our message dispatch overhead for the frame load delegate is significant.


This patch is a straight port of Maciej's fix for the same problem in the
resource load delegate. The solution is simple enough: don't use Objective-C.
Instead, use a special structure that caches which methods the delegate
implements, along with pointers to those methods.


I verified each frame load delegate callback in the debugger, except for
-webView:didFailLoadWithError:forFrame:, which is not implemented by Safari
or DumpRenderTree.

  • WebKit/DefaultDelegates/WebDefaultFrameLoadDelegate.h: Removed.
  • WebKit/DefaultDelegates/WebDefaultFrameLoadDelegate.m: Removed.
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge windowObjectCleared]): I also removed a misleading comment here. The JS debugger caches the windowScriptObject, so you do need to re-create the debugger every time you invalidate the old WebScriptObject wrapper for the window object and create a new one, or the debugger will stop working. We could fix this in a number of ways, but <rdar://problem/4608404> is not the key issue.
7:38 AM Changeset in webkit [21486] by lars
  • 2 edits in trunk/LayoutTestResults

Update test result now that we have the eventSender object.

6:40 AM Changeset in webkit [21485] by lars
  • 10 edits
    1 add in trunk

Extend the QObject JavaScript bindings to work for slots with
arguments.

Add the EventSender object to DRT. Currently it implements
mouseDown, mouseUp and mouseMoveTo.

Make run-webkit-tests --strict work somewhat better for form elements.

one more test passing for Qt, the first one that uses
the eventSender in DRT.

5:45 AM Changeset in webkit [21484] by justing
  • 67 edits in trunk/LayoutTests

Updating expected results for r21074.

  • editing/deleting/4866671-expected.checksum:
  • editing/deleting/4866671-expected.png:
  • editing/deleting/delete-first-list-item-expected.checksum:
  • editing/deleting/delete-first-list-item-expected.png:
  • editing/deleting/delete-listitem-002-expected.checksum:
  • editing/deleting/delete-listitem-002-expected.png:
  • editing/deleting/list-item-1-expected.checksum:
  • editing/deleting/list-item-1-expected.png:
  • editing/deleting/merge-into-empty-block-2-expected.checksum:
  • editing/deleting/merge-into-empty-block-2-expected.png:
  • editing/execCommand/4641880-1-expected.checksum:
  • editing/execCommand/4641880-1-expected.png:
  • editing/execCommand/4747450-expected.checksum:
  • editing/execCommand/4747450-expected.png:
  • editing/execCommand/4916402-expected.checksum:
  • editing/execCommand/4916402-expected.png:
  • editing/execCommand/4916583-expected.checksum:
  • editing/execCommand/4916583-expected.png:
  • editing/execCommand/5142012-2-expected.checksum:
  • editing/execCommand/5142012-2-expected.png:
  • editing/execCommand/5144139-1-expected.checksum:
  • editing/execCommand/5144139-1-expected.png:
  • editing/execCommand/create-list-with-hr-expected.checksum:
  • editing/execCommand/create-list-with-hr-expected.png:
  • editing/execCommand/indent-list-item-expected.checksum:
  • editing/execCommand/indent-list-item-expected.png:
  • editing/execCommand/indent-selection-expected.checksum:
  • editing/execCommand/indent-selection-expected.png:
  • editing/execCommand/insert-list-empty-div-expected.checksum:
  • editing/execCommand/insert-list-empty-div-expected.png:
  • editing/execCommand/remove-list-item-1-expected.checksum:
  • editing/execCommand/remove-list-item-1-expected.png:
  • editing/inserting/4959067-expected.checksum:
  • editing/inserting/4959067-expected.png:
  • editing/pasteboard/4861080-expected.checksum:
  • editing/pasteboard/4861080-expected.png:
  • editing/pasteboard/drag-selected-image-to-contenteditable-expected.checksum:
  • editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
  • editing/pasteboard/drop-link-expected.checksum:
  • editing/pasteboard/drop-link-expected.png:
  • editing/pasteboard/innerText-inline-table-expected.checksum:
  • editing/pasteboard/innerText-inline-table-expected.png:
  • editing/pasteboard/input-field-1-expected.checksum:
  • editing/pasteboard/input-field-1-expected.png:
  • editing/pasteboard/merge-end-list-expected.checksum:
  • editing/pasteboard/merge-end-list-expected.png:
  • editing/pasteboard/merge-start-list-expected.checksum:
  • editing/pasteboard/merge-start-list-expected.png:
  • editing/pasteboard/select-element-1-expected.checksum:
  • editing/pasteboard/select-element-1-expected.png:
  • editing/selection/drag-to-contenteditable-iframe-expected.checksum:
  • editing/selection/drag-to-contenteditable-iframe-expected.png:
  • editing/selection/extend-by-word-002-expected.checksum:
  • editing/selection/extend-by-word-002-expected.png:
  • editing/selection/select-all-iframe-expected.checksum:
  • editing/selection/select-all-iframe-expected.png:
  • editing/selection/selectNode-expected.checksum:
  • editing/selection/selectNode-expected.png:
  • editing/selection/selectNodeContents-expected.checksum:
  • editing/selection/selectNodeContents-expected.png:
  • editing/unsupported-content/list-delete-001-expected.checksum:
  • editing/unsupported-content/list-delete-001-expected.png:
  • editing/unsupported-content/list-type-after-expected.checksum:
  • editing/unsupported-content/list-type-after-expected.png:
  • editing/unsupported-content/list-type-before-expected.checksum:
  • editing/unsupported-content/list-type-before-expected.png:
3:00 AM Changeset in webkit [21483] by andrew
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): Moved the code that clears the selection when moving a selection border into the fast path.
2:31 AM Changeset in webkit [21482] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

​http://bugs.webkit.org/show_bug.cgi?id=6487
"Make Text Bigger/Smaller" affects SVGs when it probably shouldn't

Ignore Make Text Bigger/Smaller for SVG text.

2:28 AM Changeset in webkit [21481] by andersca
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

<rdar://problem/5183685>
​http://bugs.webkit.org/show_bug.cgi?id=13301
ASSERT or null value when trying to use a getter defined on a window object


Add tests.

  • fast/dom/getter-on-window-object-expected.txt: Added.
  • fast/dom/getter-on-window-object.html: Added.

WebCore:

Reviewed by Maciej.

<rdar://problem/5183685>
​http://bugs.webkit.org/show_bug.cgi?id=13301
ASSERT or null value when trying to use a getter defined on a window object

Handle the case where the value returned is a getter/setter object.


  • bindings/js/kjs_window.cpp: (KJS::Window::getOverridePropertySlot):
1:27 AM Changeset in webkit [21480] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/5200816>
REGRESSION: With Shiira 1.2.2 , I can't open embedded link in flash object by clicking (http:/www.adobe.com )


Shiira under some circumstances passes nil as the request to -[WebFrame loadRequest:]. ToT WebKit doesn't call any policy
delegate methods in this case, which means that the page is actually being loaded.


This patch makes ToT WebKit behave in the same way as Tiger WebKit when the request is nil.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkNavigationPolicy): Don't continue without calling the navigation policy method if the request is null.


(WebCore::FrameLoader::continueAfterNavigationPolicy):
If the request can't be handled, don't continue the load.


  • platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest): Don't create an NSURLRequest object if the request is null.
1:24 AM Changeset in webkit [21479] by mjs
  • 6 edits in trunk

WebCore:

Reviewed by Hyatt and Lars.

  • fixed <rdar://problem/5201758> REGRESSION: Stop button enabled and other problems caused by [WebView currentURL] returning non-nil for empty window
  • WebCore.exp: export new symbol
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): move marker that we committed a real doc load from here... (WebCore::FrameLoader::transitionToCommitted): ...to here (WebCore::FrameLoader::frameHasLoaded): check that we have at least started loading something besides the initial empty doc.
  • loader/FrameLoader.h:

WebKit:

Reviewed by Hyatt and Lars.


  • fixed <rdar://problem/5201758> REGRESSION: Stop button enabled and other problems caused by [WebView currentURL] returning non-nil for empty window


  • WebView/WebDataSource.mm: (-[WebDataSource request]): Return nil when we are still showing the initial empty doc
12:37 AM Changeset in webkit [21478] by lars
  • 2 edits
    461 adds in trunk/LayoutTestResults

5319 -> 5879 passing test cases for the Qt build.

12:31 AM Changeset in webkit [21477] by justing
  • 5 edits in trunk/LayoutTests

Spelling markers fixed:

  • editing/deleting/delete-block-table-expected.checksum:
  • editing/deleting/delete-block-table-expected.png:
  • editing/selection/move-by-line-001-expected.checksum:
  • editing/selection/move-by-line-001-expected.png:
Note: See TracTimeline for information about the timeline view.