Context Navigation

Add a line gutter to view source mode. The gutter uses counters, and this exposed the fact
that pseudoStyleForElement was not walking all UA rules properly.

Reviewed by aroben

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::pseudoStyleForElement):
css/view-source.css:
html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument): (WebCore::HTMLViewSourceDocument::addViewSourceToken): (WebCore::HTMLViewSourceDocument::addSpanWithClassName): (WebCore::HTMLViewSourceDocument::addLine): (WebCore::HTMLViewSourceDocument::addText):
html/HTMLViewSourceDocument.h:

9:17 PM Changeset in webkit [21547] by justing

3 edits
2 adds in trunk

LayoutTests:

Reviewed by ggaren

<rdar://problem/5209984> REGRESSION: Crash on click after clearing Facebook status

editing/selection/5209984-expected.txt: Added.
editing/selection/5209984.html: Added.

WebCore:

Reviewed by ggaren

<rdar://problem/5209984> REGRESSION: Crash on click after clearing Facebook status

comparePositions() expects non-null positions. It's
given a null position by contains() if the current
selection is a range selection but contains only invisible
content *and* visible positions cannot be created from its
end points. This can happen when there is a range selection
inside shadow content (like that inside text fields) that
is made invisible.

editing/SelectionController.cpp: (WebCore::SelectionController::contains): Check for invisible end points.

8:05 PM Changeset in webkit [23378] by weinig

2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Build Fix after <rdar://problem/5201423>

WebCore.vcproj/WebCore.vcproj:

7:50 PM Changeset in webkit [21546] by weinig

5 edits
3 adds in trunk

LayoutTests:

Reviewed by Adam.

Tests for <rdar://problem/5201423> REGRESSION: Links in
sidebar don't work on Honda website

fast/dom/anchor-toString-expected.txt: Added.
fast/dom/anchor-toString.html: Added.
fast/forms/focus2.html:

WebCore:

Reviewed by Adam.

Fix for <rdar://problem/5201423> REGRESSION: Links in
sidebar don't work on Honda website

Anchor elements need to have the same behavior for implicit and
explicit toString() calls.

Test: fast/dom/anchor-toString.html

WebCore.xcodeproj/project.pbxproj:
bindings/js/JSHTMLAnchorElementCustom.cpp: Added. (WebCore::JSHTMLAnchorElement::toString):
html/HTMLAnchorElement.idl:

4:38 PM Changeset in webkit [21545] by ggaren

2 edits in trunk/WebCore

Build fix.

4:24 PM Changeset in webkit [23377] by adele

2 edits in branches/WindowsMerge/WebCore

Reviewed by Hyatt.

Follow up to <rdar://problem/5092645> PopupMenuWin needs bidiReorderCharacters logic from RenderListBox

platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint): Use the clientStyle to determine how to handle bidi text. For popup buttons, which we restrict to LTR, we will match the button text.

4:15 PM Changeset in webkit [21544] by adele

2 edits in trunk/WebCore

Reviewed by Hyatt.

Update RenderMenuList PopupClient methods to consider style of inner block.

rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::itemStyle): (WebCore::RenderMenuList::clientStyle):

4:10 PM Changeset in webkit [23376] by adachan

3 edits in branches/WindowsMerge/WebKitWin

2007-05-17 Ada Chan <adachan@apple.com>

Reviewed by Steve.

Changed the context menu title "Search in Google" to "Search with Google".

3:57 PM Changeset in webkit [21543] by mjs

2 edits in trunk/WebCore

Not reviewed, emergency test fix.

avoid crash on layout tests.

Patched up my last change so that widgets don't crash.

loader/FrameLoader.cpp: (WebCore::FrameLoader::mainReceivedCompleteError):

3:25 PM Changeset in webkit [21542] by antti

6 edits
2 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for http://bugs.webkit.org/show_bug.cgi?id=13727
REGRESSION: Reproducible hang setting the selection's extent offset to -1
<rdar://problem/5206890>

LayoutTests/editing/selection/selection-invalid-offset-expected.txt: Added.
LayoutTests/editing/selection/selection-invalid-offset.html: Added.

WebCore:

Reviewed by Darin.

Fix for http://bugs.webkit.org/show_bug.cgi?id=13727
REGRESSION: Reproducible hang setting the selection's extent offset to -1
<rdar://problem/5206890>

Rise INDEX_SIZE_ERR if used selection index is negative. This matches HTML5 for
getRangeAt() and collapse() which are part of the spec (FF throws NS_ERROR_FAILURE).

Not throwing exceptions yet for too high offsets (except getRangeAt()) as it is
unclear if WebCore's definition of offsets is the same as other browsers.

bindings/js/kjs_window.cpp:
WebCore/editing/SelectionController.cpp:
WebCore/editing/SelectionController.h:
WebCore/editing/VisiblePosition.cpp:

2:42 PM Changeset in webkit [21541] by adele

4 edits
4 adds in trunk

LayoutTests:

Reviewed by Mitz.

Test for <rdar://problem/5096035> REGRESSION: rtl text should be left-aligned in <select>s

fast/text/international/bidi-menulist-expected.checksum: Added.
fast/text/international/bidi-menulist-expected.png: Added.
fast/text/international/bidi-menulist-expected.txt: Added.
fast/text/international/bidi-menulist.html: Added.

WebCore:

Reviewed by Mitz.

Fix for <rdar://problem/5096035> REGRESSION: rtl text should be left-aligned in <select>s

Test: fast/text/international/bidi-menulist.html

rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::adjustInnerStyle): Set the inner block style to direction: ltr, and text-align: left. This means that we will ignore those settings in the button to match the way the text is displayed in the popup menu. (WebCore::RenderMenuList::createInnerBlock): Call adjustInnerStyle. (WebCore::RenderMenuList::setStyle): ditto.
rendering/RenderMenuList.h: Added adjustInnerStyle.

2:16 PM Changeset in webkit [21540] by justing

3 edits in trunk/LayoutTests/editing/execCommand

I accidently mucked around with these tests after generating results.
Correcting them.

2:06 PM Changeset in webkit [21539] by justing

3 edits
12 adds in trunk

LayoutTests:

Reviewed by harrison

editing/execCommand/4924441-expected.checksum: Added.
editing/execCommand/4924441-expected.png: Added.
editing/execCommand/4924441-expected.txt: Added.
editing/execCommand/4924441.html: Added.
editing/execCommand/5207369-expected.checksum: Added.
editing/execCommand/5207369-expected.png: Added.
editing/execCommand/5207369-expected.txt: Added.
editing/execCommand/5207369.html: Added.
editing/execCommand/5210032-expected.checksum: Added.
editing/execCommand/5210032-expected.png: Added.
editing/execCommand/5210032-expected.txt: Added.
editing/execCommand/5210032.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4924441> List becomes nested when changing its type
<rdar://problem/5210032> Content before a list is placed at the end of the list when its made into a list item
<rdar://problem/5207369> Crash when removing ordering from a nested list

editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): The outermostEnclosingList of the position before the start isn't the previousList if it contains the start. Ditto for the position after the end and the nextList. If we're putting the newly created list item into the next list, insert it at the start of that list, not the end (don't append). Avoid nesting newly created lists inside list items.

11:35 AM Changeset in webkit [21538] by pyeh

2 edits in trunk/WebCore

<rdar://problem/4775672> AXTextMarkerRangeForUnorderedTextMarkers returns incorrect order

bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject doAXTextMarkerRangeForUnorderedTextMarkers:]): A selection's m_start is not guranteed to equal m_base since m_start can actually be m_base's downstream(). A more accurate way to determine the order from selection is to ask directly for isBaseFirst(). In addition, if the two visible positions given are the same position but different affinity, we need to handle it here rather than depend on the selection. This is because selection does not retain the affinity of both selection start/end visible positions as part of the selection validation.

10:57 AM Changeset in webkit [21537] by spadma

75 edits
17 adds in S60/branches/3.1m

2007-05-15 yyadavall <sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (Sachin.Padma@nokia.com).
DESC: Back port widget to 3.1 branch
http://bugs.webkit.org/show_bug.cgi?id=13657

WARNING: NO TEST CASES ADDED OR CHANGED

BWINS/WEBCOREU.DEF:
EABI/WebCoreU.DEF:
bridge/WebCoreBridge.cpp: (CWebCoreBridge::WindowScriptNPObject):
bridge/WebCoreBridge.h:
bridge/WebCoreFormControls.h:
bridge/WebCoreWidget.h: (MWebCoreWidget::PluginScriptableObject):
group/KHTML.mmp:
group/KWQ.mmp:
group/WebCore.mmp:
khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::createLanguageInstanceForValue):
khtml/ecma/kjs_binding.h:
khtml/ecma/kjs_dom.cpp: (DOMNode::mark): (DOMNode::getValueProperty): (DOMNodeList::call): (DOMDocument::DOMDocument): (DOMDocumentProtoFunc::tryCall): (DOMElementProtoFunc::tryCall): (DOMDOMImplementation::DOMDOMImplementation): (DOMNamedNodeMap::DOMNamedNodeMap): (KJS::getDOMDocumentNode): (KJS::checkNodeSecurity): (KJS::getRuntimeObject): (DOMCharacterData::DOMCharacterData): (DOMCharacterDataProtoFunc::tryCall): (DOMText::DOMText):
khtml/ecma/kjs_window.cpp: (Window::Window): (Window::mark): (Window::get): (ScheduledAction::execute):
khtml/ecma/kjs_window.h: (KJS::Window::): (KJS::Selection::):
khtml/ecma/kjs_window.lut.h: (KJS::):
khtml/html/html_formimpl.cpp: (DOM::):
khtml/html/html_formimpl.h:
khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::getAppletInstance): (HTMLEmbedElementImpl::HTMLEmbedElementImpl): (HTMLEmbedElementImpl::getEmbedInstance):
khtml/html/html_objectimpl.h:
khtml/rendering/render_form.cpp: (RenderFileButton::updateFromElement):
kwq/KWQFileButton.cpp: (KWQFileButton::KWQFileButton): (KWQFileButton::setFont): (KWQFileButton::~KWQFileButton): (KWQFileButton::setFilename): (KWQFileButton::click): (KWQFileButton::sizeForCharacterWidth): (KWQFileButton::frameGeometry): (KWQFileButton::setFrameGeometry): (KWQFileButton::HandleEvent): (KWQFileButton::setAccept):
kwq/KWQFileButton.h:
kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::KWQKHTMLPart): (KWQKHTMLPart::bindingRootObject): (KWQKHTMLPart::addPluginRootObject): (KWQKHTMLPart::cleanupPluginRootObjects): (KWQKHTMLPart::createWidgetObject): (KWQKHTMLPart::createWidgetMenuObject): (KWQKHTMLPart::createWidgetMenuItemObject): (KWQKHTMLPart::getEmbedInstanceForView): (KWQKHTMLPart::getObjectInstanceForView): (KWQKHTMLPart::windowScriptNPObject):
kwq/KWQKHTMLPart.h: (KWQKHTMLPart::getAppletInstanceForView):

10:56 AM Changeset in webkit [23375] by andersca

2 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

<rdar://problem/5210600> New WMP plugin doesn't show any contents

Call NPP_SetWindow after the window's size has been updated.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setFrameGeometry):

10:52 AM Changeset in webkit [21536] by beidson

3 edits
1 move
10 adds
3 deletes in trunk

LayoutTests:

Reviewed by Brady

pixel test for http://bugs.webkit.org/show_bug.cgi?id=13759 REGRESSION (r20182-r20184): Incorrect rendering of multipart images

Created http/tests/multipart and moved the existing multipart test there.

http/tests/misc/multipart-expected.txt: Removed.
http/tests/misc/multipart.html: Removed.
http/tests/misc/resources/1x1-blue.png: Removed.
http/tests/misc/resources/multipart.php: Removed.
http/tests/multipart/invalid-image-data-expected.checksum: Added.
http/tests/multipart/invalid-image-data-expected.png: Added.
http/tests/multipart/invalid-image-data-expected.txt: Added.
http/tests/multipart/invalid-image-data.html: Added.
http/tests/multipart/resources/2x2-green.png: Added. Shared by both multipart tests.
http/tests/multipart/resources/abe.png: Added.
http/tests/multipart/resources/multipart.php: Added. Shared by both multipart tests.
http/tests/multipart/stop-crash.html: Renamed from misc/multipart.html.

WebCore:

Reviewed by Brady

fix http://bugs.webkit.org/show_bug.cgi?id=13759 REGRESSION (r20182-r20184): Incorrect rendering of multipart images

Test: http/tests/multipart/invalid-image-data.html

loader/loader.cpp: (WebCore::Loader::didReceiveData): Make a copy of the current part's data instead of using the resource data, because the latter is going to be overwritten by the new part being received.

9:47 AM Changeset in webkit [23374] by andersca

2 edits in branches/WindowsMerge/WebCore

Reviewed by John.

<rdar://problem/5204016> Repro crash on nytimes.com in MimeTypeRegistry::getMIMETypeForExtension

Return null if the extension is null.

platform/win/MimeTypeRegistryWin.cpp: (WebCore::MimeTypeRegistry::getMIMETypeForExtension):

8:11 AM Changeset in webkit [23373] by andersca

2 edits in branches/WindowsMerge/WebKitWin

Fix build.

WebFrame.cpp: (WebFrame::loadURLIntoChild):

4:32 AM Changeset in webkit [21535] by oliver

5 edits in trunk

2007-05-17 Oliver Hunt <oliver@apple.com>

WebCore:

Reviewed by Justin.

Fix for <rdar://problem/4244861> Safari fails to create image file
after releasing dragged image that has changed on source page

Tell xcode to copy HTMLImageElement.h and HTMLImageLoader.h headers
across to WebKit as private headers.

WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Justin.

Fix for <rdar://problem/4244861> Safari fails to create image file
after releasing dragged image that has changed on source page

This patch fixes this bug by manually creating an NSFileWrapper from
the TIFF promise data for a drag if it is available. This bypasses
the problem of the required resource no longer being held due to page
loads or other constraints.

We need to leave the old path in place to allow for the case where
the promised data is not available.

WebCoreSupport/WebDragClient.mm: (WebDragClient::declareAndWriteDragImage): Always use the top WebHTMLView as the pasteboard owner, this is safe as we only use the owner for resolving promised types.
WebView/WebHTMLView.mm: (-[WebHTMLView _writeSelectionToPasteboard:]): (-[WebHTMLView writeSelectionToPasteboard:types:]): Always use the top WebHTMLView as the pasteboard owner. (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Add path to create NSFileWrapper from promise data.

3:46 AM Changeset in webkit [21534] by justing

5 edits
4 adds in trunk

LayoutTests:

Reviewed by harrison

Demonstrates bug:

editing/execCommand/5190926-expected.checksum: Added.
editing/execCommand/5190926-expected.png: Added.
editing/execCommand/5190926-expected.txt: Added.
editing/execCommand/5190926.html: Added.

Avoided some nesting:

editing/execCommand/5142012-2-expected.txt:
editing/execCommand/switch-list-type-expected.txt:

WebCore:

Reviewed by harrison

<rdar://problem/5190926>
Gmail Editor: Crash when removing list style from underlined, multi-item list

The user underlined some text, then created a list.
The list was placed inside the inline element carrying
the underline style, so, that element surrounded the
list instead of being at the lowest level (just above
text nodes). This kind of markup is more difficult to
edit. Filed 5192089 and added a workaround so that we
don't produce this kind of markup.

editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): Avoid inline elements when inserting the new list.

1:54 AM Changeset in webkit [21533] by oliver

8 edits in trunk/WebKit

2007-05-17 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

Fix for <rdar://problem/4343832> Trying to drag a large 6.2MB jpeg image

out of Safari is unexpectedly slow (4 copies of image plus RTF document on pasteboard)

This patch causes the construction of the RTF and TIFF data to be delayed until requested.

We delay TIFF construction from a DOMElement as this may require generating TIFF data
from the CachedImage, which is slow. To allow the TIFF data to be created later the
it's necessary to add a reference to the source DOMElement to the view.

Misc/WebNSPasteboardExtras.h:
Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]): Implements the delayed write of RTF data (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]): Set up the pasteboard to allow the data writing to be delayed (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]): Now we need to pass the WebHTMLView on to _web_writeImage:element:URL:title:archive:types:source:
WebCoreSupport/WebDragClient.mm: (WebDragClient::startDrag): Clear the dragging pasteboard once the drag has ended to ensure we don't hold references to anything longer than we need to. (WebDragClient::declareAndWriteDragImage):

WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLViewPrivate clear]): (-[WebHTMLView pasteboardChangedOwner:]): Make sure we clear out the DOMElement reference once it is no longer needed (-[WebHTMLView pasteboard:provideDataForType:]): Provide delayed data (-[WebHTMLView _writeSelectionToPasteboard:]): Make sure we set pasteboard ownership correctly (-[WebHTMLView promisedDragTIFFDataSource]): (-[WebHTMLView setPromisedDragTIFFDataSource:]): (-[WebHTMLView writeSelectionToPasteboard:types:]):
WebView/WebHTMLViewInternal.h:
WebView/WebHTMLViewPrivate.h:

WebView/WebView.mm: (-[WebView _writeImageForElement:withPasteboardTypes:toPasteboard:]):

1:52 AM Changeset in webkit [21532] by hyatt

4 edits in trunk/WebCore

Allow redundant attributes with the same name in view source mode.

Reviewed by aroben

dom/NamedAttrMap.h: (WebCore::NamedAttrMap::insertAttribute):
html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute):

1:48 AM Changeset in webkit [21531] by andersca

1 edit
1 add in trunk/WebCore

1:46 AM Changeset in webkit [21530] by staikos

2 edits in trunk/WebCore

Back out last patch based on discussion with Zack

1:38 AM Changeset in webkit [21529] by andersca

5 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/5207156> Hamachi test tool causes assertion in FormCompletionController in Safari

This happens because the form delegate gets passed the wrong source frame during the second submit().
If a frame with the given name is found, FrameLoader::load is called with the same parameters on the found frame.
This causes the found frame to be used as the source frame, which is wrong.

The fix is to create the form state object before checking what frame to load the new request in.

WebCore.exp:
loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::checkNavigationPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy):
loader/FrameLoader.h:
manual-tests/submit-form-with-target-twice.html: Added.

WebKit:

Reviewed by Darin.

<rdar://problem/5207156> Hamachi test tool causes assertion in FormCompletionController in Safari

Update for WebCore changes.

WebView/WebFrame.mm: (-[WebFrame _loadURL:referrer:intoChild:]):

May 16, 2007:

11:52 PM Changeset in webkit [21528] by mjs

2 edits in trunk/WebCore

Reviewed by Oliver.

<rdar://problem/5205914> REGRESSION: PLT stops after loading first page due to r21479

loader/FrameLoader.cpp: (WebCore::FrameLoader::frameHasLoaded):

11:28 PM Changeset in webkit [21527] by hyatt

1 edit in trunk/LayoutTests/fast/frames/viewsource-attribute-expected.txt

Update the lone view source mode layout test.

11:27 PM Changeset in webkit [21526] by hyatt

5 edits in trunk/WebCore

Improve the syntax-highlighted view source mode. It now preserves all whitespace properly
and highlights doctypes and comments (in addition to all the stuff it could highlight before).

Reviewed by aroben

html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute): (WebCore::HTMLTokenizer::parseTag):
html/HTMLTokenizer.h: (WebCore::Token::Token): (WebCore::Token::~Token): (WebCore::Token::reset): (WebCore::Token::addViewSourceChar):
html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken):
html/HTMLViewSourceDocument.h:

10:37 PM Changeset in webkit [21525] by beidson

2 edits in trunk/WebKitTools

Build fix for some dev configurations

DumpRenderTree/DumpRenderTree.m:

9:47 PM Changeset in webkit [21524] by mjs

2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5191024> Page never loads completely (emonome.vodpod.com)
<rdar://problem/5205162> REGRESSION (r21367): In the Address URL field, typing a site name doesn't redirect to site after pressing return
http://bugs.webkit.org/show_bug.cgi?id=13683
<rdar://problem/5208951> REGRESSION: Progress bar never completes on link click that downloads (13694)
http://bugs.webkit.org/show_bug.cgi?id=13694
<rdar://problem/5201598> REGRESSION: After uploading file to iDisk at mac.com, "loading" status remains and file does not appear in the list

loader/FrameLoader.cpp: (WebCore::FrameLoader::mainReceivedCompleteError): Make sure to always check whether the overall load completed, even if we think the current frame load is already complete.

9:21 PM Changeset in webkit [21523] by mjs

9 edits
13 adds in trunk

LayoutTests:

Reviewed by Justin.

added a bunch of layout tests using the new load delegate testing mechanism

http/tests/loading/bad-scheme-subframe-expected.txt: Added.
http/tests/loading/bad-scheme-subframe.html: Added.
http/tests/loading/bad-server-subframe-expected.txt: Added.
http/tests/loading/bad-server-subframe.html: Added.
http/tests/loading/basic-expected.txt: Added.
http/tests/loading/basic.html: Added.
http/tests/loading/empty-subframe-expected.txt: Added.
http/tests/loading/empty-subframe.html: Added.
http/tests/loading/simple-subframe-expected.txt: Added.
http/tests/loading/simple-subframe.html: Added.

WebKitTools:

Reviewed by Justin.

created a new mechanism to log FrameLoadDelegate callbacks in directories named "loading"

The reason for doing things in this slightly odd way is to make sure we don't miss the load delegates
that happen before the load commits.

Basically I moved WaitUntilDoneDelegate into a separate file (FrameLoadDelegate.m) and added
optional logging for every FrameLoadDelegate callback, including SPI callbacks.

DumpRenderTree/DumpRenderTree.h:
DumpRenderTree/DumpRenderTree.m: (createWebView): (dumpRenderTree): (dump): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController clearBackForwardList]): (-[LayoutTestController setUseDashboardCompatibilityMode:]): (-[LayoutTestController dumpFrameLoadCallbacks]): (-[LayoutTestController setWindowIsKey:]): (-[LayoutTestController setMainFrameIsFirstResponder:]): (-[LayoutTestController _doLoad:target:]): (-[LayoutTestController _doBackOrForwardNavigation:]): (-[LayoutTestController queueReload]): (-[LayoutTestController queueScript:]): (-[LayoutTestController queueLoad:target:]): (-[LayoutTestController setAcceptsEditing:]): (-[LayoutTestController setTabKeyCyclesThroughElements:]): (shouldLogFrameLoadDelegates): (runTest): (displayWebView): (+[DumpRenderTreeEvent mouseLocation]):
DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/DumpRenderTreeDraggingInfo.m: (-[DumpRenderTreeDraggingInfo draggingDestinationWindow]):
DumpRenderTree/EventSendingController.m: (-[EventSendingController mouseDown]): (-[EventSendingController mouseUp]): (-[EventSendingController mouseMoveToX:Y:]): (-[EventSendingController contextClick]):
DumpRenderTree/FrameLoadDelegate.h: Added.
DumpRenderTree/FrameLoadDelegate.m: Added. (-[WebFrame _drt_descriptionSuitableForTestResult]): (-[FrameLoadDelegate processWork:]): (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): (-[FrameLoadDelegate webView:didCommitLoadForFrame:]): (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]): (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]): (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]): (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]): (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]): (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]): (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]): (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]): (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]): (-[FrameLoadDelegate webView:willCloseFrame:]): (-[FrameLoadDelegate webView:didFirstLayoutInFrame:]): (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]): (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
DumpRenderTree/ResourceLoadDelegate.m: (-[NSURL _drt_descriptionSuitableForTestResult]):
DumpRenderTree/UIDelegate.m: (-[UIDelegate webViewFocus:]):

5:34 PM Changeset in webkit [23372] by adele

2 edits in branches/WindowsMerge/WebCore

Reviewed by Hyatt.

Fix for:

<rdar://problem/5092645> PopupMenuWin needs bidiReorderCharacters logic from RenderListBox
<rdar://problem/5205654> Select popup menus should always be ltr to match the mac

platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): Remove special cases for RTL menus, since we are always going to left align. (WebCore::PopupMenu::calculatePositionAndSize): ditto. (WebCore::PopupMenu::paint): Added call to bidiReorderCharacters.

2:47 PM Changeset in webkit [21522] by bdakin

15 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Changes for <rdar://problem/5204107> REGRESSION: CSS web forum site
layout not displaying properly in latest WebKit

New test:

fast/table/tableInsideCaption-expected.checksum: Added.
fast/table/tableInsideCaption-expected.png: Added.
fast/table/tableInsideCaption-expected.txt: Added.
fast/table/tableInsideCaption.html: Added.

Good changes.

tables/mozilla/bugs/bug48028-1-expected.checksum:
tables/mozilla/bugs/bug48028-1-expected.png:
tables/mozilla/bugs/bug48028-1-expected.txt:
tables/mozilla_expected_failures/core/captions1- expected.checksum:
tables/mozilla_expected_failures/core/captions1-expected.png:
tables/mozilla_expected_failures/core/captions1-expected.txt:

Not great changes. These changes expose other bugs. Filing reports
for these.

tables/mozilla/bugs/bug48028-2-expected.txt:
tables/mozilla/bugs/bug55789-expected.checksum:
tables/mozilla/bugs/bug55789-expected.png:
tables/mozilla/bugs/bug55789-expected.txt:

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/5204107> REGRESSION: CSS web forum site
layout not displaying properly in latest WebKit

Hyatt's http://trac.webkit.org/projects/webkit/changeset/21428
exposed this bug. We were not handling error cases with <caption>
correctly. This patch makes them do the same thing as colgroup.

html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
html/HTMLParserErrorCodes.cpp: No need any more for caption- specific errors. (WebCore::htmlParserErrorMessageTemplate):
html/HTMLParserErrorCodes.h: (WebCore::):

2:30 PM Changeset in webkit [23371] by kmccullo

2 edits in branches/WindowsMerge/LayoutTests

Reviewed by .

win/Skipped: Added a new test that requires DRT to be able to handle multiple windows.

1:57 PM Changeset in webkit [21521] by kmccullo

7 edits in trunk

LayoutTests:

Reviewed by Darin and Geoff.

rdar://problem/4981886
Added tests for allowing JS to close a window that was opened by the DOM.

fast/dom/open-and-close-by-DOM-expected.txt: Added.
fast/dom/open-and-close-by-DOM.html: Added.
fast/dom/resources/close.html: Added.
fast/dom/resources/middle.html: Added.

WebCore:

Reviewed by Darin and Geoff.

rdar://problem/4981886
Now windows opened by the DOM can be closed by JS.

bindings/js/kjs_window.cpp: (KJS::createNewWindow): (KJS::WindowFunc::callAsFunction):
loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::openedByDOM): (WebCore::FrameLoader::setOpenedByDOM): (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
loader/FrameLoader.h:

WebKitTools:

Reviewed by Darin and Geoff.

rdar://problem/4981886
Now windows opened by the DOM can be closed by JS.

DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController windowCount]):

1:15 PM Changeset in webkit [21520] by darin

4 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

test for <rdar://problem/4928671> Crash due to runaway recursion when fieldset has display: table-row (12066)

fast/css/fieldset-display-row-expected.checksum: Added.
fast/css/fieldset-display-row-expected.png: Added.
fast/css/fieldset-display-row-expected.txt: Added.
fast/css/fieldset-display-row.html: Added.

WebCore:

Reviewed by Hyatt.

fix <rdar://problem/4928671> Crash due to runaway recursion when fieldset has display: table-row (12066)

Test: fast/css/fieldset-display-row.html

rendering/RenderContainer.cpp: (WebCore::RenderContainer::addChild): Change all decision making about special handling for new children to use the class of the render object instead of the style, except for the cases where the style is the only way to tell (TABLE_COLUMN_GROUP and TABLE_CAPTION). Thus a RenderFieldset with table-row style won't get handled as if it was a table row.

rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Same thing. Except that here the styles that we ahave to look at are TABLE_CAPTION, TABLE_HEADER_GROUP, TABLE_FOOTER_GROUP, and TABLE_ROW_GROUP.

12:53 PM Changeset in webkit [21519] by spadma

3 edits in S60/trunk/WebKit

ligman, reviewed by Sachin

DESC: Remove unused iIsVisible flag. Default return ETrue from CPluginSkin::IsVisible call, so placeholder can be selected for audio download.
http://bugs.webkit.org/show_bug.cgi?id=13749

Plugin/inc/PluginSkin.h:
Plugin/src/PluginSkin.cpp: (CPluginSkin::IsVisible):

12:52 PM Changeset in webkit [21518] by spadma

3 edits in S60/branches/3.1m/WebKit

ligman, reviewed by Sachin

DESC: Remove unused iIsVisible flag. Default return ETrue from CPluginSkin::IsVisible call, so placeholder can be selected for audio download.
http://bugs.webkit.org/show_bug.cgi?id=13749

Plugin/inc/PluginSkin.h:
Plugin/src/PluginSkin.cpp: (CPluginSkin::IsVisible):

6:53 AM Changeset in webkit [21517] by zack

5 edits in trunk/WebCore

Implement Canvas element in the Qt port.

Implementation of Context2D was completely missing in the
Qt port. This commit adds bigger parts of it.
r=Lars

6:50 AM Changeset in webkit [21516] by zack

2 edits in trunk/WebCore

Fix shared timers.

Make the timers correctly use miliseconds. Based on a patch
from George.

4:12 AM Changeset in webkit [21515] by lars

2 edits in trunk/WebKitQt

Reviewed by Zack

pass the mouse events to the event handler, not the frameview.

4:05 AM Changeset in webkit [21514] by lars

2 edits in trunk/LayoutTestResults

Update layout tests for error handling changes.

2:25 AM Changeset in webkit [21513] by hyatt

1 edit in trunk/LayoutTests/fast/dom/delete-contents-expected.txt

Update layout tests for error handling changes.

1:47 AM Changeset in webkit [21512] by hyatt

1 edit in trunk/WebCore/WebCore.pro

Fix Qt build.

1:22 AM Changeset in webkit [23370] by hyatt

1 edit in branches/WindowsMerge/WebCore/WebCore.vcproj/WebCore.vcproj

Add new HTMLParserErrorCodes files.

1:11 AM Changeset in webkit [21511] by hyatt

5 edits
2 adds in trunk/WebCore

Add rudimentary error reporting to the HTML parser. This is disabled
for now until it gets beefed up a bit more (and until we work out how
best to pass the messages up without hurting perf).

Clean up and remove dead error handling code and incorrect error handling
code as well.

Reviewed by mjs

WebCore.xcodeproj/project.pbxproj:
html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser): (WebCore::HTMLParser::handleError): (WebCore::HTMLParser::headCreateErrorCheck): (WebCore::HTMLParser::reportErrorToConsole):
html/HTMLParser.h: (WebCore::HTMLParser::reportError):
html/HTMLParserErrorCodes.cpp: Added. (WebCore::htmlParserErrorMessageTemplate):
html/HTMLParserErrorCodes.h: Added. (WebCore::):
html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::tagStartLineNumber):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed