⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 18, 2007:

11:48 PM Changeset in webkit [21598] by hyatt
  • 2 edits in trunk/WebCore

Fix a glitch in view source mode attribute names.

  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken):
10:16 PM Changeset in webkit [21597] by hyatt
  • 4 edits in trunk/WebCore

"Linkify" view source mode links.

Reviewed by andersca

  • css/view-source.css:
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken): (WebCore::HTMLViewSourceDocument::addSpanWithClassName): (WebCore::HTMLViewSourceDocument::addLink):
  • html/HTMLViewSourceDocument.h:
7:05 PM Changeset in webkit [21596] by oliver
  • 10 edits in trunk

2007-05-18 Oliver Hunt <​oliver@apple.com>

WebCore:

Reviewed by Sam

No longer need to pass HTMLImageElement and HTMLImageLoader on to WebKit
Need to expose CachedResourceClient constructor

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Sam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=13782
REGRESSION (r21528-r21533): Failing editing/selection/drag-in-iframe in pixel mode


r21533 made used a DOMElement as the source for promise data, this meant it had to
clear the dragging pasteboard following the drag. In DRT a drag is non-blocking
so this resulted in us prematurely clearing the pasteboard.


This patch avoids this problem by referencing the source CachedImage rather than the
DOMElement, so we don't need to worry about retaining an entire document forever, so
we don't need to clear the dragging pasteboard following the drag.


  • Misc/WebNSPasteboardExtras.mm: (imageFromElement): Extract the underlying CachedImage from a DOMElement (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]): Use a CachedImage instead of a DOMElement


  • WebCoreSupport/WebDragClient.mm: (WebDragClient::startDrag):


  • WebKit.xcodeproj/project.pbxproj:


  • WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLViewPrivate clear]): (-[WebHTMLView pasteboardChangedOwner:]): (-[WebHTMLView pasteboard:provideDataForType:]): (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): (-[WebHTMLView WebCore::]): (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]): Use CachedImage rather than DOMElement as promised data source


  • WebView/WebHTMLViewInternal.h:
  • WebView/WebHTMLViewPrivate.h:
4:32 PM Changeset in webkit [21595] by hyatt
  • 1 edit in trunk/LayoutTests/http/tests/security/local-JavaScript-from-remote.html

Fix more malformed test cases.

4:32 PM Changeset in webkit [21594] by hyatt
  • 2 edits in trunk/LayoutTests/fast/tokenizer

Fix more malformed test cases.

4:31 PM Changeset in webkit [21593] by hyatt
  • 2 edits in trunk/LayoutTests/fast/parser

Fix more malformed test cases.

4:29 PM Changeset in webkit [21592] by hyatt
  • 1 edit in trunk/LayoutTests/fast/loader/local-JavaScript-from-local.html

Fix more malformed test cases.

4:26 PM Changeset in webkit [21591] by hyatt
  • 2 edits in trunk/LayoutTests/fast/dom/HTMLScriptElement

Fix more malformed test cases.

4:12 PM Changeset in webkit [21590] by hyatt
  • 26 edits in trunk/LayoutTests/http/tests/navigation

Beating my head against these malformed http/navigation tests still.

4:06 PM Changeset in webkit [21589] by hyatt
  • 1 edit in trunk/LayoutTests/http/tests/navigation/resources/frameset.pl

Beating my head against these malformed http/navigation tests still.

4:04 PM Changeset in webkit [21588] by hyatt
  • 2 edits in trunk/LayoutTests/http/tests/navigation

Beating my head against these malformed http/navigation tests still.

4:03 PM Changeset in webkit [21587] by hyatt
  • 2 edits in trunk/LayoutTests/http/tests/navigation

Beating my head against these malformed http/navigation tests still.

4:03 PM Changeset in webkit [21586] by hyatt
  • 5 edits in trunk/LayoutTests/http/tests/navigation

Beating my head against these malformed http/navigation tests still.

4:01 PM Changeset in webkit [21585] by hyatt
  • 1 edit in trunk/LayoutTests/http/tests/navigation/resources/success200.html

Beating my head against these malformed http/navigation tests still.

3:50 PM Changeset in webkit [21584] by hyatt
  • 6 edits in trunk/LayoutTests/http/tests/navigation

Fixing broken http/navigation test cases that were written with malformed HTML.

3:48 PM Changeset in webkit [21583] by hyatt
  • 4 edits in trunk/LayoutTests/http/tests/navigation

Fixing broken http/navigation test cases that were written with malformed HTML.

3:46 PM Changeset in webkit [21582] by tristan
  • 1 edit in trunk/WebKit/WebCoreSupport/WebFrameLoaderClient.mm

Fixed potential crash with ASSERT in download due to previous commit.

3:44 PM Changeset in webkit [21581] by hyatt
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/5214338> REGRESSION: / mishandled in
HTML tokenization (13780).

Reviewed by ggaren

  • html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute): (WebCore::HTMLTokenizer::parseTag):
3:40 PM Changeset in webkit [21580] by beidson
  • 1 edit in trunk/WebCore/ChangeLog

Added bugzilla link

3:38 PM Changeset in webkit [21579] by tristan
  • 3 edits in trunk/WebKit
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::download): asked the webframeloaderclient for its webview's history and injected the originated url into the created WebDownload
3:38 PM Changeset in webkit [21578] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Maciej

<rdar://problem/5166149> - window.open() causes server to be hit twice

This regressed in ​http://trac.webkit.org/projects/webkit/changeset/14637
That patch was to fix broken behavior when opening an already existant window.
The unfortunate side effect was to cause the server to be hit twice.
Once during the call to frame->loader()->createWindow(), and again via a
scheduled redirection.

I decided to restore the original de-facto behavior by making the new window
open via a scheduled redirection - there is a FIXME that was already here that
explains the reason why we have to do it this way for now.

Additionally, there were two distinct places that had their own logic to open
a new window - the logic for window.open() and the logic for
window.showModalDialog(). The logic was almost identical so I condensed them
into one utility function that takes a flag to handle the slight difference.

A layout test is not possible at this time since it would involve capturing
server logs (the 1st connection does not exist long enough to result in any
delegate callbacks). That task is documented in
​http://bugs.webkit.org/show_bug.cgi?id=13769

  • bindings/js/kjs_window.cpp: (KJS::createWindow): Merged the two slightly different versions of "creating a window" logic here. For the modal dialog case the load is an immediate call to changeLocation(), which is triggered by the "immediate" flag, and the other cases load via scheduleLocationChange() (KJS::showModalDialog): Call createWindow() (KJS::WindowFunc::callAsFunction): Handle frame targets of _top or _parent immediately and call createWindow() for all others
3:23 PM Changeset in webkit [23388] by sfalken
  • 1 edit in branches/WindowsMerge/WebCore/WebCore.vcproj/WebCore.vcproj

Fix build.

2:45 PM Changeset in webkit [23387] by sfalken
  • 4 edits
    1 add in branches/WindowsMerge/WebCore
2:43 PM Changeset in webkit [23386] by weinig
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Fixing the vcproj paths.

  • WebCore.vcproj/WebCore.vcproj:
2:32 PM Changeset in webkit [23385] by weinig
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Geoff.

Build fix after r21577.

  • WebCore.vcproj/WebCore.vcproj:
2:06 PM Changeset in webkit [21577] by weinig
  • 17 edits in trunk

LayoutTests:

Reviewed by Geoff.

  • update results to account for new JSHTMLElements that are being auto-generated and can now produce Constructors.
  • fast/dom/Window/element-constructors-on-window-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Geoff.

Autogenerate the JS bindings for the HTMLTableElement, HTMLTableCaptionElement,
HTMLTableCellElement, HTMLTableColElement, HTMLTableRowElement, HTMLTableSectionElement.

  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSHTMLWrapper):
  • bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::HTMLElementFunction::callAsFunction):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
  • html/HTMLTableCaptionElement.idl:
  • html/HTMLTableCellElement.idl:
  • html/HTMLTableColElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • page/DOMWindow.idl:
1:47 PM Changeset in webkit [21576] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Kevin Decker


Improvement to WebKit part of fix for 5201499 based on more modern understanding. (That is,
a couple of hours more modern.)

  • WebView/WebUIDelegatePrivate.h: add showPanel: parameter to just-introduced delegate method webView:saveFrameView:
  • WebView/WebPDFView.mm: (-[WebPDFView PDFViewSavePDFToDownloadFolder:]): pass NO for new showPanel: parameter, and update comment
1:33 PM Changeset in webkit [21575] by mjs
  • 2 edits in trunk/WebKit

Reviewed by John.


<rdar://problem/5204792> REGRESSION (r21367): System widgets are drawn with vertical/horizontal scroll bars


No test because the bug requires calling setAllowsScrolling: to reproduce.

  • WebView/WebFrameView.mm: (-[WebFrameView setAllowsScrolling:]): Update the FrameView's scroll state as well as the one on WebDynamicScrollBarsView, otherwise this setting won't stick if the frame has already loaded a document.
1:32 PM Changeset in webkit [21574] by mjs
  • 5 edits in trunk/LayoutTests

Not Reviewed, buildbot test fix.


  • updated results for the last fiew checkins.


  • fast/dom/clientWidthAfterDocumentIsRemoved-expected.txt:
  • fast/dom/replaceChild-expected.txt:
  • http/tests/loading/bad-scheme-subframe-expected.txt:
  • webarchive/loading/test-loading-archive-expected.txt:
1:03 PM Changeset in webkit [21573] by sfalken
  • 1 copy in tags/Safari-522.8.1b

New tag.

12:14 PM Changeset in webkit [21572] by oliver
  • 4 edits in trunk/WebCore

2007-05-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Sam.

Fix for <rdar://problem/5211122> DRT crash below
SVGTimer::applyAnimations when page cache is enabled
(SVG animation timers do not properly cancel themselves)

There were still a few paths in the SVG Animation code
that could cause timers to be created and used. This
patch inserts addition SVG_EXPERIMENTAL blocks to prevent
these timers from being used.

  • ksvg2/misc/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::startAnimations):
  • ksvg2/misc/SVGTimer.cpp: (WebCore::SVGTimer::animationsByElement): (WebCore::SVGTimer::applyAnimations): (WebCore::SVGTimer::notifyAll): (WebCore::SVGTimer::addNotify): (WebCore::SVGTimer::removeNotify):
  • ksvg2/misc/TimeScheduler.cpp: (WebCore::TimeScheduler::addTimer): (WebCore::TimeScheduler::connectIntervalTimer): (WebCore::TimeScheduler::disconnectIntervalTimer): (WebCore::TimeScheduler::startAnimations): (WebCore::TimeScheduler::toggleAnimations): (WebCore::TimeScheduler::timerFired):
  • ksvg2/svg/SVGAnimationElement.h:
11:58 AM Changeset in webkit [21571] by ggaren
  • 2 edits in trunk/WebKit

Fixed spelling error.


  • WebView/WebViewPrivate.h:
11:22 AM Changeset in webkit [23384] by aroben
  • 5 edits in branches/WindowsMerge/WebCore

Build fix after r21562.

  • platform/win/TemporaryLinkStubs.cpp:
  • platform/win/WidgetWin.cpp:
  • plugins/win/PluginViewWin.cpp:
  • plugins/win/PluginViewWin.h:
11:12 AM Changeset in webkit [23383] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

Build-related fix: stamp version resource properly.

  • WebKit.vcproj/WebKit.rc: Fix version resource
10:52 AM Changeset in webkit [21570] by weinig
  • 4 edits in trunk/LayoutTests

Reviewed by Mitz.

Update test results after Hyatt's update of view-source
to include line numbers and a gutter.

  • fast/frames/viewsource-attribute-expected.checksum:
  • fast/frames/viewsource-attribute-expected.png:
  • fast/frames/viewsource-attribute-expected.txt:
10:05 AM Changeset in webkit [21569] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Kevin Decker


WebKit part of fix for 5201499 (support for PDFKit UI for saving PDFs to disk)


Also, the PDFKit mechanism for notifying clients about "Open File Externally" was
changed from a notification to a delegate method. The notification was new to
Leopard, so removing it doesn't affect clients in the field.

  • WebView/WebUIDelegatePrivate.h: Declared new UI delegate method webView:saveFrameView:, analogous to the existing webView:printFrameView:
  • WebView/WebPDFView.mm: removed declaration of _webkit_PDFKitLaunchNotification (-[WebPDFView viewDidMoveToWindow]): don't observe _webkit_PDFKitLaunchNotification (-[WebPDFView viewWillMoveToWindow:]): ditto (-[WebPDFView PDFViewOpenPDFInNativeApplication:]): new PDFKit delegate method, replaces our use of _webkit_PDFKitLaunchNotification (-[WebPDFView PDFViewSavePDFToDownloadFolder:]): new PDFKit delegate method, calls through to new WebKit UI delegate method
8:36 AM Changeset in webkit [21568] by zack
  • 2 edits in trunk/WebCore

Patch from Marius Bugge Monsen to fix clipboard crash.

Return a valid pointer to a Clipboard object
from newGeneralClipboard.
r=me

7:17 AM Changeset in webkit [21567] by hausmann
  • 4 edits in trunk/WebKitQt

Changed the QWebPage::loadProgressChange API to have an integer (percent) argument
instead of a double precision float.

5:11 AM Changeset in webkit [21566] by zack
  • 2 edits in trunk/WebKitQt

Keyboard event crash fix by Marius Bugge Monsen.

The default constructed KeyboardEvent has
no PlatformKeyboardEvent.
r=me

3:15 AM Changeset in webkit [21565] by oliver
  • 2 edits in trunk/LayoutTests

2007-05-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Mark.

Fix capitalisation of resources referenced by test case.

  • svg/carto.net/window.svg:
2:50 AM Changeset in webkit [21564] by bdash
  • 3 edits in trunk/WebKitTools

2007-05-18 Mark Rowe <​mrowe@apple.com>

Reviewed by Oliver.

Force LC_ALL to C when parsing locale-specific strings in 'svn' output.

  • Scripts/svn-create-patch:
  • Scripts/webkitdirs.pm:
2:21 AM Changeset in webkit [21563] by bdash
  • 3 edits in trunk/WebCore

2007-05-18 Mark Rowe <​mrowe@apple.com>

Attempt to fix the Gdk build after r21562.

  • platform/gdk/TemporaryLinkStubs.cpp: (Widget::isEnabled):
  • platform/gdk/WidgetGdk.cpp:
1:49 AM Changeset in webkit [21562] by lars
  • 4 edits in trunk/WebCore

2007-05-18 Adam Treat <​treat@kde.org>

Reviewed by Lars

Remove dead code.

  • platform/Widget.h:
  • platform/mac/WidgetMac.mm:
  • platform/qt/WidgetQt.cpp:
1:44 AM Changeset in webkit [21561] by bdash
  • 2 edits in trunk/WebCore

2007-05-18 Holger Freyther <​zecke@selfish.org>

Reviewed by Maciej.

Return true to make loading of pages working again

  • loader/gdk/FrameLoaderClientGdk.cpp: (WebCore::FrameLoaderClientGdk::canHandleRequest):
1:41 AM Changeset in webkit [21560] by bdash
  • 10 edits
    1 add in trunk

2007-05-18 Holger Freyther <​zecke@selfish.org>

Reviewed by Maciej.

Make WebCore::Widget use GtkWidget to fix focus handling.

  • WebCore.pro: Add PlatformScrollBar
  • platform/ScrollView.h: Gtk stuff
  • platform/Widget.h: Take a GtkWidget
  • platform/gdk/PlatformScrollBarGdk.cpp: Added. (PlatformScrollbar::PlatformScrollbar): (PlatformScrollbar::~PlatformScrollbar): (PlatformScrollbar::width): (PlatformScrollbar::height): (PlatformScrollbar::setEnabled): (PlatformScrollbar::paint): (PlatformScrollbar::updateThumbPosition): (PlatformScrollbar::updateThumbProportion): (PlatformScrollbar::setRect):
  • platform/gdk/ScreenGdk.cpp: Implement depth handling (WebCore::screenDepth):
  • platform/gdk/ScrollViewGdk.cpp: use setGtkWidget, not setDrawable (WebCore::ScrollView::setGtkWidget):
  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/gdk/WidgetGdk.cpp: (WebCore::Widget::Widget): (WebCore::Widget::gtkWidget): (WebCore::Widget::setGtkWidget): (WebCore::Widget::hasFocus): (WebCore::Widget::setFocus):

2007-05-18 Holger Freyther <​zecke@selfish.org>

Reviewed by Maciej.

  • GdkLauncher/main.cpp: Call setGtkWidget (main):
1:38 AM Changeset in webkit [21559] by lars
  • 3 edits in trunk/WebCore

Reviewed by Zack

Correctly implement initialiseSupportedImageMIMETypes.

1:34 AM Changeset in webkit [21558] by bdash
  • 2 edits in trunk/WebCore

2007-05-18 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Maciej.

Build fix for non-Qt and non-Mac ports.

  • html/HTMLCanvasElement.h:
1:29 AM Changeset in webkit [21557] by bdash
  • 9 edits in trunk

2007-05-18 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Mark Rowe.

No test added as this is hard to time.

  • platform/gdk/FrameGdk.cpp: Use needsLayout() to decide if layout() is needed.

(WebCore::FrameGdk::dumpRenderTree):
(WebCore::FrameGdk::handleGdkEvent):

2007-05-18 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Mark Rowe.

  • kjs/testkjs.pro: Make the Gdk port link to icu

2007-05-18 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Mark Rowe.

  • WebKit.pro: Build testkjs for Gdk and Qt

2007-05-18 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Mark Rowe.

  • GdkLauncher/main.cpp: (main): Call Frame::init to catch up with Maciej's changes.
  • Scripts/run-javascriptcore-tests: Remove --gdk from the command line passed to the helper scripts.
1:13 AM Changeset in webkit [23382] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Geoff.


<rdar://problem/4914940> Some plugins won't redraw correctly when scrolling


This patch does two things:


  1. It comments out the call to set the window's region to an empty region while it's being moved. This was done to prevent the QT plugin from drawing outside its bounds when scrolling it when it's inside an iframe or div with overflow.


  1. It lets Windows handle its invalid region when moving the window and setting its new window region.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::updateWindow):
12:54 AM Changeset in webkit [21556] by hausmann
  • 2 edits in trunk/WebCore

Generate pkgconfig files for the Qt build.

12:50 AM Changeset in webkit [23381] by aroben
  • 4 edits in branches/WindowsMerge

WebCoreWin:

Build fix after r21555.

  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::passMouseMoveEventToSubframe):

WebKitWin:

Build fix after r21555.

  • WebView.cpp:
12:09 AM Changeset in webkit [21555] by lars
  • 8 edits in trunk/WebCore

Reviewed by Hyatt.

Remove unused handleMouseEvent methods in the Widget
and derived classes.

12:00 AM Changeset in webkit [21554] by staikos
  • 2 edits in trunk/WebCore

Use the proper clipping algorithm

May 17, 2007:

11:54 PM Changeset in webkit [23380] by sfalken
  • 1 add in branches/WindowsMerge/WebCore/WebCorePrefix.h

Merged from OpenSource/WebCore/WebCorePrefix.h r20496

11:40 PM Changeset in webkit [23379] by adachan
  • 7 edits in branches/WindowsMerge/WebKitWin

2007-05-17 Ada Chan <​adachan@apple.com>

Reviewed by Steve.


Implemented IWebHTTPURLResponse::localizedStringForStatusCode().

11:36 PM Changeset in webkit [21553] by weinig
  • 2 edits in trunk/WebCore

Reviewed by George Staikos.

Fix Qt build after adding JSHTMLAnchorElementCustom.cpp.

  • WebCore.pro:
11:32 PM Changeset in webkit [21552] by staikos
  • 2 edits in trunk/WebKitQt
  • patch from Adam Treat to implement frameLoadCompleted()
  • build fix from George Staikos
11:08 PM Changeset in webkit [21551] by staikos
  • 2 edits in trunk/WebCore

Fix preprocessor logic for CG/QT

10:32 PM Changeset in webkit [21550] by staikos
  • 2 edits in trunk/WebKitQt

Implement forceLayoutForNonHTML

10:28 PM Changeset in webkit [21549] by staikos
  • 2 edits in trunk/WebKitQt

Implement canShowMIMEType

10:07 PM Changeset in webkit [21548] by hyatt
  • 5 edits in trunk/WebCore

Add a line gutter to view source mode. The gutter uses counters, and this exposed the fact
that pseudoStyleForElement was not walking all UA rules properly.

Reviewed by aroben

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::pseudoStyleForElement):
  • css/view-source.css:
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument): (WebCore::HTMLViewSourceDocument::addViewSourceToken): (WebCore::HTMLViewSourceDocument::addSpanWithClassName): (WebCore::HTMLViewSourceDocument::addLine): (WebCore::HTMLViewSourceDocument::addText):
  • html/HTMLViewSourceDocument.h:
9:17 PM Changeset in webkit [21547] by justing
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by ggaren


<rdar://problem/5209984> REGRESSION: Crash on click after clearing Facebook status

  • editing/selection/5209984-expected.txt: Added.
  • editing/selection/5209984.html: Added.

WebCore:

Reviewed by ggaren

<rdar://problem/5209984> REGRESSION: Crash on click after clearing Facebook status


comparePositions() expects non-null positions. It's
given a null position by contains() if the current
selection is a range selection but contains only invisible
content *and* visible positions cannot be created from its
end points. This can happen when there is a range selection
inside shadow content (like that inside text fields) that
is made invisible.

  • editing/SelectionController.cpp: (WebCore::SelectionController::contains): Check for invisible end points.
8:05 PM Changeset in webkit [23378] by weinig
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Build Fix after <rdar://problem/5201423>

  • WebCore.vcproj/WebCore.vcproj:
7:50 PM Changeset in webkit [21546] by weinig
  • 5 edits
    3 adds in trunk

LayoutTests:

Reviewed by Adam.

Tests for <rdar://problem/5201423> REGRESSION: Links in
sidebar don't work on Honda website

  • fast/dom/anchor-toString-expected.txt: Added.
  • fast/dom/anchor-toString.html: Added.
  • fast/forms/focus2.html:

WebCore:

Reviewed by Adam.

Fix for <rdar://problem/5201423> REGRESSION: Links in
sidebar don't work on Honda website

Anchor elements need to have the same behavior for implicit and
explicit toString() calls.

Test: fast/dom/anchor-toString.html

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLAnchorElementCustom.cpp: Added. (WebCore::JSHTMLAnchorElement::toString):
  • html/HTMLAnchorElement.idl:
4:38 PM Changeset in webkit [21545] by ggaren
  • 2 edits in trunk/WebCore

Build fix.

4:24 PM Changeset in webkit [23377] by adele
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Hyatt.

Follow up to <rdar://problem/5092645> PopupMenuWin needs bidiReorderCharacters logic from RenderListBox

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint): Use the clientStyle to determine how to handle bidi text. For popup buttons, which we restrict to LTR, we will match the button text.
4:15 PM Changeset in webkit [21544] by adele
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Update RenderMenuList PopupClient methods to consider style of inner block.

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::itemStyle): (WebCore::RenderMenuList::clientStyle):
4:10 PM Changeset in webkit [23376] by adachan
  • 3 edits in branches/WindowsMerge/WebKitWin

2007-05-17 Ada Chan <​adachan@apple.com>

Reviewed by Steve.


Changed the context menu title "Search in Google" to "Search with Google".

3:57 PM Changeset in webkit [21543] by mjs
  • 2 edits in trunk/WebCore

Not reviewed, emergency test fix.

  • avoid crash on layout tests.


Patched up my last change so that widgets don't crash.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::mainReceivedCompleteError):
3:25 PM Changeset in webkit [21542] by antti
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.


Test for ​http://bugs.webkit.org/show_bug.cgi?id=13727
REGRESSION: Reproducible hang setting the selection's extent offset to -1
<rdar://problem/5206890>

  • LayoutTests/editing/selection/selection-invalid-offset-expected.txt: Added.
  • LayoutTests/editing/selection/selection-invalid-offset.html: Added.

WebCore:

Reviewed by Darin.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=13727
REGRESSION: Reproducible hang setting the selection's extent offset to -1
<rdar://problem/5206890>


Rise INDEX_SIZE_ERR if used selection index is negative. This matches HTML5 for
getRangeAt() and collapse() which are part of the spec (FF throws NS_ERROR_FAILURE).


Not throwing exceptions yet for too high offsets (except getRangeAt()) as it is
unclear if WebCore's definition of offsets is the same as other browsers.

  • bindings/js/kjs_window.cpp:
  • WebCore/editing/SelectionController.cpp:
  • WebCore/editing/SelectionController.h:
  • WebCore/editing/VisiblePosition.cpp:
2:42 PM Changeset in webkit [21541] by adele
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Mitz.

Test for <rdar://problem/5096035> REGRESSION: rtl text should be left-aligned in <select>s

  • fast/text/international/bidi-menulist-expected.checksum: Added.
  • fast/text/international/bidi-menulist-expected.png: Added.
  • fast/text/international/bidi-menulist-expected.txt: Added.
  • fast/text/international/bidi-menulist.html: Added.

WebCore:

Reviewed by Mitz.

Fix for <rdar://problem/5096035> REGRESSION: rtl text should be left-aligned in <select>s

Test: fast/text/international/bidi-menulist.html

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::adjustInnerStyle): Set the inner block style to direction: ltr, and text-align: left. This means that we will ignore those settings in the button to match the way the text is displayed in the popup menu. (WebCore::RenderMenuList::createInnerBlock): Call adjustInnerStyle. (WebCore::RenderMenuList::setStyle): ditto.
  • rendering/RenderMenuList.h: Added adjustInnerStyle.
2:16 PM Changeset in webkit [21540] by justing
  • 3 edits in trunk/LayoutTests/editing/execCommand

I accidently mucked around with these tests after generating results.
Correcting them.

2:06 PM Changeset in webkit [21539] by justing
  • 3 edits
    12 adds in trunk

LayoutTests:

Reviewed by harrison

  • editing/execCommand/4924441-expected.checksum: Added.
  • editing/execCommand/4924441-expected.png: Added.
  • editing/execCommand/4924441-expected.txt: Added.
  • editing/execCommand/4924441.html: Added.
  • editing/execCommand/5207369-expected.checksum: Added.
  • editing/execCommand/5207369-expected.png: Added.
  • editing/execCommand/5207369-expected.txt: Added.
  • editing/execCommand/5207369.html: Added.
  • editing/execCommand/5210032-expected.checksum: Added.
  • editing/execCommand/5210032-expected.png: Added.
  • editing/execCommand/5210032-expected.txt: Added.
  • editing/execCommand/5210032.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4924441> List becomes nested when changing its type
<rdar://problem/5210032> Content before a list is placed at the end of the list when its made into a list item
<rdar://problem/5207369> Crash when removing ordering from a nested list

  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): The outermostEnclosingList of the position before the start isn't the previousList if it contains the start. Ditto for the position after the end and the nextList. If we're putting the newly created list item into the next list, insert it at the start of that list, not the end (don't append). Avoid nesting newly created lists inside list items.
11:35 AM Changeset in webkit [21538] by pyeh
  • 2 edits in trunk/WebCore

<rdar://problem/4775672> AXTextMarkerRangeForUnorderedTextMarkers returns incorrect order

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject doAXTextMarkerRangeForUnorderedTextMarkers:]): A selection's m_start is not guranteed to equal m_base since m_start can actually be m_base's downstream(). A more accurate way to determine the order from selection is to ask directly for isBaseFirst(). In addition, if the two visible positions given are the same position but different affinity, we need to handle it here rather than depend on the selection. This is because selection does not retain the affinity of both selection start/end visible positions as part of the selection validation.
10:57 AM Changeset in webkit [21537] by spadma
  • 75 edits
    17 adds in S60/branches/3.1m

2007-05-15 yyadavall <​sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (​Sachin.Padma@nokia.com).
DESC: Back port widget to 3.1 branch
​http://bugs.webkit.org/show_bug.cgi?id=13657

WARNING: NO TEST CASES ADDED OR CHANGED

  • BWINS/WEBCOREU.DEF:
  • EABI/WebCoreU.DEF:
  • bridge/WebCoreBridge.cpp: (CWebCoreBridge::WindowScriptNPObject):
  • bridge/WebCoreBridge.h:
  • bridge/WebCoreFormControls.h:
  • bridge/WebCoreWidget.h: (MWebCoreWidget::PluginScriptableObject):
  • group/KHTML.mmp:
  • group/KWQ.mmp:
  • group/WebCore.mmp:
  • khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::createLanguageInstanceForValue):
  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_dom.cpp: (DOMNode::mark): (DOMNode::getValueProperty): (DOMNodeList::call): (DOMDocument::DOMDocument): (DOMDocumentProtoFunc::tryCall): (DOMElementProtoFunc::tryCall): (DOMDOMImplementation::DOMDOMImplementation): (DOMNamedNodeMap::DOMNamedNodeMap): (KJS::getDOMDocumentNode): (KJS::checkNodeSecurity): (KJS::getRuntimeObject): (DOMCharacterData::DOMCharacterData): (DOMCharacterDataProtoFunc::tryCall): (DOMText::DOMText):
  • khtml/ecma/kjs_window.cpp: (Window::Window): (Window::mark): (Window::get): (ScheduledAction::execute):
  • khtml/ecma/kjs_window.h: (KJS::Window::): (KJS::Selection::):
  • khtml/ecma/kjs_window.lut.h: (KJS::):
  • khtml/html/html_formimpl.cpp: (DOM::):
  • khtml/html/html_formimpl.h:
  • khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::getAppletInstance): (HTMLEmbedElementImpl::HTMLEmbedElementImpl): (HTMLEmbedElementImpl::getEmbedInstance):
  • khtml/html/html_objectimpl.h:
  • khtml/rendering/render_form.cpp: (RenderFileButton::updateFromElement):
  • kwq/KWQFileButton.cpp: (KWQFileButton::KWQFileButton): (KWQFileButton::setFont): (KWQFileButton::~KWQFileButton): (KWQFileButton::setFilename): (KWQFileButton::click): (KWQFileButton::sizeForCharacterWidth): (KWQFileButton::frameGeometry): (KWQFileButton::setFrameGeometry): (KWQFileButton::HandleEvent): (KWQFileButton::setAccept):
  • kwq/KWQFileButton.h:
  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::KWQKHTMLPart): (KWQKHTMLPart::bindingRootObject): (KWQKHTMLPart::addPluginRootObject): (KWQKHTMLPart::cleanupPluginRootObjects): (KWQKHTMLPart::createWidgetObject): (KWQKHTMLPart::createWidgetMenuObject): (KWQKHTMLPart::createWidgetMenuItemObject): (KWQKHTMLPart::getEmbedInstanceForView): (KWQKHTMLPart::getObjectInstanceForView): (KWQKHTMLPart::windowScriptNPObject):
  • kwq/KWQKHTMLPart.h: (KWQKHTMLPart::getAppletInstanceForView):
10:56 AM Changeset in webkit [23375] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

<rdar://problem/5210600> New WMP plugin doesn't show any contents

Call NPP_SetWindow after the window's size has been updated.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setFrameGeometry):
10:52 AM Changeset in webkit [21536] by beidson
  • 3 edits
    1 move
    10 adds
    3 deletes in trunk

LayoutTests:

Reviewed by Brady

Created http/tests/multipart and moved the existing multipart test there.

  • http/tests/misc/multipart-expected.txt: Removed.
  • http/tests/misc/multipart.html: Removed.
  • http/tests/misc/resources/1x1-blue.png: Removed.
  • http/tests/misc/resources/multipart.php: Removed.
  • http/tests/multipart/invalid-image-data-expected.checksum: Added.
  • http/tests/multipart/invalid-image-data-expected.png: Added.
  • http/tests/multipart/invalid-image-data-expected.txt: Added.
  • http/tests/multipart/invalid-image-data.html: Added.
  • http/tests/multipart/resources/2x2-green.png: Added. Shared by both multipart tests.
  • http/tests/multipart/resources/abe.png: Added.
  • http/tests/multipart/resources/multipart.php: Added. Shared by both multipart tests.
  • http/tests/multipart/stop-crash.html: Renamed from misc/multipart.html.

WebCore:

Reviewed by Brady

Test: http/tests/multipart/invalid-image-data.html

  • loader/loader.cpp: (WebCore::Loader::didReceiveData): Make a copy of the current part's data instead of using the resource data, because the latter is going to be overwritten by the new part being received.
9:47 AM Changeset in webkit [23374] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by John.

<rdar://problem/5204016> Repro crash on nytimes.com in MimeTypeRegistry::getMIMETypeForExtension


Return null if the extension is null.


  • platform/win/MimeTypeRegistryWin.cpp: (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
8:11 AM Changeset in webkit [23373] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Fix build.


  • WebFrame.cpp: (WebFrame::loadURLIntoChild):
4:32 AM Changeset in webkit [21535] by oliver
  • 5 edits in trunk

2007-05-17 Oliver Hunt <​oliver@apple.com>

WebCore:

Reviewed by Justin.

Fix for <rdar://problem/4244861> Safari fails to create image file
after releasing dragged image that has changed on source page

Tell xcode to copy HTMLImageElement.h and HTMLImageLoader.h headers
across to WebKit as private headers.

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Justin.

Fix for <rdar://problem/4244861> Safari fails to create image file
after releasing dragged image that has changed on source page

This patch fixes this bug by manually creating an NSFileWrapper from
the TIFF promise data for a drag if it is available. This bypasses
the problem of the required resource no longer being held due to page
loads or other constraints.


We need to leave the old path in place to allow for the case where
the promised data is not available.

  • WebCoreSupport/WebDragClient.mm: (WebDragClient::declareAndWriteDragImage): Always use the top WebHTMLView as the pasteboard owner, this is safe as we only use the owner for resolving promised types.
  • WebView/WebHTMLView.mm: (-[WebHTMLView _writeSelectionToPasteboard:]): (-[WebHTMLView writeSelectionToPasteboard:types:]): Always use the top WebHTMLView as the pasteboard owner. (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Add path to create NSFileWrapper from promise data.
3:46 AM Changeset in webkit [21534] by justing
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


Demonstrates bug:

  • editing/execCommand/5190926-expected.checksum: Added.
  • editing/execCommand/5190926-expected.png: Added.
  • editing/execCommand/5190926-expected.txt: Added.
  • editing/execCommand/5190926.html: Added.


Avoided some nesting:

  • editing/execCommand/5142012-2-expected.txt:
  • editing/execCommand/switch-list-type-expected.txt:

WebCore:

Reviewed by harrison

<rdar://problem/5190926>
Gmail Editor: Crash when removing list style from underlined, multi-item list


The user underlined some text, then created a list.
The list was placed inside the inline element carrying
the underline style, so, that element surrounded the
list instead of being at the lowest level (just above
text nodes). This kind of markup is more difficult to
edit. Filed 5192089 and added a workaround so that we
don't produce this kind of markup.

  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): Avoid inline elements when inserting the new list.
1:54 AM Changeset in webkit [21533] by oliver
  • 8 edits in trunk/WebKit

2007-05-17 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.


Fix for <rdar://problem/4343832> Trying to drag a large 6.2MB jpeg image

out of Safari is unexpectedly slow (4 copies of image plus RTF document on pasteboard)


This patch causes the construction of the RTF and TIFF data to be delayed until requested.


We delay TIFF construction from a DOMElement as this may require generating TIFF data
from the CachedImage, which is slow. To allow the TIFF data to be created later the
it's necessary to add a reference to the source DOMElement to the view.

  • Misc/WebNSPasteboardExtras.h:
  • Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]): Implements the delayed write of RTF data (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]): Set up the pasteboard to allow the data writing to be delayed (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]): Now we need to pass the WebHTMLView on to _web_writeImage:element:URL:title:archive:types:source:
  • WebCoreSupport/WebDragClient.mm: (WebDragClient::startDrag): Clear the dragging pasteboard once the drag has ended to ensure we don't hold references to anything longer than we need to. (WebDragClient::declareAndWriteDragImage):


  • WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLViewPrivate clear]): (-[WebHTMLView pasteboardChangedOwner:]): Make sure we clear out the DOMElement reference once it is no longer needed (-[WebHTMLView pasteboard:provideDataForType:]): Provide delayed data (-[WebHTMLView _writeSelectionToPasteboard:]): Make sure we set pasteboard ownership correctly (-[WebHTMLView promisedDragTIFFDataSource]): (-[WebHTMLView setPromisedDragTIFFDataSource:]): (-[WebHTMLView writeSelectionToPasteboard:types:]):
  • WebView/WebHTMLViewInternal.h:
  • WebView/WebHTMLViewPrivate.h:


  • WebView/WebView.mm: (-[WebView _writeImageForElement:withPasteboardTypes:toPasteboard:]):
1:52 AM Changeset in webkit [21532] by hyatt
  • 4 edits in trunk/WebCore

Allow redundant attributes with the same name in view source mode.

Reviewed by aroben

  • dom/NamedAttrMap.h: (WebCore::NamedAttrMap::insertAttribute):
  • html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute):
1:48 AM Changeset in webkit [21531] by andersca
  • 1 edit
    1 add in trunk/WebCore
1:46 AM Changeset in webkit [21530] by staikos
  • 2 edits in trunk/WebCore

Back out last patch based on discussion with Zack

1:38 AM Changeset in webkit [21529] by andersca
  • 5 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/5207156> Hamachi test tool causes assertion in FormCompletionController in Safari

This happens because the form delegate gets passed the wrong source frame during the second submit().
If a frame with the given name is found, FrameLoader::load is called with the same parameters on the found frame.
This causes the found frame to be used as the source frame, which is wrong.


The fix is to create the form state object before checking what frame to load the new request in.


  • WebCore.exp:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::checkNavigationPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy):
  • loader/FrameLoader.h:
  • manual-tests/submit-form-with-target-twice.html: Added.

WebKit:

Reviewed by Darin.

<rdar://problem/5207156> Hamachi test tool causes assertion in FormCompletionController in Safari

Update for WebCore changes.


  • WebView/WebFrame.mm: (-[WebFrame _loadURL:referrer:intoChild:]):
Note: See TracTimeline for information about the timeline view.