Context Navigation

← Previous Period
Next Period →

Timeline

May 19, 2007:

6:19 PM Changeset in webkit [21607] by zimmermann

23 edits
134 adds in branches/feature-branch

Reviewed by Oliver.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=12698 (SVG text needs a special per-character layout mode.)
Finally land the new SVG text engine.

5:20 PM Changeset in webkit [21606] by hyatt

2 edits in trunk/WebCore

Fix for bug 13785, O(n^{2) counter creation.}

Reviewed by darin

rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter): (WebCore::RenderCounter::originalText):

5:16 PM Changeset in webkit [21605] by bdash

12 edits
12 adds in trunk

2007-05-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=12729 box-shadow disappears when scrolling a div that it falls on/under

Tests: fast/repaint/box-shadow-dynamic.html

fast/repaint/box-shadow-h.html
fast/repaint/box-shadow-v.html

rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Factor in box shadow. (WebCore::InlineFlowBox::placeBoxesVertically): Ditto. (WebCore::InlineFlowBox::paint): Account for box shadow when checking if the damage rect intersects.
rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowHeight): For overflow areas, when asked for the "exterior" overflow, add box shadow overflow. (WebCore::RenderBlock::overflowWidth): Ditto. (WebCore::RenderBlock::overflowLeft): Ditto. (WebCore::RenderBlock::overflowTop): Ditto. (WebCore::RenderBlock::overflowRect): Ditto. (WebCore::RenderBlock::layoutBlock): Factor box shadow into visual overflow.
rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): Ditto.
rendering/RenderFlow.cpp: (WebCore::RenderFlow::lowestPosition): For overflow areas, when asked for the "exterior" extreme position, add box shadow. (WebCore::RenderFlow::rightmostPosition): Ditto. (WebCore::RenderFlow::leftmostPosition): Ditto.
rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateRects): Avoid clipping out box shadow.
rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Make sure to paint the box shadow when an edge with a shadow moves. (WebCore::RenderObject::adjustRectForOutlineAndShadow): Helper function that expands a given rectangle to encompass outline and box shadow. (WebCore::RenderObject::absoluteOutlineBox): Changed to include box shadow.
rendering/RenderObject.h:

2007-05-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

repaint tests and updated results for http://bugs.webkit.org/show_bug.cgi?id=12729 box-shadow disappears when scrolling a div that it falls on/under

fast/box-shadow/basic-shadows-expected.checksum:
fast/box-shadow/basic-shadows-expected.png:
fast/box-shadow/basic-shadows-expected.txt:
fast/repaint/box-shadow-dynamic-expected.checksum: Added.
fast/repaint/box-shadow-dynamic-expected.png: Added.
fast/repaint/box-shadow-dynamic-expected.txt: Added.
fast/repaint/box-shadow-dynamic.html: Added.
fast/repaint/box-shadow-h-expected.checksum: Added.
fast/repaint/box-shadow-h-expected.png: Added.
fast/repaint/box-shadow-h-expected.txt: Added.
fast/repaint/box-shadow-h.html: Added.
fast/repaint/box-shadow-v-expected.checksum: Added.
fast/repaint/box-shadow-v-expected.png: Added.
fast/repaint/box-shadow-v-expected.txt: Added.
fast/repaint/box-shadow-v.html: Added.

4:42 PM Changeset in webkit [21604] by bdash

4 edits in trunk/LayoutTests

2007-05-20 Mark Rowe <mrowe@apple.com>

Update test results after r21597.

fast/frames/viewsource-attribute-expected.checksum:
fast/frames/viewsource-attribute-expected.png:
fast/frames/viewsource-attribute-expected.txt:

4:11 PM Changeset in webkit [21603] by bdash

2 edits in trunk/WebCore

2007-05-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13783 REGRESSION (r21120): Frame resizers not repainted properly when dragged

rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layout):

4:09 PM Changeset in webkit [21602] by bdash

4 edits
4 adds in trunk

2007-05-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13774 REGRESSION: Crash emailing blog entry using Google Reader

Test: fast/table/stale-grid-crash.html

rendering/RenderTable.cpp: (WebCore::RenderTable::recalcSections): Made const and replaced setNeedsLayout(true) with an assertion that the table is already marked for layout. (WebCore::RenderTable::sectionAbove): Added call to recalcSectionsIfNeeded(). (WebCore::RenderTable::sectionBelow): Ditto. (WebCore::RenderTable::cellAbove): Ditto. (WebCore::RenderTable::cellBelow): Ditto. (WebCore::RenderTable::cellBefore): Ditto. (WebCore::RenderTable::cellAfter): Ditto.
rendering/RenderTable.h: Made some private member variables which are used in section recalc mutable. (WebCore::RenderTable::setNeedsSectionRecalc): Moved the call to setNeedsLayout() from recalcSections() into here, because I made recalcSections() const. (WebCore::RenderTable::recalcSectionsIfNeeded): Made const.

2007-05-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

test for http://bugs.webkit.org/show_bug.cgi?id=13774 REGRESSION: Crash emailing blog entry using Google Reader

fast/table/stale-grid-crash-expected.checksum: Added.
fast/table/stale-grid-crash-expected.png: Added.
fast/table/stale-grid-crash-expected.txt: Added.
fast/table/stale-grid-crash.html: Added.

3:54 PM Changeset in webkit [21601] by bdash

9 edits
4 adds in trunk

2007-05-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13320 rounded corners with drop shadows are really slow

Test for a rendering bug fixed by this patch:

fast/box-shadow/border-radius-big.html

No test for the performance ingredient.

platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::addRoundedRectClip): Made cross-platform. Changed to use a single clipping path. If all the radii cannot be accommodated, clips to a rect. (WebCore::GraphicsContext::clipOutRoundedRect): Changed to use a single clipping path. If all the radii cannot be accommodated, clips out a rect.
platform/graphics/GraphicsContext.h: Added clipOut(const Path&).
platform/graphics/Path.cpp: (WebCore::Path::createRoundedRectangle): Added. Returns a rounded rectangle with the specified radii. If all the radii cannot be accommodated, returns a rectangular path.
platform/graphics/Path.h:
platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clipOut): Added.
platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRoundedRect): Changed to use a single path. (WebCore::GraphicsContext::clipOut): Added.
platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clipOut): Added.

2007-05-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13320 rounded corners with drop shadows are really slow

fast/box-shadow/border-radius-big-expected.checksum: Added.
fast/box-shadow/border-radius-big-expected.png: Added.
fast/box-shadow/border-radius-big-expected.txt: Added.
fast/box-shadow/border-radius-big.html: Added.

6:14 AM Changeset in webkit [21600] by andersca

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=13771
Assertion failure ASSERT(m_layer) when running Hamachi fuzz tester

fast/frames/inline-object-inside-frameset-expected.txt: Added.
fast/frames/inline-object-inside-frameset.html: Added.

WebCore:

Reviewed by Mitz.

Test: fast/frames/inline-object-inside-frameset.html

http://bugs.webkit.org/show_bug.cgi?id=13771
Assertion failure ASSERT(m_layer) when running Hamachi fuzz tester

Don't paint inline objects.

rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::paint):

12:42 AM Changeset in webkit [21599] by hyatt

6 edits in trunk/WebCore

Add support for plain text MIME types (CSS/JS/TXT) to view source mode.
CSS/JS will eventually tokenize via their own special tokenizers so that
they can also be syntax-highlighted, but for now just treat them as
plain text.

Reviewed by aroben

dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument): (WebCore::HTMLViewSourceDocument::createTokenizer): (WebCore::HTMLViewSourceDocument::createContainingTable): (WebCore::HTMLViewSourceDocument::addViewSourceText): (WebCore::HTMLViewSourceDocument::addViewSourceToken):
html/HTMLViewSourceDocument.h:
loader/TextDocument.cpp: (WebCore::TextTokenizer::TextTokenizer): (WebCore::TextTokenizer::write):
loader/TextDocument.h: (WebCore::TextTokenizer::checkBuffer):

May 18, 2007:

11:48 PM Changeset in webkit [21598] by hyatt

2 edits in trunk/WebCore

Fix a glitch in view source mode attribute names.

html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken):

10:16 PM Changeset in webkit [21597] by hyatt

4 edits in trunk/WebCore

"Linkify" view source mode links.

Reviewed by andersca

css/view-source.css:
html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken): (WebCore::HTMLViewSourceDocument::addSpanWithClassName): (WebCore::HTMLViewSourceDocument::addLink):
html/HTMLViewSourceDocument.h:

7:05 PM Changeset in webkit [21596] by oliver

10 edits in trunk

2007-05-18 Oliver Hunt <oliver@apple.com>

WebCore:

Reviewed by Sam

No longer need to pass HTMLImageElement and HTMLImageLoader on to WebKit
Need to expose CachedResourceClient constructor

WebCore.exp:
WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Sam.

Fix for http://bugs.webkit.org/show_bug.cgi?id=13782
REGRESSION (r21528-r21533): Failing editing/selection/drag-in-iframe in pixel mode

r21533 made used a DOMElement as the source for promise data, this meant it had to
clear the dragging pasteboard following the drag. In DRT a drag is non-blocking
so this resulted in us prematurely clearing the pasteboard.

This patch avoids this problem by referencing the source CachedImage rather than the
DOMElement, so we don't need to worry about retaining an entire document forever, so
we don't need to clear the dragging pasteboard following the drag.

Misc/WebNSPasteboardExtras.mm: (imageFromElement): Extract the underlying CachedImage from a DOMElement (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]): Use a CachedImage instead of a DOMElement

WebCoreSupport/WebDragClient.mm: (WebDragClient::startDrag):

WebKit.xcodeproj/project.pbxproj:

WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLViewPrivate clear]): (-[WebHTMLView pasteboardChangedOwner:]): (-[WebHTMLView pasteboard:provideDataForType:]): (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): (-[WebHTMLView WebCore::]): (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]): Use CachedImage rather than DOMElement as promised data source

WebView/WebHTMLViewInternal.h:
WebView/WebHTMLViewPrivate.h:

4:32 PM Changeset in webkit [21595] by hyatt

1 edit in trunk/LayoutTests/http/tests/security/local-JavaScript-from-remote.html

Fix more malformed test cases.

4:32 PM Changeset in webkit [21594] by hyatt

2 edits in trunk/LayoutTests/fast/tokenizer

Fix more malformed test cases.

4:31 PM Changeset in webkit [21593] by hyatt

2 edits in trunk/LayoutTests/fast/parser

Fix more malformed test cases.

4:29 PM Changeset in webkit [21592] by hyatt

1 edit in trunk/LayoutTests/fast/loader/local-JavaScript-from-local.html

Fix more malformed test cases.

4:26 PM Changeset in webkit [21591] by hyatt

2 edits in trunk/LayoutTests/fast/dom/HTMLScriptElement

Fix more malformed test cases.

4:12 PM Changeset in webkit [21590] by hyatt

26 edits in trunk/LayoutTests/http/tests/navigation