Context Navigation

Needed to update SVGLength to handle the case where the SVGElement is
not the root document element -- we do this by falling back on the
renderer for the context.

For <svg> elements embedded as mixed content in xhtml we consider the
absolutePosition of the parent to be the origin for the <svg> element.

ksvg2/svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport):
ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::getScreenCTM):

7:14 PM Changeset in webkit [23391] by weinig

2 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Build fix.

WebCore.vcproj/WebCore.vcproj:

7:14 PM Changeset in webkit [21635] by thatcher

2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5084400> -[DOMRange lineBoxRects] returns an empty array when the DOM nodes have just been created

Do a updateLayoutIgnorePendingStylesheets before asking the Node or Range for it's box rects.

bindings/objc/DOM.mm: (-[DOMNode boundingBox]): (-[DOMNode lineBoxRects]): (-[DOMRange boundingBox]): (-[DOMRange lineBoxRects]):

6:42 PM Changeset in webkit [21634] by weinig

2 edits in trunk/WebCore

Reviewed by George Staikos.

Fix Qt build.

WebCore.pro: add missing IDL files.

6:29 PM Changeset in webkit [21633] by weinig

14 edits
1 add in trunk

LayoutTests:

Reviewed by Darin.

update tests and results for http://bugs.webkit.org/show_bug.cgi?id=13803 to account for the new JSHTMLMarquee that is being autogenerated and can now produce a constructor.

fast/dom/Window/element-constructors-on-window-expected.txt:
fast/dom/Window/element-constructors-on-window.html:
fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13803
Autogenerate the JS bindings for the HTMLMarqueeElement.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSHTMLElementWrapperFactory.cpp:
bindings/js/kjs_css.cpp: (KJS::DOMCSSRule::getOwnPropertySlot): Fix possible null pointer issue. (KJS::DOMCSSRule::put): Fix possible null pointer issue.
bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::JSHTMLElement::getOwnPropertySlot): Fix null pointer issue. (KJS::HTMLElementFunction::callAsFunction): (KJS::JSHTMLElement::put):
bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::start): (WebCore::HTMLMarqueeElement::stop):
html/HTMLMarqueeElement.h: Add start() and stop() functions.
html/HTMLMarqueeElement.idl: Added.
page/DOMWindow.idl: Add marquee constructor.

5:08 PM Changeset in webkit [21632] by adele

4 edits in trunk

WebCore:

Fix by Darin, reviewed by me.

Fix for <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts

platform/mac/WidgetMac.mm: (WebCore::safeRemoveFromSuperview): Added. If the view is the window's first responder, then set the window's first responder to nil so we don't leave the window pointing to a view that's no longer in it. (WebCore::Widget::setFocus): Don't attempt to focus the view if it has no window. (WebCore::Widget::removeFromSuperview): Call safeRemoveFromSuperview. (WebCore::Widget::afterMouseDown): ditto.

WebKit:

Fix by Darin, reviewed by me.

Fix for <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts

WebView/WebFrameView.mm: (-[WebFrameView _setDocumentView:]): If the old view is the first responder, then set the window's first responder to nil so we don't leave the window pointing to a view that's no longer in it.

4:13 PM Changeset in webkit [21631] by weinig

4 edits in trunk/LayoutTests

3:03 PM Changeset in webkit [21630] by hyatt

3 edits in trunk/WebCore

Make a line gutter backdrop so that tiny view source docs don't look
bad.

Reviewed by aroben

css/view-source.css:
html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable):

2:45 PM Changeset in webkit [23390] by adachan

4 edits in branches/WindowsMerge/WebKitWin

2007-05-21 Ada Chan <adachan@apple.com>

Reviewed by Steve.

Added IWebViewPrivate::loadBackForwardListFromOtherView(). It replicates the backforward
list from another webview and loads that in the current webview.

Interfaces/IWebViewPrivate.idl:
WebView.cpp: (WebView::loadBackForwardListFromOtherView):
WebView.h:

2:32 PM Changeset in webkit [21629] by hyatt

4 edits in trunk/WebCore

Make sure to distinguish between links to internal resources and
real links (anchors) in view source mode.

Reviewed by aroben

css/view-source.css:
html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken): (WebCore::HTMLViewSourceDocument::addLink):
html/HTMLViewSourceDocument.h:

1:00 PM Changeset in webkit [23389] by weinig

2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Build fix.

WebCore.vcproj/WebCore.vcproj:

12:37 PM S60CheckoutAndBuild edited by bradley.morrison@nokia.com

(diff)

12:35 PM S60IDE created by bradley.morrison@nokia.com

initial revision

12:07 PM Changeset in webkit [21628] by beidson

2 edits in trunk/WebKit

Making the importance of my last change more clear

WebView/WebViewPrivate.h: "Leave for Dashboard, people!"

11:55 AM S60ConfigureComputer edited by bradley.morrison@nokia.com

link to s60IDE page (diff)

11:45 AM Changeset in webkit [21627] by beidson

3 edits in trunk/WebKit

Reviewed by Kevin (Sarge)

<rdar://problem/5217124> - Re-add mistakenly removed SPI

WebView/WebView.mm: (-[WebView handleAuthenticationForResource:challenge:fromDataSource:]):
WebView/WebViewPrivate.h:

11:32 AM Changeset in webkit [21626] by spadma

2 edits in S60/branches/3.1m/WebKit

spadma

DESC: Update loc file layout

data/Webkit.loc:

11:32 AM Changeset in webkit [21625] by spadma

2 edits in S60/trunk/WebKit

spadma

DESC: Update loc file layout

data/Webkit.loc:

11:19 AM Changeset in webkit [21624] by weinig

17 edits in trunk

LayoutTests:

Reviewed by Adam and Darin.

update results for http://bugs.webkit.org/show_bug.cgi?id=13791 to account for new JSHTMLElements that are being autogenerated and can now produce constructors.

fast/dom/Window/element-constructors-on-window-expected.txt:
fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Adam and Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13791
Autogenerate the JS bindings for the HTMLIFrameElement and HTMLFrameElement.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSHTMLAnchorElementCustom.cpp:
bindings/js/JSHTMLElementWrapperFactory.cpp:
bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::HTMLElementFunction::callAsFunction):
bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
bindings/scripts/CodeGeneratorJS.pm:
html/HTMLFrameElement.idl:
html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::location):
html/HTMLFrameElementBase.h:
html/HTMLFrameOwnerElement.h: (WebCore::HTMLFrameOwnerElement::contentWindow):
html/HTMLIFrameElement.idl:
page/DOMWindow.idl:

10:57 AM Changeset in webkit [21623] by andersca

2 edits in trunk/WebKit

Reviewed by Ada.

<rdar://problem/5200816> REGRESSION: With Shiira 1.2.2 , I can't open embedded link in flash object by clicking (http:/www.adobe.com )

Null check the request.

WebView/WebView.mm: (+[WebView _canHandleRequest:]):

6:57 AM Changeset in webkit [21622] by lars

8 edits
6 adds in trunk/LayoutTestResults

Updating and adding test cases.

6:36 AM Changeset in webkit [21621] by lars

4 edits in trunk/WebKitQt

Reviewed by Simon

Remove the userHandle methods from QWebnetworkJob again.
They don't really give us anything and just clutter the API.

6:09 AM Changeset in webkit [21620] by hausmann

2 edits in trunk/WebKitQt

Export the new qt network API.

5:33 AM Changeset in webkit [21619] by lars

5 edits
3 adds
4 deletes in trunk

Reviewed by Zack.

Add an API layer for network downloads. Basically QWebnetworkInterface
is an interface class for downloading resources. QWebnetworkJob describes
the actual object to download.

QWebNetworkInterface has a default implementation that replaces the
old ResourceHandleManager class in the Qt port.

Remove the ResourceHandleManager class, it is now part of
QWebNetworkInterface. Adapt ResourceHandle to the new way
of things.

4:04 AM Changeset in webkit [21618] by mjs

15 edits in trunk/WebKit

Reviewed by Geoff.

<rdar://problem/5205358> REGRESSION (r21367): All messages appear entirely blank when running Mail off of tip of tree WebKit

The fix is to return nil from [WebFrame dataSource] when it has not loaded anything but the fake
empty initial document. However, WebKit still needs the real data source internally, so I also
added a [WebFrame _dataSource] method that skips this check, and made WebKit use it throughout.

Misc/WebNSAttributedStringExtras.mm: (fileWrapperForElement):
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView dataSource]):
Plugins/WebNullPluginView.mm: (-[WebNullPluginView viewDidMoveToWindow]):
Plugins/WebPluginController.mm: (-[WebPluginController URLPolicyCheckReferrer]):
WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge dataSource]): (-[WebFrameBridge redirectDataToPlugin:]):
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::makeDocumentView): (WebFrameLoaderClient::forceLayoutForNonHTML): (WebFrameLoaderClient::prepareForDataSourceReplacement): (WebFrameLoaderClient::canCachePage):
WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory bridgeForView:]):
WebKit.xcodeproj/project.pbxproj:
WebView/WebArchiver.mm: (+[WebArchiver archiveFrame:]): (+[WebArchiver archiveMainResourceForFrame:]): (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]): (+[WebArchiver archiveSelectionInFrame:]):
WebView/WebFrame.mm: (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _addChild:]): (-[WebFrame _dataSource]): (-[WebFrame DOMDocument]): (-[WebFrame dataSource]):
WebView/WebFrameInternal.h:
WebView/WebHTMLView.mm: (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]):
WebView/WebRenderNode.mm: (-[WebRenderNode initWithWebFrameView:]):
WebView/WebView.mm: (-[WebView _mainFrameOverrideEncoding]): (-[WebView mainFrameURL]): (-[WebView mainFrameTitle]): (-[WebView mainFrameIcon]): (-[WebView validateUserInterfaceItemWithoutDelegate:]): (-[WebView replaceSelectionWithArchive:]): (-[WebView _isLoading]): (-[WebView _performTextSizingSelector:withObject:onTrackingDocs:selForNonTrackingDocs:newScaleFactor:]): (-[WebView _notifyTextSizeMultiplierChanged]):

12:40 AM Changeset in webkit [21617] by hyatt

28 edits in trunk/LayoutTests/tables

Update test results for improved colgroup span handling.

12:31 AM Changeset in webkit [21616] by hyatt

4 adds in trunk/LayoutTests/fast/table

Add new layout test for spanning colgroup rules=groups bug.

12:30 AM Changeset in webkit [21615] by hyatt

5 edits in trunk/WebCore

Second half of fix for 13793, make sure rules=groups works properly with
spanning colgroups.

Also make sure colgroups get an actual span of 1 (instead of incorrectly
giving them a span of 0).

Reviewed by mitz

fast/table/colgroup-spanning-groups-rules.html

html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::HTMLTableColElement):
rendering/RenderTable.cpp: (WebCore::RenderTable::colElement):
rendering/RenderTable.h:
rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::collapsedLeftBorder): (WebCore::RenderTableCell::collapsedRightBorder):

May 20, 2007:

11:29 PM Changeset in webkit [21614] by hyatt

2 edits in trunk/WebCore

Half of a fix for 13793, make sure rules=groups and border behave properly
together.

Reviewed by mitz

No tests added, two Mozilla table tests now pass that failed before.

html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::getSharedCellDecl):

5:44 PM Changeset in webkit [21613] by bdash

1 edit in trunk/WebCore/loader/icon/IconLoader.cpp

Fix spelling.

3:55 PM Changeset in webkit [21612] by beidson

3 edits in trunk/WebCore

Reviewed by Geoose Garen

<rdar://problem/4758919> - Incorrect favicon shown for URL after going back

When restoring a cached page, we'd try to kick off the icon load for it, which ended up causing
shenanigans with the icon url -> page url mapping.

loader/FrameLoader.cpp: (WebCore::FrameLoader::endIfNotLoading): Only try an icon load if we're not restoring from the page cache (WebCore::FrameLoader::startIconLoader): Added helpful logging that helped me track this down (WebCore::FrameLoader::commitIconURLToIconDatabase): Ditto (and fixed a comment typo)

loader/icon/IconLoader.cpp: (WebCore::IconLoader::stopLoading): Don't null out the ResourceLoader here, as clearLoadingState() does that (WebCore::IconLoader::finishLoading): Added helpful logging that helped me track this down

2:14 PM Changeset in webkit [21611] by darin

6 edits in trunk/WebCore

Reviewed by Oliver Hunt.

fix <rdar://problem/5193416> REGRESSION: Selection on large pages extremely slow

dom/Document.cpp: (WebCore::Document::removeMarkers): Added an early exit for the common case where there are no markers. Changed code to iterate over all the nodes in the range instead of using TextIterator, which is more efficient.

page/Frame.cpp: (WebCore::Frame::respondToChangedSelection): Added checks for editable, so we don't bother doing work related to spell checking and grammar checking when changing the selection in non-editable text. Also rearranged the code so we only compute the old word boundaries and sentence boundaries when actually needed, and don't do the sentence range checks unless grammar checking is enabled.

platform/TextBreakIteratorICU.cpp: (WebCore::setUpIterator): Don't take a locale parameter. Always pass in currentTextBreakLocaleID. (WebCore::characterBreakIterator): Removed local parameter. (WebCore::wordBreakIterator): Ditto. (WebCore::lineBreakIterator): Ditto. (WebCore::sentenceBreakIterator): Ditto.

platform/mac/TextBreakIteratorInternalICUMac.mm: (WebCore::getTextBreakLocale): Broke out the code to actually get the locale. (WebCore::currentTextBreakLocaleID): This function now handles only the caching and calls getTextBreakLocale to actually figure it out.

editing/visible_units.cpp: Added lots of FIXME comments, but no code change.

11:36 AM Changeset in webkit [21610] by staikos

2 edits in trunk/WebCore

add -f to cp for some obscure build systems.

10:45 AM Changeset in webkit [21609] by staikos

2 edits in trunk/WebCore

Add missing include for auto_ptr

7:12 AM Changeset in webkit [21608] by ddkilzer

3 edits in trunk/WebKitTools

2007-05-20 David Kilzer <ddkilzer@webkit.org>

Reviewed by Adam Roben.

fix http://bugs.webkit.org/show_bug.cgi?id=13565 Change svn-create-patch to put LayoutTests in the end

In addition to reordering test files under the LayoutTests directory so that they
appear after source code files, this patch fixes an issue with prepare-ChangeLog
if the first argument passed to it is a file name instead of a directory name.

Scripts/prepare-ChangeLog: (isGIT()): If first value in @dirs array is a file, use dirname() to get the directory. (isSVN()): Ditto.
Scripts/svn-create-patch: (generateFileList($\%\%\%)): Differentiate test files in the LayoutTests directory from source code files.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed