Context Navigation

← Previous Period
Next Period →

Timeline

May 23, 2007:

11:01 PM Changeset in webkit [21700] by hyatt

1 edit in trunk/LayoutTests/fast/dom/background-shorthand-csstext.html

Remove a stray alert in a testcase that I wrote a while back.

10:58 PM Changeset in webkit [21699] by hyatt

2 adds in trunk/LayoutTests/fast/table

Add a table test for comment nodes.

10:48 PM Changeset in webkit [21698] by hyatt

3 edits in trunk/WebCore

Make the delete/InsertRows/Cells methods as well as the rowIndex method
able to work properly even when whitespace or comment nodes are present.

Reviewed by aroben

fast/table/rowindex-comment-nodes.html

html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::rowIndex): (WebCore::HTMLTableRowElement::insertCell): (WebCore::HTMLTableRowElement::deleteCell):
html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::insertRow): (WebCore::HTMLTableSectionElement::deleteRow):

10:39 PM Changeset in webkit [21697] by hyatt

4 adds in trunk/LayoutTests/fast/forms

Land optgroup DTD test.

10:36 PM Changeset in webkit [21696] by hyatt

3 edits in trunk/WebCore

<optgroup> should allow <script> and text nodes inside it, just like
<select> does.

Reviewed by aroben

fast/forms/stuff-on-my-optgroup.html

html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::checkDTD):
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::checkDTD):

10:33 PM Changeset in webkit [21695] by hyatt

4 adds in trunk/LayoutTests/fast/layers

Add gigantic z-index test.

10:23 PM Changeset in webkit [21694] by hyatt

2 edits in trunk/WebCore

Framesets should allow whitespace text nodes as children.

Reviewed by aroben

html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::checkDTD):

9:06 PM Changeset in webkit [23401] by aliceli1

2 edits in branches/WindowsMerge/LayoutTests

Reviewed by.

win/Skipped: remove fixed tests

8:28 PM Changeset in webkit [21693] by bdash

2 edits in trunk/WebCore

Fix the Qt build after r21685.

platform/qt/CursorQt.cpp: (WebCore::notAllowedCursor): (WebCore::zoomInCursor): (WebCore::zoomOutCursor):

8:23 PM Changeset in webkit [21692] by bdash

2 edits in trunk/WebCore

Reviewed by Adam.

Fix the gdk build following changes in r21685.

platform/gdk/CursorGdk.cpp: (WebCore::zoomInCursor): (WebCore::zoomOutCursor):

8:07 PM Changeset in webkit [21691] by hyatt

2 edits in trunk/WebCore

Fix for <rdar://problem/5222611> REGRESSION: Paint ordering problems at
http://buymeasoda.com/dev/issues/image_onload/image_onload.html

Clamp z-index so that values that exceed maxint (or that are below minint)
are clamped to those values.

Reviewed by darin

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):

7:13 PM Changeset in webkit [23400] by weinig

2 edits in branches/WindowsMerge/WebCore

Build fix.

WebCore.vcproj/WebCore.vcproj:

6:46 PM Changeset in webkit [21690] by ddkilzer

4 edits
4 adds in trunk

LayoutTests:

Reviewed by David Hyatt.

tests for http://bugs.webkit.org/show_bug.cgi?id=13563 REGRESSION: Crash loading message in Yahoo! Mail

fast/css/stale-style-selector-crash-1-expected.txt: Added.
fast/css/stale-style-selector-crash-1.html: Added.
fast/css/stale-style-selector-crash-2-expected.txt: Added.
fast/css/stale-style-selector-crash-2.html: Added.

WebCore:

Reviewed by David Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13563 REGRESSION: Crash loading message in Yahoo! Mail

Tests: fast/css/stale-style-selector-crash-1.html

fast/css/stale-style-selector-crash-2.html

dom/Document.cpp: (WebCore::Document::Document): Initialize the m_didCalculateStyleSelector flag to 'false'. (WebCore::Document::updateStyleSelector): Do not bail out if we have ever calculated a non-trivial style selector, even if at the moment we are pending style sheets. We could have calculated a non-trivial selector already either because at some point there were no pending style sheets (so the currently pending ones were added dynamically) or because we were forced to do a layout ignoring pending style sheets. Either way, once there is a style selector, we need to keep it up to date, otherwise we can crash under recalcStyle() during updateRendering() or simply not recalculate style correctly for dynamic changes. (WebCore::Document::recalcStyleSelector): Set m_didCalculateStyleSelector to 'true' when creating a new style selector.
dom/Document.h:

6:43 PM Changeset in webkit [21689] by andersca

3 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5224749> Show a zoom/unzoom cursor for resizable image documents

WebCore.xcodeproj/project.pbxproj: Install the zoom cursors.

loader/ImageDocument.cpp: (WebCore::ImageDocument::resizeImageToFit): Set the cursor to the zoom in cursor.

(WebCore::ImageDocument::restoreImageSize):
If the image fits, reset the cursor. Otherwise, set it to the zoom in cursor.

6:36 PM Changeset in webkit [21688] by andersca

5 edits in trunk/WebKit

Reviewed by Geoff.

<rdar://problem/3663808> Resize large images to fit in the browser window

Add new WebPreferences SPI.

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.m: (+[WebPreferences initialize]): (-[WebPreferences enableAutomaticImageResizing]): (-[WebPreferences setEnableAutomaticImageResizing:]):
WebView/WebPreferencesPrivate.h:
WebView/WebView.mm: (-[WebView _updateWebCoreSettingsFromPreferences:]):

6:11 PM Changeset in webkit [21687] by darin

1234 edits in trunk

LayoutTests:

Reviewed by Hyatt.

updated the many tests with an extra newline or two at the end because of the bug where plain-text serialization will consider nodes that are not rendered

WebCore:

Reviewed by Hyatt.

fix problems where unrendered nodes were affecting on plain text serialization

editing/TextIterator.cpp: (WebCore::TextIterator::advance): Don't call handleXXX functions or exitNode for nodes without renderers. (WebCore::shouldEmitNewlineAfterNode): Only consider rendered nodes when deciding if this is the last node in the document.

6:04 PM Changeset in webkit [23399] by andersca

2 edits in branches/WindowsMerge/WebCore

Fix build.

platform/win/CursorWin.cpp: (WebCore::zoomInCursor): (WebCore::zoomOutCursor):

6:01 PM Changeset in webkit [21686] by andersca

6 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/3663808> Resize large images to fit in the browser window

WebCore.exp: Add new settings method.

loader/ImageDocument.cpp: (WebCore::ImageEventListener::ImageEventListener): New class that handles resize events and click events and forwards them to the image document.

(WebCore::ImageTokenizer::ImageTokenizer):
(WebCore::ImageTokenizer::writeRawData):
(WebCore::ImageTokenizer::finish):
(WebCore::ImageDocument::ImageDocument):
(WebCore::ImageDocument::createDocumentStructure):
(WebCore::ImageDocument::cachedImage):
Let the ImageDocument class keep track of its document structure.

(WebCore::ImageDocument::scale):
Returns the scale that should be used when resizing the image.

(WebCore::ImageDocument::resizeImage):
Update the image size.

(WebCore::ImageDocument::imageClicked):
Toggle between resized and not resized. When restoring the size, scroll the image so that the area under
the mouse stays the same.

(WebCore::ImageDocument::imageChanged):
When the image size is known, resize the image if needed.

(WebCore::ImageDocument::restoreImageSize):
Restore the image size.

(WebCore::ImageDocument::imageNeedsResizing):
Return whether the image is too big for its window or not.

(WebCore::ImageDocument::windowSizeChanged):
Called when the window's size changes. Determine if the window fits or not and resize it if it doesn't fit.

(WebCore::ImageEventListener::handleEvent):
Forward events to the image document.

page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setEnableAutomaticImageResizing):
page/Settings.h: (WebCore::Settings::enableAutomaticImageResizing): Add new setting.

5:50 PM Changeset in webkit [21685] by andersca

7 edits
2 adds in trunk/WebCore

Reviewed by Darin.

Add -webkit-zoom-in and -webkit-zoom-out cursors.

Resources/zoomInCursor.png: Added.
Resources/zoomOutCursor.png: Added.
css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSValueKeywords.in:
page/EventHandler.cpp: (WebCore::selectCursor):
platform/Cursor.h:
platform/mac/CursorMac.mm: (WebCore::zoomInCursor): (WebCore::zoomOutCursor):
rendering/RenderStyle.h: (WebCore::):

5:01 PM Changeset in webkit [21684] by kevino

1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebView.cpp

Define rint ourselves for MSVS 2005 too, as it doesn't seem to be defined there either.

4:32 PM Changeset in webkit [21683] by weinig

6 edits in trunk/WebCore

Reviewed by Darin.

Part one of patch for http://bugs.webkit.org/show_bug.cgi?id=13830
Auto-generate JS DOM bindings for HTMLDocument and most of the rest
of HTMLElement

Just the HTMLElement part.

bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::getValueProperty): (KJS::JSHTMLElement::putValueProperty):
bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
html/HTMLElement.idl:

4:19 PM Changeset in webkit [21682] by kmccullo

4 edits
9 adds in trunk

LayoutTests:

Reviewed by Darin.

Update tests for http://bugs.webkit.org/show_bug.cgi?id=13830
Auto-generate JS DOM bindings for HTMLDocument and most of
the rest of HTMLElement

Corrects prototype chain for JSHTMLDocument and adds test for HTMLFormElement.

fast/dom/prototype-chain-expected.txt:
fast/dom/prototype-chain.html:

WebCore:

Reviewed by Darin.

rdar://problem/5183523
We now check the document's URL to see if it can load a resource in the case of a URL click, instead of checking the referrer, which is blank for local files.

loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::open):
platform/PlatformString.h: (WebCore::debugPrintString):

4:00 PM Changeset in webkit [21681] by weinig

20 edits
1 add in trunk

LayoutTests:

Reviewed by Darin.

Update tests for http://bugs.webkit.org/show_bug.cgi?id=13830
Auto-generate JS DOM bindings for HTMLDocument and most of
the rest of HTMLElement

Corrects prototype chain for JSHTMLDocument and adds test for HTMLFormElement.

fast/dom/prototype-chain-expected.txt:
fast/dom/prototype-chain.html:

WebCore:

Reviewed by Darin.

Part two of patch for http://bugs.webkit.org/show_bug.cgi?id=13830
Auto-generate JS DOM bindings for HTMLDocument and most of the rest
of HTMLElement

Just the HTMLDocument part.

WebCore.pro:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSHTMLDocumentCustom.cpp: Added. (WebCore::JSHTMLDocument::canGetItemsForName): (WebCore::JSHTMLDocument::nameGetter): (WebCore::JSHTMLDocument::all): (WebCore::JSHTMLDocument::setAll): (WebCore::JSHTMLDocument::location): (WebCore::JSHTMLDocument::setLocation): (WebCore::JSHTMLDocument::open): (WebCore::writeHelper): (WebCore::JSHTMLDocument::write): (WebCore::JSHTMLDocument::writeln): (WebCore::JSHTMLDocument::clear):
bindings/js/kjs_dom.cpp: (KJS::toJS):
bindings/js/kjs_dom.h:
bindings/js/kjs_html.cpp:
bindings/js/kjs_html.h:
bindings/objc/DOMPrivate.h:
bindings/scripts/CodeGeneratorJS.pm: Add [Deletable] property for Document.all and fix HasOverridingNameGetter to allow correct prototype chain
dom/Document.cpp: (WebCore::Document::plugins): adds alias to embeds() for bindings
dom/Document.h:
html/HTMLDocument.cpp: (WebCore::HTMLDocument::width): (WebCore::HTMLDocument::height): (WebCore::HTMLDocument::dir): (WebCore::HTMLDocument::setDir): (WebCore::HTMLDocument::designMode): (WebCore::HTMLDocument::setDesignMode): (WebCore::HTMLDocument::bgColor): (WebCore::HTMLDocument::setBgColor): (WebCore::HTMLDocument::fgColor): (WebCore::HTMLDocument::setFgColor): (WebCore::HTMLDocument::alinkColor): (WebCore::HTMLDocument::setAlinkColor): (WebCore::HTMLDocument::linkColor): (WebCore::HTMLDocument::setLinkColor): (WebCore::HTMLDocument::vlinkColor): (WebCore::HTMLDocument::setVlinkColor): (WebCore::HTMLDocument::captureEvents): (WebCore::HTMLDocument::releaseEvents):
html/HTMLDocument.h:
html/HTMLDocument.idl:

WebKit:

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13830
Auto-generate JS DOM bindings for HTMLDocument and most of the rest
of HTMLElement

MigrateHeaders.make: add DOMHTMLDocumentPrivate.h
WebKit.xcodeproj/project.pbxproj:

3:58 PM Changeset in webkit [21680] by hyatt

1 edit in trunk/WebCore/html/HTMLTokenizer.cpp

3:55 PM Changeset in webkit [21679] by hyatt

2 edits in trunk/WebCore

Fix for <rdar://problem/5221838> REGRESSION (r21581): no content in idisk
window at mac.com.

Back out the change to make self-closed <script/> into a Dashboard quirk
only.

Reviewed by aroben

html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):

1:53 PM Changeset in webkit [21678] by oliver

2 edits in trunk/WebKit

Reviewed by Geoff.

Fix for <rdar://problem/5223782> REGRESSION: Can't drag and drop a standalone image

The main resource for a standalone image webarchive has the same mimetype as the
underlying image.

Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):

1:28 PM Changeset in webkit [21677] by thatcher

2 edits in tags/WebCore-418.22/WebCore

Versioning.

1:27 PM Changeset in webkit [21676] by thatcher

2 edits in tags/WebCore-418.22/WebCore

Merge fix r21674.

1:26 PM Changeset in webkit [21675] by thatcher

1 copy in tags/WebCore-418.22

New tag.

1:24 PM Changeset in webkit [21674] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-10-05 Maciej Stachowiak <mjs@apple.com>

Reviewed by Eric.

<rdar://problem/4150976> Safari crashes in HTMLImageLoader::dispatchLoadEvent() on particular page (archive attached)

I couldn't figure out how to make an automated test for this; even once I got DumpRenderTree
to mouse in and out it did not crash.

khtml/html/html_imageimpl.cpp: (HTMLImageLoader::dispatchLoadEvent): Check if CachedImage is null before using it.

1:22 PM Changeset in webkit [21673] by thatcher

2 edits in tags/WebCore-418.21/WebCore

Rolling out a commit on the wrong tag.

1:17 PM Changeset in webkit [21672] by thatcher

2 edits in tags/WebCore-418.21/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-10-05 Maciej Stachowiak <mjs@apple.com>

Reviewed by Eric.

<rdar://problem/4150976> Safari crashes in HTMLImageLoader::dispatchLoadEvent() on particular page (archive attached)

I couldn't figure out how to make an automated test for this; even once I got DumpRenderTree
to mouse in and out it did not crash.

khtml/html/html_imageimpl.cpp: (HTMLImageLoader::dispatchLoadEvent): Check if CachedImage is null before using it.

10:19 AM Changeset in webkit [21671] by kmccullo

1 edit
2 adds in trunk/LayoutTests

Reviewed by.

Fixed build breakage.

fast/dom/open-and-close-by-DOM-expected.txt: Added.
fast/dom/open-and-close-by-DOM.html: Added.

10:11 AM Changeset in webkit [21670] by pyeh

2 edits in trunk/WebCore

<rdar://problem/5078453> AXNext/PrevLineEndTextMarkerForTextMarker returns kAXErrorNoValue for attachment range

Floating objects, such as aligned images, are not included as part of any line. So when the given
text marker is on the floating object, the returned line edge cannot be found and asserts are fired.
In addition, this paints an inconsistent text layout (in the accessibility sense) of where the floating
object resides. Character/word methods report floating object at the beginning of the text line(s). Yet
line methods never present floating objects anywhere.
To fix this, the ax line methods will now do more checking to ensure floating object nodes are included
when determining the line range/position. That way, assistive apps won't get stuck using the line methods
to read line-by-line

bridge/mac/WebCoreAXObject.mm: (updateAXLineStartForVisiblePosition): Added a helper method to adjust line start position to account for floating objects (-[WebCoreAXObject doAXLeftLineTextMarkerRangeForTextMarker:]): (-[WebCoreAXObject doAXRightLineTextMarkerRangeForTextMarker:]): (-[WebCoreAXObject doAXNextLineEndTextMarkerForTextMarker:]): (-[WebCoreAXObject doAXPreviousLineStartTextMarkerForTextMarker:]): Fixed up line routines to include floating object nodes in line position calculation. startOfLine/endOLine may return null for position next to a floating position. So now there's extra checks to prevent returning null line position/ranges back to AX.

10:02 AM Changeset in webkit [21669] by kmccullo

1 edit
2 deletes in trunk/LayoutTests

Reviewed by.

Removing failing tests until I've fixed them.

fast/dom/open-and-close-by-DOM-expected.txt: Removed.
fast/dom/open-and-close-by-DOM.html: Removed.

9:22 AM Changeset in webkit [21668] by hausmann

9 edits in trunk

Added support for per-QWebPage network interface handlers, clean up the
http and file loading and fixed a bug in the HTTP redirect handling.

8:45 AM Changeset in webkit [23398] by sfalken

2 edits in branches/WindowsMerge/WebKitWin

Build fix. Fix continuous rebuilding of Interfaces by turning off Generate Type Library for every IDL except WebKit.idl.

WebKit.vcproj/Interfaces.vcproj:

7:00 AM Changeset in webkit [21667] by rwlbuis

10 edits
4 adds in trunk

Reviewed by Dave Hyatt.

http://bugs.webkit.org/show_bug.cgi?id=13174
line-height in font shorthand does not override a previously stated line-height property

Make sure line-height is calculated against definite font-size and
uses the last set line-height, ie. directly or through font shorthand.

5:14 AM Changeset in webkit [21666] by lars

4 edits in trunk/WebKitQt

Reviewed by Zack

Don't do HTTP downloads in a second thread. Simplifies
the code significantly and fixes crashes on some
Web pages.

4:07 AM Changeset in webkit [21665] by lars

2 edits in trunk/WebCore

Reviewed by Zack and Valgrind

Initialize variable.

4:04 AM Changeset in webkit [21664] by rwlbuis

3 edits
4 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13784
REGRESSION (r13744-13750): Crash with empty gradient when drawing to canvas

Fix crash by testing for zero stops, and returning transparent black
in this case.

3:48 AM Changeset in webkit [21663] by rwlbuis

3 edits
4 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13801
Crash when loading nonexisting symbol

Check for referenced element and when not found just return.

3:01 AM Changeset in webkit [21662] by lars

3 edits in trunk/WebKitQt

Fix Host: line in HTTP headers and resolving of relative URLs
when redirecting and clean up qHash forward declaration a bit.

1:48 AM Changeset in webkit [21661] by hausmann

2 edits in trunk/WebKitQt

Fix signal/slot connection for load progress.

May 22, 2007:

10:37 PM Changeset in webkit [23397] by aliceli1

5 edits in branches/WindowsMerge/WebKitWin

Reviewed by Oliver.

Enabling smartInsertDelete to resolve
<rdar://problem/5082891> editing/deleting/smart-delete-003.html (and 004) fail

Interfaces/IWebView.idl:
WebEditorClient.cpp: (WebEditorClient::smartInsertDeleteEnabled):
WebView.cpp: (WebView::WebView): (WebView::initWithFrame): (WebView::toggleSmartInsertDelete): (WebView::setSmartInsertDeleteEnabled): (WebView::smartInsertDeleteEnabled):
WebView.h:

10:02 PM Changeset in webkit [21660] by bdash

1 edit in tags/Safari-5522.7.1/WebKit/Configurations/Version.xcconfig

Versioning.

9:52 PM Changeset in webkit [21659] by bdash

3 edits in tags/Safari-5522.7.1/WebKit

Merge in r21576.

9:46 PM Changeset in webkit [21658] by bdash

3 edits in tags/Safari-5522.7.1/WebKit

Merge in r21569.

9:05 PM Changeset in webkit [21657] by bdash

1 copy in tags/Safari-5522.7.1

New tag.

8:38 PM Changeset in webkit [21656] by weinig

2 edits in trunk/WebCore

Rubber stamped by Adam.

Fix license.

bindings/js/JSHTMLAnchorElementCustom.cpp:

6:26 PM Changeset in webkit [21655] by weinig

13 edits in trunk

LayoutTests:

Reviewed by Adam.

Update tests for http://bugs.webkit.org/show_bug.cgi?id=13833
Add ObjC DOM binding for HTMLMarqeeElement

fast/dom/wrapper-classes-expected.txt:
fast/dom/wrapper-classes.html: HTMLMarqueeElement now is a DOMHTMLMarqueeElement

WebCore:

Reviewed by Adam.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13833
Add ObjC DOM binding for HTMLMarqeeElement

Also adds missing DOMHTMLFramePrivate.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOM.mm: (WebCore::createElementClassMap):
bindings/objc/DOMHTML.h:
bindings/objc/DOMInternal.h:
bindings/objc/DOMPrivate.h:
bindings/objc/PublicDOMInterfaces.h:

WebKit:

Reviewed by Adam.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13833
Add ObjC DOM binding for HTMLMarqeeElement

Also adds missing DOMHTMLFramePrivate.

MigrateHeaders.make:

6:19 PM Changeset in webkit [21654] by justing

3 edits
7 adds in trunk

LayoutTests:

Reviewed by darin

http://bugs.webkit.org/show_bug.cgi?id=13804
REGRESSION(r21611): Several new layout test pixel failures (misspelling markers)

editing/selection/13804-expected.checksum: Added.
editing/selection/13804-expected.png: Added.
editing/selection/13804-expected.txt: Added.
editing/selection/13804.html: Added. These were missing:
editing/selection/5076323-1-expected.png: Added.
editing/selection/5076323-2-expected.png: Added.
editing/selection/5076323-3-expected.png: Added.

WebCore:

Reviewed by darin, who found the fix independently.

http://bugs.webkit.org/show_bug.cgi?id=13804
REGRESSION(r21611): Several new layout test pixel failures (misspelling markers)

r21611 exposed a bug in the way removeMarkers computes
the end of the range to remove markers from. It also
introduced a bug: removeMarkers expects a startOffset
and a length, not a startOffset and an endOffset (added
a layout test).

dom/Document.cpp: (WebCore::Document::removeMarkers): The other removeMarkers expects a startOffset and a length, not a startOffset and an endOffset. (WebCore::Document::removeMarkers): Fixed the endOffset from length and startOffset calculation.

5:55 PM Changeset in webkit [21653] by hyatt

2 adds in trunk/LayoutTests/fast/dom

Add layout test for better background dumping.

5:43 PM Changeset in webkit [21652] by hyatt

6 edits in trunk/WebCore

Fix for bug 13802, background colors can't be reset to default
color. Fix the value cssText method to do the right thing for background
and background-position values.

Reviewed by beth

fast/dom/background-shorthand-csstext.html

css/CSSInitialValue.h: (WebCore::CSSInitialValue:::m_implicit): (WebCore::CSSInitialValue::isImplicitInitialValue):
css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue): (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue):
css/CSSMutableStyleDeclaration.h:
css/CSSValue.h: (WebCore::CSSValue::isImplicitInitialValue):
css/cssparser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseBackgroundShorthand): (WebCore::CSSParser::parseShorthand):

4:47 PM Changeset in webkit [21651] by darin

10 edits in trunk

LayoutTests:

Reviewed by Geoff.

test for <rdar://problem/5215830> REGRESSION: ebay.com layout is wrong

fast/dom/iframe-document.html: Updated test to expect no document property.
fast/dom/iframe-document-expected.txt: Updated.

fast/forms/focus2.html: Changed test to use ownerDocument instead of document.

WebCore:

Reviewed by Geoff.

fix <rdar://problem/5215830> REGRESSION: ebay.com layout is wrong

The code on ebay was looking for the "document" property on a iframe.
We changed that to be the ownerDocument rather than the contentDocument,
which was not what ebay was expecting. The best fix seems to be removing
the document property altogether.

Test: fast/dom/iframe-document.html

bindings/js/kjs_html.h: Remove ElementDocument.
bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::getValueProperty): Ditto.

WebKit:

Reviewed by Geoff.

WebInspector/webInspector/treeoutline.js: Use ownerDocument instead of non-standard document property.

4:43 PM Changeset in webkit [21650] by adele

3 edits in trunk/WebCore

Reviewed by Darin.

A little cleanup from my last checkin.

page/Chrome.h: Formatting change.
page/mac/ChromeMac.mm: Fixed copyright.

4:21 PM Changeset in webkit [21649] by adele

6 edits
4 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for http://bugs.webkit.org/show_bug.cgi?id=13796
Crash in [NSInputContext currentInputContext] when you click on this map

fast/frames/frame-display-none-focus-expected.txt: Added.
fast/frames/frame-display-none-focus.html: Added.
fast/frames/resources/iframe-focus.html: Added.

WebCore:

Reviewed by Darin.

Fix for http://bugs.webkit.org/show_bug.cgi?id=13796
Crash in [NSInputContext currentInputContext] when you click on this map

This is another case of <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts

Test: fast/frames/frame-display-none-focus.html

WebCore.xcodeproj/project.pbxproj: Added ChromeMac.mm
page/Chrome.h:
page/mac/ChromeMac.mm: Added. (WebCore::Chrome::focusNSView): Moved code from Widget::setFocus so it can be used whenever we need to make a view the first responder.
page/mac/EventHandlerMac.mm: (WebCore::EventHandler::focusDocumentView): Calls focusNSView.
platform/mac/WidgetMac.mm: (WebCore::Widget::setFocus): Calls focusNSView.

4:18 PM Changeset in webkit [21648] by justing

10 edits
4 adds
4 deletes in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/4875189> List is deleted when replacing contents with Chinese/Japanese characters

Moved from unsupported-content because we've supported editing lists
for a while now:

editing/deleting/4875189-expected.checksum: Added.
editing/deleting/4875189-expected.png: Added.
editing/deleting/4875189-expected.txt: Added.
editing/deleting/4875189.html: Added.
editing/unsupported-content/list-delete-002-expected.checksum: Removed.
editing/unsupported-content/list-delete-002-expected.png: Removed.
editing/unsupported-content/list-delete-002-expected.txt: Removed.
editing/unsupported-content/list-delete-002.html: Removed.

Reflects new behavior:

editing/deleting/delete-select-all-003-expected.checksum:
editing/deleting/delete-select-all-003-expected.png:
editing/deleting/delete-select-all-003-expected.txt:

Ditto and also removed a FIXME:

editing/deleting/list-item-1-expected.checksum:
editing/deleting/list-item-1-expected.png:
editing/deleting/list-item-1-expected.txt:
editing/deleting/list-item-1.html:

WebCore:

Reviewed by darin

<rdar://problem/4875189>
List is deleted when replacing contents with Chinese/Japanese characters

editing/htmlediting.cpp: (WebCore::isSpecialElement): Lists are no longer special. They can be removed by removing their content and then then hitting delete inside of the empty list item that's left over. Even when that list item is the first thing in the editable region.

4:02 PM Changeset in webkit [21647] by adele

2 edits in trunk/WebKit

Reviewed by Darin.

Adding some asserts to help detect other cases of <rdar://problem/5171145>

WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge makeFirstResponder:]):

3:59 PM Changeset in webkit [21646] by darin

3 edits in trunk/WebCore

Reviewed by Tim Hatcher.

fix <rdar://problem/5206089> REGRESSION: hovering over amazon.com "product categories" tab makes page content disappear

The contentWindow property was doing a cross-frame security check, but it shouldn't.
Window objects are responsible for protecting themselves from cross-frame activity.
Because contentWindow returned undefined, we then ended up setting visibility on the
body of the main frame to "hidden".

No layout test yet. When we make cross-domain tests, we should include this one.

html/HTMLFrameElement.idl: Removed CheckFrameSecurity attribute from contentWindow.
html/HTMLIFrameElement.idl: Ditto.

3:53 PM Changeset in webkit [23396] by adachan

2 edits in branches/WindowsMerge/WebCore

2007-05-22 Ada Chan <adachan@apple.com>

Fix build.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handleMouseEvent):

3:52 PM Changeset in webkit [21645] by kmccullo

1 edit
4 adds in trunk/LayoutTests

Reviewed by.

Forgot to checkin for fix for rdar://problem/4981886

fast/dom/open-and-close-by-DOM-expected.txt: Added.
fast/dom/open-and-close-by-DOM.html: Added.
fast/dom/resources/close.html: Added.
fast/dom/resources/middle.html: Added.
http/tests/security/local-image-from-remote.html:

2:57 PM Changeset in webkit [23395] by aliceli1

2 edits in branches/WindowsMerge/LayoutTests

Reviewed by.

win/Skipped: removed fixed tests

2:38 PM Changeset in webkit [23394] by justing

4 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by oliver

Build fix.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handleMouseEvent):

WebKitWin:

Reviewed by oliver

Build fix.

WebView.cpp: (WebView::clearFocusNode):

2:17 PM Changeset in webkit [23393] by sfalken

4 edits in branches/WindowsMerge/WebKitWin

Reviewed by Ada.

Added 3 view-related methods to IWebFramePrivate.

Interfaces/IWebFramePrivate.idl: Added 3 new methods
WebFrame.cpp: (WebFrame::hasScrollBars): Added. (WebFrame::contentBounds): Added. (WebFrame::frameBounds): Added.
WebFrame.h:

1:49 PM Changeset in webkit [21644] by yongjzha

4 edits in S60/trunk/JavaScriptCore

2007-05-22 bujtas <zbujtas@gmail.com>

Reviewed by Yongjun
DESC: fix out of boundary crah in prce
http://bugs.webkit.org/show_bug.cgi?id=13826

pcre/internal.h:
pcre/pcre.c: (check_escape): (is_counted_repeat): (read_repeat_counts): (check_posix_syntax): (compile_branch): (pcre_compile): (match):
pcre/study.c: (set_bit): (set_start_bits):

1:43 PM Changeset in webkit [21643] by yongjzha

4 edits in S60/branches/3.1m/JavaScriptCore

2007-05-22 bujtas <zbujtas@gmail.com>

Reviewed by Yongjun
DESC: fix out of boundary crah in prce
http://bugs.webkit.org/show_bug.cgi?id=13826

pcre/internal.h:
pcre/pcre.c: (check_escape): (is_counted_repeat): (read_repeat_counts): (check_posix_syntax): (compile_branch): (pcre_compile): (match):
pcre/study.c: (set_bit): (set_start_bits):

12:02 PM Changeset in webkit [21642] by justing

11 edits
4 adds in trunk

LayoutTests:

Reviewed by oliver

<rdar://problem/5213963>
REGRESSION(r21467): Active selection remains in text field after clicking on a button

Demonstrates bug:

editing/selection/5213963-expected.checksum: Added.
editing/selection/5213963-expected.png: Added.
editing/selection/5213963-expected.txt: Added.
editing/selection/5213963.html: Added. We now clear the selection on mouse down (but not before the mousedown event is fired):
fast/forms/focus-selection-input-expected.txt:
fast/forms/focus-selection-textarea-expected.txt:

WebCore:

Reviewed by oliver

<rdar://problem/5213963>
REGRESSION(r21467): Active selection remains in text field after clicking on a button

page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent): Call FocusController::setFocusedNode, because Document::setFocusedNode no longer clears the selection. Begin passing the new focused frame to FocusController::setFocusedNode, because when the new focus node is null, the selection should only be cleared if the focused frame isn't changing. (WebCore::Element::focus): Begin passing the new focused frame. (WebCore::Element::blur): Ditto.
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::focus): Ditto.
html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::focus): Ditto.
page/Frame.cpp: (WebCore::Frame::setFocusedNodeIfNeeded): Ditto.
page/FocusController.cpp: (WebCore::clearSelectionIfNeeded): Take in the new focused frame. If it's not changing, don't clear the selection. (WebCore::FocusController::setFocusedNode): Take in the new focused frame.
page/FocusController.h:

12:02 PM Changeset in webkit [21641] by beidson