⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 24, 2007:

11:58 PM Changeset in webkit [21746] by hyatt
  • 8 edits in trunk/WebCore

Rework line numbering (again). This time I finally think I have
it right for all the document.write insanity that can occur.

Reviewed by aroben

  • html/HTMLParser.cpp: (WebCore::HTMLParser::reportErrorToConsole):
  • html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserDocumentWriteMessage):
  • html/HTMLParserErrorCodes.h:
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write):
  • html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::lineNumberPtr): (WebCore::HTMLTokenizer::processingContentWrittenByScript):
  • platform/SegementedSring.cpp (WebCore::SegmentedString::setExcludeLineNumbers):
  • platform/SegmentedString.h: (WebCore::SegmentedSubstring::SegmentedSubstring): (WebCore::SegmentedSubstring::clear): (WebCore::SegmentedSubstring::excludeLineNumbers): (WebCore::SegmentedSubstring::setExcludeLineNumbers): (WebCore::SegmentedString::excludeLineNumbers): (WebCore::SegmentedString::advance):
11:56 PM Web Inspector edited by smith@sideshowbarker.net
boldface Inspect Element (diff)
11:48 PM Web Inspector edited by smith@sideshowbarker.net
added WI UI image (diff)
11:13 PM Changeset in webkit [21745] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

Added a debug-only CachedPage counter. This helped me track down an SVG
timer bug in my recent page cache work.


  • history/CachedPage.cpp:
11:05 PM Changeset in webkit [21744] by sfalken
  • 1 copy in tags/Safari-522.8.3b

New tag.

9:42 PM Changeset in webkit [21743] by hyatt
  • 4 edits in trunk/WebCore

Improve <form> error reporting to catch <form>s inside table parts.
Tweak the wording of some of the error messages to be a bit better.

Reviewed by olliej

  • html/HTMLParser.cpp: (WebCore::HTMLParser::insertNode): (WebCore::HTMLParser::processCloseTag): (WebCore::HTMLParser::popBlock):
  • html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate):
  • html/HTMLParserErrorCodes.h:
6:28 PM Changeset in webkit [21742] by weinig
  • 6 edits
    8 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test cases for:
​http://bugs.webkit.org/show_bug.cgi?id=4104
first-letter not updating style with hover
​http://bugs.webkit.org/show_bug.cgi?id=13169
css-formatted first letter won't hide dynamically

  • fast/css/first-letter-hover-expected.checksum: Added.
  • fast/css/first-letter-hover-expected.png: Added.
  • fast/css/first-letter-hover-expected.txt: Added.
  • fast/css/first-letter-hover.html: Added.
  • fast/css/first-letter-visibility-expected.checksum: Added.
  • fast/css/first-letter-visibility-expected.png: Added.
  • fast/css/first-letter-visibility-expected.txt: Added.
  • fast/css/first-letter-visibility.html: Added.

WebCore:

Reviewed by Hyatt.

​http://bugs.webkit.org/show_bug.cgi?id=4104
first-letter not updating style with hover
​http://bugs.webkit.org/show_bug.cgi?id=13169
css-formatted first letter won't hide dynamically

Update first letter when RenderBlock::setStyle is called.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::createElement):
  • dom/Document.h: (WebCore::Document::usesFirstLetterRules): (WebCore::Document::setUsesFirstLetterRules):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::setStyle): (WebCore::RenderBlock::updateFirstLetter):
6:15 PM Changeset in webkit [21741] by kevino
  • 5 edits in branches/wx-port-alpha/trunk/WebCore/platform

Fix crash caused by Widget::setCursor not checking for a null implementation. This can happen because we don't implement image cursors yet. Also add a wxBitmap accessor to BitmapImage to make it easier to add such support in the future.

5:09 PM Creating and Submitting Layout Tests and Patches created by KWhiteRight@gmail.com
4:57 PM Changeset in webkit [21740] by weinig
  • 5 edits in trunk/LayoutTests

Reviewed by Darin.

Updated the test and the results.

  • fast/forms/select-item-background-clip-expected.checksum:
  • fast/forms/select-item-background-clip-expected.png:
  • fast/forms/select-item-background-clip-expected.txt:
  • fast/forms/select-item-background-clip.html:
4:51 PM Changeset in webkit [21739] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/forms/slider-thumb-shared-style-expected.checksum: Added.
  • fast/forms/slider-thumb-shared-style-expected.png: Added.
  • fast/forms/slider-thumb-shared-style-expected.txt: Added.
  • fast/forms/slider-thumb-shared-style.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/slider-thumb-shared-style.html

RenderSlider mutates the thumb's style, therefore it must not be shared
with another slider's thumb, a situation that could occur if the sliders
themselves shared style.

  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::createThumbStyle): Always use a private copy for the thumb style.
4:48 PM Changeset in webkit [21738] by adele
  • 6 edits
    3 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/5211921> Form values sometimes get transposed (iGoogle)

  • fast/history/redirect-load-no-form-restoration-expected.txt: Added.
  • fast/history/redirect-load-no-form-restoration.html: Added.
  • fast/history/resources/redirect-load.html: Added.

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5211921> Form values sometimes get transposed (iGoogle)

Test: fast/history/redirect-load-no-form-restoration.html

  • history/HistoryItem.cpp: (WebCore::HistoryItem::setURL): Clear the document state when the url changes for a HistoryItem. (WebCore::HistoryItem::isCurrentDocument): Added. Compares the HistoryItem url to the document's url. This might not be the best way to do this, but it works for now.
  • history/HistoryItem.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::saveDocumentState): Only set the document (and form) state if the document is current for the history item.
4:36 PM WikiStart edited by KWhiteRight@gmail.com
(diff)
4:35 PM Changeset in webkit [21737] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/Bakefiles/presets.bkl

Remove tabs that accidently got into the file.

4:28 PM Changeset in webkit [21736] by weinig
  • 5 edits in trunk/JavaScriptCore

Reviewed by Darin

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=13855
Port patch 666176 to JavaScriptCore

  • Renamed JSValue::downcast() to JSValue::asCell() which makes the function meaning cleaner. It's modeled after Harri Porten change in KDE trunk.
  • kjs/collector.cpp: (KJS::Collector::protect): (KJS::Collector::unprotect): (KJS::Collector::collectOnMainThreadOnly):
  • kjs/object.h: (KJS::JSValue::isObject):
  • kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction):
  • kjs/value.h: (KJS::JSValue::asCell): (KJS::JSValue::isNumber): (KJS::JSValue::isString): (KJS::JSValue::isObject): (KJS::JSValue::getNumber): (KJS::JSValue::getString): (KJS::JSValue::getObject): (KJS::JSValue::getUInt32): (KJS::JSValue::mark): (KJS::JSValue::marked): (KJS::JSValue::type): (KJS::JSValue::toPrimitive): (KJS::JSValue::toBoolean): (KJS::JSValue::toNumber): (KJS::JSValue::toString): (KJS::JSValue::toObject):
4:20 PM Changeset in webkit [21735] by hyatt
  • 59 edits in trunk/LayoutTests/tables

Update results for better whitespace handling in framesets and tables.

4:05 PM Changeset in webkit [21734] by weinig
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adele.

  • fast/forms/select-double-onchange-expected.txt: Added.
  • fast/forms/select-double-onchange.html: Added.

WebCore:

Reviewed by Adele.

Test: fast/forms/select-double-onchange.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::menuListOnChange): Changed to update m_lastOnChangeIndex before dispatching the change event to avoid reentrancy.
3:58 PM Changeset in webkit [21733] by hyatt
  • 3 edits in trunk/LayoutTests/webarchive

Update results for better whitespace handling in framesets and tables.

3:56 PM Changeset in webkit [21732] by darin
  • 13 edits in trunk/WebCore

Reviewed by Hyatt.

  • fix <rdar://problem/5226451> REGRESSION (21618): Mail block quotes are missing the lines on the side

This patch fixes three problems:

1) makes the "skip canLoad check" boolean also skip the check

that prevents any loads while the document is in provisional
state; this is the proximate cause of the bug

  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Don't check the frame's state if skipCanLoadCheck is true.

2) moves the "skip canLoad check" boolean to the Request object;

the old implementation would cause that flag to affect the
new request we served, which might not be the resource with
that flag set

3) fixes error-handling code path that would leak requests

  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement): Pass false to the CachedImage constructor to indicate we are not making this object for the cache.
  • loader/Cache.cpp: (WebCore::createResource): Pass true to the CachedImage constructor to indicate we are making this object for the cache. (WebCore::Cache::requestResource): Add new code that assumes the object will already have the inCache bit set, and that will delete the object and return 0 if the cache is disabled and the load failed.
  • loader/CachedImage.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): Added a forCache boolean parameter. Always false for the constructor that's only used outside the cache code, and passed in as a boolean for the constructor that's used both in cache and outside cache.
  • loader/CachedResource.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): Added a forCache boolean parameter that determines the initial state of the m_inCache flag. This is needed to prevent a resource from being destroyed if an error occurs during the initial load.
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestCSSStyleSheet): Added FIXME. (WebCore::DocLoader::setLoadInProgress): Added null check.
  • loader/Request.h:
  • loader/Request.cpp: (WebCore::Request::Request): Added a shouldSkipCanLoadCheck boolean here, since we need to track this for each request.
  • loader/loader.h:
  • loader/loader.cpp: (WebCore::Loader::load): Pass the skipCanLoadCheck boolean to the Request constructor rather than to the servePendingRequests function. (WebCore::Loader::servePendingRequests): Add a loop so we can handle cases where the request fails immediately without leaking the request and thinking that we're loading forever.
3:29 PM Changeset in webkit [21731] by hyatt
  • 4 edits in trunk/WebCore

Add error reporting for residual style.

Reviewed by aroben

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): (WebCore::HTMLParser::reopenResidualStyleTags):
  • html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate):
  • html/HTMLParserErrorCodes.h:
3:13 PM Changeset in webkit [21730] by darin
  • 2 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
2:49 PM Changeset in webkit [21729] by hyatt
  • 24 edits in trunk/LayoutTests/dom/xhtml/level2/html

Land updated tests.

1:57 PM Changeset in webkit [21728] by oliver
  • 2 edits in trunk/WebKit

2007-05-24 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam, Darin, and Geoff.

Fix for <rdar://problem/5000470> REGRESSION: The IM reconvert
function returns incorrect symbol due to inconsistent range
domains in TSM

Text Services Management uses ranges provided by the
NSTextInput API to index into the string return by
-[WebHTMLView string]. As a result some input methods
incorrectly get their candidate text from the beginning
of the document instead of from the input element.

TSM prefers to query -textStorage over -string so as a
workaround we provide an implementation of -textStorage that
returns the content of the current text input. TSM only ever
queries the result of textStorage as an NSAttributedString so
we do not need to implement a fake NSTextStorage class

This should not cause harm to anything else as textStorage is
actually a method on NSTextView, which we clearly are not. TSM
only queries the method because it uses respondsToSelector to
control behaviour.

  • WebView/WebHTMLView.mm: (-[WebHTMLView textStorage]):
1:45 PM Changeset in webkit [21727] by hyatt
  • 4 edits in trunk/WebCore

Report <script/> as a warning instead of an error for now, since we
actually do close it. (Sigh.)

Reviewed by beth

  • html/HTMLParser.cpp: (WebCore::HTMLParser::parseToken): (WebCore::HTMLParser::reportErrorToConsole):
  • html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate): (WebCore::isWarning):
  • html/HTMLParserErrorCodes.h:
1:26 PM Changeset in webkit [21726] by hyatt
  • 5 edits in trunk/WebCore

Add error reporting for the </p> -> <p></p> quirk.

Add error reporting when a stray close tag is encountered with no
corresponding open tag.

Reviewed by adele

  • html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser): (WebCore::HTMLParser::processCloseTag): (WebCore::HTMLParser::popBlock):
  • html/HTMLParser.h: (WebCore::HTMLParser::popBlock):
  • html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate):
  • html/HTMLParserErrorCodes.h:
1:16 PM Changeset in webkit [21725] by kmccullo
  • 2 edits in trunk/LayoutTests

Reviewed by.

  • Do you ever feel like Charlie Brown? *sigh*
  • fast/dom/HTMLHeadElement/resources/head-check.js:
1:06 PM Changeset in webkit [21724] by kmccullo
  • 5 edits
    9 deletes in trunk

LayoutTests:

Reviewed by.

  • Rolling back change to fix the build until I have a good fix for data: urls.
  • ChangeLog:
  • fast/dom/HTMLHeadElement/resources/head-check.js:
  • fast/dom/frame-loading-via-document-write-expected.txt: Removed.
  • fast/dom/frame-loading-via-document-write.html: Removed.
  • fast/dom/resources/frame-loading-via-document-write.js: Removed.
  • fast/dom/resources/green250x50.png: Removed.
  • fast/dom/resources/success.html: Removed.
  • http/tests/security/frame-loading-via-document-write-expected.txt: Removed.
  • http/tests/security/frame-loading-via-document-write.html: Removed.
  • http/tests/security/resources/frame-loading-via-document-write.js: Removed.
  • http/tests/security/resources/success.html: Removed.

WebCore:

Reviewed by.

  • Rolling back change to fix the build until I have a good fix for data: urls.
  • ChangeLog:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::open):
  • platform/String.cpp:
12:54 PM Changeset in webkit [21723] by hyatt
  • 6 edits in trunk/WebCore

Add two more error messages to the HTMLParser.

Report when the </br> -> <br> quirk is triggered.

Also report whenever the broken XML self-closing tag syntax is used on
tags that can actually have an end tag (either optional or required).

Reviewed by aroben

  • html/HTMLParser.cpp: (WebCore::HTMLParser::parseToken):
  • html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate):
  • html/HTMLParserErrorCodes.h: (WebCore::):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
  • html/HTMLTokenizer.h: (WebCore::Token::reset):
12:47 PM Changeset in webkit [21722] by spadma
  • 2 edits in S60/trunk/WebKit

deepa, reviewed by Sachin

DESC: [S60] Scrollbar covers some parts of web page in RTL mode (MNAN-734F5H)
​http://bugs.webkit.org/show_bug.cgi?id=13831

  • BrowserControl/src/BrCtl.cpp:
11:47 AM Changeset in webkit [23406] by weinig
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by NOBODY (OOPS!).

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
11:34 AM Changeset in webkit [23405] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://5211882>
Need to relaunch Boomer to recognize newly installed QT plug-in


<rdar://5061867>
After installing Flash, Safari would still not display pages that needed it


  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::refresh): Return whether the plugin database changed or not.


(WebCore::PluginDatabaseWin::findPlugin):
New function that tries to find a plug-in given its url and MIME type.


(WebCore::PluginDatabaseWin::createPluginView):
If no plugin is found, refresh the database and search for the plugin again if the database changed.

11:30 AM Changeset in webkit [21721] by weinig
  • 2 edits
    1 move in trunk/WebCore

Reviewed by Anders.

Rename JSHTMLFrameSetCustom.cpp to JSHTMLFrameSetElementCustom.cpp
for consistency.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLFrameSetCustom.cpp: Removed.
  • bindings/js/JSHTMLFrameSetElementCustom.cpp: Added.
11:26 AM Changeset in webkit [21720] by hyatt
  • 6 edits in trunk/WebCore

Fix for <rdar://problem/5208440> (13753)

REGRESSION: Raw text needs to be pulled outside of tables

Reviewed by aroben

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
  • html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::checkDTD):
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::checkDTD):
  • html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::checkDTD):
  • html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::checkDTD):
10:55 AM Changeset in webkit [23404] by adele
  • 2 edits in branches/WindowsMerge/WebCore
10:45 AM Changeset in webkit [21719] by adele
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/forms/menulist-separator-painting-expected.checksum: Added.
  • fast/forms/menulist-separator-painting-expected.png: Added.
  • fast/forms/menulist-separator-painting-expected.txt: Added.
  • fast/forms/menulist-separator-painting.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/menulist-separator-painting.html

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawConvexPolygon): Changed this function to actually do both filling and stroking when needed, even though all existing callers set the stroke to none.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuListButton): Added calls to set the stroke style and thickness when painting the arrows and the separator.
10:40 AM Changeset in webkit [21718] by thatcher
  • 3 edits in trunk/WebCore

Reviewed by Sam Weinig.

Remove the OBJC_NEW_PROPERTIES #ifdef and only export the new @property syntax.

  • bindings/objc/DOMObject.h:
  • bindings/scripts/CodeGeneratorObjC.pm:
10:36 AM Changeset in webkit [21717] by spadma
  • 1 edit in S60/trunk/S60Internals/S60Headers.zip

Update S60Headers.zip for font access

10:20 AM Changeset in webkit [21716] by weinig
  • 5 edits in trunk

LayoutTests:

Reviewed by Anders.

  • update results to account for the new JSHTMLFrameSetElement that is being autogenerated and can now produce a constructor.
  • fast/dom/Window/element-constructors-on-window-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Anders.

Uncomment HTMLFramesSetElement constructor now that it exists.

  • page/DOMWindow.idl:
10:04 AM Changeset in webkit [21715] by andersca
  • 2 edits in trunk/WebCore

Try fixing the buildbot build.


  • loader/ImageDocument.cpp: (WebCore::ImageDocument::resizeImageToFit): (WebCore::ImageDocument::imageClicked):
9:57 AM Changeset in webkit [23403] by weinig
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
9:39 AM Changeset in webkit [21714] by weinig
  • 8 edits
    1 add in trunk/WebCore

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=13853
Autogenerate the JS bindings for the HTMLFrameSetElement

  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLElementWrapperFactory.cpp:
  • bindings/js/JSHTMLFrameSetCustom.cpp: Added. (WebCore::JSHTMLFrameSetElement::canGetItemsForName): (WebCore::JSHTMLFrameSetElement::nameGetter):
  • bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::JSHTMLElement::getOwnPropertySlot):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
  • html/HTMLFrameSetElement.idl:
9:25 AM Changeset in webkit [21713] by ddkilzer
  • 1 edit in trunk/LayoutTests/ChangeLog

Remove conflict markers.

9:06 AM Changeset in webkit [21712] by spadma
  • 14 edits in S60/trunk

yongjzha, reviewed by sachin

DESC: enable font access api.
​http://bugs.webkit.org/show_bug.cgi?id=13832

WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCoreTextRendererFactory.h:
  • khtml/rendering/font.cpp: (Font::update):
  • kwq/KWQFont.cpp: (QFont::QFont): (QFont::operator= ): (QFont::Renderer): (QFont::setGenericFamily):
  • kwq/KWQFont.h:
8:41 AM Changeset in webkit [21711] by zack
  • 2 edits in trunk/WebCore

Fixing check for incorrent font size - it should
check fixed not normal.

r=andersca

8:11 AM Changeset in webkit [21710] by harrison
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher.

<rdar://problem/5225343> REGRESSION: With View Source window opened, navigating to a different URL in the browser window results in a crash at WebCore::FrameLoader::frameHasLoaded()


_private->loader->frameLoader() was not being nil checked.

  • WebView/WebDataSource.mm: (-[WebDataSource request]): Add nil check for _private->loader->frameLoader()
7:10 AM Changeset in webkit [21709] by hausmann
  • 2 edits in trunk/WebKitQt

Fix multipart HTTP POSTs in the Qt port

5:37 AM Changeset in webkit [21708] by bdash
  • 2 edits in trunk/WebCore

Speculative buildbot build fix.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
2:53 AM Changeset in webkit [21707] by aroben
  • 1 edit in trunk/WebCore/page/Chrome.cpp

Didn't mean to commit this

2:42 AM Changeset in webkit [21706] by aroben
  • 11 edits in trunk/WebCore

Made Chrome::addMessageToConsole more flexible

addMessageToConsole now takes two additional parameters to specify the
message source (HTML, JS, CSS, XML) and level (error, warning, log). To
maintain our old behavior, all current messages were given
JSMessageSource and ErrorMessageLevel parameters. Messages matching
these characteristics are passed up to the ChromeClient.

Reviewed by Hyatt.

2:42 AM Changeset in webkit [21705] by zimmermann
  • 630 edits in branches/feature-branch

Reviewed by Oliver.

Add new code path dumping SVG text engine specific layout test results.
Finally the dumped results are actually accurate and respond to the
rendered glyphs. This has never been correct so far.

1:56 AM Changeset in webkit [21704] by hyatt
  • 8 edits in trunk/WebCore

Rework how HTML handles line numbering so that it is not fooled by
\r without a following \n and so that document.write doesn't lead
to line numbering confusion.

Reviewed by aroben

  • html/HTMLParser.cpp: (WebCore::HTMLParser::reportErrorToConsole):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::processListing): (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseComment): (WebCore::HTMLTokenizer::parseServer): (WebCore::HTMLTokenizer::parseProcessingInstruction): (WebCore::HTMLTokenizer::parseText): (WebCore::HTMLTokenizer::parseEntity): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::write): (WebCore::HTMLTokenizer::processToken): (WebCore::HTMLTokenizer::setSrc):
  • html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::lineNumberPtr):
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addLine):
  • loader/TextDocument.cpp: (WebCore::TextTokenizer::write):
  • platform/SegmentedString.cpp: (WebCore::SegmentedString::SegmentedString): (WebCore::SegmentedString::operator=): (WebCore::SegmentedString::clear):
  • platform/SegmentedString.h: (WebCore::SegmentedString::SegmentedString): (WebCore::SegmentedString::advance): (WebCore::SegmentedString::escaped):
1:47 AM Changeset in webkit [21703] by hyatt
  • 2 edits in trunk/LayoutTests/fast/css

Update some tests that darin missed.

1:46 AM Changeset in webkit [21702] by hyatt
  • 1 edit in trunk/LayoutTests/fast/dom/background-shorthand-csstext-expected.txt

Land corrected background shorthand test now that I yanked the bogus alert.

12:47 AM Changeset in webkit [21701] by hausmann
  • 4 edits in trunk/WebKitQt

Share WebCoreHttp and therefore HTTP connections among multiple
QWebNetworkInterface instances by moving the code into
QWebNetworkManager.

12:01 AM Changeset in webkit [23402] by sfalken
  • 4 edits in branches/WindowsMerge/WebKitWin

Added IWebFramePrivate::isDescendantOfFrame.

  • Interfaces/IWebFramePrivate.idl:
  • WebFrame.cpp: (WebFrame::isDescendantOfFrame):
  • WebFrame.h:

May 23, 2007:

11:01 PM Changeset in webkit [21700] by hyatt
  • 1 edit in trunk/LayoutTests/fast/dom/background-shorthand-csstext.html

Remove a stray alert in a testcase that I wrote a while back.

10:58 PM Changeset in webkit [21699] by hyatt
  • 2 adds in trunk/LayoutTests/fast/table

Add a table test for comment nodes.

10:48 PM Changeset in webkit [21698] by hyatt
  • 3 edits in trunk/WebCore

Make the delete/InsertRows/Cells methods as well as the rowIndex method
able to work properly even when whitespace or comment nodes are present.

Reviewed by aroben

fast/table/rowindex-comment-nodes.html

  • html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::rowIndex): (WebCore::HTMLTableRowElement::insertCell): (WebCore::HTMLTableRowElement::deleteCell):
  • html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::insertRow): (WebCore::HTMLTableSectionElement::deleteRow):
10:39 PM Changeset in webkit [21697] by hyatt
  • 4 adds in trunk/LayoutTests/fast/forms

Land optgroup DTD test.

10:36 PM Changeset in webkit [21696] by hyatt
  • 3 edits in trunk/WebCore

<optgroup> should allow <script> and text nodes inside it, just like
<select> does.

Reviewed by aroben

fast/forms/stuff-on-my-optgroup.html

  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::checkDTD):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::checkDTD):
10:33 PM Changeset in webkit [21695] by hyatt
  • 4 adds in trunk/LayoutTests/fast/layers

Add gigantic z-index test.

10:23 PM Changeset in webkit [21694] by hyatt
  • 2 edits in trunk/WebCore

Framesets should allow whitespace text nodes as children.

Reviewed by aroben

  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::checkDTD):
9:06 PM Changeset in webkit [23401] by aliceli1
  • 2 edits in branches/WindowsMerge/LayoutTests

Reviewed by.

  • win/Skipped: remove fixed tests
8:28 PM Changeset in webkit [21693] by bdash
  • 2 edits in trunk/WebCore

Fix the Qt build after r21685.

  • platform/qt/CursorQt.cpp: (WebCore::notAllowedCursor): (WebCore::zoomInCursor): (WebCore::zoomOutCursor):
8:23 PM Changeset in webkit [21692] by bdash
  • 2 edits in trunk/WebCore

Reviewed by Adam.

Fix the gdk build following changes in r21685.

  • platform/gdk/CursorGdk.cpp: (WebCore::zoomInCursor): (WebCore::zoomOutCursor):
8:07 PM Changeset in webkit [21691] by hyatt
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/5222611> REGRESSION: Paint ordering problems at
​http://buymeasoda.com/dev/issues/image_onload/image_onload.html

Clamp z-index so that values that exceed maxint (or that are below minint)
are clamped to those values.

Reviewed by darin

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
7:13 PM Changeset in webkit [23400] by weinig
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
6:46 PM Changeset in webkit [21690] by ddkilzer
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by David Hyatt.

  • fast/css/stale-style-selector-crash-1-expected.txt: Added.
  • fast/css/stale-style-selector-crash-1.html: Added.
  • fast/css/stale-style-selector-crash-2-expected.txt: Added.
  • fast/css/stale-style-selector-crash-2.html: Added.

WebCore:

Reviewed by David Hyatt.

Tests: fast/css/stale-style-selector-crash-1.html

fast/css/stale-style-selector-crash-2.html

  • dom/Document.cpp: (WebCore::Document::Document): Initialize the m_didCalculateStyleSelector flag to 'false'. (WebCore::Document::updateStyleSelector): Do not bail out if we have ever calculated a non-trivial style selector, even if at the moment we are pending style sheets. We could have calculated a non-trivial selector already either because at some point there were no pending style sheets (so the currently pending ones were added dynamically) or because we were forced to do a layout ignoring pending style sheets. Either way, once there is a style selector, we need to keep it up to date, otherwise we can crash under recalcStyle() during updateRendering() or simply not recalculate style correctly for dynamic changes. (WebCore::Document::recalcStyleSelector): Set m_didCalculateStyleSelector to 'true' when creating a new style selector.
  • dom/Document.h:
6:43 PM Changeset in webkit [21689] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5224749> Show a zoom/unzoom cursor for resizable image documents


  • WebCore.xcodeproj/project.pbxproj: Install the zoom cursors.


  • loader/ImageDocument.cpp: (WebCore::ImageDocument::resizeImageToFit): Set the cursor to the zoom in cursor.


(WebCore::ImageDocument::restoreImageSize):
If the image fits, reset the cursor. Otherwise, set it to the zoom in cursor.

6:36 PM Changeset in webkit [21688] by andersca
  • 5 edits in trunk/WebKit

Reviewed by Geoff.

<rdar://problem/3663808> Resize large images to fit in the browser window


Add new WebPreferences SPI.


  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.m: (+[WebPreferences initialize]): (-[WebPreferences enableAutomaticImageResizing]): (-[WebPreferences setEnableAutomaticImageResizing:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _updateWebCoreSettingsFromPreferences:]):
6:11 PM Changeset in webkit [21687] by darin
  • 1234 edits in trunk

LayoutTests:

Reviewed by Hyatt.

  • updated the many tests with an extra newline or two at the end because of the bug where plain-text serialization will consider nodes that are not rendered

WebCore:

Reviewed by Hyatt.

  • fix problems where unrendered nodes were affecting on plain text serialization
  • editing/TextIterator.cpp: (WebCore::TextIterator::advance): Don't call handleXXX functions or exitNode for nodes without renderers. (WebCore::shouldEmitNewlineAfterNode): Only consider rendered nodes when deciding if this is the last node in the document.
6:04 PM Changeset in webkit [23399] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Fix build.


  • platform/win/CursorWin.cpp: (WebCore::zoomInCursor): (WebCore::zoomOutCursor):
6:01 PM Changeset in webkit [21686] by andersca
  • 6 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/3663808> Resize large images to fit in the browser window


  • WebCore.exp: Add new settings method.


  • loader/ImageDocument.cpp: (WebCore::ImageEventListener::ImageEventListener): New class that handles resize events and click events and forwards them to the image document.


(WebCore::ImageTokenizer::ImageTokenizer):
(WebCore::ImageTokenizer::writeRawData):
(WebCore::ImageTokenizer::finish):
(WebCore::ImageDocument::ImageDocument):
(WebCore::ImageDocument::createDocumentStructure):
(WebCore::ImageDocument::cachedImage):
Let the ImageDocument class keep track of its document structure.


(WebCore::ImageDocument::scale):
Returns the scale that should be used when resizing the image.


(WebCore::ImageDocument::resizeImage):
Update the image size.


(WebCore::ImageDocument::imageClicked):
Toggle between resized and not resized. When restoring the size, scroll the image so that the area under
the mouse stays the same.


(WebCore::ImageDocument::imageChanged):
When the image size is known, resize the image if needed.


(WebCore::ImageDocument::restoreImageSize):
Restore the image size.


(WebCore::ImageDocument::imageNeedsResizing):
Return whether the image is too big for its window or not.


(WebCore::ImageDocument::windowSizeChanged):
Called when the window's size changes. Determine if the window fits or not and resize it if it doesn't fit.


(WebCore::ImageEventListener::handleEvent):
Forward events to the image document.


  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setEnableAutomaticImageResizing):
  • page/Settings.h: (WebCore::Settings::enableAutomaticImageResizing): Add new setting.
5:50 PM Changeset in webkit [21685] by andersca
  • 7 edits
    2 adds in trunk/WebCore

Reviewed by Darin.

Add -webkit-zoom-in and -webkit-zoom-out cursors.


  • Resources/zoomInCursor.png: Added.
  • Resources/zoomOutCursor.png: Added.
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSValueKeywords.in:
  • page/EventHandler.cpp: (WebCore::selectCursor):
  • platform/Cursor.h:
  • platform/mac/CursorMac.mm: (WebCore::zoomInCursor): (WebCore::zoomOutCursor):
  • rendering/RenderStyle.h: (WebCore::):
5:01 PM Changeset in webkit [21684] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebView.cpp

Define rint ourselves for MSVS 2005 too, as it doesn't seem to be defined there either.

4:32 PM Changeset in webkit [21683] by weinig
  • 6 edits in trunk/WebCore

Reviewed by Darin.

Part one of patch for ​http://bugs.webkit.org/show_bug.cgi?id=13830
Auto-generate JS DOM bindings for HTMLDocument and most of the rest
of HTMLElement

  • Just the HTMLElement part.
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::getValueProperty): (KJS::JSHTMLElement::putValueProperty):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
  • html/HTMLElement.idl:
4:19 PM Changeset in webkit [21682] by kmccullo
  • 4 edits
    9 adds in trunk

LayoutTests:

Reviewed by Darin.

Update tests for ​http://bugs.webkit.org/show_bug.cgi?id=13830
Auto-generate JS DOM bindings for HTMLDocument and most of
the rest of HTMLElement

  • Corrects prototype chain for JSHTMLDocument and adds test for HTMLFormElement.
  • fast/dom/prototype-chain-expected.txt:
  • fast/dom/prototype-chain.html:

WebCore:

Reviewed by Darin.

  • rdar://problem/5183523
  • We now check the document's URL to see if it can load a resource in the case of a URL click, instead of checking the referrer, which is blank for local files.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::open):
  • platform/PlatformString.h: (WebCore::debugPrintString):
4:00 PM Changeset in webkit [21681] by weinig
  • 20 edits
    1 add in trunk

LayoutTests:

Reviewed by Darin.

Update tests for ​http://bugs.webkit.org/show_bug.cgi?id=13830
Auto-generate JS DOM bindings for HTMLDocument and most of
the rest of HTMLElement

  • Corrects prototype chain for JSHTMLDocument and adds test for HTMLFormElement.
  • fast/dom/prototype-chain-expected.txt:
  • fast/dom/prototype-chain.html:

WebCore:

Reviewed by Darin.

Part two of patch for ​http://bugs.webkit.org/show_bug.cgi?id=13830
Auto-generate JS DOM bindings for HTMLDocument and most of the rest
of HTMLElement

  • Just the HTMLDocument part.
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLDocumentCustom.cpp: Added. (WebCore::JSHTMLDocument::canGetItemsForName): (WebCore::JSHTMLDocument::nameGetter): (WebCore::JSHTMLDocument::all): (WebCore::JSHTMLDocument::setAll): (WebCore::JSHTMLDocument::location): (WebCore::JSHTMLDocument::setLocation): (WebCore::JSHTMLDocument::open): (WebCore::writeHelper): (WebCore::JSHTMLDocument::write): (WebCore::JSHTMLDocument::writeln): (WebCore::JSHTMLDocument::clear):
  • bindings/js/kjs_dom.cpp: (KJS::toJS):
  • bindings/js/kjs_dom.h:
  • bindings/js/kjs_html.cpp:
  • bindings/js/kjs_html.h:
  • bindings/objc/DOMPrivate.h:
  • bindings/scripts/CodeGeneratorJS.pm: Add [Deletable] property for Document.all and fix HasOverridingNameGetter to allow correct prototype chain
  • dom/Document.cpp: (WebCore::Document::plugins): adds alias to embeds() for bindings
  • dom/Document.h:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::width): (WebCore::HTMLDocument::height): (WebCore::HTMLDocument::dir): (WebCore::HTMLDocument::setDir): (WebCore::HTMLDocument::designMode): (WebCore::HTMLDocument::setDesignMode): (WebCore::HTMLDocument::bgColor): (WebCore::HTMLDocument::setBgColor): (WebCore::HTMLDocument::fgColor): (WebCore::HTMLDocument::setFgColor): (WebCore::HTMLDocument::alinkColor): (WebCore::HTMLDocument::setAlinkColor): (WebCore::HTMLDocument::linkColor): (WebCore::HTMLDocument::setLinkColor): (WebCore::HTMLDocument::vlinkColor): (WebCore::HTMLDocument::setVlinkColor): (WebCore::HTMLDocument::captureEvents): (WebCore::HTMLDocument::releaseEvents):
  • html/HTMLDocument.h:
  • html/HTMLDocument.idl:

WebKit:

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=13830
Auto-generate JS DOM bindings for HTMLDocument and most of the rest
of HTMLElement

  • MigrateHeaders.make: add DOMHTMLDocumentPrivate.h
  • WebKit.xcodeproj/project.pbxproj:
3:58 PM Changeset in webkit [21680] by hyatt
  • 1 edit in trunk/WebCore/html/HTMLTokenizer.cpp
3:55 PM Changeset in webkit [21679] by hyatt
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/5221838> REGRESSION (r21581): no content in idisk
window at mac.com.

Back out the change to make self-closed <script/> into a Dashboard quirk
only.

Reviewed by aroben

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
1:53 PM Changeset in webkit [21678] by oliver
  • 2 edits in trunk/WebKit

Reviewed by Geoff.

Fix for <rdar://problem/5223782> REGRESSION: Can't drag and drop a standalone image

The main resource for a standalone image webarchive has the same mimetype as the
underlying image.

  • Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
1:28 PM Changeset in webkit [21677] by thatcher
  • 2 edits in tags/WebCore-418.22/WebCore

Versioning.

1:27 PM Changeset in webkit [21676] by thatcher
  • 2 edits in tags/WebCore-418.22/WebCore

Merge fix r21674.

1:26 PM Changeset in webkit [21675] by thatcher
  • 1 copy in tags/WebCore-418.22

New tag.

1:24 PM Changeset in webkit [21674] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-10-05 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Eric.

<rdar://problem/4150976> Safari crashes in HTMLImageLoader::dispatchLoadEvent() on particular page (archive attached)

I couldn't figure out how to make an automated test for this; even once I got DumpRenderTree
to mouse in and out it did not crash.


  • khtml/html/html_imageimpl.cpp: (HTMLImageLoader::dispatchLoadEvent): Check if CachedImage is null before using it.
1:22 PM Changeset in webkit [21673] by thatcher
  • 2 edits in tags/WebCore-418.21/WebCore

Rolling out a commit on the wrong tag.

1:17 PM Changeset in webkit [21672] by thatcher
  • 2 edits in tags/WebCore-418.21/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-10-05 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Eric.

<rdar://problem/4150976> Safari crashes in HTMLImageLoader::dispatchLoadEvent() on particular page (archive attached)

I couldn't figure out how to make an automated test for this; even once I got DumpRenderTree
to mouse in and out it did not crash.


  • khtml/html/html_imageimpl.cpp: (HTMLImageLoader::dispatchLoadEvent): Check if CachedImage is null before using it.
10:19 AM Changeset in webkit [21671] by kmccullo
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by.

  • Fixed build breakage.
  • fast/dom/open-and-close-by-DOM-expected.txt: Added.
  • fast/dom/open-and-close-by-DOM.html: Added.
10:11 AM Changeset in webkit [21670] by pyeh
  • 2 edits in trunk/WebCore

<rdar://problem/5078453> AXNext/PrevLineEndTextMarkerForTextMarker returns kAXErrorNoValue for attachment range

Floating objects, such as aligned images, are not included as part of any line. So when the given
text marker is on the floating object, the returned line edge cannot be found and asserts are fired.
In addition, this paints an inconsistent text layout (in the accessibility sense) of where the floating
object resides. Character/word methods report floating object at the beginning of the text line(s). Yet
line methods never present floating objects anywhere.
To fix this, the ax line methods will now do more checking to ensure floating object nodes are included
when determining the line range/position. That way, assistive apps won't get stuck using the line methods
to read line-by-line

  • bridge/mac/WebCoreAXObject.mm: (updateAXLineStartForVisiblePosition): Added a helper method to adjust line start position to account for floating objects (-[WebCoreAXObject doAXLeftLineTextMarkerRangeForTextMarker:]): (-[WebCoreAXObject doAXRightLineTextMarkerRangeForTextMarker:]): (-[WebCoreAXObject doAXNextLineEndTextMarkerForTextMarker:]): (-[WebCoreAXObject doAXPreviousLineStartTextMarkerForTextMarker:]): Fixed up line routines to include floating object nodes in line position calculation. startOfLine/endOLine may return null for position next to a floating position. So now there's extra checks to prevent returning null line position/ranges back to AX.
10:02 AM Changeset in webkit [21669] by kmccullo
  • 1 edit
    2 deletes in trunk/LayoutTests

Reviewed by.

  • Removing failing tests until I've fixed them.
  • fast/dom/open-and-close-by-DOM-expected.txt: Removed.
  • fast/dom/open-and-close-by-DOM.html: Removed.
9:22 AM Changeset in webkit [21668] by hausmann
  • 9 edits in trunk

Added support for per-QWebPage network interface handlers, clean up the
http and file loading and fixed a bug in the HTTP redirect handling.

8:45 AM Changeset in webkit [23398] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fix. Fix continuous rebuilding of Interfaces by turning off Generate Type Library for every IDL except WebKit.idl.

  • WebKit.vcproj/Interfaces.vcproj:
7:00 AM Changeset in webkit [21667] by rwlbuis
  • 10 edits
    4 adds in trunk

Reviewed by Dave Hyatt.

​http://bugs.webkit.org/show_bug.cgi?id=13174
line-height in font shorthand does not override a previously stated line-height property

Make sure line-height is calculated against definite font-size and
uses the last set line-height, ie. directly or through font shorthand.

5:14 AM Changeset in webkit [21666] by lars
  • 4 edits in trunk/WebKitQt

Reviewed by Zack

Don't do HTTP downloads in a second thread. Simplifies
the code significantly and fixes crashes on some
Web pages.

4:07 AM Changeset in webkit [21665] by lars
  • 2 edits in trunk/WebCore

Reviewed by Zack and Valgrind

Initialize variable.

4:04 AM Changeset in webkit [21664] by rwlbuis
  • 3 edits
    4 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13784
REGRESSION (r13744-13750): Crash with empty gradient when drawing to canvas

Fix crash by testing for zero stops, and returning transparent black
in this case.

3:48 AM Changeset in webkit [21663] by rwlbuis
  • 3 edits
    4 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13801
Crash when loading nonexisting symbol

Check for referenced element and when not found just return.

3:01 AM Changeset in webkit [21662] by lars
  • 3 edits in trunk/WebKitQt

Fix Host: line in HTTP headers and resolving of relative URLs
when redirecting and clean up qHash forward declaration a bit.

1:48 AM Changeset in webkit [21661] by hausmann
  • 2 edits in trunk/WebKitQt

Fix signal/slot connection for load progress.

Note: See TracTimeline for information about the timeline view.