⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 27, 2007:

10:48 PM Changeset in webkit [23417] by weinig
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
10:22 PM Changeset in webkit [21834] by kevino
  • 2 edits in branches/wx-port-alpha/trunk/WebKit/wx

Remove unused code and fix keyboard event handling.

9:47 PM Changeset in webkit [21833] by weinig
  • 2 edits in trunk/WebCore

Qt and Gdk build fix.

  • WebCore.pro:
9:40 PM Changeset in webkit [21832] by weinig
  • 14 edits
    3 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Update results for ​http://bugs.webkit.org/show_bug.cgi?id=13893
Autogenerate the JS bindings for the HTMLObjectElement,
HTMLEmbedElement and HTMLAppletElement

  • account for the new JSHTMLObjectElement and JSHTMLEmbedElement that are being autogenerated and can now produce constructors.
  • fast/dom/Window/element-constructors-on-window-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Hyatt.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=13893
Autogenerate the JS bindings for the HTMLObjectElement,
HTMLEmbedElement and HTMLAppletElement

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLAppletElementCustom.cpp: Added. (WebCore::JSHTMLAppletElement::customGetOwnPropertySlot): (WebCore::JSHTMLAppletElement::customPut): (WebCore::JSHTMLAppletElement::implementsCall): (WebCore::JSHTMLAppletElement::callAsFunction): (WebCore::JSHTMLAppletElement::canGetItemsForName): (WebCore::JSHTMLAppletElement::nameGetter):
  • bindings/js/JSHTMLElementWrapperFactory.cpp:
  • bindings/js/JSHTMLEmbedElementCustom.cpp: Added. (WebCore::JSHTMLEmbedElement::customGetOwnPropertySlot): (WebCore::JSHTMLEmbedElement::customPut): (WebCore::JSHTMLEmbedElement::implementsCall): (WebCore::JSHTMLEmbedElement::callAsFunction): (WebCore::JSHTMLEmbedElement::canGetItemsForName): (WebCore::JSHTMLEmbedElement::nameGetter):
  • bindings/js/JSHTMLObjectElementCustom.cpp: Added. (WebCore::JSHTMLObjectElement::customGetOwnPropertySlot): (WebCore::JSHTMLObjectElement::customPut): (WebCore::JSHTMLObjectElement::implementsCall): (WebCore::JSHTMLObjectElement::callAsFunction): (WebCore::JSHTMLObjectElement::canGetItemsForName): (WebCore::JSHTMLObjectElement::nameGetter):
  • bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::toString): (KJS::JSHTMLElement::pushEventHandlerScope): (KJS::runtimeObjectGetter): (KJS::runtimeObjectPropertyGetter): (KJS::runtimeObjectCustomGetOwnPropertySlot): (KJS::runtimeObjectCustomPut): (KJS::runtimeObjectImplementsCall): (KJS::runtimeObjectCallAsFunction):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::classInfo):
  • bindings/scripts/CodeGeneratorJS.pm: Add support for CustomGetOwnPropertySlot, CustomPutFunction, CustomCall, and SVGCheckSecurityDocument properties.
  • html/HTMLAppletElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLObjectElement.idl:
  • page/DOMWindow.idl: Uncomment constructors.
7:23 PM Changeset in webkit [21831] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

Gdk build fix.

  • platform/graphics/Path.h:
7:09 PM Changeset in webkit [21830] by weinig
  • 2 edits in trunk/JavaScriptCore

Reviewed by Mark Rowe.

  • wtf/Platform.h: Move Gdk up to allow building WebKit/Gdk on Darwin
6:46 PM Changeset in webkit [21829] by weinig
  • 6 edits in trunk/WebCore

Gdk build fix. Forgot to update a few instances of notImplementedGdk() to notImplemented().

  • page/gdk/EventHandlerGdk.cpp: (WebCore::EventHandler::passMousePressEventToScrollbar):
  • platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::ignoreWordInSpellDocument): (WebCore::EditorClientGdk::learnWord): (WebCore::EditorClientGdk::checkSpellingOfString): (WebCore::EditorClientGdk::checkGrammarOfString): (WebCore::EditorClientGdk::updateSpellingUIWithGrammarString): (WebCore::EditorClientGdk::updateSpellingUIWithMisspelledWord): (WebCore::EditorClientGdk::showSpellingUI): (WebCore::EditorClientGdk::spellingUIIsShowing): (WebCore::EditorClientGdk::getGuessesForWord):
  • platform/gdk/FrameGdk.cpp: (WebCore::Frame::dashboardRegionsChanged):
  • platform/gdk/PlatformScrollBarGdk.cpp: (PlatformScrollbar::paint): (PlatformScrollbar::updateThumbPosition): (PlatformScrollbar::updateThumbProportion):
  • platform/gdk/TemporaryLinkStubs.cpp: (Widget::setEnabled): (Widget::isEnabled): (Widget::removeFromParent): (Widget::paint): (Widget::setIsSelected): (Widget::invalidate): (Widget::invalidateRect):
6:24 PM Changeset in webkit [21828] by weinig
  • 4 edits
    1 add in trunk/WebCore

Reviewed by Sam and Oliver.

Implement PathCairo. This patch is based on changes in Mike Emmel's
WebKit fork with some additional clean-ups and updates.

  • platform/graphics/Path.h:
  • platform/graphics/cairo/CairoPath.h: Added. (CairoPath::CairoPath): (CairoPath::~CairoPath):
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clip):
  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::Path): (WebCore::Path::~Path): (WebCore::Path::operator=): (WebCore::Path::clear): (WebCore::Path::isEmpty): (WebCore::Path::translate): (WebCore::Path::moveTo): (WebCore::Path::addLineTo): (WebCore::Path::addRect): (WebCore::Path::addQuadCurveTo): (WebCore::Path::addBezierCurveTo): (WebCore::Path::addArc): (WebCore::Path::addArcTo): (WebCore::Path::addEllipse): (WebCore::Path::closeSubpath): (WebCore::Path::boundingRect): (WebCore::Path::contains): (WebCore::Path::apply): (WebCore::Path::transform): (WebCore::Path::debugString):
5:39 PM Changeset in webkit [21827] by kevino
  • 50 edits
    1 add
    1 delete in trunk

WebCore:

Reviewed by Sam Weinig.

Consolidate all notImplemented() macro definitions into
one header file for all platforms.

  • loader/gdk/DocumentLoaderGdk.cpp: (WebCore::DocumentLoader::getResponseModifiedHeader):
  • loader/gdk/FrameLoaderClientGdk.cpp: (WebCore::FrameLoaderClientGdk::dispatchDidReceiveAuthenticationChallenge): (WebCore::FrameLoaderClientGdk::dispatchDidCancelAuthenticationChallenge): (WebCore::FrameLoaderClientGdk::dispatchWillSendRequest): (WebCore::FrameLoaderClientGdk::assignIdentifierToInitialRequest): (WebCore::FrameLoaderClientGdk::createPlugin): (WebCore::FrameLoaderClientGdk::createFrame): (WebCore::FrameLoaderClientGdk::redirectDataToPlugin): (WebCore::FrameLoaderClientGdk::createJavaAppletWidget): (WebCore::FrameLoaderClientGdk::objectContentType): (WebCore::FrameLoaderClientGdk::overrideMediaType): (WebCore::FrameLoaderClientGdk::windowObjectCleared): (WebCore::FrameLoaderClientGdk::hasWebView): (WebCore::FrameLoaderClientGdk::hasFrameView): (WebCore::FrameLoaderClientGdk::frameLoadCompleted): (WebCore::FrameLoaderClientGdk::saveViewStateToItem): (WebCore::FrameLoaderClientGdk::restoreViewState): (WebCore::FrameLoaderClientGdk::privateBrowsingEnabled): (WebCore::FrameLoaderClientGdk::makeDocumentView): (WebCore::FrameLoaderClientGdk::makeRepresentation): (WebCore::FrameLoaderClientGdk::forceLayout): (WebCore::FrameLoaderClientGdk::forceLayoutForNonHTML): (WebCore::FrameLoaderClientGdk::setCopiesOnScroll): (WebCore::FrameLoaderClientGdk::detachedFromParent1): (WebCore::FrameLoaderClientGdk::detachedFromParent2): (WebCore::FrameLoaderClientGdk::detachedFromParent3): (WebCore::FrameLoaderClientGdk::detachedFromParent4): (WebCore::FrameLoaderClientGdk::loadedFromCachedPage): (WebCore::FrameLoaderClientGdk::dispatchDidHandleOnloadEvents): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidCancelClientRedirect): (WebCore::FrameLoaderClientGdk::dispatchWillPerformClientRedirect): (WebCore::FrameLoaderClientGdk::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoaderClientGdk::dispatchWillClose): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveIcon): (WebCore::FrameLoaderClientGdk::dispatchDidStartProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientGdk::dispatchDidCommitLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFinishDocumentLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFirstLayout): (WebCore::FrameLoaderClientGdk::dispatchShow): (WebCore::FrameLoaderClientGdk::cancelPolicyCheck): (WebCore::FrameLoaderClientGdk::dispatchDidLoadMainResource): (WebCore::FrameLoaderClientGdk::revertToProvisionalState): (WebCore::FrameLoaderClientGdk::clearUnarchivingState): (WebCore::FrameLoaderClientGdk::willChangeTitle): (WebCore::FrameLoaderClientGdk::finishedLoading): (WebCore::FrameLoaderClientGdk::finalSetupForReplace): (WebCore::FrameLoaderClientGdk::setDefersLoading): (WebCore::FrameLoaderClientGdk::isArchiveLoadPending): (WebCore::FrameLoaderClientGdk::cancelPendingArchiveLoad): (WebCore::FrameLoaderClientGdk::clearArchivedResources): (WebCore::FrameLoaderClientGdk::canHandleRequest): (WebCore::FrameLoaderClientGdk::canShowMIMEType): (WebCore::FrameLoaderClientGdk::representationExistsForURLScheme): (WebCore::FrameLoaderClientGdk::generatedMIMETypeForURLScheme): (WebCore::FrameLoaderClientGdk::provisionalLoadStarted): (WebCore::FrameLoaderClientGdk::didFinishLoad): (WebCore::FrameLoaderClientGdk::prepareForDataSourceReplacement): (WebCore::FrameLoaderClientGdk::setTitle): (WebCore::FrameLoaderClientGdk::setDocumentViewFromCachedPage): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveContentLength): (WebCore::FrameLoaderClientGdk::dispatchDidFinishLoading): (WebCore::FrameLoaderClientGdk::dispatchDidFailLoading): (WebCore::FrameLoaderClientGdk::dispatchDidLoadResourceFromMemoryCache): (WebCore::FrameLoaderClientGdk::dispatchDidFailProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFailLoad): (WebCore::FrameLoaderClientGdk::download): (WebCore::FrameLoaderClientGdk::cancelledError): (WebCore::FrameLoaderClientGdk::blockedError): (WebCore::FrameLoaderClientGdk::cannotShowURLError): (WebCore::FrameLoaderClientGdk::interruptForPolicyChangeError): (WebCore::FrameLoaderClientGdk::cannotShowMIMETypeError): (WebCore::FrameLoaderClientGdk::fileDoesNotExistError): (WebCore::FrameLoaderClientGdk::shouldFallBack): (WebCore::FrameLoaderClientGdk::willUseArchive): (WebCore::FrameLoaderClientGdk::saveDocumentViewToCachedPage): (WebCore::FrameLoaderClientGdk::canCachePage): (WebCore::FrameLoaderClientGdk::dispatchCreatePage): (WebCore::FrameLoaderClientGdk::dispatchUnableToImplementPolicy): (WebCore::FrameLoaderClientGdk::setMainDocumentError): (WebCore::FrameLoaderClientGdk::startDownload): (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForStandardLoad): (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForReload):
  • loader/qt/DocumentLoaderQt.cpp:
  • page/gdk/ContextMenuClientGdk.cpp: (WebCore::ContextMenuClientGdk::contextMenuDestroyed): (WebCore::ContextMenuClientGdk::getCustomMenuFromDefaultItems): (WebCore::ContextMenuClientGdk::contextMenuItemSelected): (WebCore::ContextMenuClientGdk::downloadURL): (WebCore::ContextMenuClientGdk::copyImageToClipboard): (WebCore::ContextMenuClientGdk::searchWithGoogle): (WebCore::ContextMenuClientGdk::lookUpInDictionary): (WebCore::ContextMenuClientGdk::speak): (WebCore::ContextMenuClientGdk::stopSpeaking):
  • page/gdk/EventHandlerGdk.cpp: (WebCore::EventHandler::passMouseDownEventToWidget): (WebCore::EventHandler::eventActivatedView): (WebCore::EventHandler::passSubframeEventToSubframe): (WebCore::EventHandler::passWheelEventToWidget): (WebCore::EventHandler::createDraggingClipboard):
  • page/qt/EventHandlerQt.cpp:
  • page/qt/FrameQt.cpp:
  • platform/NotImplemented.h: Added.
  • platform/gdk/CursorGdk.cpp: (WebCore::Cursor::Cursor):
  • platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::shouldDeleteRange): (WebCore::EditorClientGdk::isContinuousSpellCheckingEnabled): (WebCore::EditorClientGdk::isGrammarCheckingEnabled): (WebCore::EditorClientGdk::spellCheckerDocumentTag): (WebCore::EditorClientGdk::shouldBeginEditing): (WebCore::EditorClientGdk::shouldEndEditing): (WebCore::EditorClientGdk::shouldInsertText): (WebCore::EditorClientGdk::shouldChangeSelectedRange): (WebCore::EditorClientGdk::shouldApplyStyle): (WebCore::EditorClientGdk::didBeginEditing): (WebCore::EditorClientGdk::respondToChangedContents): (WebCore::EditorClientGdk::respondToChangedSelection): (WebCore::EditorClientGdk::didEndEditing): (WebCore::EditorClientGdk::didWriteSelectionToPasteboard): (WebCore::EditorClientGdk::didSetSelectionTypesForPasteboard): (WebCore::EditorClientGdk::selectWordBeforeMenuEvent): (WebCore::EditorClientGdk::isEditable): (WebCore::EditorClientGdk::registerCommandForUndo): (WebCore::EditorClientGdk::registerCommandForRedo): (WebCore::EditorClientGdk::clearUndoRedoOperations): (WebCore::EditorClientGdk::canUndo): (WebCore::EditorClientGdk::canRedo): (WebCore::EditorClientGdk::undo): (WebCore::EditorClientGdk::redo): (WebCore::EditorClientGdk::shouldInsertNode): (WebCore::EditorClientGdk::pageDestroyed): (WebCore::EditorClientGdk::smartInsertDeleteEnabled): (WebCore::EditorClientGdk::toggleContinuousSpellChecking): (WebCore::EditorClientGdk::handleInputMethodKeypress): (WebCore::EditorClientGdk::textFieldDidBeginEditing): (WebCore::EditorClientGdk::textFieldDidEndEditing): (WebCore::EditorClientGdk::textDidChangeInTextField): (WebCore::EditorClientGdk::doTextFieldCommandFromEvent): (WebCore::EditorClientGdk::textWillBeDeletedInTextField): (WebCore::EditorClientGdk::textDidChangeInTextArea):
  • platform/gdk/FrameGdk.cpp: (WebCore::Frame::print): (WebCore::Frame::issueTransposeCommand): (WebCore::Frame::cleanupPlatformScriptObjects): (WebCore::Frame::dragImageForSelection):
  • platform/gdk/NotImplementedGdk.h: Removed.
  • platform/gdk/PopupMenuGdk.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement):
  • platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::setCheckboxSize): (WebCore::RenderThemeGdk::setRadioSize): (WebCore::RenderThemeGdk::adjustTextFieldStyle):
  • platform/gdk/ScreenGdk.cpp: (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
  • platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::update): (WebCore::ScrollView::addChild): (WebCore::ScrollView::removeChild): (WebCore::ScrollView::scrollRectIntoViewRecursively): (WebCore::ScrollView::inWindow): (WebCore::ScrollView::wheelEvent): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::updateScrollInfo): (WebCore::ScrollView::windowToContents): (WebCore::ScrollView::contentsToWindow): (WebCore::ScrollView::scrollbarUnderMouse):
  • platform/gdk/TemporaryLinkStubs.cpp: (FrameView::updateBorder): (WebCore::findNextWordFromIndex): (WebCore::currentTextBreakLocaleID): (ChromeClientGdk::chromeDestroyed): (ChromeClientGdk::windowRect): (ChromeClientGdk::setWindowRect): (ChromeClientGdk::pageRect): (ChromeClientGdk::scaleFactor): (ChromeClientGdk::focus): (ChromeClientGdk::unfocus): (ChromeClientGdk::createWindow): (ChromeClientGdk::createModalDialog): (ChromeClientGdk::show): (ChromeClientGdk::canRunModal): (ChromeClientGdk::runModal): (ChromeClientGdk::setToolbarsVisible): (ChromeClientGdk::toolbarsVisible): (ChromeClientGdk::setStatusbarVisible): (ChromeClientGdk::statusbarVisible): (ChromeClientGdk::setScrollbarsVisible): (ChromeClientGdk::scrollbarsVisible): (ChromeClientGdk::setMenubarVisible): (ChromeClientGdk::menubarVisible): (ChromeClientGdk::setResizable): (ChromeClientGdk::closeWindowSoon): (ChromeClientGdk::canTakeFocus): (ChromeClientGdk::takeFocus): (ChromeClientGdk::canRunBeforeUnloadConfirmPanel): (ChromeClientGdk::addMessageToConsole): (ChromeClientGdk::runBeforeUnloadConfirmPanel): (ChromeClientGdk::runJavaScriptAlert): (ChromeClientGdk::runJavaScriptConfirm): (ChromeClientGdk::runJavaScriptPrompt): (ChromeClientGdk::setStatusbarText): (ChromeClientGdk::shouldInterruptJavaScript): (ChromeClientGdk::tabsToLinks): (ChromeClientGdk::windowResizerRect): (ChromeClientGdk::addToDirtyRegion): (ChromeClientGdk::scrollBackingStore): (ChromeClientGdk::updateBackingStore): (PlugInInfoStore::createPluginInfoForPluginAtIndex): (PlugInInfoStore::pluginCount): (WebCore::PlugInInfoStore::supportsMIMEType): (WebCore::refreshPlugins): (SearchPopupMenu::saveRecentSearches): (SearchPopupMenu::loadRecentSearches): (SearchPopupMenu::SearchPopupMenu): (SearchPopupMenu::enabled): (FileChooser::FileChooser): (FileChooser::~FileChooser): (FileChooser::openFileChooser): (FileChooser::basenameForWidth): (ResourceHandle::willLoadFromCache): (ResourceHandle::loadsBlocked): (ResourceHandle::loadResourceSynchronously): (Icon::Icon): (Icon::~Icon): (Icon::newIconForFile): (Icon::paint): (Font::selectionRectForComplexText): (Font::drawComplexText): (Font::floatWidthForComplexText): (Font::offsetForPositionForComplexText): (CachedPage::close): (Editor::newGeneralClipboard): (Pasteboard::generalPasteboard): (Pasteboard::writeSelection): (Pasteboard::writeURL): (Pasteboard::writeImage): (Pasteboard::clear): (Pasteboard::canSmartReplace): (Pasteboard::documentFragment): (Pasteboard::plainText): (Pasteboard::Pasteboard): (Pasteboard::~Pasteboard): (ContextMenu::ContextMenu): (ContextMenu::~ContextMenu): (ContextMenu::appendItem): (ContextMenuItem::ContextMenuItem): (ContextMenuItem::~ContextMenuItem): (ContextMenuItem::releasePlatformDescription): (ContextMenuItem::type): (ContextMenuItem::setType): (ContextMenuItem::action): (ContextMenuItem::setAction): (ContextMenuItem::title): (ContextMenuItem::setTitle): (ContextMenuItem::platformSubMenu): (ContextMenuItem::setSubMenu): (ContextMenuItem::setChecked): (ContextMenuItem::setEnabled): (WebCore::supportedKeySizes): (WebCore::systemBeep): (WebCore::userIdleTime):
  • platform/graphics/cairo/GraphicsContextCairo.cpp:
  • platform/graphics/cairo/ImageBufferCairo.cpp:
  • platform/graphics/cairo/PathCairo.cpp:
  • platform/graphics/gdk/ImageGdk.cpp:
  • platform/graphics/qt/GraphicsContextQt.cpp:
  • platform/graphics/qt/IconQt.cpp:
  • platform/graphics/qt/ImageQt.cpp:
  • platform/network/gdk/ResourceHandleCurl.cpp: (WebCore::ResourceHandle::setDefersLoading):
  • platform/network/gdk/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::setupPUT): (WebCore::ResourceHandleManager::setupPOST):
  • platform/network/qt/ResourceHandleQt.cpp:
  • platform/qt/ClipboardQt.cpp:
  • platform/qt/CursorQt.cpp:
  • platform/qt/DragDataQt.cpp:
  • platform/qt/FileChooserQt.cpp:
  • platform/qt/MimeTypeRegistryQt.cpp:
  • platform/qt/PasteboardQt.cpp:
  • platform/qt/PlatformScrollBarQt.cpp:
  • platform/qt/PopupMenuQt.cpp:
  • platform/qt/ScrollViewQt.cpp:
  • platform/qt/TemporaryLinkStubs.cpp:
  • platform/qt/TextBoundaries.cpp:
  • platform/qt/WidgetQt.cpp:
  • platform/win/FontWin.cpp:
  • platform/win/TemporaryLinkStubs.cpp:
  • platform/wx/ClipboardWx.cpp:
  • platform/wx/FontWx.cpp:
  • platform/wx/ScrollViewWx.cpp:
  • platform/wx/SharedTimerWx.cpp:
  • platform/wx/TemporaryLinkStubs.cpp:

WebKitQt:

Reviewed by Sam Weinig.


Consolidate all notImplemented() macro definitions into
one header file for all platforms.

  • WebCoreSupport/ChromeClientQt.cpp:
  • WebCoreSupport/ContextMenuClientQt.cpp:
  • WebCoreSupport/EditorClientQt.cpp:
  • WebCoreSupport/FrameLoaderClientQt.cpp:
4:37 PM Changeset in webkit [21826] by kevino
  • 2 edits in branches/wx-port-alpha/trunk

Use wxAutoBufferedPaintDC to make sure we don't get any flicker on Windows. (It doesn't buffer on platforms whose drawing is already double-buffered.)

4:31 PM Changeset in webkit [21825] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/graphics/wx/ImageSourceWx.cpp

Remove unused code.

3:40 PM Changeset in webkit [21824] by darin
  • 2 edits in trunk/JavaScriptCore
  • fix a couple ifdefs that said WIN instead of WIN_OS
  • kjs/collector.cpp: (KJS::allocateBlock): WIN -> WIN_OS (KJS::freeBlock): Ditto.
3:07 PM Changeset in webkit [21823] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/wx/FontWx.cpp

Calculate the correct y position to draw the text.

12:59 PM Changeset in webkit [21822] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/wx/SharedTimerWx.cpp

Improve detection of invalid values for the shared timer, and assert if the timer interval == 0.

7:52 AM Changeset in webkit [21821] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/JavaScriptCore/kjs/collector.cpp

Use Windows virtual memory functions on Windows even when not building the Windows port.

2:49 AM Changeset in webkit [21820] by rwlbuis
  • 4 edits
    4 adds in trunk

Reviewed by Oliver.

​http://bugs.webkit.org/show_bug.cgi?id=13828
x/y values on rootmost <svg> elements should be ignored

Make sure that root-most <svg> elements do not take into account x/y.

May 26, 2007:

11:09 PM Changeset in webkit [21819] by hyatt
  • 5 edits
    6 adds in trunk

Fix for radar bug 5219562, PNG isn't displayed on SVG test suite.
Improve <object> error handling so that it recovers properly when
<td> is used inside it.

Reviewed by olliej

Added fast/invalid/td-inside-object.html

  • html/HTMLObjectElement.h: (WebCore::HTMLObjectElement::tagPriority):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
  • html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate):
  • html/HTMLParserErrorCodes.h:
10:01 PM Changeset in webkit [21818] by hyatt
  • 2 edits in trunk/WebCore

Don't compare the "isset" variables in background layers, since they
lead us to turn off the Aqua look incorrectly, even when the background
matches the default.

Reviewed by olliej

  • rendering/RenderStyle.cpp: (WebCore::BackgroundLayer::operator==):
9:56 PM Changeset in webkit [21817] by hyatt
  • 3 edits in trunk/WebCore

Improve the </p> -> <p></p> error message to not spew two errors.
Fix a bug where errors reported inside document.write didn't get
reported as such because of a mistake in the notation of SegmentedString.

Reviewed by aroben

  • html/HTMLParser.cpp: (WebCore::HTMLParser::processCloseTag):
  • platform/SegmentedString.h: (WebCore::SegmentedSubstring::clear):
9:53 PM Changeset in webkit [21816] by hyatt
  • 4 adds in trunk/LayoutTests/fast/block/positioning

Add layout test for bug 13887.

9:52 PM Changeset in webkit [21815] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebKitSupport/EditorClientWx.cpp

Make sure the function returns a value.

9:51 PM Changeset in webkit [21814] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 13887, percentage height block not sized correctly inside
positioned percentage height containing block.

Reviewed by mitz

fast/block/positioning/complex-percentage-height.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcPercentageHeight):
8:45 PM Changeset in webkit [21813] by kevino
  • 16 adds in branches/wx-port-alpha/trunk/WebCore

More additions, hopefully the last batch.

8:34 PM Changeset in webkit [21812] by kevino
  • 3 adds in branches/wx-port-alpha/trunk/WebCore/rendering

More files the merge didn't mark as added.

8:31 PM Changeset in webkit [21811] by kevino
  • 1 add in branches/wx-port-alpha/trunk/WebCore/rendering/LayoutState.h

Another merge file that wasn't marked for addition to the branch

8:27 PM Changeset in webkit [21810] by kevino
  • 3 adds in branches/wx-port-alpha/trunk/WebCore/html

The merge didn't properly mark these files as added on the branch, so add them ourselves.

7:35 PM Changeset in webkit [21809] by kevino
  • 732 edits
    2 copies
    35 deletes in branches/wx-port-alpha/trunk

Sync wx port with TOT, and fix a bug with iconv detection in install-unix-extras.

4:09 PM Changeset in webkit [21808] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Oliver Hunt.

Covered by fast/forms/box-shadow-override.html

I forgot to include adjustSliderThumbStyle in the previous patch and the
test didn't detect it because of a bug introduced in r21739.

  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustSliderThumbStyle):
3:09 PM Changeset in webkit [21807] by weinig
  • 11 edits in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/repaint/box-shadow-h-expected.checksum:
  • fast/repaint/box-shadow-h-expected.png:
  • fast/repaint/box-shadow-h-expected.txt:
  • fast/repaint/box-shadow-h.html:
  • fast/repaint/box-shadow-v-expected.checksum:
  • fast/repaint/box-shadow-v-expected.png:
  • fast/repaint/box-shadow-v-expected.txt:
  • fast/repaint/box-shadow-v.html:

WebCore:

Reviewed by Hyatt.

Tests: fast/repaint/box-shadow-h.html

fast/repaint/box-shadow-v.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
2:57 PM Changeset in webkit [21806] by weinig
  • 5 edits in trunk

JavaScriptCore:

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=13854
Port of commit 667785 from kjs

  • special case calling String.localeCompare() with no parameters to return 0.
  • kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction):

LayoutTests:

Reviewed by Darin.

Update tests ​http://bugs.webkit.org/show_bug.cgi?id=13854
Port of commit 667785 from kjs

  • update tests and results to match kde.
  • fast/js/kde/StringObject-expected.txt:
  • fast/js/kde/resources/StringObject.js:
10:38 AM Changeset in webkit [21805] by bdash
  • 4 edits in trunk

Versioning.

10:26 AM Changeset in webkit [21804] by bdash
  • 1 copy in tags/Safari-5522.8

New tag.

8:36 AM Changeset in webkit [21803] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13605
REGRESSION: Browser crashes when switching Kotoeri input modes

The problem could no longer be reproduced with Kotoeri thanks to
a fix in <​http://trac.webkit.org/projects/webkit/changeset/21728>,
but we still need to protect from invalid ranges passed from
input methods.

Test: editing/input/replace-invalid-range.html

  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge selectNSRange:]): Added a null check.
8:26 AM Changeset in webkit [21802] by darin
  • 1 edit in trunk/WebKit/ChangeLog

"on this makefile itself"

8:24 AM Changeset in webkit [21801] by darin
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher.

  • MigrateHeaders.make: Added dependency on this header file itself, which is useful when you change the sed command or other aspect of this file. My build failed until I made this fix.
7:40 AM Changeset in webkit [21800] by darin
  • 2 edits in trunk/WebCore
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::doUpdateResourceResponse): Alexey pointed out that I was wrong about object lifetime, so rolling this change out.
7:32 AM Changeset in webkit [21799] by darin
  • 2 edits in trunk/WebCore

Reviewed by Anders.

  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::doUpdateResourceResponse): Fixed code where a temporary String is used after destroyed.
6:36 AM Changeset in webkit [21798] by bdash
  • 2 edits in trunk/WebCore

2007-05-26 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Not testable.

  • platform/graphics/Color.cpp: (WebCore::Color::light): (WebCore::Color::dark):
6:32 AM Changeset in webkit [21797] by bdash
  • 7 edits in trunk

2007-05-26 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Covered by fast/frames/inline-object-inside-frameset.html

  • rendering/RenderFrame.h: (WebCore::RenderFrame::isFrame): Added.
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::paint): Removed check for inline objects that is no longer needed. (WebCore::RenderFrameSet::isChildAllowed): Added. Allows the child only if it is a frame or another frameset.
  • rendering/RenderFrameSet.h:
  • rendering/RenderObject.h: (WebCore::RenderObject::isFrame): Added.

2007-05-26 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/frames/inline-object-inside-frameset-expected.txt:
6:29 AM Changeset in webkit [21796] by bdash
  • 5 edits
    4 adds in trunk

2007-05-26 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/forms/box-shadow-override.html

  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustCheckboxStyle): (WebCore::RenderTheme::adjustRadioStyle):
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustButtonStyle): (WebCore::RenderThemeMac::adjustMenuListStyle): (WebCore::RenderThemeMac::adjustSliderTrackStyle): (WebCore::RenderThemeMac::adjustSearchFieldStyle): (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):

2007-05-26 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/forms/box-shadow-override-expected.checksum: Added.
  • fast/forms/box-shadow-override-expected.png: Added.
  • fast/forms/box-shadow-override-expected.txt: Added.
  • fast/forms/box-shadow-override.html: Added.
6:14 AM Changeset in webkit [21795] by bdash
  • 2 edits in trunk/WebCore

2007-05-26 Holger Freyther <​zecke@selfish.org>

Reviewed by Anders.

  • platform/gdk/FrameGdk.cpp: Catch up to make it compile (WebCore::FrameGdk::FrameGdk): The Settings is now owned by the Page
12:05 AM Changeset in webkit [23416] by oliver
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-05-25 Oliver Hunt <​oliver@apple.com>

Reviewed by Hyatt.


Fix rdar://problem/5212399 <object> with PNG src rendered as image document (causes Acid2 to fail)

  • WebFrame.cpp: (WebFrame::objectContentType):
Note: See TracTimeline for information about the timeline view.