Context Navigation

← Previous Period
Next Period →

Timeline

Jun 1, 2007:

10:57 PM Changeset in webkit [21956] by sfalken

1 copy in tags/Safari-522.8.7b

New tag.

8:30 PM Changeset in webkit [21955] by bdash

1 edit in tags/Safari-5522.8.3/WebCore/Configurations/Version.xcconfig

Versioning.

8:20 PM Changeset in webkit [21954] by bdash

1 copy in tags/Safari-5522.8.3

New tag.

8:12 PM Changeset in webkit [21953] by bdash

2 edits in branches/Safari-5522/WebCore

Merge r21952.

Reviewed by David Harrison.

<rdar://problem/5236843>
CrashTracer: [USER] 3 crashes in Mail at WebCore::Loader::didReceiveResponse(WebCore::SubresourceLoader*, WebCore::ResourceResponse const&)

This is by no means the best solution for handling user style sheets. I've filed <rdar://problem/5244734>
for tracking that.

loader/loader.cpp: (WebCore::Loader::didReceiveResponse): If a load starts while the frame is still in the provisional state (this can be the case when loading the user style sheet), committing the load then causes all requests to be removed from the m_requestsLoading map. This means that req might be null here. In that case we just return early.

7:37 PM Changeset in webkit [21952] by andersca

2 edits in trunk/WebCore

Reviewed by David Harrison.

<rdar://problem/5236843>
CrashTracer: [USER] 3 crashes in Mail at WebCore::Loader::didReceiveResponse(WebCore::SubresourceLoader*, WebCore::ResourceResponse const&)

This is by no means the best solution for handling user style sheets. I've filed <rdar://problem/5244734>
for tracking that.

loader/loader.cpp: (WebCore::Loader::didReceiveResponse): If a load starts while the frame is still in the provisional state (this can be the case when loading the user style sheet), committing the load then causes all requests to be removed from the m_requestsLoading map. This means that req might be null here. In that case we just return early.

6:58 PM Changeset in webkit [21951] by kevino

3 edits in branches/wx-port-alpha/trunk

Don't require a debug build of wxWidgets to be used with wxWebKit.

4:54 PM Changeset in webkit [21950] by weinig

2 edits in trunk/WebCore

Reviewed by Adele.

fix http://bugs.webkit.org/show_bug.cgi?id=13958 REGRESSION: Form select menu in iframe destroys form select menu on page

page/mac/EventHandlerMac.mm: (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking): Instead of calling the event handler methods directly, post the fake event on the application event queue. This ensures that the fake event is handled only after handling of the initiating event has ended, and is seen by ancestor frames' event handlers.

3:27 PM Changeset in webkit [21949] by sfalken

1 copy in tags/Safari-522.8.6b

New tag.

3:10 PM Changeset in webkit [23438] by kmccullo

2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Oliver.

Uncommenting some functions that should not be commented out. I needed them for the Drosera port.

WebKit.vcproj/WebKit_debug.def:

3:07 PM Changeset in webkit [23437] by kmccullo

3 edits in branches/WindowsMerge/WebKitTools

Reviewed by Steve.

3:00 PM Changeset in webkit [21948] by kevino

1 edit in branches/wx-port-alpha/trunk/WebCore/platform/wx/StringWx.cpp

More robust string conversion, courtesy of Vaclav Slavik.

2:52 PM Changeset in webkit [23436] by andersca

2 edits in branches/WindowsMerge/WebCore

Reviewed by Steve.

If the value exists but is empty, return an empty String.

plugins/win/PluginPackageWin.cpp: (WebCore::getVersionInfo):

2:28 PM Changeset in webkit [21947] by kevino

1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebView.cpp

Add explicit cast (some users reported 'ambiguous call' errors without it).

2:26 PM Changeset in webkit [21946] by kevino

1 edit in branches/wx-port-alpha/trunk/WebCore/WebCoreSources.bkl

Remove duplicate file entry.

2:23 PM Changeset in webkit [21945] by kevino

1 edit in branches/wx-port-alpha/trunk/WebCore/page/Frame.h

Remove unused variable.

2:12 PM Changeset in webkit [21944] by eseidel

14 edits in branches/feature-branch

2007-06-01 Eric Seidel <eric@webkit.org>

Reviewed by olliej.

Add support for maskUnits and maskContentUnits
http://bugs.webkit.org/show_bug.cgi?id=12568

This is covered by the W3C tests (including mask-intro01)

ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement): (WebCore::SVGMaskElement::parseMappedAttribute): (WebCore::SVGMaskElement::drawMaskerContent): (WebCore::SVGMaskElement::canvasResource): (WebCore::SVGMaskElement::notifyAttributeChange):
ksvg2/svg/SVGMaskElement.h:
ksvg2/svg/SVGMaskElement.idl:
platform/graphics/svg/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::SVGResourceMasker): (WebCore::SVGResourceMasker::invalidate):
platform/graphics/svg/SVGResourceMasker.h:
platform/graphics/svg/cg/SVGResourceMaskerCg.mm: (WebCore::SVGResourceMasker::applyMask):

2:05 PM Changeset in webkit [21943] by bdash

2 edits in branches/Safari-5522/WebCore

Merge r21933.

Reviewed by Beth Dakin.

Fixed <rdar://problem/5238177> Continuing after hitting breakpoint doesn't
execute the next step.

No test because the only code affected is the debugger, and none of the
relevant API is exported.

Reverted an accidental change in 21324 that caused originRootObject for
the window object always to be 0. We could probably just remove the debugger's
dependency on originRootObject, but I wanted to be safe.

page/mac/FrameMac.mm: (WebCore::Frame::windowScriptObject):

2:05 PM Changeset in webkit [21942] by bdash

3 edits in branches/Safari-5522/WebCore

Merge r21905.

Reviewed by Hyatt.

Fix for <rdar://problem/5198882> CrashTracer: [USER] 7 crashes in
Safari at com.apple.WebCore: WebCore::RenderBlock::layoutBlock +
2360

The problem is that we are re-entering layout when we should not.
http://trac.webkit.org/projects/webkit/changeset/21778 actually
fixed this crash, but we have been inspired to add the same guard
in two other possibly-dangerous places.

page/FrameView.cpp: (WebCore::FrameView::layout): Add the guard in two more places.

2:05 PM Changeset in webkit [21941] by bdash

5 edits
4 adds in branches/Safari-5522

Merge r21902.

LayoutTests:

Reviewed by Dr. Harrison.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13868
REGRESSION: crash on accessing a new iframe's contentWindow property

fast/dom/frame-contentWindow-crash-expected.txt: Added.
fast/dom/frame-contentWindow-crash.html: Added.
fast/dom/iframe-contentWindow-crash-expected.txt: Added.
fast/dom/iframe-contentWindow-crash.html: Added.

WebCore:

Reviewed by Dr. Harrison.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13868
REGRESSION: crash on accessing a new iframe's contentWindow property

Adds a null check in for the contentWindow property for HTMLIFrameElement
and HTMLFrameElement.

bindings/scripts/CodeGeneratorJS.pm:
html/HTMLFrameElement.idl:
html/HTMLIFrameElement.idl:

2:04 PM Changeset in webkit [21940] by bdash

2 edits in branches/Safari-5522/WebCore

Merge r21897.

Reviewed by Darin.

<rdar://problem/5200795> REGRESSION (r21057): lineBoxRects doesn't match actual text when wrapping occurs

Use box->end() instead of box->len().

rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects):

1:55 PM Changeset in webkit [23435] by sfalken

2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Kevin Decker.

Remove unnecessary user agent spoofs, now that we have the final UA in place.
Added spoof to allow Flash downloads from adobe.com

WebView.cpp: (WebView::userAgentForKURL):

12:09 PM Changeset in webkit [23434] by andersca

2 edits in branches/WindowsMerge/WebCore

Reviewed by Steve.

Add the default path for the new WMP Firefox plugin.

plugins/win/PluginDatabaseWin.cpp: (WebCore::addWindowsMediaPlayerPluginPath):

11:01 AM Changeset in webkit [21939] by andersca

15 edits in branches/Safari-522

Merge r20613 and the subsequent build fix, r20614

5:47 AM Changeset in webkit [21938] by staikos

2 edits in trunk/WebCore

2007-06-01 George Staikos <staikos@kde.org>

Reviewed by bdash.

Redo the build fix again after it was backed out

WebCore.pro: add an include guard around CSSGrammar.h

5:40 AM BuildingOnWindows edited by todd.fisher@revolution.com

(diff)

5:39 AM BuildingOnWindows edited by todd.fisher@revolution.com

(diff)

4:20 AM Changeset in webkit [21937] by eseidel

2 edits
1 add in branches/feature-branch/WebCore

2007-06-01 Eric Seidel <eric@webkit.org>

Reviewed by lars.

Cursor does not change to hand over links containing <use>
http://bugs.webkit.org/show_bug.cgi?id=12630

Test: manual-tests/svg-link-hover-use.svg

manual-tests/svg-link-hover-use.svg: Added.
rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTest): use eventParentNode instead of parentNode

2:59 AM Changeset in webkit [21936] by eseidel

5 edits
4 adds in branches/feature-branch

2007-06-01 Eric Seidel <eric@webkit.org>

Reviewed by olliej.

SVG is not correctly respecting scroll during hit testing
http://bugs.webkit.org/show_bug.cgi?id=13083

Test: svg/custom/scroll-hit-test.svg

rendering/RenderPath.cpp: (WebCore::RenderPath::nodeAtPoint):
rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::nodeAtPoint):

2:34 AM Changeset in webkit [21935] by bdash

2 edits in trunk/WebCore

Roll out r21916 as it did nothing to fix the build.

1:13 AM Changeset in webkit [21934] by eseidel

4 edits
5 adds in branches/feature-branch

2007-06-01 Eric Seidel <eric@webkit.org>

Reviewed by hyatt.

Fix for: http://bugs.webkit.org/show_bug.cgi?id=12187

Tests: fast/dom/attribute-case-sensitivity.html, fast/dom/attribute-case-sensitivity2.xhtml

dom/Element.cpp: (WebCore::shouldIgnoreAttributeCase): check to make sure element is an HTMLElement (WebCore::Element::getAttribute): (WebCore::Element::setAttribute): (WebCore::Element::removeAttribute): (WebCore::Element::getAttributeNode): (WebCore::Element::hasAttribute):
dom/NamedAttrMap.cpp: (WebCore::shouldIgnoreAttributeCase): (WebCore::NamedAttrMap::getNamedItem): (WebCore::NamedAttrMap::removeNamedItem):

12:25 AM Changeset in webkit [21933] by ggaren

3 edits in trunk/WebCore

Reviewed by Beth Dakin.

Fixed <rdar://problem/5238177> Continuing after hitting breakpoint doesn't
execute the next step.

No test because the only code affected is the debugger, and none of the
relevant API is exported.

Reverted an accidental change in 21324 that caused originRootObject for
the window object always to be 0. We could probably just remove the debugger's
dependency on originRootObject, but I wanted to be safe.

page/mac/FrameMac.mm: (WebCore::Frame::windowScriptObject):

May 31, 2007:

10:57 PM Changeset in webkit [21932] by hyatt

8 edits in trunk

WebCore:

Fix for 11768, Flash plugin does not respect clips set via CSS.

Reviewed by olliej

bindings/objc/DOM.mm: (-[DOMElement _windowClipRect]):
bindings/objc/DOMPrivate.h:
page/FrameView.cpp: (WebCore::FrameView::windowClipRect): (WebCore::FrameView::windowClipRectForLayer):
platform/ScrollView.h: (WebCore::ScrollView::contentsToWindow): (WebCore::ScrollView::windowToContents):
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::contentsToWindow): (WebCore::ScrollView::windowToContents):

WebKit:

Fix for 11768, Flash plugin does not respect clips set by CSS.

Reviewed by olliej

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):

10:46 PM Changeset in webkit [21931] by weinig

3 edits in trunk/LayoutTests

Reviewed by Adam.

Update test to reflect new correct result.

fast/dom/Window/atob-btoa-expected.txt:
fast/dom/Window/atob-btoa.html:

10:45 PM Changeset in webkit [21930] by weinig

2 edits in trunk/WebCore

Reviewed by Adam.

Fix build bot.

ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::setCurrentScale):

9:49 PM Changeset in webkit [21929] by kevino

1 edit in branches/wx-port-alpha/trunk/JavaScriptCore/wtf/Assertions.h

Correct fix to deal with variadic macros on MSVC7.

9:34 PM Changeset in webkit [23433] by weinig

2 edits in branches/WindowsMerge/WebCore

Fixed build.

WebCore.vcproj/WebCore.vcproj:

8:19 PM Changeset in webkit [21928] by weinig

2 edits in trunk/WebCore

Fix Qt and Gdk builds.

WebCore.pro: remove bindings/js/JSHTMLAnchorElementCustom.cpp

8:13 PM Changeset in webkit [21927] by weinig

16 edits
2 adds
1 delete in trunk

LayoutTests:

Reviewed by Geoff.

Tests for http://bugs.webkit.org/show_bug.cgi?id=10782
Classes should not override JSObject::toString(ExecState *)

Adds a new test to test overriding toString and valueOf for multiple objects.
Update tests to reflect the correction of the toString architecture.

editing/selection/getRangeAt-expected.txt:
fast/dom/Window/atob-btoa-expected.txt:
fast/js/toString-and-valueOf-override-expected.txt: Added.
fast/js/toString-and-valueOf-override.html: Added.

WebCore:

Reviewed by Geoff.

Patch for http://bugs.webkit.org/show_bug.cgi?id=10782
Classes should not override JSObject::toString(ExecState *)

Remove all overrides of JSObject::toString and JSObject::toPrimitive
which is a bad practice. Instead, if an object, like the
HTMLAnchorElement, needs to override to toString, it should add
a function to the JS object which will be called when needed. This
also allows developers to override toString and valueOf from within JS.

Test: fast/js/toString-and-valueOf-override.html

WebCore.xcodeproj/project.pbxproj:
bindings/js/JSHTMLAnchorElementCustom.cpp: Removed.
bindings/js/kjs_binding.cpp:
bindings/js/kjs_binding.h:
bindings/js/kjs_dom.cpp:
bindings/js/kjs_dom.h:
bindings/js/kjs_domnode.h:
bindings/js/kjs_window.cpp: (KJS::History::): (KJS::LocationFunc::callAsFunction): (KJS::SelectionFunc::callAsFunction):
bindings/js/kjs_window.h:
bindings/scripts/CodeGeneratorJS.pm:
html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::toString):
html/HTMLAnchorElement.h:
html/HTMLAnchorElement.idl:

7:35 PM Changeset in webkit [21926] by kevino

1 edit in branches/wx-port-alpha/trunk/JavaScriptCore/wtf/Assertions.h

Add a note about variadic macros on MSVC7, and enable any macros which don't use variadic args.

6:52 PM Changeset in webkit [21925] by weinig

9 edits in trunk/WebCore

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11272
Implement currentScale(), setCurrentScale() and currentTranslate() in SVGSVGElement

Allow zooming and panning, thereby implementing the above methods.

ksvg2/svg/SVGDocument.cpp: (WebCore::SVGDocument::zoomEnabled): (WebCore::SVGDocument::startPan): (WebCore::SVGDocument::updatePan):
ksvg2/svg/SVGDocument.h:
ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::currentScale): (WebCore::SVGSVGElement::setCurrentScale): (WebCore::SVGSVGElement::currentTranslate): (WebCore::SVGSVGElement::setCurrentTranslate):
ksvg2/svg/SVGSVGElement.h:
page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::handleMouseReleaseEvent):
page/EventHandler.h:
page/Frame.cpp: (WebCore::Frame::setZoomFactor):
rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout): (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::absoluteTransform):
rendering/RenderSVGContainer.h:

6:35 PM Changeset in webkit [21924] by weinig

4 edits
4 adds in trunk

LayoutTests:

Reviewed by Niko.

Test for fix: http://bugs.webkit.org/show_bug.cgi?id=12570

svg/custom/prevent-default-expected.checksum: Added.
svg/custom/prevent-default-expected.png: Added.
svg/custom/prevent-default-expected.txt: Added.
svg/custom/prevent-default.svg: Added.

WebCore:

Reviewed by Niko.

Links are activated based on mouse down events instead of click events
http://bugs.webkit.org/show_bug.cgi?id=12570

Test: svg/custom/prevent-default.svg

html/HTMLAnchorElement.cpp: use MiddleButton and RightButton instead of 1 and 2 (WebCore::HTMLAnchorElement::defaultEventHandler):
ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): make it function more like the HTML side

5:21 PM Changeset in webkit [21923] by mjs

1 edit in trunk/LayoutTests/ChangeLog

Reviewed by Hyatt.

fix layout test editing/style/table-selection.html

editing/style/table-selection-expected.txt: Updated selection delegate output.

5:19 PM Changeset in webkit [21922] by mjs

4 edits in trunk

LayoutTests:

Reviewed by Hyatt.

fix layout test editing/style/table-selection.html

editing/style/table-selection-expected.txt: Updated selection delegate output.

WebCore:

Reviewed by Hyatt.

fix layout test editing/style/table-selection.html

This was broken by the change to keep whitespace text nodes in tables. They safely didn't render,
but the font delta style change command would wrap them in spans, creating extra anonymous table
cells.

editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Don't wrap in a span if the text node is not rendered.

4:50 PM Changeset in webkit [21921] by weinig

4 edits
1 move in trunk

top level:

Reviewed by Eric Seidel.

http://bugs.webkit.org/show_bug.cgi?id=13941
Rename WebCore/platform/network/gdk to WebCore/platform/network/curl

WebKit.pri:

WebCore:

Reviewed by Eric Seidel.

http://bugs.webkit.org/show_bug.cgi?id=13941
Rename WebCore/platform/network/gdk to WebCore/platform/network/curl

WebCore.pro:

1:53 PM Changeset in webkit [21920] by eseidel

4 edits
4 adds in branches/feature-branch

2007-05-31 Eric Seidel <eric@webkit.org>

Reviewed by Niko.

Links are activated based on mouse down events instead of click events
http://bugs.webkit.org/show_bug.cgi?id=12570

Test: svg/custom/prevent-default.svg

html/HTMLAnchorElement.cpp: use MiddleButton and RightButton instead of 1 and 2 (WebCore::HTMLAnchorElement::defaultEventHandler):
ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): make it function more like the HTML side

1:33 PM Changeset in webkit [21919] by weinig

2 edits in trunk/WebCore

Reviewed by Niko.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13945
GraphicsContextCairo enhancements necessary for SVG support

platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::beginPath): (WebCore::GraphicsContext::addPath):

1:20 PM Changeset in webkit [21918] by kevino

43 edits
4 copies
17 adds in branches/wx-port-alpha/trunk

Merge with TOT and add files that weren't automatically added during the last merge.

12:49 PM Changeset in webkit [21917] by pyeh

2 edits in trunk/WebCore

<rdar://problem/5221920> AXLink is returning a CFString instead of a CFURL for AXURL

bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityAttributeValue:]): Convert the url string to an NSURL before returning as the AXURLAttribute

12:44 PM Changeset in webkit [21916] by staikos