Context Navigation

http://bugs.webkit.org/show_bug.cgi?id=13352 REGRESSION: Gmail hangs on send message.
Now we don't hang, but we do so by avoiding certain legitimate characters, the evangelism bug for this is: <rdar://problem/5252577> gmail does not accept legal characters in the form boundary

html/HTMLFormElement.cpp: (WebCore::getUniqueBoundaryString):

7:29 PM Changeset in webkit [22012] by bdash

3 edits in branches/Safari-522/WebCore

2007-06-06 Mark Rowe <mrowe@apple.com>

Build fix. Merge in a portion of r20802 that a merged change appears to depend on.

6:05 PM Changeset in webkit [22011] by sfalken

1 copy in tags/Safari-522.9.1b

New tag.

5:30 PM Changeset in webkit [22010] by bdash

2 edits in branches/Safari-522/WebKit

Merge r21623.

Reviewed by Ada.

<rdar://problem/5200816> REGRESSION: With Shiira 1.2.2 , I can't open embedded link in flash object by clicking (http:/www.adobe.com )

Null check the request.

WebView/WebView.mm: (+[WebView _canHandleRequest:]):

5:30 PM Changeset in webkit [22009] by bdash

3 edits in branches/Safari-522/WebCore

Merge in r21480.

Reviewed by Geoff.

<rdar://problem/5200816>
REGRESSION: With Shiira 1.2.2 , I can't open embedded link in flash object by clicking (http:/www.adobe.com )

Shiira under some circumstances passes nil as the request to -[WebFrame loadRequest:]. ToT WebKit doesn't call any policy
delegate methods in this case, which means that the page is actually being loaded.

This patch makes ToT WebKit behave in the same way as Tiger WebKit when the request is nil.

loader/FrameLoader.cpp: (WebCore::FrameLoader::checkNavigationPolicy): Don't continue without calling the navigation policy method if the request is null.

(WebCore::FrameLoader::continueAfterNavigationPolicy):
If the request can't be handled, don't continue the load.

platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest): Don't create an NSURLRequest object if the request is null.

5:29 PM Changeset in webkit [22008] by bdash

3 edits
2 adds in branches/Safari-522

Merge r21423.

2007-05-11 Oliver Hunt <oliver@apple.com>

LayoutTests:

Reviewed by Hyatt.

Layout test for x-mac-roman character encoding.

fast/encoding/xmacroman-encoding-test-expected.txt: Added.
fast/encoding/xmacroman-encoding-test.html: Added.

WebCore:

Reviewed by Hyatt.

<rdar://problem/5195473> REGRESSION: "Curly quote" fails to
be displayed correctly even when META tag specifies charset=x-mac-roman

platform/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames): Register the xmacroman encoding

5:29 PM Changeset in webkit [22007] by bdash

2 edits in branches/Safari-522/WebKit

Merge r20812.

Reviewed by Darin.

<rdar://problem/5026893>
REGRESSION: "Mail Contents of this Page" for standalone image in Safari results in a broken image in Mail

WebView/WebFrame.mm: (-[WebFrame DOMDocument]): We can't check for _isHTMLDocument here since image and plugin documents inherit from HTMLDocument. Instead, check for those two document types explicitly.

5:28 PM Changeset in webkit [22006] by bdash

2 edits in branches/Safari-522/WebCore

Merge r21117.

Reviewed by Hyatt.

<rdar://problem/4851944>
REGRESSION: With TOT, BMP images can no longer be opened in the browser window

On Tiger, the MIME type for the com.microsoft.bmp UTI isn't in the registry, so add it manually.

platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes):

5:28 PM Changeset in webkit [22005] by bdash

3 edits in branches/Safari-522/JavaScriptCore

Merge r21080.

Reviewed by Oliver.

use custom calling convention for everything in nodes.cpp on intel gcc for 1.5% speed boost

Nearly all functions in nodes.cpp were marked up to use the
regparm(3) calling convention under GCC for x86, since this is
faster and they are all guaranteed to be called only internally to
kjs.

The only exception is destructors, since delete doesn't know how to use a custom calling convention.

kjs/nodes.cpp: (dotExprDoesNotAllowCallsString):
kjs/nodes.h: (KJS::Node::): (KJS::StatementNode::): (KJS::NullNode::): (KJS::BooleanNode::): (KJS::NumberNode::): (KJS::StringNode::): (KJS::RegExpNode::): (KJS::ThisNode::): (KJS::ResolveNode::): (KJS::GroupNode::): (KJS::ElementNode::): (KJS::ArrayNode::): (KJS::PropertyNameNode::): (KJS::PropertyNode::): (KJS::PropertyListNode::): (KJS::ObjectLiteralNode::): (KJS::BracketAccessorNode::): (KJS::DotAccessorNode::): (KJS::ArgumentListNode::): (KJS::ArgumentsNode::): (KJS::NewExprNode::): (KJS::FunctionCallValueNode::): (KJS::FunctionCallResolveNode::): (KJS::FunctionCallBracketNode::): (KJS::FunctionCallParenBracketNode::): (KJS::FunctionCallDotNode::): (KJS::FunctionCallParenDotNode::): (KJS::PostfixResolveNode::): (KJS::PostfixBracketNode::): (KJS::PostfixDotNode::): (KJS::PostfixErrorNode::): (KJS::DeleteResolveNode::): (KJS::DeleteBracketNode::): (KJS::DeleteDotNode::): (KJS::DeleteValueNode::): (KJS::VoidNode::): (KJS::TypeOfResolveNode::): (KJS::TypeOfValueNode::): (KJS::PrefixResolveNode::): (KJS::PrefixBracketNode::): (KJS::PrefixDotNode::): (KJS::PrefixErrorNode::): (KJS::UnaryPlusNode::): (KJS::NegateNode::): (KJS::BitwiseNotNode::): (KJS::LogicalNotNode::): (KJS::MultNode::): (KJS::AddNode::): (KJS::ShiftNode::): (KJS::RelationalNode::): (KJS::EqualNode::): (KJS::BitOperNode::): (KJS::BinaryLogicalNode::): (KJS::ConditionalNode::): (KJS::AssignResolveNode::): (KJS::AssignBracketNode::): (KJS::AssignDotNode::): (KJS::AssignErrorNode::): (KJS::CommaNode::): (KJS::AssignExprNode::): (KJS::VarDeclListNode::): (KJS::VarStatementNode::): (KJS::EmptyStatementNode::): (KJS::ExprStatementNode::): (KJS::IfNode::): (KJS::DoWhileNode::): (KJS::WhileNode::): (KJS::ForNode::): (KJS::ContinueNode::): (KJS::BreakNode::): (KJS::ReturnNode::): (KJS::WithNode::): (KJS::LabelNode::): (KJS::ThrowNode::): (KJS::TryNode::): (KJS::ParameterNode::): (KJS::Parameter::): (KJS::FunctionBodyNode::): (KJS::FuncExprNode::): (KJS::FuncDeclNode::): (KJS::SourceElementsNode::): (KJS::CaseClauseNode::): (KJS::ClauseListNode::): (KJS::SwitchNode::):

5:28 PM Changeset in webkit [22004] by bdash

4 edits
1 add in branches/Safari-522/JavaScriptCore

Merge r21064.

Reviewed by Geoff.

compile most of JavaScriptCore as one file for 4% JS iBench speed improvement

JavaScriptCore.xcodeproj/project.pbxproj: Add AllInOneFile.cpp, and remove files it includes from the build.
kjs/AllInOneFile.cpp: Added.
kjs/dtoa.cpp: Renamed CONST to CONST_ to avoid conflict. (Bigint::): (Bigint::nrv_alloc):
kjs/lookup.cpp: Use "namspace KJS { ... }" instead of "using namespace KJS;"

5:27 PM Changeset in webkit [22003] by bdash

2 edits in branches/Safari-522/JavaScriptCore

Merge r21050.

Build fix, not reviewed.

kjs/collector.h: Fix struct/class mismatch.

5:27 PM Changeset in webkit [22002] by bdash

2 edits in branches/Safari-522/JavaScriptCore

Merge r21048.

Reviewed by Darin.

raise ALLOCATIONS_PER_COLLECTION to 4000, for 3.7% iBench speed improvement

Now that the cell size is smaller and the block size is bigger, we can fit 4000 objects in
the two spare cells the collector is willing to keep around, so collect a bit less often.

kjs/collector.cpp:

5:27 PM Changeset in webkit [22001] by bdash

4 edits in branches/Safari-522/JavaScriptCore

Merge r21047.

Reviewed by Darin and Geoff.

move mark and collectOnMainThreadOnly bits into separate bitmaps

This saves 4 bytes per cell, allowing shrink of cell size to 32,
which leads to a .8% speed improvement on iBench.

This is only feasible because of all the previous changes on the branch.

kjs/collector.cpp: (KJS::allocateBlock): Adjust for some renames of constants. (KJS::Collector::markStackObjectsConservatively): Now that cells are 32 bytes (64 bytes on 64-bit) the cell alignment check can be made much more strict, and also obsoletes the need for a % sizeof(CollectorCell) check. Also, we can mask off the low bits of the pointer to have a potential block pointer to look for. (KJS::Collector::collectOnMainThreadOnly): Use bitmap. (KJS::Collector::markMainThreadOnlyObjects): Use bitmap. (KJS::Collector::collect): When sweeping, use bitmaps directly to find mark bits.
kjs/collector.h: (KJS::): Move needed constants and type declarations here. (KJS::CollectorBitmap::get): Bit twiddling to get a bitmap value. (KJS::CollectorBitmap::set): Bit twiddling to set a bitmap bit to true. (KJS::CollectorBitmap::clear): Bit twiddling to set a bitmap bit to false. (KJS::CollectorBitmap::clearAll): Clear whole bitmap at one go. (KJS::Collector::cellBlock): New operation, compute the block pointer for a cell by masking off low bits. (KJS::Collector::cellOffset): New operation, compute the cell offset for a cell by masking off high bits and dividing (actually a shift). (KJS::Collector::isCellMarked): Check mark bit in bitmap (KJS::Collector::markCell): Set mark bit in bitmap.
kjs/value.h: (KJS::JSCell::JSCell): No more bits. (KJS::JSCell::marked): Let collector handle it. (KJS::JSCell::mark): Let collector handle it.

5:27 PM Changeset in webkit [22000] by bdash

2 edits in branches/Safari-522/JavaScriptCore

Merge r21034.

Build fix.

kjs/regexp_object.h: RegExpObjectImpPrivate is a struct, not a class.

5:26 PM Changeset in webkit [21999] by bdash

7 edits in branches/Safari-522/JavaScriptCore

Merge r21032.

Reviewed by Darin.

shrink FunctionImp / DeclaredFunctionImp by 4 bytes, by moving parameter list to function body

I reconciled this with a similar change in KDE kjs by Maks Orlovich <maksim@kde.org>.

kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::FunctionImp::passInParameters): (KJS::FunctionImp::lengthGetter): (KJS::FunctionImp::getParameterName):
kjs/function.h:
kjs/function_object.cpp: (FunctionProtoFunc::callAsFunction): (FunctionObjectImp::construct):
kjs/nodes.cpp: (FunctionBodyNode::addParam): (FunctionBodyNode::paramString): (FuncDeclNode::addParams): (FuncDeclNode::processFuncDecl): (FuncExprNode::addParams): (FuncExprNode::evaluate):
kjs/nodes.h: (KJS::Parameter::Parameter): (KJS::FunctionBodyNode::numParams): (KJS::FunctionBodyNode::paramName): (KJS::FunctionBodyNode::parameters): (KJS::FuncExprNode::FuncExprNode): (KJS::FuncDeclNode::FuncDeclNode):
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Disable 64-bit warnings because they handle size_t badly.

5:26 PM Changeset in webkit [21998] by bdash

3 edits in branches/Safari-522/JavaScriptCore

Merge r21031.

Reviewed by Darin.

shrink RegexpObjectImp by 4 bytes

Somewhat inexplicably, this seems to be a .33% speedup on JS iBench.

kjs/regexp_object.cpp: (KJS::RegExpObjectImpPrivate::RegExpObjectImpPrivate): (RegExpObjectImp::RegExpObjectImp): (RegExpObjectImp::performMatch): (RegExpObjectImp::arrayOfMatches): (RegExpObjectImp::getBackref): (RegExpObjectImp::getLastMatch): (RegExpObjectImp::getLastParen): (RegExpObjectImp::getLeftContext): (RegExpObjectImp::getRightContext): (RegExpObjectImp::getValueProperty): (RegExpObjectImp::putValueProperty):
kjs/regexp_object.h:

5:26 PM Changeset in webkit [21997] by bdash

2 edits in branches/Safari-522/JavaScriptCore

Merge r21030.

Reviewed by Oliver.

change to 1-bit bitfields instead of 8-bit, this turns out to lead to a .51% speedup on JS iBench

The 1-bit bitfields are actually faster than just plain bools, at least on Intel (go figure).

kjs/property_map.h:

5:25 PM Changeset in webkit [21996] by bdash

3 edits in branches/Safari-522/JavaScriptCore

Merge r21029.

Reviewed by Darin.

shrink ArrayInstance objects by 4 bytes http://bugs.webkit.org/show_bug.cgi?id=13386

I did this by storing the capacity before the beginning of the storage array. It turns out
it is rarely needed and is by definition 0 when the storage array is null.

kjs/array_instance.h: (KJS::ArrayInstance::capacity): Get it from the secret stash
kjs/array_object.cpp: (allocateStorage): New function to encapsulate allocating the storage with extra space ahead for the capacity. (reallocateStorage): ditto for realloc (ArrayInstance::ArrayInstance): (ArrayInstance::~ArrayInstance): (ArrayInstance::resizeStorage):

5:25 PM Changeset in webkit [21995] by bdash

2 edits in branches/Safari-522/JavaScriptCore

Merge r21025.

Reviewed by Darin.

fix test failures / crashes on PPC

kjs/property_map.h: Make the bool fields explicitly 8-bit bitfields, since bool is a full word there otherwise :-(

5:25 PM Changeset in webkit [21994] by bdash

3 edits in branches/Safari-522/JavaScriptCore

Merge r21024.

Reviewed by Darin.

fix more test case failures

bindings/runtime_array.cpp: (RuntimeArray::RuntimeArray): inherit from JSObject instead of ArrayInstance; it turns out that this class only needs the prototype and classInfo from ArrayInstance, not the actual class itself, and it was too big otherwise. (RuntimeArray::getOwnPropertySlot):
bindings/runtime_array.h:

5:25 PM Changeset in webkit [21993] by bdash

3 edits in branches/Safari-522/JavaScriptCore

Merge r21023.

Reviewed by Darin.

fix some test failures

bindings/runtime_method.cpp: (RuntimeMethod::RuntimeMethod): inherit from InternalFunctionImp instead of FunctionImpl, otherwise this is too big (RuntimeMethod::getOwnPropertySlot):
bindings/runtime_method.h:

5:24 PM Changeset in webkit [21992] by bdash

6 edits in branches/Safari-522/JavaScriptCore

Merge r21019.

Reviewed by Darin.

discard the arguments List for an ActivationImp when the corresponding Context is destroyed (1.7% speedup) http://bugs.webkit.org/show_bug.cgi?id=13385

Based an idea by Christopher E. Hyde <C.Hyde@parableuk.force9.co.uk>. His patch to do
this also had many other List changes and I found this much simpler subset of the changes
was actually a hair faster.

This optimization is valid because the arguments list is only kept around to
lazily make the arguments object. If it's not made by the time the function
exits, it never will be, since any function that captures the continuation will
have its own local arguments variable in scope.

Besides the 1.7% speed improvement, it shrinks List by 4 bytes
(which in turn shrinks ActivationImp by 4 bytes).

kjs/Context.cpp: (KJS::Context::~Context): Clear the activation's arguments list.
kjs/function.cpp: (KJS::ActivationImp::ActivationImp): Adjusted for list changes. (KJS::ActivationImp::mark): No need to mark, lists are always protected (this doesn't cause a ref-cycle for reasons stated above). (KJS::ActivationImp::createArgumentsObject): Clear arguments list.
kjs/function.h:
kjs/list.cpp: (KJS::List::List): No more needsMarking boolean (KJS::List::operator=): ditto
kjs/list.h: (KJS::List::List): ditto (KJS::List::reset): ditto (KJS::List::deref): ditto

5:24 PM Changeset in webkit [21991] by bdash

4 edits in branches/Safari-522/JavaScriptCore

Merge r21018.

Reviewed by Darin.

shrink PropertyMap by 8 bytes and therefore shrink CELL_SIZE to 40 (for 32-bit; similar shrinkage for 64-bit) http://bugs.webkit.org/show_bug.cgi?id=13384

Inspired by similar changes by Christopher E. Hyde <C.Hyde@parableuk.force9.co.uk>
done in the kjs-tweaks branch of KDE's kjs. However, this version is somewhat
cleaner style-wise and avoids some of the negative speed impact (at least on gcc/x86)
of his version.

This is nearly a wash performance-wise, maybe a slight slowdown, but worth doing
to eventually reach cell size 32.

kjs/collector.cpp: (KJS::):
kjs/property_map.cpp: (KJS::PropertyMap::~PropertyMap): (KJS::PropertyMap::clear): (KJS::PropertyMap::get): (KJS::PropertyMap::getLocation): (KJS::PropertyMap::put): (KJS::PropertyMap::insert): (KJS::PropertyMap::expand): (KJS::PropertyMap::rehash): (KJS::PropertyMap::remove): (KJS::PropertyMap::mark): (KJS::PropertyMap::containsGettersOrSetters): (KJS::PropertyMap::getEnumerablePropertyNames): (KJS::PropertyMap::getSparseArrayPropertyNames): (KJS::PropertyMap::save): (KJS::PropertyMap::checkConsistency):
kjs/property_map.h: (KJS::PropertyMap::hasGetterSetterProperties): (KJS::PropertyMap::setHasGetterSetterProperties): (KJS::PropertyMap::): (KJS::PropertyMap::PropertyMap):

5:24 PM Changeset in webkit [21990] by bdash

2 edits in branches/Safari-522/JavaScriptCore

Merge r21017.

Reviewed by Darin.

change blocks to 64k in size, and use various platform-specific calls to allocate at 64k-aligned addresses http://bugs.webkit.org/show_bug.cgi?id=13383

kjs/collector.cpp: (KJS::allocateBlock): New function to allocate 64k of 64k-aligned memory (KJS::freeBlock): Corresponding free (KJS::Collector::allocate): (KJS::Collector::collect):

5:23 PM Changeset in webkit [21989] by bdash

2 edits in branches/Safari-522/JavaScriptCore

Merge r21015.

Reviewed by Darin and Geoff.

remove the concept of oversize objects, now that there aren't any (for now only enforced with an assert). http://bugs.webkit.org/show_bug.cgi?id=13382

This change is a .66% speedup on JS iBench for 32-bit platforms, probably much more
for 64-bit since it finally gives a reasonable cell size, but I did not test that.

kjs/collector.cpp: (KJS::): Use different cell size for 32-bit and 64-bit, now that there is no oversize allocation. (KJS::Collector::allocate): Remove oversize allocator. (KJS::Collector::markStackObjectsConservatively): Don't check oversize objects. (KJS::Collector::markMainThreadOnlyObjects): Ditto. (KJS::Collector::collect): Ditto.

5:23 PM Changeset in webkit [21988] by bdash

4 edits in branches/Safari-522/WebCore

Merge r21014.

Reviewed by Darin and Geoff.

move most of Window's data members into a separate private object, to avoid needing to use the oversize allocator for it

It was the only remaining JSObject subclass to use the oversize
allocator on 32-bit platforms, and having oversize objects around
makes garbage collection slower so this would hurt performance
with many tabs/windows open.

No significant effect on JS iBench.

bindings/js/kjs_events.cpp: (KJS::JSUnprotectedEventListener::JSUnprotectedEventListener): (KJS::JSUnprotectedEventListener::~JSUnprotectedEventListener): (KJS::JSEventListener::JSEventListener): (KJS::JSEventListener::~JSEventListener): (KJS::JSLazyEventListener::parseCode):
bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::Window::Window): (KJS::Window::~Window): (KJS::Window::location): (KJS::Window::selection): (KJS::Window::locationbar): (KJS::Window::menubar): (KJS::Window::personalbar): (KJS::Window::statusbar): (KJS::Window::toolbar): (KJS::Window::scrollbars): (KJS::Window::mark): (KJS::Window::getValueProperty): (KJS::Window::findJSEventListener): (KJS::Window::findJSUnprotectedEventListener): (KJS::Window::clearHelperObjectProperties): (KJS::Window::clear): (KJS::Window::setCurrentEvent): (KJS::Window::setReturnValueSlot): (KJS::Window::clearAllTimeouts): (KJS::Window::installTimeout): (KJS::Window::pauseTimeouts): (KJS::Window::resumeTimeouts): (KJS::Window::clearTimeout): (KJS::Window::timerFired): (KJS::Window::disconnectFrame): (KJS::Window::jsEventListeners): (KJS::Window::jsHTMLEventListeners): (KJS::Window::jsUnprotectedEventListeners): (KJS::Window::jsUnprotectedHTMLEventListeners):
bindings/js/kjs_window.h:

5:22 PM Changeset in webkit [21987] by bdash

2 edits in branches/Safari-522/JavaScriptCore

Merge r20991.

2007-04-21 Mitz Pettel <mitz@webkit.org>

Reviewed by Adam.

fix http://bugs.webkit.org/show_bug.cgi?id=13428 REGRESSION (r20973-r20976): Failing ecma/Array/15.4.4.5-3.js

fix http://bugs.webkit.org/show_bug.cgi?id=13429 REGRESSION (r20973-r20976): Crashing in fast/dom/plugin-attributes-enumeration.html

kjs/array_object.cpp: (ArrayInstance::sort): Free the old storage, not the new one.

5:22 PM Changeset in webkit [21986] by bdash

2 edits in branches/Safari-522/JavaScriptCore

Merge r20977.

Not reviewed, build fix.

fix build problem with last change - -O3 complains more about uninitialized variables

pcre/pcre_compile.c: (compile_branch): (pcre_compile2):

5:22 PM Changeset in webkit [21985] by bdash

3 edits in branches/Safari-522/JavaScriptCore

Merge r20974.

Reviewed by Darin.

<rdar://problem/5149915> use mergesort when possible, since it leads to fewer compares (2% JS iBench speedup)

kjs/array_object.cpp: (ArrayInstance::sort): Use mergesort(3) on platforms that have it, since it tends to do fewer compares than qsort; but avoid it very on large arrays since it uses extra memory. Also added comments identifying possibly even better sorting algorithms for sort by string value and sort by compare function.
kjs/config.h:

5:21 PM Changeset in webkit [21984] by bdash

2 edits in branches/Safari-522/JavaScriptCore

Merge r20973.

Reviewed by Darin.

bump optimization flags up to -O3 for 1% JS iBench speed improvement

Configurations/Base.xcconfig:

5:09 PM Changeset in webkit [21983] by sfalken

2 edits in branches/Safari-522/WebCore

Merged fix from r21975.

2:01 PM Changeset in webkit [21982] by andersca

2 edits in trunk/WebCore

Build fix.

xml/xmlhttprequest.cpp: (WebCore::isValidToken):

1:47 PM Changeset in webkit [21981] by andersca

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Geoff.

<rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
<rdar://problem/5246208> HTTP injection in XMLHttpRequest.open method parameter
<rdar://problem/5246242> HTTP header injection in HXMLHttpRequest.setRequestHeader header parameter

fast/dom/xmlhttprequest-invalid-values-expected.txt: Added.
fast/dom/xmlhttprequest-invalid-values.html: Added.

WebCore:

Reviewed by Geoff.

<rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
<rdar://problem/5246208> HTTP injection in XMLHttpRequest.open method parameter
<rdar://problem/5246242> HTTP header injection in HXMLHttpRequest.setRequestHeader header parameter

Check method names, header names and header values and throw exceptions if any of them are
invalid. This is what the new XMLHttpRequest spec states that we should do.

xml/xmlhttprequest.cpp: (WebCore::isValidToken): (WebCore::isValidHeaderValue): (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::setRequestHeader):

1:39 PM Changeset in webkit [21980] by spadma

26 edits in S60/trunk

w3liu, reviewed by Sachin

DESC: 3.2 widget flag changes.
http://bugs.webkit.org/show_bug.cgi?id=13939

BrowserControl/src/BrCtl.cpp: (CBrCtl::HandleCommandL): (CBrCtl::AddOptionMenuItemsL): (CBrCtl::CreateWidgetExtensionL):
BrowserCore/Formcontrols/src/FControlFileInputSkin.cpp: (CFormFileInputSkin::ActivateL):
BrowserView/inc/WebKitControl.h: (CWebKitControl::WidgetExtension):
BrowserView/inc/webkitbridge.h:
BrowserView/src/WebKitControl.cpp: (CWebKitOOMNotifier::Notify): (CStaticObjectContainer::CStaticObjectContainer): (CStaticObjectContainer::FormDataManagerHandlerL): (CStaticObjectContainer::DownloadObserver): (CStaticObjectContainer::InitializeFactoryObjectsL): (CWebKitControl::CWebKitControl): (CWebKitControl::ConstructL): (CWebKitControl::~CWebKitControl): (CWebKitControl::GetBrowserSettingL): (CWebKitControl::PageInfoLC): (CWebKitControl::HandleLoaderCommandL): (CWebKitControl::SyncCancelL): (CWebKitControl::HistoryView): (CWebKitControl::IncrementProgressForMoreData): (CWebKitControl::FinalProgressComplete): (CWebKitControl::ForegroundEvent): (CWebKitControl::CreateWidgetExtensionL):
BrowserView/src/WebKitView.cpp: (CWebKitView::MakeVisible): (CWebKitView::Draw):
BrowserView/src/webkitbridge.cpp: (CWebKitBridge::createWidgetMenuItemObject):
Plugin/inc/PluginHandler.h:
Plugin/inc/PluginSkin.h:
Plugin/inc/PluginWin.h:
Plugin/inc/npapi.h:
Plugin/src/NpnImplementation.cpp: (NpnGetValue):
Plugin/src/PluginHandler.cpp:
Plugin/src/PluginSkin.cpp: (CPluginSkin::ConstructL): (CPluginSkin::PluginScriptableObject):
Plugin/src/PluginWin.cpp: (CPluginWin::PluginScriptableObject):
group/BrowserView.mmp:
group/Plugin.mmp:
group/formcontrols.mmpi:
group/webkit.mmp:

1:33 PM Changeset in webkit [21979] by weinig

11 edits in trunk/WebCore

Reviewed by Geoff.

Optimize JSCSSStyleDeclaration after performance regression in r21854.

Check static table before name getter in JSCSSStyleDeclaration::getOwnPropertySlot()
Get rid of a string allocation by keeping string as KJS::Identifier for canGetItemsForName() functions.

WebCore.xcodeproj/project.pbxproj:
bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::canGetItemsForName):
bindings/js/JSHTMLAppletElementCustom.cpp: (WebCore::JSHTMLAppletElement::canGetItemsForName):
bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::canGetItemsForName):
bindings/js/JSHTMLEmbedElementCustom.cpp: (WebCore::JSHTMLEmbedElement::canGetItemsForName):
bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::canGetItemsForName):
bindings/js/JSHTMLFrameSetElementCustom.cpp: (WebCore::JSHTMLFrameSetElement::canGetItemsForName):
bindings/js/JSHTMLObjectElementCustom.cpp: (WebCore::JSHTMLObjectElement::canGetItemsForName):
bindings/scripts/CodeGeneratorJS.pm:
css/CSSStyleDeclaration.idl:

12:53 PM BuildingGdk edited by alp@atoker.com

Update "Code layout" section (diff)

12:20 PM Changeset in webkit [21978] by eseidel

4 edits in branches/feature-branch/WebCore

2007-06-05 Eric Seidel <eric@webkit.org>

Reviewed by olliej.

Commit files missing from previous commit, oops!

platform/graphics/svg/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::SVGResourceMasker): (WebCore::SVGResourceMasker::invalidate):
platform/graphics/svg/SVGResourceMasker.h:
platform/graphics/svg/cg/SVGResourceMaskerCg.mm: (WebCore::SVGResourceMasker::applyMask):

Jun 4, 2007:

7:49 PM Changeset in webkit [21977] by sfalken

1 copy in tags/Safari-522.8.10b

New tag.

6:09 PM BuildingGdk edited by jdahlin@async.com.br

(diff)

5:15 PM Changeset in webkit [21976] by oliver

3 edits in trunk/WebKit

Reviewed by Geoff and Justin.

Fix for <rdar://problem/5246941> Clicking URL field on
Safari causes halt for a minute when using input methods.
and <rdar://problem/5245964> Safari hangs for several
seconds when trying to select text using mouse

This is a by product of the textStorage hack used to fix
rdar://problem/5000470 -- TSM calls textStorage repeatedly
when changing focus, on certain mouse events, etc. If there
is no selection/editable region we repeatedly create an
NSAttributedString from the full document. If the document is
sufficiently long this starts consuming an inordinate amount of
time.

This check should really have been present in the original
patch.

WebKit.xcodeproj/project.pbxproj:
WebView/WebHTMLView.mm: (-[WebHTMLView textStorage]):

5:10 PM Changeset in webkit [21975] by andersca

2 edits in trunk/WebCore

Reviewed, tweaked and landed by Anders.

<rdar://problem/5247178> REGRESSION: With CSS Edit 2.5, a crash occurs at WebCore::DeprecatedString::DeprecatedString when page fails to be extracted

Null check the provisional document loader. If an application stops the load
inside of the didFailProvisionalLoad delegate method, the provisional document loader will be nulled out.

loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame):

4:43 PM Changeset in webkit [21974] by bdash

6 edits in trunk/WebCore

2007-06-04 Alp Toker <alp.toker@collabora.co.uk>

Reviewed by Anders.

http://bugs.webkit.org/show_bug.cgi?id=13986
Cairo graphics fixes and cleanups

platform/graphics/ImageBuffer.h:
platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::surface): Provide surface() accessor.
platform/graphics/cairo/AffineTransformCairo.cpp: (WebCore::AffineTransform::rotate): Convert from degrees to radians to fix rotation.
platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawRect): Add save/restore. (WebCore::GraphicsContext::rotate): Rename parameter to "radians" to avoid further confusion.
platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::boundingRect): The cairo_fill_extents() parameters do not describe a point/size but rather the two control points of the rectangular region. (WebCore::Path::contains): Remove needless casts.

4:40 PM Changeset in webkit [21973] by bdash

2 edits in trunk/WebKitTools

2007-06-05 Mark Rowe <mrowe@apple.com>

Reviewed by Anders.

WebKitLauncher/Info.plist: Update CFBundleGetInfoString, and add CFBundleShortVersionString.

4:37 PM Changeset in webkit [21972] by bdash

2 edits in tags/Safari-5522.8.3/WebKitTools

Roll out change landed in the wrong place.

4:36 PM Changeset in webkit [21971] by bdash

2 edits in tags/Safari-5522.8.3/WebKitTools

2007-06-05 Mark Rowe <mrowe@apple.com>

Reviewed by Anders.

WebKitLauncher/Info.plist: Update CFBundleGetInfoString, and add CFBundleShortVersionString.

2:49 PM Changeset in webkit [21970] by yongjzha

2 edits in S60/trunk/WebKit

yadavall, reviewed by <yongjun.zhang@nokia.com>

DESC: Remove circular dependency between UI RSS file and engine
http://bugs.webkit.org/show_bug.cgi?id=13994

BrowserView/src/WidgetExtension.cpp: (CWidgetExtension::NewL): (CWidgetExtension::~CWidgetExtension): (CWidgetExtension::LaunchApplicationL): (CWidgetExtension::OpenApplication): (CWidgetExtension::SetPreferenceForKey): (CWidgetExtension::AddOptionMenuItemsL): (CWidgetExtension::MenuItemSelected): (CWidgetExtension::SetParamL): (CWidgetExtension::AddOptionsMenuItem): (CWidgetExtension::SetRightSoftKeyLabel): (CWidgetExtension::Append): (CWidgetExtension::DeleteMenuItem): (CWidgetExtension::ReplaceMenuItem): (CWidgetExtension::MenuItem): (CWidgetExtension::GetFromMenuItemCollection): (CWidgetExtension::SetDimmed): (CWidgetExtension::SetMenuItemObserver): (CWidgetExtension::MenuItemObserver): (CWidgetExtension::MenuObserver): (CWidgetExtension::RightKeyObserver): (CWidgetExtension::FindNodeById): (CWidgetExtension::FindNodeByText):

2:27 PM Changeset in webkit [21969] by weinig

2 edits in trunk/WebCore

Reviewed by Adam Roben.

Fix the buildbot.

rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):

11:39 AM Changeset in webkit [21968] by justing

6 edits
2 adds in trunk

LayoutTests:

Reviewed by Kimon Tsinteris.

<rdar://problem/5241148> REGRESSION: ActivEdit can't perform operations on certain selections

Demonstrates bug:

editing/selection/5241148-expected.txt: Added.
editing/selection/5241148.html: Added. Updated to reflect new equivalents for positions before/after tables:
editing/selection/click-before-and-after-table-expected.txt:
editing/selection/click-before-and-after-table.html:

WebCore:

Reviewed by Kimon Tsinteris.

<rdar://problem/5241148> REGRESSION: ActivEdit can't perform operations on certain selections

Return valid equivalents from these methods (no [img, 1] for
example). ActivEdit was using positions returned from these
methods to create new DOM Ranges.

editing/SelectionController.cpp: (WebCore::SelectionController::baseNode): (WebCore::SelectionController::baseOffset): (WebCore::SelectionController::extentNode): (WebCore::SelectionController::extentOffset): (WebCore::SelectionController::anchorNode): (WebCore::SelectionController::anchorOffset): (WebCore::SelectionController::focusNode): (WebCore::SelectionController::focusOffset):
editing/SelectionController.h:

9:17 AM BuildingQtOnLinux edited by bero@arklinux.org

Add gcc 4.2 incompatibility workaround (diff)

6:41 AM Changeset in webkit [21967] by rwlbuis

2 edits in trunk/WebCore

Fix the svg experimental build.

5:15 AM BuildingQtOnLinux edited by bero@arklinux.org

Add qmake build dependency and note about having qmake in the PATH (diff)

5:01 AM BuildingQtOnLinux edited by bero@arklinux.org

Add flex to list of build deps (diff)

4:51 AM BuildingQtOnLinux edited by bero@arklinux.org

update headline to reflect the fact that Ark instructions are included (diff)

3:43 AM BuildingQtOnLinux edited by bero@arklinux.org

Add Ark Linux build instructions where they differ from *ubuntu's … (diff)

2:41 AM Changeset in webkit [21966] by bdash

86 edits
428 adds in trunk/WebKitSite

2007-05-04 Mark Rowe <mrowe@apple.com>

Upgrade to WordPress 2.2. I didn't go to the effort of tracking down files
present in the old version which have since been removed, but it's unlikely
they'll ever cause a problem.

1:30 AM Changeset in webkit [21965] by bdash

1 edit
11 adds in trunk/WebKitSite

2007-05-04 Mark Rowe <mrowe@apple.com>

Add graphics used by existing blog posts into SVN.

blog/wp-content/rotate.png: Added.
blog/wp-content/drosera.png: Added.
blog/wp-content/hitlist.png: Added.
blog/wp-content/svgtextmini.png: Added.
blog/wp-content/svgtextmini_01.png: Added.
blog/wp-content/textfield_screenshot.jpg: Added.
blog/wp-content/Picture9.png: Added.
blog/wp-content/svgtext.png: Added.
blog/wp-content/webInspector.png: Added.
blog/wp-content/rotate.svg: Added.
blog/wp-content/chucknorris.png: Added.

1:04 AM Changeset in webkit [21964] by rwlbuis

3 edits
4 adds in trunk

Reviewed by Hyatt.

http://bugs.webkit.org/show_bug.cgi?id=6170
CSS1: Properties for :first-letter aren't recalculated on color change

Mark styles with first-letter as unique.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed