Timeline

Jun 15, 2007:

8:14 PM Changeset in webkit [23558] by hyatt

• 4 edits in trunk/WebCore

Fix for bugzilla bugs 14183 and 14184, 'repeat' regressed in border-image
because of a botched 'round' support removal. Also update for a change in
the spec that has the second stretch/round/repeat keyword match the first
if omitted.

Reviewed by olliej

• css/cssparser.cpp: (WebCore::BorderImageParseContext::commitBorderImage):
• platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
• platform/graphics/Image.h: (WebCore::Image::):

6:47 PM Changeset in webkit [23557] by weinig

• 22 edits
  1 move in trunk

LayoutTests:

Reviewed by Darin.

Update test for ​http://bugs.webkit.org/show_bug.cgi?id=14053
Autogenerate JS binding for Rect

• fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=14053
Autogenerate JS binding for Rect

• Renames RectImpl to Rect, DOMStyleSheetList to JSStyleSheetList and DOMRGBColor to JSRGBColor
• Moves JSStyleSheetList and JSRGBColor into the WebCore namespace.

• DerivedSources.make:
• WebCore.pro:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/kjs_css.cpp: (WebCore::): (WebCore::JSStyleSheetList::JSStyleSheetList): (WebCore::JSStyleSheetList::~JSStyleSheetList): (WebCore::JSStyleSheetList::getValueProperty): (WebCore::JSStyleSheetList::indexGetter): (WebCore::JSStyleSheetList::nameGetter): (WebCore::JSStyleSheetList::getOwnPropertySlot): (WebCore::toJS): (WebCore::JSStyleSheetListFunc::callAsFunction): (WebCore::JSRGBColor::JSRGBColor): (WebCore::JSRGBColor::~JSRGBColor): (WebCore::JSRGBColor::getOwnPropertySlot): (WebCore::JSRGBColor::getValueProperty): (WebCore::getJSRGBColor):
• bindings/js/kjs_css.h: (WebCore::JSStyleSheetList::classInfo): (WebCore::JSStyleSheetList::): (WebCore::JSStyleSheetList::impl): (WebCore::JSRGBColor::classInfo): (WebCore::JSRGBColor::): (WebCore::JSRGBColor::impl):
• bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
• bindings/scripts/CodeGeneratorJS.pm:
• bindings/scripts/CodeGeneratorObjC.pm:
• css/CSSBorderImageValue.cpp: (WebCore::CSSBorderImageValue::CSSBorderImageValue):
• css/CSSBorderImageValue.h:
• css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::cssText):
• css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::getRectValue): (WebCore::CSSPrimitiveValue::):
• css/DashboardRegion.h:
• css/Rect.h: Copied from css/RectImpl.h. (WebCore::Rect::~Rect): (WebCore::Rect::top): (WebCore::Rect::right): (WebCore::Rect::bottom): (WebCore::Rect::left): (WebCore::Rect::setTop): (WebCore::Rect::setRight): (WebCore::Rect::setBottom): (WebCore::Rect::setLeft):
• css/Rect.idl:
• css/RectImpl.h: Removed.
• css/cssparser.cpp: (WebCore::CSSParser::parseShape): (WebCore::BorderImageParseContext::commitBorderImage):
• css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
• page/DOMWindow.idl:

WebKit:

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=14053
Autogenerate JS binding for Rect

• Fix conflicts by using ::Rect instead of Rect.

• Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView sendEvent:]): (-[WebBaseNetscapePluginView tellQuickTimeToChill]): (-[WebBaseNetscapePluginView invalidateRegion:]): (-[WebBaseNetscapePluginView _printedPluginBitmap]):

5:53 PM Changeset in webkit [23556] by kevino

• 1 edit in branches/wx-port-alpha/trunk/WebKitTools/Scripts/build-wxwebkit

Allow users to specify whether they're using a debug or wxPython build of wx.

5:29 PM Changeset in webkit [23555] by kevino

• 5 edits in branches/wx-port-alpha/trunk

Fix for cases where the wxpresets don't define WX_PYTHON, and only have the webcore and jscore templates include flags. (these are not linked to directly by wx clients)

4:21 PM Changeset in webkit [23554] by zimmermann

• 19 edits
  9 adds in branches/feature-branch

Reviewed by Eric.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=14015 (SVGTransformList::initialize() has no effect)

Fix SVGTransformList usage in SVG DOM exposed to JS.
This also fixes SVG space invaders including most repainting issues. (still some unrelated ones left)

This is basically the _same_ fix applied to SVGPointList some months ago. We just forgot
to add JSSVGTransformListCustom when switching from SVGTransform* -> SVGTransform (POD type).

3:07 PM Changeset in webkit [23553] by andersca

• 2 edits in trunk/WebKit

Reviewed by Kevin.

A better fix for <rdar://problem/5271774>. Only try to access the element if the
view has an associated window. This also works with GC. (Fix suggested by Kevin.)

• Plugins/WebKitPluginContainerView.mm: (-[WebKitPluginContainerView dealloc]): (-[WebKitPluginContainerView visibleRect]):

2:17 PM Changeset in webkit [23552] by andersca

• 2 edits in trunk/WebKit

Reviewed by Kevin.

<rdar://problem/5271774> REGRESSION: A crash occurs when closing a window that contains a QT movie

In some cases, calling [super dealloc] might end up calling visibleRect, so make sure to
set _element to 0 so we won't send a message to a freed object and crash.

• Plugins/WebKitPluginContainerView.mm: (-[WebKitPluginContainerView dealloc]): (-[WebKitPluginContainerView visibleRect]):

12:21 PM Changeset in webkit [23551] by zimmermann

• 4 edits
  4 adds in branches/feature-branch

Reviewed by Eric.
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=14155

JSSVGMatrix was not working properly.
"matrix.translate(10, 10)" actually altered 'matrix' instead of returning a
new SVGMatrix object, as described in SVG 1.1 specification.

10:32 AM Changeset in webkit [23550] by spadma

• 2 edits in S60/trunk/WebKit

vbradley, reviewed by Sachin

DESC: EYLG-6ZVCLT - Chinese candidate and autofill boxes overlap
​http://bugs.webkit.org/show_bug.cgi?id=13925

• BrowserView/src/WebKitControl.cpp: (CStaticObjectContainer::FormDataManagerHandlerL):

10:27 AM Changeset in webkit [23549] by spadma

• 2 edits in S60/branches/3.1m/WebKit

2007-06-14 Mahesh Kulkarni <​mahesh.kulkarni@nokia.com>

Reviewed by Sachin Padma.
DESC: Plug-in request for execution of JavaScript through NpnGetUrl API not working
​http://waplabdc.nokia-boston.com/browser/users/MaheshKK/geturl.html

• WebKit\Plugin\PluginLoader.cpp: (CPluginLoader::LoadPluginContentL): Do not resolve URL when "javascript:" is in the URL

10:25 AM Changeset in webkit [23548] by spadma

• 2 edits in S60/trunk/WebKit

007-06-14 Mahesh Kulkarni <​mahesh.kulkarni@nokia.com>

Reviewed by Sachin Padma.
DESC: Plug-in request for execution of JavaScript through NpnGetUrl API not working
​http://waplabdc.nokia-boston.com/browser/users/MaheshKK/geturl.html

• WebKit\Plugin\PluginLoader.cpp: (CPluginLoader::LoadPluginContentL): Do not resolve URL when "javascript:" is in the URL

9:54 AM Changeset in webkit [23547] by eseidel

• 2 edits in branches/feature-branch/WebCore

2007-06-15 Eric Seidel <​eric@webkit.org>

Reviewed by Niko.

Fix the release build.

• rendering/SVGRootInlineBox.cpp: (WebCore::applyTextAnchorToTextChunk):

Jun 14, 2007:

7:51 PM Changeset in webkit [23546] by staikos

• 3 edits in trunk/WebKitQt

Add evaluateJavaScript() method

7:31 PM Changeset in webkit [23545] by staikos

• 7 edits in trunk

Add quite a bit of keyboard handling in editing and non-editing mode for
QtWebKit, as well as some focus fixes.

6:41 PM Changeset in webkit [23544] by rwlbuis

• 3 edits
  4 adds in branches/feature-branch

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=14051
<svg:image> fails to position correctly when <svg> is inside an inline <div>

Leave parent translation to the containers.

5:02 PM Changeset in webkit [23543] by zimmermann

• 5 edits in branches/feature-branch/WebCore

Reviewed by Eric.
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=13963

Fix SVG space invaders. It actually highlighted a bad problem with our JSSVGPODTypeWrapper's.
Introduce a new "2nd-level cache" for all readwrite POD properties. Subsequent calls to ie.
myRect.x.baseVal.value don't create a new wrapper everytime, but are properly cached now.
This leads to a massive reduction in created wrappers.

4:50 PM Changeset in webkit [23542] by thatcher

• 12 edits
  4 copies in branches/Safari-522

Merge r21212.

4:39 PM Changeset in webkit [23541] by thatcher

• 2 edits in branches/Safari-522/WebCore

Merge r20855.

3:15 PM Changeset in webkit [23540] by andersca

• 2 edits in trunk/JavaScriptCore

Fix Windows build.

• bindings/runtime_object.cpp: (RuntimeObjectImp::canPut):

2:58 PM Changeset in webkit [23539] by hyatt

• 3 edits in trunk/WebCore

Fix for missing text in non-English Windows installs.

2:43 PM Changeset in webkit [23538] by andersca

• 14 edits
  2 adds in trunk

JavaScriptCore:

Reviewed by Darin.

<rdar://problem/5103077>
Crash at _NPN_ReleaseObject when quitting page at ​http://eshop.macsales.com/shop/ModBook

<rdar://problem/5183692>
​http://bugs.webkit.org/show_bug.cgi?id=13547
REGRESSION: Crash in _NPN_ReleaseObject when closing Safari on nba.com (13547)

<rdar://problem/5261499>
CrashTracer: [USER] 75 crashes in Safari at com.apple.JavaScriptCore: KJS::Bindings::CInstance::~CInstance + 40

Have the root object track all live instances of RuntimeObjectImp. When invalidating
the root object, also invalidate all live runtime objects by zeroing out their instance ivar.
This prevents instances from outliving their plug-ins which lead to crashes.

• bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant):
• bindings/jni/jni_jsobject.cpp: (JavaJSObject::convertValueToJObject):
• bindings/jni/jni_utility.cpp: (KJS::Bindings::convertValueToJValue):
• bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::callAsFunction):
• bindings/runtime_array.cpp: (RuntimeArray::RuntimeArray):
• bindings/runtime_array.h: (KJS::RuntimeArray::getConcreteArray):
• bindings/runtime_method.cpp: (RuntimeMethod::callAsFunction):
• bindings/runtime_method.h:
• bindings/runtime_object.cpp: (RuntimeObjectImp::RuntimeObjectImp): (RuntimeObjectImp::~RuntimeObjectImp): (RuntimeObjectImp::invalidate): (RuntimeObjectImp::fallbackObjectGetter): (RuntimeObjectImp::fieldGetter): (RuntimeObjectImp::methodGetter): (RuntimeObjectImp::getOwnPropertySlot): (RuntimeObjectImp::put): (RuntimeObjectImp::canPut): (RuntimeObjectImp::defaultValue): (RuntimeObjectImp::implementsCall): (RuntimeObjectImp::callAsFunction): (RuntimeObjectImp::getPropertyNames): (RuntimeObjectImp::throwInvalidAccessError):
• bindings/runtime_object.h:
• bindings/runtime_root.cpp: (KJS::Bindings::RootObject::invalidate): (KJS::Bindings::RootObject::addRuntimeObject): (KJS::Bindings::RootObject::removeRuntimeObject):
• bindings/runtime_root.h:

LayoutTests:

Reviewed by Darin.

Add test that manipulates plug-in script objects after the plug-in has been destroyed.

• plugins/netscape-destroy-plugin-script-objects-expected.txt: Added.
• plugins/netscape-destroy-plugin-script-objects.html: Added.

2:42 PM Changeset in webkit [23537] by weinig

• 3 edits in trunk/WebKitTools

Reviewed by Brady.

Update set of files to download for cygwin to include
diffutils and regenerate the zip file. This should fix
an issue on vista where svn-create-patch doesn't work.

• CygwinDownloader/cygwin-downloader.py:
• CygwinDownloader/cygwin-downloader.zip:

2:08 PM Changeset in webkit [23536] by andersca

• 4 edits in trunk/WebCore

Reviewed by Geoff.

Add Frame::cleanupScriptObjectsForPlugin which will invalidate the root object
for a given plug-in.

• WebCore.exp:
• page/Frame.cpp: (WebCore::Frame::cleanupScriptObjectsForPlugin):
• page/Frame.h:

2:06 PM Changeset in webkit [23535] by andersca

• 4 edits in trunk/WebKit

Reviewed by Geoff.

Call cleanupScriptObjectsForPlugin on the frame after destroying the plug-in.

• Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView _destroyPlugin]):
• Plugins/WebPluginController.mm: (-[WebPluginController destroyPlugin:]): (-[WebPluginController destroyAllPlugins]):

1:02 PM Changeset in webkit [23534] by kdecker

• 2 edits in branches/Safari-2-0-branch/WebKit

Reviewed by John and Darin and Anders!

Fixed: <rdar://problem/5269008> REGRESSION (Safari 3 Beta 1): Package Tracker widget fails (can't find localized strings due to bundle ID)

• Misc.subproj/WebLocalizableStrings.m: The problem was that WebLocalizableStrings.m has the system WebKit bundle identifier, not WebKitForDashboard's bundle identifier. The code therefore couldn't find the localizable string "Recent searches", thus returned a nil string and therefore triggered an assertion failure in NSMenuItem. I fixed this by changing the bundle constant to "com.apple.WebKitForDashboard".

12:22 PM Changeset in webkit [23533] by eseidel

• 4 edits in branches/feature-branch/WebCore

2007-06-14 Eric Seidel <​eric@webkit.org>

Reviewed by Niko.

Text gradients are broken on feature branch
​http://bugs.webkit.org/show_bug.cgi?id=14142

• rendering/SVGRenderSupport.cpp: (WebCore::prepareToRenderSVGContent):
• rendering/SVGRootInlineBox.cpp: (WebCore::prepareTextRendering): (WebCore::SVGRootInlineBox::paint): (WebCore::SVGRootInlineBox::paintInlineBoxes): (WebCore::SVGRootInlineBox::paintChildInlineTextBox): (WebCore::SVGRootInlineBox::paintChildInlineFlowBox):
• rendering/SVGRootInlineBox.h:

12:16 PM Changeset in webkit [23532] by zimmermann

• 2 edits in branches/feature-branch/WebCore

Reviewed by Sam.
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11273

Implement pixelUnitToMillimeterX(), pixelUnitToMillimeterY() in SVGSVGElement.
Use cssPixelsPerInch, just like done in CSSPrimitiveValue & SVGLength.

11:43 AM Applications using WebKit edited by ruben@mailplaneapp.com

Added Mailplane (diff)

11:33 AM Changeset in webkit [23531] by bdash

• 2 edits in trunk/WebKitTools

2007-06-14 Mark Rowe <​mrowe@apple.com>

Update script to match new nightly.webkit.org infrastructure.

• BuildSlaveSupport/build-launcher-dmg: Upload to the live web server, not the caching proxy. Let the server know it's a Mac build.

10:50 AM Changeset in webkit [23530] by rwlbuis

• 3 edits
  4 adds in branches/feature-branch

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=9752
%-sizing of elements with a html parent is broken

Calculate width/height for length percentages when embedded in xhtml.

10:21 AM Changeset in webkit [23529] by andersca

• 3 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/5211677>
-[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>

• loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): If the object is a Java MIME type and Java is disabled, don't load the plug-in.

• platform/MimeTypeRegistry.cpp: (WebCore::MimeTypeRegistry::isJavaAppletMIMEType): Clean this up and add another applet MIME type.

10:13 AM Changeset in webkit [23528] by staikos

• 8 edits in trunk

Implement the javascript dialogs and file chooser dialog, along with some
cleanups.

9:47 AM Changeset in webkit [23527] by staikos

• 2 edits in trunk/WebCore

Add missing null-init of pointer (will fix an upcoming crash)

9:13 AM Changeset in webkit [23526] by andersca

• 5 edits in trunk

JavaScriptCore:

Reviewed by Mitz.

<rdar://problem/5244948>
Safari keeps on complaining about slow script playing NBC TV video (14133)

​http://bugs.webkit.org/show_bug.cgi?id=14133
Runaway JavaScript timer fires when spinning around in Google Maps street view

Make sure to start and stop the timeout checker around calls to JS.

• bindings/NP_jsobject.cpp: (_NPN_InvokeDefault): (_NPN_Invoke): (_NPN_Evaluate):
• bindings/jni/jni_jsobject.cpp: (JavaJSObject::call): (JavaJSObject::eval):

WebCore:

Reviewed by Mitz.

<rdar://problem/5244948>
Safari keeps on complaining about slow script playing NBC TV video (14133)

​http://bugs.webkit.org/show_bug.cgi?id=14133
Runaway JavaScript timer fires when spinning around in Google Maps street view

Make sure to start and stop the timeout checker around calls to JS.

• bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]):

4:41 AM Changeset in webkit [23525] by hausmann

• 2 edits in trunk/WebKitQt

Removed QWebHistoryItem::parent() as it is not implemented and WebCore's

HistoryItem itself doesn't seem to have a parent pointer either.

4:40 AM Changeset in webkit [23524] by hausmann

• 3 edits in trunk/WebKitQt

Make it possible to copy QWebHistoryItem objects.