Context Navigation

← Previous Period
Next Period →

Timeline

Jun 18, 2007:

9:56 PM Changeset in webkit [23582] by kdecker

2 edits in trunk/WebKit

Reviewed by Kevin Decker

Carbon/HIWebView.m: (WindowHandler): HIObjectIsOfClass requires non-NULL input on Tiger. Reworked Kevin Decker's patch to remove the conditional compilation for Tiger, yet still avoid crashing BBEdit.

7:12 PM Changeset in webkit [23581] by weinig

2 edits in trunk/WebCore

Qt build fix.

platform/qt/PlatformScreenQt.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):

7:05 PM Changeset in webkit [23580] by andersca

2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Kevin McCullough.

Merged fix from TOT to Safari-2-0-branch

2007-06-05 Anders Carlsson <andersca@apple.com>

Reviewed by Geoff.

<rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
<rdar://problem/5246208> HTTP injection in XMLHttpRequest.open method parameter
<rdar://problem/5246242> HTTP header injection in HXMLHttpRequest.setRequestHeader header parameter

Check method names, header names and header values and throw exceptions if any of them are
invalid. This is what the new XMLHttpRequest spec states that we should do.

khtml/ecma/xmlhttprequest.cpp: (KJS::isValidToken): (KJS::isValidHeaderValue): (KJS::XMLHttpRequestProtoFunc::tryCall):

7:03 PM Changeset in webkit [23579] by weinig

10 edits in trunk

WebCore:

Reviewed by Beth.

Fix build and update licenses.

WebCore.xcodeproj/project.pbxproj:
page/BarInfo.cpp:
page/BarInfo.h:
page/BarInfo.idl:
page/Screen.cpp: (WebCore::Screen::height): (WebCore::Screen::width): (WebCore::Screen::colorDepth): (WebCore::Screen::pixelDepth): (WebCore::Screen::availLeft): (WebCore::Screen::availTop): (WebCore::Screen::availHeight): (WebCore::Screen::availWidth):
page/Screen.h:
page/Screen.idl:

WebKit:

Reviewed by Beth.

Build fix.

WebCoreSupport/WebChromeClient.mm:

6:30 PM Changeset in webkit [23578] by kdecker

2 edits in trunk/WebKit

2007-06-18 Kevin Decker <kdecker@apple.com>

Carbon/HIWebView.m: (WindowHandler): Fixed the Tiger build; ControlKind wasn't defined.

6:14 PM Changeset in webkit [23577] by andersca

6 edits in trunk

LayoutTests:

Reviewed by John Sullivan.

Update result, we shouldn't call didFinishLoadForFrame if the URL isn't valid.

http/tests/loading/bad-scheme-subframe-expected.txt:

WebCore:

Reviewed by John Sullivan.

<rdar://problem/5277008> Assertion in [LocationChangeHandler finishedLoadingFrame:]

Don't send any frame load callbacks if the document load hasn't been
committed for real.

loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame):

WebKitTools:

Reviewed by John Sullivan.

Assert that the frame has a dataSource.

DumpRenderTree/FrameLoadDelegate.m: (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):

5:08 PM Changeset in webkit [23576] by weinig

18 edits
4 moves
4 adds in trunk

LayoutTests:

Reviewed by Geoff.

Updates tests for http://bugs.webkit.org/show_bug.cgi?id=14193
Move the Screen object out of the JS bindings

fast/dom/Window/window-appendages-cleared-expected.txt:
fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Geoff.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14193
Move the Screen object out of the JS bindings

Renames Screen.h to PlatformScreen.h to accommodate new class.
Autogenerates JSScreen.

DerivedSources.make:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::Window::mark): (KJS::Window::getValueProperty): (KJS::Window::clearHelperObjectProperties):
bindings/js/kjs_window.h: (KJS::Window::):
css/MediaQueryEvaluator.cpp:
page/DOMWindow.cpp: (WebCore::DOMWindow::DOMWindow): (WebCore::DOMWindow::~DOMWindow): (WebCore::DOMWindow::frame): (WebCore::DOMWindow::disconnectFrame): (WebCore::DOMWindow::screen):
page/DOMWindow.h:
page/DOMWindow.idl:
page/Screen.cpp: Added. (WebCore::Screen::Screen): (WebCore::Screen::disconnectFrame): (WebCore::Screen::height): (WebCore::Screen::width): (WebCore::Screen::colorDepth): (WebCore::Screen::pixelDepth): (WebCore::Screen::availLeft): (WebCore::Screen::availTop): (WebCore::Screen::availHeight): (WebCore::Screen::availWidth):
page/Screen.h: Added.
page/Screen.idl: Added.
page/mac/WebCoreFrameBridge.mm:
platform/PlatformScreen.h: Copied from WebCore/platform/Screen.h.
platform/Screen.h: Removed.
platform/gdk/PlatformScreenGdk.cpp: Copied from WebCore/platform/gdk/ScreenGdk.cpp.
platform/gdk/ScreenGdk.cpp: Removed.
platform/mac/PlatformMouseEventMac.mm:
platform/mac/PlatformScreenMac.mm: Copied from WebCore/platform/mac/ScreenMac.mm.
platform/mac/ScreenMac.mm: Removed.
platform/qt/PlatformScreenQt.cpp: Added. (WebCore::WebCore::screenDepth): (WebCore::WebCore::screenDepthPerComponent): (WebCore::WebCore::screenIsMonochrome): (WebCore::WebCore::screenRect): (WebCore::WebCore::screenAvailableRect):
platform/qt/TemporaryLinkStubs.cpp:
platform/win/PlatformScreenWin.cpp: Copied from WebCore/platform/win/ScreenWin.cpp.
platform/win/ScreenWin.cpp: Removed.
rendering/RenderObject.cpp:

5:06 PM Changeset in webkit [23575] by thatcher

2 edits in branches/Safari-522/WebKit

Merge r23574.

5:01 PM Changeset in webkit [23574] by kdecker

2 edits in trunk/WebKit

Reviewed by Tim Hatcher.

Fixed: <rdar://problem/5276135> With Safari 3 Tiger Beta installed, a crash occurs in BBEdit while mousing down and dragging outside of HTML preview window

Carbon/HIWebView.m: (WindowHandler): Because the fix for 5051616 causes Tiger to crash in HIToolbox (but not on Leopard), I reverted back to using GetControlKind on Tiger only, instead of HIObjectIsOfClass.

4:04 PM Changeset in webkit [23573] by weinig

10 edits
3 adds in trunk/WebCore

Reviewed by Geoff.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14211
Move the BarInfo object out of the JS bindings

DerivedSources.make:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::Window::mark): (KJS::Window::getValueProperty): (KJS::Window::clearHelperObjectProperties): (KJS::Window::disconnectFrame):
bindings/js/kjs_window.h: (KJS::Window::):
page/BarInfo.cpp: Added. (WebCore::BarInfo::BarInfo): (WebCore::BarInfo::disconnectFrame): (WebCore::BarInfo::visible):
page/BarInfo.h: Added. (WebCore::BarInfo::):
page/BarInfo.idl: Added.
page/DOMWindow.cpp: (WebCore::DOMWindow::~DOMWindow): (WebCore::DOMWindow::disconnectFrame): (WebCore::DOMWindow::locationbar): (WebCore::DOMWindow::menubar): (WebCore::DOMWindow::personalbar): (WebCore::DOMWindow::scrollbars): (WebCore::DOMWindow::statusbar): (WebCore::DOMWindow::toolbar):
page/DOMWindow.h:
page/DOMWindow.idl:

3:52 PM Changeset in webkit [23572] by thatcher

4 edits
4 copies in branches/Safari-522

Merge r21602.

3:45 PM Changeset in webkit [23571] by thatcher

5 edits in branches/Safari-522

Merge r21529.

3:04 PM Changeset in webkit [23570] by staikos

2 edits in trunk/WebKitTools

Reflect the library name change for WebKitQt in the perl scripts. Patch from
Adam Treat

1:11 PM Changeset in webkit [23569] by hyatt

2 edits in trunk/WebKit/win

Groundwork for Ctrl+Enter URL bar support.

10:27 AM Changeset in webkit [23568] by andersca

7 edits in branches/Safari-522

Merge 21104, 21254 and 21776.

10:15 AM Changeset in webkit [23567] by weinig

10 edits in trunk

LayoutTests:

Reviewed by Darin.

Update tests now that window.frames points to window and not FrameArray
(which has been removed).

fast/dom/Window/resources/window-appendages-cleared-results.html:
fast/dom/Window/window-appendages-cleared-expected.txt:
fast/dom/Window/window-appendages-cleared.html:
fast/dom/Window/window-properties-expected.txt:
fast/js/toString-and-valueOf-override-expected.txt:
fast/js/toString-and-valueOf-override.html:

WebCore:

Reviewed by Darin.

Remove the FrameArray class and instead make window.frames another
self-reference for window (like window.window, window.self, etc).
This is what Firefox and what the HTML5 dictates.

bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::Window::mark): (KJS::Window::getValueProperty): (KJS::Window::clearHelperObjectProperties): (KJS::Window::disconnectFrame):
bindings/js/kjs_window.h:

9:58 AM Changeset in webkit [23566] by bdash

3 edits in trunk/WebKitTools

2007-06-18 Jake Helfert <jake@jakeonthenet.com>

Reviewed by Adam.

fix http://bugs.webkit.org/show_bug.cgi?id=14154 Spinneret doesn't build against the new Win32 port.

Spinneret/Spinneret/Spinneret.cpp: (_tWinMain):

-Changed IWebViewExt to IWebViewPrivate
-Changed Co[Un]initialize to Ole[Un]initialize because WebKit now calls

the WIN32 function RegisterDragDrop which requires the Ole* calls.

Spinneret/Spinneret/Spinneret.h: (SpinneretWebHost::didReceiveIcon): Updated method signature. (SpinneretWebHost::willPerformClientRedirectToURL): Updated method signature. (SpinneretWebHost::windowScriptObjectAvailable): Updated method signature.

9:55 AM Changeset in webkit [23565] by bdash