Timeline
Jun 23, 2007:
- 5:37 PM Changeset in webkit [23751] by
-
- 2 edits in trunk/WebKitSite
2007-06-23 Mark Rowe <mrowe@apple.com>
Not reviewed.
- building/checkout.html: Update link to bypass caching proxy as it has a habit of breaking huge downloads.
- 12:23 PM Changeset in webkit [23750] by
-
- 2 edits in trunk/LayoutTests
Uploading the correct expected results -- the ones checked in expected
an "unkown" callback, which was incorrect behavior.
- fast/loader/user-style-sheet-resource-load-callbacks-expected.txt:
- 11:35 AM Changeset in webkit [23749] by
-
- 3 edits1 add in trunk
Fix the "num-cpus not found" warning the Windows WebCore build emits
WebCore:
Silence a build warning about not finding
num-cpus
Reviewed by Mark Rowe.
- WebCore.vcproj/build-generated-files.sh: Look for num-cpus in its new location.
WebKitTools:
Land num-cpus for the Windows build.
Reviewed by Mark Rowe.
- Scripts/num-cpus: Added.
- 1:49 AM Changeset in webkit [23748] by
-
- 2 edits in trunk/WebKitTools
Added support for populating ChangeLog entries from given git commits
using --git-commit=<commitish> and --git-reviewer=<name>.
Jun 22, 2007:
- 4:06 PM Changeset in webkit [23747] by
-
- 2 edits in trunk/WebKit
Reviewed by Geoff and Darin.
Fix for: <rdar://problem/5239236> Other slash characters should not be permitted as part of a domain name
- Misc/WebNSURLExtras.m: (isSlashOrPeriodLookalike): (allCharactersInIDNScriptWhiteList):
- 3:19 PM Changeset in webkit [23746] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
- plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::didFinishLoading): No need to fetch the size from resourceData.
- 3:16 PM Changeset in webkit [23745] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin.
<rdar://problem/5288617>
Crash playing a very large QuickTime movie inside Safari.
Get rid of m_completeDeliveryData and use the loader's resource data instead. This reduces the memory usage for
plug-ins which loads large files and use a transfer mode of NP_ASFILE or NP_ASFILEONLY.
- plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::~PluginStreamWin): (WebCore::PluginStreamWin::didReceiveData): (WebCore::PluginStreamWin::didFinishLoading):
- plugins/win/PluginStreamWin.h:
- 3:03 PM Changeset in webkit [23744] by
-
- 6 edits4 adds in trunk
LayoutTests:
Reviewed by Oliver and Darin.
Tests for <rdar://problem/5266999> Loading page from MangleMe fuzz
tester crashes in RenderTableRow::addChild (giant ROWSPAN)
The results of this test have changed because we now clamp rowspan
at 8190 to match Firefox.
- fast/table/giantRowspan-expected.checksum:
- fast/table/giantRowspan-expected.png:
- fast/table/giantRowspan-expected.txt:
A new test that crashes our old heuristic for too-large rowspan,
but succeeds with the new one.
- fast/table/giantRowspan2-expected.checksum: Added.
- fast/table/giantRowspan2-expected.png: Added.
- fast/table/giantRowspan2-expected.txt: Added.
- fast/table/giantRowspan2.html: Added.
WebCore:
Reviewed by Oliver and Darin.
Fix for <rdar://problem/5266999> Loading page from MangleMe fuzz
tester crashes in RenderTableRow::addChild (giant ROWSPAN)
We already have code that tries to prevent allocating too-large
rowspans. The rowspan in this test, however, was small enough that
we thought it was okay in that code, even though clearly it was
still too large. I did a bunch of testing in Firefox, and it seems
that they set a hard limit on the maximum rowspan right in the DOM
-- 8k. So that is what this patch implements.
- html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::parseMappedAttribute):
- 2:57 PM Changeset in webkit [23743] by
-
- 4 edits4 adds in trunk
LayoutTests:
Reviewed by Darin.
<rdar://problem/5272440> Adding To Do via Note received in e-mail adds newlines when pressing return
Demonstrates bug:
- editing/deleting/5272440-expected.checksum: Added.
- editing/deleting/5272440-expected.png: Added.
- editing/deleting/5272440-expected.txt: Added.
- editing/deleting/5272440.html: Added.
upstream() now works for the positions visually equivalent to [span, 0]
where span is an inline root editable element:
- editing/deleting/delete-mixed-editable-content-001-expected.txt:
WebCore:
Reviewed by Darin.
<rdar://problem/5272440> Adding To Do via Note received in e-mail adds newlines on delete
Deletion inserts a placeholder after it removes full paragraphs if
one doesn't already exist. The code that looked for a pre-existing
placeholder didn't work because of a bug in enclosingNodeOfType.
- editing/htmlediting.cpp: (WebCore::enclosingNodeOfType): We start looking at node->parentNode(), but don't go above an editing root.
- 12:47 PM Changeset in webkit [23742] by
-
- 1 edit1 add in trunk/LayoutTests
Add result.
- fast/loader/user-style-sheet-resource-load-callbacks-expected.txt: Added.
- 12:04 PM Changeset in webkit [23741] by
-
- 20 edits2 adds in trunk
LayoutTests:
Reviewed by Geoff.
<rdar://problem/5244734>
WebKit shouldn't send delegate resource load methods for the user stylesheet (doing so causes assertions in Safari)
- fast/loader/resources/user-style-sheet.css: Added.
- fast/loader/user-style-sheet-resource-load-callbacks.html: Added.
WebCore:
Reviewed by Maciej and Geoff.
<rdar://problem/5244734>
WebKit shouldn't send delegate resource load methods for the user stylesheet (doing so causes assertions in Safari)
Add a sendResourceLoadCallbacks argument to the ResourceLoader and only send resource load callbacks if it's true. Make it so that
loading the user style sheet creates a resource loader with sendResourceLoadCallbacks set to false (done by adding a sendResourceLoadCallbacks
argument to a bunch of classes).
- loader/Cache.cpp: (WebCore::createResource): (WebCore::Cache::requestResource):
- loader/Cache.h:
- loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
- loader/CachedCSSStyleSheet.h:
- loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource):
- loader/CachedResource.h: (WebCore::CachedResource::sendResourceLoadCallbacks):
- loader/DocLoader.cpp: (WebCore::DocLoader::requestCSSStyleSheet): (WebCore::DocLoader::requestResource): (WebCore::DocLoader::checkCacheObjectStatus):
- loader/DocLoader.h:
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::MainResourceLoader):
- loader/Request.cpp: (WebCore::Request::Request):
- loader/Request.h: (WebCore::Request::sendResourceLoadCallbacks):
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didReceiveData): (WebCore::ResourceLoader::didFinishLoadingOnePart): (WebCore::ResourceLoader::didFail): (WebCore::ResourceLoader::didCancel):
- loader/ResourceLoader.h: (WebCore::ResourceLoader::sendResourceLoadCallbacks):
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::create):
- loader/SubresourceLoader.h:
- loader/loader.cpp: (WebCore::Loader::load): (WebCore::Loader::servePendingRequests):
- loader/loader.h:
- loader/mac/NetscapePlugInStreamLoaderMac.mm: (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
- 11:27 AM Changeset in webkit [23740] by
-
- 6 edits in trunk
LayoutTests:
Reviewed by Anders.
<rdar://problem/5228168> Leopard regression test failures: fast/applescript
New results to match the DumpRenderTree changes.
- fast/AppleScript/001-expected.txt:
- fast/AppleScript/array-expected.txt:
- fast/AppleScript/date-expected.txt:
WebKitTools:
Reviewed by Anders.
<rdar://problem/5228168> Leopard regression test failures: fast/applescript
There were some changes in Leopard that made our test output inconsistent with Tiger.
NSAppleEventDescriptor no longer returns a stringValue for typeType descriptors
on Leopard, so output our own readable string for typeType descriptors.
NSArray's description also changed on Leopard to output more whitespace, so
make our own string representation for typeAEList descriptors. This requires
a special case typeUnicodeText too, so the output is a quoted string.
- DumpRenderTree/AppleScriptController.m: (convertAEDescToObject):
- 10:28 AM Changeset in webkit [23739] by
-
- 2 edits in S60/branches/3.1m/WebCore
2007-06-21 w3liu <wei.liu@nokia.com>
Reviewed by yongjun.zhang@nokia.com.
DESC: SCHY-72JNXK: 3.1 Voda: The alt text and broken images are not displayed correctly for IMG element.
http://bugs.webkit.org/show_bug.cgi?id=14243
WARNING: NO TEST CASES ADDED OR CHANGED
- khtml/rendering/render_image.cpp: (RenderImage::setPixmap): (RenderImage::paint):
- 9:56 AM Changeset in webkit [23738] by
-
- 2 edits in trunk/WebCore
Reviewed by Tim Hatcher.
Bug 14305: Web Inspector marks local files with server-side compression tip
http://bugs.webkit.org/show_bug.cgi?id=14305
- page/inspector/Resource.js: (WebInspector.Resource._shouldCompress): Prevent server-side compression tip from being given to local files
- 12:00 AM Changeset in webkit [23737] by
-
- 3 edits2 adds in trunk
2007-06-21 Mark Rowe <mrowe@apple.com>
Reviewed by Darin.
Fix for <rdar://problem/5266928> REGRESSION: crash/assert failure beneath RenderFrameSet::layOutAxis when loading
- platform/StringImpl.cpp: (WebCore::StringImpl::toLengthArray): Simplify whitespace before checking for an empty string. This avoids returning a length of zero when the string is collapsed to empty by whitespace simplification.
2007-06-21 Mark Rowe <mrowe@apple.com>
Reviewed by Darin.
Test for <rdar://problem/5266928> REGRESSION: crash/assert failure beneath RenderFrameSet::layOutAxis when loading
- fast/frames/frame-set-whitespace-attributes-expected.txt: Added.
- fast/frames/frame-set-whitespace-attributes.html: Added.
