⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 28, 2007:

10:49 PM Changeset in webkit [23868] by aroben
  • 7 edits in trunk/WebCore

Get WebCore compiling with /W2 on Windows

Reviewed by Steve.

No regression tests affected.

  • WebCore.vcproj/WebCore.vcproj: Turn the warning level up to 2, and

disable two warnings: implicit int <=> float conversion, and class vs.
struct inconsistency.

  • dom/CharacterData.cpp:

(WebCore::CharacterData::deleteData): Cast to int before negating.

  • loader/Cache.cpp:

(WebCore::Cache::remove): Ditto.

  • platform/graphics/Path.cpp:

(WebCore::pathLengthApplierFunction): Consistently use floats.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawEllipse): Ditto.

  • platform/win/GraphicsContextWin.cpp:

(WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): Ditto.

9:16 PM Changeset in webkit [23867] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.


Fixed <rdar://problem/5299005> DOM timers fire without a local autorelease
pool => pathologically high high water mark


I couldn't measure any performance problems with iBench HTML or PLT.

  • WebCore.xcodeproj/project.pbxproj: Changed .cpp file to be ObjC++.
  • platform/mac/SharedTimerMac.cpp: (WebCore::timerFired): Added autorelease pool.
7:46 PM Changeset in webkit [23866] by weinig
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Beth.

  • fast/dynamic/recursive-layout-expected.txt: Added.
  • fast/dynamic/recursive-layout.html: Added.

WebCore:

Reviewed by Beth.

Test: fast/dynamic/recursive-layout.html

  • page/FrameView.cpp: (WebCore::FrameView::layout): Removed the midLayout guards around the calls to invalidateSelection() and updateWidgetPositions(). Those calls may dirty the layout, but in that case they also update it, so they should be allowed to do it. Added an ASSERT to make sure that when they return, the root is not marked for layout.
6:05 PM Changeset in webkit [23865] by slewis
  • 4 edits in trunk/WebKitTools

Reviewed by Adam,

Allow tests to use pre-built roots instead of building the tests.

  • Scripts/run-javascriptcore-tests: added --root option
  • Scripts/run-webkit-tests: added --root option
  • Scripts/webkitdirs.pm: added support for using a root
5:06 PM Changeset in webkit [23864] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/5287569> WEBVIEW: Creating a webview in IB 3.0 (v2.0) NIB later crashes Interface Builder 2.5.4 on Tiger

Prevent encoding any of the WebView subviews. The subviews are ignored by -[WebView initWithCoder:] and will be recreated.
The Tiger 2.0 code crashed when the WebView released the subviews in initWithCoder:, so now there are no subviews to release.
This never happened before because the Tiger 2.0 code and IB wouldn't encode a WebView that has a WebHTMLView.

  • WebView/WebView.mm: (-[WebView encodeWithCoder:]):
4:02 PM Changeset in webkit [23863] by weinig
  • 3 edits
    4 deletes in trunk

LayoutTests:

Rubberstamped by Adam Roben.

Roll out r23861. It caused the buildbot to fail on intel.

  • http/tests/navigation/goBack-blank-tab-page-expected.txt: Removed.
  • http/tests/navigation/goBack-blank-tab-page.html: Removed.
  • http/tests/navigation/resources/before-go-back.html: Removed.
  • http/tests/navigation/resources/will-go-back.html: Removed.

WebCore:

Rubberstamped by Adam Roben.

Roll out r23861. It caused the buildbot to fail on intel.

  • page/Page.cpp: (WebCore::Page::goToItem):
2:57 PM Changeset in webkit [23862] by antti
  • 3 edits in branches/feature-branch/JavaScriptCore

Reviewed by Maciej.


Use intHash to hash floats and doubles too.

  • ChangeLog:
  • wtf/HashFunctions.h: (WTF::FloatHash::hash): (WTF::FloatHash::equal): (WTF::):
  • wtf/HashTraits.h: (WTF::FloatHashTraits::emptyValue): (WTF::FloatHashTraits::deletedValue): (WTF::):
2:08 PM Changeset in webkit [23861] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Geoff.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=13038

ASSERTION FAILED: item->target().isEmpty()
m_mainFrame->tree()->find(item->target()) == m_mainFrame

Although the test works with the script, it can't detect an eventually
error automatically since the first link must be opened in a new tab with
a _blank target to reproduce the crash. So it should be launched manually
following the steps decribed in there, then it's effective.

  • http/tests/navigation/goBack-blank-tab-page-expected.txt: Added.
  • http/tests/navigation/goBack-blank-tab-page.html: Added.
  • http/tests/navigation/resources/before-go-back.html: Added.
  • http/tests/navigation/resources/will-go-back.html: Added.

WebCore:

Reviewed by Geoff.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=13038

ASSERTION FAILED: item->target().isEmpty()
m_mainFrame->tree()->find(item->target()) == m_mainFrame

Modification of an ASSERT on goToItem related to go back/forward in
history.Don't need to check the frameset if the target is _blank.

  • page/Page.cpp: (WebCore::Page::goToItem):
1:16 PM Changeset in webkit [23860] by andersca
  • 1 edit in trunk/LayoutTests/ChangeLog

Tabs are bad

1:13 PM Changeset in webkit [23859] by andersca
  • 2 edits in trunk/LayoutTests

Remove tests that don't need to be skipped anymore.

  • win/Skipped:
1:05 PM Changeset in webkit [23858] by spadma
  • 2 edits in S60/trunk/WebKit

ligman, reviewed by <reviewer>

DESC: The pluginloader does not handle top level loads correctly when the plugin is in an iframe. Always load page from the MainFrame.
​http://bugs.webkit.org/show_bug.cgi?id=14447

  • Plugin/src/PluginLoader.cpp: (CPluginLoader::LoadPluginContentL):
12:46 PM Changeset in webkit [23857] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

<rdar://problem/5234139>
<object> with PNG src rendered as image document.


Complete the URL before passing it to the frame loader client.


  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::isImageType):
11:48 AM Changeset in webkit [23856] by spadma
  • 7 edits in S60/trunk

2007-06-27 Prashanth Narayanaswamy <​prashanth.narayanaswamy@nokia.com>

Reviewed by Sachin Padma.
DESC: SKWK-745NC7 - On going download files from Browser can be seen in Music Shop

  • WebKit\ResourceLoader\inc\LoaderContainer.h: (CLoaderContainer::SetDownloadAppClientUID): new function for storing App UID in LoaderContainer (CLoaderContainer::DownloadAppClientUID): new function for retrieving App UID from LoaderContainer (CLoaderContainer::iDownloadClientAppUID): TUid instance for storing App Uid
  • WebKit\ResourceLoader\src\LoaderContainer.cpp: (CLoaderContainer::ConstructL): initialized iDownloadClientAppUID with default browser Uid - KCRUidBrowser
  • WebKit\ResourceLoader\src\HttpDownloadObserver.cpp: (CHttpDownloadObserver::InitDownloadMgrL): while connecting to download manager server, use the application Uid which is passed by the client, instead of always using Browser's App Uid
  • WebKit\BrowserView\src\WebKitControl.cpp (CWebKitControl::SetBrowserSettingL): Store the Application Uid in LoaderContainer
9:59 AM Changeset in webkit [23855] by rwlbuis
  • 5 edits in trunk/LayoutTests

Forgot committing this change in my previous commit.

9:00 AM Changeset in webkit [23854] by rwlbuis
  • 11 edits
    4 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=14373
CSS1: selectors (classes and IDs) cannot start with a dash or with a digit

Make sure the id selector validates against the CSS2.1 identfier
definition, not the hexcolor/HASH definition.

7:44 AM Changeset in webkit [23853] by hausmann
  • 3 edits in trunk/WebKitQt

Propagate mouse double click events from Qt to WebCore.

7:16 AM Changeset in webkit [23852] by hausmann
  • 4 edits in trunk/WebKitQt

Implemented clipboard functions in QWebPage, in particular can(Cut|Copy|Paste), cut/copy/paste as slot as well as a selectionChanged() signal.

7:16 AM Changeset in webkit [23851] by hausmann
  • 2 edits in trunk/WebCore

Implemented PasteboardQt::writeSelection to copy the selected text into the Clipboard as well as PasteboardQt::plainText to retrieve plain text from the clipboard for pasting for example into form fields.

6:54 AM Changeset in webkit [23850] by antti
  • 15 edits in trunk

LayoutTests:

Reviewed by Mitz.


Test changes for ​http://bugs.webkit.org/show_bug.cgi?id=14332
Bug 14332: REGRESSION (r21145): <td> width ignored
<rdar://problem/5290123>


  • expand empty-cells.html to cover non-zero cellpadding case too
  • update other related tests (none of these affect pixel results)
  • fast/css/acid2-expected.txt:
  • fast/css/acid2-pixel-expected.txt:
  • fast/table/032-expected.txt:
  • fast/table/empty-cells-expected.checksum:
  • fast/table/empty-cells-expected.png:
  • fast/table/empty-cells-expected.txt:
  • fast/table/empty-cells.html:
  • fast/table/empty-section-crash-expected.txt:
  • http/tests/misc/acid2-expected.txt:
  • http/tests/misc/acid2-pixel-expected.txt:
  • tables/mozilla/bugs/bug222467-expected.txt:
  • tables/mozilla/bugs/bug78162-expected.txt:

WebCore:

Reviewed by Mitz.


Fix ​http://bugs.webkit.org/show_bug.cgi?id=14332
Bug 14332: REGRESSION (r21145): <td> width ignored
<rdar://problem/5290123>


Cells in table with non-zero cellpadding are not considered empty.

  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn):
1:58 AM Changeset in webkit [23849] by rwlbuis
  • 4 edits
    4 adds in branches/feature-branch

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=14241
SVG <image> with height or width less than 1 fails to render image

Keep extra member vars to get width/height as floats for accurate
calculations.

12:48 AM Changeset in webkit [23848] by aroben
  • 2 edits in trunk/WebCore

Fix <rdar://problem/5300455> Prefast: typo in RenderBlock::paintObject

Reviewed by Hyatt.

No layout test possible, as this bug didn't have any effect since
"bool & bool" has the same value as "bool && bool"

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintObject): Changed & to &&.

12:30 AM Changeset in webkit [23847] by aroben
  • 3 edits
    2 adds in trunk

Fix <rdar://problem/5300443> word-break and -webkit-user-modify allow any value

WebCore:

Fix <rdar://problem/5300443> word-break and -webkit-user-modify allow any value

The bug was caused by two typos found by prefast.

Reviewed by Hyatt.

  • css/cssparser.cpp: (WebCore::CSSParser::parseValue): Fixed typos.

LayoutTests:

New test for <rdar://problem/5300443> word-break and -webkit-user-modify allow any value

Reviewed by Hyatt.

  • fast/css/word-break-user-modify-allowed-values-expected.txt: Added.
  • fast/css/word-break-user-modify-allowed-values.html: Added.

Jun 27, 2007:

11:53 PM Changeset in webkit [23846] by kmccullo
  • 4 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Darin.

  • <rdar://problem/5271937> REGRESSION: Apparent WebKit JavaScript memory smasher when submitting comment to iWeb site (crashes in kjs_pcre_compile2)
  • Correctly evaluate the return value of _pcre_ucp_findchar.
  • pcre/pcre_compile.c: (compile_branch):
  • pcre/pcre_exec.c: (match):

LayoutTests:

Reviewed by Darin.

  • <rdar://problem/5271937> REGRESSION: Apparent WebKit JavaScript memory smasher when submitting comment to iWeb site (crashes in kjs_pcre_compile2)
  • Correctly evaluate the return value of _pcre_ucp_findchar.
  • fast/js/regexp-unicode-overflow-expected.txt: Added.
  • fast/js/regexp-unicode-overflow.html: Added.
  • fast/js/resources/regexp-unicode-overflow.js: Added.
11:18 PM Changeset in webkit [23845] by bdash
  • 2 edits in trunk/WebCore

2007-06-20 Matt Perry <​mpComplete@gmail.com>

Reviewed by Adam.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Got rid of a call to saveLastSelection in the "Enter" key handler for select controls that was preventing onchange from firing.
11:01 PM Changeset in webkit [23844] by weinig
  • 1 edit in trunk/WebCore/page/DOMSelection.cpp

Yet another build fix :(

10:32 PM Changeset in webkit [23843] by weinig
  • 3 edits in trunk/WebCore

Fix Gdk, Qt, and Win32 builds.

  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
10:25 PM Changeset in webkit [23842] by weinig
  • 12 edits
    3 adds in trunk

LayoutTests:

Reviewed by Geoff.

Update tests for ​http://bugs.webkit.org/show_bug.cgi?id=14319
Move the Selection object out of the JS bindings

  • fast/dom/Window/window-properties-expected.txt:
  • fast/js/toString-and-valueOf-override-expected.txt:
  • http/tests/security/cross-frame-access-expected.txt:

WebCore:

Reviewed by Geoff.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=14319
Move the Selection object out of the JS bindings

  • Renames JS Object Selection to DOMSelection to avoid a name conflict.
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::Window::mark): (KJS::Window::clearHelperObjectProperties): (KJS::WindowFunc::callAsFunction): (KJS::Window::disconnectFrame):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • page/DOMSelection.cpp: Added. (WebCore::DOMSelection::DOMSelection): (WebCore::DOMSelection::frame): (WebCore::DOMSelection::disconnectFrame): (WebCore::DOMSelection::anchorNode): (WebCore::DOMSelection::baseNode): (WebCore::DOMSelection::anchorOffset): (WebCore::DOMSelection::baseOffset): (WebCore::DOMSelection::focusNode): (WebCore::DOMSelection::extentNode): (WebCore::DOMSelection::focusOffset): (WebCore::DOMSelection::extentOffset): (WebCore::DOMSelection::isCollapsed): (WebCore::DOMSelection::type): (WebCore::DOMSelection::rangeCount): (WebCore::DOMSelection::collapse): (WebCore::DOMSelection::collapseToEnd): (WebCore::DOMSelection::collapseToStart): (WebCore::DOMSelection::empty): (WebCore::DOMSelection::setBaseAndExtent): (WebCore::DOMSelection::setPosition): (WebCore::DOMSelection::modify): (WebCore::DOMSelection::getRangeAt): (WebCore::DOMSelection::removeAllRanges): (WebCore::DOMSelection::addRange): (WebCore::DOMSelection::toString):
  • page/DOMSelection.h: Added.
  • page/DOMSelection.idl: Added.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::disconnectFrame): (WebCore::DOMWindow::getSelection):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
8:34 PM Changeset in webkit [23841] by weinig
  • 5 edits in trunk/WebCore

Reviewed by Maciej.

2nd patch for ​http://bugs.webkit.org/show_bug.cgi?id=14111
Autogenerate Event JS binding

  • Cleanup kjs_events
  • bindings/js/kjs_events.cpp: (WebCore::JSAbstractEventListener::JSAbstractEventListener): (WebCore::JSAbstractEventListener::handleEvent): (WebCore::JSAbstractEventListener::isHTMLEventListener): (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener): (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener): (WebCore::JSUnprotectedEventListener::listenerObj): (WebCore::JSUnprotectedEventListener::windowObj): (WebCore::JSUnprotectedEventListener::clearWindowObj): (WebCore::JSUnprotectedEventListener::mark): (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::~JSEventListener): (WebCore::JSEventListener::listenerObj): (WebCore::JSEventListener::windowObj): (WebCore::JSEventListener::clearWindowObj): (WebCore::JSLazyEventListener::JSLazyEventListener): (WebCore::JSLazyEventListener::listenerObj): (WebCore::JSLazyEventListener::parseCode): (WebCore::getNodeEventListener): (WebCore::JSClipboard::JSClipboard): (WebCore::JSClipboard::getValueProperty): (WebCore::JSClipboard::putValueProperty): (WebCore::JSClipboardPrototypeFunction::callAsFunction): (WebCore::toJS): (WebCore::toClipboard):
  • bindings/js/kjs_events.h: (WebCore::JSClipboard::classInfo): (WebCore::JSClipboard::impl):
  • bindings/js/kjs_window.h:
  • ksvg2/events/JSSVGLazyEventListener.h:
8:19 PM Changeset in webkit [23840] by weinig
  • 7 edits
    8 adds in trunk

LayoutTests:

Reviewed by Adam Roben.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=12045
Crash under gmalloc at WTF::RefPtr<WebCore::HTMLSliderThumbElement>::operator->
<rdar://problem/5286670>

  • fast/forms/thumbslider-crash-expected.checksum: Added.
  • fast/forms/thumbslider-crash-expected.png: Added.
  • fast/forms/thumbslider-crash-expected.txt: Added.
  • fast/forms/thumbslider-crash.html: Added.
  • fast/forms/thumbslider-no-parent-slider-expected.checksum: Added.
  • fast/forms/thumbslider-no-parent-slider-expected.png: Added.
  • fast/forms/thumbslider-no-parent-slider-expected.txt: Added.
  • fast/forms/thumbslider-no-parent-slider.html: Added.

WebCore:

Reviewed by Adam Roben.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=12045
Crash under gmalloc at WTF::RefPtr<WebCore::HTMLSliderThumbElement>::operator->
<rdar://problem/5286670>

Test: fast/forms/thumbslider-no-parent-slider.html
Test: fast/forms/thumbslider-crash.html

  • rendering/RenderObject.h: (WebCore::RenderObject::isSlider):
  • rendering/RenderSlider.h: (WebCore::RenderSlider::isSlider):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::paint): Only paint thumbslider if the parent renderer is a RenderSlider.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSliderThumb):
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintSliderThumb):
6:50 PM Changeset in webkit [23839] by staikos
  • 1 edit in trunk/WebKitQt/QtLauncher/main.cpp

Missed this file as part of #23832

6:36 PM Changeset in webkit [23838] by staikos
  • 2 edits in trunk/WebCore

Make Qt builds link when XSLT is disabled

5:23 PM Changeset in webkit [23837] by sfalken
  • 2 edits in trunk/WebCore

Turn on static code analysis (Windows only).

Affects only folks that have Visual Studio Team Suite installed,
or who have replaced their compiler with the version shipping in the
Vista SDK.


Reviewed by Oliver.

  • WebCore.vcproj/WebCore.vcproj:
5:04 PM Changeset in webkit [23836] by staikos
  • 2 edits in trunk/WebCore

Remove files that no longer exist (were commented out)

4:14 PM Changeset in webkit [23835] by staikos
  • 5 edits in trunk/WebCore

revert IDL change until the code generator is fixed

4:08 PM Changeset in webkit [23834] by justing
  • 10 edits
    4 adds in trunk

LayoutTests:

Reviewed by John.


<rdar://problem/5247341> REGRESSION: Pasting sometimes loses trailing newline


Demonstrates the bug:

  • editing/pasteboard/5247341-expected.checksum: Added.
  • editing/pasteboard/5247341-expected.png: Added.
  • editing/pasteboard/5247341-expected.txt: Added.
  • editing/pasteboard/5247341.html: Added.


The changes in this patch exposed three bugs (5296964, 5296977, and 5299425).
Added FIXMES for them. Also removed tabs in them:

  • editing/pasteboard/paste-table-003-expected.checksum:
  • editing/pasteboard/paste-table-003-expected.png:
  • editing/pasteboard/paste-table-003-expected.txt:
  • editing/pasteboard/paste-table-003.html:
  • fast/forms/textarea-paste-newline.html:


Equivalent trees:

  • editing/pasteboard/paste-text-016-expected.txt:
  • editing/pasteboard/paste-text-017-expected.txt:

WebCore:

Reviewed by John.

<rdar://problem/5247341> REGRESSION: Pasting sometimes leaves out trailing newline


Pasting with a trailing interchange newline doesn't work when pasting
into an empty line. Code that handles removing brs at the insertion
position tries to also handle trailing interchange newlines by re-using
those brs and fails. Removed that code and handle all interchange
newlines with code later in doApply().

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Don't try to re-use the endBR when there's a trailing interchange newline.
3:21 PM Changeset in webkit [23833] by staikos
  • 5 edits in trunk/WebCore

Use the proper macros so that it builds with !SVG and !XPATH

3:06 PM Changeset in webkit [23832] by staikos
  • 6 edits in trunk/WebKitQt

Fix compilation with various Qt configurations

3:05 PM Changeset in webkit [23831] by sfalken
  • 1 edit in trunk/WebKit/win/ChangeLog

Fix ChangeLog.

3:01 PM Changeset in webkit [23830] by sfalken
  • 3 edits
    1 add in trunk/WebKit/win

Turn on static code analysis.

Reviewed by Oliver.


Effects only folks that have Visual Studio Team Suite installed,
or who have replaced their compiler with the version shipping in the
Vista SDK.

  • CodeAnalysisConfig.h: Added.
  • WebKit.vcproj/WebKit.vcproj:
  • WebLocalizableStrings.cpp: (createWebKitBundle):
2:55 PM Changeset in webkit [23829] by sfalken
  • 3 edits in trunk/WebKit/win

Prefast: Remove variable redefinitions in inner scopes.


Reviewed by Ada.

  • WebDownload.cpp: (WebDownload::didFinish):
  • WebNotificationCenter.cpp: (WebNotificationCenter::postNotificationInternal): (WebNotificationCenter::removeObserver):
2:28 PM Changeset in webkit [23828] by sfalken
  • 2 edits in trunk/WebKit/win

Remove SEH block from around history plist read, since the underlying bug has been fixed.


Reviewed by Darin.

  • WebHistory.cpp: (createHistoryListFromStream):
2:27 PM Changeset in webkit [23827] by andersca
  • 4 edits in trunk/WebCore

Reviewed by Oliver.

<rdar://problem/5253950>
When Shockwave plugin has been loaded, exiting crashes Safari


Add a "load count" for plugin packages. When the load count is zero, unload the plugin.


  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::PluginPackageWin): (WebCore::PluginPackageWin::load): (WebCore::PluginPackageWin::unload): (WebCore::PluginPackageWin::unloadWithoutShutdown):
  • plugins/win/PluginPackageWin.h:


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::~PluginViewWin): Make sure to unload the plugin package and clear any references to plugin script objects.
1:45 PM Changeset in webkit [23826] by staikos
  • 2 edits in trunk/WebCore

We were compiling purely out of luck, but if qmake sets up the build order
slightly differently it fails. This forces a dependency to generate HTMLNames.h
in time.

1:13 PM Changeset in webkit [23825] by staikos
  • 2 edits in trunk/WebKitQt

Patch from Eli Fidler to compile when QT_NO_IMAGE_TEXT is defined.

1:06 PM Changeset in webkit [23824] by staikos
  • 2 edits in trunk/WebKitQt

Patch from Eli Fidler to remove QT3_SUPPORT dependency in ICO handler.

1:04 PM Changeset in webkit [23823] by justing
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by John.


<rdar://problem/4580583> Breaking blockquoted list should not automatically renumber the second list

Splits a quoted list w/o splitting a list item:

  • editing/execCommand/4580583-1-expected.checksum: Added.
  • editing/execCommand/4580583-1-expected.png: Added.
  • editing/execCommand/4580583-1-expected.txt: Added.
  • editing/execCommand/4580583-1.html: Added.


Split a quoted list item:

  • editing/execCommand/4580583-2-expected.checksum: Added.
  • editing/execCommand/4580583-2-expected.png: Added.
  • editing/execCommand/4580583-2-expected.txt: Added.
  • editing/execCommand/4580583-2.html: Added.

WebCore:

Reviewed by John.

<rdar://problem/4580583> Breaking blockquoted list should not automatically renumber the second list


When a quoted numbered list is broken in half, it's cloned
to make the second list. That second list needs its start attribute
set so that the numbers of the list items in it will be preserved.

  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): Set the start attribute of a cloned list to be the original number of the first list item in it.
10:28 AM Changeset in webkit [23822] by sfalken
  • 2 edits in trunk/WebKit/win

Prefast: Fix misplaced parenthesis.


Reviewed by Darin.

  • WebView.cpp: (core):
10:21 AM Changeset in webkit [23821] by ap
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

​http://bugs.webkit.org/show_bug.cgi?id=14413
GIF animation throttling is different from MSIE

  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::frameDurationAtIndex): Change the cut-off value to 50ms to match MSIE.
10:15 AM Changeset in webkit [23820] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Darin


  • WebKit support for displaying multiple text matches in PDF views (<rdar://problem/4601967>)
  • WebView/WebPDFView.h: new ivars textMatches and lastScrollPosition; now conforms to WebMultipleTextMatches protocol


  • WebView/WebPDFView.mm: (-[WebPDFView dealloc]): release textMatches (-[WebPDFView viewDidMoveToWindow]): start observing bounds changes in the PDF document's enclosing clip view, so we can notice when scrolling takes place (-[WebPDFView viewWillMoveToWindow:]): stop observing bounds changes in the PDF document's enclosing clip view (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]): most of the code here has been moved into the new method _nextMatchFor::::, which this now calls (-[WebPDFView setMarkedTextMatchesAreHighlighted:]): implementation of WebMultipleTextMatches protocol method, does nothing useful here because we don't support inline highlighting of matches in PDF documents (-[WebPDFView markedTextMatchesAreHighlighted]): implementation of WebMultipleTextMatches protocol method (-[WebPDFView markAllMatchesForText:caseSensitive:limit:]): implementation of WebMultipleTextMatches protocol method; calls _nextMatchFor:::: in a loop until entire document is searched or limit is hit; records results by saving PDFSelections in textMatches ivar (-[WebPDFView unmarkAllTextMatches]): implementation of WebMultipleTextMatches protocol method; clears saved textMatches (-[WebPDFView rectsForTextMatches]): implementation of WebMultipleTextMatches protocol method; converts saved PDFSelections into NSValue objects that represent NSRects (-[WebPDFView _clipViewForPDFDocumentView]): new helper method to find the clip view whose bounds determine the current scroll position (-[WebPDFView _nextMatchFor:direction:caseSensitive:wrap:fromSelection:startInSelection:]): new helper method, extracted from searchFor::::: (-[WebPDFView _PDFDocumentViewMightHaveScrolled:]): new notification callback; tells webView's delegate when document has scrolled (-[WebPDFView _setTextMatches:]): new helper method, stores value in ivar
10:13 AM Changeset in webkit [23819] by sfalken
  • 2 edits in trunk/WebKit/win

Prefast: Add null check prior to writing into allocated BSTR.


Reviewed by Darin.

  • MarshallingHelpers.cpp: (MarshallingHelpers::CFStringRefToBSTR):
9:53 AM Changeset in webkit [23818] by sfalken
  • 2 edits in trunk/WebKit/win

Prefast: Add error handling for SysAllocStringLen where the string length is determined by website content.

Reviewed by Sam, Darin.


Allocation failure will result in a null dereference in this case,
so it isn't exploitable.

  • DefaultDownloadDelegate.cpp: (DefaultDownloadDelegate::decideDestinationWithSuggestedFilename):
9:47 AM Changeset in webkit [23817] by ap
  • 1 add in trunk/LayoutTests/fast/dom/resources/1251.html

Forgot to commit this file with r23815.

9:43 AM Changeset in webkit [23816] by weinig
  • 29 edits in trunk

JavaScriptCore:

Reviewed by Darin.

First pass at fixing implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Add 'f' suffix where necessary.
  • kjs/testkjs.cpp: (StopWatch::getElapsedMS):

WebCore:

Reviewed by Darin.

First pass at fixing implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Add 'f' suffix where necessary.
  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
  • css/csshelper.h:
  • css/cssstyleselector.cpp: (WebCore::): (WebCore::CSSStyleSelector::largerFontSize): (WebCore::CSSStyleSelector::smallerFontSize):
  • html/CanvasGradient.cpp: (WebCore::CanvasGradient::addColorStop):
  • html/CanvasPattern.cpp: (WebCore::CanvasPattern::createPattern):
  • ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/events/SVGZoomEvent.cpp: (WebCore::SVGZoomEvent::SVGZoomEvent):
  • ksvg2/svg/SVGLength.cpp: (WebCore::SVGLength::SVGLength): (WebCore::SVGLength::value): (WebCore::SVGLength::setValue): (WebCore::SVGLength::valueAsPercentage): (WebCore::SVGLength::PercentageOfViewport):
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::pixelUnitToMillimeterX): (WebCore::SVGSVGElement::pixelUnitToMillimeterY): (WebCore::SVGSVGElement::getScreenCTM):
  • ksvg2/svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::getComputedTextLength): (WebCore::SVGTextContentElement::getSubStringLength): (WebCore::SVGTextContentElement::getRotationOfChar):
  • ksvg2/svg/SVGTransformDistance.cpp: (WebCore::SVGTransformDistance::SVGTransformDistance): (WebCore::SVGTransformDistance::distance):
  • page/InspectorController.cpp: (WebCore::InspectorResource::InspectorResource):
  • platform/graphics/FloatPoint3D.cpp: (WebCore::FloatPoint3D::normalize):
  • platform/graphics/Path.cpp: (WebCore::pathLengthApplierFunction): (WebCore::Path::createRoundedRectangle):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::FrameData::clear):
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::frameDurationAtIndex):
  • platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::setCurrentPage):
  • platform/graphics/svg/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::externalRepresentation):
  • platform/graphics/svg/SVGPaintServerRadialGradient.cpp: (WebCore::SVGPaintServerRadialGradient::SVGPaintServerRadialGradient):
  • platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::cgGradientCallback): (WebCore::CGShadingRefForRadialGradient): (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
  • platform/mac/FontDataMac.mm: (WebCore::webFallbackFontFamily):
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally):
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::setValueForPosition): (WebCore::RenderSlider::setPositionFromValue):
9:36 AM Changeset in webkit [23815] by ap
  • 5 edits
    2 adds in trunk

Reviewed by Geoff.

​http://bugs.webkit.org/show_bug.cgi?id=14288
XMLHttpRequest doesn't use a correct content type for ​file:// URLs

Test: fast/dom/xmlhttprequest-html-response-encoding.html

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::responseMIMEType): Use MIME type provided by the network layer, since it provides it even for non-HTTP responses.
8:00 AM Changeset in webkit [23814] by zbujtas
  • 5 edits in S60/trunk/WebKit

rathnasa, reviewed by <​zbujtas@gmail.com>

DESC: Widget Menu API needs refinement
​http://bugs.webkit.org/show_bug.cgi?id=14389

6:27 AM BuildingQtOnLinux edited by treat@kde.org
(diff)
6:27 AM BuildingQtOnLinux edited by treat@kde.org
add heading (diff)
6:21 AM BuildingQtOnLinux edited by treat@kde.org
Don't focus on one or two distros and update minimum version of Qt. (diff)
1:19 AM Changeset in webkit [23813] by oliver
  • 3 edits in trunk/WebKit

Reviewed by Maciej.

Hopefully fix remainder of the IME issues on Mac.
We now assume that the IME silently consumes any event given
to it during text composition, and only override this assumption
if the NSTextInput or NSResponder callbacks are made.

This prevents us from treating those events that the IME has
consumed internally (eg. candidate window navigation) as unhandled
events that should be bubbled.

This fixes:

<rdar://problem/5107538> Major problems handling key press event with non-english Input Methods
<rdar://problem/4196249> REGRESSION: Mail: Inputting space (U+0020) with IM deletes subsequent line breaks on Mail.app
<rdar://problem/5015544> REGRESSION: Reverse conversion keyboard command does not work in Safari.
<rdar://problem/5045121> REGRESSION: Inline is confirmed after press left/right arrow keys, happens in Mail but not in TextEdit.
<rdar://problem/5076807> REGRESSION: Can't undo conversion of inline text (by hitting ESC)
<rdar://problem/5085781> REGRESSION: Active input area lost "selected" highlight
<rdar://problem/5094200> space key pressed to close the associated words candidate window gets inserted as text
<rdar://problem/5228294> Candidate item for character matrix is sometimes skipped

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLView.mm: (-[WebHTMLView launchKeyEvent:]): (-[WebHTMLView keyDown:]): (-[WebHTMLView keyUp:]): (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): (-[WebHTMLView unmarkText]): (-[WebHTMLView setMarkedText:selectedRange:]): (-[WebHTMLView doCommandBySelector:]): (-[WebHTMLView insertText:]):
Note: See TracTimeline for information about the timeline view.