Context Navigation

← Previous Period
Next Period →

Timeline

Jun 29, 2007:

8:37 PM Changeset in webkit [23896] by kevino

4 edits
6 adds in branches/wx-port-alpha/trunk

Adding wxPython bindings for wxWebKit.

8:35 PM Changeset in webkit [23895] by sfalken

1 edit in trunk/WebCore/WebCore.vcproj/WebCore.make

Build fix.

2:56 PM Changeset in webkit [23894] by justing

7 edits
1 add
1 delete in trunk

LayoutTests:

Reviewed by Harrison.

<rdar://problem/5299513> REGRESSION: In Mail, a crash occurs when attempting to undo a newly created To Do

Backing out a change made in r23787.

editing/deleting/4845371-expected.txt:
editing/deleting/4845371.html:
editing/deleting/5126166-expected.txt:
editing/deleting/5290534.html: Removed.
editing/deleting/5290534.html-disabled: Added.

WebCore:

Reviewed by Harrison.

<rdar://problem/5299513> REGRESSION: In Mail, a crash occurs when attempting to undo a newly created To Do

Rolled out a change made in r23787.

editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete):

2:45 PM Changeset in webkit [23893] by ggaren

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Darin Adler, Anders Carlsson.

Test for <rdar://problem/5303567> REGRESSION: XMLHttpRequest.responseXML
returns NULL if response MIME type is not XML -- breaks Wikipedia widget

fast/loader/xmlhttprequest-bad-mimetype-expected.txt: Added.
fast/loader/xmlhttprequest-bad-mimetype.html: Added.

WebCore:

Reviewed by Darin Adler, Anders Carlsson.

Fixed <rdar://problem/5303567> REGRESSION: XMLHttpRequest.responseXML
returns NULL if response MIME type is not XML -- breaks Wikipedia widget

The spec says that responseXML must return null for any HTTP response
with a non-XML MIME type. Technically, that leaves non-HTTP responses
free to do whatever they want.

xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::getResponseXML): Only return null for non-XML MIME types if the response was HTTP.

2:36 PM Changeset in webkit [23892] by weinig

12 edits in trunk

JavaScriptCore:

Reviewed by Darin.

Second pass at fixing implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

Add a toFloat() method to JSValue for float conversion.

JavaScriptCore.exp:
kjs/value.cpp: (KJS::JSValue::toFloat):
kjs/value.h:

WebCore:

Reviewed by Darin.

Second pass at fixing implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

Use new JSValue::toFloat() method instead of toNumber() where appropriate.

bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::setFillColor): (WebCore::JSCanvasRenderingContext2D::setStrokeColor): (WebCore::JSCanvasRenderingContext2D::strokeRect): (WebCore::JSCanvasRenderingContext2D::drawImage): (WebCore::JSCanvasRenderingContext2D::drawImageFromRect): (WebCore::JSCanvasRenderingContext2D::setShadow):
bindings/js/JSHTMLSelectElementCustom.cpp: (WebCore::JSHTMLSelectElement::remove):
bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::rotateFromVector):
bindings/js/kjs_events.cpp: (KJS::JSClipboardPrototypeFunction::callAsFunction):
bindings/scripts/CodeGeneratorJS.pm:
ksvg2/svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::executeScript):

2:29 PM Changeset in webkit [23891] by adele

4 edits
8 deletes in trunk

LayoutTests:

Rolling out tests for <rdar://problem/5301322>.

fast/forms/input-readonly-select-all-expected.checksum: Removed.
fast/forms/input-readonly-select-all-expected.png: Removed.
fast/forms/input-readonly-select-all-expected.txt: Removed.
fast/forms/input-readonly-select-all.html: Removed..
fast/forms/textarea-readonly-select-all-expected.checksum: Removed.
fast/forms/textarea-readonly-select-all-expected.png: Removed.
fast/forms/textarea-readonly-select-all-expected.txt: Removed.
fast/forms/textarea-readonly-select-all.html: Removed.

WebCore:

Rolling out fix for <rdar://problem/5301322> since it broke layout tests.

html/HTMLInputElement.h:
html/HTMLTextAreaElement.h:

1:51 PM Changeset in webkit [23890] by brmorris

2 edits
3 adds in S60/branches/3.1m/WebKit

brad, reviewed by sachin

DESC: merge of r23888 to 3.1 (generate browserversiongenerated.bat + about:version )

This is part of IAD.

ResourceLoader/src/AboutTransaction.cpp: (CAboutTransaction::DoSubmitL):
data/version.txt: Added.
group/version.mk: Added.
group/versiontext.bat: Added.

1:37 PM Changeset in webkit [23889] by ggaren

4 edits
2 adds in trunk

LayoutTests:

Reviewed by Oliver Hunt.

Layout tests for <rdar://problem/4962298> REGRESSION: Synchronous XHR for
missing local file throws exception -- breaks Wikipedia widget

fast/loader/xmlhttprequest-missing-file-exception-expected.txt: Added.
fast/loader/xmlhttprequest-missing-file-exception.html: Added.

WebCore:

Reviewed by Oliver Hunt.

Fixed <rdar://problem/4962298> REGRESSION: Synchronous XHR for missing
local file throws exception -- breaks Wikipedia widget

WebCore.xcodeproj/project.pbxproj:
xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): Don't throw exceptions for local files.

1:35 PM Changeset in webkit [23888] by brmorris

3 edits
3 adds in S60/trunk/WebKit

brad, reviewed by sachin

DESC: generate browserversiongenerated.bat + about:version

ResourceLoader/src/AboutTransaction.cpp: (CAboutTransaction::DoSubmitL):
data/version.txt: Added.
group/bld.inf:
group/version.mk: Added.
group/versiontext.bat: Added.

1:28 PM Changeset in webkit [23887] by spadma

2 edits in S60/trunk/WebKit

2007-06-29 Vikram Malaiya, reviewed by Sachin

DESC: YDAI-73QAL9 - Browser does not render any content from a data:URL.
http://bugs.webkit.org/show_bug.cgi?id=14436

ResourceLoader/src/DataTransaction.cpp: (CDataTransaction::CreateHeaderResponseLC):

12:38 PM Changeset in webkit [23886] by spadma

2 edits in S60/branches/3.1m/WebKit

ligman, reviewed by <reviewer>

DESC: The pluginloader does not handle top level loads correctly when the plugin is in an iframe. Always load page from the MainFrame.
http://bugs.webkit.org/show_bug.cgi?id=14447

Plugin/src/PluginLoader.cpp: (CPluginLoader::LoadPluginContentL):

12:29 PM Changeset in webkit [23885] by yongjzha

3 edits in S60/branches/3.1m/MemoryManager

2007-06-29 yongjzha <yongjun.zhang@nokia.com>

Reviewed by Zalan.
DESC: implement mmanp & munmap in Symbian OS.
http://bugs.webkit.org/show_bug.cgi?id=14461

Group/MemMan.mmp:
Src/fast_malloc.cpp: (fast_set_rescue_buffer_size): (release_rescue_buffer): (alloc_rescue_buffer): (chunkMoreCore): (symbian_mmap): (symbian_munmap): (log_abort): (fast_pre_check): (fast_post_check):

12:27 PM Changeset in webkit [23884] by yongjzha

7 edits in S60/trunk

hongzhao, reviewed by <Yongjun.zhang@nokia.com>

DESC: Video continue to play after closing the page view.
http://bugs.webkit.org/show_bug.cgi?id=14434

WebKit/BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
WebKit/BrowserControl/src/BrCtl.cpp: (CBrCtl::HandleCommandL):
WebKit/BrowserView/inc/WebKitFrame.h:
WebKit/BrowserView/src/WebKitFrame.cpp: (CWebKitFrame::RemovePluginWin):
WebKit/Plugin/inc/PluginSkin.h:
WebKit/Plugin/src/PluginSkin.cpp: (CPluginSkin::RemovePluginWin):

12:22 PM Changeset in webkit [23883] by adachan

2 edits in trunk/WebCore

2007-06-29 Ada Chan <adachan@apple.com>

Reviewed by Adam.

Fixed a previous fix to a signed/unsigned mismatch.

plugins/win/PluginPackageWin.cpp: (WebCore::splitString):

12:22 PM Changeset in webkit [23882] by yongjzha

18 edits in S60/trunk

yongjzha, reviewed by Zalan

DESC: Implement Linux-like mmap and munmap in Symbian OS

http://bugs.webkit.org/show_bug.cgi?id=14461

Group/MemMan.mmp:
Src/fast_malloc.cpp: (free_memory): (fast_set_rescue_buffer_size): (release_rescue_buffer): (alloc_rescue_buffer): (chunkMoreCore): (symbian_mmap): (symbian_munmap): (log_abort): (fast_pre_check): (fast_post_check):

11:15 AM Changeset in webkit [23881] by adele

4 edits
8 adds in trunk

LayoutTests:

Reviewed by Ada and Kevin McCullough.

Test for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas

fast/forms/input-readonly-select-all-expected.checksum: Added.
fast/forms/input-readonly-select-all-expected.png: Added.
fast/forms/input-readonly-select-all-expected.txt: Added.
fast/forms/input-readonly-select-all.html: Added.
fast/forms/textarea-readonly-select-all-expected.checksum: Added.
fast/forms/textarea-readonly-select-all-expected.png: Added.
fast/forms/textarea-readonly-select-all-expected.txt: Added.
fast/forms/textarea-readonly-select-all.html: Added.

WebCore:

Reviewed by Ada and Kevin McCullough.

Fix for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas

Implemented canSelectAll and selectAll for text fields and textareas, since they're special cases even when they're not editable.

Tests:
fast/forms/input-readonly-select-all.html
fast/forms/textarea-readonly-select-all.html

html/HTMLInputElement.h: (WebCore::HTMLInputElement::canSelectAll): (WebCore::HTMLInputElement::selectAll):
html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::canSelectAll): (WebCore::HTMLTextAreaElement::selectAll):

10:58 AM Changeset in webkit [23880] by aroben

2 edits in trunk/WebCore

Build fix

This is what happens when you test your patch on two OSs and then
commit from the wrong one.

rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::valueChanged):
(WebCore::RenderTextControl::itemText):
(WebCore::RenderTextControl::itemIsSeparator):

10:50 AM Changeset in webkit [23879] by aroben

2 edits in trunk/WebCore

Start compiling WebCore with /W3 under MSVC

One warning was globally disabled: implicit conversion of int to bool.

Reviewed by Darin.

WebCore.vcproj/WebCore.vcproj:

10:50 AM Changeset in webkit [23878] by aroben

3 edits in trunk/WebCore

Turn DeprecatedStringData's copy constructor into a static method to appease MSVC /W3

DeprecatedStringData now has no public copy constructor. The single
call to the old one has been replaced with a call to the new
DeprecatedStringData::createAndAdopt static method.

Reviewed by Darin.

All regression tests pass.

platform/DeprecatedString.cpp:

(WebCore::DeprecatedStringData::createAndAdopt):
(WebCore::DeprecatedStringData::adopt):
(WebCore::DeprecatedString::detachIfInternal):

platform/DeprecatedString.h:

10:50 AM Changeset in webkit [23877] by aroben

9 edits in trunk/WebCore

Fix more signed/unsigned mismatches uncovered by MSVC /W3

Reviewed by John.

No regression tests possible.

platform/network/cf/ResourceResponseCFNet.cpp:

(WebCore::filenameHasSaneExtension):

platform/win/FontDataWin.cpp:

(WebCore::FontData::containsCharacters):

platform/win/PlatformScrollBarSafari.cpp:

(WebCore::):

platform/win/UniscribeController.cpp:

(WebCore::UniscribeController::advance):
(WebCore::UniscribeController::shapeAndPlaceItem):

platform/win/WebCoreTextRenderer.cpp:

(WebCore::doDrawTextAtPoint):

plugins/win/PluginDatabaseWin.cpp:

(WebCore::parseVersionString):

plugins/win/PluginPackageWin.cpp:

(WebCore::splitString):

plugins/win/PluginViewWin.cpp:

(WebCore::freeStringArray):
(WebCore::PluginViewWin::invalidateTimerFired):

10:50 AM Changeset in webkit [23876] by aroben

8 edits in trunk/WebCore

Change PopupMenuClient::listSize to return an int to appease warnings from MSVC /W3

Reviewed by John.

No regression test possible.

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::menuListDefaultEventHandler):

platform/PopupMenuClient.h:
platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::calculatePositionAndSize):
(WebCore::PopupMenu::focusFirst):
(WebCore::PopupMenu::focusLast):
(WebCore::PopupMenu::down):
(WebCore::PopupMenu::up):
(WebCore::PopupMenu::paint):

rendering/RenderMenuList.cpp:
rendering/RenderMenuList.h:
rendering/RenderTextControl.cpp:
rendering/RenderTextControl.h:

10:50 AM Changeset in webkit [23875] by aroben

3 edits in trunk/WebCore

Fix two typos spotted by MSVC /W3

Both typos were a semicolon following the condition of an if. This
would cause the intended body of the if to always execute.

Unfortunately neither of these fixes are testable.
BackForwardList::goForward is only called from WebBackForwardList, and
the createDragImageFromImage bug would only manifest itself when
CreateCompatibleDC failed.

Reviewed by Mark.

history/BackForwardList.cpp:

(WebCore::BackForwardList::goForward):

platform/win/DragImageWin.cpp:

(WebCore::createDragImageFromImage):

7:19 AM Changeset in webkit [23874] by staikos

2 edits in trunk/WebCore

Patch from Adam Treat to improve scroll wheel support for Qt.

6:28 AM Changeset in webkit [23873] by antti

2 edits in branches/feature-branch/WebKitTools

Add VIDEO build flag

6:26 AM Changeset in webkit [23872] by antti

2 edits
85 adds in branches/feature-branch/LayoutTests

Basic tests for <video> and <audio>

6:25 AM Changeset in webkit [23871] by antti

32 edits
9 copies
22 adds in branches/feature-branch/WebCore

Support for HTML5 <video> and <audio> elements

6:25 AM Changeset in webkit [23870] by antti

6 edits in branches/feature-branch

Squashed commit of the following:

commit 0116a51745ee1ebe9a03ac3101f4c19f77e7459c
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 15:30:25 2007 +0300

delete video/

commit a31e7f20d0d6859853d414ddbeaf687f646768eb
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 15:21:12 2007 +0300

update ChangeLog

commit a918e88bf5b4b335d391975ff623e4b2d7981378
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 15:17:36 2007 +0300

move layout tests to media directory

commit 18d7cc5037909ded7f886fff4dde1d07e442120b
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 15:08:16 2007 +0300

add new window properties to test case

commit 59d0817997df6997a58ae807385c3cf107933025
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 15:06:43 2007 +0300

Implement review comments

commit 5fc7dcc6e943ae71f49ae5b9604094fa1b63036d
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 14:10:32 2007 +0300

Squashed commit of the following:

commit 3e7ca5b62c8106a3e5585e8f6a8bbb8a680f7b58
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 00:12:20 2007 +0300

use WebCoreSystemInterface for SPIs

random fixes

commit e32105832dbe42f1f5b7f173906fd7ee40c2cc79
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 00:11:34 2007 +0300

update ChangeLog

commit 621efda557bdaf8c670c60b2678ba205daab5d16
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 00:09:14 2007 +0300

SPIs

commit 9b2f4e7f72c3ca3e407d1cf7e3888a05e4abd418
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 00:21:50 2007 +0300

merge

commit 18d2a487635dae8bc61afe86e4520368074dd7f4
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 28 23:36:56 2007 +0300

Update ChangeLog

commit 919dc27a8de220ba934c4e2df88c4aa0ea621b10
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 28 23:35:59 2007 +0300

Use +/-inf for empty and deleted float hash keys

commit 109e1820d84d005c7d16bcbe15ed16ea720a7d27
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 17:53:11 2007 -0700

use SPI instead of private QTKit headers

commit 1987e31a5782f53b553a7c93f3c35048d85152f5
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 17:52:07 2007 -0700

add test video without audio track

more tolerant test cases

commit 51f34157309633502e76f157e374599313e4eb3f
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 15:25:37 2007 -0700

looser timing for test

commit 2735133a86c81cf71c67f293e7a1764ee3663f24
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 14:49:10 2007 -0700

fix int->float time conversion bug

fix cue point at 0

commit e6fd255201421644296841457c23ac023f03c262
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 13:28:56 2007 -0700

Update tests

commit 89cedff67fc5306980913b2f4cc321e8e6361ada
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 00:46:32 2007 -0700

update test files

commit 7d8923712a21ce09fb01806ceb333966c74565fb
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 00:35:59 2007 -0700

new test files

commit f1650455847033298087c2752288fb8843eda6e0
Author: Antti Koivisto <Antti Koivisto>
Date: Wed Jun 20 17:58:36 2007 -0700

fix float hash

commit 88ca8d32e2268342ad62611a4ed8c7a52dfbf65a
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 21:50:51 2007 -0700

don't crash with empty idl interfaces

commit cc54f83f5da73cd3ac04990cb5d310c5fa685074
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 21:48:42 2007 -0700

add test video

commit 478d0bc891a69d8862cdd79cadbe596bc39c1999
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 17:21:18 2007 -0700

tests

commit f647bef8037665128ed8985e6b9d12578ec8e7a6
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 16:53:29 2007 -0700

Some more files

commit 0fc70d1b08149d695b95ed3069a8774140308ddc
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 16:52:18 2007 -0700

Import video to feature branch

commit 3e7ca5b62c8106a3e5585e8f6a8bbb8a680f7b58
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 00:12:20 2007 +0300

use WebCoreSystemInterface for SPIs

random fixes

commit e32105832dbe42f1f5b7f173906fd7ee40c2cc79
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 00:11:34 2007 +0300

update ChangeLog

commit 621efda557bdaf8c670c60b2678ba205daab5d16
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 00:09:14 2007 +0300

SPIs

commit 9b2f4e7f72c3ca3e407d1cf7e3888a05e4abd418
Author: Antti Koivisto <Antti Koivisto>
Date: Fri Jun 29 00:21:50 2007 +0300

merge

commit 18d2a487635dae8bc61afe86e4520368074dd7f4
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 28 23:36:56 2007 +0300

Update ChangeLog

commit 919dc27a8de220ba934c4e2df88c4aa0ea621b10
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 28 23:35:59 2007 +0300

Use +/-inf for empty and deleted float hash keys

commit 109e1820d84d005c7d16bcbe15ed16ea720a7d27
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 17:53:11 2007 -0700

use SPI instead of private QTKit headers

commit 1987e31a5782f53b553a7c93f3c35048d85152f5
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 17:52:07 2007 -0700

add test video without audio track

more tolerant test cases

commit 51f34157309633502e76f157e374599313e4eb3f
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 15:25:37 2007 -0700

looser timing for test

commit 2735133a86c81cf71c67f293e7a1764ee3663f24
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 14:49:10 2007 -0700

fix int->float time conversion bug

fix cue point at 0

commit e6fd255201421644296841457c23ac023f03c262
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 13:28:56 2007 -0700

Update tests

commit 89cedff67fc5306980913b2f4cc321e8e6361ada
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 00:46:32 2007 -0700

update test files

commit 7d8923712a21ce09fb01806ceb333966c74565fb
Author: Antti Koivisto <Antti Koivisto>
Date: Thu Jun 21 00:35:59 2007 -0700

new test files

commit f1650455847033298087c2752288fb8843eda6e0
Author: Antti Koivisto <Antti Koivisto>
Date: Wed Jun 20 17:58:36 2007 -0700

fix float hash

commit 88ca8d32e2268342ad62611a4ed8c7a52dfbf65a
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 21:50:51 2007 -0700

don't crash with empty idl interfaces

commit cc54f83f5da73cd3ac04990cb5d310c5fa685074
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 21:48:42 2007 -0700

add test video

commit 478d0bc891a69d8862cdd79cadbe596bc39c1999
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 17:21:18 2007 -0700

tests

commit f647bef8037665128ed8985e6b9d12578ec8e7a6
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 16:53:29 2007 -0700

Some more files

commit 0fc70d1b08149d695b95ed3069a8774140308ddc
Author: Antti Koivisto <Antti Koivisto>
Date: Tue Jun 19 16:52:18 2007 -0700

Import video to feature branch

1:18 AM Changeset in webkit [23869] by antti

3 edits in trunk/WebKitLibraries

Reviewed by Maciej.

Added WKQTMovieDataRate and WKQTMovieMaxTimeLoaded

WebKitSystemInterface.h:
libWebKitSystemInterface.a:

Jun 28, 2007:

10:49 PM Changeset in webkit [23868] by aroben

7 edits in trunk/WebCore

Get WebCore compiling with /W2 on Windows

Reviewed by Steve.

No regression tests affected.

WebCore.vcproj/WebCore.vcproj: Turn the warning level up to 2, and

disable two warnings: implicit int <=> float conversion, and class vs.
struct inconsistency.

dom/CharacterData.cpp:

(WebCore::CharacterData::deleteData): Cast to int before negating.

loader/Cache.cpp:

(WebCore::Cache::remove): Ditto.

platform/graphics/Path.cpp:

(WebCore::pathLengthApplierFunction): Consistently use floats.

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawEllipse): Ditto.

platform/win/GraphicsContextWin.cpp:

(WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): Ditto.

9:16 PM Changeset in webkit [23867] by ggaren

3 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

Fixed <rdar://problem/5299005> DOM timers fire without a local autorelease
pool => pathologically high high water mark

I couldn't measure any performance problems with iBench HTML or PLT.

WebCore.xcodeproj/project.pbxproj: Changed .cpp file to be ObjC++.
platform/mac/SharedTimerMac.cpp: (WebCore::timerFired): Added autorelease pool.

7:46 PM Changeset in webkit [23866] by weinig

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Beth.

test for http://bugs.webkit.org/show_bug.cgi?id=14118 ASSERTION FAILED: !needsLayout() seen again

fast/dynamic/recursive-layout-expected.txt: Added.
fast/dynamic/recursive-layout.html: Added.

WebCore:

Reviewed by Beth.

fix http://bugs.webkit.org/show_bug.cgi?id=14118 ASSERTION FAILED: !needsLayout() seen again

Test: fast/dynamic/recursive-layout.html

page/FrameView.cpp: (WebCore::FrameView::layout): Removed the midLayout guards around the calls to invalidateSelection() and updateWidgetPositions(). Those calls may dirty the layout, but in that case they also update it, so they should be allowed to do it. Added an ASSERT to make sure that when they return, the root is not marked for layout.

6:05 PM Changeset in webkit [23865] by slewis

4 edits in trunk/WebKitTools

Reviewed by Adam,

Allow tests to use pre-built roots instead of building the tests.

Scripts/run-javascriptcore-tests: added --root option
Scripts/run-webkit-tests: added --root option
Scripts/webkitdirs.pm: added support for using a root

5:06 PM Changeset in webkit [23864] by thatcher

2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/5287569> WEBVIEW: Creating a webview in IB 3.0 (v2.0) NIB later crashes Interface Builder 2.5.4 on Tiger

Prevent encoding any of the WebView subviews. The subviews are ignored by -[WebView initWithCoder:] and will be recreated.
The Tiger 2.0 code crashed when the WebView released the subviews in initWithCoder:, so now there are no subviews to release.
This never happened before because the Tiger 2.0 code and IB wouldn't encode a WebView that has a WebHTMLView.

WebView/WebView.mm: (-[WebView encodeWithCoder:]):

4:02 PM Changeset in webkit [23863] by weinig

3 edits
4 deletes in trunk

LayoutTests:

Rubberstamped by Adam Roben.

Roll out r23861. It caused the buildbot to fail on intel.

http/tests/navigation/goBack-blank-tab-page-expected.txt: Removed.
http/tests/navigation/goBack-blank-tab-page.html: Removed.
http/tests/navigation/resources/before-go-back.html: Removed.
http/tests/navigation/resources/will-go-back.html: Removed.

WebCore:

Rubberstamped by Adam Roben.

Roll out r23861. It caused the buildbot to fail on intel.

page/Page.cpp: (WebCore::Page::goToItem):

2:57 PM Changeset in webkit [23862] by antti

3 edits in branches/feature-branch/JavaScriptCore

Reviewed by Maciej.

Use intHash to hash floats and doubles too.

ChangeLog:
wtf/HashFunctions.h: (WTF::FloatHash::hash): (WTF::FloatHash::equal): (WTF::):
wtf/HashTraits.h: (WTF::FloatHashTraits::emptyValue): (WTF::FloatHashTraits::deletedValue): (WTF::):

2:08 PM Changeset in webkit [23861] by weinig

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Geoff.

Tests for http://bugs.webkit.org/show_bug.cgi?id=13038

ASSERTION FAILED: item->target().isEmpty()

m_mainFrame->tree()->find(item->target()) == m_mainFrame

Although the test works with the script, it can't detect an eventually
error automatically since the first link must be opened in a new tab with
a _blank target to reproduce the crash. So it should be launched manually
following the steps decribed in there, then it's effective.

http/tests/navigation/goBack-blank-tab-page-expected.txt: Added.
http/tests/navigation/goBack-blank-tab-page.html: Added.
http/tests/navigation/resources/before-go-back.html: Added.
http/tests/navigation/resources/will-go-back.html: Added.

WebCore:

Reviewed by Geoff.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13038

ASSERTION FAILED: item->target().isEmpty()

m_mainFrame->tree()->find(item->target()) == m_mainFrame

Modification of an ASSERT on goToItem related to go back/forward in
history.Don't need to check the frameset if the target is _blank.

page/Page.cpp: (WebCore::Page::goToItem):

1:16 PM Changeset in webkit [23860] by andersca

1 edit in trunk/LayoutTests/ChangeLog

Tabs are bad

1:13 PM Changeset in webkit [23859] by andersca

2 edits in trunk/LayoutTests

Remove tests that don't need to be skipped anymore.

win/Skipped:

1:05 PM Changeset in webkit [23858] by spadma

2 edits in S60/trunk/WebKit

ligman, reviewed by <reviewer>

DESC: The pluginloader does not handle top level loads correctly when the plugin is in an iframe. Always load page from the MainFrame.
http://bugs.webkit.org/show_bug.cgi?id=14447

Plugin/src/PluginLoader.cpp: (CPluginLoader::LoadPluginContentL):

12:46 PM Changeset in webkit [23857] by andersca

2 edits in trunk/WebCore

Reviewed by Oliver.

<rdar://problem/5234139>
<object> with PNG src rendered as image document.

Complete the URL before passing it to the frame loader client.

html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::isImageType):

11:48 AM Changeset in webkit [23856] by spadma

7 edits in S60/trunk

2007-06-27 Prashanth Narayanaswamy <prashanth.narayanaswamy@nokia.com>

Reviewed by Sachin Padma.
DESC: SKWK-745NC7 - On going download files from Browser can be seen in Music Shop

WebKit\ResourceLoader\inc\LoaderContainer.h: (CLoaderContainer::SetDownloadAppClientUID): new function for storing App UID in LoaderContainer (CLoaderContainer::DownloadAppClientUID): new function for retrieving App UID from LoaderContainer (CLoaderContainer::iDownloadClientAppUID): TUid instance for storing App Uid

WebKit\ResourceLoader\src\LoaderContainer.cpp: (CLoaderContainer::ConstructL): initialized iDownloadClientAppUID with default browser Uid - KCRUidBrowser

WebKit\ResourceLoader\src\HttpDownloadObserver.cpp: (CHttpDownloadObserver::InitDownloadMgrL): while connecting to download manager server, use the application Uid which is passed by the client, instead of always using Browser's App Uid

WebKit\BrowserView\src\WebKitControl.cpp (CWebKitControl::SetBrowserSettingL): Store the Application Uid in LoaderContainer

9:59 AM Changeset in webkit [23855] by rwlbuis

5 edits in trunk/LayoutTests

Forgot committing this change in my previous commit.

9:00 AM Changeset in webkit [23854] by rwlbuis

11 edits
4 adds in trunk

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=14373
CSS1: selectors (classes and IDs) cannot start with a dash or with a digit

Make sure the id selector validates against the CSS2.1 identfier
definition, not the hexcolor/HASH definition.

7:44 AM Changeset in webkit [23853] by hausmann

3 edits in trunk/WebKitQt

Propagate mouse double click events from Qt to WebCore.

7:16 AM Changeset in webkit [23852] by hausmann

4 edits in trunk/WebKitQt

Implemented clipboard functions in QWebPage, in particular can(Cut|Copy|Paste), cut/copy/paste as slot as well as a selectionChanged() signal.

7:16 AM Changeset in webkit [23851] by hausmann

2 edits in trunk/WebCore

Implemented PasteboardQt::writeSelection to copy the selected text into the Clipboard as well as PasteboardQt::plainText to retrieve plain text from the clipboard for pasting for example into form fields.

6:54 AM Changeset in webkit [23850] by antti

15 edits in trunk

LayoutTests:

Reviewed by Mitz.

Test changes for http://bugs.webkit.org/show_bug.cgi?id=14332
Bug 14332: REGRESSION (r21145): <td> width ignored
<rdar://problem/5290123>

expand empty-cells.html to cover non-zero cellpadding case too
update other related tests (none of these affect pixel results)

fast/css/acid2-expected.txt:
fast/css/acid2-pixel-expected.txt:
fast/table/032-expected.txt:
fast/table/empty-cells-expected.checksum:
fast/table/empty-cells-expected.png:
fast/table/empty-cells-expected.txt:
fast/table/empty-cells.html:
fast/table/empty-section-crash-expected.txt:
http/tests/misc/acid2-expected.txt:
http/tests/misc/acid2-pixel-expected.txt:
tables/mozilla/bugs/bug222467-expected.txt:
tables/mozilla/bugs/bug78162-expected.txt:

WebCore:

Reviewed by Mitz.

Fix http://bugs.webkit.org/show_bug.cgi?id=14332
Bug 14332: REGRESSION (r21145): <td> width ignored
<rdar://problem/5290123>

Cells in table with non-zero cellpadding are not considered empty.

rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn):

1:58 AM Changeset in webkit [23849] by rwlbuis

4 edits
4 adds in branches/feature-branch

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=14241
SVG <image> with height or width less than 1 fails to render image

Keep extra member vars to get width/height as floats for accurate
calculations.

12:48 AM Changeset in webkit [23848] by aroben

2 edits in trunk/WebCore

Fix <rdar://problem/5300455> Prefast: typo in RenderBlock::paintObject

Reviewed by Hyatt.

No layout test possible, as this bug didn't have any effect since
"bool & bool" has the same value as "bool && bool"

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintObject): Changed & to &&.

12:30 AM Changeset in webkit [23847] by aroben

3 edits
2 adds in trunk

Fix <rdar://problem/5300443> word-break and -webkit-user-modify allow any value

WebCore:

Fix <rdar://problem/5300443> word-break and -webkit-user-modify allow any value

The bug was caused by two typos found by prefast.

Reviewed by Hyatt.

css/cssparser.cpp: (WebCore::CSSParser::parseValue): Fixed typos.

LayoutTests:

New test for <rdar://problem/5300443> word-break and -webkit-user-modify allow any value

Context Navigation

Timeline

Jun 29, 2007:

Jun 28, 2007:

Download in other formats: