⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 2, 2007:

10:52 PM Changeset in webkit [23941] by aroben
  • 2 edits in trunk/LayoutTests

Update the Windows Skipped list.

  • win/Skipped:
6:36 PM Changeset in webkit [23940] by aroben
  • 6 edits in trunk/LayoutTests

Update results after r23938.

  • fast/inline-block/14498-positionForCoordinates-expected.txt:
  • fast/table/click-near-anonymous-table-expected.txt:
  • svg/custom/pointer-events-image-expected.txt:
  • svg/custom/pointer-events-path-expected.txt:
  • svg/custom/text-hit-test-expected.txt:
5:53 PM Changeset in webkit [23939] by oliver
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/5098378> single-pixel image optimization needs to be rewritten to not depend on floating point bitmap
Tested by fast/replaced/image-solid-color-with-alpha.html

Switch from float to byte based bitmap when pulling the color from 1x1 pixel images so
that we can use the single pixel image optimisation in WebKit/win.

  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::checkForSolidColor):
4:54 PM Changeset in webkit [23938] by aroben
  • 3 edits
    2 adds in trunk

Fix Bug 14498: RenderContainer::positionForCoordinates contains an order of operations error

WebCore:

Fix Bug 14498: RenderContainer::positionForCoordinates contains an order of operations error
​http://bugs.webkit.org/show_bug.cgi?id=14498

There were two bugs:
1) xPos/yPos were flipped
2) + binds tighter than ?:, so the order of operations was incorrect

Reviewed by Darin.

Test: fast/inline-block/14498-positionForCoordinates.html

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::positionForCoordinates):

LayoutTests:

Test for Bug 14498: RenderContainer::positionForCoordinates contains an order of operations error
​http://bugs.webkit.org/show_bug.cgi?id=14498

Reviewed by Darin.

  • fast/inline-block/14498-positionForCoordinates-expected.txt: Added.
  • fast/inline-block/14498-positionForCoordinates.html: Added.
4:30 PM Changeset in webkit [23937] by darin
  • 6 edits in trunk/WebKit

Reviewed by Kevin Decker and Tim Hatcher.

  • fix <rdar://problem/5307880> some classes need finalize methods because of non-trivial work done in dealloc methods
  • DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer dealloc]): Added a comment about how this probably won't work under GC.
  • WebInspector/WebNodeHighlight.m: (-[WebNodeHighlight dealloc]): Ditto.
  • WebView/WebDataSource.mm: (+[WebDataSourcePrivate initialize]): Added. Makes finalize run on main thread. (-[WebDataSourcePrivate finalize]): Added. Calls deref on the document loader.
  • WebView/WebHTMLView.mm: (+[WebHTMLViewPrivate initialize]): Added. Makes finalize run on main thread. (-[WebHTMLViewPrivate finalize]): Added. Calls deref on promisedDragTIFFDataSource.
  • WebKit.xcodeproj/project.pbxproj: Let Xcode be Xcode.
4:29 PM Changeset in webkit [23936] by darin
  • 4 edits in trunk/WebCore

Reviewed by Kevin Decker and Tim Hatcher.

  • fix <rdar://problem/5307906> some classes need finalize methods because of non-trivial work done in dealloc methods
  • bindings/objc/DOMRGBColor.mm: (+[DOMRGBColor initialize]): Added. Tells finalizer to run on main thread, which is needed because we are sharing a CFDictionary here with no locking.
  • bridge/mac/WebCoreAXObject.mm: (+[WebCoreAXObject initialize]): Added. Tells finalizer to run on main thread. (-[WebCoreAXObject finalize]): Added. Calls detach.
  • WebCore.xcodeproj/project.pbxproj: Let Xcode do what it wants to do.
4:20 PM Changeset in webkit [23935] by weinig
  • 8 edits in trunk/WebCore

Reviewed by Darin.

Sixth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

Use new narrowPrecisionToFloat() and narrowPrecisionToCGFloat() where
appropriate.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setShadow): (WebCore::CanvasRenderingContext2D::applyShadow):
  • html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
  • ksvg2/svg/SVGAngle.cpp:
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseKeyNumbers): (WebCore::parseKeySplines): (WebCore::SVGAnimationElement::handleTimerEvent): (WebCore::SVGAnimationElement::updateAnimatedValueForElapsedSeconds):
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::buildPattern):
  • ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
  • platform/graphics/cg/AffineTransformCG.cpp: (WebCore::AffineTransform::AffineTransform): (WebCore::AffineTransform::setMatrix): (WebCore::AffineTransform::map): (WebCore::AffineTransform::setA): (WebCore::AffineTransform::setB): (WebCore::AffineTransform::setC): (WebCore::AffineTransform::setD): (WebCore::AffineTransform::setE): (WebCore::AffineTransform::setF): (WebCore::AffineTransform::scale): (WebCore::AffineTransform::rotate): (WebCore::AffineTransform::translate): (WebCore::AffineTransform::shear):
4:05 PM Changeset in webkit [23934] by kevino
  • 6 edits in branches/wx-port-alpha/trunk

Enable RTTI and exceptions for now, fix a linking issue with libjpeg on Win, and improve support for building with Python versions other than 2.5.

3:14 PM Changeset in webkit [23933] by sullivan
  • 2 edits in trunk/WebCore
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]): added a comment
1:47 PM Changeset in webkit [23932] by weinig
  • 5 edits
    1 move in trunk/WebCore

Rubberstamped by Darin.

Rename FloatConversionUtilities.h to FloatConversion.h.
Fix Win32 build.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/DeprecatedString.cpp:
  • platform/FloatConversion.h: Copied from platform/FloatConversionUtilities.h.
  • platform/FloatConversionUtilities.h: Removed.
  • platform/StringImpl.cpp:
1:41 PM Changeset in webkit [23931] by weinig
  • 12 edits
    1 add in trunk

JavaScriptCore:

Reviewed by Kevin McCullough.

Fourth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

Add custom piDouble and piFloat constants to use instead of M_PI.

  • kjs/math_object.cpp: (MathObjectImp::getValueProperty):
  • wtf/MathExtras.h: (wtf_atan2):

WebCore:

Reviewed by Darin.

Fifth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

Add toFloat() method to string classes and use it where appropriate.

  • WebCore.xcodeproj/project.pbxproj:
  • css/cssparser.cpp: (WebCore::CSSParser::lex):
  • ksvg2/svg/SVGAngle.cpp: (WebCore::SVGAngle::setValueAsString):
  • platform/AtomicString.h: (WebCore::AtomicString::toFloat):
  • platform/DeprecatedString.cpp: (WebCore::DeprecatedString::toFloat):
  • platform/DeprecatedString.h:
  • platform/FloatConversionUtilities.h: Added. (WebCore::narrowPrecisionToFloat): (WebCore::narrowPrecisionToCGFloat):
  • platform/PlatformString.h:
  • platform/String.cpp: (WebCore::String::toFloat):
  • platform/StringImpl.cpp: (WebCore::StringImpl::toFloat):
  • platform/StringImpl.h:
11:44 AM Changeset in webkit [23930] by weinig
  • 11 edits in trunk

JavaScriptCore:

Reviewed by Kevin McCullough.

Third round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

Add custom piDouble and piFloat constants to use instead of M_PI.

  • kjs/math_object.cpp: (MathObjectImp::getValueProperty):
  • wtf/MathExtras.h: (wtf_atan2):

WebCore:

Reviewed by Kevin McCullough.

Third round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

Use new piDouble and piFloat constants instead of M_PI.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::rotate):
  • ksvg2/svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::calculateArc):
  • platform/graphics/Path.cpp: (WebCore::pathLengthApplierFunction): (WebCore::Path::createEllipse):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc):
  • platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::setCurrentPage):
  • platform/graphics/svg/filters/cg/SVGFEHelpersCg.h:
  • rendering/RenderPath.cpp: (WebCore::drawMarkerWithData):
11:12 AM BuildingGdk edited by alp@atoker.com
Update deps and tasks (diff)
8:52 AM Changeset in webkit [23929] by brmorris
  • 2 edits in S60/trunk/WebKit

brad, rs'd by sachin.

DESC: merge r23928 to trunk: noise suppression - typo in version.mk
causing a scanlog error ..

  • group/version.mk: typo in RELEASABLES phase.
8:50 AM Changeset in webkit [23928] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

brad, rs'd by sachin.

DESC: noise suppression - typo in version.mk causing a scanlog error ..

  • group/version.mk: typo in RELEASABLES phase.
7:08 AM Changeset in webkit [23927] by bdash
  • 2 edits in trunk/WebKitSite

2007-07-02 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • quality/reduction.html:
12:42 AM Changeset in webkit [23926] by oliver
  • 2 edits in trunk/WebKit

Reviewed by Justin.

Fix for

<rdar://problem/5290113> WebKit does not correctly handle replacement ranges from the IM in -[WebHTMLView insertText:]
​http://bugs.webkit.org/show_bug.cgi?id=13664

We replicate the logic of -[WebHTMLView setMarkedText:selectedRange:] to handle the Input Method
feeding us a replacement string through insertText: so we can handle IMs that use insertText to
replace text.

  • WebView/WebHTMLView.mm: (-[WebHTMLView insertText:]):

Jul 1, 2007:

10:48 PM Changeset in webkit [23925] by aroben
  • 2 edits in trunk/WebCore

Clarify/fix {Shadow,BorderImage}ParseContext's memory management

Prefast emitted warnings that drew my attention to
{Shadow,BorderImage}ParseContext::failed(). It turned out that these
methods were actually correct, but rather confusing. "failed" really
meant "abort and clean up" rather than "did you fail?", which was
unclear. However, once I figured that out, the "and clean up" part was
still a bit confusing, because all failed() did was to set a flag that
would later cause the ParseContext's members to be deleted in the
destructor. To clear this up, I've gotten rid of the failed() method
altogether. It always returned false, so I've replaced all calls to
it with the value false.

I also noticed that the lifetime management of the ParseContexts'
members was in all cases confusing, and in some cases wrong. The
m_border{Top,Right,Bottom,Left} members of BorderImageParseContext
were leaked whenever a border-image property was successfully parsed.
I fixed that by holding these members in OwnPtrs. The
CSSPrimitiveValue members of {Shadow,BorderImage}ParseContext, which
inherit from Shared, were being explicitly deleted, which is not a
safe way to manage the lifetime of objects that inherit from Shared.
To fix this, I put those members inside RefPtrs. These two changes
allowed me to remove the destructors entirely.

Reviewed by Darin.

All regression tests pass.

  • css/cssparser.cpp:

(WebCore::ShadowParseContext::commitValue): Use .release() to avoid
ref-count churn.
(WebCore::ShadowParseContext::commitLength): Use a RefPtr for the new value to
avoid a leak.
(WebCore::CSSParser::parseShadow): Use 'false' instead of
'context.failed()', and use .release() to avoid ref-count churn.
(WebCore::BorderImageParseContext::commitWidth): Updated to use
OwnPtr.
(WebCore::CSSParser::parseBorderImage): Use 'false' instead of
'context.failed'.

10:18 PM Changeset in webkit [23924] by oliver
  • 2 edits in trunk/WebKit

Reviewed by Alexey.

Fix for <rdar://problem/5306210> Some events are still passed to WebCore despite being handled by the IM
​http://bugs.webkit.org/show_bug.cgi?id=14457

We have to assume that the IM will consume all events, so we remove the dependency
on -[WebHTMLView hasMarkedText].

  • WebView/WebHTMLView.mm: (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]):
9:13 PM Changeset in webkit [23923] by andersca
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/5297146>
Crash in Mail at WebCore::Frame::setUserStyleSheetLocation (reproducible w/ particular message)


  • loader/Cache.cpp: (WebCore::Cache::requestResource): Only insert the resource in the LRU list if the cache is enabled.


(WebCore::Cache::insertInLRUList):
(WebCore::Cache::resourceAccessed):
Assert that the resource is in the cache.

7:26 PM Changeset in webkit [23922] by darin
  • 3 edits
    4 deletes in trunk
  • css/tokenizer.flex: Rolled out the fix for 14453. The layout test wasn't passing. We'll try again.
5:51 PM Changeset in webkit [23921] by kevino
  • 8 edits in branches/wx-port-alpha/trunk

Restore the Windows build after libpng/libjpeg and Python extension changes.

5:44 PM Changeset in webkit [23920] by aroben
  • 2 edits in trunk/WebCore

Fix a crash in ~PluginViewWin()

This crash was introduced in r23827.

Reviewed by Anders.

Fixes dom/html/level2/html/HTMLAnchorElement01.html

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginViewWin::~PluginViewWin): Allow m_plugin to be null.

4:47 PM Changeset in webkit [23919] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

Regression test for:
​http://bugs.webkit.org/show_bug.cgi?id=14453
REGRESSION: www.nzherald.co.nz almost all the formating is gone

  • css2.1/hex-color-regression-expected.checksum: Added.
  • css2.1/hex-color-regression-expected.png: Added.
  • css2.1/hex-color-regression-expected.txt: Added.
  • css2.1/hex-color-regression.html: Added.

WebCore:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=14453
REGRESSION: www.nzherald.co.nz almost all the formating is gone


  • css/tokenizer.flex: Allow hex colors with 2, 4, or 5 hex digits.
4:22 PM Changeset in webkit [23918] by darin
  • 2 edits in trunk/LayoutTests

Fixed a no-SVG test failure by removing a node that was affecting the test results differently
depending on whether SVG support was compiled in or not.

  • fast/xpath/namespace-vs-predicate.xhtml: Remove the r_00 node at the end of the test.
4:01 PM Changeset in webkit [23917] by aroben
  • 2 edits in trunk/WebKitTools

Fix some paths to make http tests work again on Windows

Rubberstamped by Sam.

  • Scripts/run-webkit-tests:
10:38 AM Changeset in webkit [23916] by weinig
  • 15 edits in trunk

LayoutTests:

Reviewed by Oliver.

Third round of implicit 64-32 bit conversion errors fixes.
<rdar://problem/5292262>

getFloatValue() used to return a double and now returns a float for a small
loss of precision.

  • fast/css/getFloatValueForUnit-expected.checksum:
  • fast/css/getFloatValueForUnit-expected.png:
  • fast/css/getFloatValueForUnit-expected.txt:
  • fast/css/getFloatValueForUnit.html:

WebCore:

Reviewed by Oliver.

Third round of implicit 64-32 bit conversion errors fixes.
<rdar://problem/5292262>

  • Use new CSSPrimitiveValue::getDoubleValue() and CSSPrimitiveValue::getIntValue() methods instead of CSSPrimitiveValue::getFloatValue() where appropriate.
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::computeLengthInt): (WebCore::CSSPrimitiveValue::computeLengthIntForLength): (WebCore::CSSPrimitiveValue::computeLengthShort): (WebCore::CSSPrimitiveValue::computeLengthFloat): (WebCore::CSSPrimitiveValue::computeLengthDouble): (WebCore::CSSPrimitiveValue::getDoubleValue):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::getDoubleValue): (WebCore::CSSPrimitiveValue::getFloatValue): (WebCore::CSSPrimitiveValue::getIntValue):
  • css/Counter.h: (WebCore::Counter::listStyleNumber):
  • css/MediaQueryEvaluator.cpp: (WebCore::parseAspectRatio):
  • css/cssparser.cpp: (WebCore::BorderImageParseContext::commitBorderImage):
  • css/cssstyleselector.cpp: (WebCore::convertToLength): (WebCore::applyCounterList): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapBackgroundSize): (WebCore::CSSStyleSelector::mapBackgroundXPosition): (WebCore::CSSStyleSelector::mapBackgroundYPosition):
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::parseMappedAttribute):
  • ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::KSVGPainterFactory::cssPrimitiveToLength): (WebCore::KSVGPainterFactory::dashArrayFromRenderingStyle):
10:23 AM Changeset in webkit [23915] by darin
  • 1 edit
    2 moves in trunk/LayoutTests

Fixed a no-SVG test failure by moving a test that requires SVG into the svg directory.

  • fast/dom/svg-element-attribute-js-null-expected.txt: Removed.
  • fast/dom/svg-element-attribute-js-null.xhtml: Removed.
  • svg/dom/svg-element-attribute-js-null-expected.txt: Copied from fast/dom/svg-element-attribute-js-null-expected.txt.
  • svg/dom/svg-element-attribute-js-null.xhtml: Copied from fast/dom/svg-element-attribute-js-null.xhtml.
10:05 AM Changeset in webkit [23914] by darin
  • 1 edit
    1 add in trunk/LayoutTests

Added a missing file for the test for <rdar://problem/5303567> REGRESSION: XMLHttpRequest.responseXML

  • fast/loader/resources/plist.app: Added. Just some random XML file I found somewhere; seems to make the test succeed instead of failing every time!
8:52 AM Changeset in webkit [23913] by bdash
  • 3 edits
    2 deletes in trunk

Roll out r23911 as it introduced two layout test failures.

7:26 AM Changeset in webkit [23912] by bdash
  • 7 edits in trunk

2007-07-01 Pamela Greene <​pamg.bugs@gmail.com>

Reviewed by Darin.

Fix for <​http://bugs.webkit.org/show_bug.cgi?id=14320>
Bug 14320: <canvas> gradient stops at identical offsets are applied in the wrong order
<rdar://problem/5290084>

Use std::stable_sort() instead of qsort() to sort gradient stops.
Adjust the comparison function accordingly.

  • html/CanvasGradient.cpp: (WebCore::compareStops): (WebCore::CanvasGradient::findStop):

2007-07-01 Pamela Greene <​pamg.bugs@gmail.com>

Reviewed by Darin.

Tests for <​http://bugs.webkit.org/show_bug.cgi?id=14320>
Bug 14320: <canvas> gradient stops at identical offsets are applied in the wrong order
<rdar://problem/5290084>

Add tests for various combinations of stops, including multiple stops at
the same offsets, sorted and unsorted. Update results accordingly.

  • fast/canvas/fillrect_gradient-expected.checksum:
  • fast/canvas/fillrect_gradient-expected.png:
  • fast/canvas/fillrect_gradient-expected.txt:
  • fast/canvas/fillrect_gradient.html:
7:20 AM Changeset in webkit [23911] by bdash
  • 3 edits
    2 adds in trunk

2007-07-01 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Darin.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=14448
HTMLObjectElement::data should return an absolute URL

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::isImageType): (WebCore::HTMLObjectElement::data):

2007-07-01 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Darin.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=14448
HTMLObjectElement::data should return an absolute URL

  • fast/dom/object-data-absurl-expected.txt: Added.
  • fast/dom/object-data-absurl.html: Added.
7:17 AM Changeset in webkit [23910] by bdash
  • 2 edits in trunk/WebCore

2007-07-01 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Darin.

m_usesPageCache was not initialized. As the b/f cache is only
implemented in the Mac port and WebView.mm is taking care of calling
Settings::setUsesPageCache I decided to make it false by default.

  • page/Settings.cpp: (WebCore::Settings::Settings): m_usesPageCache was not initialized
7:16 AM Changeset in webkit [23909] by bdash
  • 2 edits in trunk/WebCore

2007-07-01 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Darin.

Inherited- and NonInheritedFlags is a bit field. But for comparsion
the other part of the union _iflags/_niflags is used for comparions.
This will compare 5 uninitialized bits of _iflags and 22 of _niflags.
Make sure the unused bits have a specified value.

  • ksvg2/css/SVGRenderStyle.h: (WebCore::SVGRenderStyle::setBitDefaults): Make sure the unused bits have a value as well.
7:14 AM Changeset in webkit [23908] by bdash
  • 2 edits in trunk/WebKitSite

2007-07-01 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • coding/lgpl-license.html:
Note: See TracTimeline for information about the timeline view.