⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 3, 2007:

8:02 PM Changeset in webkit [23978] by darin
  • 2 edits in trunk/WebKit
  • StringsNotToBeLocalized.txt: Updated for recent changes.
6:07 PM Changeset in webkit [23977] by thatcher
  • 10 edits
    1 copy in trunk/WebKit

Reviewed by Darin.

Remove HIWebView in 64-bit.

Also disable a few calls that are now gone in 64-bit and filed these bugs:

<rdar://problem/5311653> WebKit needs to adopt HIGetMousePosition where we used GetGlobalMouse before
<rdar://problem/5311648> WebKit needs to move off of CopyEvent in WebBaseNetscapePluginView
<rdar://problem/5311640> WebKit needs a new solution for HISearchWindowShow on 64-bit

  • Carbon/CarbonUtils.m:
  • Carbon/CarbonWindowAdapter.m:
  • Carbon/CarbonWindowContentView.m:
  • Carbon/CarbonWindowFrame.m:
  • Carbon/HIViewAdapter.m: (SetViewNeedsDisplay):
  • Carbon/HIWebView.m: (Draw): (SyncFrame):
  • Configurations/WebKit.xcconfig:
  • Plugins/WebBaseNetscapePluginView.mm: (+[WebBaseNetscapePluginView getCarbonEvent:]): (TSMEventHandler):
  • WebKit.LP64.exp: Added.
  • WebView/WebView.mm: (-[WebView _searchWithSpotlightFromMenu:]):
6:04 PM Changeset in webkit [23976] by thatcher
  • 2 edits in trunk

Disable the strict aliasing warning until <rdar://problem/5311093> is fixed.

6:02 PM Changeset in webkit [23975] by thatcher
  • 1 edit in trunk/WebCore/page/mac/FrameMac.mm

64-bit build fix.

5:58 PM Changeset in webkit [23974] by aroben
  • 2 edits
    1 delete in trunk/WebKitTools

Fixed update-webkit-localizable-strings to work with new extract-localizable-strings

Got rid of extract-webkit-localizable-strings because it was trying to
do update-webkit-localizable-strings' job.

Rubberstamped by Darin.

  • Scripts/extract-webkit-localizable-strings: Removed.
  • Scripts/update-webkit-localizable-strings: Renamed from

extract-localizable-strings.

5:56 PM Changeset in webkit [23973] by thatcher
  • 10 edits
    1 copy in tags/Safari-5522.10/WebKit

Reviewed by Darin.

Remove HIWebView in 64-bit.

Also disable a few calls that are now gone in 64-bit and filed these bugs:

<rdar://problem/5311653> WebKit needs to adopt HIGetMousePosition where we used GetGlobalMouse before
<rdar://problem/5311648> WebKit needs to move off of CopyEvent in WebBaseNetscapePluginView
<rdar://problem/5311640> WebKit needs a new solution for HISearchWindowShow on 64-bit

  • Carbon/CarbonUtils.m:
  • Carbon/CarbonWindowAdapter.m:
  • Carbon/CarbonWindowContentView.m:
  • Carbon/CarbonWindowFrame.m:
  • Carbon/HIViewAdapter.m: (SetViewNeedsDisplay):
  • Carbon/HIWebView.m: (Draw): (SyncFrame):
  • Configurations/WebKit.xcconfig:
  • Plugins/WebBaseNetscapePluginView.mm: (+[WebBaseNetscapePluginView getCarbonEvent:]): (TSMEventHandler):
  • WebKit.LP64.exp: Added.
  • WebView/WebView.mm: (-[WebView _searchWithSpotlightFromMenu:]):
5:40 PM Changeset in webkit [23972] by aroben
  • 6 edits
    1 move
    1 add
    1 delete in trunk

Merge the Windows and Mac localized strings and exceptions files

WebKit:

Merge the Windows and Mac localized strings and exceptions files

Reviewed by Darin and Anders.

  • English.lproj/Localizable.strings: Added Windows strings.
  • StringsNotToBeLocalized.txt: Renamed from WebKit/English.lproj/StringsNotToBeLocalized.txt.

WebKit/win:

Merge the Windows and Mac localized strings and exceptions files

Reviewed by Darin and Anders.

  • English.lproj/Localizable.strings: Added Mac strings.
  • English.lproj/StringsNotToBeLocalized.txt: Removed.

WebKitTools:

Modify scripts to keep Mac/Windows localized strings in sync

extract-webkit-localizable-strings now handles extracting strings from
both the Mac and Windows WebKit ports and updating their respective
Localizable.strings files. extract-localizable-strings is now really a
piece of plumbing rather than a top-level tool.

Reviewed by Darin and Anders.

  • Scripts/extract-localizable-strings: Changed to handle multiple directories.
  • Scripts/extract-webkit-localizable-strings: Added.
5:29 PM Changeset in webkit [23971] by adele
  • 2 edits in trunk/WebKit

Removed printf I accidently left in.

  • Misc/WebNSURLExtras.m: (mapHostNames):
5:06 PM Changeset in webkit [23970] by thatcher
  • 4 edits in tags/Safari-5522.10/WebKit

Merge r23946 to fix 64-bit build.

5:04 PM Changeset in webkit [23969] by darin
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Tim Hatcher.

  • tests for <rdar://problem/5221297> Font family name in the cssText for a DOMCSSStyleDeclaration needs quotes
  • editing/style/font-family-with-space-expected.txt: Added.
  • editing/style/font-family-with-space.html: Added.
  • fast/inspector/style-expected.txt: Updated expected results to expect "Lucida Grande" in quote marks.

WebCore:

Reviewed by Tim Hatcher.

  • fix <rdar://problem/5221297> Font family name in the cssText for a DOMCSSStyleDeclaration needs quotes

Test: editing/style/font-family-with-space.html

  • css/FontFamilyValue.cpp: (WebCore::isValidCSSIdentifier): Added. Implements the same rule that the CSS lexer does. (WebCore::quoteStringIfNeeded): Changed to call isValidCSSIdentifier instead of just checking for a leading "#" character.
  • editing/markup.cpp: (WebCore::escapeTextForMarkup): Changed to take a String parameter for better efficiency. (WebCore::renderedText): Changed to return a String for better efficiency. (WebCore::addNamespace): Updated to pass String to escapeTextForMarkup. (WebCore::startMarkup): Updated to pass String to escapeTextForMarkup. Added missing call to escapeTextForMarkup in the special case for the style property. (WebCore::createMarkup): Changed from single quotes to double quotes and also added missing call to escapeTextForMarkup in two special cases for the style property.
4:56 PM Changeset in webkit [23968] by thatcher
  • 1 edit in tags/Safari-5522.10/WebCore/page/mac/FrameMac.mm

64-bit build fix.

4:54 PM Changeset in webkit [23967] by adele
  • 1 edit in trunk/WebKit/Misc/WebNSURLExtras.m

Updating comment

4:46 PM Changeset in webkit [23966] by thatcher
  • 2 edits in tags/Safari-5522.10

Disable the strict aliasing warning, not strict aliasing.

4:21 PM Changeset in webkit [23965] by thatcher
  • 2 edits in tags/Safari-5522.10

Turn off strict aliasing until <rdar://problem/5311093> is fixed.

4:19 PM Changeset in webkit [23964] by weinig
  • 6 edits in trunk/WebCore

Reviewed by Darin.

Twelfth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Add casts and accompanying FIXMEs to avoid remaining compiler errors.
  • WebCore.xcodeproj/project.pbxproj:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::opened): (WebCore::FrameLoader::sendRemainingDelegateMessages):
  • loader/FrameLoader.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didReceiveData):
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::nsURLResponse):
4:16 PM Changeset in webkit [23963] by adele
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters

  • fast/encoding/idn-security-expected.txt: Added.
  • fast/encoding/idn-security.html: Added.
  • win/Skipped: Blocked by <rdar://problem/5301954>.

WebKit:

Reviewed by Darin.

Fix for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters

  • Misc/WebNSURLExtras.m: (isLookalikeCharacter): Renamed. Also excludes any non-printable character, any character considered as whitespace that isn't already converted to a space by ICU, any ignorable character, and any character excluded in Mozilla's blacklist: ​http://kb.mozillazine.org/Network.IDN.blacklist_chars (allCharactersInIDNScriptWhiteList):

WebKitTools:

Reviewed by Darin.

Extended DumpRenderTree to test encoding and decoding host names.

  • DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): Added cases for encodeHostName and decodeHostName. (+[LayoutTestController webScriptNameForSelector:]): ditto. (-[LayoutTestController decodeHostName:]): Added. (-[LayoutTestController encodeHostName:]): Added.
4:03 PM Changeset in webkit [23962] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/bindings/python/samples/simple.py

Add some more functionality to the basic sample.

3:51 PM Changeset in webkit [23961] by weinig
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

Eleventh round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

Add functions to test long long and unsigned long long.

  • DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController objCLongLongRoundTrip:]): (-[LayoutTestController objCUnsignedLongLongRoundTrip:]):
3:37 PM Changeset in webkit [23960] by weinig
  • 3 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Darin.

Eleventh round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Fixes a real bug where where we were setting long long and unsigned long long values to a long field.
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue):

LayoutTests:

Reviewed by Darin.

Eleventh round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • fast/objc: Added.
  • fast/objc/longlongTest-expected.txt: Added.
  • fast/objc/longlongTest.html: Added.
3:11 PM Changeset in webkit [23959] by thatcher
  • 2 edits in tags/Safari-5522.10/WebCore

Merge r23894.

3:04 PM Changeset in webkit [23958] by thatcher
  • 3 edits in tags/Safari-5522.10

Turn off -Wshorten-64-to-32 until <rdar://problems/5292100&5292113&5292262> are fixed.

3:02 PM Changeset in webkit [23957] by darin
  • 4 edits in trunk/WebKit

Reviewed by Maciej.

  • fix <rdar://problem/5310848> WebDataSource lifetime problem -- may be cause of the leaks seen on the buildbot
  • WebView/WebDataSource.mm: (-[WebDataSourcePrivate dealloc]): Added a call to the new detachDataSource function. (-[WebDataSourcePrivate finalize]): Ditto.
  • WebView/WebDocumentLoaderMac.h: Added detachDataSource function to be used when the WebDataSource is deallocated. Added retain/releaseDataSource helper functions to be used to retain and release the data source object. Replaced the m_hasEverBeenDetached boolean with a more primitive and hence easier to understand m_isDataSourceRetained boolean.
  • WebView/WebDocumentLoaderMac.mm: (WebDocumentLoaderMac::WebDocumentLoaderMac): Initialize m_isDataSourceRetained to false. (WebDocumentLoaderMac::setDataSource): Call retainDataSource instead of calling HardRetain on the dataSource parameter. Also updated a comment. (WebDocumentLoaderMac::attachToFrame): Call retainDataSource unconditionally rather than trying to use m_hasEverBeenDetached to decide if a retain is needed. Also got rid of an assertion that m_loadingResources is empty -- not important any more. (WebDocumentLoaderMac::detachFromFrame): Call releaseDataSource instead of using HardRelease, but only if m_loadingResources is empty. If it's non-empty, then we'll do the releaseDataSource later in decreaseLoadCount. (WebDocumentLoaderMac::increaseLoadCount): Call retainDataSource unconditionally rather than calling HardRetain only if the old set of resources was empty. (WebDocumentLoaderMac::decreaseLoadCount): Call releaseDataSource if m_loadingResources is empty and we're not attached to a frame. If we are attached to a frame, then we'll do the releaseDataSource later in detachFromFrame. (WebDocumentLoaderMac::retainDataSource): Added. Calls CFRetain, but only if the data source is not already retained (according to the boolean). (WebDocumentLoaderMac::releaseDataSource): Added. Calls CFRelease, but only if the data source is currently retained (according to the boolean). (WebDocumentLoaderMac::detachDataSource): Added. Sets m_dataSource to nil. Since this is only called from WebDataSource's dealloc and finalize methods, it won't ever be called when the m_isDataSourceRetained boolean is true.
3:01 PM Changeset in webkit [23956] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5093862>
Nothing shown in plugin area when trying to play content using the DivX plugin


Defer calling SetWindow for the DivX plugin, just like we do with the WMP plugin.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::determineQuirks):
2:35 PM Changeset in webkit [23955] by weinig
  • 2 edits in trunk/JavaScriptCore

Reviewed by Brady Eidson.

Tenth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Add explicit casts.
  • kjs/dtoa.cpp: (Bigint::):
2:21 PM Changeset in webkit [23954] by darin
  • 2 edits in trunk/WebKit
  • forgot to check in one file in the fix for <rdar://problem/5307880> some classes need finalize methods because of non-trivial work done in dealloc methods
  • WebView/WebView.mm: (-[WebViewPrivate finalize]): Delete identifierMap so it doesn't leak.
2:17 PM Changeset in webkit [23953] by weinig
  • 3 edits in trunk/WebCore

Reviewed by Brady Eidson.

Ninth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Fix function signature to use unsigned long instead of unsigned long long.
  • loader/ProgressTracker.cpp: (WebCore::ProgressTracker::completeProgress):
  • loader/ProgressTracker.h:
2:11 PM Changeset in webkit [23952] by thatcher
  • 1 copy in tags/Safari-5522.10

New tag.

1:46 PM Changeset in webkit [23951] by weinig
  • 44 edits in trunk/WebCore

Reviewed by Oliver.

Eighth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Convert SVG implementation files to use floats instead of doubles to match the spec/IDLs.
  • bindings/scripts/CodeGeneratorJS.pm:
  • ksvg2/svg/SVGAngle.cpp:
  • ksvg2/svg/SVGAnimatedTemplate.h:
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::getEndTime): (WebCore::SVGAnimationElement::getStartTime): (WebCore::SVGAnimationElement::getCurrentTime): (WebCore::SVGAnimationElement::getSimpleDuration):
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::parseViewBox):
  • ksvg2/svg/SVGLength.cpp: (WebCore::SVGLength::setValueAsString):
  • ksvg2/svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient):
  • ksvg2/svg/SVGMatrix.idl:
  • ksvg2/svg/SVGNumber.idl:
  • ksvg2/svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::parseSVG): (WebCore::SVGPathParser::calculateArc): (WebCore::SVGPathParser::svgLineToHorizontal): (WebCore::SVGPathParser::svgLineToVertical): (WebCore::SVGPathParser::svgCurveToCubicSmooth): (WebCore::SVGPathParser::svgCurveToQuadratic): (WebCore::SVGPathParser::svgCurveToQuadraticSmooth): (WebCore::SVGPathParser::svgArcTo):
  • ksvg2/svg/SVGParserUtilities.h:
  • ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::SVGPathElement): (WebCore::SVGPathElement::getTotalLength): (WebCore::SVGPathElement::getPointAtLength): (WebCore::SVGPathElement::getPathSegAtLength): (WebCore::SVGPathElement::createSVGPathSegMovetoAbs): (WebCore::SVGPathElement::createSVGPathSegMovetoRel): (WebCore::SVGPathElement::createSVGPathSegLinetoAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel): (WebCore::SVGPathElement::createSVGPathSegArcAbs): (WebCore::SVGPathElement::createSVGPathSegArcRel): (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel): (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel): (WebCore::SVGPathElement::svgMoveTo): (WebCore::SVGPathElement::svgLineTo): (WebCore::SVGPathElement::svgLineToHorizontal): (WebCore::SVGPathElement::svgLineToVertical): (WebCore::SVGPathElement::svgCurveToCubic): (WebCore::SVGPathElement::svgCurveToCubicSmooth): (WebCore::SVGPathElement::svgCurveToQuadratic): (WebCore::SVGPathElement::svgCurveToQuadraticSmooth): (WebCore::SVGPathElement::svgArcTo): (WebCore::SVGPathElement::parseMappedAttribute):
  • ksvg2/svg/SVGPathElement.h:
  • ksvg2/svg/SVGPathSegArc.cpp: (WebCore::SVGPathSegArcAbs::SVGPathSegArcAbs): (WebCore::SVGPathSegArcAbs::setX): (WebCore::SVGPathSegArcAbs::x): (WebCore::SVGPathSegArcAbs::setY): (WebCore::SVGPathSegArcAbs::y): (WebCore::SVGPathSegArcAbs::setR1): (WebCore::SVGPathSegArcAbs::r1): (WebCore::SVGPathSegArcAbs::setR2): (WebCore::SVGPathSegArcAbs::r2): (WebCore::SVGPathSegArcAbs::setAngle): (WebCore::SVGPathSegArcAbs::angle): (WebCore::SVGPathSegArcRel::SVGPathSegArcRel): (WebCore::SVGPathSegArcRel::setX): (WebCore::SVGPathSegArcRel::x): (WebCore::SVGPathSegArcRel::setY): (WebCore::SVGPathSegArcRel::y): (WebCore::SVGPathSegArcRel::setR1): (WebCore::SVGPathSegArcRel::r1): (WebCore::SVGPathSegArcRel::setR2): (WebCore::SVGPathSegArcRel::r2): (WebCore::SVGPathSegArcRel::setAngle): (WebCore::SVGPathSegArcRel::angle):
  • ksvg2/svg/SVGPathSegArc.h:
  • ksvg2/svg/SVGPathSegCurvetoCubic.cpp: (WebCore::SVGPathSegCurvetoCubicAbs::SVGPathSegCurvetoCubicAbs): (WebCore::SVGPathSegCurvetoCubicAbs::setX): (WebCore::SVGPathSegCurvetoCubicAbs::x): (WebCore::SVGPathSegCurvetoCubicAbs::setY): (WebCore::SVGPathSegCurvetoCubicAbs::y): (WebCore::SVGPathSegCurvetoCubicAbs::setX1): (WebCore::SVGPathSegCurvetoCubicAbs::x1): (WebCore::SVGPathSegCurvetoCubicAbs::setY1): (WebCore::SVGPathSegCurvetoCubicAbs::y1): (WebCore::SVGPathSegCurvetoCubicAbs::setX2): (WebCore::SVGPathSegCurvetoCubicAbs::x2): (WebCore::SVGPathSegCurvetoCubicAbs::setY2): (WebCore::SVGPathSegCurvetoCubicAbs::y2): (WebCore::SVGPathSegCurvetoCubicRel::SVGPathSegCurvetoCubicRel): (WebCore::SVGPathSegCurvetoCubicRel::setX): (WebCore::SVGPathSegCurvetoCubicRel::x): (WebCore::SVGPathSegCurvetoCubicRel::setY): (WebCore::SVGPathSegCurvetoCubicRel::y): (WebCore::SVGPathSegCurvetoCubicRel::setX1): (WebCore::SVGPathSegCurvetoCubicRel::x1): (WebCore::SVGPathSegCurvetoCubicRel::setY1): (WebCore::SVGPathSegCurvetoCubicRel::y1): (WebCore::SVGPathSegCurvetoCubicRel::setX2): (WebCore::SVGPathSegCurvetoCubicRel::x2): (WebCore::SVGPathSegCurvetoCubicRel::setY2): (WebCore::SVGPathSegCurvetoCubicRel::y2):
  • ksvg2/svg/SVGPathSegCurvetoCubic.h:
  • ksvg2/svg/SVGPathSegCurvetoCubicSmooth.cpp: (WebCore::SVGPathSegCurvetoCubicSmoothAbs::SVGPathSegCurvetoCubicSmoothAbs): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setX): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::x): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setY): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::y): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setX2): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::x2): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setY2): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::y2): (WebCore::SVGPathSegCurvetoCubicSmoothRel::SVGPathSegCurvetoCubicSmoothRel): (WebCore::SVGPathSegCurvetoCubicSmoothRel::setX): (WebCore::SVGPathSegCurvetoCubicSmoothRel::x): (WebCore::SVGPathSegCurvetoCubicSmoothRel::setY): (WebCore::SVGPathSegCurvetoCubicSmoothRel::y): (WebCore::SVGPathSegCurvetoCubicSmoothRel::setX2): (WebCore::SVGPathSegCurvetoCubicSmoothRel::x2): (WebCore::SVGPathSegCurvetoCubicSmoothRel::setY2): (WebCore::SVGPathSegCurvetoCubicSmoothRel::y2):
  • ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
  • ksvg2/svg/SVGPathSegCurvetoQuadratic.cpp: (WebCore::SVGPathSegCurvetoQuadraticAbs::SVGPathSegCurvetoQuadraticAbs): (WebCore::SVGPathSegCurvetoQuadraticAbs::setX): (WebCore::SVGPathSegCurvetoQuadraticAbs::x): (WebCore::SVGPathSegCurvetoQuadraticAbs::setY): (WebCore::SVGPathSegCurvetoQuadraticAbs::y): (WebCore::SVGPathSegCurvetoQuadraticAbs::setX1): (WebCore::SVGPathSegCurvetoQuadraticAbs::x1): (WebCore::SVGPathSegCurvetoQuadraticAbs::setY1): (WebCore::SVGPathSegCurvetoQuadraticAbs::y1): (WebCore::SVGPathSegCurvetoQuadraticRel::SVGPathSegCurvetoQuadraticRel): (WebCore::SVGPathSegCurvetoQuadraticRel::setX): (WebCore::SVGPathSegCurvetoQuadraticRel::x): (WebCore::SVGPathSegCurvetoQuadraticRel::setY): (WebCore::SVGPathSegCurvetoQuadraticRel::y): (WebCore::SVGPathSegCurvetoQuadraticRel::setX1): (WebCore::SVGPathSegCurvetoQuadraticRel::x1): (WebCore::SVGPathSegCurvetoQuadraticRel::setY1): (WebCore::SVGPathSegCurvetoQuadraticRel::y1):
  • ksvg2/svg/SVGPathSegCurvetoQuadratic.h: (WebCore::SVGPathSegCurvetoQuadraticRel::toString):
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.cpp: (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::SVGPathSegCurvetoQuadraticSmoothAbs): (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::setX): (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::x): (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::setY): (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::y): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::SVGPathSegCurvetoQuadraticSmoothRel): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::setX): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::x): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::setY): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::y):
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
  • ksvg2/svg/SVGPathSegLineto.cpp: (WebCore::SVGPathSegLinetoAbs::SVGPathSegLinetoAbs): (WebCore::SVGPathSegLinetoAbs::setX): (WebCore::SVGPathSegLinetoAbs::x): (WebCore::SVGPathSegLinetoAbs::setY): (WebCore::SVGPathSegLinetoAbs::y): (WebCore::SVGPathSegLinetoRel::SVGPathSegLinetoRel): (WebCore::SVGPathSegLinetoRel::setX): (WebCore::SVGPathSegLinetoRel::x): (WebCore::SVGPathSegLinetoRel::setY): (WebCore::SVGPathSegLinetoRel::y):
  • ksvg2/svg/SVGPathSegLineto.h:
  • ksvg2/svg/SVGPathSegLinetoHorizontal.cpp: (WebCore::SVGPathSegLinetoHorizontalAbs::SVGPathSegLinetoHorizontalAbs): (WebCore::SVGPathSegLinetoHorizontalAbs::setX): (WebCore::SVGPathSegLinetoHorizontalAbs::x): (WebCore::SVGPathSegLinetoHorizontalRel::SVGPathSegLinetoHorizontalRel): (WebCore::SVGPathSegLinetoHorizontalRel::setX): (WebCore::SVGPathSegLinetoHorizontalRel::x):
  • ksvg2/svg/SVGPathSegLinetoHorizontal.h:
  • ksvg2/svg/SVGPathSegLinetoVertical.cpp: (WebCore::SVGPathSegLinetoVerticalAbs::SVGPathSegLinetoVerticalAbs): (WebCore::SVGPathSegLinetoVerticalAbs::setY): (WebCore::SVGPathSegLinetoVerticalAbs::y): (WebCore::SVGPathSegLinetoVerticalRel::SVGPathSegLinetoVerticalRel): (WebCore::SVGPathSegLinetoVerticalRel::setY): (WebCore::SVGPathSegLinetoVerticalRel::y):
  • ksvg2/svg/SVGPathSegLinetoVertical.h:
  • ksvg2/svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::getPathSegAtLength):
  • ksvg2/svg/SVGPathSegList.h:
  • ksvg2/svg/SVGPathSegMoveto.cpp: (WebCore::SVGPathSegMovetoAbs::SVGPathSegMovetoAbs): (WebCore::SVGPathSegMovetoAbs::setX): (WebCore::SVGPathSegMovetoAbs::x): (WebCore::SVGPathSegMovetoAbs::setY): (WebCore::SVGPathSegMovetoAbs::y): (WebCore::SVGPathSegMovetoRel::SVGPathSegMovetoRel): (WebCore::SVGPathSegMovetoRel::setX): (WebCore::SVGPathSegMovetoRel::x): (WebCore::SVGPathSegMovetoRel::setY): (WebCore::SVGPathSegMovetoRel::y):
  • ksvg2/svg/SVGPathSegMoveto.h:
  • ksvg2/svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::svgPolyTo):
  • ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::viewport): (WebCore::SVGSVGElement::getCurrentTime):
  • ksvg2/svg/SVGStopElement.cpp: (WebCore::SVGStopElement::SVGStopElement): (WebCore::SVGStopElement::parseMappedAttribute):
  • ksvg2/svg/SVGStopElement.h:
  • ksvg2/svg/SVGTransform.cpp: (SVGTransform::translate): (SVGTransform::scale):
  • ksvg2/svg/SVGTransformDistance.cpp: (WebCore::SVGTransformDistance::addToSVGTransform): (WebCore::SVGTransformDistance::distance):
  • ksvg2/svg/SVGTransformable.cpp: (WebCore::SVGTransformable::parseTransformAttribute):
1:15 PM Changeset in webkit [23950] by andersca
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/5289718>
​http://bugs.webkit.org/show_bug.cgi?id=14437
CrashTracer: [REGRESSION] 76 crashes in Safari at com.apple.WebCore: WebCore::Frame::settings const + 6 (14437)


Add test from Alexey Proskuryakov.


  • plugins/plugin-remove-subframe-expected.txt: Added.
  • plugins/plugin-remove-subframe.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/5289718>
​http://bugs.webkit.org/show_bug.cgi?id=14437
CrashTracer: [REGRESSION] 76 crashes in Safari at com.apple.WebCore: WebCore::Frame::settings const + 6 (14437)


Based on a patch from Maxime Britto.


  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]): If the script caused the frame to go away, return nil. This can only happen if a plugin in a subframe destroys its frame.

(-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
ASSERT that this is only called on the main frame.

WebKit:

Reviewed by Darin.

  • WebView/WebView.mm: (-[WebView stringByEvaluatingJavaScriptFromString:]): ASSERT that the value returned isn't nil. It can't be nil when invoked on the main frame.
12:22 PM Changeset in webkit [23949] by sullivan
  • 2 edits in trunk/WebCore

Written by Darin, reviewed by me


  • fixed <rdar://problem/5249730> REGRESSION (Leopard, around 9A464): Safari opens the same local documents more than once due to canonicalization change
  • loader/mac/LoaderNSURLExtras.m: (canonicalURL): pass URL through KURL so we get KURL's version of canonicalization as well as NSURLProtocol's version of canonicalization
12:14 PM Changeset in webkit [23948] by weinig
  • 38 edits in trunk

LayoutTests:

Reviewed by Darin.

Seventh round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Change from double -> float caused some slight changes.
  • svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-units-02-b-expected.txt:
  • svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-02-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-03-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-04-b-expected.txt:
  • svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt:
  • svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
  • svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt:

WebCore:

Reviewed by Darin.

Seventh round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Adds more narrowPrecision functions to FloatPoint, FloatSize and FloatRect.
  • Changes over more implicit conversions to use new functions.
  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
  • platform/graphics/FloatPoint.cpp: (WebCore::FloatPoint::matrixTransform): (WebCore::FloatPoint::narrowPrecision):
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatRect.cpp: (WebCore::FloatRect::narrowPrecision):
  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatSize.cpp: (WebCore::FloatSize::narrowPrecision):
  • platform/graphics/FloatSize.h:
  • platform/graphics/Path.cpp: (WebCore::Path::createRoundedRectangle): (WebCore::Path::createRectangle): (WebCore::Path::createEllipse):
  • platform/graphics/mac/ColorMac.mm: (WebCore::nsColor):
  • platform/graphics/mac/IconMac.mm: (WebCore::Icon::paint):
  • platform/graphics/svg/cg/CgSupport.cpp: (WebCore::applyStrokeStyleToContext):
  • platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::CGShadingRefForRadialGradient): (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache): (WebCore::SVGPaintServerGradient::handleBoundingBoxModeAndGradientTransformation):
  • platform/graphics/svg/cg/SVGResourceMaskerCg.mm: (WebCore::applyLuminanceToAlphaFilter): (WebCore::applyExpandAlphatoGrayscaleFilter): (WebCore::transformImageIntoGrayscaleMask):
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::mapAbsolutePointToLocal):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::calcViewport):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::nodeAtPoint):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::relativeBBox):
10:55 AM Changeset in webkit [23947] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5261523>
Crash playing MP11 on cnbc.com


The WMP Netscape plugin still creates a window even when windowless mode is turned on. Work around this by
always removing the "windowlessvideo" parameter before passing it to the plugin.
According to ​http://msdn2.microsoft.com/en-us/library/bb249373.aspx, "The windowlessVideo property is not
supported for Netscape Navigator. Setting a value for this property in Navigator may yield unexpected results."


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWndProc): (WebCore::PluginViewWin::paint): (WebCore::PluginViewWin::invalidateRect): (WebCore::PluginViewWin::determineQuirks): (WebCore::PluginViewWin::setParameters): (WebCore::PluginViewWin::PluginViewWin): (WebCore::PluginViewWin::init):
  • plugins/win/PluginViewWin.h: (WebCore::):
9:21 AM Changeset in webkit [23946] by bdash
  • 4 edits in trunk/WebKit

2007-07-04 Mark Rowe <​mrowe@apple.com>

Unreviewed 64-bit build fixes.

  • WebCoreSupport/WebInspectorClient.mm: Let the compiler know that WebFrameView is a subclass of NSView.
  • WebView/WebDocumentInternal.h: Remove our preprocessor macro once we're done with it.
  • WebView/WebHTMLView.mm: (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Fix argument types.
8:29 AM Changeset in webkit [23945] by staikos
  • 2 edits in trunk/WebCore

Patch from Qing Zhao to fix sunken state improperly set.

6:42 AM Changeset in webkit [23944] by antti
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.


Test for REGRESSION: misplaced selection ring remains after link is no longer focused.
<rdar://problem/5205580>

  • fast/repaint/focus-layers-expected.checksum: Added.
  • fast/repaint/focus-layers-expected.png: Added.
  • fast/repaint/focus-layers-expected.txt: Added.
  • fast/repaint/focus-layers.html: Added.

WebCore:

Reviewed by Maciej.


REGRESSION: misplaced selection ring remains after link is no longer focused.
<rdar://problem/5205580>


Fix placement of selection ring when part of the ring is in a different layer.

  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::addFocusRingRects): Get coordinates right when moving to a different layer.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): Don't reset state variables when not necessary. When repaint() was called at the end of setSyle() it would get repaint rects wrong in some cases.
6:31 AM Changeset in webkit [23943] by antti
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Blind fix for CrashTracer: [USER] 25 crashes in Safari at com.apple.WebCore: WebCore::Frame::document const + 6
<rdar://problem/5263939>


No one has managed to reproduce this but it looks like null check is needed here. There are plausible ways
m_frame could be null for a live FrameView object.

  • page/FrameView.cpp: (WebCore::FrameView::needsLayout):
5:58 AM Changeset in webkit [23942] by rwlbuis
  • 2 edits in branches/feature-branch/LayoutTests

Correcting the pixel test result that was supposed to go in during r23849.

Jul 2, 2007:

10:52 PM Changeset in webkit [23941] by aroben
  • 2 edits in trunk/LayoutTests

Update the Windows Skipped list.

  • win/Skipped:
6:36 PM Changeset in webkit [23940] by aroben
  • 6 edits in trunk/LayoutTests

Update results after r23938.

  • fast/inline-block/14498-positionForCoordinates-expected.txt:
  • fast/table/click-near-anonymous-table-expected.txt:
  • svg/custom/pointer-events-image-expected.txt:
  • svg/custom/pointer-events-path-expected.txt:
  • svg/custom/text-hit-test-expected.txt:
5:53 PM Changeset in webkit [23939] by oliver
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/5098378> single-pixel image optimization needs to be rewritten to not depend on floating point bitmap
Tested by fast/replaced/image-solid-color-with-alpha.html

Switch from float to byte based bitmap when pulling the color from 1x1 pixel images so
that we can use the single pixel image optimisation in WebKit/win.

  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::checkForSolidColor):
4:54 PM Changeset in webkit [23938] by aroben
  • 3 edits
    2 adds in trunk

Fix Bug 14498: RenderContainer::positionForCoordinates contains an order of operations error

WebCore:

Fix Bug 14498: RenderContainer::positionForCoordinates contains an order of operations error
​http://bugs.webkit.org/show_bug.cgi?id=14498

There were two bugs:
1) xPos/yPos were flipped
2) + binds tighter than ?:, so the order of operations was incorrect

Reviewed by Darin.

Test: fast/inline-block/14498-positionForCoordinates.html

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::positionForCoordinates):

LayoutTests:

Test for Bug 14498: RenderContainer::positionForCoordinates contains an order of operations error
​http://bugs.webkit.org/show_bug.cgi?id=14498

Reviewed by Darin.

  • fast/inline-block/14498-positionForCoordinates-expected.txt: Added.
  • fast/inline-block/14498-positionForCoordinates.html: Added.
4:30 PM Changeset in webkit [23937] by darin
  • 6 edits in trunk/WebKit

Reviewed by Kevin Decker and Tim Hatcher.

  • fix <rdar://problem/5307880> some classes need finalize methods because of non-trivial work done in dealloc methods
  • DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer dealloc]): Added a comment about how this probably won't work under GC.
  • WebInspector/WebNodeHighlight.m: (-[WebNodeHighlight dealloc]): Ditto.
  • WebView/WebDataSource.mm: (+[WebDataSourcePrivate initialize]): Added. Makes finalize run on main thread. (-[WebDataSourcePrivate finalize]): Added. Calls deref on the document loader.
  • WebView/WebHTMLView.mm: (+[WebHTMLViewPrivate initialize]): Added. Makes finalize run on main thread. (-[WebHTMLViewPrivate finalize]): Added. Calls deref on promisedDragTIFFDataSource.
  • WebKit.xcodeproj/project.pbxproj: Let Xcode be Xcode.
4:29 PM Changeset in webkit [23936] by darin
  • 4 edits in trunk/WebCore

Reviewed by Kevin Decker and Tim Hatcher.

  • fix <rdar://problem/5307906> some classes need finalize methods because of non-trivial work done in dealloc methods
  • bindings/objc/DOMRGBColor.mm: (+[DOMRGBColor initialize]): Added. Tells finalizer to run on main thread, which is needed because we are sharing a CFDictionary here with no locking.
  • bridge/mac/WebCoreAXObject.mm: (+[WebCoreAXObject initialize]): Added. Tells finalizer to run on main thread. (-[WebCoreAXObject finalize]): Added. Calls detach.
  • WebCore.xcodeproj/project.pbxproj: Let Xcode do what it wants to do.
4:20 PM Changeset in webkit [23935] by weinig
  • 8 edits in trunk/WebCore

Reviewed by Darin.

Sixth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

Use new narrowPrecisionToFloat() and narrowPrecisionToCGFloat() where
appropriate.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setShadow): (WebCore::CanvasRenderingContext2D::applyShadow):
  • html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
  • ksvg2/svg/SVGAngle.cpp:
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseKeyNumbers): (WebCore::parseKeySplines): (WebCore::SVGAnimationElement::handleTimerEvent): (WebCore::SVGAnimationElement::updateAnimatedValueForElapsedSeconds):
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::buildPattern):
  • ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
  • platform/graphics/cg/AffineTransformCG.cpp: (WebCore::AffineTransform::AffineTransform): (WebCore::AffineTransform::setMatrix): (WebCore::AffineTransform::map): (WebCore::AffineTransform::setA): (WebCore::AffineTransform::setB): (WebCore::AffineTransform::setC): (WebCore::AffineTransform::setD): (WebCore::AffineTransform::setE): (WebCore::AffineTransform::setF): (WebCore::AffineTransform::scale): (WebCore::AffineTransform::rotate): (WebCore::AffineTransform::translate): (WebCore::AffineTransform::shear):
4:05 PM Changeset in webkit [23934] by kevino
  • 6 edits in branches/wx-port-alpha/trunk

Enable RTTI and exceptions for now, fix a linking issue with libjpeg on Win, and improve support for building with Python versions other than 2.5.

3:14 PM Changeset in webkit [23933] by sullivan
  • 2 edits in trunk/WebCore
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]): added a comment
1:47 PM Changeset in webkit [23932] by weinig
  • 5 edits
    1 move in trunk/WebCore

Rubberstamped by Darin.

Rename FloatConversionUtilities.h to FloatConversion.h.
Fix Win32 build.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/DeprecatedString.cpp:
  • platform/FloatConversion.h: Copied from platform/FloatConversionUtilities.h.
  • platform/FloatConversionUtilities.h: Removed.
  • platform/StringImpl.cpp:
1:41 PM Changeset in webkit [23931] by weinig
  • 12 edits
    1 add in trunk

JavaScriptCore:

Reviewed by Kevin McCullough.

Fourth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

Add custom piDouble and piFloat constants to use instead of M_PI.

  • kjs/math_object.cpp: (MathObjectImp::getValueProperty):
  • wtf/MathExtras.h: (wtf_atan2):

WebCore:

Reviewed by Darin.

Fifth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

Add toFloat() method to string classes and use it where appropriate.

  • WebCore.xcodeproj/project.pbxproj:
  • css/cssparser.cpp: (WebCore::CSSParser::lex):
  • ksvg2/svg/SVGAngle.cpp: (WebCore::SVGAngle::setValueAsString):
  • platform/AtomicString.h: (WebCore::AtomicString::toFloat):
  • platform/DeprecatedString.cpp: (WebCore::DeprecatedString::toFloat):
  • platform/DeprecatedString.h:
  • platform/FloatConversionUtilities.h: Added. (WebCore::narrowPrecisionToFloat): (WebCore::narrowPrecisionToCGFloat):
  • platform/PlatformString.h:
  • platform/String.cpp: (WebCore::String::toFloat):
  • platform/StringImpl.cpp: (WebCore::StringImpl::toFloat):
  • platform/StringImpl.h:
11:44 AM Changeset in webkit [23930] by weinig
  • 11 edits in trunk

JavaScriptCore:

Reviewed by Kevin McCullough.

Third round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

Add custom piDouble and piFloat constants to use instead of M_PI.

  • kjs/math_object.cpp: (MathObjectImp::getValueProperty):
  • wtf/MathExtras.h: (wtf_atan2):

WebCore:

Reviewed by Kevin McCullough.

Third round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

Use new piDouble and piFloat constants instead of M_PI.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::rotate):
  • ksvg2/svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::calculateArc):
  • platform/graphics/Path.cpp: (WebCore::pathLengthApplierFunction): (WebCore::Path::createEllipse):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc):
  • platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::setCurrentPage):
  • platform/graphics/svg/filters/cg/SVGFEHelpersCg.h:
  • rendering/RenderPath.cpp: (WebCore::drawMarkerWithData):
11:12 AM BuildingGdk edited by alp@atoker.com
Update deps and tasks (diff)
8:52 AM Changeset in webkit [23929] by brmorris
  • 2 edits in S60/trunk/WebKit

brad, rs'd by sachin.

DESC: merge r23928 to trunk: noise suppression - typo in version.mk
causing a scanlog error ..

  • group/version.mk: typo in RELEASABLES phase.
8:50 AM Changeset in webkit [23928] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

brad, rs'd by sachin.

DESC: noise suppression - typo in version.mk causing a scanlog error ..

  • group/version.mk: typo in RELEASABLES phase.
7:08 AM Changeset in webkit [23927] by bdash
  • 2 edits in trunk/WebKitSite

2007-07-02 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • quality/reduction.html:
12:42 AM Changeset in webkit [23926] by oliver
  • 2 edits in trunk/WebKit

Reviewed by Justin.

Fix for

<rdar://problem/5290113> WebKit does not correctly handle replacement ranges from the IM in -[WebHTMLView insertText:]
​http://bugs.webkit.org/show_bug.cgi?id=13664

We replicate the logic of -[WebHTMLView setMarkedText:selectedRange:] to handle the Input Method
feeding us a replacement string through insertText: so we can handle IMs that use insertText to
replace text.

  • WebView/WebHTMLView.mm: (-[WebHTMLView insertText:]):
Note: See TracTimeline for information about the timeline view.