Context Navigation

← Previous Period
Next Period →

Timeline

Jul 5, 2007:

11:14 PM Changeset in webkit [24043] by staikos

2 edits in trunk/WebKitTools

Add optional --qmake= and --qt arguments to force Qt builds and force with a
specific qmake binary

10:12 PM Changeset in webkit [24042] by staikos

5 edits in trunk

Switch USE(ICONDATABASE) to ENABLE(ICONDATABASE)

8:49 PM Changeset in webkit [24041] by sullivan

18 edits in trunk

WebCore:

Reviewed by Adam

WebCore part of fix for <rdar://problem/5315033>

rendering/RenderObject.h: replaced PaintRestrictionSelectionOnlyWhiteText with PaintRestrictionSelectionOnlyBlackText (WebCore::RenderObject::PaintInfo::PaintInfo): replaced forceWhiteText with forceBlackText

rendering/RenderObject.cpp: (WebCore::RenderObject::addLineBoxRects): added a useSelectionHeight parameter, which defaults to false; this method is unimplemented at this level so this has no effect.

rendering/RenderText.h:
rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects): added a useSelectionHeight parameter, which defaults to false. If true, use the vertical position and height returned by selectionRect rather than replacing it with the more tight-fitting position and height of the line box.

dom/Range.h:
dom/Range.cpp: (WebCore::Range::addLineBoxRects): added a useSelectionHeight parameter, which defaults to false. Passes this along to RenderObject.

page/Frame.h: renamed parameter to selectionImage
page/Frame.cpp: (WebCore::Frame::selectionTextRects): pass true for addLineBoxRects new useSelectionHeight parameter, so the rects returned by this new method will match the height that the selection would be painted here (WebCore::Frame::paint): updated for white->black name changes

page/mac/FrameMac.mm: (WebCore::Frame::selectionImage): updated for white->black name changes

rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintTextDecorations): updated for white->black name changes

rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): updated for white->black name changes

rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): updated for white->black name changes, and actually use black instead of white. This was the goal of all the name changes.

WebKit:

Reviewed by Adam

WebKit part of fix for <rdar://problem/5315033>

WebView/WebDocumentPrivate.h: new selectionImageForcingBlackText: method. selectionImageForcingWhiteText: is no longer used and was never in an official release of WebKit, so it could be removed, except that doing so would cause trouble for people using nightly WebKit with Safari 3.0 beta. So I left it in, but made it just force black text instead of white text, which will look different for those nightly WebKit/Safari 3.0 beta people but not break anything.

Misc/WebSearchableTextView.m: (-[WebSearchableTextView selectionImageForcingBlackText:]): new unimplemented protocol method for this obsolete class

WebView/WebHTMLView.mm: (-[WebHTMLView selectionImageForcingBlackText:]): calls through to WebCore the way selectionImageForcingWhiteText: used to (-[WebHTMLView selectionImageForcingWhiteText:]): now just calls selectionImageForcingBlackText:, thus not working as you would expect from the name

WebView/WebPDFView.mm: (-[WebPDFView selectionImageForcingBlackText:]): guts of old selectionImageForcingWhiteText:, but with black substituted for white (-[WebPDFView selectionImageForcingWhiteText:]): now just calls selectionImageForcingBlackText:, thus not working as you would expect from the name

8:33 PM Changeset in webkit [24040] by aroben

1 edit in trunk/LayoutTests/win/Skipped

Forgot the file extension

8:31 PM Changeset in webkit [24039] by aroben

2 edits in trunk/LayoutTests

Updated the Windows Skipped file

win/Skipped:

7:28 PM Changeset in webkit [24038] by andersca

2 edits in trunk/WebCore

Reviewed by Oliver.

Fix layout test failures.

loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): Don't make a representation if we're creating the initial document.

6:58 PM Changeset in webkit [24037] by aroben

4 edits
4 adds
4 deletes in trunk

Fix Bug 14388: Input in text fields limited to 1024 characters

WebCore:

2007-07-05 Alp Toker <alp.toker@collabora.co.uk>

Fix Bug 14388: Input in text fields limited to 1024 characters
http://bugs.webkit.org/show_bug.cgi?id=14388

Slightly modified by Adam Roben.

Reviewed by Adele.

Test: fast/forms/input-length.html

html/HTMLInputElement.cpp: Bump limit to 524288. (WebCore::HTMLInputElement::init): (WebCore::HTMLInputElement::parseMappedAttribute):
html/HTMLInputElement.h:

LayoutTests:

Added two tests for Bug 14388: Input in text fields limited to 1024 characters

fast/forms/input-maxlength-2.html is obsoleted by
fast/forms/input-maxlength.html.

Reviewed by Adele.

fast/forms/input-implicit-length-limit-expected.txt: Added.
fast/forms/input-implicit-length-limit.html: Added.
fast/forms/input-maxlength-2-expected.checksum: Removed.
fast/forms/input-maxlength-2-expected.png: Removed.
fast/forms/input-maxlength-2-expected.txt: Removed.
fast/forms/input-maxlength-2.html: Removed.
fast/forms/input-maxlength-expected.txt: Added.
fast/forms/input-maxlength.html: Added.

6:58 PM Changeset in webkit [24036] by aroben

2 edits in trunk/LayoutTests

Add another hanging test to the Leopard Skipped file

Rubberstamped by Adele.

mac/leopard/Skipped:

6:14 PM Changeset in webkit [24035] by kevino

1 edit in branches/wx-port-alpha/trunk/WebCore/platform/wx/RenderThemeWx.cpp

Selected text under MSW should be white too.

6:02 PM Changeset in webkit [24034] by justing

1 edit in trunk/LayoutTests/fast/frames/iframe-double-attach-expected.txt

Updating expected results for r24027.

5:56 PM Changeset in webkit [24033] by kevino

3 edits in branches/wx-port-alpha/trunk/WebKit/wx

Get RunScript working and add a way to test it in the demo.

5:40 PM Changeset in webkit [24032] by kevino

1 edit in branches/wx-port-alpha/trunk/WebKit/wx/bindings/python/webview.i

Add checks to ensure that you won't get a crash when trying to create a wxWebView or wxWebFrame without a running wx app instance.

5:34 PM Changeset in webkit [24031] by kevino

1 edit in branches/wx-port-alpha/trunk/WebCore/platform/graphics/wx/ColorWx.cpp

Fix wxColor->Color conversion.

4:12 PM Changeset in webkit [24030] by andersca

2 edits in trunk/WebCore

Build fix.

loader/FrameLoader.cpp: (WebCore::FrameLoader::init):

4:04 PM Changeset in webkit [24029] by ggaren

2 edits in trunk/LayoutTests

Forgot to add this file for the test for <rdar://problem/5303566> REGRESSION:
XMLHttpRequest.responseXML. Darin added a dummy file before -- here's the
real one.

fast/loader/resources/plist.app:

3:56 PM Changeset in webkit [24028] by weinig

8 edits in trunk/WebCore

Reviewed by Geoff.

Add focus, blur and close functions to DOMWindow implementation class
and move bindings from Window to JSDOMWindow.

bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
bindings/js/kjs_window.cpp: (KJS::Window::getOwnPropertySlot): (KJS::WindowFunc::callAsFunction):
bindings/js/kjs_window.h: (KJS::Window::):
bindings/scripts/CodeGeneratorJS.pm: Move prototype function declaration from the implementation to the header.
page/DOMWindow.cpp: (WebCore::DOMWindow::focus): (WebCore::DOMWindow::blur): (WebCore::DOMWindow::close):
page/DOMWindow.h:
page/DOMWindow.idl:

3:52 PM Changeset in webkit [24027] by justing

5 edits
4 adds in trunk

LayoutTests:

Reviewed by Harrison.

<rdar://problem/5279521> REGRESSION: In Mail, a crash occurs at WebCore::Range::startPosition() when attempting to apply alignment to selected image/text in message body

Demonstrates bug:

editing/style/5279521-expected.checksum: Added.
editing/style/5279521-expected.png: Added.
editing/style/5279521-expected.txt: Added.
editing/style/5279521.html: Added.

Fixed:

fast/forms/radio-check-click-and-drag-expected.txt:
fast/forms/textarea-type-spaces-expected.txt:

WebCore:

Reviewed by Harrison.

<rdar://problem/5279521> REGRESSION: In Mail, a crash occurs at WebCore::Range::startPosition() when attempting to apply alignment to selected image/text in message body

editing/TextIterator.cpp: (WebCore::TextIterator::exitNode): Previously emitted content shouldn't have to come from a text node in order to emit a '\n' as we exit block containers.

3:50 PM Changeset in webkit [24026] by andersca

2 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/5315284> REGRESSION: Leopard Launch Time - plugins are being accessed at startup.

Set a response that has a MIME type of "text/html" on the document loader so WebKit won't refresh the
plugin database looking for a plug-in that can handle the document's MIME type (which will be null anyway).

loader/FrameLoader.cpp: (WebCore::FrameLoader::init):

3:34 PM Changeset in webkit [24025] by andersca

2 edits in trunk/WebCore

Reviewed by Oliver.

<rdar://problem/5106788>
WebKit loads user style sheets too late as seen in Mail (breaks DataDetectors; Mail flashes wrong font)

Let the document know when the user style sheet is loading so that it try not to display anything
until the user style sheet has finished loading.

page/Frame.cpp: (WebCore::UserStyleSheetLoader::UserStyleSheetLoader): (WebCore::UserStyleSheetLoader::~UserStyleSheetLoader): (WebCore::UserStyleSheetLoader::setCSSStyleSheet): (WebCore::Frame::setUserStyleSheetLocation):

2:02 PM Changeset in webkit [24024] by aroben

2 edits in trunk/WebKit/win

Fix a leak in WebView::setToolTip

Reviewed by Beth.

WebView.cpp:

(WebView::setToolTip):

1:43 PM Changeset in webkit [24023] by thatcher

2 edits in trunk/WebKit

Reviewed by John.

<rdar://problem/5314993> Shiira 2.1 throws an exception open a new window: -window: unrecognized selector

Add an empty implementation of this method to prevent Shiira from throwing an exception.
Also log that this method is obsolete and the class will be removed.

WebInspector/WebInspector.mm: (-window):

1:16 PM Changeset in webkit [24022] by aroben

4 edits in trunk/WebKit/win

Fix Bug 14143: Tooltips not displayed on Windows
http://bugs.webkit.org/show_bug.cgi?id=14143
<rdar://problem/4719799>

Reviewed by Oliver.

WebChromeClient.cpp:

(WebChromeClient::setToolTip): Call up to WebView.

WebView.cpp:

(WebView::WebView): Initialize m_toolTipHwnd member.
(WebView::initWithFrame): Set up the tool tip window.
(initCommonControls): Added.
(WebView::initializeToolTipWindow): Added.
(WebView::setToolTip): Set the tool tip text and enable/disable the
tool tip.

WebView.h: Added/updated declarations.

1:11 PM Applications using WebKit edited by jalkut@red-sweater.com

Update MarsEdit info with info and link pertinent to Red Sweater … (diff)

11:09 AM Changeset in webkit [24021] by weinig

4 edits in trunk/WebCore

Reviewed by Darin.

Move JSDOMWindow overriding getOwnPropertySlot logic from KJS::Window
up into JSDOMWindow. No change in functionality so no testcase required.

bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
bindings/js/kjs_window.cpp: (KJS::Window::getOwnPropertySlot):
bindings/js/kjs_window.h:

10:51 AM Changeset in webkit [24020] by darin

3 edits
1 copy
2 adds in trunk/LayoutTests

tweaked IDN test and checked in both Tiger results and Leopard

fast/encoding/idn-security.html: Changed test to only test lowercase "a" since the behavior for uppercase letters has changed in the new ICU. Also added code to detect the older ICU and expect different results.

fast/encoding/idn-security-expected.txt: Regenerated results.

mac/leopard/fast/encoding/idn-security-expected.txt: Copied from fast/encoding/idn-security-expected.txt. The modified.

10:02 AM Changeset in webkit [24019] by weinig

2 edits in trunk/WebCore

Reviewed and Landed by Sam.

fix bug 14465 for window.showModalDialog

bindings/js/kjs_window.cpp: (KJS::parseModalDialogFeatures): (KJS::showModalDialog):

9:14 AM Changeset in webkit [24018] by weinig

2 edits
1 add in trunk/WebCore

Reviewed by Mitz.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14465
window.open() uses the literal "undefined" as the URL

bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): add checks for undefined and null values when setting the url.
manual-tests/open-url-undefined.html: Added.

6:51 AM Changeset in webkit [24017] by bdash

4 edits in trunk/WebCore

2007-07-05 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Rob Buis.

Rework FontData and FontPlatformData for the Gdk work to make valgrind
happy.

Move destroying of FontConfig and Cairo objects held in FontPlatformData
to FontData::platformDestroy. The ownership of these objects is held by
FontData. This is following the Mac and Qt port at least.

Currently it is possible that FontPlatformData will not create cairo resources
in this case at least make sure the variables are initialized to 0.
Initialize x,y of the cairo_glyph_t with zero to avoid extents.x_advance depending
on subtracing with not defined values.

FontPlatformData::hash. Using FontDescription is a bad idea as we don't have a clue
about how it is packed, if holes are present, etc. The FcPattern and the m_fontMatrix
should be good enough to describe the Font. All other objects are created using these
variables

Replace C-style casts with C++ casts, in this case reinterpret_cast.

platform/gdk/FontDataGdk.cpp: (WebCore::FontData::platformInit): Don't assert (WebCore::FontData::platformDestroy): Take over ownership (WebCore::FontData::platformWidthForGlyph): initialize (WebCore::FontData::setFont): be paranoid and assert
platform/gdk/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): Initialize everything (WebCore::FontPlatformData::hash): make valgrind happy and don't use m_fontDescription
platform/gdk/FontPlatformDataGdk.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData): FontData::platformDestroy will do this (WebCore::FontPlatformData::list): Don't use C-style casts. (WebCore::FontPlatformData::setFont): m_fontFace, m_fontMatrix, m_options might not be initialized (WebCore::FontPlatformData::operator==): Don't use C-style casts.

6:47 AM Changeset in webkit [24016] by bdash

4 edits in trunk/WebCore

2007-07-05 Alp Toker <alp.toker@collabora.co.uk>

Reviewed by Mark Rowe.

http://bugs.webkit.org/show_bug.cgi?id=14445
GraphicsContextCairo code style cleanup

Follow the cr naming convention for cairo_t*.
Remove trailing whitespace.
Replace C casts with C++ casts.
Avoid needless casts.

platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::platformContext): (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::drawRect): (WebCore::adjustLineToPixelBoundaries): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc): Save/restore the graphics state. (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::drawFocusRing): (WebCore::GraphicsContext::roundToDevicePixels): (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::origin): (WebCore::GraphicsContext::setPlatformStrokeThickness): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::setPlatformFont): (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::setLineCap): (WebCore::GraphicsContext::setLineJoin): (WebCore::GraphicsContext::setMiterLimit): (WebCore::GraphicsContext::setCompositeOperation): (WebCore::GraphicsContext::beginPath): (WebCore::GraphicsContext::addPath): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::scale):
platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::ImageBuffer):
platform/graphics/cairo/ImageCairo.cpp: Avoid the confusing ctxt/context naming scheme. (WebCore::BitmapImage::draw): (WebCore::Image::drawPattern):

6:45 AM Changeset in webkit [24015] by bdash

2 edits in trunk/WebCore

2007-07-05 Alp Toker <alp.toker@collabora.co.uk>

Reviewed by Mark Rowe.

http://bugs.webkit.org/show_bug.cgi?id=14531
Cairo SVGImage::nativeImageForCurrentFrame() has no return

Return the Cairo surface from the frame cache.

Also add a fall-through else macro with notImplemented() so that future
ports do not make the same mistake.

platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::nativeImageForCurrentFrame):

6:43 AM Changeset in webkit [24014] by bdash

2 edits in trunk/WebCore

2007-07-05 Alp Toker <alp.toker@collabora.co.uk>

Reviewed by Mark Rowe.

http://bugs.webkit.org/show_bug.cgi?id=14513
Cairo animated GIF support is broken

Implement ImageSource::frameIsCompleteAtIndex() to enable animated GIFs.

platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::frameIsCompleteAtIndex):

2:15 AM Changeset in webkit [24013] by aroben

1 edit
3 adds in trunk/LayoutTests

Add a Skipped file for Leopard.

Reviewed by Mark.

mac/leopard/Skipped: Added.

1:21 AM Changeset in webkit [24012] by aroben

2 edits in trunk/WebKitTools

Warn about tests in the Skipped file that succeeded

Scripts/run-webkit-tests:

1:10 AM Changeset in webkit [24011] by aroben

1 edit
1 delete in trunk/WebKitTools

Removed unused install-win-extras script

Rubberstamped by Mark.

Scripts/install-win-extras: Removed.

12:51 AM Changeset in webkit [24010] by aroben

2 edits in trunk/WebKitTools

Show the test's extension in the results page

Scripts/run-webkit-tests:

12:49 AM Changeset in webkit [24009] by aroben

2 edits in trunk/WebKitTools

Add more options for controlling the interpretation of the Skipped file

Reviewed by Mark.

Scripts/run-webkit-tests:

Jul 4, 2007:

11:56 PM Changeset in webkit [24008] by aroben

2 edits in trunk/WebKitTools

Add --skipped-only option to run-webkit-tests

When this option is specified, only those tests listed in the Skipped
file are run.

Reviewed by Mark.

Scripts/run-webkit-tests:

11:42 PM Changeset in webkit [24007] by aroben

2 edits in trunk/WebKitTools

Clean up/alphabetize the run-webkit-tests help message

Scripts/run-webkit-tests:

11:24 PM Changeset in webkit [24006] by aroben

3 edits in trunk/WebKitTools

Enable a Leopard-specific Skipped list.

Reviewed by Mark.

Scripts/run-webkit-tests: Check for Leopard.
Scripts/webkitdirs.pm: Added isTiger/isLeopard.

11:12 PM Changeset in webkit [24005] by bdash

2 edits in trunk

... and it was reviewed by Adam.

11:08 PM Changeset in webkit [24004] by bdash

3 edits
9 adds in trunk

2007-07-04 Matt Perry <mpComplete@gmail.com>

Fix for http://bugs.webkit.org/show_bug.cgi?id=13400
Bug 13400: REGRESSION (r20809-20814): No back entry created for navigations created by assigning to document.location
<rdar://problem/5153025>

Treat userGesture as always true for setLocation, forcing a back/forward
entry to be created.

bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::setLocation):

2007-07-04 Matt Perry <mpComplete@gmail.com>

Test for http://bugs.webkit.org/show_bug.cgi?id=13400
Bug 13400: REGRESSION (r20809-20814): No back entry created for navigations created by assigning to document.location
<rdar://problem/5153025>

Test that assigning to document.location in various ways adds an
item to the back/forward list.

http/tests/navigation/document-location-click-expected.txt: Added.
http/tests/navigation/document-location-click-timeout-expected.txt: Added.
http/tests/navigation/document-location-click-timeout.html: Added.
http/tests/navigation/document-location-click.html: Added.
http/tests/navigation/document-location-mouseover-expected.txt: Added.
http/tests/navigation/document-location-mouseover.html: Added.
http/tests/navigation/document-location-onload-expected.txt: Added.
http/tests/navigation/document-location-onload.html: Added.
http/tests/navigation/resources/document-location.js: Added.

11:04 PM Changeset in webkit [24003] by aroben

2 edits in trunk/WebCore

Restore MouseEventWithHitTestResults::targetNode's old behavior

Reviewed by Mark.

Fixes fast/images/imagemap-case and fast/replace/image-map.

page/MouseEventWithHitTestResults.cpp:

(WebCore::MouseEventWithHitTestResults::targetNode): Use the inner
node, not the inner non-shared node.

10:21 PM Changeset in webkit [24002] by aroben

5 edits in trunk/WebCore

Mac, Qt, and Gdk build fixes.

page/EventHandler.h:
page/gdk/EventHandlerGdk.cpp:
page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passSubframeEventToSubframe):

page/qt/EventHandlerQt.cpp:

8:23 PM Changeset in webkit [24001] by aroben

3 edits in trunk/WebCore

Fix the Qt/Gdk builds.

page/gdk/EventHandlerGdk.cpp:
page/qt/EventHandlerQt.cpp:

8:00 PM Changeset in webkit [24000] by aroben

20 edits in trunk

Move tooltip logic down into WebCore so that it can be shared cross-platform

WebCore:

Move tooltip logic down into WebCore so that it can be shared cross-platform

Reviewed by Sam.

page/Chrome.cpp: (WebCore::Chrome::setToolTip): Added.
page/Chrome.h:
page/ChromeClient.h:
page/EventHandler.cpp: (WebCore::EventHandler::mouseMoved): Call Chrome::setToolTip.
platform/graphics/svg/SVGImageEmptyClients.h:

Added stubs for Gdk:

platform/gdk/ChromeClientGdk.h:
platform/gdk/TemporaryLinkStubs.cpp: (ChromeClientGdk::setToolTip):

WebKit:

Move tooltip logic down into WebCore so that it can be shared cross-platform

Reviewed by Sam.

WebCoreSupport/WebChromeClient.h:
WebCoreSupport/WebChromeClient.mm: (WebChromeClient::setToolTip): Added.
WebView/WebHTMLView.mm: Removed _resetCachedWebPreferences. (-[WebHTMLView _updateMouseoverWithEvent:]): Removed tooltip code. (-[WebHTMLView initWithFrame:]): Removed call to _resetCachedWebPreferences. (-[WebHTMLView setDataSource:]): Ditto.
WebView/WebHTMLViewInternal.h: Removed showsURLsInToolTips ivar.
WebView/WebHTMLViewPrivate.h: Added declaration for _setTooltip so that WebChromeClient can call it.

WebKit/win:

Added a stub for WebChromeClient::setToolTip

Reviewed by Sam.

WebChromeClient.cpp:
WebChromeClient.h:

WebKitQt:

Added a stub for ChromeClientQt::setToolTip

Reviewed by Sam.

WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::setToolTip):
WebCoreSupport/ChromeClientQt.h:

8:00 PM Changeset in webkit [23999] by aroben

8 edits in trunk

Add/initialize Settings::showsURLsInToolTips

WebCore:

Add Settings::showsURLsInToolTips

Reviewed by Sam.

WebCore.exp:
page/Settings.cpp: (WebCore::Settings::Settings):
page/Settings.h:

WebKit:

Initialize Settings::showsURLsInToolTips

Reviewed by Sam.

WebView/WebView.mm: (-[WebView _updateWebCoreSettingsFromPreferences:]):

WebKit/win:

Initialize Settings::showsURLsInToolTips

Reviewed by Sam.

WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences):

8:00 PM Changeset in webkit [23998] by aroben

9 edits in trunk

Move logic for calling mouseDidMoveOverElement into WebCore

WebCore:

Move logic for calling mouseDidMoveOverElement into WebCore

Reviewed by Sam.

page/EventHandler.cpp: (WebCore::EventHandler::mouseMoved): Added. Calls Chrome::mouseDidMoveOverElement. (WebCore::EventHandler::handleMouseMoveEvent): Now takes an optional HitTestResult* parameter which is used to communicate to the caller the node the mouse is over.
page/EventHandler.h:
page/mac/EventHandlerMac.mm: (WebCore::EventHandler::mouseMoved): Changed to call the overloaded mouseMoved(). (WebCore::EventHandler::passMouseMoveEventToSubframe): Pass hoveredNode through to the subframe so we can get the deepest node hovered, not just the node's parent frame.
page/win/EventHandlerWin.cpp: (WebCore::EventHandler::passMouseMoveEventToSubframe): Ditto.

WebKit:

Removed call to mouseDidMoveOverElement now that WebCore handles it

Reviewed by Sam.

WebView/WebHTMLView.mm: (-[WebHTMLView _updateMouseoverWithEvent:]):

WebKit/win:

Removed call to mouseDidMoveOverElement now that WebCore handles it

Reviewed by Sam.

WebView.cpp: (WebView::handleMouseEvent):

8:00 PM Changeset in webkit [23997] by aroben

16 edits in trunk

Add Chrome::mouseDidMoveOverElement

WebCore:

Add Chrome::mouseDidMoveOverElement

This does the work of calling up to the ChromeClient (which will call
the UI delegate).

Reviewed by Sam.

page/Chrome.cpp: (WebCore::Chrome::mouseDidMoveOverElement): Added.
page/Chrome.h:
page/ChromeClient.h:
platform/graphics/svg/SVGImageEmptyClients.h: Updated for change to ChromeClient.
platform/gdk/ChromeClientGdk.h:
platform/gdk/TemporaryLinkStubs.cpp: (ChromeClientGdk::mouseDidMoveOverElement):

WebKit:

Add WebChromeClient::mouseDidMoveOverElement

This is not called yet.

Reviewed by Sam.

WebCoreSupport/WebChromeClient.h:
WebCoreSupport/WebChromeClient.mm:

WebKit/win:

Add WebChromeClient::mouseDidMoveOverElement

This is not called yet.

Reviewed by Sam.

WebChromeClient.cpp: (WebChromeClient::mouseDidMoveOverElement):
WebChromeClient.h:

WebKitQt:

Added a stub for ChromeClientQt::mouseDidMoveOverElement

Reviewed by Sam.

WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::mouseDidMoveOverElement):
WebCoreSupport/ChromeClientQt.h:

8:00 PM Changeset in webkit [23996] by aroben

4 edits in trunk/WebCore

Changed PlatformMouseEvent to store the modifier flags of the event

Reviewed by Sam.

platform/PlatformMouseEvent.h:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

platform/mac/PlatformMouseEventMac.mm:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

platform/win/PlatformMouseEventWin.cpp:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

7:59 PM Changeset in webkit [23995] by aroben

4 edits in trunk/WebCore

Add HitTestResult::setToNonShadowAncestor

Reviewed by Sam.

page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint): Moved logic into
HitTestResult::setToNonShadowAncestor.

rendering/HitTestResult.cpp:

(WebCore::HitTestResult::setToNonShadowAncestor):

rendering/HitTestResult.h:

7:59 PM Changeset in webkit [23994] by aroben

4 edits in trunk/WebCore

Change MouseEventWithHitTestResults to hold onto a HitTestResult

Reviewed by Sam.

dom/Document.cpp:

(WebCore::Document::prepareMouseEvent):

page/MouseEventWithHitTestResults.cpp:

(WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
(WebCore::MouseEventWithHitTestResults::targetNode):
(WebCore::MouseEventWithHitTestResults::localPoint):
(WebCore::MouseEventWithHitTestResults::scrollbar):

page/MouseEventWithHitTestResults.h:

(WebCore::MouseEventWithHitTestResults::event):
(WebCore::MouseEventWithHitTestResults::hitTestResult):

7:52 PM Changeset in webkit [23993] by darin

3 edits in trunk/LayoutTests

take out infinity tests from the test for bug 5292262 (see below) for now since they give different results on PowerPC and Intel and are not an important part of the intent of this test anyway; the bug was about normal numbers, not edge cases like infinity

If we want to test the infinity behavior, we should make a separate test later.

fast/objc/longlongTest-expected.txt: Removed results from infinity tests.
fast/objc/longlongTest.html: Removed infinity tests.

6:16 PM Changeset in webkit [23992] by pewtermoose

2 edits in trunk/WebCore

Not reviewed, gdk build fix.

platform/gdk/FrameGdk.cpp:

3:54 PM Changeset in webkit [23991] by antti

3 edits
2 adds in trunk

LayoutTests:

Reviewed by John.

Test for Repro crash due to infinite recursion in HTMLParser::handleError @ youos.com
<rdar://problem/5237811>

fast/table/incomplete-table-in-fragment-hang-expected.txt: Added.
fast/table/incomplete-table-in-fragment-hang.html: Added.

WebCore:

Reviewed by John.

Fix Repro crash due to infinite recursion in HTMLParser::handleError @ youos.com
<rdar://problem/5237811>

It is possible to add table parts (thead etc) without table ancestor to a document fragment. If a new table element
was added to such a part, as in

div.innerHTML = '<tbody><table>';

the parser error handling code would try to pop the previous table as normal. However since
the table does not actually exist nothing would happen and parser would go to infinite recursion.

Solution here is to pop table parts one by one when handling the error inside a fragment instead of trying to pop
the table straight away (as it might not exist).

html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):

2:57 PM Changeset in webkit [23990] by kevino

2 edits in branches/wx-port-alpha/trunk/WebCore/platform/graphics/wx

Fix transparent image support on Windows, and likely GTK too.

2:33 PM Changeset in webkit [23989] by staikos

2 edits in trunk/WebCore

Patch from Qing Zhao to fix combobox rendering

2:23 PM Changeset in webkit [23988] by staikos

3 edits in trunk/WebCore

Compile

1:04 PM Changeset in webkit [23987] by weinig

6 edits
2 adds in trunk

LayoutTests:

Reviewed by Mitz.

Test for http://bugs.webkit.org/show_bug.cgi?id=14504
REGRESSION (r23573): Amazon Book Excerpt can not be viewed in recent nightly

fast/dom/Window/window-property-shadowing-expected.txt: Added.
fast/dom/Window/window-property-shadowing.html: Added.

WebCore:

Reviewed by Mitz.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14504
REGRESSION (r23573): Amazon Book Excerpt can not be viewed in recent nightly

Made it possible (again) to shadow window properties with local variable names.

Test: fast/dom/Window/window-property-shadowing.html

bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customPut):
bindings/js/kjs_window.cpp: (KJS::Window::put):
bindings/scripts/CodeGeneratorJS.pm:
page/DOMWindow.idl:

11:37 AM Changeset in webkit [23986] by aliceli1

10 edits
3 adds in trunk/WebCore

Reviewed by Adam.

Fixed <rdar://problem/5225119> support smart pasting on Windows

WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:

Added new files

editing/SmartReplace.cpp: Added. (WebCore::isCharacterSmartReplaceExempt):

Added non-CF implementation placeholder

editing/SmartReplace.h: Added.
editing/SmartReplaceCF.cpp: Added. (WebCore::getSmartSet): (WebCore::isCharacterSmartReplaceExempt):

Added new implementation

bridge/win/FrameWin.cpp:
page/Frame.h:
page/mac/FrameMac.mm:

Removed old declaration and implementation

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):

Changed to call the new function instead of old

page/mac/WebCoreFrameBridge.h:
page/mac/WebCoreFrameBridge.mm:

Removed old declaration and implementation

(-[WebCoreFrameBridge smartInsertForString:replacingRange:beforeString:afterString:]):

Changed to call the new function instead of old

platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::Pasteboard):

Register new clipboard format

(WebCore::Pasteboard::writeSelection):

Set data for smartpaste format on clipboard

(WebCore::Pasteboard::canSmartReplace):

Added non-stub implementation

11:33 AM Changeset in webkit [23985] by thatcher

2 edits in trunk

Reenable some code for 64-bit now that <rdar://problem/5311640> and <rdar://problem/5311690> are resolved.

8:15 AM Changeset in webkit [23984] by staikos

2 edits in trunk/WebCore

Patch from Qing Zhao: Similar to the PlatformScrollbar fixes, adjust the
painter to make the styler draw all subcontrols, and in this case the focus
rect, in the proper location

3:56 AM Changeset in webkit [23983] by bdash

3 edits in trunk/WebCore

2007-07-04 Mitz Pettel <mitz@webkit.org>

Reviewed by Maciej.

fix http://bugs.webkit.org/show_bug.cgi?id=14495 REGRESSION: Wrong cursor is displayed during drag and drop when text is selected <rdar://problem/5312384>

No test possible because DumpRenderTree cannot query the current cursor.

page/EventHandler.cpp: (WebCore::EventHandler::selectCursor): Changed into a member function and added that if the last mouse down event could not have started a selection, then the cursor should not change to an I-beam unconditionally. (WebCore::EventHandler::handleMouseMoveEvent):
page/EventHandler.h:

3:52 AM Changeset in webkit [23982] by bdash