Context Navigation

← Previous Period
Next Period →

Timeline

Jul 7, 2007:

6:40 PM Changeset in webkit [24093] by weinig

4 edits in trunk

LayoutTests:

Reviewed by Oliver Hunt.

update results after removing extraneous calls to isSafeScript for readonly attributes.

http/tests/security/cross-frame-access-expected.txt:

WebCore:

Reviewed by Oliver Hunt.

Bailout early in Window::put() if attribute is readonly to avoid
extra calls to isSafeScript().

bindings/js/kjs_window.cpp: (KJS::Window::put):

2:35 PM Changeset in webkit [24092] by darin

4 edits in trunk/LayoutTests

updated results (I changed the test at the last minute, but didn't regenerate results)

fast/canvas/fill-stroke-clip-reset-path-expected.checksum: Updated.
fast/canvas/fill-stroke-clip-reset-path-expected.png: Updated.
fast/canvas/fill-stroke-clip-reset-path-expected.txt: Updated.

1:42 PM Changeset in webkit [24091] by darin

4 edits
4 adds in trunk

LayoutTests:

test for <rdar://problem/5292364> REGRESSION: ZX Spectrum 3.0 widget - graphic anomalies in widget window frame

fast/canvas/fill-stroke-clip-reset-path-expected.checksum: Added.
fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
fast/canvas/fill-stroke-clip-reset-path-expected.txt: Added.
fast/canvas/fill-stroke-clip-reset-path.html: Added.

WebCore:

Reviewed by Oliver Hunt.

fix <rdar://problem/5292364> REGRESSION: ZX Spectrum 3.0 widget - graphic anomalies in widget window frame

Updated Dashboard quirk so it affects fill, stroke, and clip, rather than just stroke.

Test: fast/canvas/fill-stroke-clip-reset-path.html

html/CanvasRenderingContext2D.h: Added clearPathForDashboardBackwardCompatibilityMode.
html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::clearPathForDashboardBackwardCompatibilityMode): Added. (WebCore::CanvasRenderingContext2D::fill): Call the new function. (WebCore::CanvasRenderingContext2D::stroke): Replaced in-line code with a call to the new function. (WebCore::CanvasRenderingContext2D::clip): Call the new function.

1:14 PM Changeset in webkit [24090] by darin

4 edits
4 adds in trunk

LayoutTests:

Reviewed by Darin.

Testcase for:
http://bugs.webkit.org/show_bug.cgi?id=8994
Canvas doesn't reset on resize

fast/canvas/canvas-resize-reset-expected.checksum: Added.
fast/canvas/canvas-resize-reset-expected.png: Added.
fast/canvas/canvas-resize-reset-expected.txt: Added.
fast/canvas/canvas-resize-reset.html: Added.

WebCore:

Reviewed and tweaked by Darin.

http://bugs.webkit.org/show_bug.cgi?id=8994
Canvas doesn't reset on resize

Also reset the rendering context when resetting the canvas.

html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::reset): (WebCore::HTMLCanvasElement::drawingContext):

3:11 AM Changeset in webkit [24089] by ap

2 edits in trunk/LayoutTests

Fixed a mismatch between test output and expected results (a typo that was only fixed in the former).

fast/loader/early-load-cancel-expected.txt:

3:00 AM Changeset in webkit [24088] by ap

7 edits
5 adds in trunk

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=14525
Support exslt:node-set()

Test: fast/xsl/exslt-node-set.xml

xml/XSLTExtensions.cpp: Added. (WebCore::exsltNodeSetFunction): A copy of exslt:node-set() implementation from libexslt 1.1.11 (shipped with Tiger). (WebCore::registerXSLTExtensions): This function registers any WebCore-provided extensions on a context. Currently, the only extension is exslt:node-set().
xml/XSLTExtensions.h: Added.

xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::transformToString): Register extensions when creating a context.

WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl: Add XSLTExtensions.{h,cpp} to projects.

Jul 6, 2007:

11:29 PM Changeset in webkit [24087] by mjs

3 edits
3 adds in trunk

LayoutTests:

Reviewed by Oliver.

test case for <rdar://problem/5133420> ASSERT in WebDocumentLoaderMac::decreaseLoadCount() un-discarding Gmail message

fast/loader/early-load-cancel-expected.txt: Added.
fast/loader/early-load-cancel.html: Added.
fast/loader/resources/early-load-cancel-inner.html: Added.

WebCore:

Reviewed by Oliver.

fixed <rdar://problem/5133420> ASSERT in WebDocumentLoaderMac::decreaseLoadCount() un-discarding Gmail message

test case: fast/loader/early-load-cancel.html

loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didCancel): Don't send cancel-related client callbacks if we never even sent willSendRequest because we were deferred.

9:28 PM Changeset in webkit [24086] by bdash

2 edits in trunk/WebKitTools

2007-07-07 Mark Rowe <mrowe@apple.com>

Reviewed by Oliver.

DumpRenderTree/DumpRenderTree.m: (convertWebResourceResponseToDictionary): Fix leak of two NSMutableString's introduced in r24076.

9:01 PM Changeset in webkit [24085] by oliver

13 edits in trunk

WebCore:

Reviewed by Maciej.

Pulled a number of methods from WebKit and WebCoreFrameBridge into
C++ objects.

WebCore.exp:
WebCore.xcodeproj/project.pbxproj:
editing/Editor.cpp: (WebCore::Editor::replaceMarkedText):

From -[WebCoreFrameBridge replaceMarkedTextWithText:]

editing/Editor.h:
page/Frame.cpp: (WebCore::Frame::setMarkedTextRange):

Pulled platform independent logic from Mac specific implementation

(WebCore::Frame::selectRangeInMarkedText):

Converted from -[WebHTMLView _selectRangeInMarkedText:]

page/Frame.h:
page/mac/FrameMac.mm: (WebCore::Frame::setMarkedTextRange):

Now only does Mac specific logic when manipulating initial
NSAttributedString

page/mac/WebCoreFrameBridge.h:
page/mac/WebCoreFrameBridge.mm:

Removed -[WebCoreFrameBridge replaceMarkedTextWithText:]

WebKit:

Reviewed by Maciej.

<rdar://problem/5318756> Need to refactor IM/Marked text code to share logic with windows.

Moved a number of methods from WebHTMLView into WebCore.
Replaced bridge methods with calls directly into WebCore objects.

WebKit.xcodeproj/project.pbxproj:
WebView/WebHTMLView.mm: (-[WebHTMLView setMarkedText:selectedRange:]): Now calls WebCore object methods directly, rather than calling via the bridge.

7:37 PM Changeset in webkit [24084] by bdash

7 edits
4 adds in trunk

2007-07-06 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=14545 REGRESSION (r21854-r21869): Repro crash in RenderBlock::updateFirstLetter @ nola.com/rose/

Test: fast/css/first-letter-capitalized.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter): Moved the call to setFirstLetter further down so that the first letter is not destroyed if a text transform is applied to the remaining text fragment when it is add to the render tree.
rendering/RenderText.cpp: (WebCore::RenderText::previousCharacter): Factored out of setTextInternal. (WebCore::RenderText::setTextInternal): Changed to call previousCharacter().
rendering/RenderText.h:
rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::previousCharacter): Override to return the character in the original string before the start of the fragment.
rendering/RenderTextFragment.h:

2007-07-06 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

test for http://bugs.webkit.org/show_bug.cgi?id=14545 REGRESSION (r21854-r21869): Repro crash in RenderBlock::updateFirstLetter @ nola.com/rose/

fast/css/first-letter-capitalized-expected.checksum: Added.
fast/css/first-letter-capitalized-expected.png: Added.
fast/css/first-letter-capitalized-expected.txt: Added.
fast/css/first-letter-capitalized.html: Added.

7:35 PM Changeset in webkit [24083] by bdash

2 edits in trunk/WebCore

2007-07-06 Mitz Pettel <mitz@webkit.org>

Reviewed by Beth.

fix http://bugs.webkit.org/show_bug.cgi?id=14536 Unnecessary layout done when mousing down in text field

No test possible because there is no change in functionality.

rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setStyle): Reset the height and the width in the old style to avoid getting a layout hint as a result of having mutated the old style during layout. (WebCore::RenderTextControl::layout): Update children's layout if an inner block's dimensions should change. This need for layout was previously masked by the bug.

6:02 PM Changeset in webkit [24082] by darin

2 edits in trunk/LayoutTests

mac/leopard/Skipped: Updated bug numbers for some bugs that were duplicates.

5:27 PM Changeset in webkit [24081] by beidson

2 edits in trunk/WebCore

Fix builds that use IconDatabaseNone.cpp - better, this time

loader/icon/IconDatabaseNone.cpp: (WebCore::IconDatabase::isOpen):

5:20 PM Changeset in webkit [24080] by beidson

2 edits in trunk/WebCore

Fix builds that use IconDatabaseNone.cpp

loader/icon/IconDatabaseNone.cpp: (WebCore::IconDatabase::databasePath):

4:48 PM Changeset in webkit [24079] by thatcher

3 edits in trunk/LayoutTests

Reviewed by Adam.

<rdar://problem/5313506> Some attributed string layout tests have an extra space character on Leopard

Leopard serializes empty attribute dictionaries as "{ }", turn these into "{}" to match Tiger.

fast/text/attributed-substring-from-range-001.html:
mac/leopard/Skipped: Don't skip this test anymore.

4:44 PM Changeset in webkit [24078] by thatcher

1 edit in trunk/WebKitTools/ChangeLog

Fix typo.

4:43 PM Changeset in webkit [24077] by sullivan

8 edits in trunk

WebCore:

Reviewed by Brady

WebCore part of fix for: <rdar://problem/5310739> Time Machine shouldn't back up WebKit's icon database files

loader/icon/IconDatabase.h:
loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::isOpen): made this method const (necessary to make IconDatabase::databasePath const) (WebCore::IconDatabase::databasePath): new method, returns SQLDatabase's path if open, otherwise empty string

loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::open): don't append a null character to the m_path ivar. The appended null character was making the path() method return a String with a trailing null, which is bad. However, there were no callers to the path() method until now. Instead of appending a null character to the ivar, use charactersWithNullTermination() instead of characters() when opening the database.

loader/icon/SQLDatabase.h: (WebCore::SQLDatabase::isOpen): made this method const (necessary to make IconDatabase::databasePath const) (WebCore::SQLDatabase::path): made this method const (not required for these changes, but seemed worth doing at the same time)

WebCore.exp: added symbol for IconDatabase::databasePath

WebKit:

Reviewed by Brady

WebKit part of fix for: <rdar://problem/5310739> Time Machine shouldn't back up WebKit's icon database files

Misc/WebIconDatabase.mm: (-[WebIconDatabase init]): Use CSBackupSetItemExcluded to tell Time Machine not to back up the icon database file

4:40 PM Changeset in webkit [24076] by andersca

15 edits in trunk

LayoutTests:

Reviewed by David Kilzer.

<rdar://problem/5313502>
Many webarchive tests fail due to different NSURLResponse serialization on Leopard

mac/leopard/Skipped:
webarchive/archive-with-unencoded-url-expected.txt:
webarchive/test-body-background-expected.txt:
webarchive/test-duplicate-resources-expected.txt:
webarchive/test-frameset-expected.txt:
webarchive/test-img-src-expected.txt:
webarchive/test-input-src-expected.txt:
webarchive/test-link-href-expected.txt:
webarchive/test-object-data-expected.txt:
webarchive/test-script-src-expected.txt:
webarchive/test-table-background-expected.txt:
webarchive/test-td-background-expected.txt:

WebKitTools:

Reviewed by David Kilzer.

<rdar://problem/5313502>
Many webarchive tests fail due to different NSURLResponse serialization on Leopard

Don't dump the serialized form of NSURLResponse. Instead, create a dictionary with the
response's attributes. Also change the JavaScript MIME type to be "text/javascript".

DumpRenderTree/DumpRenderTree.m: (convertMIMEType): (convertWebResourceDataToString): (convertWebResourceResponseToDictionary): (serializeWebArchiveToXML):

4:22 PM Changeset in webkit [24075] by thatcher

5 edits in trunk

LayoutTests:

Reviewed by Oliver.

<rdar://problem/5313506> Some attributed string layout tests have an extra space character on Leopard

Don't dump the attributed string's description, this isn't helpfull for the test. Just log
the attribute names at index 0, which we expect to be nothing, to make sure the string
has no attributes.

fast/forms/attributed-strings-expected.txt:
fast/forms/attributed-strings.html:

WebKitTools:

Reviewed by Oliver.

Initlize the NSMutableAttributedString directly instead of creating
a NSAttributedString first.

DumpRenderTree/TextInputController.m: (-[TextInputController attributedStringWithString:]):

3:44 PM Changeset in webkit [24074] by staikos

1 edit in trunk/WebCore/WebCore.pro

missed in previous checkin

3:36 PM Changeset in webkit [24073] by staikos

2 edits
1 add in trunk/WebCore

Move locatizations into another file.

2:54 PM Changeset in webkit [24072] by ggaren

3 edits in trunk/WebCore

Reviewed by Anders Carlsson.

A little more FrameLoader cleanup while working on <rdar://problem/5126396>.

Moved url() and URL() methods next to each other to highlight their subtlety.

loader/FrameLoader.cpp: (WebCore::FrameLoader::url):
loader/FrameLoader.h:

2:37 PM Changeset in webkit [24071] by andersca

16 edits in trunk

LayoutTests:

Reviewed by David Kilzer.

Update tests.

webarchive/archive-empty-frame-dom-expected.txt:
webarchive/archive-empty-frame-source-expected.txt:
webarchive/archive-with-unencoded-url-expected.txt:
webarchive/test-body-background-expected.txt:
webarchive/test-duplicate-resources-expected.txt:
webarchive/test-frameset-expected.txt:
webarchive/test-img-src-expected.txt:
webarchive/test-input-src-expected.txt:
webarchive/test-link-href-expected.txt:
webarchive/test-object-data-expected.txt:
webarchive/test-script-src-expected.txt:
webarchive/test-table-background-expected.txt:
webarchive/test-td-background-expected.txt:

WebKitTools:

Reviewed by David Kilzer.

Replace "Apple Computer" with "Apple" in the DTD declaration.

DumpRenderTree/DumpRenderTree.m: (serializeWebArchiveToXML):

2:30 PM Changeset in webkit [24070] by ggaren

4 edits in trunk/WebCore

Reviewed by Anders Carlsson.

A little FrameLoader cleanup while working on <rdar://problem/5126396>.

Renamed endIfNotLoading() to endIfNotLoadingMainResource() because "loading"
and "loadingMainResource" have distinct meanings and this function
honors the latter.

(WebCore::FrameLoader::endIfNotLoadingMainResource): Protect after the
early return to avoid ref count churn.

loader/FrameLoader.h: (WebCore::FrameLoader::isLoadingMainResource): Inlined this function.

2:06 PM Changeset in webkit [24069] by staikos

15 edits in trunk

Patch from Adam Treat to convert QWebFrame to a QFrame from a QAbstractScrollArea.

1:52 PM Changeset in webkit [24068] by andersca

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Mitz.

<rdar://problem/5280532>
REGRESSION: Can't access nested embed by document.name if object is not immediate parent

plugins/embed-inside-object-expected.txt: Added.
plugins/embed-inside-object.html: Added.

WebCore:

Reviewed by Mitz.

<rdar://problem/5280532>
REGRESSION: Can't access nested embed by document.name if object is not immediate parent

Traverse up the tree looking for an object element.

html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::getInstance):

1:29 PM Changeset in webkit [24067] by aroben

2 edits in trunk/LayoutTests

Add another Leopard failure

mac/leopard/Skipped:

11:11 AM Changeset in webkit [24066] by aroben

2 edits in trunk/LayoutTests

Add another crasher to the Skipped file

Also moved a test that had a bug filed about it out of the section of
unfiled failures.

win/Skipped:

11:00 AM Changeset in webkit [24065] by andersca

4 edits in trunk/LayoutTests

Reviewed by Alexey.

<rdar://problem/5313518> fast/events/iframe-object-onload.html shows events out of order on Leopard

Fix test so that it doesn't matter in what order the frames/objects are loaded. This is done by keeping
the load logs in an array and sort it before dumping it.

fast/events/iframe-object-onload-expected.txt:
fast/events/iframe-object-onload.html:
mac/leopard/Skipped:

10:28 AM Changeset in webkit [24064] by staikos

2 edits in trunk/WebCore

Don't clobber variables that are already set, resulting in a broken build.

10:08 AM Changeset in webkit [24063] by andersca

6 edits
4 deletes in trunk/LayoutTests

Reviewed by Alexey.

<rdar://problem/5313512> fast/frames/frame-set-same-{location,src}.html sometimes hang on Leopard

Make these tests more robust against frames loading in a different order. Also, turn the tests
into text tests and remove them from the Leopard skipped list.

fast/frames/frame-set-same-location-expected.checksum: Removed.
fast/frames/frame-set-same-location-expected.png: Removed.
fast/frames/frame-set-same-location-expected.txt:
fast/frames/frame-set-same-location.html:
fast/frames/frame-set-same-src-expected.checksum: Removed.
fast/frames/frame-set-same-src-expected.png: Removed.
fast/frames/frame-set-same-src-expected.txt:
fast/frames/frame-set-same-src.html:
mac/leopard/Skipped:

9:54 AM Changeset in webkit [24062] by staikos

2 edits in trunk/WebKitTools

Add --qmakearg=foo to make it possible to configure the build without editing
the .pro files each time.

7:56 AM Changeset in webkit [24061] by bdash

2 edits in trunk/WebKit

2007-07-07 Mark Rowe <mrowe@apple.com>

Build fix. Update WebDynamicScrollBarsView.h to include methods added and used in r24060.

WebView/WebDynamicScrollBarsView.h:

7:40 AM Changeset in webkit [24060] by thatcher

3 edits in trunk/WebKit

Reviewed by John.

<rdar://problem/5236277> REGRESSION-9A458: SPI for setting scroll bar behavior doesn't work

Calling setHorizontalScrollingMode: calls updateScrollers before returning, this will cause
WebCore to reset the scrolling mode based on the CSS overflow rules. So the setAlwaysShowHorizontalScroller:
and setAlwaysShowVerticalScroller: methods needed a way to lock the scrolling mode before
calling updateScrollers.

WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): (-[WebDynamicScrollBarsView setHorizontalScrollingMode:andLock:]): (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): (-[WebDynamicScrollBarsView setVerticalScrollingMode:andLock:]): (-[WebDynamicScrollBarsView setScrollingMode:]): (-[WebDynamicScrollBarsView setScrollingMode:andLock:]):
WebView/WebView.mm: (-[WebView setAlwaysShowVerticalScroller:]): (-[WebView setAlwaysShowHorizontalScroller:]):

5:09 AM Changeset in webkit [24059] by mjs

12 edits in trunk

JavaScriptCore:

Reviewed by Antti.

<rdar://problem/5311093> JavaScriptCore fails to build with strict-aliasing warnings

Configurations/Base.xcconfig: Re-enable -Wstrict-aliasing
bindings/jni/jni_utility.cpp: (KJS::Bindings::getJNIEnv): Type-pun via a union instead of a pointer cast.
wtf/HashMap.h: (WTF::): Instead of doing type-punned assignments via pointer cast, do one of three things: (1) assign directly w/o cast if storage type matches real type; (2) assign using cast via union if type does not need reffing; (3) copy with memcpy and ref/deref manually if type needs reffing. This is ok peref-wise because memcpy of a constant length gets optomized. HashTraits are now expected to make ref()/deref() take the storage type, not the true type.
wtf/HashSet.h: (WTF::): Same basic idea.
wtf/HashTable.h: (WTF::): Added Assigner template for use by HashMap/HashSet. Change RefCounter to call ref() and deref() via storage type, avoiding the need to type-pun. (WTF::RefCounter::ref): ditto (WTF::RefCounter::deref): ditto
wtf/HashTraits.h: (WTF::): Change ref() and deref() for RefPtr HashTraits to take the storage type; cast via union to pointer type.
wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::init): Changed from constructor to init function so this can go in a union. (WTF::): redefine pageheap macro in terms of getPageHeap(). (WTF::getPageHeap): new inline function, helper for pageheap macro. This hides the cast in a union. (WTF::TCMalloc_ThreadCache::InitModule): Call init() instead of using placement new to initialize page heap.
wtf/TCPageMap.h: (TCMalloc_PageMap1::init): Changed from constructor to init function. (TCMalloc_PageMap2::init): ditto (TCMalloc_PageMap3::init): ditto

WebCore:

Reviewed by Antti.

<rdar://problem/5311093> JavaScriptCore fails to build with strict-aliasing warnings

platform/StringHash.h: (WTF::): Adapt to newer way to do storage types.

4:42 AM Changeset in webkit [24058] by bdash

2 edits in trunk/WebCore

2007-07-06 Bernhard Rosenkraenzer <bero@arklinux.org>

Reviewed by Sam.

Fix for http://bugs.webkit.org/show_bug.cgi?id=13985
Bug 13985: WebCore/rendering/RenderTable.cpp fails to compile with gcc 4.2.x

rendering/RenderTable.cpp: (WebKit::RenderTable::calcBorderLeft) (WebKit::RenderTable::calcBorderRight)

3:31 AM Changeset in webkit [24057] by bdash

2 edits
3 adds in trunk/WebCore

2007-07-06 Maxime Britto <mbritto@pleyo.com>

Reviewed by Maciej.

Fix http://bugs.webkit.org/show_bug.cgi?id=13038

Bug 13038: ASSERTION FAILED: item->target().isEmpty()

m_mainFrame->tree()->find(item->target()) == m_mainFrame

Modify an ASSERT in goToItem related to going back/forward in history. We don't need to check the frameset if the target is _blank.
The attached test case is a manual one since it relies on having pages opened in tabs in Safari.

manual-tests/goBack-blank-tab-page.html: Added.
manual-tests/resources/before-go-back.html: Added.
manual-tests/resources/will-go-back.html: Added.
page/Page.cpp: (WebCore::Page::goToItem):

3:21 AM Changeset in webkit [24056] by bdash

5 edits in trunk/LayoutTests

2007-07-06 Mark Rowe <mrowe@apple.com>

Unreviewed. Update test results.

fast/encoding/utf-32-big-endian-bom-expected.txt:
fast/encoding/utf-32-big-endian-nobom-expected.txt:
fast/encoding/utf-32-little-endian-bom-expected.txt:
fast/encoding/utf-32-little-endian-nobom-expected.txt:

3:06 AM Changeset in webkit [24055] by bdash

4 edits
2 adds in trunk

2007-07-06 Mitz Pettel <mitz@webkit.org>

Reviewed by Maciej.

fix http://bugs.webkit.org/show_bug.cgi?id=14400 Assertion failure (SHOULD NEVER BE REACHED) going back on YouTube

Test: fast/forms/button-state-restore.html

dom/Document.h: (WebCore::Document::isFormElementRegistered): Added.
html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::closeRenderer): Restore saved form element state only if the element is registered with the document to have its state saved.

2007-07-06 Mitz Pettel <mitz@webkit.org>

Reviewed by Maciej.

test for http://bugs.webkit.org/show_bug.cgi?id=14400 Assertion failure (SHOULD NEVER BE REACHED) going back on YouTube

fast/forms/button-state-restore-expected.txt: Added.
fast/forms/button-state-restore.html: Added.

3:05 AM Changeset in webkit [24054] by bdash

3 edits
4 adds in trunk

2007-07-06 Mitz Pettel <mitz@webkit.org>

Reviewed by Maciej.

fix http://bugs.webkit.org/show_bug.cgi?id=14487 Incomplete repaint of background and border of boxes with -webkit-border-fit:lines

Test: fast/repaint/border-fit-lines.html

rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Do a full repaint if -webkit-border-fit:lines was specified.

2007-07-06 Mitz Pettel <mitz@webkit.org>

Reviewed by Maciej.

repaint test for http://bugs.webkit.org/show_bug.cgi?id=14487 Incomplete repaint of background and border of boxes with -webkit-border-fit:lines

fast/repaint/border-fit-lines-expected.checksum: Added.
fast/repaint/border-fit-lines-expected.png: Added.
fast/repaint/border-fit-lines-expected.txt: Added.
fast/repaint/border-fit-lines.html: Added.

3:03 AM Changeset in webkit [24053] by bdash

3 edits
3 adds in trunk

2007-07-06 Tony Chang <idealisms@gmail.com>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=14516
Bug 14516: crash loading multipart/x-mixed-replace data on windows safari

NULL check m_resourceData to prevent a crash in Safari on Windows.

loader/ResourceLoader.cpp: (WebCore::ResourceLoader::clearResourceData):

2007-07-06 Tony Chang <idealisms@gmail.com>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=14516
Bug 14516: crash loading multipart/x-mixed-replace data on windows safari

http/tests/multipart/resources/multipart-nodashes.php: Added.
http/tests/multipart/win-boundary-crash-expected.txt: Added.
http/tests/multipart/win-boundary-crash.html: Added.

3:00 AM Changeset in webkit [24052] by bdash

7 edits
8 adds in trunk

2007-07-06 Jungshik Shin <jungshik.shin@gmail.com>

Reviewed by Alexey.

Add UTF-32 encoding support http://bugs.webkit.org/show_bug.cgi?id=13415

Test:

fast/encoding/utf-32-big-endian-bom.html
fast/encoding/utf-32-big-endian-nobom.xml
fast/encoding/utf-32-little-endian-bom.html
fast/encoding/utf-32-little-endian-nobom.xml

loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForBOM): (WebCore::TextResourceDecoder::checkForHeadCharset):
platform/TextDecoder.cpp: (WebCore::TextDecoder::checkForBOM):
platform/TextDecoder.h:
platform/TextEncoding.cpp: (WebCore::UTF32BigEndianEncoding): (WebCore::UTF32LittleEndianEncoding):
platform/TextEncoding.h:

2007-07-06 Jungshik Shin <jungshik.shin@gmail.com>

Reviewed by Alexey.

test for http://bugs.webkit.org/show_bug.cgi?id=13415

fast/encoding/utf-32-big-endian-bom-expected.txt: Added.
fast/encoding/utf-32-big-endian-bom.html: Added.
fast/encoding/utf-32-big-endian-nobom-expected.txt: Added.
fast/encoding/utf-32-big-endian-nobom.xml: Added.
fast/encoding/utf-32-little-endian-bom-expected.txt: Added.
fast/encoding/utf-32-little-endian-bom.html: Added.
fast/encoding/utf-32-little-endian-nobom-expected.txt: Added.
fast/encoding/utf-32-little-endian-nobom.xml: Added.

2:56 AM Changeset in webkit [24051] by bdash

3 edits in trunk/WebCore

2007-07-06 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Maciej.

Start implementening RenderThemeGdk/Gtk using GtkStyle. The approach is
to allocate one native control for each widget type. And use margins, spacing,
style properties from the Widget. And for drawing use GtkStyle on the rect supplied.

This should allow nice integration and be relative resource friendly. Mozilla is using
a similiar approach. They seem to share the GdkPixmap among several operations and this
will be an obvious candidate for improvements. Create a normally big enough GdkPixmap and
use that for drawing and then set clip regions for cairo to make sure to not go beyond the
width and height.

The next steps will be to introduce states for the widgets, add more widgets, handle focus,
and various other style attributes, honor the size and margin and use that to propagate this
back to RenderStyle*.

platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::RenderThemeGdk): (WebCore::RenderThemeGdk::setCheckboxSize): (WebCore::RenderThemeGdk::paintCheckbox): (WebCore::RenderThemeGdk::setRadioSize): (WebCore::RenderThemeGdk::paintRadio): (WebCore::RenderThemeGdk::paintButton): (WebCore::RenderThemeGdk::copyToContext): (WebCore::RenderThemeGdk::gtkButton): (WebCore::RenderThemeGdk::gtkCheckbox): (WebCore::RenderThemeGdk::gtkRadioButton): (WebCore::RenderThemeGdk::gtkWindowContainer):
platform/gdk/RenderThemeGdk.h:

2:52 AM Changeset in webkit [24050] by bdash

2 edits in trunk/WebKit

2007-07-06 Mitz Pettel <mitz@webkit.org>

Reviewed by Maciej.

fix http://bugs.webkit.org/show_bug.cgi?id=10267 Can't scroll page downwards with scroll wheel, when pointer is on top of non-scrolling iframe

WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView scrollWheel:]): Override the superclass implementation to forward the wheel event to the next responder if this view does not allow scrolling in the event's direction.

2:11 AM Changeset in webkit [24049] by rwlbuis

1 edit in trunk/WebCore/html/CanvasGradient.cpp

Fix build.

2:00 AM Changeset in webkit [24048] by rwlbuis

3 edits
4 adds in trunk

Reviewed by Adam.

http://bugs.webkit.org/show_bug.cgi?id=14442
Adding a stop with value 1.0 to a gradient that has already been used has no effect

Implement start and end stop handling differently so they are not
in the color stop array.

1:44 AM Changeset in webkit [24047] by aroben

7 edits in trunk

Fix <rdar://problem/5301994> Garbled text still showing on some sites

WebCore:

Fix <rdar://problem/5301994> Garbled text still showing on some sites

Replace calls to GetGlyphIndices with wkGetGlyphs.

Reviewed by Alice.

platform/win/GlyphPageTreeNodeWin.cpp: (WebCore::GlyphPage::fill): Use wkGetGlyphs.
platform/win/FontDataWin.cpp: (WebCore::FontData::containsCharacters):

WebKitLibraries: