⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 9, 2007:

6:43 PM Changeset in webkit [24131] by staikos
  • 6 edits
    1 add in trunk/WebCore

Patch from Qing Zhao to add context menu support for Qt.

4:38 PM Changeset in webkit [24130] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: Moved leaks from Tiger that are marked as fixed in Leopard to a Tiger-only section.
4:23 PM Changeset in webkit [24129] by aliceli1
  • 10 edits in trunk

LayoutTests:

  • win/Skipped: removed one test from skipped list to see whether it will pass with the new DOM Paste API change that is being added simultaneously.

WebKitTools:

Reviewed by Adam Roben.

setting DOM Paste Allowed Pref

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initializePreferences):

win:

Reviewed by Adam Roben.


Adding DOM Paste Allowed preference, setters and getters
for the purpose of layout tests.

  • Interfaces/IWebPreferences.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::isDOMPasteAllowed): (WebPreferences::setDOMPasteAllowed):
  • WebPreferences.h:
  • WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences):
4:19 PM Changeset in webkit [24128] by andersca
  • 2 edits in trunk/WebKit/win

Build fix.

  • WebView.cpp: (WebView::stringByEvaluatingJavaScriptFromString):
4:18 PM Changeset in webkit [24127] by andersca
  • 2 edits in trunk/WebCore

Build fix.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):
3:10 PM Changeset in webkit [24126] by andersca
  • 10 edits in trunk/WebCore

Reviewed by Geoff.

Get rid of the node argument in our various script execution functions.


  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate):
  • bindings/js/kjs_proxy.h:
  • bindings/js/kjs_window.cpp: (KJS::ScheduledAction::execute):
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::endElementNs): (WebCore::XMLTokenizer::notifyFinished):
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::evaluateScript):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::replaceContentsWithScriptResult): (WebCore::FrameLoader::executeScript):
  • loader/FrameLoader.h:
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]): (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
3:06 PM Changeset in webkit [24125] by kmccullo
  • 1 edit
    20 adds in trunk/WebKitTools

Reviewed by Adam, Sam, and Ada.

  • Inital checkin of Drosera for Win. This isn't pretty and doesn't connect to Safari but debug builds and runs.
  • Drosera/Images/Drosera.ico: Added.
  • Drosera/Images/small.ico: Added.
  • Drosera/win: Added.
  • Drosera/win/BaseDelegate.h: Added. (BaseDelegate::QueryInterface): (BaseDelegate::didFinishLoadForFrame): (BaseDelegate::windowScriptObjectAvailable): (BaseDelegate::didStartProvisionalLoadForFrame): (BaseDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): (BaseDelegate::didFailProvisionalLoadWithError): (BaseDelegate::didCommitLoadForFrame): (BaseDelegate::didReceiveTitle): (BaseDelegate::didReceiveIcon): (BaseDelegate::didFailLoadWithError): (BaseDelegate::didChangeLocationWithinPageForFrame): (BaseDelegate::willPerformClientRedirectToURL): (BaseDelegate::didCancelClientRedirectForFrame): (BaseDelegate::willCloseFrame): (BaseDelegate::createWebViewWithRequest): (BaseDelegate::webViewShow): (BaseDelegate::webViewClose): (BaseDelegate::webViewFocus): (BaseDelegate::webViewUnfocus): (BaseDelegate::webViewFirstResponder): (BaseDelegate::makeFirstResponder): (BaseDelegate::setStatusText): (BaseDelegate::webViewStatusText): (BaseDelegate::webViewAreToolbarsVisible): (BaseDelegate::setToolbarsVisible): (BaseDelegate::webViewIsStatusBarVisible): (BaseDelegate::setStatusBarVisible): (BaseDelegate::webViewIsResizable): (BaseDelegate::setResizable): (BaseDelegate::setFrame): (BaseDelegate::webViewFrame): (BaseDelegate::setContentRect): (BaseDelegate::webViewContentRect): (BaseDelegate::runJavaScriptAlertPanelWithMessage): (BaseDelegate::runJavaScriptConfirmPanelWithMessage): (BaseDelegate::runJavaScriptTextInputPanelWithPrompt): (BaseDelegate::runBeforeUnloadConfirmPanelWithMessage): (BaseDelegate::runOpenPanelForFileButtonWithResultListener): (BaseDelegate::mouseDidMoveOverElement): (BaseDelegate::contextMenuItemsForElement): (BaseDelegate::validateUserInterfaceItem): (BaseDelegate::shouldPerformAction): (BaseDelegate::dragDestinationActionMaskForDraggingInfo): (BaseDelegate::willPerformDragDestinationAction): (BaseDelegate::dragSourceActionMaskForPoint): (BaseDelegate::willPerformDragSourceAction): (BaseDelegate::contextMenuItemSelected): (BaseDelegate::hasCustomMenuImplementation): (BaseDelegate::trackCustomPopupMenu): (BaseDelegate::measureCustomMenuItem): (BaseDelegate::drawCustomMenuItem): (BaseDelegate::addCustomMenuDrawingData): (BaseDelegate::cleanUpCustomMenuDrawingData): (BaseDelegate::canTakeFocus): (BaseDelegate::takeFocus): (BaseDelegate::registerUndoWithTarget): (BaseDelegate::removeAllActionsWithTarget): (BaseDelegate::setActionTitle): (BaseDelegate::undo): (BaseDelegate::redo): (BaseDelegate::canUndo): (BaseDelegate::canRedo):
  • Drosera/win/DebuggerApplication.cpp: Added. (DebuggerApplication::serverLoaded): (DebuggerApplication::serverUnloaded): (DebuggerApplication::attach): (DebuggerApplication::numberOfRowsInTableView): (DebuggerApplication::tableView):
  • Drosera/win/DebuggerApplication.h: Added. (DebuggerApplication::DebuggerApplication): (DebuggerApplication::knownServers):
  • Drosera/win/DebuggerObjectCallbacks.cpp: Added. (breakpointEditorHTMLCallback): (currentFunctionStackCallback): (doubleClickMillisecondsCallback): (evaluateScript_inCallFrame_Callback): (isPausedCallback): (localScopeVariableNamesForCallFrame_Callback): (pauseCallback): (resumeCallback): (stepIntoCallback): (valueForScopeVariableNamed_inCallFrame_Callback): (staticFunctions):
  • Drosera/win/DebuggerObjectCallbacks.h: Added.
  • Drosera/win/Drosera.cpp: Added. (_tWinMain): (RegisterDroseraClass): (DroseraWndProc): (About): (Attach): (Drosera::Drosera): (Drosera::initUI): (Drosera::QueryInterface): (Drosera::AddRef): (Drosera::Release): (Drosera::didFinishLoadForFrame): (getDroseraJSClass): (Drosera::windowScriptObjectAvailable): (Drosera::webViewClose): (Drosera::validateUserInterfaceItem): (Drosera::runJavaScriptAlertPanelWithMessage): (Drosera::onSize):
  • Drosera/win/Drosera.h: Added. (Drosera::webViewLoaded):
  • Drosera/win/Drosera.vcproj: Added.
  • Drosera/win/Drosera.vcproj/Drosera.rc: Added.
  • Drosera/win/Drosera.vcproj/Drosera.vcproj: Added.
  • Drosera/win/Drosera.vcproj/debug.vsprops: Added.
  • Drosera/win/Drosera.vcproj/release.vsprops: Added.
  • Drosera/win/HelperFunctions.h: Added. (CFStringToBSTR):
  • Drosera/win/Info.plist: Added.
  • Drosera/win/resource.h: Added.
  • Drosera/win/stdafx.cpp: Added.
  • Drosera/win/stdafx.h: Added.
2:25 PM Changeset in webkit [24124] by staikos
  • 2 edits in trunk/WebKitQt

Patch from Eli Fidler to properly decode data: urls.

2:23 PM Changeset in webkit [24123] by justing
  • 7 edits
    1 add
    1 delete in trunk

LayoutTests:

Rolling the fix for 5310404 back in now that 5310404 has been fixed in Mail.

  • editing/deleting/4845371-expected.checksum:
  • editing/deleting/4845371-expected.txt:
  • editing/deleting/4845371.html:
  • editing/deleting/5126166-expected.txt:
  • editing/deleting/5290534.html: Added.
  • editing/deleting/5290534.html-disabled: Removed.

WebCore:

Rolling the fix for 5290534 back in now that 5310404 has been fixed in Mail.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete):
2:08 PM Changeset in webkit [24122] by ggaren
  • 4 edits in trunk/WebCore

Reviewed by Anders Carlsson.

A little more FrameLoader cleanup while working on <rdar://problem/5126396>.


Rename: "checkEmitLoadEvent" => "checkCallImplicitClose" because the function
doesn't emit the load event; it just calls implicitClose.


Rename: "m_wasLoadEventEmitted" => "m_didCallImplicitClose" because the variable
tracks whether implicitClose was called.

  • dom/Document.cpp: (WebCore::Document::implicitClose): Turned 12 lines of code into 6, adding ASSERT.
  • loader/FrameLoader.h: Removed bogus declaration of non-existent emitLoadEvent().
2:06 PM Changeset in webkit [24121] by brmorris
  • 2 edits in S60/trunk/WebKit

brmorris, rs'd by sachin

DESC: remove a compile warning by generating version info earlier

in the build process.

1:27 PM Changeset in webkit [24120] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by John.


<rdar://problem/5156801> REGRESSION: Crash when deleting table content in Leopard Mail

  • editing/deleting/5156801-expected.checksum: Added.
  • editing/deleting/5156801-expected.png: Added.
  • editing/deleting/5156801-expected.txt: Added.
  • editing/deleting/5156801.html: Added.

WebCore:

Reviewed by John.


REGRESSION: Crash when deleting table content in Leopard Mail

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete): Use a RefPtr for the next node to delete, in case it is destroyed when the current node is deleted. In the crash reported in the radar, we crash because the next node is the div that holds the delete button and it's destroyed when the node that contains the selection is removed.
12:41 PM Changeset in webkit [24119] by staikos
  • 18 edits in trunk

Patch from Adam Treat to convert QWebFrame from QFrame to QObject. Fixes many
regressions from the previous patch.

11:28 AM Changeset in webkit [24118] by andersca
  • 11 edits
    2 adds in trunk

LayoutTests:

Reviewed by Oliver.

<rdar://problem/4954319>
Acrobat 7 / Safari crash: CrashTracer: 99 crashes in Safari at
com.apple.WebCore: WebCore::NetscapePlugInStreamLoader::isDone const + 0


Add tests.


  • plugins/return-error-from-new-stream-callback-in-full-frame-plugin-expected.txt: Added.
  • plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html: Added.

WebCore:

Reviewed by Oliver.

Add DocumentLoader::isLoadingMainResource.

  • WebCore.exp:

WebKit:

Reviewed by Oliver.

<rdar://problem/4954319>
Acrobat 7 / Safari crash: CrashTracer: 99 crashes in Safari at
com.apple.WebCore: WebCore::NetscapePlugInStreamLoader::isDone const + 0

Add a new initWithFrameLoader: method to WebNetscapePluginStream which is to be used when
the stream is a "fake" stream for full frame plug-ins.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView pluginView:receivedResponse:]):
  • Plugins/WebNetscapePluginStream.h:
  • Plugins/WebNetscapePluginStream.mm: (-[WebNetscapePluginStream initWithFrameLoader:]): (-[WebNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]): (-[WebNetscapePluginStream start]): (-[WebNetscapePluginStream cancelLoadWithError:]): (-[WebNetscapePluginStream stop]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createFrame):

WebKitTools:

Reviewed by Oliver.

<rdar://problem/4954319>
Acrobat 7 / Safari crash: CrashTracer: 99 crashes in Safari at
com.apple.WebCore: WebCore::NetscapePlugInStreamLoader::isDone const + 0


If the src url is "data:application/x-webkit-test-netscape,returnerrorfromnewstream",
return an error from NPP_NewStream.


  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginAllocate):
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_New): (NPP_NewStream):
10:45 AM Changeset in webkit [24117] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin


  • fixed <rdar://problem/5320208> WebKit should prevent Time Machine from backing up WebKit clients' icon databases
  • Misc/WebIconDatabase.mm: (-[WebIconDatabase init]): Re-added the code to exclude the icon database from backups. We now do this at the same time we (try to) import the old icon database format, which happens only once per icon database's lifetime. (-[WebIconDatabase _importToWebCoreFormat]): Assert that we haven't imported yet rather than bailing out. It's now the caller's responsibility to check whether we've imported yet.
10:44 AM Changeset in webkit [24116] by sullivan
  • 1 edit in trunk/WebCore/ChangeLog

added missing Reviewer to previous checkin

10:43 AM Changeset in webkit [24115] by sullivan
  • 2 edits in trunk/WebCore
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj: exported String::createCFString, needed for <rdar://problem/5320208>
10:21 AM Changeset in webkit [24114] by staikos
  • 2 edits in trunk/WebKitQt

Fix a minor memory leak in the loader

9:52 AM Changeset in webkit [24113] by staikos
  • 2 edits in trunk/WebKitQt

Fix a massive memory leak in the loader.

8:04 AM Changeset in webkit [24112] by yongjzha
  • 2 edits in S60/branches/3.1m/JavaScriptCore

ligman, reviewed by Yongjun Zhang

DESC: Character class array is defined to 32. If we don't limit characters to 255 an overflow occurs.
​http://bugs.webkit.org/show_bug.cgi?id=14435

  • pcre/pcre.c: (compile_branch): (match):
8:01 AM Changeset in webkit [24111] by yongjzha
  • 2 edits in S60/trunk/JavaScriptCore

ligman, reviewed by Yongjun Zhang

DESC: Character class array is defined to 32. If we don't limit characters to 255 an overflow occurs.
​http://bugs.webkit.org/show_bug.cgi?id=14435

  • pcre/pcre.c: (compile_branch): (match):
7:54 AM Changeset in webkit [24110] by yongjzha
  • 4 edits in S60/branches/3.1m/WebCore

2007-06-29 bujtas <​zbujtas@gmail.com>

Reviewed by Yongjun
DESC: ref images right before switching to the final document,
so they dont get deleted.
​http://bugs.webkit.org/show_bug.cgi?id=14464

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/khtml_part.cpp: (KHTMLPart::switchToFinalDoc):
  • khtml/misc/loader.h: (khtml::):
  • khtml/misc/loader_client.h: (khtml::DummyCachedObjectClient::~DummyCachedObjectClient): (khtml::DummyCachedObjectClient::setPixmap): (khtml::DummyCachedObjectClient::setStyleSheet): (khtml::DummyCachedObjectClient::setXBLDocument): (khtml::DummyCachedObjectClient::notifyFinished):
7:53 AM Changeset in webkit [24109] by yongjzha
  • 4 edits in S60/trunk/WebCore

2007-06-29 bujtas <​zbujtas@gmail.com>

Reviewed by Yongjun
DESC: ref images right before switching to the final document,
so they dont get deleted.
​http://bugs.webkit.org/show_bug.cgi?id=14464

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/khtml_part.cpp: (KHTMLPart::switchToFinalDoc):
  • khtml/misc/loader.h: (khtml::):
  • khtml/misc/loader_client.h: (khtml::DummyCachedObjectClient::~DummyCachedObjectClient): (khtml::DummyCachedObjectClient::setPixmap): (khtml::DummyCachedObjectClient::setStyleSheet): (khtml::DummyCachedObjectClient::setXBLDocument): (khtml::DummyCachedObjectClient::notifyFinished):
7:50 AM Changeset in webkit [24108] by staikos
  • 4 edits in trunk/WebKitQt

Rework much of WebCoreHttp to make it more stable and support Proxy and SSL.

12:57 AM Changeset in webkit [24107] by mjs
  • 1 edit
    1 add in trunk/WebCore

Reviewed by Maciej.

Test case for the bug below, which is ​http://bugs.webkit.org/show_bug.cgi?id=14207

  • manual-tests/flash-unload-tab.html: Added.
12:39 AM Changeset in webkit [24106] by mjs
  • 4 edits in trunk

JavaScriptCore:

Reviewed by Oliver.


  • JavaScriptCore part of fix for: <rdar://problem/5295734> Repro crash closing tab/window @ maps.google.com in WTF::HashSet<KJS::RuntimeObjectImp*, WTF::PtrHash<KJS::RuntimeObjectImp*>, WTF::HashTraits<KJS::RuntimeObjectImp*> >::add + 11


WebCore:

Reviewed by Oliver.

<rdar://problem/5295734> Repro crash closing tab/window @ maps.google.com in WTF::HashSet<KJS::RuntimeObjectImp*, WTF::PtrHash<KJS::RuntimeObjectImp*>, WTF::HashTraits<KJS::RuntimeObjectImp*> >::add + 11


Automated test case is not possible. Did not bother with manual test this time.

  • bindings/js/kjs_dom.cpp: (WebCore::getRuntimeObject): Check that runtime root isn't null, as well as instance; this should cover the case where the plugin is already shut down and onunload time.

Jul 8, 2007:

11:29 PM Changeset in webkit [24105] by mjs
  • 5 edits
    1 add in trunk/WebCore

Reviewed by Sam.

  • bindings/js/kjs_window.cpp: (KJS::createWindow): No longer take an immediate argument - always do immediate loads on a newly created Window. Also, do a load of "" to make sure that the right info makes it to the app. (KJS::showModalDialog): Updated for above. (KJS::WindowFunc::callAsFunction): Updated for above.
  • dom/Document.cpp: (WebCore::Document::shouldBeAllowedToLoadLocalResources): If our URL is about:blank, we're allowed if our opener is (since the opener must have written the contents).
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): Add a variant which takes a KURL, which it expects to be pre-completed. This is to avoid completing "" to the opener URL. (WebCore::FrameLoader::urlSelected): Allow loading empty URLs.
  • loader/FrameLoader.h:


Test case is manual only, since it takes particular app behavior to reproduce:


  • manual-tests/new-window-subresource-crash.html: Added.
3:43 PM Changeset in webkit [24104] by kevino
  • 2 edits in branches/wx-port-alpha/trunk/WebKit/wx/bindings/python

Expose WebView events to the Python bindings.

2:02 PM Changeset in webkit [24103] by bdash
  • 2 edits in trunk/WebCore

2007-07-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

  • fix leaks introduced in r24099
  • dom/Element.cpp: (WebCore::Element::~Element): Do not delete the cached computed style here. (WebCore::Element::detach): Delete the computed style here instead. (WebCore::Element::computedStyle): Removed a redundant ref() which was causing the leak. Changed to return 0 if the element is not attached, because in that case there is currently no way to tell when to delete the computed style.
12:36 PM Changeset in webkit [24102] by bdash
  • 2 edits in trunk/WebKitTools

2007-07-08 Mark Rowe <​mrowe@apple.com>

Change name from WebKit/Qt to WebKit.

  • CodeCoverage/regenerate-coverage-display:
11:55 AM Changeset in webkit [24101] by sullivan
  • 2 edits in trunk/WebKit
  • Misc/WebIconDatabase.mm: (-[WebIconDatabase init]): Removed the code to exclude the icon database from backups. We still want to do this, but in a way that only runs once ever, instead of once per launch, due to performance concerns.
11:47 AM Changeset in webkit [24100] by bdash
  • 3 edits in trunk/WebKitTools

Mark code coverage scripts as executable.

10:51 AM Changeset in webkit [24099] by weinig
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/css/computed-style-without-renderer-expected.txt: Added.
  • fast/css/computed-style-without-renderer.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/css/computed-style-without-renderer.html

Implement rich computed style for elements that do not have a renderer.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::getPositionOffsetValue): Changed to take a RenderStyle instead of a RenderObject. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Changed to use the computed style returned by the node instead of going through the renderer. Changed properties that compute by measuring the renderer to fall back on returning the length from the RenderStyle if a renderer does not exist. (WebCore::CSSComputedStyleDeclaration::length): Changed to return the number of properties we can compute even if the element has no renderer. (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties): Changed to use the computed style returned by the node instead of going through the renderer.
  • dom/Element.cpp: (WebCore::ElementRareData::ElementRareData): Added a computed style member, used to cache computed style for elements that do not have a renderer. (WebCore::ElementRareData::resetComputedStyle): Added. (WebCore::Element::~Element): Delete the cached computed style. (WebCore::Element::recalcStyle): Added code to delete the cached computed style when necessary. (WebCore::Element::computedStyle): Added. Returns the style used in rendering the element, if available. Otherwise uses the style selector to compute style for the element.
  • dom/Element.h:
  • dom/Node.cpp: (WebCore::Node::computedStyle): Added. This method returns either the style used in rendering the node, or the style that would be used if the node had a renderer.
  • dom/Node.h:
10:40 AM Changeset in webkit [24098] by bdash
  • 2 edits in trunk/WebCore

2007-07-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passWheelEventToWidget): Changed to return false if the event coordinates are not inside the widget's NSView hierarchy.
8:37 AM Changeset in webkit [24097] by rwlbuis
  • 10 edits
    4 adds in trunk

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=10752
The inspector should not respond to Make Text Smaller/Bigger commands

Use the -webkit-text-size-adjust property to ignore text sizing
and do not take the zoom factor into account for line height when
-webkit-text-size-adjust is set to none.

4:49 AM Changeset in webkit [24096] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fix <rdar://problem/5318994> Integer overflow in WebCore's Base64.cpp:base64Encode
  • platform/Base64.cpp: (WebCore::base64Encode): Check against a maximum size. (WebCore::base64Decode): Ditto.
4:47 AM Changeset in webkit [24095] by darin
  • 8 edits in trunk

WebCore:

Reviewed by Maciej.

  • fix <rdar://problem/5124665> WebCore secondary-thread assertion should use linked-on-or-after check instead of building on Tiger check
  • platform/ThreadCheck.h: Renamed _WebCoreThreadViolationCheck to reportThreadViolation since it's in the WebCore namespace and also we shouldn't use leading underscores since those are reserved for the compiler and standard library. Added a new function named setDefaultThreadViolationBehavior and an enum for the parameter. Removed the threadViolationIsException parameter from WebCoreReportThreadViolation since we use a global variable for it now. Got rid of the unnecessary use of do while (0) in the WebCoreThreadViolationCheck macro -- since it's only a single function call it's already a statement and doesn't need to be turned into one with the do while (0) trick.
  • platform/mac/ThreadCheck.mm: (WebCore::readThreadViolationBehaviorFromUserDefaults): Moved the code to read from NSUserDefaults into this helper function. Changed it to use stringForKey instead of objectForKey so we don't get a "method not found" if someone puts something other than a string in there. Updated to use the new globals. (WebCore::setDefaultThreadViolationBehavior): Added. (WebCore::reportThreadViolation): Simplified, now that most of the work is in the readThreadViolationBehaviorFromUserDefaults function. (WebCoreReportThreadViolation): Changed to use a global variable instead of parameter to determine how to report a violation. Added LogOnFirstThreadViolation, which will log only once for each function that violates.
  • WebCore.exp: Updated for above changes.

WebKit:

Reviewed by Maciej.

  • fix <rdar://problem/5124665> WebCore secondary-thread assertion should use linked-on-or-after check instead of building on Tiger check
  • Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITH_MAIN_THREAD_EXCEPTIONS.
  • WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): In first-time initialization block, check for binaries linked against older versions of WebKit, and set the default thread violation behavior to LogOnFirstThreadViolation.
  • WebView/WebView.mm: (+[WebView initialize]): Improved comments.
2:54 AM Changeset in webkit [24094] by bdash
  • 3 edits
    4 adds in trunk

2007-07-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/css-generated-content/before-with-first-letter.html

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::updateBeforeAfterContentForContainer): If a child of the existing 'before' container is not text, do not assume that it is an image, since it can also be an inline wrapping a first-letter. In that case, do not update its style (so in particular, keep it a FIRST_LETTER type style) and leave it to updateFirstLetter() to take care of.

2007-07-08 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/css-generated-content/before-with-first-letter-expected.checksum: Added.
  • fast/css-generated-content/before-with-first-letter-expected.png: Added.
  • fast/css-generated-content/before-with-first-letter-expected.txt: Added.
  • fast/css-generated-content/before-with-first-letter.html: Added.
Note: See TracTimeline for information about the timeline view.