⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 10, 2007:

11:20 PM Changeset in webkit [24183] by ggaren
  • 4 edits in trunk/WebKit

Reviewed by Maciej Stachowiak.

  • Fixed <rdar://problem/5049509> REGRESSION(10.4.9-9A377a): REAP Suite installer shows empty modal alert window (hangs) if user cancels during "installing shared components" phase


Added Adobe installers to the family of apps that need a data load
loading quirk.


Added a linked-on-or-after check because this code is no longer
Tiger-only.


I tested this code on Tiger and Leopard.

  • Misc/WebKitVersionChecks.h:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDocumentLoaderMac.mm: (needsDataLoadWorkaround): (WebDocumentLoaderMac::setDataSource):
10:10 PM Changeset in webkit [24182] by weinig
  • 9 edits
    2 adds in trunk

LayoutTests:

Reviewed by Oliver.

  • fast/dom/Window/get-set-properties-expected.txt: Added.
  • fast/dom/Window/get-set-properties.html: Added.

WebCore:

Reviewed by Oliver.

Move more attributes from the pure JS bindings in KJS::Window
to the implementation in DOMWindow and autogenerate the new bindings

Test: fast/dom/Window/get-set-properties.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot): Change to use propHashTable in JSDOMWindow instead of KJS::Window
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty): (KJS::Window::put):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • bindings/scripts/CodeGeneratorJS.pm: Cleanup getValueProperty and put generation to reduce code duplication.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::closed): (WebCore::DOMWindow::length): (WebCore::DOMWindow::name): (WebCore::DOMWindow::setName): (WebCore::DOMWindow::status): (WebCore::DOMWindow::setStatus): (WebCore::DOMWindow::defaultStatus): (WebCore::DOMWindow::setDefaultStatus):
  • page/DOMWindow.h: (WebCore::DOMWindow::defaultstatus): (WebCore::DOMWindow::setDefaultstatus):
  • page/DOMWindow.idl:
8:46 PM Changeset in webkit [24181] by weinig
  • 4 edits
    3 adds in trunk

LayoutTests:

Reviewed by Geoff.

Tests for <rdar://problem/5326791>

  • http/tests/security/cross-frame-access-expected.txt:
  • http/tests/security/cross-frame-access-put-expected.txt: Added.
  • http/tests/security/cross-frame-access-put.html: Added.
  • http/tests/security/resources/cross-frame-iframe-for-put-test.html: Added.

WebCore:

Reviewed by Geoff.

Fix for <rdar://problem/5326791> XSS vulnerability: ability to set window.defaultStatus,
window.defaultstatus and window.status cross domains

Test: http/tests/security/cross-frame-access-put.html

  • bindings/js/kjs_window.cpp: (KJS::Window::put): Adds isSafeScript check for defaultStatus, defaultstatus and status cases.
8:11 PM Changeset in webkit [24180] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: Add an ignore item for a leak in Tiger's Foundation's multipart/mixed-replace support -- I already verified that the bug has been fixed.
7:13 PM Changeset in webkit [24179] by aliceli1
  • 2 edits in trunk/WebKitTools

rubber stamped by Maciej.

fixed <rdar://5137972> editing/selection/editable-links.html fails on Windows

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initializePreferences): set editable link behavior to match Mac DRT.
6:42 PM Changeset in webkit [24178] by weinig
  • 2 edits in trunk/WebCore

Fix build for BuildBot.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::outerHeight): (WebCore::DOMWindow::outerWidth): (WebCore::DOMWindow::screenX): (WebCore::DOMWindow::screenY):
6:38 PM Changeset in webkit [24177] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Sam

<rdar://problem/5326653> - REGRESSION: [WebBackForwardList forwardListCount] might return incorrect result

No layout test because this is an API issue that can't be tested in DRT or the browser

  • history/BackForwardList.cpp: (WebCore::BackForwardList::forwardListCount): If the index is NoCurrentItemIndex, return 0
5:28 PM Changeset in webkit [24176] by weinig
  • 6 edits in trunk/WebCore

Reviewed by Darin.

Move more readonly attributes from pure JS bindings in KJS::Window
to the implementation in DOMWindow and autogenerate the new bindings.

  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty): Sort the hashmap comment into categories to make further migration easier.
  • bindings/js/kjs_window.h: Sort the enum into categories to make further migration easier. (KJS::Window::):
  • page/DOMWindow.cpp: Add new methods. (WebCore::DOMWindow::focus): (WebCore::DOMWindow::blur): (WebCore::DOMWindow::offscreenBuffering): (WebCore::DOMWindow::outerHeight): (WebCore::DOMWindow::outerWidth): (WebCore::DOMWindow::innerHeight): (WebCore::DOMWindow::innerWidth): (WebCore::DOMWindow::screenX): (WebCore::DOMWindow::screenY): (WebCore::DOMWindow::scrollX): (WebCore::DOMWindow::scrollY): (WebCore::DOMWindow::getComputedStyle): (WebCore::DOMWindow::getMatchedCSSRules): Add null Document assertion. (WebCore::DOMWindow::devicePixelRatio): Add null Frame and Page checks.
  • page/DOMWindow.h: (WebCore::DOMWindow::screenLeft): (WebCore::DOMWindow::screenTop): (WebCore::DOMWindow::pageXOffset): (WebCore::DOMWindow::pageYOffset):
  • page/DOMWindow.idl:
5:23 PM Changeset in webkit [24175] by oliver
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/5326417> Editor::unmarkText needs to be crossplatform

Missed this in earlier patch to make text marking platform independent.

  • editing/Editor.cpp: (WebCore::Editor::unmarkText):

Add platform independent impl

  • editing/mac/EditorMac.mm:

Remove the old mac path.

4:52 PM Changeset in webkit [24174] by ggaren
  • 4 edits in trunk

WebCore:

Reviewed by Tim Hatcher.

Added a Page counter. This helped me while investigating
<rdar://problem/5314463> 40MB of WebKit memory still allocated after
closing large email in Mail

  • WebCore.xcodeproj/project.pbxproj:
  • page/Page.cpp: (WebCore::): (WebCore::PageCounter::~PageCounter): (WebCore::Page::Page): (WebCore::Page::~Page):

WebKitTools:

Reviewed by Tim Hatcher.

Ignore Page.o in debug builds because it now has a static PageCounter
object.

  • Scripts/check-for-global-initializers:
4:44 PM Changeset in webkit [24173] by thatcher
  • 4 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/5326126> InspectorResource holds onto more data than it needs

Reduces the fixed size of InspectorResource from 630 bytes to 224 bytes. Now
selectively pick out parts of the ResourceRequest and ResourceResponse objects
for the info needed and store that directly in InspectorResource.

The ResourceRequest and ResourceResponse objects hold a reference to the original
NSURL object, so almost double the data was being kept around. So the struct size
reduction is just the tip of the ice burg on what this really saves.

In a test of 100,000 XMLHTTPRequests using a 85 byte long data URL, I see ~21 MB less
RSIZE compared to Safari running without this change.

  • page/InspectorController.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::type): (WebCore::addSourceToFrame): (WebCore::scriptObjectForRequest): (WebCore::scriptObjectForResponse): (WebCore::InspectorController::addScriptResource): (WebCore::InspectorController::addAndUpdateScriptResource): (WebCore::updateResourceRequest): (WebCore::updateResourceResponse): (WebCore::InspectorController::updateScriptResourceRequest): (WebCore::InspectorController::updateScriptResourceResponse): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading):
  • page/InspectorController.h:
3:42 PM Changeset in webkit [24172] by zimmermann
  • 3 edits in branches/feature-branch/WebCore

Forgot to commit the ChangeLog and two files in my last commit!

3:37 PM Changeset in webkit [24171] by darin
  • 2 edits in trunk/WebCore

Reviewed by Brady.

  • fix crash introduced by my patch for 5318732, only seen in release builds
  • page/Page.cpp: (WebCore::Page::~Page): Added a missing null check.
3:30 PM Changeset in webkit [24170] by staikos
  • 2 edits in trunk/WebCore

Patch from Andrea Cavalli to fix sunken state of text fields.
Bug #14576

3:29 PM Changeset in webkit [24169] by zimmermann
  • 17 edits
    5 adds in branches/feature-branch

Reviewed by Sam.

Recognizee <textPath> in SVG JS bindings.
Add JSSVGTextPathElement to JSSVGElementWrapperFactory.

Add SVGException.idl just for the JS generation.
Turn on all SVG JS constructors and add them to DOMWindow.idl.

Testcase added: LayoutTests/svg/custom/js-svg-constructors.svg

3:13 PM Changeset in webkit [24168] by staikos
  • 3 edits in trunk/WebCore

Patch from Qing Zhao to draw focus rects on non-QStyle rendered nodes. Needs a
bit more work once we figure out how to use QPainterPathStroker in a more
sophisticated manner.

3:10 PM Changeset in webkit [24167] by brmorris
  • 2 edits in S60/trunk/WebKit

brmorris, reviewed by johnshi

DESC: remove generated header from releasables list.


Turns out some build systems delete the releasables list after the
makmake phase but before the compilation, and hence the generated
header was not found at compile time.

3:04 PM BuildingGdk edited by zecke@selfish.org
(diff)
3:04 PM BuildingGdk edited by zecke@selfish.org
(diff)
2:53 PM Changeset in webkit [24166] by adachan
  • 2 edits in trunk/WebKit/win

2007-07-10 Ada Chan <​adachan@apple.com>

Fixed build.

  • WebView.cpp:
2:46 PM Changeset in webkit [24165] by zimmermann
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

Fix 'unsigned int' overflow in CodeGeneratorJS.pm.
This fixes hashing of "SVG_FEBLEND_MODE_NORMAL". Its hashvalue exceeded 232, which
is no problem in perl but in the cpp code. Emulate C/C++ behaviour by using "% 232" in
the perl code. Testcase available in feature-branch soon (js-svg-constructors.svg).

2:45 PM Changeset in webkit [24164] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

Disabled Arena recycling in RenderArena. PLT shows no regression
(possibly a small speedup), and this can reduce allocated memory in
WebKit clients by about 120K (4K per Arena * 30 Arenas).


I happened upon this optimization while investigating
<rdar://problem/5314463> WebKit hangs on to 40MB RAM after closing
large email in Mail (appears to be render tree arena allocator),
although I don't think it will come close to fixing that bug
completely.

  • rendering/RenderArena.cpp: (WebCore::RenderArena::~RenderArena): Use FinishArenaPool, which frees the ArenaPool's Arenas immediately.
2:37 PM Changeset in webkit [24163] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/replaced/absolute-position-percentage-height-expected.checksum: Added.
  • fast/replaced/absolute-position-percentage-height-expected.png: Added.
  • fast/replaced/absolute-position-percentage-height-expected.txt: Added.
  • fast/replaced/absolute-position-percentage-height.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/replaced/absolute-position-percentage-height.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcReplacedHeightUsing): For positioned elements, evaluate the percentage with respect to the container's final height.
1:21 PM Changeset in webkit [24162] by thatcher
  • 1 edit in trunk/WebCore/platform/DeprecatedString.cpp

Build fix.

1:13 PM Changeset in webkit [24161] by beidson
  • 1 edit in trunk/WebCore/platform/DeprecatedString.cpp

Correctness fix

1:08 PM Changeset in webkit [24160] by zbujtas
  • 7 edits in S60/branches/3.1m/WebKit

2007-07-03 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by ​zbujtas@gmail.com.
DESC: merge fixes SYAI-73AS6K and SYAI-73ARXK from 3.2
​http://bugs.webkit.org/show_bug.cgi?id=14389

1:03 PM Changeset in webkit [24159] by darin
  • 2 edits in trunk/WebKit
  • fix build
  • WebView/WebHTMLView.mm: Add include of ContextMenu.h.
12:54 PM Changeset in webkit [24158] by beidson
  • 7 edits in trunk/WebCore

Reviewed by Mark Rowe

Add 64-bit integer converters to our string classes for future work

  • platform/DeprecatedString.cpp: (WebCore::DeprecatedString::toInt64): (WebCore::DeprecatedString::toUInt64):
  • platform/DeprecatedString.h:
  • platform/PlatformString.h:
  • platform/String.cpp: (WebCore::String::toInt64): (WebCore::String::toUInt64):
  • platform/StringImpl.cpp: (WebCore::StringImpl::toInt64): (WebCore::StringImpl::toUInt64):
  • platform/StringImpl.h:
12:45 PM Changeset in webkit [24157] by aliceli1
  • 2 edits in trunk/LayoutTests
  • win/Skipped: removing tests that were blocked on lack of support for smart pasting and DOM Paste API
12:21 PM Changeset in webkit [24156] by darin
  • 9 edits in trunk/WebCore

Reviewed by Anders.

  • fix <rdar://problem/5318732> REGRESSION: In Mail, a crash occurs when attempting to send a HTML based message (nytimes.com, washingtonpost.com, latimes.com)

Did an audit of calls to get the inspector and most other uses of Page* and added null
checks since Frame* can outlast its Page*.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): Added null check. (WebCore::FrameLoader::loadSubframe): Ditto. (WebCore::FrameLoader::load): Ditto. (WebCore::FrameLoader::transitionToCommitted): Ditto. (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto. (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): Ditto. (WebCore::FrameLoader::addExtraFieldsToRequest): Ditto. (WebCore::FrameLoader::loadResourceSynchronously): Ditto. (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Ditto. (WebCore::FrameLoader::requestFromDelegate): Ditto. (WebCore::FrameLoader::canGoBackOrForward): Ditto. (WebCore::FrameLoader::getHistoryLength): Ditto. (WebCore::FrameLoader::historyURL): Ditto. (WebCore::FrameLoader::cachePageForHistoryItem): Ditto. (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): Ditto. (WebCore::FrameLoader::goToItem): Ditto. (WebCore::FrameLoader::dispatchWindowObjectAvailable): Ditto. (WebCore::FrameLoader::dispatchDidCommitLoad): Ditto. (WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest): Ditto. (WebCore::FrameLoader::dispatchWillSendRequest): Ditto. (WebCore::FrameLoader::dispatchDidReceiveResponse): Ditto. (WebCore::FrameLoader::dispatchDidReceiveContentLength): Ditto. (WebCore::FrameLoader::dispatchDidFinishLoading): Ditto. (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache): Ditto.
  • page/ContextMenuController.h:
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::ContextMenuController): Removed unneeded and unused Page* parameter. (WebCore::openNewWindow): Added null check. (WebCore::ContextMenuController::contextMenuItemSelected): Ditto.
  • page/InspectorController.h: (WebCore::InspectorController::pageDestroyed): Added. Since this object is owned by the Page and has a back-pointer to it, it needs an explicit disconnect. There's already a higher-level one, but this is more reliable than that.
  • page/InspectorController.cpp: (WebCore::InspectorController::windowScriptObjectAvailable): Added null check. (WebCore::InspectorController::windowUnloading): Ditto.
  • page/Page.cpp: (WebCore::Page::Page): Updated for change in parameters of ContextMenuController constructor. (WebCore::Page::~Page): Added call to InspectorController pageDestroyed().
  • page/Chrome.cpp: Updated includes.
  • page/DragController.cpp: Ditto.
11:47 AM Changeset in webkit [24155] by darin
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

  • <rdar://problem/5321953> remove workaround for fixed AppKit mouse moved bug
  • WebView/WebHTMLView.mm: Put the workaround for bug 3429631 inside an ifdef BUILDING_ON_TIGER.
10:44 AM Changeset in webkit [24154] by bdash
  • 1 copy in tags/WebKit-419.3/WebKit

New tag (part 2).

10:43 AM Changeset in webkit [24153] by bdash
  • 1 add in tags/WebKit-419.3

New tag (part 1).

10:42 AM Changeset in webkit [24152] by bdash
  • 1 copy in tags/WebCore-418.23/WebCore

New tag (part 2).

10:42 AM Changeset in webkit [24151] by bdash
  • 1 add in tags/WebCore-418.23

New tag (part 1).

10:39 AM Changeset in webkit [24150] by bdash
  • 4 edits in branches/Safari-2.0-system

Versioning.

9:39 AM Changeset in webkit [24149] by staikos
  • 2 edits in trunk/WebCore

Patch from Adam Treat to make the scroll wheel behave sanely

9:25 AM Changeset in webkit [24148] by ggaren
  • 4 edits
    5 adds in trunk

LayoutTests:

Reviewed by Maciej Stachowiak.

  • fast/events/onload-after-document-close-no-subresource-expected.txt: Added.
  • fast/events/onload-after-document-close-no-subresource.html: Added.
  • fast/events/onload-after-document-close-with-subresource-expected.txt: Added.
  • fast/events/onload-after-document-close-with-subresource.html: Added.
  • fast/events/resources/onload-image.png: Added.

WebCore:

Reviewed by Maciej Stachowiak.

Fixed ​http://bugs.webkit.org/show_bug.cgi?id=13241 | <rdar://problem/5126396>
onload fires before content is finished loading (woot.com)


  • dom/Document.cpp: (WebCore::Document::close): Try to go through the normal "Am I done loading?" machinery before dispatching the load event. As the comment indicates, we can't do this in all cases, so the fix isn't perfect. However, a perfect solution would require much riskier sweeping changes to the loader, which are best left for later, I think.
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): Removed a slightly worse solution to the same problem.
3:25 AM Changeset in webkit [24147] by bdash
  • 2 edits in trunk/WebKitQt

2007-07-10 Mark Rowe <​mrowe@apple.com>

Qt build fix after r24126.

  • Api/qwebframe.cpp: (QWebFrame::evaluateJavaScript):
2:21 AM Changeset in webkit [24146] by rwlbuis
  • 28 edits
    6 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=8007
createElement() and XHTML (A dynamically created table not rendered as such)

Follow the HTML5 rules of making the name lowercase and then
creating the element in the xhtml namespace.

1:20 AM Changeset in webkit [24145] by bdash
  • 2 edits in branches/Safari-2.0-dashboard/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r23529 from ToT to Safari-2.0-dashboard.

2007-06-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Geoff.

<rdar://problem/5211677>
-[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): If the object is a Java MIME type and Java is disabled, don't load the plug-in.
  • platform/MimeTypeRegistry.cpp: (WebCore::MimeTypeRegistry::isJavaAppletMIMEType): Clean this up and add another applet MIME type.
1:20 AM Changeset in webkit [24144] by bdash
  • 2 edits in branches/Safari-2.0-dashboard/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r18365 from ToT to Safari-2.0-dashboard.

2006-12-20 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.

Fixed <rdar://problem/4809825>. We need to check isSafeScript when converting
a Location to string.

It's really a bug, and poor design, for objects to override toString.
Subclasses that want custom toString implementations should add a toString
function to their prototypes instead of overriding the JavaScript ToString
operation. Following this design pattern would have avoided this bug in the
first place.

  • bindings/js/kjs_window.cpp: (KJS::Location::toString):
1:20 AM Changeset in webkit [24143] by bdash
  • 3 edits in branches/Safari-2.0-dashboard/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r19551 from ToT to Safari-2.0-dashboard.

2007-02-10 Maciej Stachowiak <​mjs@apple.com>

Reviewed by me, patch from Ian Eng (cleaned up by me some).

  • fixed <rdar://problem/4988091> objects attached to Window not cleared (memory leak)

Test case: fast/dom/Window/window-appendages-cleared.html

  • bindings/js/kjs_window.cpp: (KJS::Window::clearHelperObjectProperties): (KJS::Window::clear):
  • bindings/js/kjs_window.h:
1:20 AM Changeset in webkit [24142] by bdash
  • 2 edits in branches/Safari-2.0-dashboard/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r19126 from ToT to Safari-2.0-dashboard.

2007-01-25 Dirk Mueller <​mueller@kde.org>

Reviewed and merged by Beth.

Fix for <rdar://problem/4921692> not processing comments inside a
title element leads to XSS (for at least BlogSpot)

This is equivalent to commit 626791 in the KDE tree. Basically, the
patch allows comment parsing in titles to avoid capturing a
<script> tag by accident.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseComment):
1:20 AM Changeset in webkit [24141] by bdash
  • 2 edits in branches/Safari-2.0-dashboard/WebKit

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r23963 from ToT to Safari-2.0-dashboard.

2007-07-03 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

Fix for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters

  • Misc/WebNSURLExtras.m: (isLookalikeCharacter): Renamed. Also excludes any non-printable character, any character considered as whitespace that isn't already converted to a space by ICU, any ignorable character, and any character excluded in Mozilla's blacklist: ​http://kb.mozillazine.org/Network.IDN.blacklist_chars (allCharactersInIDNScriptWhiteList):
1:10 AM Changeset in webkit [24140] by bdash
  • 2 edits in branches/Safari-1-3-branch/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r23529 from ToT to Safari-1-3-branch.

2007-06-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Geoff.

<rdar://problem/5211677>
-[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): If the object is a Java MIME type and Java is disabled, don't load the plug-in.
  • platform/MimeTypeRegistry.cpp: (WebCore::MimeTypeRegistry::isJavaAppletMIMEType): Clean this up and add another applet MIME type.
1:10 AM Changeset in webkit [24139] by bdash
  • 3 edits in branches/Safari-1-3-branch/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r19551 from ToT to Safari-1-3-branch.

2007-02-10 Maciej Stachowiak <​mjs@apple.com>

Reviewed by me, patch from Ian Eng (cleaned up by me some).

  • fixed <rdar://problem/4988091> objects attached to Window not cleared (memory leak)

Test case: fast/dom/Window/window-appendages-cleared.html

  • bindings/js/kjs_window.cpp: (KJS::Window::clearHelperObjectProperties): (KJS::Window::clear):
  • bindings/js/kjs_window.h:
1:10 AM Changeset in webkit [24138] by bdash
  • 2 edits in branches/Safari-1-3-branch/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r19126 from ToT to Safari-1-3-branch.

2007-01-25 Dirk Mueller <​mueller@kde.org>

Reviewed and merged by Beth.

Fix for <rdar://problem/4921692> not processing comments inside a
title element leads to XSS (for at least BlogSpot)

This is equivalent to commit 626791 in the KDE tree. Basically, the
patch allows comment parsing in titles to avoid capturing a
<script> tag by accident.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseComment):
1:10 AM Changeset in webkit [24137] by bdash
  • 2 edits in branches/Safari-1-3-branch/WebKit

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r23963 from ToT to Safari-1-3-branch.

2007-07-03 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

Fix for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters

  • Misc/WebNSURLExtras.m: (isLookalikeCharacter): Renamed. Also excludes any non-printable character, any character considered as whitespace that isn't already converted to a space by ICU, any ignorable character, and any character excluded in Mozilla's blacklist: ​http://kb.mozillazine.org/Network.IDN.blacklist_chars (allCharactersInIDNScriptWhiteList):
1:08 AM Changeset in webkit [24136] by bdash
  • 2 edits in branches/Safari-2.0-system/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r23529 from ToT to Safari-2.0-system.

2007-06-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Geoff.

<rdar://problem/5211677>
-[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): If the object is a Java MIME type and Java is disabled, don't load the plug-in.
  • platform/MimeTypeRegistry.cpp: (WebCore::MimeTypeRegistry::isJavaAppletMIMEType): Clean this up and add another applet MIME type.
1:08 AM Changeset in webkit [24135] by bdash
  • 2 edits in branches/Safari-2.0-system/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r18365 from ToT to Safari-2.0-system.

2006-12-20 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.

Fixed <rdar://problem/4809825>. We need to check isSafeScript when converting
a Location to string.

It's really a bug, and poor design, for objects to override toString.
Subclasses that want custom toString implementations should add a toString
function to their prototypes instead of overriding the JavaScript ToString
operation. Following this design pattern would have avoided this bug in the
first place.

  • bindings/js/kjs_window.cpp: (KJS::Location::toString):
1:08 AM Changeset in webkit [24134] by bdash
  • 3 edits in branches/Safari-2.0-system/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r19551 from ToT to Safari-2.0-system.

2007-02-10 Maciej Stachowiak <​mjs@apple.com>

Reviewed by me, patch from Ian Eng (cleaned up by me some).

  • fixed <rdar://problem/4988091> objects attached to Window not cleared (memory leak)

Test case: fast/dom/Window/window-appendages-cleared.html

  • bindings/js/kjs_window.cpp: (KJS::Window::clearHelperObjectProperties): (KJS::Window::clear):
  • bindings/js/kjs_window.h:
1:08 AM Changeset in webkit [24133] by bdash
  • 2 edits in branches/Safari-2.0-system/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r19126 from ToT to Safari-2.0-system.

2007-01-25 Dirk Mueller <​mueller@kde.org>

Reviewed and merged by Beth.

Fix for <rdar://problem/4921692> not processing comments inside a
title element leads to XSS (for at least BlogSpot)

This is equivalent to commit 626791 in the KDE tree. Basically, the
patch allows comment parsing in titles to avoid capturing a
<script> tag by accident.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseComment):
1:08 AM Changeset in webkit [24132] by bdash
  • 2 edits in branches/Safari-2.0-system/WebKit

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r23963 from ToT to Safari-2.0-system.

2007-07-03 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

Fix for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters

  • Misc/WebNSURLExtras.m: (isLookalikeCharacter): Renamed. Also excludes any non-printable character, any character considered as whitespace that isn't already converted to a space by ICU, any ignorable character, and any character excluded in Mozilla's blacklist: ​http://kb.mozillazine.org/Network.IDN.blacklist_chars (allCharactersInIDNScriptWhiteList):

Jul 9, 2007:

6:43 PM Changeset in webkit [24131] by staikos
  • 6 edits
    1 add in trunk/WebCore

Patch from Qing Zhao to add context menu support for Qt.

4:38 PM Changeset in webkit [24130] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: Moved leaks from Tiger that are marked as fixed in Leopard to a Tiger-only section.
4:23 PM Changeset in webkit [24129] by aliceli1
  • 10 edits in trunk

LayoutTests:

  • win/Skipped: removed one test from skipped list to see whether it will pass with the new DOM Paste API change that is being added simultaneously.

WebKitTools:

Reviewed by Adam Roben.

setting DOM Paste Allowed Pref

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initializePreferences):

win:

Reviewed by Adam Roben.


Adding DOM Paste Allowed preference, setters and getters
for the purpose of layout tests.

  • Interfaces/IWebPreferences.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::isDOMPasteAllowed): (WebPreferences::setDOMPasteAllowed):
  • WebPreferences.h:
  • WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences):
4:19 PM Changeset in webkit [24128] by andersca
  • 2 edits in trunk/WebKit/win

Build fix.

  • WebView.cpp: (WebView::stringByEvaluatingJavaScriptFromString):
4:18 PM Changeset in webkit [24127] by andersca
  • 2 edits in trunk/WebCore

Build fix.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):
3:10 PM Changeset in webkit [24126] by andersca
  • 10 edits in trunk/WebCore

Reviewed by Geoff.

Get rid of the node argument in our various script execution functions.


  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate):
  • bindings/js/kjs_proxy.h:
  • bindings/js/kjs_window.cpp: (KJS::ScheduledAction::execute):
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::endElementNs): (WebCore::XMLTokenizer::notifyFinished):
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::evaluateScript):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::replaceContentsWithScriptResult): (WebCore::FrameLoader::executeScript):
  • loader/FrameLoader.h:
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]): (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
3:06 PM Changeset in webkit [24125] by kmccullo
  • 1 edit
    20 adds in trunk/WebKitTools

Reviewed by Adam, Sam, and Ada.

  • Inital checkin of Drosera for Win. This isn't pretty and doesn't connect to Safari but debug builds and runs.
  • Drosera/Images/Drosera.ico: Added.
  • Drosera/Images/small.ico: Added.
  • Drosera/win: Added.
  • Drosera/win/BaseDelegate.h: Added. (BaseDelegate::QueryInterface): (BaseDelegate::didFinishLoadForFrame): (BaseDelegate::windowScriptObjectAvailable): (BaseDelegate::didStartProvisionalLoadForFrame): (BaseDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): (BaseDelegate::didFailProvisionalLoadWithError): (BaseDelegate::didCommitLoadForFrame): (BaseDelegate::didReceiveTitle): (BaseDelegate::didReceiveIcon): (BaseDelegate::didFailLoadWithError): (BaseDelegate::didChangeLocationWithinPageForFrame): (BaseDelegate::willPerformClientRedirectToURL): (BaseDelegate::didCancelClientRedirectForFrame): (BaseDelegate::willCloseFrame): (BaseDelegate::createWebViewWithRequest): (BaseDelegate::webViewShow): (BaseDelegate::webViewClose): (BaseDelegate::webViewFocus): (BaseDelegate::webViewUnfocus): (BaseDelegate::webViewFirstResponder): (BaseDelegate::makeFirstResponder): (BaseDelegate::setStatusText): (BaseDelegate::webViewStatusText): (BaseDelegate::webViewAreToolbarsVisible): (BaseDelegate::setToolbarsVisible): (BaseDelegate::webViewIsStatusBarVisible): (BaseDelegate::setStatusBarVisible): (BaseDelegate::webViewIsResizable): (BaseDelegate::setResizable): (BaseDelegate::setFrame): (BaseDelegate::webViewFrame): (BaseDelegate::setContentRect): (BaseDelegate::webViewContentRect): (BaseDelegate::runJavaScriptAlertPanelWithMessage): (BaseDelegate::runJavaScriptConfirmPanelWithMessage): (BaseDelegate::runJavaScriptTextInputPanelWithPrompt): (BaseDelegate::runBeforeUnloadConfirmPanelWithMessage): (BaseDelegate::runOpenPanelForFileButtonWithResultListener): (BaseDelegate::mouseDidMoveOverElement): (BaseDelegate::contextMenuItemsForElement): (BaseDelegate::validateUserInterfaceItem): (BaseDelegate::shouldPerformAction): (BaseDelegate::dragDestinationActionMaskForDraggingInfo): (BaseDelegate::willPerformDragDestinationAction): (BaseDelegate::dragSourceActionMaskForPoint): (BaseDelegate::willPerformDragSourceAction): (BaseDelegate::contextMenuItemSelected): (BaseDelegate::hasCustomMenuImplementation): (BaseDelegate::trackCustomPopupMenu): (BaseDelegate::measureCustomMenuItem): (BaseDelegate::drawCustomMenuItem): (BaseDelegate::addCustomMenuDrawingData): (BaseDelegate::cleanUpCustomMenuDrawingData): (BaseDelegate::canTakeFocus): (BaseDelegate::takeFocus): (BaseDelegate::registerUndoWithTarget): (BaseDelegate::removeAllActionsWithTarget): (BaseDelegate::setActionTitle): (BaseDelegate::undo): (BaseDelegate::redo): (BaseDelegate::canUndo): (BaseDelegate::canRedo):
  • Drosera/win/DebuggerApplication.cpp: Added. (DebuggerApplication::serverLoaded): (DebuggerApplication::serverUnloaded): (DebuggerApplication::attach): (DebuggerApplication::numberOfRowsInTableView): (DebuggerApplication::tableView):
  • Drosera/win/DebuggerApplication.h: Added. (DebuggerApplication::DebuggerApplication): (DebuggerApplication::knownServers):
  • Drosera/win/DebuggerObjectCallbacks.cpp: Added. (breakpointEditorHTMLCallback): (currentFunctionStackCallback): (doubleClickMillisecondsCallback): (evaluateScript_inCallFrame_Callback): (isPausedCallback): (localScopeVariableNamesForCallFrame_Callback): (pauseCallback): (resumeCallback): (stepIntoCallback): (valueForScopeVariableNamed_inCallFrame_Callback): (staticFunctions):
  • Drosera/win/DebuggerObjectCallbacks.h: Added.
  • Drosera/win/Drosera.cpp: Added. (_tWinMain): (RegisterDroseraClass): (DroseraWndProc): (About): (Attach): (Drosera::Drosera): (Drosera::initUI): (Drosera::QueryInterface): (Drosera::AddRef): (Drosera::Release): (Drosera::didFinishLoadForFrame): (getDroseraJSClass): (Drosera::windowScriptObjectAvailable): (Drosera::webViewClose): (Drosera::validateUserInterfaceItem): (Drosera::runJavaScriptAlertPanelWithMessage): (Drosera::onSize):
  • Drosera/win/Drosera.h: Added. (Drosera::webViewLoaded):
  • Drosera/win/Drosera.vcproj: Added.
  • Drosera/win/Drosera.vcproj/Drosera.rc: Added.
  • Drosera/win/Drosera.vcproj/Drosera.vcproj: Added.
  • Drosera/win/Drosera.vcproj/debug.vsprops: Added.
  • Drosera/win/Drosera.vcproj/release.vsprops: Added.
  • Drosera/win/HelperFunctions.h: Added. (CFStringToBSTR):
  • Drosera/win/Info.plist: Added.
  • Drosera/win/resource.h: Added.
  • Drosera/win/stdafx.cpp: Added.
  • Drosera/win/stdafx.h: Added.
2:25 PM Changeset in webkit [24124] by staikos
  • 2 edits in trunk/WebKitQt

Patch from Eli Fidler to properly decode data: urls.

2:23 PM Changeset in webkit [24123] by justing
  • 7 edits
    1 add
    1 delete in trunk

LayoutTests:

Rolling the fix for 5310404 back in now that 5310404 has been fixed in Mail.

  • editing/deleting/4845371-expected.checksum:
  • editing/deleting/4845371-expected.txt:
  • editing/deleting/4845371.html:
  • editing/deleting/5126166-expected.txt:
  • editing/deleting/5290534.html: Added.
  • editing/deleting/5290534.html-disabled: Removed.

WebCore:

Rolling the fix for 5290534 back in now that 5310404 has been fixed in Mail.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete):
2:08 PM Changeset in webkit [24122] by ggaren
  • 4 edits in trunk/WebCore

Reviewed by Anders Carlsson.

A little more FrameLoader cleanup while working on <rdar://problem/5126396>.


Rename: "checkEmitLoadEvent" => "checkCallImplicitClose" because the function
doesn't emit the load event; it just calls implicitClose.


Rename: "m_wasLoadEventEmitted" => "m_didCallImplicitClose" because the variable
tracks whether implicitClose was called.

  • dom/Document.cpp: (WebCore::Document::implicitClose): Turned 12 lines of code into 6, adding ASSERT.
  • loader/FrameLoader.h: Removed bogus declaration of non-existent emitLoadEvent().
2:06 PM Changeset in webkit [24121] by brmorris
  • 2 edits in S60/trunk/WebKit

brmorris, rs'd by sachin

DESC: remove a compile warning by generating version info earlier

in the build process.

1:27 PM Changeset in webkit [24120] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by John.


<rdar://problem/5156801> REGRESSION: Crash when deleting table content in Leopard Mail

  • editing/deleting/5156801-expected.checksum: Added.
  • editing/deleting/5156801-expected.png: Added.
  • editing/deleting/5156801-expected.txt: Added.
  • editing/deleting/5156801.html: Added.

WebCore:

Reviewed by John.


REGRESSION: Crash when deleting table content in Leopard Mail

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete): Use a RefPtr for the next node to delete, in case it is destroyed when the current node is deleted. In the crash reported in the radar, we crash because the next node is the div that holds the delete button and it's destroyed when the node that contains the selection is removed.
12:41 PM Changeset in webkit [24119] by staikos
  • 18 edits in trunk

Patch from Adam Treat to convert QWebFrame from QFrame to QObject. Fixes many
regressions from the previous patch.

11:28 AM Changeset in webkit [24118] by andersca
  • 11 edits
    2 adds in trunk

LayoutTests:

Reviewed by Oliver.

<rdar://problem/4954319>
Acrobat 7 / Safari crash: CrashTracer: 99 crashes in Safari at
com.apple.WebCore: WebCore::NetscapePlugInStreamLoader::isDone const + 0


Add tests.


  • plugins/return-error-from-new-stream-callback-in-full-frame-plugin-expected.txt: Added.
  • plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html: Added.

WebCore:

Reviewed by Oliver.

Add DocumentLoader::isLoadingMainResource.

  • WebCore.exp:

WebKit:

Reviewed by Oliver.

<rdar://problem/4954319>
Acrobat 7 / Safari crash: CrashTracer: 99 crashes in Safari at
com.apple.WebCore: WebCore::NetscapePlugInStreamLoader::isDone const + 0

Add a new initWithFrameLoader: method to WebNetscapePluginStream which is to be used when
the stream is a "fake" stream for full frame plug-ins.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView pluginView:receivedResponse:]):
  • Plugins/WebNetscapePluginStream.h:
  • Plugins/WebNetscapePluginStream.mm: (-[WebNetscapePluginStream initWithFrameLoader:]): (-[WebNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]): (-[WebNetscapePluginStream start]): (-[WebNetscapePluginStream cancelLoadWithError:]): (-[WebNetscapePluginStream stop]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createFrame):

WebKitTools:

Reviewed by Oliver.

<rdar://problem/4954319>
Acrobat 7 / Safari crash: CrashTracer: 99 crashes in Safari at
com.apple.WebCore: WebCore::NetscapePlugInStreamLoader::isDone const + 0


If the src url is "data:application/x-webkit-test-netscape,returnerrorfromnewstream",
return an error from NPP_NewStream.


  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginAllocate):
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_New): (NPP_NewStream):
10:45 AM Changeset in webkit [24117] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin


  • fixed <rdar://problem/5320208> WebKit should prevent Time Machine from backing up WebKit clients' icon databases
  • Misc/WebIconDatabase.mm: (-[WebIconDatabase init]): Re-added the code to exclude the icon database from backups. We now do this at the same time we (try to) import the old icon database format, which happens only once per icon database's lifetime. (-[WebIconDatabase _importToWebCoreFormat]): Assert that we haven't imported yet rather than bailing out. It's now the caller's responsibility to check whether we've imported yet.
10:44 AM Changeset in webkit [24116] by sullivan
  • 1 edit in trunk/WebCore/ChangeLog

added missing Reviewer to previous checkin

10:43 AM Changeset in webkit [24115] by sullivan
  • 2 edits in trunk/WebCore
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj: exported String::createCFString, needed for <rdar://problem/5320208>
10:21 AM Changeset in webkit [24114] by staikos
  • 2 edits in trunk/WebKitQt

Fix a minor memory leak in the loader

9:52 AM Changeset in webkit [24113] by staikos
  • 2 edits in trunk/WebKitQt

Fix a massive memory leak in the loader.

8:04 AM Changeset in webkit [24112] by yongjzha
  • 2 edits in S60/branches/3.1m/JavaScriptCore

ligman, reviewed by Yongjun Zhang

DESC: Character class array is defined to 32. If we don't limit characters to 255 an overflow occurs.
​http://bugs.webkit.org/show_bug.cgi?id=14435

  • pcre/pcre.c: (compile_branch): (match):
8:01 AM Changeset in webkit [24111] by yongjzha
  • 2 edits in S60/trunk/JavaScriptCore

ligman, reviewed by Yongjun Zhang

DESC: Character class array is defined to 32. If we don't limit characters to 255 an overflow occurs.
​http://bugs.webkit.org/show_bug.cgi?id=14435

  • pcre/pcre.c: (compile_branch): (match):
7:54 AM Changeset in webkit [24110] by yongjzha
  • 4 edits in S60/branches/3.1m/WebCore

2007-06-29 bujtas <​zbujtas@gmail.com>

Reviewed by Yongjun
DESC: ref images right before switching to the final document,
so they dont get deleted.
​http://bugs.webkit.org/show_bug.cgi?id=14464

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/khtml_part.cpp: (KHTMLPart::switchToFinalDoc):
  • khtml/misc/loader.h: (khtml::):
  • khtml/misc/loader_client.h: (khtml::DummyCachedObjectClient::~DummyCachedObjectClient): (khtml::DummyCachedObjectClient::setPixmap): (khtml::DummyCachedObjectClient::setStyleSheet): (khtml::DummyCachedObjectClient::setXBLDocument): (khtml::DummyCachedObjectClient::notifyFinished):
7:53 AM Changeset in webkit [24109] by yongjzha
  • 4 edits in S60/trunk/WebCore

2007-06-29 bujtas <​zbujtas@gmail.com>

Reviewed by Yongjun
DESC: ref images right before switching to the final document,
so they dont get deleted.
​http://bugs.webkit.org/show_bug.cgi?id=14464

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/khtml_part.cpp: (KHTMLPart::switchToFinalDoc):
  • khtml/misc/loader.h: (khtml::):
  • khtml/misc/loader_client.h: (khtml::DummyCachedObjectClient::~DummyCachedObjectClient): (khtml::DummyCachedObjectClient::setPixmap): (khtml::DummyCachedObjectClient::setStyleSheet): (khtml::DummyCachedObjectClient::setXBLDocument): (khtml::DummyCachedObjectClient::notifyFinished):
7:50 AM Changeset in webkit [24108] by staikos
  • 4 edits in trunk/WebKitQt

Rework much of WebCoreHttp to make it more stable and support Proxy and SSL.

12:57 AM Changeset in webkit [24107] by mjs
  • 1 edit
    1 add in trunk/WebCore

Reviewed by Maciej.

Test case for the bug below, which is ​http://bugs.webkit.org/show_bug.cgi?id=14207

  • manual-tests/flash-unload-tab.html: Added.
12:39 AM Changeset in webkit [24106] by mjs
  • 4 edits in trunk

JavaScriptCore:

Reviewed by Oliver.


  • JavaScriptCore part of fix for: <rdar://problem/5295734> Repro crash closing tab/window @ maps.google.com in WTF::HashSet<KJS::RuntimeObjectImp*, WTF::PtrHash<KJS::RuntimeObjectImp*>, WTF::HashTraits<KJS::RuntimeObjectImp*> >::add + 11


WebCore:

Reviewed by Oliver.

<rdar://problem/5295734> Repro crash closing tab/window @ maps.google.com in WTF::HashSet<KJS::RuntimeObjectImp*, WTF::PtrHash<KJS::RuntimeObjectImp*>, WTF::HashTraits<KJS::RuntimeObjectImp*> >::add + 11


Automated test case is not possible. Did not bother with manual test this time.

  • bindings/js/kjs_dom.cpp: (WebCore::getRuntimeObject): Check that runtime root isn't null, as well as instance; this should cover the case where the plugin is already shut down and onunload time.
Note: See TracTimeline for information about the timeline view.