⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 12, 2007:

10:46 PM Changeset in webkit [24253] by bdash
  • 10 edits in trunk

2007-07-13 Mark Rowe <​mrowe@apple.com>

Reviewed by Mitz.

Build fix. Stub out ChromeClientGdk::print and SVGEmptyChromeClient::print.

  • platform/gdk/ChromeClientGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp: (ChromeClientGdk::print):
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::print):

2007-07-13 Mark Rowe <​mrowe@apple.com>

Reviewed by Mitz.

Build fix. Stub out WebChromeClient::print.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::print):

2007-07-13 Mark Rowe <​mrowe@apple.com>

Reviewed by Mitz.

Build fix. Stub out ChromeClientQt::print.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::print):
  • WebCoreSupport/ChromeClientQt.h:
10:00 PM Changeset in webkit [24252] by aliceli1
  • 10 edits in trunk

WebCore:

Reviewed by Maciej and Steve.

fixed <rdar://4982432> window.print() needs to be implemented

  • bridge/win/FrameWin.cpp: (WebCore::Frame::print):
  • page/Chrome.cpp: (WebCore::Chrome::print):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/win/TemporaryLinkStubs.cpp:

win:

Reviewed by Maciej and Steve.

fixed <rdar://4982432> window.print() needs to be implemented

  • Interfaces/IWebUIDelegate.idl:
  • WebChromeClient.cpp: (WebChromeClient::print):
  • WebChromeClient.h:
8:16 PM Changeset in webkit [24251] by ddkilzer
  • 2 edits in trunk/LayoutTests

2007-07-12 George Staikos <​staikos@kde.org>

Reviewed by NOBODY.

Backed out previous change. This worked fine with Safari, but not so much with DumpRenderTree.

  • http/tests/security/cross-frame-access-put.html:
7:53 PM Changeset in webkit [24250] by ddkilzer
  • 2 edits in trunk/LayoutTests

2007-07-12 David Kilzer <​ddkilzer@apple.com>

Reviewed by NOBODY.

Don't hard code the hostname to make it work with run-webkit-httpd on other interfaces.

  • http/tests/security/cross-frame-access-put.html:
1:04 PM Changeset in webkit [24249] by bdash
  • 1 edit in tags/Safari-5522.11.2/WebCore/Configurations/Version.xcconfig

Versioning.

1:02 PM Changeset in webkit [24248] by bdash
  • 3 edits
    4 adds in tags/Safari-5522.11.2

Merge r24245.

12:42 PM Changeset in webkit [24247] by bdash
  • 1 copy in tags/Safari-5522.11.2

New tag.

12:41 PM Changeset in webkit [24246] by bdash
  • 1 delete in tags/Safari-5522.11.1/Safari-5522.11

Remove broken tag.

12:26 PM Changeset in webkit [24245] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Harrison.


<rdar://problem/5300379> Mail hung on option-delete

  • editing/deleting/5300379-expected.checksum: Added.
  • editing/deleting/5300379-expected.png: Added.
  • editing/deleting/5300379-expected.txt: Added.
  • editing/deleting/5300379.html: Added.

WebCore:

Reviewed by Harrison.


<rdar://problem/5300379> Mail hung on option-delete


We were starting backward iteration at [container, 0] and
emitting for container over and over.

  • editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::advance): Don't emit characters for a node if we're starting iteration at [container, 0]. Don't emit characters for exiting containers if we've already done so.
12:14 PM Changeset in webkit [24244] by ap
  • 2 edits in trunk/JavaScriptCore

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=14596
Fix JSC compilation with KJS_VERBOSE.

  • kjs/function.cpp: (KJS::FunctionImp::passInParameters):
11:46 AM Changeset in webkit [24243] by bdash
  • 1 copy in tags/Safari-5522.11.1/Safari-5522.11

New tag.

10:37 AM Changeset in webkit [24242] by kdecker
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

<rdar://problem/5039463> find a good gray that works well for full frame plug-ins; consistent look for plugins

  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure): Changed values to a darker gray, per request from the HI team.
9:34 AM Changeset in webkit [24241] by weinig
  • 9 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test for <rdar://problem/5329841>
Calling window.closed on a closed window causes Safari to crash

  • fast/dom/Window/window-closed-crash-expected.txt: Added.
  • fast/dom/Window/window-closed-crash.html: Added.

WebCore:

Reviewed by Maciej.

Patch for <rdar://problem/5329841>
Calling window.closed on a closed window causes Safari to crash

  • Replaces the Frame member variable in KJS::Window for more appropriate DOMWindow
  • Adds additional new null checks as necessary
  • Removes bogus toBoolean method
  • Removes unused scheduleClose method

Test: fast/dom/Window/window-closed-crash.html

  • bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::create):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot): (WebCore::JSDOMWindow::customPut):
  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction):
  • bindings/js/kjs_events.cpp: (WebCore::JSAbstractEventListener::handleEvent): (WebCore::JSLazyEventListener::parseCode):
  • bindings/js/kjs_window.cpp: (KJS::Window::Window): (KJS::Window::impl): (KJS::Window::interpreter): (KJS::Window::location): (KJS::Window::find): (KJS::allowPopUp): (KJS::createWindow): (KJS::canShowModalDialog): (KJS::canShowModalDialogNow): (KJS::showModalDialog): (KJS::Window::getValueProperty): (KJS::Window::childFrameGetter): (KJS::Window::indexGetter): (KJS::Window::namedItemGetter): (KJS::Window::getOwnPropertySlot): (KJS::Window::put): (KJS::Window::isSafeScript): (KJS::Window::setListener): (KJS::Window::getListener): (KJS::Window::clear): (KJS::WindowFunc::callAsFunction): (KJS::Window::updateLayout): (KJS::ScheduledAction::execute): (KJS::Window::disconnectFrame): (KJS::Location::put): (KJS::LocationFunc::callAsFunction):
  • bindings/js/kjs_window.h:
  • page/mac/WebCoreFrameBridge.mm: (updateRenderingForBindings):
9:24 AM Changeset in webkit [24240] by bdash
  • 2 edits in trunk/LayoutTests

2007-07-12 Mitz Pettel <​mitz@webkit.org>

Reviewed by Mark Rowe.

  • try to fix hang seen on buildbot after the last fix
  • fast/history/resources/history_reload_window.html:
8:15 AM Changeset in webkit [24239] by bdash
  • 2 edits in trunk/LayoutTests

2007-07-12 Mitz Pettel <​mitz@webkit.org>

Reviewed by Mark Rowe.

  • fix an assertion failure in DumpRenderTree when running fast/history/resources/history_reload_window.html
  • fast/history/resources/history_reload_window.html: Delay notifyDone() until after the window actually closes.
7:47 AM BuildingQtOnLinux edited by treat@kde.org
(diff)
7:47 AM BuildingQtOnLinux edited by treat@kde.org
(diff)
7:01 AM Changeset in webkit [24238] by bdash
  • 5 edits in trunk

2007-07-12 Mark Rowe <​mrowe@apple.com>

Reviewed by Ada.

<rdar://problem/5329877> REGRESSION: Document::setTransformSource leaks an xmlDocPtr if called more than once per document

  • dom/Document.cpp: (WebCore::Document::setTransformSource): Free any existing m_transformSource before overwriting it, rather than simply leaking it.
  • dom/Document.h:

2007-07-12 Mark Rowe <​mrowe@apple.com>

Reviewed by Ada.

Remove leak suppression for xmlDocPtrForString now that <rdar://problem/5329877> is fixed.

  • Scripts/run-webkit-tests:
4:18 AM Changeset in webkit [24237] by bdash
  • 3 edits in trunk/LayoutTests

2007-07-12 Maxime Britto <​mbritto@pleyo.com>

Reviewed by Mark Rowe.

Update the expected results now that they match what the test describes as the correct rendering.

  • svg/custom/invalid-fill-hex-expected.txt:
  • svg/custom/invalid-fill-hex-expected.png:
3:49 AM Changeset in webkit [24236] by bdash
  • 2 edits in trunk/WebCore

2007-07-12 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Mark Rowe.

Fix compilation of the CURL backend after the removing of accessors from ResourceHandle in r24202

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::setupPOST): (WebCore::ResourceHandleManager::startJob):
1:15 AM Changeset in webkit [24235] by ggaren
  • 3 edits in trunk/WebKitTools

Reviewed by Oliver Hunt.


Made the leaks tests pass on Leopard.

  • Scripts/run-webkit-tests: Added some leaks to exclude on Leopard.
  • Scripts/run-leaks: Updated parser for slight change in text output.
12:21 AM Changeset in webkit [24234] by bdash
  • 2 edits in trunk/WebCore

2007-07-12 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin.

<rdar://problem/5327189> Logic error in DeprecatedString::to{,U}Int{,64} can lead to reading past end of buffer

The fix for reading past the end of the buffer is to verify we are not at the end of the string before checking
for a leading '+' character. Rather than fixing the logic error in four nearly-identical functions I chose to
extract the common functionality into the toIntegralType helper function which the four functions call through to.

  • platform/DeprecatedString.cpp: (WebCore::isCharacterAllowedInBase): (WebCore::toIntegralType): (WebCore::DeprecatedString::toInt): (WebCore::DeprecatedString::toInt64): (WebCore::DeprecatedString::toUInt): (WebCore::DeprecatedString::toUInt64):

Jul 11, 2007:

11:23 PM Changeset in webkit [24233] by sfalken
  • 1 copy in tags/Safari-522.14.1b

New tag.

11:23 PM Changeset in webkit [24232] by sfalken
  • 1 edit in trunk/WebKit/win/WebKit.vcproj/VERSION

Bump version for submit

11:21 PM Changeset in webkit [24231] by sfalken
  • 1 delete in tags/Safari-522.14.1b

Remove unneeded tag.

11:15 PM Changeset in webkit [24230] by sfalken
  • 1 copy in tags/Safari-522.14.1b

New tag.

10:06 PM Changeset in webkit [24229] by staikos
  • 3 edits in trunk/WebCore

remove two unused variables and fix combobox rendering

9:34 PM Changeset in webkit [24228] by oliver
  • 2 edits in trunk/WebCore

Reviewed by Maciej

Fix for <rdar://problem/5329712> GMail crash when trying to compose new message

  • platform/win/FontDataWin.cpp: (WebCore::FontData::containsCharacters):
9:17 PM Changeset in webkit [24227] by ap
  • 6 edits
    1 move
    4 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=14584
XMLHttpRequest treats null login/password incorrectly

Test: http/tests/xmlhttprequest/null-auth.php

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::open):
  • xml/xmlhttprequest.h: Split the open() method into three to distinguish between missing and null credentials.
  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction): Call the appropriate open().
8:04 PM Changeset in webkit [24226] by staikos
  • 2 edits in trunk

Fix build in debug mode

7:48 PM Changeset in webkit [24225] by ddkilzer
  • 2 edits in trunk/WebKitTools

2007-07-11 David Kilzer <​ddkilzer@apple.com>

Reviewed by Maciej.

Update the iExploder list of CSS properties after box-sizing was renamed to
-webkit-box-sizing in r21026 to fix <rdar://problem/4667227>.

  • iExploder/htdocs/cssproperties.in: Added -webkit-box-sizing. Both box-sizing and -moz-box-sizing remain.
7:22 PM Changeset in webkit [24224] by staikos
  • 1 edit
    11 adds in trunk/JavaScriptCore

Make it compile

7:07 PM Changeset in webkit [24223] by oliver
  • 2 edits in trunk/WebCore

Build fix for windows

  • page/Frame.cpp: (WebCore::Frame::firstRectForRange):
6:20 PM Changeset in webkit [24222] by oliver
  • 5 edits in trunk/WebCore

Reviewed by Maciej.

Fix <rdar://problem/5329481> Character range rect code for IME support needs to be crossplatform

Move -[WebCoreFrameBridge firstRectForDOMRange:] to Frame::firstRectForRange

  • page/Frame.cpp: (WebCore::Frame::firstRectForRange):
  • page/Frame.h:
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge firstRectForDOMRange:]):
5:27 PM Changeset in webkit [24221] by thatcher
  • 3 edits in tags

Versioning

5:26 PM Changeset in webkit [24220] by thatcher
  • 3 edits in tags

Turn off -Wshorten-64-to-32 for now.

5:23 PM Changeset in webkit [24219] by thatcher
  • 1 copy in tags/Safari-5522.11.1

New tag.

4:47 PM Changeset in webkit [24218] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebView.cpp

Make sure we got a result before trying to convert it.

4:46 PM Changeset in webkit [24217] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebFrame.cpp

Don't automatically load an URL.

4:17 PM Changeset in webkit [24216] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Oliver.

<rdar://problem/5108789> WEBVIEW: Drawing artifacts when dragging in IB

Interface Builder 3 is relying on KVO notifications for frameOrigin and frameSize,
among other standard NSView keys. Change automaticallyNotifiesObserversForKey to
return NO only for keys WebView manually fires notifications for.

  • WebView/WebView.mm: (+[WebView automaticallyNotifiesObserversForKey:]): Selectivly return NO for keys we manually fire. (-[WebView _declaredKeys]): Code clean up.
3:49 PM Changeset in webkit [24215] by sfalken
  • 2 edits in trunk/WebKit/win

Static analysis build fix.


Only specify /analyze (PREfast) if it is available.
Prevents entire project from rebuilding each time.

Reviewed by Hyatt.

  • WebKit.vcproj/WebKit.vcproj:
3:49 PM Changeset in webkit [24214] by sfalken
  • 2 edits in trunk/WebCore

Static analysis build fix.


Only specify /analyze (PREfast) if it is available.
Prevents entire project from rebuilding each time.

Reviewed by Hyatt.

  • WebCore.vcproj/WebCore.vcproj:
3:01 PM Changeset in webkit [24213] by staikos
  • 3 edits in trunk/WebCore

Make comboboxes update when the current item is changed.

12:59 PM Changeset in webkit [24212] by staikos
  • 2 edits in trunk/WebCore

Add a destructor to cleanup the SQL handle (presently unused, but will be soon).

12:29 PM Changeset in webkit [24211] by staikos
  • 2 edits in trunk/WebKitQt

Fix build with assertions.

12:24 PM Changeset in webkit [24210] by darin
  • 5 edits
    1 delete in trunk

top level:

Reviewed by Darin.

As of ​http://bugs.webkit.org/show_bug.cgi?id=14527 move the
WebCore/ForwardingHeader/JavaScriptCore to JavaScriptCore

  • WebKit.pri: Adjust INCLUDEPATH

JavaScriptCore:

Reviewed by Darin.

As of ​http://bugs.webkit.org/show_bug.cgi?id=14527 move the
WebCore/ForwardingHeader/JavaScriptCore to JavaScriptCore

  • ForwardingHeaders: Added.
  • ForwardingHeaders/JavaScriptCore: Copied from WebCore/ForwardingHeaders/JavaScriptCore.

WebCore:

Reviewed by Darin.

As of ​http://bugs.webkit.org/show_bug.cgi?id=14527 move the
WebCore/ForwardingHeader/JavaScriptCore to JavaScriptCore

  • ForwardingHeaders/JavaScriptCore: Removed.
  • ForwardingHeaders/JavaScriptCore/APICast.h: Removed.
  • ForwardingHeaders/JavaScriptCore/JSBase.h: Removed.
  • ForwardingHeaders/JavaScriptCore/JSContextRef.h: Removed.
  • ForwardingHeaders/JavaScriptCore/JSLock.h: Removed.
  • ForwardingHeaders/JavaScriptCore/JSObjectRef.h: Removed.
  • ForwardingHeaders/JavaScriptCore/JSStringRef.h: Removed.
  • ForwardingHeaders/JavaScriptCore/JSStringRefCF.h: Removed.
  • ForwardingHeaders/JavaScriptCore/JSValueRef.h: Removed.
  • ForwardingHeaders/JavaScriptCore/JavaScriptCore.h: Removed.
12:22 PM Changeset in webkit [24209] by andersca
  • 2 edits in trunk/WebCore

Fix build.


  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::didReceiveResponse): (WebCore::didReceiveData): (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::didReceiveChallenge):
12:20 PM Changeset in webkit [24208] by staikos
  • 2 edits in trunk/WebKitQt

Another build fix.

12:16 PM Changeset in webkit [24207] by staikos
  • 2 edits in trunk/WebCore

Repair the build.

12:09 PM Changeset in webkit [24206] by adele
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/5230188> REGRESSION: Active/inactive marked text is not distinguished in textfields and textareas

We were previously trying to leave room for 1px of space between the text and the underline.
This change removes that requirement so that if we don't have room for the extra space, we still draw the thick underline
touching the text.

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintMarkedTextUnderline):
11:47 AM Changeset in webkit [24205] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Darin and Geoff.

<rdar://problem/5313508>
REGRESSION (Leopard): http/tests/xmlhttprequest/basic-auth.html hangs


Leopard Foundation now ignores credentials passed in as part of the URL so we need to pass them ourselves.


For the asynchronous case, we simply keep track of the URL and if it has a user name and password, we
pass those if we're asked to authenticate.


For the synchronous case, implement a new connection delegate and run it in a separate mode so
no other sources will fire.

  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::loadResourceSynchronously): (-[WebCoreResourceHandleAsDelegate dealloc]): (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebCoreSynchronousLoader _isDone]): (-[WebCoreSynchronousLoader dealloc]): (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): (-[WebCoreSynchronousLoader connection:didReceiveResponse:]): (-[WebCoreSynchronousLoader connection:didReceiveData:]): (-[WebCoreSynchronousLoader connectionDidFinishLoading:]): (-[WebCoreSynchronousLoader connection:didFailWithError:]): (-[WebCoreSynchronousLoader _data]): (-[WebCoreSynchronousLoader _response]): (-[WebCoreSynchronousLoader _error]): (+[WebCoreSynchronousLoader loadRequest:returningResponse:error:]):
11:21 AM Changeset in webkit [24204] by andersca
  • 2 edits in trunk/LayoutTests

Reviewed by Geoff.

Create the lock file in a writable directory.


  • http/conf/apache2-httpd.conf:
11:11 AM Changeset in webkit [24203] by darin
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • fix <rdar://problem/5315265> REGRESSION: Leopard launch time - there are about 190 stats of icudt36b files during launch
  • platform/TextEncodingRegistry.cpp: (WebCore::atomicCanonicalTextEncodingName): Add a special case for the empty string so we don't load the extended text encodings just so we can return 0 for that case.
10:12 AM Changeset in webkit [24202] by andersca
  • 5 edits in trunk/WebCore

Reviewed by Darin.

Remove a bunch of unneeded accessors from ResourceHandle.


  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveResponse): (WebCore::IconLoader::didFail): (WebCore::IconLoader::didFinishLoading):
  • platform/network/ResourceHandle.cpp:
  • platform/network/ResourceHandle.h:
6:26 AM Changeset in webkit [24201] by bdash
  • 4 edits in tags/Safari-5522.11

Versioning.

6:14 AM Changeset in webkit [24200] by bdash
  • 9 deletes in tags/Safari-5522.11/WebCore/ForwardingHeaders/JavaScriptCore

Remove WebCore/ForwardingHeaders/JavaScriptCore to prevent the WebCore build from failing.

6:12 AM Changeset in webkit [24199] by bdash
  • 11 edits in tags/Safari-5522.11

Merge r24156, and follow-up fixes r24159 and r24171.

5:56 AM Changeset in webkit [24198] by zimmermann
  • 2 edits in trunk/JavaScriptCore

Reviewed by Mark.

Forwardport the hash table fix from CodeGeneratorJS.pm to create_hash_table.
Reran run-jsc-tests, couldn't find any regressions. Suggested by Darin.

5:49 AM Changeset in webkit [24197] by bdash
  • 1 copy in tags/Safari-5522.11

New tag.

5:46 AM Changeset in webkit [24196] by zimmermann
  • 2 edits in branches/feature-branch/JavaScriptCore

Reviewed by Mark.

Forwardport the hash table fix from CodeGeneratorJS.pm to create_hash_table.
Reran run-jsc-tests, couldn't find any regressions. Suggested by Darin.

5:00 AM Changeset in webkit [24195] by zimmermann
  • 88 edits in branches/feature-branch

Rubber stamped by Mark.

WebKitTools:
Enable svg experimental features as default here in feature-branch.

LayoutTests:
Land new test results with experimental features on by default.
Files showing regressions have NOT been updated, of course.

4:31 AM Changeset in webkit [24194] by zimmermann
  • 33 edits in branches/feature-branch

WebCore:
Reviewed by Sam.

Remove all "SVGElement* m_context" parameters spread over SVG primitives
(like SVGAngle, SVGPreserveAspectRatio, SVGTransformList, ...)

This is all handled by the JS generation in the bindings now, leading
to a faster static rendering codepaths, and easier handling of the dynamic
parts like JS scripting. Remove the mystified genericContext() concept alltogether.

Add bug number reference missing in the last ChangeLog entry.

LayoutTests:
Reviewed by Sam.
Check in correct results, now that the hashing bug is fixed here as well.

3:36 AM Changeset in webkit [24193] by bdash
  • 1 copy in tags/WebKit-312.9/WebKit

New tag (part 2).

3:36 AM Changeset in webkit [24192] by bdash
  • 1 copy in tags/WebCore-315.15/WebCore

New tag (part 2).

3:35 AM Changeset in webkit [24191] by bdash
  • 1 add in tags/WebKit-312.9

New tag (part 1).

3:34 AM Changeset in webkit [24190] by bdash
  • 1 add in tags/WebCore-315.15

New tag (part 1).

3:34 AM Changeset in webkit [24189] by bdash
  • 4 edits in branches/Safari-1-3-branch

Versioning.

3:34 AM Changeset in webkit [24188] by bdash
  • 2 edits in branches/Safari-1-3-branch/WebCore

2007-07-09 Mark Rowe <​mrowe@apple.com>

Merge r18365 from ToT to Safari-1-3-branch.

2006-12-20 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.

Fixed <rdar://problem/4809825>. We need to check isSafeScript when converting
a Location to string.

It's really a bug, and poor design, for objects to override toString.
Subclasses that want custom toString implementations should add a toString
function to their prototypes instead of overriding the JavaScript ToString
operation. Following this design pattern would have avoided this bug in the
first place.

  • bindings/js/kjs_window.cpp: (KJS::Location::toString):
3:21 AM Changeset in webkit [24187] by justing
  • 4 edits
    8 adds in trunk

LayoutTests:

Reviewed by Darin.


<rdar://problem/5234383> REGRESSION: Sentence breaker method returning entire document length

  • editing/selection/5234383-1-expected.checksum: Added.
  • editing/selection/5234383-1-expected.png: Added.
  • editing/selection/5234383-1-expected.txt: Added.
  • editing/selection/5234383-1.html: Added.
  • editing/selection/5234383-2-expected.checksum: Added.
  • editing/selection/5234383-2-expected.png: Added.
  • editing/selection/5234383-2-expected.txt: Added.
  • editing/selection/5234383-2.html: Added.

WebCore:

Reviewed by Darin.


<rdar://problem/5234383> REGRESSION: Sentence breaker method returning entire document length


The functions for moving the caret to the next/previous sentence boundary
were in many cases moving to the beginning/end of the document. The functions that
should move the caret to an equivalent position in the next/previous sentence behaved
like the aforementioned functions ought to. Put the code from the second two functions
in the first and made sure that the second two are properly FIXMEd. They're rarely
used (filed 5323691).


  • editing/SelectionController.cpp: (WebCore::SelectionController::modify): Added an option for sentenceBoundary granularity, so that we can test the functions that were broken from JS.
  • editing/visible_units.cpp: (WebCore::startOfSentence): Removed the FIXME about 5234383. (WebCore::endSentenceBoundary): Make this function do what nextSentencePositionBoundary current does. (WebCore::endOfSentence): Removed the FIXME about 5234383. (WebCore::previousSentencePosition): Removed an incorrect FIXME. (WebCore::nextSentencePositionBoundary): Tweaked FIXME. This function is identical, not close to endSentenceBoundary. (WebCore::nextSentencePosition): Removed an incorrect FIXME.
1:10 AM Changeset in webkit [24186] by antti
  • 2 edits in trunk/WebKit

Reviewed by John.


Fix <rdar://problem/4570550>
Hang in layout/layoutBlock/layoutBlockChildren preparing to print certain Mail messages


When printing from Mail, WebHTMLView is a subview of the view that is actually printed and does not
receive calls that would set it to printing mode. Method adjustPageHeightNew is called repeatedly (for each page) during
printing and it enables printing mode temporarily for each call. This triggers two full style recalcs and layouts
each time making printing at least O(n2).

Instead of enabling printing mode and resetting it back immediatly do the resetting asynchronously, after
all adjustPageHeightNew calls are done. Normal Safari printing is not affected as adjustPageHeightNew is only
called in case WebHTMLView is embedded in the view that is being printed.


No automatic test possible, requires printing and non-Safari client.


  • WebView/WebHTMLView.mm: (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
12:40 AM Changeset in webkit [24185] by rwlbuis
  • 5 edits
    4 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=14453
REGRESSION: www.nzherald.co.nz almost all the formating is gone

Be less strict for the hex color definition.

12:34 AM Changeset in webkit [24184] by rwlbuis
  • 3 edits in trunk/WebCore

Reviewed by Oliver.

Forgot to commit this as part of commit r24146. Now we are sure
createElement creates elements in the xhtml namespace only.

Note: See TracTimeline for information about the timeline view.