Timeline
Jul 15, 2007:
- 11:13 PM Changeset in webkit [24301] by
-
- 6 edits in trunk
LayoutTests:
Reviewed by Adam.
Update for changed behaviour now that we allow tab characters in input fields again
- editing/inserting/typing-tab-designmode-forms-expected.checksum:
- editing/inserting/typing-tab-designmode-forms-expected.png:
- editing/inserting/typing-tab-designmode-forms-expected.txt:
WebCore:
Reviewed by Adam.
Fix for fix for <rdar://problem/5336602> REGRESSION: tab characters
cannot be entered into text fields
http://bugs.webkit.org/show_bug.cgi?id=14032
Need to use UChar not char.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::constrainValue):
- 7:09 PM Changeset in webkit [24300] by
-
- 5 edits in trunk
LayoutTests:
Reviewed by Geoff Garen.
Update results after removing redundant calls to isSafeScript()
- http/tests/security/cross-frame-access-expected.txt:
WebCore:
Reviewed by Geoff Garen.
Remove redundant calls to isSafeScript()
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customPut):
- bindings/js/kjs_window.cpp: (KJS::Window::put):
- 6:44 PM Changeset in webkit [24299] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej Stachowiak.
Removed incorrect error log, seen while running layout tests.
Perhaps at some point FrameLoadTypeInteral had a specific meaning
that prevented it from being used in non-child frame, non-redirect
situations. However, that meaning has been lost and nobody remembers
how to get it back.
We currently use FrameLoadTypeInternal for any load that is not
initiated by a user gesture, so it's trivial to produce this error
log, even though nothing has gone wrong.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::updateHistoryForInternalLoad):
- 6:36 PM Changeset in webkit [24298] by
-
- 3 edits2 adds in trunk
LayoutTests:
Reviewed by Maciej.
Testcase for <rdar://problem/5336602> REGRESSION: tab characters cannot be entered into text fields
- fast/forms/tab-in-input-expected.txt: Added.
- fast/forms/tab-in-input.html: Added.
WebCore:
Reviewed by Maciej
Fix for <rdar://problem/5336602> REGRESSION: tab characters cannot be entered into text fields
constrainValue attempted to block control characters from being inserted
by a simple less than ' ' check, which prevent tab characters from being
inserted. This patch adds an additional check to allow the tab character
again
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::constrainValue):
- 10:38 AM Changeset in webkit [24297] by
-
- 2 edits in branches/wx-port-alpha/trunk/WebCore/platform/graphics/wx
Improve image memory handling, and set some asserts to help debug problems with deleting the bitmaps created by frameAtIndex. (Related to threads and CURL?)
- 10:01 AM Changeset in webkit [24296] by
-
- 6 edits in branches/feature-branch
Reviewed by Rob.
Fix invisible-text-after-scrolling.xhtml regression. Scroll offset not
taken into account properly. Also fix RenderSVGInlineText::selectionRect(),
so that SVG text can be selected, when being embedded in XHTML.
Jul 14, 2007:
- 4:39 PM Changeset in webkit [24295] by
-
- 3 edits in trunk/WebCore
Third shot at blind Qt/GDK build fix
- platform/gdk/TemporaryLinkStubs.cpp: (FTPDirectoryDocument::createTokenizer):
- platform/qt/TemporaryLinkStubs.cpp: (FTPDirectoryDocument::createTokenizer):
- 4:25 PM Changeset in webkit [24294] by
-
- 2 edits in trunk/WebCore/platform
RUBBERSTAMPED BY SAM WEINIG - Try to (actually) fix Qt and GDK
- 4:21 PM Changeset in webkit [24293] by
-
- 4 edits in trunk
Fix Windows build and set the pref to allow FTP directory listings in Windows nightlies
- 4:13 PM Changeset in webkit [24292] by
-
- 610 edits8 adds in branches/feature-branch
Fixes: http://bugs.webkit.org/show_bug.cgi?id=5940 (<svg> inside <body> incorrectly extends over top/bottom borders)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=14145 (RenderSVGContainer should not inherit from RenderContainer)
Make RenderSVGContainer inherit from RenderObject directly, instead of RenderContainer.
Itdoes a lot of things that we don't need for SVG, and by removing this inheritance
we can finally fix the differences about SVG object positioning, as we don't need
parent translation (tx/ty). Fixes SVG text rendering within XHTML.
Fix requireLayer() function on RenderSVGRoot, as it can actually be a layer now.
This change is based on Rob's patch at 5940 - fixing z-order indexing.
Change RenderSVGRoot renderName() and update all layout tests, because of this change.
Fix absoluteRects() function for RenderSVGInlineText & RenderSVGTSpan.
Checked extensively using WebInspector, to assure all rects are correctly displayed.
Testcases fixed: junk-data.svg, missing-xlink.svg hixie/013.xml (all regressions!)
(junk-data.svg & missing-xlink.svg previously relied on SVG text painting out of <svg> overflow rect.
Fix these testcases, as within this new RenderSVGContainer concept, that bug is now fixed, and breaks them)
Testcases added: custom/absolute-sized-svg-in-xhtml.xhtml, custom/inline-svg-in-xhtml.xml (Mozilla XTech demo)
- 3:59 PM Changeset in webkit [24291] by
-
- 2 edits in trunk/WebCore
Fix Tiger build.
- config.h:
- 3:58 PM Changeset in webkit [24290] by
-
- 3 edits in trunk/WebCore
Blind attempt at (hopefully) fixing the Qt and GDK builds
- platform/gdk/TemporaryLinkStubs.cpp: (FTPDirectoryDocument::FTPDirectoryDocument):
- platform/qt/TemporaryLinkStubs.cpp: (FTPDirectoryDocument::FTPDirectoryDocument):
- 3:25 PM Changeset in webkit [24289] by
-
- 22 edits4 adds in trunk
Reviewed by Sam Weinig
Initial check-in for <rdar://problem/3154486> - Supporting FTP directory listings in the browser
- wtf/Platform.h: Add ENABLE_FTPDIR feature to handle building on platforms that don't have the proper network-layer support
WebCore:
Reviewed by Sam Weinig
Initial check-in for <rdar://problem/3154486> - Supporting FTP directory listings in the browser
Development has taken place on both Leopard and Windows (windows enabling patch will follow shortly)
Support will only exist on platforms whose network layers (ie, ResourceHandle) support piping the raw
FTP Directory data into the engine.
This is known to include Leopard, Windows, and CURL based platforms - probably others
Known incompatible platforms include Tiger.
The FTP listing page is built in HTML. An external HTML document can be provided as a template for the
directory listing. This document is parsed, and expected to have a <table> with a certain class in it.
As FTP directory listings come in, each entry is added to this table as a row.
If no HTML template is provided to work with, a very basic empty document is hard coded that contains only
this special table.
Upgrades to the look and feel of the directory listings can take place largely in this HTML template which,
admittedly, is conspicuously absent in this initial checkin
- WebCore.exp: New Settings symbols for WebKit
- WebCore.xcodeproj/project.pbxproj:
- config.h: If BUILDING_ON_TIGER, disable FTP directory listing support
- dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Create an FTPDirectoryDocument if the mime type is "application/x-ftp-directory"
- loader/FTPDirectoryDocument.cpp: Added. (WebCore::FTPDirectoryTokenizer::isWaitingForScripts): (WebCore::FTPDirectoryTokenizer::checkBuffer): (WebCore::FTPDirectoryTokenizer::FTPDirectoryTokenizer): Building on HTML tokenizer, this facilitates parsing FTP Directory listings in the engine (WebCore::FTPDirectoryTokenizer::appendEntry): Add a table row for a directory listing to the document (WebCore::FTPDirectoryTokenizer::createTDForFilename): Create the TD for the filename with the anchor in it
(WebCore::processFilesizeString): Prettify the filesize
(WebCore::wasLastDayOfMonth):
(WebCore::processFileDateString): Prettify the date
(WebCore::FTPDirectoryTokenizer::parseAndAppendOneLine):
(WebCore::FTPDirectoryTokenizer::loadDocumentTemplate): Loads the HTML template that FTP directory listings
can build on top of
(WebCore::FTPDirectoryTokenizer::createBasicDocument): Creates a most basic document (body and one table) to
append the rows to in case the document template is not loaded and parsed
(WebCore::FTPDirectoryTokenizer::write): Add the FTP listing to the buffer and parse entries out of it
(WebCore::FTPDirectoryTokenizer::finish):
(WebCore::FTPDirectoryDocument::FTPDirectoryDocument): Special document-type for FTP directory listings
(WebCore::FTPDirectoryDocument::createTokenizer):
- loader/FTPDirectoryDocument.h: Added. (WebCore::FTPDirectoryDocument::isImageDocument):
- loader/FTPDirectoryParser.cpp: Added. (WebCore::parseOneFTPLine): Adapted from ParseFTPList.cpp from Firefox - parses most known FTP directory listing styles into discrete FTP directory entries
- loader/FTPDirectoryParser.h: Added. (WebCore::ListState::ListState): Maintains FTP Parser state (WebCore::ListResult::ListResult): Represents one FTP directory listing (WebCore::ListResult::clear):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::checkContentPolicy): If the Settings say to bypass the policy check for "application/x-ftp-directory", skip it. This will allow people to test this feature even if their browser/WebKit app would otherwise not allow it
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setFTPDirectoryTemplatePath): Set the path to the FTP listing document template (WebCore::Settings::setForceFTPDirectoryListings): Set to bypass the policy delegate check for mime type "application/x-ftp-directory"
- page/Settings.h: (WebCore::Settings::ftpDirectoryTemplatePath): (WebCore::Settings::forceFTPDirectoryListings):
- platform/Logging.cpp: Add an "LogFTP" logging channel
- platform/Logging.h:
- platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary):
- platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedNonImageMimeTypes): Add "application/x-ftp-directory"
- platform/SharedBuffer.cpp: (WebCore::SharedBuffer::createWithContentsOfFile): Stub for now
- platform/SharedBuffer.h:
- platform/mac/SharedBufferMac.mm: (WebCore::SharedBuffer::createWithContentsOfFile): Load contents of the file into an NSData, then wrap that NSData
WebKit:
Reviewed by Sam Weinig
Initial check-in for <rdar://problem/3154486> - Supporting FTP directory listings in the browser
- WebView/WebPreferenceKeysPrivate.h: Added preference keys for the FTP template location, as well as to force FTP directory listings, bypassing the policy delegate. This is necessary to test the new feature until browser policy delegate support is added.
- WebView/WebPreferences.m: (-[WebPreferences _setFTPDirectoryTemplatePath:]): (-[WebPreferences _ftpDirectoryTemplatePath]): (-[WebPreferences _setForceFTPDirectoryListings:]): (-[WebPreferences _forceFTPDirectoryListings]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm: (-[WebView _updateWebCoreSettingsFromPreferences:]):
- 11:02 AM Changeset in webkit [24288] by
-
- 3 edits2 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=14618
REGRESSION(13464): drivehq.com login form doesn't work
Test: http/tests/misc/post-submit-button.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::appendFormData): Append a submit even if its value is empty.
- 10:04 AM Changeset in webkit [24287] by
-
- 6 edits3 adds in trunk
2007-07-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Darin.
Fixes http://bugs.webkit.org/show_bug.cgi?id=13517,
http://bugs.webkit.org/show_bug.cgi?id=14237, and
the failure of test js1_5/Scope/regress-185485.js
Bug 13517: DOM Exception 8 in finance.aol.com sub-page
Bug 14237: Javascript "var" statement interprets initialization in the topmost function scope
- kjs/nodes.cpp: (VarDeclNode::evaluate):
- tests/mozilla/expected.html:
2007-07-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Darin.
Added tests for the following bugs:
http://bugs.webkit.org/show_bug.cgi?id=13517
http://bugs.webkit.org/show_bug.cgi?id=14237
Bug 13517: DOM Exception 8 in finance.aol.com sub-page
Bug 14237: Javascript "var" statement interprets initialization in the topmost function scope
- fast/js/resources/vardecl-blocks-init.js: Added.
- fast/js/resources/vardecl-preserve-arguments.js: Updated.
- fast/js/vardecl-blocks-init-expected.txt: Added.
- fast/js/vardecl-blocks-init.html: Added.
- fast/js/vardecl-preserve-arguments-expected.txt: Updated result.
- 9:53 AM Changeset in webkit [24286] by
-
- 2 edits in trunk/WebKitTools
2007-07-15 Mark Rowe <mrowe@apple.com>
- Scripts/generate-coverage-data: Don't fail if WebKitBuild directory does not exist.
- 1:21 AM Changeset in webkit [24285] by
-
- 4 edits in trunk/WebKit/win
Reviewed by Darin and Alexey.
Fix for <rdar://problem/5231528> Inline input of International text (IME)
This patch adds IME support to WebKit/win, it currently does not support
reconversion (<rdar://problem/5334818>) and has issues with the chinese
IMEs (<rdar://problem/5334826>)
- WebEditorClient.cpp: (WebEditorClient::respondToChangedSelection): (WebEditorClient::handleInputMethodKeypress): Prevent the initial keydown for an IME from triggering a keypressed event
- WebView.cpp: (WebView::WebView): (WebView::keyUp): (WebView::keyDown): (WebViewWndProc): (IMMDict::dict): (IMMDict::IMMDict):
Dynamic loader for IME libraries
(WebView::getIMMContext):
(WebView::releaseIMMContext):
(WebView::prepareCandidateWindow):
(selectionInsideMarkedText):
(setSelectionToEndOfRange):
(WebView::resetIME):
(WebView::updateSelectionForIME):
(WebView::selectionChanged):
(getCompositionString):
(compositionToUnderlines):
Helper functions
(WebView::onIMEStartComposition):
(WebView::onIMEComposition):
(WebView::onIMEEndComposition):
(WebView::onIMEChar):
(WebView::onIMENotify):
(WebView::onIMERequest):
(WebView::onIMESelect):
(WebView::onIMESetContext):
IME event handling, so far most of these are not implemented, but the bulk of functionality
is performed the the composition event handlers
- WebView.h:
