Context Navigation

xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseText): hold JSLock when needed (WebCore::XMLHttpRequest::open): ditto (WebCore::XMLHttpRequest::didFinishLoading): ditto (WebCore::XMLHttpRequest::didReceiveData): ditto
xml/XMLHttpRequest.h:

5:08 PM Changeset in webkit [24636] by andersca

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/5327912>
iDisk: Web iDisk & main iDisk appear blank

http/tests/loading/cached-scripts-expected.txt: Added.
http/tests/loading/cached-scripts.html: Added.
http/tests/loading/resources: Added.
http/tests/loading/resources/cached-scripts-subframe.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/5327912>
iDisk: Web iDisk & main iDisk appear blank

Prepend any remaining text that scripts might have written.

html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution):

3:45 PM Changeset in webkit [24635] by zimmermann

3 edits in branches/feature-branch/WebCore

Reviewed by Oliver.

Unify absoluteRects() of RenderSVGTSpan & RenderSVGTextPath.
The RenderSVGTextPath one was still using the old, wrong concept.

3:15 PM Changeset in webkit [24634] by kmccullo

8 edits
6 adds in trunk

LayoutTests:

Reviewed by .

mac/leopard/Skipped: Removing some tests that were removed earlier, but checked back in accidentally. Not sure how they got back into my file though.

WebCore:

Reviewed by Tim, Darin, Oliver.

<rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
Check for file:// urls when clicking links, not block all schemes that are treated as local.

loader/FrameLoader.cpp: (WebCore::FrameLoader::load):

WebKitTools:

Reviewed by Tim, Darin, Oliver.

<rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
Change DRT to be able to intercept the requst to load so it can check if a scheme was allowed or not.

ChangeLog:
DumpRenderTree/DumpRenderTree.m: (createWebView): (dumpRenderTree): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setCustomPolicyDelegate:]):
DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/FrameLoadDelegate.h:
DumpRenderTree/PolicyDelegate.h: Added.
DumpRenderTree/PolicyDelegate.m: Added. (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
DumpRenderTree/ResourceLoadDelegate.h:

2:50 PM Changeset in webkit [24633] by mjs

21 edits
7 adds in trunk

JavaScriptCore:

Reviewed by Darin.

JavaScriptCore part of fix for <rdar://problem/5300291> Optimize GC to reclaim big, temporary objects (like XMLHttpRequest.responseXML) quickly

Also, as a side effect of optimizations included in this patch:

7% speedup on JavaScript iBench
4% speedup on "Celtic Kane" JS benchmark

The basic idea is explained in a big comment in collector.cpp. When unusually
large objecs are allocated, we push the next GC closer on the assumption that
most objects are short-lived.

I also did the following two optimizations in the course of tuning
this not to be a performance regression:

1) Change UString::Rep to hold a self-pointer as the baseString in
the unshared case, instead of a null pointer; this removes a
number of null checks in hot code because many places already
wanted to use the rep itself or the baseString as appropriate.

2) Avoid creating duplicate StringImpls when creating a
StringInstance (the object wrapper for a JS string) or calling
their methods. Since a temporary wrapper object is made every time
a string method is called, this resulted in two useless extra
StringImpls being allocated for no reason whenever a String method
was invoked on a string value. Now we bypass those.

kjs/collector.cpp: (KJS::): (KJS::Collector::recordExtraCost): Basics of the extra cost mechanism. (KJS::Collector::allocate): ditto (KJS::Collector::collect): ditto
kjs/collector.h: (KJS::Collector::reportExtraMemoryCost): ditto
kjs/array_object.cpp: (ArrayInstance::ArrayInstance): record extra cost
kjs/internal.cpp: (KJS::StringImp::toObject): don't create a whole new StringImpl just to be the internal value of a StringInstance! StringImpls are immutable so there's no point tot his.
kjs/internal.h: (KJS::StringImp::StringImp): report extra cost
kjs/string_object.cpp: (KJS::StringInstance::StringInstance): new version that takes a StringImp (KJS::StringProtoFunc::callAsFunction): don't create a whole new StringImpl just to convert self to string! we already have one in the internal value
kjs/string_object.h: report extra cost
kjs/ustring.cpp: All changes to handle baseString being self instead of null in the unshared case. (KJS::): (KJS::UString::Rep::create): (KJS::UString::Rep::destroy): (KJS::UString::usedCapacity): (KJS::UString::usedPreCapacity): (KJS::UString::expandCapacity): (KJS::UString::expandPreCapacity): (KJS::UString::UString): (KJS::UString::append): (KJS::UString::operator=): (KJS::UString::copyForWriting):
kjs/ustring.h: (KJS::UString::Rep::baseIsSelf): new method, now that baseString is self instead of null in the unshared case we can't just null check. (KJS::UString::Rep::data): adjusted as mentioned above (KJS::UString::cost): new method to compute the cost for a UString, for use by StringImpl.

kjs/value.cpp: (KJS::jsString): style fixups. (KJS::jsOwnedString): new method, use this for strings allocated from UStrings held by the parse tree. Tracking their cost as part of string cost is pointless, because garbage collecting them will not actually free the relevant string buffer.
kjs/value.h: prototyped jsOwnedString.
kjs/nodes.cpp: (StringNode::evaluate): use jsOwnedString as appropriate (RegExpNode::evaluate): ditto (PropertyNameNode::evaluate): ditto (ForInNode::execute): ditto

JavaScriptCore.exp: Exported some new symbols.

WebCore:

Reviewed by Darin.

fixed <rdar://problem/5300291> Optimize GC to reclaim big, temporary objects (like XMLHttpRequest.responseXML) quickly

With this plus related JavaScriptCore changes, a number of XMLHttpRequest situations that
result in huge data sets are addressed, including a single huge responseXML on an XMR done
repeatedly, or accessing responseText repeatedly during loading of a single large XHR.

In addition to the GC changes in JavaScriptCore, I changed responseText to be stored as a
KJS::UString instead of a WebCore::String so that the JavaScript responseText value can
share the buffer (indeed multiple intermediate responseTexts can share its buffer).

First of all, here's some manual test cases that will each blow out the process VM without this fix,
but will settle into decent steady state with.

manual-tests/memory: Added.
manual-tests/memory/MessageUidsAlreadyDownloaded2: Added.
manual-tests/memory/string-growth.html: Added.
manual-tests/memory/xhr-multiple-requests-responseText.html: Added.
manual-tests/memory/xhr-multiple-requests-responseXML.html: Added.
manual-tests/memory/xhr-multiple-requests.html: Added.
manual-tests/memory/xhr-repeated-string-access.xml: Added.

And here's the actual code changes:

WebCore.xcodeproj/project.pbxproj:
bindings/js/JSDocumentCustom.cpp: (WebCore::toJS): Record extra cost if the document is frameless (counting the nodes doesn't make a measurable performance difference here in any case I could find)
bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::getValueProperty): Adjust for the fact that ressponseText is now stored as a UString.
bindings/js/kjs_binding.cpp: (KJS::jsOwnedStringOrNull): New helper.
bindings/js/kjs_binding.h:
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseText): It's a UString! (WebCore::XMLHttpRequest::getResponseXML): handle the fact that m_responseText is a UString. (WebCore::XMLHttpRequest::XMLHttpRequest): ditto. (WebCore::XMLHttpRequest::abort): call dropProtection (WebCore::XMLHttpRequest::didFinishLoading): call dropProtection (WebCore::XMLHttpRequest::dropProtection): after removing our GC protection, report extra cost of this XHR's responseText buffer.
xml/XMLHttpRequest.h:

2:41 PM Changeset in webkit [24632] by thatcher

5 edits in trunk/WebCore

Reviewed by Brady.

<rdar://problem/4796657> table deletion outline does not always follow the table size as editing occurs inside

Change the outline element to position itself automaticlly using the top, left, bottom and right CSS properties.
This made the container element redundant, so it has been removed. Now the outline element and the delete button
both get appended to the target element and positioned based on that container element. This removes the need
to update the width and height when the target contents changed.

editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::show): Change the style properties and remove the container element. (WebCore::DeleteButtonController::hide): Remove the button and outline from the target element.
editing/DeleteButtonController.h: Removed updateOutlineStyle, respondToChangedContents and m_containerElement.
editing/Editor.cpp: (WebCore::Editor::respondToChangedContents): Remove the call to DeleteButtonController respondToChangedContents.

2:35 PM Changeset in webkit [24631] by andersca

2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5344471>
CrashTracer: [USER] 1 crash in Mail at WebCore::PluginTokenizer::writeRawData(char const*, int)

Make sure to layout so we'll have a renderer. Also null-check the renderer for extra safety.

loader/PluginDocument.cpp: (WebCore::PluginTokenizer::writeRawData):

1:54 PM Changeset in webkit [24630] by adachan

4 edits in trunk/WebKit/win

2007-07-25 Ada Chan <adachan@apple.com>

Reviewed by Adam and Steve.

Implemented some DOM methods and other fixes for <rdar://problem/5311601>.

DOMCoreClasses.cpp: (DOMNode::ownerDocument): implemented (DOMDocument::getComputedStyle): get the DOMElement via QueryInterface (DOMElement::QueryInterface):
DOMHTMLClasses.cpp: (DOMHTMLDocument::body): fixed leak (DOMHTMLFormElement::action): implemented (DOMHTMLFormElement::method): ditto (DOMHTMLInputElement::form): ditto (DOMHTMLTextAreaElement::form): ditto
Interfaces/DOMHTML.idl: IDOMHTMLInputElement should inherit from IDOMHTMLElement

1:12 PM Changeset in webkit [24629] by treat

2 edits in trunk/WebKitTools

Fix build for some reported systems.

1:02 PM BuildingGdk edited by alp@atoker.com

(diff)

12:14 PM Changeset in webkit [24628] by zimmermann

4 edits in branches/feature-branch/WebCore

Reviewed by Sam.

Let <textPath> be recognized within the ObjC bindings.
Forgot to add that months ago.

12:07 PM Changeset in webkit [24627] by aliceli1

2 edits in trunk/LayoutTests

Reviewed by .

mac/leopard/Skipped: Removing some tests that were removed earlier, but checked back in accidentally. Not sure how they got back into my file though.

12:01 PM Changeset in webkit [24626] by aliceli1

1 edit in trunk/LayoutTests/mac/leopard/Skipped

11:48 AM Changeset in webkit [24625] by aliceli1

2 edits in trunk/LayoutTests

Reviewed by .

mac/leopard/Skipped: Adding to skip list to avoid false failure

9:54 AM Changeset in webkit [24624] by darin

6 edits in trunk/WebCore

Reviewed by Maciej, Darin.

http://bugs.webkit.org/show_bug.cgi?id=14030

Add ResourceHandle::setClient to resolve some messiness with handle
releasing. Clear the client when ResourceLoader is going to release
the handle to prevent crashes in the case where somebody still holds a
reference (this doesn't seem to currently happen in practice). Add
NULL-checking for ResourceHandle implementations using the client.

loader/ResourceLoader.cpp: (WebCore::ResourceLoader::releaseResources):
platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::fireBlockedFailure): (WebCore::ResourceHandle::setClient):
platform/network/ResourceHandle.h:
platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::didReceiveResponse): (WebCore::didReceiveData): (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::willCacheResponse): (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::receivedCancellation):
platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::didCancelAuthenticationChallenge): (WebCore::ResourceHandle::receivedCancellation): (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]): (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):

8:52 AM Changeset in webkit [24623] by darin

2 edits in trunk/WebCore

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=11756 <rdar://problem/5286420>

Fix a typo error to really compare the present domain to the domain of the parent of the targeted frame.

loader/FrameLoader.cpp: (WebCore::FrameLoader::canTarget):

8:50 AM Changeset in webkit [24622] by kmccullo

2 edits in trunk/LayoutTests

Reviewed by .

Reverted

win/Skipped:

8:49 AM Changeset in webkit [24621] by darin

4 edits
4 adds in trunk

LayoutTests:

Reviewed by Darin.

test for http://bugs.webkit.org/show_bug.cgi?id=14758 REGRESSION: Repeated text after line break on facebook.com

fast/text/reset-emptyRun-expected.checksum: Added.
fast/text/reset-emptyRun-expected.png: Added.
fast/text/reset-emptyRun-expected.txt: Added.
fast/text/reset-emptyRun.html: Added.

WebCore:

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=14758 REGRESSION: Repeated text after line break on facebook.com

Test: fast/text/reset-emptyRun.html

platform/BidiResolver.h: (WebCore::::deleteRuns): Re-add a line that was removed for no reason at all during refactoring in r24485.
rendering/bidi.cpp: (WebCore::BidiState::deleteRuns): Ditto.

8:44 AM Changeset in webkit [24620] by kmccullo

2 edits in trunk/LayoutTests

Reviewed by .

Forgot to checking the changes to the skipped list so the win bot doesn't fail.

win/Skipped:

2:57 AM Changeset in webkit [24619] by bdash

8 edits
6 deletes in trunk

Roll out r24618 as it broke 600+ layout tests.

2:08 AM Changeset in webkit [24618] by kmccullo

8 edits
6 adds in trunk

LayoutTests:

Reviewed by Oliver.

<rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
Tests that feed:// urls can still be followed when clicked.

http/tests/security/feed-urls-from-remote-expected.txt: Added.
http/tests/security/feed-urls-from-remote.html: Added.
http/tests/security/resources/feed.html: Added.
http/tests/security/resources/feed.xml: Added.
win/Skipped:

WebCore:

Reviewed by Oliver.

<rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
Check for file:// urls when clicking links, not block all schemes that are treated as local.

loader/FrameLoader.cpp: (WebCore::FrameLoader::load):

WebKitTools:

Reviewed by Oliver.

<rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
Change DRT to be able to intercept the requst to load so it can check if a scheme was allowed or not.

ChangeLog:
DumpRenderTree/DumpRenderTree.m: (createWebView): (dumpRenderTree): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setCustomPolicyDelegate:]):
DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/FrameLoadDelegate.h:
DumpRenderTree/PolicyDelegate.h: Added.
DumpRenderTree/PolicyDelegate.m: Added. (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
DumpRenderTree/ResourceLoadDelegate.h:

Jul 24, 2007:

10:38 PM Changeset in webkit [24617] by beidson

2 edits in trunk/LayoutTests

Reviewed by Adam Roben

<rdar://problem/5313504> - Some Back/Forward tests fail on Leopard

mac/leopard/Skipped: Remove from the skipped list as they work now

9:37 PM Changeset in webkit [24616] by oliver

13 edits in trunk

WebCore:

Reviewed by Adam and Justin.

<rdar://problem/5141779> WebView editableDOMRangeForPoint: & moveDragCaretToPoint: returns last position in DOMText range

Remove bridge implementation for editableDOMRangeForPoint: and moveDragCaretToPoint:.
Now use cross-platform code Editor::rangeForPoint and DragController::placeDragCaret instead.
This required lifting local code from DragController.cpp into the shared methods
Frame::visiblePositionForPoint and Frame::documentAtPoint.

WebCore.exp:
editing/Editor.cpp: (WebCore::Editor::rangeForPoint):
editing/Editor.h:
page/DragController.cpp: (WebCore::DragController::dragEnded): (WebCore::DragController::performDrag): (WebCore::DragController::dragEnteredOrUpdated): (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::operationForLoad): (WebCore::setSelectionToDragCaret): (WebCore::DragController::concludeDrag): (WebCore::DragController::placeDragCaret):
page/DragController.h:
page/Frame.cpp: (WebCore::Frame::visiblePositionForPoint): (WebCore::Frame::documentAtPoint):
page/Frame.h:
page/mac/WebCoreFrameBridge.h:
page/mac/WebCoreFrameBridge.mm:

WebKit:

Reviewed by Adam and Justin.

<rdar://problem/5141779> WebView editableDOMRangeForPoint: & moveDragCaretToPoint: returns last position in DOMText range

editableDOMRangeForPoint:, moveDragCaretToPoint:, and removeDragCaret now call directly into
WebCore without relying on bridge look up through the now removed _bridgeAtPoint:.

WebKit.xcodeproj/project.pbxproj:
WebView/WebView.mm: (-[WebView moveDragCaretToPoint:]): (-[WebView removeDragCaret]): (-[WebView editableDOMRangeForPoint:]):

6:22 PM Changeset in webkit [24615] by weinig

2 edits in trunk/WebCore

Rubber-stamped by Adam Roben.

Remove unused .strip files.

WebCore.xcodeproj/project.pbxproj:

6:21 PM Changeset in webkit [24614] by aroben

1 copy in tags/Safari-522.14.3b

New tag.

6:20 PM Changeset in webkit [24613] by aroben

1 edit in trunk/WebKit/win/WebKit.vcproj/VERSION

Bump version for submit

6:20 PM Changeset in webkit [24612] by aliceli1

2 edits in trunk/LayoutTests

Adding to the Leopard skip list to avoid a test that hangs due to a CFNetwork bug.

mac/leopard/Skipped:

6:10 PM Changeset in webkit [24611] by sfalken

1 copy in tags/Safari-522.15.5b

New tag.

6:04 PM Changeset in webkit [24610] by adele

1 edit in trunk/LayoutTests/mac/leopard/Skipped

Updating skipped list

5:53 PM Changeset in webkit [24609] by adele

3 edits in trunk/LayoutTests

Updating test to put JS code in the onload handler helps to avoid intermittent failures.
<rdar://problem/5313531> REGRESSION(Leopard): editing/pasteboard/copy-in-password-field.html sometimes fails

editing/pasteboard/copy-in-password-field-expected.txt:
editing/pasteboard/copy-in-password-field.html:

5:02 PM Changeset in webkit [24608] by adele

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for <rdar://problem/5308492> Computed width for elements with box-sizing: border-box is not equal to the width set in the CSS

fast/css/getComputedStyle-border-box-expected.txt: Added.
fast/css/getComputedStyle-border-box.html: Added.

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/5308492> Computed width for elements with box-sizing: border-box is not equal to the width set in the CSS

Test: fast/css/getComputedStyle-border-box.html

css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): For the width and height properties, when you get the value from the renderer, use the renderer's box sizing value to determine the size.

4:36 PM Changeset in webkit [24607] by andersca

2 edits in trunk/WebCore

Reviewed by Kevin Decker.

<rdar://problem/5355781>
REGRESSION: reproducible crash in CoreFoundation!CFRunLoopFinished on Flash pages

Null check the loader.

plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::start):

4:31 PM Changeset in webkit [24606] by kdecker

2 edits in trunk/WebKit

Reviewed by Anders.

<rdar://problem/4699455> REGRESSION (Safari 2->Safari 3): Adobe Reader 7.0.8 plug-in doesn't work

Plugins/WebNetscapePluginEmbeddedView.h: Added a #define that renames this class to "WebNetscapePluginDocumentView" This is necessary because the Adobe 7.x Acrobat plug-in has a hard coded check for a view named "WebNetscapePluginDocumentView" and will not function correctly if it doesn't find a view in the hierarchy without the old class name.

3:59 PM Changeset in webkit [24605] by zimmermann

12 edits
105 adds in branches/feature-branch

Reviewed by Oliver.
Fix all known bugs regarding to SVG text selection, when embedded in XHTML.
Also fix inspecting <text> elements when embedded in XHTML. (WebInspector)

3:23 PM Changeset in webkit [24604] by adele

103 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt and Adam.

Added and updated tests for <rdar://problem/5130590> REGRESSION: style="width:1px" on <select> element no longer hides the element
The metrics have changed for the anonymous block inside popup buttons.

fast/forms/menulist-narrow-width-expected.checksum: Added.
fast/forms/menulist-narrow-width-expected.png: Added.
fast/forms/menulist-narrow-width-expected.txt: Added.
fast/forms/menulist-narrow-width.html: Added.

editing/pasteboard/4641033-expected.txt:
editing/pasteboard/4944770-1-expected.txt:
editing/pasteboard/4944770-2-expected.txt:
editing/pasteboard/select-element-1-expected.txt:
editing/selection/caret-before-select-expected.txt:
editing/selection/replaced-boundaries-3-expected.txt:
editing/selection/select-box-expected.txt:
editing/selection/select-element-paragraph-boundary-expected.txt:
fast/block/float/float-avoidance-expected.txt:
fast/block/margin-collapse/103-expected.txt:
fast/forms/001-expected.checksum:
fast/forms/001-expected.png:
fast/forms/001-expected.txt:
fast/forms/003-expected.txt:
fast/forms/004-expected.txt:
fast/forms/HTMLOptionElement_label01-expected.txt:
fast/forms/HTMLOptionElement_label02-expected.txt:
fast/forms/HTMLOptionElement_label03-expected.txt:
fast/forms/HTMLOptionElement_label04-expected.txt:
fast/forms/HTMLOptionElement_label06-expected.txt:
fast/forms/HTMLOptionElement_label07-expected.txt:
fast/forms/control-restrict-line-height-expected.txt:
fast/forms/disabled-select-change-index-expected.txt:
fast/forms/form-element-geometry-expected.txt:
fast/forms/menulist-separator-painting-expected.txt:
fast/forms/menulist-width-change-expected.txt:
fast/forms/option-script-expected.txt:
fast/forms/option-strip-whitespace-expected.txt:
fast/forms/option-text-clip-expected.txt:
fast/forms/select-accesskey-expected.txt:
fast/forms/select-align-expected.txt:
fast/forms/select-baseline-expected.txt:
fast/forms/select-change-listbox-to-popup-expected.txt:
fast/forms/select-disabled-appearance-expected.txt:
fast/forms/select-initial-position-expected.txt:
fast/forms/select-selected-expected.txt:
fast/forms/select-size-expected.txt:
fast/forms/select-style-expected.txt:
fast/forms/select-visual-hebrew-expected.txt:
fast/forms/select-writing-direction-natural-expected.txt:
fast/forms/stuff-on-my-optgroup-expected.txt:
fast/html/keygen-expected.txt:
fast/invalid/014-expected.txt:
fast/invalid/residual-style-expected.txt:
fast/parser/document-write-option-expected.txt:
fast/replaced/replaced-breaking-expected.txt:
fast/replaced/replaced-breaking-mixture-expected.txt:
fast/replaced/three-selects-break-expected.txt:
fast/replaced/width100percent-expected.txt:
fast/text/international/bidi-menulist-expected.txt:
http/tests/navigation/anchor-basic-expected.txt:
http/tests/navigation/anchor-frames-expected.txt:
http/tests/navigation/anchor-goback-expected.txt:
http/tests/navigation/anchor-subframeload-expected.txt:
http/tests/navigation/javascriptlink-basic-expected.txt:
http/tests/navigation/javascriptlink-frames-expected.txt:
http/tests/navigation/javascriptlink-goback-expected.txt:
http/tests/navigation/javascriptlink-subframeload-expected.txt:
http/tests/navigation/metaredirect-basic-expected.txt:
http/tests/navigation/metaredirect-frames-expected.txt:
http/tests/navigation/metaredirect-goback-expected.txt:
http/tests/navigation/metaredirect-subframeload-expected.txt:
http/tests/navigation/post-goback2-expected.txt:
http/tests/navigation/postredirect-goback2-expected.txt:
http/tests/navigation/redirect302-basic-expected.txt:
http/tests/navigation/redirect302-frames-expected.txt:
http/tests/navigation/redirect302-goback-expected.txt:
http/tests/navigation/redirect302-subframeload-expected.txt:
http/tests/navigation/relativeanchor-basic-expected.txt:
http/tests/navigation/relativeanchor-frames-expected.txt:
http/tests/navigation/relativeanchor-goback-expected.txt:
http/tests/navigation/slowmetaredirect-basic-expected.txt:
http/tests/navigation/slowtimerredirect-basic-expected.txt:
http/tests/navigation/success200-basic-expected.txt:
http/tests/navigation/success200-frames-expected.txt:
http/tests/navigation/success200-frames-loadsame-expected.txt:
http/tests/navigation/success200-goback-expected.txt:
http/tests/navigation/success200-loadsame-expected.txt:
http/tests/navigation/success200-reload-expected.txt:
http/tests/navigation/success200-subframeload-expected.txt:
http/tests/navigation/timerredirect-basic-expected.txt:
http/tests/navigation/timerredirect-frames-expected.txt:
http/tests/navigation/timerredirect-goback-expected.txt:
http/tests/navigation/timerredirect-subframeload-expected.txt:
tables/mozilla/bugs/bug1188-expected.txt:
tables/mozilla/bugs/bug18359-expected.txt:
tables/mozilla/bugs/bug2479-3-expected.txt:
tables/mozilla/bugs/bug2479-4-expected.txt:
tables/mozilla/bugs/bug29326-expected.txt:
tables/mozilla/bugs/bug33855-expected.txt:
tables/mozilla/bugs/bug4382-expected.txt:
tables/mozilla/bugs/bug96334-expected.txt:
tables/mozilla/core/margins-expected.txt:
tables/mozilla/dom/tableDom-expected.txt:
tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:

WebCore:

Reviewed by Hyatt and Adam.

Fix for <rdar://problem/5130590> REGRESSION: style="width:1px" on <select> element no longer hides the element

Removed hack that forced large padding on popup buttons. Now we put that padding in the inner block, so that
the specified width will be honored.

rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::adjustInnerStyle): Set the padding on the inner block based on the metrics provided by the theme. (WebCore::RenderMenuList::controlClipRect): Clip to the intersection of the inner content box and the outer content box. This will leave room for the arrows which sit in the inner box padding, and if the inner box ever spills out of the outer box, that will get clipped too. (WebCore::RenderMenuList::calcPrefWidths): Add in the inner box's padding and border to the pref widths.

rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuList): Only inflate the rect for the shadow if the rect is big enough to fit the whole control. Also, on Leopard, the NSCell will draw outside of a small rect, so add a clip for that case. (WebCore::RenderThemeMac::paintMenuListButton): Restrict font scale to make sure the arrows will actually fit in the bounds vertically. Don't draw the arrows if they won't fit horizontally. Reset padding. Since WinIE doesn't honor padding for popups, its not critical to support padding at this time. (WebCore::RenderThemeMac::adjustMenuListStyle): Don't set the padding here. Instead, we're going to set the padding on the inner block of the select. (WebCore::RenderThemeMac::adjustMenuListButtonStyle): ditto. (WebCore::RenderThemeMac::popupInternalPaddingLeft): Added. Provides internal padding values for RenderMenuList. (WebCore::RenderThemeMac::popupInternalPaddingRight): ditto. (WebCore::RenderThemeMac::popupInternalPaddingTop): ditto. (WebCore::RenderThemeMac::popupInternalPaddingBottom): ditto.
rendering/RenderThemeMac.h:

rendering/RenderThemeSafari.cpp: The same changes that were made to RenderThemeMac were made here, with variations for the arrow differences. This code should be refactored and shared, but now did not seem like the right time to do that refactoring. (WebCore::RenderThemeSafari::paintMenuList): (WebCore::RenderThemeSafari::paintMenuListButton): (WebCore::RenderThemeSafari::adjustMenuListStyle): (WebCore::RenderThemeSafari::popupInternalPaddingLeft): (WebCore::RenderThemeSafari::popupInternalPaddingRight): (WebCore::RenderThemeSafari::popupInternalPaddingTop): (WebCore::RenderThemeSafari::popupInternalPaddingBottom): (WebCore::RenderThemeSafari::adjustMenuListButtonStyle):
rendering/RenderThemeSafari.h:

rendering/RenderTheme.h: Added to provide internal padding values for RenderMenuList. (WebCore::RenderTheme::popupInternalPaddingLeft): (WebCore::RenderTheme::popupInternalPaddingRight): (WebCore::RenderTheme::popupInternalPaddingTop): (WebCore::RenderTheme::popupInternalPaddingBottom):

1:58 PM Changeset in webkit [24603] by lars

4 edits
2 adds
2 deletes in trunk/WebCore

replace the makeprop and makevalues shell scripts by equivalent perl versions. This is required to remove the last shell dependency when building QtWebKit on Windows.

1:43 PM Changeset in webkit [24602] by sfalken

2 edits in trunk/WebKit/win

Removed touch of WebKit.rc to prevent rebuilds of the rc file.
The autoversion info can get slightly out of date now, but this isn't a huge problem relative to the rebuilds.

Rubber-stamped by Adam.

WebKit.vcproj/WebKit.vcproj:

1:05 PM Changeset in webkit [24601] by sfalken

1 copy in tags/Safari-522.15.4b

New tag.

12:49 PM Changeset in webkit [24600] by treat

3 edits in trunk/WebKitQt

These are no longer necessary or used.

12:03 PM Changeset in webkit [24599] by bdakin

3 edits
8 adds in trunk

LayoutTests:

Reviewed by Darin.

Tests for http://bugs.webkit.org/show_bug.cgi?id=14714 REGRESSION:
ASSERTION FAILED: i < size() in Vector.h:401 on negative -webkit-
column-width

and - http://bugs.webkit.org/show_bug.cgi?id=14718 REGRESSION: ASSERTION FAILED: i < size() in Vector.h:401 on zero -webkit-column-count

fast/multicol/negativeColumnWidth-expected.checksum: Added.
fast/multicol/negativeColumnWidth-expected.png: Added.
fast/multicol/negativeColumnWidth-expected.txt: Added.
fast/multicol/negativeColumnWidth.html: Added.
fast/multicol/zeroColumnCount-expected.checksum: Added.
fast/multicol/zeroColumnCount-expected.png: Added.
fast/multicol/zeroColumnCount-expected.txt: Added.
fast/multicol/zeroColumnCount.html: Added.

WebCore:

Reviewed by Darin.

Fix for http://bugs.webkit.org/show_bug.cgi?id=14714 REGRESSION:
ASSERTION FAILED: i < size() in Vector.h:401 on negative -webkit-
column-width

and - http://bugs.webkit.org/show_bug.cgi?id=14718 REGRESSION: ASSERTION FAILED: i < size() in Vector.h:401 on zero -webkit-column-count

rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcColumnWidth): Make 1 the minimum value for column-width and column-count. Since the spec does not address what to do with negative values for these properties, we are patching the rendering code instead of the parser.

11:49 AM Changeset in webkit [24598] by yongjzha

2 edits in S60/branches/3.1m/WebCore

2007-07-20 vmalaiya, <vikram.malaiya@nokia.com>

Reviewed by Yongjun
DESC: JPKN-6Z38E5 - Browser crashes and problems with memory low note.
Fix - Remove Nokia specific changes so that the name chache is updated before

an attempt to retrieve information from it.

http://bugs.webkit.org/show_bug.cgi?id=14688

khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::namedItems):

11:47 AM Changeset in webkit [24597] by yongjzha

2 edits in S60/trunk/WebCore

2007-07-20 vmalaiya, <vikram.malaiya@nokia.com>

Reviewed by Yongjun
DESC: JPKN-6Z38E5 - Browser crashes and problems with memory low note.
Fix - Remove Nokia specific changes so that the name chache is updated before

an attempt to retrieve information from it.

http://bugs.webkit.org/show_bug.cgi?id=14688

khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::namedItems):

11:44 AM Changeset in webkit [24596] by andersca

2 edits in trunk/WebCore

Reviewed by Steve.

<rdar://problem/5355403>
REGRESSION: 303A2 does not display pdf files with AdobeReader 8.1

Close the file before handing off the file name to the plug-in.

plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::destroyStream):

11:29 AM Changeset in webkit [24595] by alp

3 edits in trunk/WebCore

2007-07-24 Alp Toker <alp.toker@collabora.co.uk>

Reviewed by Adam.

http://bugs.webkit.org/show_bug.cgi?id=14711
RenderThemeGdk's buttons are state-agnostic (pressed, hovered)

Remove unnecessary label from widget instances.
Render check and radio widgets correctly.
Determine the widget state and render it appropriately.

platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::determineState): (WebCore::RenderThemeGdk::paintCheckbox): (WebCore::RenderThemeGdk::paintRadio): (WebCore::RenderThemeGdk::paintButton): (WebCore::RenderThemeGdk::gtkButton): (WebCore::RenderThemeGdk::gtkCheckbox): (WebCore::RenderThemeGdk::gtkRadioButton):
platform/gdk/RenderThemeGdk.h:

9:55 AM Applications using WebKit edited by micha.brandt@gmail.com

Including PageOutline (diff)

7:52 AM Changeset in webkit [24594] by bdash

1 copy in tags/JavaScriptCore-419.2.1/JavaScriptCore

New tag (part 2).

7:51 AM Changeset in webkit [24593] by bdash

1 add in tags/JavaScriptCore-419.2.1

New tag (part 1).

7:51 AM Changeset in webkit [24592] by bdash

1 copy in tags/JavaScriptCore-418.6.1/JavaScriptCore

New tag (part 2).

7:50 AM Changeset in webkit [24591] by bdash

1 add in tags/JavaScriptCore-418.6.1

New tag (part 1).

7:48 AM Changeset in webkit [24590] by bdash

2 edits in branches/Safari-2.0-dashboard/JavaScriptCore

Versioning.

7:47 AM Changeset in webkit [24589] by bdash

2 edits in branches/Safari-2.0-dashboard/JavaScriptCore

2007-07-25 Mark Rowe <mrowe@apple.com>

Build fix for GCC 3.3.

pcre/pcre_compile.c: Remove unused variables.

7:44 AM Changeset in webkit [24588] by bdash

2 edits in branches/Safari-2.0-system/JavaScriptCore

Versioning.

7:44 AM Changeset in webkit [24587] by bdash

2 edits in branches/Safari-2.0-system/JavaScriptCore

2007-07-25 Mark Rowe <mrowe@apple.com>

Build fix for GCC 3.3.

pcre/pcre_compile.c: Remove unused variables.

5:56 AM Changeset in webkit [24586] by bdash

82 edits in trunk/WebCore/page/inspector/Images

Set the correct svn:mime-type on WebCore/page/inspector/Images/*.png

5:21 AM Changeset in webkit [24585] by bdash

5 edits in trunk

2007-07-24 Mark Rowe <mrowe@apple.com>

Reviewed by Antti.

<rdar://problem/5356666> NSMenuItem's seen leaking on buildbot

platform/mac/ContextMenuItemMac.mm: (WebCore::ContextMenuItem::releasePlatformDescription): Transfer ownership from the RetainPtr's CF-based retain count to the Foundation retain count so that callers of releasePlatformDescription can use -[NSObject release] to dispose of it in a manner that won't leak under Obj-C GC.
platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::appendItem): Release platformItem as we were transferred its ownership by releasePlatformDescription. (WebCore::ContextMenu::insertItem): ditto.

2007-07-24 Mark Rowe <mrowe@apple.com>

Reviewed by Antti.

<rdar://problem/5356666> NSMenuItem's seen leaking on buildbot

WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::contextMenuItemSelected): Release platformItem as we were transferred its ownership by releasePlatformDescription.

4:47 AM Changeset in webkit [24584] by bdash

2 edits in trunk/WebCore

Roll out r24583, it needs further consideration.

4:42 AM BuildingOnLinux edited by vprajan@gmail.com

(diff)

4:40 AM Changeset in webkit [24583] by bdash

2 edits in trunk/WebCore

2007-07-24 Mark Rowe <mrowe@apple.com>

Reviewed by Oliver.

<rdar://problem/5356666> NSMenuItem's seen leaking on buildbot

platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::appendItem): Release the platformItem after we take ownership of it from the ContextMenuItem.

3:38 AM BuildingOnLinux edited by vprajan@gmail.com

(diff)

3:36 AM BuildingOnLinux created by vprajan@gmail.com

3:23 AM WikiStart edited by vprajan@gmail.com

(diff)

2:55 AM Changeset in webkit [24582] by bdash

34 edits
6 adds
2 deletes in trunk

2007-07-24 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=14684 Hebrew text in Safari chrome is reversed (LTR instead of RTL)

Test: fast/text/drawBidiText.html

WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl:
manual-tests/chrome-bidi-text.html: Added.
manual-tests/resources/chrome-bidi-text-window.html: Added.
platform/BidiReorderCharacters.cpp: Removed.
platform/BidiReorderCharacters.h: Removed.
platform/BidiResolver.h: (WebCore::BidiCharacterRun::start): Added accessor method. (WebCore::BidiCharacterRun::stop): Ditto. (WebCore::BidiCharacterRun::level): Ditto. (WebCore::BidiCharacterRun::next): Ditto. (WebCore::::appendRun): Added default implementation.
platform/TextStyle.h: (WebCore::TextStyle::setDirectionalOverride): Added accessor method.
platform/graphics/GraphicsContext.cpp: (WebCore::TextRunIterator::TextRunIterator): Added. A BidiResolver- compliant iterator over the characters in a TextRun. (WebCore::TextRunIterator::offset): (WebCore::TextRunIterator::increment): (WebCore::TextRunIterator::atEnd): (WebCore::TextRunIterator::current): (WebCore::TextRunIterator::direction): (WebCore::TextRunIterator::operator==): (WebCore::TextRunIterator::operator!=): (WebCore::GraphicsContext::drawBidiText): Added. Applies the Unicode Bidi Algorithm to the text and draws the resulting unidirectional runs in the right order and with the right directionality.
platform/graphics/GraphicsContext.h:
platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint): Replaced the use of a character buffer and BidiReorderCharacters with calling to drawBidiText(). Removed special handling of '-webkit-rtl-ordering:visual' because that CSS property is an implementation detail of WebCore's visual Hebrew support, and the UA stylesheet sets it to 'logical' for this form control. Authors can specify the ordering using the 'direction' and 'unicode-bidi' properties.
platform/win/WebCoreTextRenderer.cpp: (WebCore::isOneLeftToRightRun): Added. Checks if the text consists of a single left-to-right run, in which case it requires no bidi processing. (WebCore::doDrawTextAtPoint): Changed to call drawBidiText if the text is not entirely left-to-right.
rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): Replaced the use of a character buffer in BidiReorderCharacters with calling to drawBidiText(). Removed special handling of '-webkit-rtl-ordering:visual' for the same reason stated above.
rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): Ditto. Also changed the run-rounding modes used when drawing to match those used when measuring.

2007-07-24 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

test, updated tests and updated results for http://bugs.webkit.org/show_bug.cgi?id=14684 Hebrew text in Safari chrome is reversed (LTR instead of RTL)

fast/forms/HTMLOptionElement_label05-expected.checksum:
fast/forms/HTMLOptionElement_label05-expected.png:
fast/forms/listbox-deselect-scroll-expected.checksum:
fast/forms/listbox-deselect-scroll-expected.png:
fast/forms/listbox-width-change-expected.checksum:
fast/forms/listbox-width-change-expected.png:
fast/forms/option-strip-whitespace-expected.checksum:
fast/forms/option-strip-whitespace-expected.png:
fast/forms/select-change-popup-to-listbox-expected.checksum:
fast/forms/select-change-popup-to-listbox-expected.png:
fast/forms/select-initial-position-expected.checksum:
fast/forms/select-initial-position-expected.png:
fast/text/drawBidiText-expected.checksum: Added.
fast/text/drawBidiText-expected.png: Added.
fast/text/drawBidiText-expected.txt: Added.
fast/text/drawBidiText.html: Added.
fast/text/international/bidi-listbox-atsui-expected.checksum:
fast/text/international/bidi-listbox-atsui-expected.png:
fast/text/international/bidi-listbox-atsui-expected.txt:
fast/text/international/bidi-listbox-atsui.html: Removed the visual ordering cases.
fast/text/international/bidi-listbox-expected.checksum:
fast/text/international/bidi-listbox-expected.png:
fast/text/international/bidi-listbox-expected.txt:
fast/text/international/bidi-listbox.html: Removed the visual ordering cases because the patch removed special handling of visual ordering.

2:29 AM Changeset in webkit [24581] by bdash

1 copy in tags/JavaScriptCore-4522.10.1/JavaScriptCore

New tag (part 2).

2:29 AM Changeset in webkit [24580] by bdash

1 add in tags/JavaScriptCore-4522.10.1

New tag (part 1).

2:28 AM Changeset in webkit [24579] by bdash

1 edit in branches/Safari-522/JavaScriptCore/Configurations/Version.xcconfig

Versioning.

2:28 AM Changeset in webkit [24578] by bdash

6 edits in branches/Safari-522/JavaScriptCore

2007-07-24 Mark Rowe <mrowe@apple.com>

Merge r24453.

2007-07-19 Darin Adler <Darin Adler>

Reviewed by Geoff.

fix <rdar://problem/5345440> PCRE computes wrong length for expressions with quantifiers on named recursion or subexpressions

It's challenging to implement proper preflighting for compiling these advanced features.
But we don't want them in the JavaScript engine anyway.

Turned off the following features of PCRE (some of these are simply parsed and not implemented):

\C \E \G \L \N \P \Q \U \X \Z
\e \l \p \u \z
[::] .. [==]
(?#) (?<=) (?<!) (?>)
(?C) (?P) (?R)
(?0) (and 1-9)
(?imsxUX)

Added the following:

\u \v

Because of \v, the js1_2/regexp/special_characters.js test now passes.

To be conservative, I left some features that JavaScript doesn't want, such as
\012 and \x{2013}, in place. We can revisit these later; they're not directly-enough
related to avoiding the incorrect preflighting.

I also didn't try to remove unused opcodes and remove code from the execution engine.
That could save code size and speed things up a bit, but it would require more changes.

kjs/regexp.h:
kjs/regexp.cpp: (KJS::RegExp::RegExp): Remove the sanitizePattern workaround for lack of \u support, since the PCRE code now has \u support.

pcre/pcre-config.h: Set JAVASCRIPT to 1.
pcre/pcre_internal.h: Added ESC_v.

pcre/pcre_compile.c: Added a different escape table for when JAVASCRIPT is set that omits all the escapes we don't want interpreted and includes '\v'. (check_escape): Put !JAVASCRIPT around the code for '\l', '\L', '\N', '\u', and '\U', and added code to handle '\u2013' inside JAVASCRIPT. (compile_branch): Put !JAVASCRIPT if around all the code implementing the features we don't want. (pcre_compile2): Ditto.

tests/mozilla/expected.html: Updated since js1_2/regexp/special_characters.js now passes.

2:28 AM Changeset in webkit [24577] by bdash

2 edits in branches/Safari-522/JavaScriptCore

2007-07-24 Mark Rowe <mrowe@apple.com>

Merge r24430.

2007-07-18 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

fix <rdar://problem/5345432> PCRE computes length wrong for expressions such as "[]"

Test: fast/js/regexp-charclass-crash.html

pcre/pcre_compile.c: (pcre_compile2): Fix the preflight code that calls check_posix_syntax to match the actual regular expression compilation code; before it was missing the check of the first character.

2:15 AM Changeset in webkit [24576] by bdash