Context Navigation

editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::deleteTarget): Because the deletion UI only appears when the selection is entirely within the target, we unconditionally update the selection to be a caret where the target had been.

5:36 PM Changeset in webkit [24801] by adele

17 edits
4 adds
4 deletes in trunk

LayoutTests:

Reviewed by Hyatt.

Updated tests for <rdar://problem/5339395> REGRESSION:http://sudokucraving.com does not render grid correctly

fast/forms/input-appearance-minWidth.html: Removed. This test is covered by fast/replaced/width100percent-textfield.html.
fast/forms/input-appearance-minWidth-expected.checksum: Removed.
fast/forms/input-appearance-minWidth-expected.png: Removed.
fast/forms/input-appearance-minWidth-expected.txt: Removed.

fast/forms/input-table-expected.checksum:
fast/forms/input-table-expected.png:
fast/forms/input-table-expected.txt:
fast/replaced/width100percent-menulist-expected.checksum:
fast/replaced/width100percent-menulist-expected.png:
fast/replaced/width100percent-menulist-expected.txt:
fast/replaced/width100percent-searchfield-expected.checksum: Added.
fast/replaced/width100percent-searchfield-expected.png: Added.
fast/replaced/width100percent-searchfield-expected.txt: Added.
fast/replaced/width100percent-searchfield.html: Added.
fast/replaced/width100percent-textarea-expected.checksum:
fast/replaced/width100percent-textarea-expected.png:
fast/replaced/width100percent-textarea-expected.txt:
fast/replaced/width100percent-textfield-expected.checksum:
fast/replaced/width100percent-textfield-expected.png:
fast/replaced/width100percent-textfield-expected.txt:

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/5339395> REGRESSION:http://sudokucraving.com does not render grid correctly

rendering/RenderTextControl.h: (WebCore::RenderTextControl::hasControlClip): Clip for search fields.
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::controlClipRect): Added a control clip so the search field's cancel button and magnifier glass never draw outside the control's bounds. (WebCore::RenderTextControl::calcPrefWidths): Only include the inner box's padding when calculating the min/max width without using calcContentBoxWidth. Our old behavior was causing that inner padding to get counted twice. Also, no need to add in the border for an inner box that can't be controlled from outside this class.
rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::calcPrefWidths): ditto.

5:20 PM Changeset in webkit [24800] by andersca

2 edits in trunk/WebCore

Reviewed by Geoff.

Speculative fix for <rdar://problem/5359695>
REGRESSION (Tiger Beta): Multiple crashes in WebCore::Widget::getView() const + 6

page/EventHandler.cpp: (WebCore::EventHandler::updateDragAndDrop): Null check the frame view.

2:17 PM Changeset in webkit [24799] by thatcher

7 edits in trunk

WebCore:

Reviewed by Oliver and Beth.

<rdar://problem/5211271> ADOBE Leopard 9A410: At the first Launching InDesign after deactivate, EULA page gets blanked.

Rename needsAcrobatFrameReloadingQuirk to needsAdobeFrameReloadingQuirk, since this now applies to more Adobe applications.

WebCore.exp:
page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setNeedsAdobeFrameReloadingQuirk):
page/Settings.h: (WebCore::Settings::needsAcrobatFrameReloadingQuirk):

WebKit:

Reviewed by Oliver and Beth.

<rdar://problem/5211271> ADOBE Leopard 9A410: At the first Launching InDesign after deactivate, EULA page gets blanked.

Check for more Adobe applications that need the frame reload quirk. Also cache the answer
so the version check dosen't happen more than once.

WebView/WebView.mm: (-[WebView _needsAdobeFrameReloadingQuirk]): (-[WebView _updateWebCoreSettingsFromPreferences:]):

1:29 PM Changeset in webkit [24798] by beidson

7 edits
2 adds in trunk

LayoutTests:

Reviewed by Brady

Test for http://bugs.webkit.org/show_bug.cgi?id=14757
HTMLTokenizer::processingData implementation is incorrect

http/tests/loading/slow-parsing-subframe-expected.txt: Added.
http/tests/loading/slow-parsing-subframe.html: Added.

WebCore:

Reviewed by Brady and Darin, tweaked by Brady, landed by Brady

Fix for http://bugs.webkit.org/show_bug.cgi?id=14757 and <rdar://problem/5364692>
HTMLTokenizer::processingData implementation is incorrect

html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::processingData): Made it also return true if the HTMLTokenizer was inside the write() call.
loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::checkLoadCompleteTimerFired): (WebCore::FrameLoader::scheduleCheckLoadComplete): (WebCore::FrameLoader::stopForUserCancel): Changed a call to checkLoadComplete to be asynchronous, since stopForUserCancel can be called while parsing.
loader/FrameLoader.h:

12:54 PM Changeset in webkit [24797] by adele

2 edits in trunk/WebKit

Reviewed by Oliver.

Fix for <rdar://problem/5308020> REGRESSION: Command-N with Dvorak-Qwerty keyboard layout stopped working inside web page text fields

WebView/WebHTMLView.mm: (-[WebHTMLView _handleStyleKeyEquivalent:]): The input method may have modified the character we get, so don't use charactersIgnoringModifiers to interpret the character we get.

12:08 PM Changeset in webkit [24796] by andersca

3 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/5371582>
REGRESSION: PLT .5% slower due to r24451 (copying HTMLCollection objects)

Make the hash maps store CollectionInfo pointers to reduce amount of copying when
inserting/rehashing etc.

dom/Document.cpp: (WebCore::Document::~Document): (WebCore::Document::nameCollectionInfo):
dom/Document.h:

11:38 AM Changeset in webkit [24795] by adele

4 edits in trunk/LayoutTests

Reviewed by Beth.

Updated this test to force display to happen earlier. This works around a bug in DRT that draws the scrollbars in a different way from Safari.

fast/replaced/width100percent-textarea-expected.checksum:
fast/replaced/width100percent-textarea-expected.png:
fast/replaced/width100percent-textarea.html:

11:27 AM Changeset in webkit [24794] by adele

1 edit
28 adds
4 deletes in trunk/LayoutTests

Reviewed by Sam.

Breaking up fast/replaced/width100percent.html into separate tests for the different elements.

fast/replaced/width100percent-button-expected.checksum: Added.
fast/replaced/width100percent-button-expected.png: Added.
fast/replaced/width100percent-button-expected.txt: Added.
fast/replaced/width100percent-button.html: Added.
fast/replaced/width100percent-checkbox-expected.checksum: Added.
fast/replaced/width100percent-checkbox-expected.png: Added.
fast/replaced/width100percent-checkbox-expected.txt: Added.
fast/replaced/width100percent-checkbox.html: Added.
fast/replaced/width100percent-image-expected.checksum: Added.
fast/replaced/width100percent-image-expected.png: Added.
fast/replaced/width100percent-image-expected.txt: Added.
fast/replaced/width100percent-image.html: Added.
fast/replaced/width100percent-menulist-expected.checksum: Added.
fast/replaced/width100percent-menulist-expected.png: Added.
fast/replaced/width100percent-menulist-expected.txt: Added.
fast/replaced/width100percent-menulist.html: Added.
fast/replaced/width100percent-radio-expected.checksum: Added.
fast/replaced/width100percent-radio-expected.png: Added.
fast/replaced/width100percent-radio-expected.txt: Added.
fast/replaced/width100percent-radio.html: Added.
fast/replaced/width100percent-textarea-expected.checksum: Added.
fast/replaced/width100percent-textarea-expected.png: Added.
fast/replaced/width100percent-textarea-expected.txt: Added.
fast/replaced/width100percent-textarea.html: Added.
fast/replaced/width100percent-textfield-expected.checksum: Added.
fast/replaced/width100percent-textfield-expected.png: Added.
fast/replaced/width100percent-textfield-expected.txt: Added.
fast/replaced/width100percent-textfield.html: Added.

fast/replaced/width100percent.html: Removed.
fast/replaced/width100percent-expected.checksum: Removed.
fast/replaced/width100percent-expected.png: Removed.
fast/replaced/width100percent-expected.txt: Removed.

10:58 AM Changeset in webkit [24793] by weinig

11 edits in trunk

LayoutTests:

Reviewed by Mitz.

Updated tests for http://bugs.webkit.org/show_bug.cgi?id=14825
Non-integer hsl() colours are ignored

fast/css/hsl-color-expected.checksum:
fast/css/hsl-color-expected.png:
fast/css/hsl-color-expected.txt:
fast/css/hsl-color.html: Add non-integer hue tests
fast/css/hsla-color-expected.checksum:
fast/css/hsla-color-expected.png:
fast/css/hsla-color-expected.txt:
fast/css/hsla-color.html: Add non-integer hue tests

WebCore:

Reviewed by Mitz.

Fix for http://bugs.webkit.org/show_bug.cgi?id=14825
Non-integer hsl() colours are ignored

css/CSSParser.cpp: (WebCore::CSSParser::parseHSLParameters): Parse hue as a Number, not an Integer.

1:32 AM BuildingQtOnWindows edited by Simon Hausmann

(diff)

Jul 30, 2007:

8:54 PM Changeset in webkit [24792] by justing

6 edits
4 adds in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/5369009>
Crash due to infinite recursion in moveParagraphs deleting line from a Mail message

editing/deleting/5369009-expected.checksum: Added.
editing/deleting/5369009-expected.png: Added.
editing/deleting/5369009-expected.txt: Added.
editing/deleting/5369009.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/5369009> Crash due to infinite recursion in moveParagraphs on delete

After the delete, we moved content into the previous block, and a style
rule turned a style span in the moved content into a block, throwing
moveParagraphs into infinite recursion, as it continually tried and failed
to get the style span into the same paragraph as the content just before it.

Added a method to ReplaceSelectionCommand to keep inserted style spans
from turning into blocks because of style rules. Will add code to prevent
other kinds of content from changing appearance because of style rules,
post-Leopard (5371536). Also added a bool to ReplaceSelectionCommand's
constructor to guard against infinite recursion.

editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs):
editing/JSEditor.cpp:
editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): (WebCore::ReplaceSelectionCommand::negateStyleRulesThatEffectAppearance): (WebCore::ReplaceSelectionCommand::doApply):
editing/ReplaceSelectionCommand.h:

8:44 PM Changeset in webkit [24791] by treat

3 edits in trunk/WebKitQt

Fix build.

8:18 PM Changeset in webkit [24790] by sullivan

3 edits in trunk/WebKit

Reviewed by Darin

fixed <rdar://problem/5216176> Need WebKit SPI to allow clients using embedded WebViews to avoid clipping ends of some printed pages

This provides Mail, and other clients that print views that embed WebViews, a way to ensure that
the HTML is laid out for printing before pagination occurs.

WebView/WebHTMLViewPrivate.h: new SPI method -_layoutForPrinting

WebView/WebHTMLView.mm: (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): new method, just like existing _web_setPrintingModeRecursive except passes YES for adjustViewSize (-[WebHTMLView _layoutForPrinting]): new SPI method, sets printing mode temporarily to adjust the view size for printing (-[NSView _web_setPrintingModeRecursiveAndAdjustViewSize]): new helper method to do the recursion

5:48 PM Changeset in webkit [24789] by andersca

2 edits in trunk/WebCore

Reviewed by Brady.

<rdar://problem/5371515>
BitmapImage::getTIFFRepresentation() bug results in favicons not working at many sites

Don't bail out if a single frame is invalid.

platform/graphics/mac/ImageMac.mm: (WebCore::BitmapImage::getTIFFRepresentation):

5:29 PM Changeset in webkit [24788] by darin

1 edit in trunk/WebCore/ChangeLog-2006-05-10

Fix a bug number on an old check-in.

5:09 PM Changeset in webkit [24787] by adele

2 edits in trunk/WebKit

Reviewed by Darin.

Fix for <rdar://problem/5367919> A crash occurs at WebCore::Frame::isFrameSet() when attempting to print a iframe before it loads at http://www.monster.com/

WebView/WebHTMLView.mm: (-[WebHTMLView knowsPageRange:]): Nil check for frame.

4:56 PM Changeset in webkit [24786] by adele

2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/5274937> Safari 3 breaks Missing Sync's WebKit code by crashing

loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy): Nil check for the FrameLoader.

4:24 PM Changeset in webkit [24785] by andersca

6 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/5370710>
REGRESSION: After switching from Bookmark view, the Find Banner won't appear while displaying a PDF file

Add a hasHTMLView to FrameLoaderClient. This is only useful for clients who can show different views for different
MIME types and URL schemes.

loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted): Call delegate methods here if the current view is not a HTML view.

loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::hasHTMLView):

WebKit:

Reviewed by Darin.

<rdar://problem/5370710>
REGRESSION: After switching from Bookmark view, the Find Banner won't appear while displaying a PDF file

Implement hasHTMLView.

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::hasHTMLView):

4:05 PM Changeset in webkit [24784] by darin

1 edit in trunk/WebKitTools/ChangeLog

Hatcher!

4:05 PM Changeset in webkit [24783] by darin

2 edits in trunk/WebKitTools

Reviewed by Tim Matcher.

DumpRenderTree/DumpRenderTree.m: (dump): Fix dumping for documents that include null characters. This turned out not to be needed for the test case that motivated me to do it, but it's nice to have this for the future.

3:29 PM Changeset in webkit [24782] by justing

1 edit in trunk/WebKit/WebView/WebEditingDelegatePrivate.h

Fixed a typo in my last checkin.

11:29 AM Changeset in webkit [24781] by weinig

14 edits
2 adds
4 deletes in trunk

LayoutTests:

Reviewed by Maciej.

Update tests for <rdar://problem/5363896>
REGRESSION: Setting document.domain does not override port-based cross-frame security checks -- breaks SAP NetWeaver

Also changes frame access test to use shared resource iframes.

http/tests/security/cross-frame-access-port-expected.txt:
http/tests/security/cross-frame-access-port-explicit-domain-expected.txt:
http/tests/security/cross-frame-access-port-explicit-domain.html:
http/tests/security/cross-frame-access-port.html:
http/tests/security/cross-frame-access-protocol-expected.txt:
http/tests/security/cross-frame-access-protocol-explicit-domain-expected.txt:
http/tests/security/cross-frame-access-protocol-explicit-domain.html:
http/tests/security/cross-frame-access-protocol.html:
http/tests/security/resources/cross-frame-iframe-for-port-explicit-domain-test.html: Removed.
http/tests/security/resources/cross-frame-iframe-for-port-test.html: Removed.
http/tests/security/resources/cross-frame-iframe-for-protocol-explicit-domain-test.html: Removed.
http/tests/security/resources/cross-frame-iframe-for-protocol-test.html: Removed.
http/tests/security/resources/cross-frame-iframe-with-explicit-domain-set.html: Added.
http/tests/security/resources/cross-frame-iframe.html: Added.

WebCore:

Reviewed by Maciej.

Fix for <rdar://problem/5363896>
REGRESSION: Setting document.domain does not override port-based cross-frame security checks -- breaks SAP NetWeaver

Updates the results for:

http/tests/security/cross-frame-access-port-explicit-domain.html
http/tests/security/cross-frame-access-protocol-explicit-domain.html

bindings/js/kjs_window.cpp: (KJS::createWindow): Use the new setDomainInternal method. (KJS::Window::isSafeScript): Don't set check the port or protocol if both documents have explicitly set document.domain in the DOM and the those domains are equal.
dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::setDomain): Remove force parameter and change all calls that relied on it use the new setDomainInternal method which does the same thing. (WebCore::Document::setDomainInternal):
dom/Document.h: Add new m_domainWasSetInDOM variable and accessor. (WebCore::Document::domainWasSetInDOM):
loader/FrameLoader.cpp: (WebCore::FrameLoader::checkCallImplicitClose): Use the new setDomainInternal method.

11:25 AM Changeset in webkit [24780] by justing

14 edits in trunk

WebCore:

Reviewed by Tristan.

<rdar://problem/5098931> Attachments are lost when they are moved into a ToDo after a delete

Added an editor client method for asking whether or not it is
OK to merge content after a delete.

bridge/EditorClient.h:
editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): Ask if the merge is allowed.
platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::shouldMoveRangeAfterDelete): Added a method stub.
platform/gdk/EditorClientGdk.h:
platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::shouldMoveRangeAfterDelete): Ditto.

WebKit:

Reviewed by Tristan.

<rdar://problem/5098931> Attachments are lost when they are moved into a ToDo after a delete

Mail needs to be asked if it is OK to do the content movement that happens
after a deleting in a situation like this one:
<div contenteditable="plaintext-only">foo</div><div>^{bar</div>

so that they can prevent the move or so that they can save content that

will be stripped by the move. This could have been done with shouldInsertNode

and a new WebViewInsertAction for "moves", but WebKit clients like Mail and

DashCode think that a shouldInsert* means that the user pasted something and

perform actions only appropriate for pastes. This change is less risky because

it won't require those clients to change their code.}

DefaultDelegates/WebDefaultEditingDelegate.m: (-[WebDefaultEditingDelegate webView:shouldMoveRangeAfterDelete:replacingRange:]):
WebCoreSupport/WebEditorClient.h:
WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldMoveRangeAfterDelete):
WebView/WebEditingDelegatePrivate.h:

win:

Reviewed by Tristan.

<rdar://problem/5098931> Attachments are lost when they are moved into a ToDo after a delete

WebEditorClient.cpp: (WebEditorClient::shouldMoveRangeAfterDelete): Method stub.
WebEditorClient.h:

11:15 AM Changeset in webkit [24779] by andersca

4 edits
4 adds in trunk

LayoutTests:

Reviewed by Anders.

<rdar://problem/5352526>
http://bugs.webkit.org/show_bug.cgi?id=14704
REGRESSION: sync XMLHttpRequest.send() raises an exception for failed authentication

http/tests/xmlhttprequest/failed-auth-expected.txt: Added.
http/tests/xmlhttprequest/failed-auth.html: Added. This test has other cases from bug 13075 commented out, as they still fail.

http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt: Added.
http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html: Added. This test already passed, but I think it's useful to cover this case, too.

WebCore:

Reviewed by Anders.

<rdar://problem/5352526>
http://bugs.webkit.org/show_bug.cgi?id=14704
REGRESSION: sync XMLHttpRequest.send() raises an exception for failed authentication

Test: http/tests/xmlhttprequest/failed-auth.html

platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::loadResourceSynchronously): Make the fake response better match the real one in case of failed authentication. Unfortunately, NSURLConnection doesn't give us the real response.

xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send): If the response has an HTTP code in it, then the error wasn't a network one, and an exception shouldn't be raised.

10:48 AM Changeset in webkit [24778] by tristan

1 edit in trunk/LayoutTests/http/tests/navigation/relativeanchor-frames-expected.txt

Updating layout test results with new expected results.

10:28 AM Changeset in webkit [24777] by andersca

2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4942372> REGRESSION: Anchor links in Mail don't work anymore

Make it possible for KURL to handle addig fragments to non-hierarchical URLs
such as mailto: and cid:.

platform/KURL.cpp: (WebCore::KURL::init): If the base URL is not hierarchical but the relative URL is a fragment, then allow parsing it.

(WebCore::KURL::parse):
If the URL is not hierarchical, set the fragment start and end positions correctly.

9:10 AM Changeset in webkit [24776] by hausmann

2 edits in trunk/WebCore

On Windows make sure the dll also ends up in $$OUTPUT_DIR/bin, so that QtLauncher can find it.

9:10 AM Changeset in webkit [24775] by hausmann

4 edits in trunk

Link QtLauncher into $$OUTPUT_DIR/bin

8:30 AM Changeset in webkit [24774] by hausmann

5 edits in trunk

Removed the BUILDING_QT ifdef in JSStringRef.h and changed UChar for the Qt build to use wchar_t on Windows.

8:30 AM Changeset in webkit [24773] by hausmann

2 edits in trunk/WebCore

Don't link against libxml/libxslt unless we really need it.

6:57 AM Changeset in webkit [24772] by zimmermann

72 edits in branches/feature-branch

Reviewed by Oliver & Rob.

Enable SVG textPath selection. Actually build chunks for them instead of
ignoring them - was easier than I thought. Respect per-character transformation
when calculating the chunk boundaries for the selection rectangles. Also fixes
selection rect drawing of rotated characters.

Next thing todo is to unify the glyph size calculations, as per-glyph transformations
are not respected when calculating flow box sizes in SVGRootInlineBox.

6:51 AM BuildingQtOnWindows edited by Simon Hausmann

(diff)

6:46 AM BuildingQtOnWindows edited by Simon Hausmann

(diff)

6:39 AM BuildingQtOnWindows edited by Simon Hausmann

(diff)

6:34 AM BuildingQtOnWindows edited by Simon Hausmann

(diff)

6:31 AM BuildingQtOnWindows edited by Simon Hausmann

(diff)

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed