⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 3, 2007:

8:57 PM Changeset in webkit [24865] by aroben
  • 2 edits in trunk/WebKitTools

Catch SIGPIPE on Windows so that run-webkit-tests doesn't quit when DRT crashes

Reviewed by Sam.

  • Scripts/run-webkit-tests: Also close ERROR when we finish running the tests.
6:09 PM Changeset in webkit [24864] by adele
  • 2 edits in trunk/WebCore

Reviewed by Adam.

Fix for <rdar://problem/5345862> CrashTracer: [USER] 4 crashes in Safari at com.apple.WebCore: WebCore::Frame::isContentEditable const + 10

Couldn't reproduce the problem, but a nil check for the frame should fix this.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
5:22 PM Changeset in webkit [24863] by weinig
  • 12 edits in trunk

LayoutTests:

Reviewed by Darin.

Dump contents of subframes using new layoutTestController.dumpChildFramesAsText()
function.

  • http/tests/security/cross-frame-access-port-expected.txt:
  • http/tests/security/cross-frame-access-port-explicit-domain-expected.txt:
  • http/tests/security/cross-frame-access-protocol-expected.txt:
  • http/tests/security/cross-frame-access-protocol-explicit-domain-expected.txt:
  • http/tests/security/resources/cross-frame-access.js:

WebKitTools:

Reviewed by Darin.

Recursively dump all frames as text using new
layoutTestController.dumpChildFramesAsText() function.

  • DumpRenderTree/DumpRenderTree.m: (dumpFramesAsText): (dump): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController dumpChildFramesAsText]): (runTest):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dumpFramesAsText): (dump): (runTest):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (dumpChildFramesAsTextCallback):
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4:53 PM Changeset in webkit [24862] by andersca
  • 7 edits in trunk/WebCore

Reviewed by Oliver.

<rdar://problem/5383286>
XMLHTTPRequest does not return 401 when user cancels authentication dialog (affects .Mac)


  • loader/ResourceLoader.h: Make receivedCancellation virtual.


  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::receivedCancellation): Call SubresourceLoaderClient::receivedCancellation.


  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::receivedCancellation): Save the failure response.
4:07 PM Changeset in webkit [24861] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/5374393>
Image change on disk not noticed by WebView; -[WebCache setDisabled:] used to cause a reload every time


This is essentially a better fix for the crash in <rdar://problem/5362783>.


  • loader/DocLoader.cpp: (WebCore::DocLoader::requestResource): If the resource already exists in the m_docResources map, remove it and disassociate it from the doc loader.
3:37 PM Changeset in webkit [24860] by oliver
  • 3 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/5375190> Mail crashed in WebCore::CachedImage::imageSize() const when viewing a particular message

Fix the uncached load path to confirm that the type of resource being
returned actually matches the type that was requested.

Also make sure we never create a resource in the Cache for invalid urls.

  • loader/Cache.cpp: (WebCore::Cache::requestResource):
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestResource):
3:17 PM Changeset in webkit [24859] by sfalken
  • 1 copy in tags/Safari-522.16.1b

New tag.

3:17 PM Changeset in webkit [24858] by sfalken
  • 1 edit in trunk/WebKit/win/WebKit.vcproj/VERSION

Bump version for submit

3:15 PM Changeset in webkit [24857] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Adele.

  • fast/forms/menulist-deselect-update-expected.checksum: Added.
  • fast/forms/menulist-deselect-update-expected.png: Added.
  • fast/forms/menulist-deselect-update-expected.txt: Added.
  • fast/forms/menulist-deselect-update.html: Added.

WebCore:

Reviewed by Adele.

Test: fast/forms/menulist-deselect-update.html

  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::setSelected): Reordered to allow setSelectedIndex() to call setChanged().
2:42 PM Changeset in webkit [24856] by spadma
  • 7 edits in S60/trunk/WebKit

2007-07-31 vmalaiya, <​vikram.malaiya@nokia.com>

Reviewed by Sachin
DESC: AKUR-74Q7EL - Browser crashes when Vote button selected on second window
​http://bugs.webkit.org/show_bug.cgi?id=14829

  • BrowserView/inc/FormDataLoginStore.h:
  • BrowserView/inc/FormDataManager.h:
  • BrowserView/src/FormDataLoginStore.cpp: (CFormDataLoginStore::CLoginDataElement::~CLoginDataElement): (CFormDataLoginStore::NewL): (CFormDataLoginStore::ConstructL): (CFormDataLoginStore::GetDataL): (CFormDataLoginStore::SaveDataL): (CFormDataLoginStore::SaveDialogL):
  • BrowserView/src/FormDataManager.cpp: (CFormDataManager::NewL): (CFormDataManager::ConstructL): (CFormDataManager::SaveDataL):
  • BrowserView/src/WebKitControl.cpp: (CStaticObjectContainer::FormDataManagerHandlerL):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::SaveFormData):
2:41 PM Changeset in webkit [24855] by spadma
  • 3 edits in S60/trunk/WebKit

2007-07-24 vmalaiya, <​vikram.malaiya@nokia.com>

Reviewed by Sachin
DESC: VMAA-75EP3L - Browser plugin does not implement memory collection on an out-of-memory condition
​http://bugs.webkit.org/show_bug.cgi?id=14753


  • Plugin/inc/PluginSkin.h:
  • Plugin/src/PluginSkin.cpp: (COOMPluginCollector::COOMPluginCollector): (COOMPluginCollector::~COOMPluginCollector): (COOMPluginCollector::Collect): (COOMPluginCollector::Restore): (COOMPluginCollector::Priority): (COOMPluginCollector::IsCollecting): (CPluginSkin::ConstructL): (CPluginSkin::~CPluginSkin): (CPluginSkin::CreatePluginWinL):
2:28 PM Changeset in webkit [24854] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

brmorris, rs'd by johnshi

DESC: remove generated header from releasables list (merge of r24167 & r24121 to 3.1m)


Turns out some build systems delete the releasables list after the
makmake phase but before the compilation, and hence the generated
header was not found at compile time.



  • group/version.mk: Added.
2:21 PM Changeset in webkit [24853] by spadma
  • 2 edits in S60/trunk/WebKit

yadavall, reviewed by <​sachin.padma@nokia.com>

DESC: Center key press must be sent to Engine
​http://bugs.webkit.org/show_bug.cgi?id=14593

  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleOfferKeyEventL):
2:04 PM Changeset in webkit [24852] by spadma
  • 2 edits in S60/trunk/WebKit

lebril, reviewed by Sachin

DESC: ELFN-7535HR: Operator manu: Both time stamps in Link-1 and Link-2 are same when opening link is in Expires Date header 1A iteam
​http://bugs.webkit.org/show_bug.cgi?id=

  • ResourceLoader/CacheSrc/HttpCacheUtil.cpp:
1:09 PM Changeset in webkit [24851] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5286444>
​http://bugs.webkit.org/show_bug.cgi?id=14269
REGRESSION: Gmail links stop working after computer sleep


Add a PowerNotifier object that takes care of resetting and firing the shared timer when coming
back from sleep.


  • platform/mac/SharedTimerMac.cpp: (-[PowerNotifier init]): (-[PowerNotifier didWake:]): (WebCore::setSharedTimerFireTime):
11:46 AM Changeset in webkit [24850] by bdash
  • 2 edits in trunk/WebCore

2007-08-04 Mark Rowe <​mrowe@apple.com>

Windows build fix.

  • rendering/RenderTextControl.cpp: Don't use the same name for two arguments.
11:19 AM Changeset in webkit [24849] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-08-04 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Anders.

  • pcre/pcre_compile.c: Remove non-ASCII character from a comment.
11:03 AM Changeset in webkit [24848] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Mark Rowe.

Correct the bundle version check to work in Debug and Release builds too.

  • WebKit.xcodeproj/project.pbxproj:
10:58 AM Changeset in webkit [24847] by bdash
  • 4 edits in trunk

Bump versioning to avoid 4. issues.

10:20 AM Changeset in webkit [24846] by zbujtas
  • 3 edits in S60/trunk/WebKit

2007-08-02 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: Widget Cascade menu not in FIFO order
​http://bugs.webkit.org/show_bug.cgi?id=14866

10:18 AM Changeset in webkit [24845] by zbujtas
  • 4 edits in S60/branches/3.1m

2007-08-02 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: Widget Cascade menu not in FIFO order
​http://bugs.webkit.org/show_bug.cgi?id=14866

9:31 AM Changeset in webkit [24844] by yongjzha
  • 2 edits in S60/branches/3.1m/WebCore

w3liu, reviewed by <​yongjun.zhang@nokia.com>

DESC: FPER-74HDN2: Strange character are shown instead of Chinese on www.sina.com.cn
​http://bugs.webkit.org/show_bug.cgi?id=14830

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/khtml_part.cpp: (KHTMLPart::write):
9:21 AM Changeset in webkit [24843] by bdash
  • 7 edits
    3 adds in trunk/JavaScriptCore

2007-08-02 Mark Rowe <​mrowe@apple.com>

Reviewed by Geoff Garen.

<rdar://problem/4212199> 'leaks' reports false leaks in WebKit (because the WTF allocator uses mmap?)

Implement malloc zone introspection routines to allow leaks, heap, and friends to request information
about specific memory regions that were allocated by FastMalloc or the JavaScriptCore collector.

This requires tool-side support before the regions will be displayed. The addition of that support is
tracked by <rdar://problems/5353057&5353060>.

  • JavaScriptCore.exp: Export the two variables that are used by leaks to introspect the allocators.
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/AllInOneFile.cpp:
  • kjs/CollectorZone.cpp: Added. (KJS::): (KJS::CollectorZone::registerZone): (KJS::CollectorZone::CollectorZone): Create and register our zone with the system. (KJS::CollectorZone::zoneEnumerator): Iterate over the CollectorBlocks that are in use and report them to the caller as being used.
  • kjs/CollectorZone.h: Added. (KJS::CollectorZone::zoneObjectSize): Return zero to indicate the specified pointer does not belong to this zone.
  • kjs/collector.cpp: (KJS::Collector::registerThread): Register the CollectorZone with the system when the first thread is registered with the collector.
  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::GetDescriptorEnsureSafe): (WTF::TCMalloc_ThreadCache_FreeList::enumerateFreeObjects): Enumerate the objects on the free list. (WTF::TCMalloc_ThreadCache::enumerateFreeObjects): Ditto. (WTF::TCMalloc_Central_FreeList::enumerateFreeObjects): Ditto. (WTF::TCMalloc_ThreadCache::InitModule): Register the FastMallocZone with the system when initializing TCMalloc. (WTF::FreeObjectFinder::FreeObjectFinder): (WTF::FreeObjectFinder::visit): Add an object to the free list. (WTF::FreeObjectFinder::isFreeObject): (WTF::FreeObjectFinder::freeObjectCount): (WTF::FreeObjectFinder::findFreeObjects): Find the free objects within a thread cache or free list. (WTF::PageMapFreeObjectFinder::PageMapFreeObjectFinder): Find the free objects within a TC_PageMap. (WTF::PageMapFreeObjectFinder::visit): Called once per allocated span. Record whether the span or any subobjects are free. (WTF::PageMapMemoryUsageRecorder::PageMapMemoryUsageRecorder): (WTF::PageMapMemoryUsageRecorder::visit): Called once per allocated span. Report the range of memory as being allocated, and the span or it's subobjects as being used if they do not appear on the free list. (WTF::FastMallocZone::zoneEnumerator): Map the key remote TCMalloc data structures into our address space. We then locate all free memory ranges before reporting the other ranges as being in use. (WTF::FastMallocZone::zoneObjectSize): Determine whether the given pointer originates from within our allocation zone. If so, we return its allocation size. (WTF::FastMallocZone::zoneMalloc): (WTF::FastMallocZone::zoneCalloc): (WTF::FastMallocZone::zoneFree): (WTF::FastMallocZone::zoneRealloc): (WTF::): (WTF::FastMallocZone::FastMallocZone): Create and register our zone with the system. (WTF::FastMallocZone::registerZone):
  • wtf/MallocZoneSupport.h: Added. (WTF::RemoteMemoryReader::RemoteMemoryReader): A helper class to ease the process of mapping memory in a different process into our local address space (WTF::RemoteMemoryReader::operator()):
  • wtf/TCPageMap.h: (TCMalloc_PageMap2::visit): Walk over the heap and visit each allocated span. (TCMalloc_PageMap3::visit): Ditto.
7:29 AM Changeset in webkit [24842] by bdash
  • 3 edits
    2 adds in trunk

2007-08-03 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/forms/search-click-in-placeholder.html

Defined a subclass of RenderBlock that never hit-tests children for use in
text controls. This avoids returning placeholder text as the hit node.
Since text controls cannot contain inline elements, there is no harm in
doing that unconditionally, and not just in the case that the field is
showing placeholder text.

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock): (WebCore::RenderTextControlInnerBlock::~RenderTextControlInnerBlock): (WebCore::RenderTextControlInnerBlock::nodeAtPoint): (WebCore::RenderTextControl::createSubtreeIfNeeded):

2007-08-03 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/forms/search-click-in-placeholder-expected.txt: Added.
  • fast/forms/search-click-in-placeholder.html: Added.
4:57 AM Changeset in webkit [24841] by bdash
  • 3 edits in tags/Safari-5522.13/WebCore

Merge r24810.

Reviewed by Justin.

<rdar://problem/5376156> Mail crash in DeleteButtonController::hide() when dropping selected image on DIV's border

Add the container element back so the selection can not touch the deletion UI nodes. The container
has style to prevent user selection, user drag and user modification.

  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::show): Make the container node, and append the button and outline elements. (WebCore::DeleteButtonController::hide): Remove the container elements and null out the other nodes.
  • editing/DeleteButtonController.h:
4:33 AM Changeset in webkit [24840] by bdash
  • 4 edits in trunk

Versioning.

4:32 AM Changeset in webkit [24839] by bdash
  • 1 copy in tags/Safari-5522.13

New tag.

12:21 AM Changeset in webkit [24838] by aroben
  • 3 edits in trunk/LayoutTests

Updated Skipped files for Windows and Leopard.

  • mac/leopard/Skipped: Removed a test that has been moved (and only fails on Windows), and added new failures.
  • win/Skipped: Added new failures and annotated some old ones.
12:21 AM Changeset in webkit [24837] by aroben
  • 3 edits in trunk/LayoutTests

Fix a typo in fast/events/no-blur-on-page

Reviewed by Sam.

  • fast/events/no-blur-on-page-leave-expected.txt: Updated.
  • fast/events/no-blur-on-page-leave.html: Fixed typo.
12:21 AM Changeset in webkit [24836] by aroben
  • 2 edits in trunk/WebKitTools

Fix fast/dom/Window/alert-undefined.html

Reviewed by Sam.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (WaitUntilDoneDelegate::runJavaScriptAlertPanelWithMessage): Don't let Windows translate a null BSTR into "(null)"

Aug 2, 2007:

8:17 PM Changeset in webkit [24835] by oliver
  • 6 edits in trunk/WebCore

Reviewed by Geoff

Fix for <rdar://problem/5369332> Xcode crashes while selecting a hyperlink within a AppleScript dictionary (WebCore::Font::drawGlyphBuffer)

There were many places where we were not correctly retaining/releasing the
NSFont object stored in the C++ PlatformFontData object, this resulted in
the GC incorrectly collecting the NSFont.

This patch fixes the problem by prevent direct modification of the PlatformFontData
font pointer, allowing us to enforce correct CFRetain/Release behaviour.

  • platform/FontData.h: (WebCore::FontData::getNSFont):
  • platform/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::createFontPlatformData):
  • platform/mac/FontDataMac.mm: (WebCore::initFontData): (WebCore::FontData::platformInit): (WebCore::FontData::platformDestroy): (WebCore::FontData::smallCapsFontData): (WebCore::FontData::containsCharacters): (WebCore::FontData::determinePitch): (WebCore::FontData::platformWidthForGlyph): (WebCore::FontData::checkShapesArabic):
  • platform/mac/FontMac.mm: (WebCore::initializeATSUStyle): (WebCore::overrideLayoutOperation): (WebCore::Font::drawGlyphs):
  • platform/mac/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::operator==): (WebCore::FontPlatformData::font): (WebCore::FontPlatformData::setFont):
5:24 PM Changeset in webkit [24834] by weinig
  • 3 edits in trunk/LayoutTests

Reviewed by Kevin McCullough.

Change test to use shared shouldBe function to
show failures more clearly.

  • fast/dom/Window/window-resize-expected.txt:
  • fast/dom/Window/window-resize.html:
4:54 PM Changeset in webkit [24833] by antti
  • 2 edits in trunk/WebCore

Oops, this change wasn't supposed to be commited.

  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setBaseBackgroundColor:]):
4:45 PM Changeset in webkit [24832] by antti
  • 4 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5355951>
plainText() fragments TCMalloc heap badly on large pages


also likely fixes some cases of
<rdar://problem/5335382>
CrashTracer: [REGRESSION] 73 crashes in Safari at com.apple.WebCore: WebCore::DeprecatedStringData::increaseUnicodeSize + 52


If you load ​http://dscoder.com/test.txt with WebKit build with TCMalloc and system malloc you see that
Safari RPRVT with TCMalloc is 118.8MB
Safari RPRVT with system malloc is 69.7MB


Difference is almost entirely caused by heap fragmentation from a full document plainText() call (for indexing purposes).


The patch helps in two ways:

  • construct plainText string in pieces to avoid O(n2) reallocs
  • allocate buffers using system malloc so they can be returned back to OS and don't fragment and grow TCMalloc heap


This shrinks ​http://dscoder.com/test.txt RPRVT to 79.0MB and makes full document plainText() take 50ms instead of 500ms.
The benefits are not limited to extreme cases, web pages above ~200kB can show substantial improvement in RPRVT.

  • editing/TextIterator.cpp: (WebCore::plainTextToMallocAllocatedBuffer): (WebCore::plainText):
  • editing/TextIterator.h:
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge selectedString]): (-[WebCoreFrameBridge stringForRange:]):
3:50 PM Changeset in webkit [24831] by hyatt
  • 3 edits in trunk/WebCore

Fix for 5374437, allow comment nodes to be the child of a document.
Refine the check to always make a root element to check documentElement()
rather than firstChild(), since a comment node could be present as the
firstChild() now.

Reviewed by Tim Hatcher

  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::childAllowed):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::finished):
3:39 PM Changeset in webkit [24830] by kmccullo
  • 2 edits in trunk/WebKitTools

Reviewed by Tim.

  • It would help if I actually called the right function.
  • Drosera/DebuggerDocument.cpp: (DebuggerDocument::showConsole):
3:00 PM Changeset in webkit [24829] by antti
  • 6 edits
    5 adds in trunk

LayoutTests:

Reviewed by Darin.


<rdar://problem/5228138>
REGRESSION(Leopard): test failures: tests that test Georgian numbering


Correct counter test results for Georgian numbers.
Add leopard specific versions needed due to font changes (actual characters instead of boxes).

  • css2.1/t1202-counter-09-b-expected.txt:
  • css2.1/t1202-counters-09-b-expected.txt:
  • mac/leopard/Skipped:
  • mac/leopard/css2.1: Added.
  • mac/leopard/css2.1/t1202-counter-09-b-expected.txt: Added.
  • mac/leopard/css2.1/t1202-counters-09-b-expected.txt: Added.
  • mac/leopard/fast/lists: Added.
  • mac/leopard/fast/lists/w3-list-styles-expected.txt: Added.

WebCore:

Reviewed by Darin.


<rdar://problem/5228138>
REGRESSION(Leopard): test failures: tests that test Georgian numbering

Fix to Georgian number tables to get CSS2.1 test results right. Font has relevant characters now
which revealed that results were actually wrong.

  • rendering/RenderListMarker.cpp: (WebCore::toGeorgian):
2:41 PM Changeset in webkit [24828] by antti
  • 6 edits in trunk/LayoutTests

Reviewed by Geoff.


Fix <rdar://problem/5228233>
REGRESSION(Leopard): layout test failures: fast/table/absolute-table-at-bottom


Remove an arrow symbol unrelated to what is being tested. It has different metrics on Leopard.

  • fast/table/absolute-table-at-bottom-expected.checksum:
  • fast/table/absolute-table-at-bottom-expected.png:
  • fast/table/absolute-table-at-bottom-expected.txt:
  • fast/table/absolute-table-at-bottom.html:
  • mac/leopard/Skipped:
1:08 PM Changeset in webkit [24827] by beidson
  • 2 edits in trunk/WebKit

Reviewed by Tim

<rdar://problem/5381463> - setMIMETypesShownAsHTML mutates while enumerating

  • WebView/WebView.mm: (+[WebView setMIMETypesShownAsHTML:]): Copy the dictionary before we work with it.
11:24 AM Changeset in webkit [24826] by adachan
  • 8 edits in trunk

2007-08-02 Ada Chan <​adachan@apple.com>

Reviewed by Steve.

WebCore:

<rdar://problem/5079175> Added parameters headerHeight and footerHeight to
computePageRectsForFrame() so we can account for the header and footer when
calculating page heights for this frame.

  • bridge/win/FrameWin.cpp: (WebCore::computePageRectsForFrame):
  • bridge/win/FrameWin.h:


WebKit/win:

<rdar://problem/5079175> Printing header and footer

  • Interfaces/IWebUIDelegate.idl: added methods for header/footer drawing.
  • WebFrame.cpp: (WebFrame::headerAndFooterHeights): ask client for the header and footer heights via IWebUIDelegate2 methods. (WebFrame::computePageRects): pass in header and footer heights when calculating page rect heights. (WebFrame::spoolPages): ask client to draw header and footer via IWebUIDelegate2 methods.
  • WebFrame.h:
  • WebKitGraphics.cpp: (DrawTextAtPoint): the code assumes color has 4 components - might as well assert it.
7:08 AM Changeset in webkit [24825] by yongjzha
  • 2 edits in S60/branches/3.1m/MemoryManager

2007-08-01 vmalaiya, <​vikram.malaiya@nokia.com>

Reviewed by Yongjun
DESC: - Added error check in case an attempt to commit memory fails.
TSW Id - SKAR-74YPNV
​http://bugs.webkit.org/show_bug.cgi?id=14844

  • Src/fast_malloc.cpp: (chunkMoreCore): (symbian_mmap):
7:02 AM Changeset in webkit [24824] by yongjzha
  • 2 edits in S60/trunk/MemoryManager

2007-08-01 vmalaiya, <​vikram.malaiya@nokia.com>

Reviewed by Yongjun
DESC: - Added error check in case an attempt to commit memory fails.
TSW Id - SKAR-74YPNV
​http://bugs.webkit.org/show_bug.cgi?id=14844

  • Src/fast_malloc.cpp: (chunkMoreCore): (symbian_mmap):
4:56 AM Changeset in webkit [24823] by staikos
  • 4 edits in trunk/WebKitQt

Add an interface for the useragent string

3:01 AM Changeset in webkit [24822] by bdash
  • 2 edits in trunk/LayoutTests

2007-08-02 Mark Rowe <​mrowe@apple.com>

Layout test fix, rubber-stamped by Oliver.

  • fast/js/resources/string-concatenate-outofmemory.js: Don't let an out of memory exception during verification cause a failure. The exception is a perfectly valid success case as it shows that access the string did not cause a crash.
2:49 AM Changeset in webkit [24821] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-08-02 Mark Rowe <​mrowe@apple.com>

Build fix.

  • kjs/ustring.cpp: (KJS::UString::expandedSize): Use std::numeric_limits<size_t>::max() rather than the non-portable SIZE_T_MAX.
2:33 AM Changeset in webkit [24820] by bdash
  • 7 edits in trunk

2007-08-02 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

<rdar://problem/5352887> "Out of memory" error during repeated JS string concatenation leaks hundreds of MBs of RAM

A call to fastRealloc was failing which lead to UString::expandCapacity leaking the buffer it was trying to reallocate.
It also resulted in the underlying UString::rep having both a null baseString and buf field, which meant that attempting
to access the contents of the string after the failed memory reallocation would crash.

A third issue is that expandedSize size was calculating the new length in a way that led to an integer overflow occurring.
Attempting to allocate a string more than 190,000,000 characters long would fail a the integer overflow would lead to a
memory allocation of around 3.6GB being attempted rather than the expected 390MB. Sizes that would lead to an overflow
are now returned as zero and callers are updated to treat this as though the memory allocation has failed.

  • kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): Check whether the append failed and raise an "Out of memory" exception if it did.
  • kjs/ustring.cpp: (KJS::allocChars): Wrapper around fastMalloc that takes a length in characters. It will return 0 when asked to allocate a zero-length buffer. (KJS::reallocChars): Wrapper around fastRealloc that takes a length in characters. It will return 0 when asked to allocate a zero-length buffer. (KJS::UString::expandedSize): Split the size calculation in two and guard against overflow during each step. (KJS::UString::expandCapacity): Don't leak r->buf if reallocation fails. Instead free the memory and use the null representation. (KJS::UString::expandPreCapacity): If fastMalloc fails then use the null representation rather than crashing in memcpy. (KJS::UString::UString): If calls to expandCapacity, expandPreCapacity or fastMalloc fail then use the null representation rather than crashing in memcpy. (KJS::UString::append): Ditto. (KJS::UString::operator=): Ditto.
  • kjs/ustring.h: Change return type of expandedSize from int to size_t.

2007-08-02 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

<rdar://problem/5352887> "Out of memory" error during repeated JS string concatenation leaks hundreds of MBs of RAM

Update test to check that accessing the string after the "Out of memory" exception was raised does not crash.

  • fast/js/resources/string-concatenate-outofmemory.js:
  • fast/js/string-concatenate-outofmemory-expected.txt:
12:24 AM Changeset in webkit [24819] by aliceli1
  • 1 edit in trunk/WebKit/ChangeLog

forgot to add info about the bug being fixed

12:13 AM Changeset in webkit [24818] by aliceli1
  • 4 edits
    1 add in trunk

WebCore:

Reviewed by Kevin McCullough.

fixed <rdar://problem/5310312> REGRESSION: javascript is mis-escaped at ​http://labs.zarate.org/passwd causing bookmarklet to break


  • WebCore.exp: expose some calls for WebKit to call.
  • manual-tests/JavaScript-bookmarklets.html: Added.

WebKit:

Reviewed by Kevin McCullough.

  • Misc/WebNSURLExtras.mm: (+[NSURL _web_URLWithUserTypedString:relativeToURL:]): (-[NSURL _web_userVisibleString]): (-[NSURL _web_URLWithLowercasedScheme]): (-[NSURL _web_dataForURLComponentType:]): These 4 changes are just casting changes.

(-[NSString _webkit_stringByReplacingValidPercentEscapes]):
This change replaces the call to an NSURL method with a webcore one that doesn't abort the escaping effort once an illegal character is encountered.

12:01 AM Changeset in webkit [24817] by aroben
  • 2 edits in trunk/WebKitTools

Don't delete the stderr file right after creating it

Reviewed by NOBODY.

  • Scripts/run-webkit-tests:
Note: See TracTimeline for information about the timeline view.