⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 8, 2007:

11:37 PM Changeset in webkit [24954] by bdash
  • 1 copy in tags/Safari-4523

New tag.

10:19 PM Changeset in webkit [24953] by bdakin
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Geoff Garen.

Test for <rdar://problem/5286443>, ​http://bugs.webkit.org/
show_bug.cgi?id=14268 REGRESSION: Radio buttons don't stay selected
due to unclosed <label> tags

  • fast/forms/radio-nested-labels-expected.checksum: Added.
  • fast/forms/radio-nested-labels-expected.png: Added.
  • fast/forms/radio-nested-labels-expected.txt: Added.
  • fast/forms/radio-nested-labels.html: Added.

WebCore:

Reviewed by Geoff Garen.

Fx for <rdar://problem/5286443>, ​http://bugs.webkit.org/
show_bug.cgi?id=14268 REGRESSION: Radio buttons don't stay selected
due to unclosed <label> tags

This patch maintains the behavior that allows <label> tags to nest.
This matches WinIE, and appears to match the spec, since the spec
does not explicitly say that they cannot nest. It fixes the bug
instead by calling setDefaultHandled() in two places it should have
been called anyway. This keeps the appropriate button checked as
the event bubbles.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::postDispatchEventHandler):
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::defaultEventHandler):
9:15 PM Changeset in webkit [24952] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Oliver.


<rdar://problem/5387578> Crash at ReplaceSelectionCommand::doApply() when pasting just after table cell content

  • editing/pasteboard/5387578-expected.checksum: Added.
  • editing/pasteboard/5387578-expected.png: Added.
  • editing/pasteboard/5387578-expected.txt: Added.
  • editing/pasteboard/5387578.html: Added.

WebCore:

Reviewed by Oliver.

<rdar://problem/5387578> Crash at ReplaceSelectionCommand::doApply() when pasting just after table cell content


ReplaceSelectionCommand::doApply() inserts a line break before insertion
to prevent block nesting. InsertLineBreakCommand::doApply was accidently
destroying a text node when it removed insignificant whitespace and then
setting a nil endingSelection().

  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): If insignificant whitespace removal removes textNode from the document, insert a text node containing the non-breaking space we were attempting to insert and then insert it at the position that the removed textNode occupied.
8:59 PM Changeset in webkit [24951] by ggaren
  • 6 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

Added a thrash check to live decoded resource eviction.


Here's the strategy: Stamp every image with its paint time. Don't evict
a live decoded resource until another resource paints with a reasonably
(1 second) larger time stamp.


If no other resource paints, or another resource paints, but very soon
after the resource in question, the resource in question is very likely
to paint again soon. In fact, it's probably still on screen. So we
leave it alone. (Previously, we evicted it on a timer, but that would
evict a resource that was still on screen, hurting speed without
helping memory use.)

In theory, this algorithm allows a single large resource or closely
related set of resources to linger in the live decoded cache even
though the cache is over its limit. However, that can only happen as
long as no other resource ever paints again, which guarantees an
absolute cap on cache memory usage from then on. Also, the resources
will only linger as long as they remain live. Upon going dead, they
will flush. Also, these circumstances are so rare that they are almost
impossible to encounter in the wild. So don't sweat it.


Stop evicting if the next resource painted too recently:


  • loader/Cache.cpp: (WebCore::Cache::pruneLiveResources):
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::liveResourceAccessed):
  • loader/CachedResource.h:

Track the paint time stamp in Frame. We do this to give a consistent
stamp to all resources painted in a single paint operation (in case the
operation takes a significant amount of time), and to avoid excessive
calls to system time functions, which hurt the PLT:

  • page/Frame.cpp: (WebCore::Frame::paint):
  • page/Frame.h: (WebCore::Frame::currentPaintTimeStamp):
8:16 PM Changeset in webkit [24950] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

Update project file to reflect the moving of character-sets.txt
and make-charset-table.pl to platform/mac a while ago.

  • WebCore.xcodeproj/project.pbxproj:
6:56 PM Changeset in webkit [24949] by kdecker
  • 1 edit in trunk/WebKit/ChangeLog

Tweaked ChangeLog entry

6:53 PM Changeset in webkit [24948] by justing
  • 7 edits
    4 adds in trunk

LayoutTests:

Reviewed by Harrison.


<rdar://problem/5390681> WebKit asserts when deleting To Do content selected with a double-click

  • editing/deleting/5390681-2-expected.checksum: Added.
  • editing/deleting/5390681-2-expected.png: Added.
  • editing/deleting/5390681-2-expected.txt: Added.
  • editing/deleting/5390681-2.html: Added.


Added a FIXME about an extraneous newline:

  • editing/deleting/5390681-expected.checksum:
  • editing/deleting/5390681-expected.png:
  • editing/deleting/5390681-expected.txt:
  • editing/deleting/5390681.html:ada

WebCore:

Reviewed by Harrison.

<rdar://problem/5390681> WebKit asserts when deleting To Do content selected with a double-click


  • dom/Position.cpp: (WebCore::Position::trailingWhitespacePosition): Use VisiblePosition::characterAfter to look for a trailing space. The old code would incorrectly return a position before a non-editable space if it had a collapsed space before it.
6:49 PM Changeset in webkit [24947] by kdecker
  • 21 edits in trunk/WebKit

Reviewed by Anders Carlsson.

Fixed: <rdar://problem/5394449> Stop using some Carbon UI APIs for 64 bit


#ifdef'd out Netscape style plug-ins on 64-bit because Mac OS X doesn't support for 64-bit Carbon.


  • Plugins/WebBaseNetscapePluginStream.h:
  • Plugins/WebBaseNetscapePluginStream.mm:
  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (+[WebBaseNetscapePluginView getCarbonEvent:]): (TSMEventHandler):
  • Plugins/WebBaseNetscapePluginViewInternal.h:
  • Plugins/WebBaseNetscapePluginViewPrivate.h:
  • Plugins/WebBasePluginPackage.m: (+[WebBasePluginPackage pluginWithPath:]):
  • Plugins/WebNetscapePluginEmbeddedView.h:
  • Plugins/WebNetscapePluginEmbeddedView.mm:
  • Plugins/WebNetscapePluginPackage.h:
  • Plugins/WebNetscapePluginPackage.m:
  • Plugins/WebNetscapePluginStream.h:
  • Plugins/WebNetscapePluginStream.mm:
  • Plugins/WebPluginDatabase.m: (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
  • Plugins/npapi.m:
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
  • WebView/WebFrame.mm:
  • WebView/WebFramePrivate.h:
  • WebView/WebHTMLView.mm: (-[NSArray _web_makePluginViewsPerformSelector:withObject:]):
  • WebView/WebHTMLViewInternal.h:
5:56 PM Changeset in webkit [24946] by weinig
  • 9 edits
    7 adds in trunk

LayoutTests:

Reviewed by Brady.

Test that protocol and host compares are case-insensitive.

  • http/tests/security/cross-frame-access-port-expected.txt:
  • http/tests/security/cross-frame-access-protocol-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt: Added.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase.html: Added.
  • http/tests/security/host-compare-case-insensitive-expected.txt: Added.
  • http/tests/security/host-compare-case-insensitive.html: Added.
  • http/tests/security/protocol-compare-case-insensitive-expected.txt: Added.
  • http/tests/security/protocol-compare-case-insensitive.html: Added.
  • http/tests/security/resources/cross-frame-iframe.html:
  • http/tests/security/resources/localhost-accesssor.html: Added.

WebCore:

Reviewed by Brady.

Make protocol and host compares case-insensitive.

  • bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript):
  • dom/Document.cpp: (WebCore::Document::initSecurityPolicyURL):
  • platform/DeprecatedString.cpp: (WebCore::equalIgnoringCase):
  • platform/DeprecatedString.h: (WebCore::equalIgnoringCase):
4:42 PM Changeset in webkit [24945] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Harrison.


<rdar://problem/5390681> WebKit asserts when deleting To Do content selected with a double-click

  • editing/deleting/5390681-expected.checksum: Added.
  • editing/deleting/5390681-expected.png: Added.
  • editing/deleting/5390681-expected.txt: Added.
  • editing/deleting/5390681.html: Added.

WebCore:

Reviewed by Harrison.

<rdar://problem/5390681> WebKit asserts when deleting To Do content selected with a double-click

  • dom/Position.cpp: (WebCore::Position::leadingWhitespacePosition): Added checks to prevent expansion across editable an boundary. (WebCore::Position::trailingWhitespacePosition): Ditto.
4:00 PM Changeset in webkit [24944] by bdash
  • 4 edits in trunk

Versioning.

3:55 PM Changeset in webkit [24943] by bdash
  • 1 copy in tags/Safari-5523

New tag.

3:11 PM Changeset in webkit [24942] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by John.

Test for for <rdar://problem/5393798> 100% reproducible crash in WebCore::Scrollbar::setValue

  • fast/events/mousedown_in_scrollbar-expected.txt: Added.
  • fast/events/mousedown_in_scrollbar.html: Added.

WebCore:

Reviewed by John.

Fix for <rdar://problem/5393798> 100% reproducible crash in WebCore::Scrollbar::setValue

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): If the hit testing originally determined the event was in a scrollbar, refetch the MouseEventWithHitTestResults in case the scrollbar widget was destroyed when the mouse event was handled.
3:01 PM Changeset in webkit [24941] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-08-08 yadavall <sriram.yadavalli>

Reviewed by Sachin (​sachin.padma@nokia.com).
DESC: CRAS-757S3Q:Center key press event not being sent to webcore
​http://bugs.webkit.org/show_bug.cgi?id=14593

  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleOfferKeyEventL):
2:51 PM Changeset in webkit [24940] by spadma
  • 3 edits in S60/branches/3.1m/WebKit

2007-08-06 vmalaiya, <​vikram.malaiya@nokia.com>

Reviewed by Sachin
DESC: VMAA-75EP3L - Browser plugin does not implement memory collection on an out-of-memory condition
​http://bugs.webkit.org/show_bug.cgi?id=14753


  • Plugin/inc/PluginSkin.h: (CPluginSkin::Frame):
  • Plugin/src/PluginSkin.cpp: (COOMPluginCollector::COOMPluginCollector): (COOMPluginCollector::~COOMPluginCollector): (COOMPluginCollector::Collect): (COOMPluginCollector::Restore): (COOMPluginCollector::Priority): (COOMPluginCollector::IsCollecting): (CPluginSkin::ConstructL): (CPluginSkin::~CPluginSkin): (CPluginSkin::RemovePluginWin):
2:49 PM Changeset in webkit [24939] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-08-08 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by NOBODY (​sachin.padma@nokia.com).
DESC: SWIP-75QJJN - BrCtl ContentSize returning SizeHint and not ContentSize
​http://bugs.webkit.org/show_bug.cgi?id=14871

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::ContentSize):
1:46 PM Changeset in webkit [24938] by weinig
  • 4 edits
    35 adds in trunk

LayoutTests:

Reviewed by Geoff Garen.

Tests for <rdar://problem/5354635>

  • http/tests/security/dataURL: Added.
  • http/tests/security/dataURL/resources: Added.
  • http/tests/security/dataURL/resources/foreign-domain-data-url-accessee-iframe.html: Added.
  • http/tests/security/dataURL/resources/foreign-domain-data-url-accessee-opened-frame.html: Added.
  • http/tests/security/dataURL/resources/foreign-domain-data-url-accessor-iframe.html: Added.
  • http/tests/security/dataURL/resources/foreign-domain-data-url-accessor-opened-frame.html: Added.
  • http/tests/security/dataURL/resources/foreign-domain-data-url-window-location.html: Added.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-subframe-expected.txt: Added.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-subframe.html: Added.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-window-open-expected.txt: Added.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-window-open.html: Added.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt: Added.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level.html: Added.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt: Added.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt: Added.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame.html: Added.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame.html: Added.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt: Added.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url.html: Added.
  • http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt: Added.
  • http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open.html: Added.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt: Added.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url.html: Added.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe-expected.txt: Added.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe-location-change-expected.txt: Added.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe-location-change.html: Added.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe.html: Added.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-window-open-expected.txt: Added.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-window-open.html: Added.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt: Added.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level.html: Added.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt: Added.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame.html: Added.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt: Added.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-window-open.html: Added.

WebCore:

Reviewed by Geoff Garen.

Fix for <rdar://problem/5354635>

Match Firefox's model for data: URLs by not allowing them script access
to any frames other then itself.

  • bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript):
  • dom/Document.cpp: (WebCore::Document::initSecurityPolicyURL):
12:19 PM Changeset in webkit [24937] by darin
  • 2 edits in trunk/WebCore

Reviewed by Kevin Decker.

  • fix for <rdar://problem/5390708> CrashTracer: [USER] 27 crashes in Safari at com.apple.WebCore: WTF::HashMap<etc>::set + 68, beneath pruneUnretainedIconsAtStartup
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Eliminate an unnecessary HashMap from the implementation; we can just use the m_pageURLToRetainCount map directly. This simplifies the code and allows us to handle the empty string, which otherwise poses a problem for HashMap.
10:37 AM Changeset in webkit [24936] by antti
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.


Test for <rdar://problem/5391576>
Malformed table innerHTML causes Safari to crash in HTMLParser::handleError (14894)

  • fast/table/incomplete-table-in-fragment-2-expected.txt: Added.
  • fast/table/incomplete-table-in-fragment-2.html: Added.

WebCore:

Reviewed by Darin.


Fix for <rdar://problem/5391576>
Malformed table innerHTML causes Safari to crash in HTMLParser::handleError (14894)


Add null checks to protect against


e.innerHTML = "<tr>text</tr>";


type cases. Normal assumptions about document tree structure don't hold when parsing
fragments. Results don't match Firefox in all cases. It seems to have some sort of
anything-goes fragment parsing mode.


  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
10:14 AM Changeset in webkit [24935] by kmccullo
  • 9 edits
    6 adds in trunk

LayoutTests:

Reviewed by Maciej and Hyatt.

  • <rdar://problem/4976879> REGRESSION: Safari doesn't work with Zimbra enhanced login.
    • Reverting a previous change, and modifying how documents are created so that we better match other browsers behavior with respect to namespaceURIs.
  • dom/xhtml/level1/core/hc_documentcreateelementcasesensitive-expected.txt:
  • fast/dom/Document/replace-child-expected.txt:
  • http/tests/misc/createElementNamespace1-expected.txt: Added.
  • http/tests/misc/createElementNamespace1.xml: Added.
  • http/tests/misc/createElementNamespace2-expected.txt: Added.
  • http/tests/misc/createElementNamespace2.xhtml: Added.
  • http/tests/misc/createElementNamespace3-expected.txt: Added.
  • http/tests/misc/createElementNamespace3.html: Added.

WebCore:

Reviewed by Maciej and Hyatt.

  • <rdar://problem/4976879> REGRESSION: Safari doesn't work with Zimbra enhanced login.
  • Reverting a previous change, and modifying how documents are created so that we better match other browsers behavior with respect to namespaceURIs.
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::createElement):
  • dom/Document.h:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::createElement):
  • html/HTMLDocument.h:
9:37 AM Changeset in webkit [24934] by beidson
  • 4 edits in trunk

LayoutTests:

Reviewed and landed by Brady

Updated test case because of fix for <​http://bugs.webkit.org/show_bug.cgi?id=13422>

Bug 13422: REGRESSION: Page reload loses page position

  • http/tests/navigation/success200-reload-expected.txt:

WebCore:

Reviewed and landed by Brady

Fixes <​http://bugs.webkit.org/show_bug.cgi?id=13422>

Bug 13422: REGRESSION: Page reload loses page position

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::updateHistoryForReload):
9:24 AM Changeset in webkit [24933] by staikos
  • 2 edits in trunk/JavaScriptCore

Make it compile with Qt4 unicode

9:20 AM Changeset in webkit [24932] by rwlbuis
  • 21 edits
    8 adds in branches/feature-branch

Reviewed by Nikolas.

​http://bugs.webkit.org/show_bug.cgi?id=11909
Regression: large SVG from Illustrator comes out blank

Fix last issue with the Illustrator file by making relativeBBox
calculation take into account viewBox.

9:17 AM Changeset in webkit [24931] by zecke
  • 3 edits in trunk/WebKit

2007-08-08 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Niko.

We only need to set the Settings of the Page once so do it in
WebKitGtkPage instead of WebKitGtkFrame.

  • gtk/Api/webkitgtkframe.cpp:
  • gtk/Api/webkitgtkpage.cpp:
8:57 AM Changeset in webkit [24930] by zecke
  • 2 edits in trunk/WebCore

2007-08-08 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Niko.

Be paranoid and disconnect from the signal before going away.

  • platform/gdk/PlatformScrollBarGdk.cpp: (PlatformScrollbar::~PlatformScrollbar):
8:18 AM Changeset in webkit [24929] by zecke
  • 3 edits in trunk/WebKit

2007-08-08 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Niko.

Instead of reimplementing the general event method, reimplement
the specific mouse, expose, keyboard event methods.

Call the finalize implementation of the base class from WebKitGtkPage
and WebKitGtkFrame.

  • gtk/Api/webkitgtkframe.cpp:
  • gtk/Api/webkitgtkpage.cpp:
3:44 AM Changeset in webkit [24928] by zecke
  • 2 edits in trunk/WebCore

2007-08-08 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Niko.

Use GraphicsContext::translatePoint in RenderThemeGdk to paint at the
right position.
This is needed as the Gtk+ theming code does not know about the translation
of the GraphicsContext.

  • platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::paintCheckbox): (WebCore::RenderThemeGdk::paintRadio): (WebCore::RenderThemeGdk::paintButton):
3:28 AM Changeset in webkit [24927] by zecke
  • 6 edits in trunk

WebCore:
2007-08-08 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Niko.

Implement Widget::paint for the Gtk port. This is needed to paint
Widgets in z-order. The original GdkEventExpose is stored within the
GraphicsContext and then used to draw the children. This is similiar
to gtk_container_propagate_expose but we try to honor the GraphicsConntext
translation.

  • platform/gdk/WidgetGdk.cpp: (WebCore::Widget::paint):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::setGdkExposeEvent): (WebCore::GraphicsContext::gdkExposeEvent): (WebCore::GraphicsContext::gdkDrawable): (WebCore::GraphicsContext::translatePoint):

WebKit:
2007-08-08 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Niko.

Remove the custom painting in favor of the Widget::paint
implementation.

  • gtk/Api/webkitgtkpage.cpp:
1:02 AM Changeset in webkit [24926] by zecke
  • 3 edits in trunk/WebCore

2007-08-08 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Oliver Hunt.

Implement PlatformScrollbar by calling ScrollBar::setValue from
gtkValueChange connected to the value-changed signal of the
GtkAdjustment.
Update 'value' of the GtkAdjustment in updateThumbPosition and
set upper, page-increment, step-increment and page_size in
updateThumbProportion.

This is from bug ​http://bugs.webkit.org/show_bug.cgi?id=14795.

  • platform/gdk/PlatformScrollBar.h:
  • platform/gdk/PlatformScrollBarGdk.cpp: (PlatformScrollbar::PlatformScrollbar): (PlatformScrollbar::updateThumbPosition): (PlatformScrollbar::updateThumbProportion): (PlatformScrollbar::gtkValueChanged):
12:01 AM Changeset in webkit [24925] by ggaren
  • 10 edits in trunk/WebCore

Reviewed by Maciej Stachowiak. Based on earlier review from Dave Hyatt.

First chunk of work for <rdar://problem/5326009> Make non-browser
WebKit clients have no memory cache, or a very tiny one


Layout tests pass.


Removed decodedSizeWillChange mechanism because my last patch to
change the live resources list to a strict LRU model made that code
vestigial.


Renamed "liveResourcesList" and related stuff =>
"liveDecodedResourcesList" because only live resources with decoded
data are kept in the list.

  • loader/CachedImage.cpp: (WebCore::CachedImage::decodedSizeChanged): Only add ourselves to the list if we're live, our decoded size has grown, and we're not in the list already. (Otherwise, either we're not live, we're not decoded, or we're already in the list.)
  • loader/CachedResource.cpp: (WebCore::CachedResource::liveResourceAccessed): Only re-insert ourselves into the list if we're already there. (In theory, this should be always, but it's a little more clear to check.)

Aug 7, 2007:

10:43 PM Changeset in webkit [24924] by weinig
  • 3 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Oliver.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=14897
Decompilation of double negation fails and produces invalid or incorrect code

Test: fast/js/function-decompilation-operators.html

  • kjs/nodes2string.cpp: (UnaryPlusNode::streamTo): Put space after unary operator. Matches Firefox. (NegateNode::streamTo): Diito. (MultNode::streamTo): Put spaces around binary operator. Matches Firefox. (AddNode::streamTo): Ditto.

LayoutTests:

Reviewed by Oliver.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=14897
Decompilation of double negation fails and produces invalid or incorrect code

  • fast/js/function-decompilation-operators-expected.txt: Added.
  • fast/js/function-decompilation-operators.html: Added.
7:06 PM Changeset in webkit [24923] by zecke
  • 9 edits
    1 move
    1 delete in trunk

WebCore:
2007-08-08 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Adam.

Kill class FrameGdk and move the stubs to page/gdk/FrameGdk.cpp and the
remainings into WebKitGtkFrame.
The DRT functionality of class FrameGdk is currently lost.

  • WebCore.pro:
  • loader/gdk/FrameLoaderClientGdk.cpp:
  • loader/gdk/FrameLoaderClientGdk.h:
  • page/gdk/FrameGdk.cpp: Renamed from WebCore/platform/gdk/FrameGdk.cpp. (WebCore::Frame::issueTransposeCommand): (WebCore::Frame::cleanupPlatformScriptObjects): (WebCore::Frame::dragImageForSelection): (WebCore::Frame::dashboardRegionsChanged):
  • platform/gdk/FrameGdk.h: Removed.
  • platform/gdk/TemporaryLinkStubs.cpp: Removed Frame stub, added the loadResourceIntoArray stub
  • platform/gdk/WidgetGdk.cpp:

WebKit:
2007-08-08 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Adam.

Moved code from class FrameGdk into WebKitGtkFrame. Update the
webkitgrkprivate.h header file to not include FrameGdk.h.

  • gtk/Api/webkitgtkframe.cpp:
  • gtk/Api/webkitgtkprivate.h:
6:40 PM Changeset in webkit [24922] by ddkilzer
  • 2 edits
    1 move in trunk/LayoutTests

LayoutTests:

Reviewed by Oliver.

Move plain-text-document.txt to the resources subdirectory.

  • fast/loader/plain-text-document.html: Updated URL to plain-text-document.txt.
  • fast/loader/plain-text-document.txt: Removed.
  • fast/loader/resources/plain-text-document.txt: Copied from fast/loader/plain-text-document.txt.
5:59 PM Changeset in webkit [24921] by weinig
  • 17 edits
    19 adds in trunk/LayoutTests

Reviewed by Geoff Garen.

Make tests not depend on data: URLs in preparation of
data: URL policy change.

  • editing/pasteboard/drag-image-to-contenteditable-in-iframe.html:
  • editing/pasteboard/resources: Added.
  • editing/pasteboard/resources/drag-image-to-contenteditable-iframe.html: Added.
  • fast/dom/HTMLDocument/frameless-location-bugzilla10837.html:
  • fast/dom/HTMLDocument/resources: Added.
  • fast/dom/HTMLDocument/resources/frameless-location-bugzilla10837-iframe.html: Added.
  • fast/dom/exception-no-frame-inline-script-crash.html:
  • fast/dom/exception-no-frame-timeout-crash.html:
  • fast/dom/null-document-location-assign-crash.html:
  • fast/dom/null-document-location-href-put-crash.html:
  • fast/dom/null-document-location-put-crash.html:
  • fast/dom/null-document-location-replace-crash.html:
  • fast/dom/null-document-window-open-crash.html:
  • fast/dom/resources/exception-no-frame-inline-script-crash-iframe.html: Added.
  • fast/dom/resources/exception-no-frame-timeout-crash-iframe.html: Added.
  • fast/events/frame-programmatic-focus.html:
  • fast/events/iframe-object-onload.html:
  • fast/events/mouseover-mouseout.html:
  • fast/events/mouseover-mouseout2.html:
  • fast/events/resources/iframe-object-onload-iframe-1.html: Added.
  • fast/events/resources/iframe-object-onload-iframe-2.html: Added.
  • fast/events/resources/iframe-object-onload-iframe-3.html: Added.
  • fast/events/resources/iframe-object-onload-object-1.html: Added.
  • fast/events/resources/iframe-object-onload-object-2.html: Added.
  • fast/events/resources/iframe-object-onload-object-3.html: Added.
  • fast/events/resources/mouseover-mouseout-iframe.html: Added.
  • fast/events/resources/mouseover-mouseout2-iframe-1.html: Added.
  • fast/events/resources/mouseover-mouseout2-iframe-2.html: Added.
  • fast/events/resources/mouseover-mouseout2-iframe-3.html: Added.
  • fast/events/resources/mouseover-mouseout2-iframe-4.html: Added.
  • fast/events/resources/mouseover-mouseout2-iframe-5.html: Added.
  • fast/loader/opaque-base-url-expected.txt:
  • fast/loader/opaque-base-url.html:
  • plugins/plugin-remove-subframe.html:
  • plugins/resources/plugin-remove-subframe-iframe.html: Added.
5:54 PM Changeset in webkit [24920] by zecke
  • 4 edits in trunk/WebKit

2007-08-08 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Adam.

Change variable names to follow the Coding-Style. Replace occurences
of a_b with aB and place the '*' correctly.

  • gtk/Api/webkitgtkframe.cpp:
  • gtk/Api/webkitgtkpage.cpp:
  • gtk/Api/webkitgtkprivate.h:
5:45 PM Changeset in webkit [24919] by darin
  • 6 edits in trunk/JavaScriptCore

Reviewed by Adele.

  • fix <rdar://problem/5383104> REGRESSION: XHR.responseText is null instead of empty string in http/tests/xmlhttprequest/zero-length-response.html

The new code to handle out of memory conditions was turning a "" into a null string.

  • kjs/ustring.h: Removed UCharReference, which has long been obsolete and unused. Removed copyForWriting, which was only used for the upper/lowercasing code and for UCharReference.
  • kjs/ustring.cpp: (KJS::allocChars): Removed special case that made this fail (return 0) when passed 0. Instead assert that we're not passed 0. Also added an overflow check for two reasons: 1) for sizes that aren't checked this prevents us from allocating a buffer that's too small, and 2) for sizes where we overflowed in the expandedSize function and returned overflowIndicator, it guarantees we fail. (KJS::reallocChars): Ditto. (KJS::UString::expandedSize): Return a large number, overflowIndicator, rather than 0 for cases where we overflow. (KJS::UString::spliceSubstringsWithSeparators): Added a special case for empty string so we don't call allocChars with a length of 0. (KJS::UString::operator=): Added special characters for both 0 and empty string so we match the behavior of the constructor. This avoids calling allocChars with a length of 0 and making a null string rather than an empty string in that case, and also matches the pattern used in the rest of the functions. (KJS::UString::operator[]): Made the return value const so code that tries to use the operator to modify the string will fail.
  • kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction): Rewrote uppercasing and lowercasing functions so they don't need copyForWriting any more -- it wasn't really doing any good for optimization purposes. Instead use a Vector and releaseBuffer.
  • wtf/unicode/icu/UnicodeIcu.h: Eliminate one of the versions of toLower/toUpper -- we now only need the version where both a source and destination buffer is passed in, not the one that works in place.
  • wtf/unicode/qt4/UnicodeQt4.h: Ditto.
5:27 PM Changeset in webkit [24918] by zimmermann
  • 128 edits in branches/feature-branch

Reviewed by Oliver.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=14896 (SVG InlineText/Flow box sizes don't take rotated glyphs into account)

Introduce new helper function calculateGlyphBoundaries, which takes into account any per-character transformation.
This fixes box size calculations in svg/W3C-SVG-1.1/text-text-07-t.svg, svg/batik/text/textEffect3.svg (rotated glyphs)
-> These strings can be properly selected now, just as well as text path elements.

5:17 PM Changeset in webkit [24917] by zecke
  • 5 edits in trunk

WebCore:
2007-08-08 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Adam.

Remove the event handling code and move it to WebKit/gtk/Api/webkitgtkpage.cpp

  • platform/gdk/FrameGdk.cpp:
  • platform/gdk/FrameGdk.h:

WebKit:
2007-08-08 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Adam.

Reimplement GtkWidget::event and handle the keyboard and mouse
events inside WebKitGtkPage.

  • gtk/Api/webkitgtkpage.cpp: (FrameGdkExposeData::frame_gdk_expose_child): (FrameGdkExposeData::webkit_gtk_page_rendering_area_handle_gdk_event): (FrameGdkExposeData::webkit_gtk_page_register_rendering_area_events): (FrameGdkExposeData::webkit_gtk_page_class_init):
4:09 PM Changeset in webkit [24916] by zimmermann
  • 95 edits in branches/feature-branch

Reviewed by Oliver.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=13909 (SVG text selection doesn't work with RTL text)

Use drawHighlightForText() to draw the selection, instead of my home-brewn solution.
Affected code in SVGRootInlineBox::paintSelectionForTextBox. Removed not anymore needed
helper function cummulatedWidthOfSelectionRange.

Dump all contained InlineTextBox(es) in SVGRenderTreeAsText, take into account multiple
child text boxes in ie. a RenderSVGInlineText objects (which happens for RTL text and
LTR text cases where newlines were involved - see changed testcase results.)
This affects a lot of LTR tests which actually had more than one child text box, that
wasn't taken properly into account before (in terms of selection, not rendering.)

Fix selection for RTL text by taking box start offsets into account in closestCharacterToPosition()
and by offering RTL text selection special cases in svgCharacterHitsPosition().

Centralized the creation of a TextStyle object for text selection/painting in a new helper function
svgTextStyleForInlineTextBox. Add new helper functions calculateGlyphWidth/calculateGlyphHeight to
centralize these calculations -> use these new helpers everywhere to avoid code duplication.

A single fix in bidi.cpp was needed to fix SVG's unicode-bidi/direction handling, to fix text-intro-02-b.svg.
SVG didacts that the 'direction' attribute is ignored if unicode-bidi is set to 'normal' (default).
Discussed with Mitz.

4:06 PM Changeset in webkit [24915] by hyatt
  • 3 edits in trunk/WebKit

Fix a botched backout of the Quicktime plugin clipping fix that broke Java. The plugin view should not
be set to autosize with the parent view. Also, cleanup of script objects was removed accidentally as
well.

Reviewed by olliej

  • Plugins/WebPluginController.mm: (-[WebPluginController destroyPlugin:]): (-[WebPluginController destroyAllPlugins]):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:DOMElement:loadManually:]):
3:04 PM Changeset in webkit [24914] by zecke
  • 8 edits in trunk/WebCore

2007-08-07 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Niko.

Switch from the generic union GdkEvent to the specific struct GdkEvent*. This is needed
to make WebKitGtkPage handle the events by reimplementing the default handlers in the near
future.

  • platform/PlatformKeyboardEvent.h:
  • platform/PlatformMouseEvent.h:
  • platform/PlatformWheelEvent.h:
  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::handleGdkEvent):
  • platform/gdk/KeyEventGdk.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
  • platform/gdk/MouseEventGdk.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
  • platform/gdk/WheelEventGdk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2:39 PM Changeset in webkit [24913] by antti
  • 1 edit
    2 deletes in trunk/LayoutTests

Remove a test that was a bit too slow on older hardware.


  • fast/block/basic/stress-shallow-nested-expected.txt: Removed.
  • fast/block/basic/stress-shallow-nested.html: Removed.
11:19 AM Changeset in webkit [24912] by alp
  • 1 edit in trunk/WebKit/gtk/Api/webkitgtkpage.cpp

Supplemental whitespace fix

11:11 AM Changeset in webkit [24911] by alp
  • 3 edits in trunk/WebKit

2007-08-07 Xan Lopez <​xan@gnome.org>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=14815
[gtk] API implementation: reload

  • gtk/Api/webkitgtkpage.cpp: Implement the webkit_gtk_page_reload() function.
10:17 AM Changeset in webkit [24910] by staikos
  • 2 edits in trunk/WebCore

Some QStyles don't handle negative maximum very well

7:29 AM Changeset in webkit [24909] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

w3liu, reviewed by <​zbujtas@gmail.com>

DESC: [S60] SLON-75MAFV: <<OTC>> OTC - BTT - 6.800.5620 WCSS TABLE ROW HEIGHT
​http://bugs.webkit.org/show_bug.cgi?id=14872

7:26 AM Changeset in webkit [24908] by zbujtas
  • 2 edits in S60/trunk/WebCore

w3liu, reviewed by <​zbujtas@gmail.com>

DESC: [S60] SLON-75MAFV: <<OTC>> OTC - BTT - 6.800.5620 WCSS TABLE ROW HEIGHT
​http://bugs.webkit.org/show_bug.cgi?id=14872

4:15 AM Changeset in webkit [24907] by antti
  • 9 edits
    6 adds in trunk

LayoutTests:

Reviewed by Hyatt.


Tests for <rdar://problem/5102553>
Mail spins trying to display or edit a specific long plain text message in WebCore::TimerBase::...


  • added performance test. With debug build on MBP this takes about 1.5s to run.
  • added test case that shows some additional progression from the patch (less leftover anonymous boxes).


  • fast/block/basic/stress-shallow-nested-expected.txt: Added.
  • fast/block/basic/stress-shallow-nested.html: Added.
  • fast/block/float/nestedAnonymousBlocks2-expected.checksum: Added.
  • fast/block/float/nestedAnonymousBlocks2-expected.png: Added.
  • fast/block/float/nestedAnonymousBlocks2-expected.txt: Added.
  • fast/block/float/nestedAnonymousBlocks2.html: Added.

WebCore:

Reviewed by Hyatt.

Fix <rdar://problem/5102553>
Mail spins trying to display or edit a specific long plain text message in WebCore::TimerBase::...

Calling removeLeftoverAnonymousBoxes() from RenderBlock::addChildToFlow() made adding children
O(n2) in simple cases (repeated <div><div></div></div> for example).


I couldn't find any limited fix so here is a more complete one. It removes iterating/recursing
removeLeftoverAnonymousBoxes() method altogether. Instead of hunting around wildly, just get
rid of anonymous boxes with block children when they occur.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::addChildToFlow):
  • rendering/RenderButton.h: (WebCore::RenderButton::removeLeftoverAnonymousBlock):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeLeftoverAnonymousBlock):
  • rendering/RenderContainer.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::handleDynamicFloatPositionChange): (WebCore::RenderObject::removeLeftoverAnonymousBlock):
  • rendering/RenderObject.h:
  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::removeLeftoverAnonymousBlock):
12:50 AM Changeset in webkit [24906] by rwlbuis
  • 2 edits in branches/feature-branch/WebCore

Reviewed by Oliver.

Do not export some symbols for internal functions, saves some bytes.

Note: See TracTimeline for information about the timeline view.