Context Navigation

http/tests/security/cross-frame-access-location-expected.txt: This test's results changed, there are more debug messages due to access being legitimately denied.

The remainder are new tests and support:

http/tests/security/resources/xss-DENIED-assign-location-hash-attacker.html: Added.
http/tests/security/resources/xss-DENIED-assign-location-host-attacker.html: Added.
http/tests/security/resources/xss-DENIED-assign-location-host-failure.html: Added.
http/tests/security/resources/xss-DENIED-assign-location-hostname-attacker.html: Added.
http/tests/security/resources/xss-DENIED-assign-location-hostname-failure.html: Added.
http/tests/security/resources/xss-DENIED-assign-location-nonstandardProperty-attacker.html: Added.
http/tests/security/resources/xss-DENIED-assign-location-pathname-attacker.html: Added.
http/tests/security/resources/xss-DENIED-assign-location-pathname-failure.html: Added.
http/tests/security/resources/xss-DENIED-assign-location-protocol-attacker.html: Added.
http/tests/security/resources/xss-DENIED-assign-location-protocol-failure.html: Added.
http/tests/security/resources/xss-DENIED-assign-location-reload-attacker.html: Added.
http/tests/security/resources/xss-DENIED-assign-location-search-attacker.html: Added.
http/tests/security/xss-DENIED-assign-location-hash-expected.txt: Added.
http/tests/security/xss-DENIED-assign-location-hash.html: Added.
http/tests/security/xss-DENIED-assign-location-host-expected.txt: Added.
http/tests/security/xss-DENIED-assign-location-host.html: Added.
http/tests/security/xss-DENIED-assign-location-hostname-expected.txt: Added.
http/tests/security/xss-DENIED-assign-location-hostname.html: Added.
http/tests/security/xss-DENIED-assign-location-nonstandardProperty-expected.txt: Added.
http/tests/security/xss-DENIED-assign-location-nonstandardProperty.html: Added.
http/tests/security/xss-DENIED-assign-location-pathname-expected.txt: Added.
http/tests/security/xss-DENIED-assign-location-pathname.html: Added.
http/tests/security/xss-DENIED-assign-location-protocol-expected.txt: Added.
http/tests/security/xss-DENIED-assign-location-protocol.html: Added.
http/tests/security/xss-DENIED-assign-location-reload-expected.txt: Added.
http/tests/security/xss-DENIED-assign-location-reload.html: Added.
http/tests/security/xss-DENIED-assign-location-search-expected.txt: Added.
http/tests/security/xss-DENIED-assign-location-search.html: Added.

WebCore:

Reviewed by Darin and Sam.

<rdar://problem/5395213> cross-domain access to individual components of location object should be denied.

bindings/js/kjs_window.cpp: (KJS::Location::put): Add the appropriate cross-domain access checks.

8:06 PM Changeset in webkit [25027] by darin

4 edits in trunk/WebCore

Reviewed by John Sullivan.

fix <rdar://problem/5403724> REGRESSION: text inputs are not scrolled to make inline input visible (14912)

editing/Editor.h: Made setIgnoreMarkedTextSelectionChange no longer inline. It now has a side effect of revealing the selection when you set it to false. Added private revealSelectionAfterEditingOperation helper.
editing/Editor.cpp: (WebCore::Editor::deleteRange): Calls revealSelectionAfterEditingOperation instead of calling m_frame->revealSelection directly. (WebCore::Editor::replaceSelectionWithFragment): Ditto. (WebCore::Editor::insertOrderedList): Ditto. (WebCore::Editor::insertUnorderedList): Ditto. (WebCore::Editor::increaseSelectionListLevel): Ditto. (WebCore::Editor::increaseSelectionListLevelOrdered): Ditto. (WebCore::Editor::increaseSelectionListLevelUnordered): Ditto. (WebCore::Editor::decreaseSelectionListLevel): Ditto. (WebCore::Editor::insertLineBreak): Ditto. (WebCore::Editor::insertParagraphSeparator): Ditto. (WebCore::Editor::replaceMarkedText): Ditto. (WebCore::Editor::revealSelectionAfterEditingOperation): Added. Calls revealSelection, unless we are in the ignoreMarkedTextSelectionChange state. If we are in that state, we're in the middle of a composite editing operation and we shouldn't try to scroll to reveal the selection until the operation is done. (WebCore::Editor::setIgnoreMarkedTextSelectionChange): Made no longer inline. If changing the state from true to false, then calls revealSelectionAfterEditingOperation.

WebCore.exp: Add new entry point for no-longer-inline setter function.

7:42 PM Changeset in webkit [25026] by darin

11 edits
3 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

fix http://bugs.webkit.org/show_bug.cgi?id=14931 <rdar://problem/5403816> JavaScript regular expression non-participating capturing parentheses fail in 3 different ways

Test: fast/js/regexp-non-capturing-groups.html

kjs/string_object.cpp: (KJS::replace): Add missing code to handle undefined backreferences; before we'd get the empty string instead of a JavaScript "undefined" value. (KJS::StringProtoFunc::callAsFunction): Implemented backreference support for split.
pcre/pcre_exec.c: (match): Made backreferences to undefined groups match the empty string instead of always failing. Only in JAVASCRIPT mode.

tests/mozilla/expected.html: Add a new expected test success, since this fixed one test result.

LayoutTests:

Reviewed by Maciej.

test for http://bugs.webkit.org/show_bug.cgi?id=14931 JavaScript regular expression non-participating capturing groups behave incorrectly in edge cases

fast/js/regexp-non-capturing-groups-expected.txt: Added.
fast/js/regexp-non-capturing-groups.html: Added.
fast/js/resources/regexp-non-capturing-groups.js: Added.

fast/js/resources/js-test-pre.js: Updated to add a special case for array results, since there are some array results in the test. Also cut down on the verbosity of failures when the type of the actual result is the same as the type of the expected result. And get rid of the special case function just for NaN.

fast/js/regexp-unicode-overflow.html: Let the make-js-test-wrappers script regenerate this file (it removed one of the trailing newlines).

fast/js/kde/encode_decode_uri-expected.txt: This test now passes. I'm not sure why it was failing before.

fast/js/char-at-expected.txt: Removed all the periods at the end of NaN test PASS messages; they are now consistent with all the other tests.
fast/js/date-parse-comments-test-expected.txt: Ditto.
fast/js/date-parse-test-expected.txt: Ditto.

7:41 PM Changeset in webkit [25025] by ggaren

8 edits in trunk/WebCore

Reviewed by Maciej Stachowiak, Dave Hyatt.

Changed the dead resource LRU-SP algorithm to measure an object's
total size, not just its encoded size. This will allow us to make
better decisions about what data to evict when the cache is small. For
example, the PLT can now run with a 16MB cache without fully evicting
any resources.

(Previously, we had assumed that decoded size would be an OK estimate
of encoded size, but that is not true of GIF, whose decoded size can be
orders of magnitude greater than its encoded size.)

Subtly, destroying a resource's decoded data now increases its recency
by moving it to the head of a smaller LRU list. This is slightly odd,
but, since all resources get the same treatment, it shouldn't hurt
the eviction algorithm.

history/PageCache.cpp: (WebCore::PageCache::releaseAutoreleasedPagesNow): Make sure that a dead resource eviction doesn't happen until we've released all of our dead pages. Otherwise, the cache will make terrible decisions about what to evict because all of our dead resources will seem live.

loader/Cache.cpp: (WebCore::Cache::Cache): (WebCore::Cache::pruneLiveResources): (WebCore::Cache::pruneDeadResources): Removed call to removeFromLiveDecodedResourcesList because this happens automatically now as a part of the process of changing the resource's decoded size. (WebCore::Cache::lruListFor): * The key change. * Compute the appropriate LRU list based on total size, not encoded size. (WebCore::Cache::dumpLRULists): Added debug logging function to help visualize the cache.

loader/Cache.h: (WebCore::Cache::setDeadResourcePruneEnabled): (WebCore::Cache::deadResourcePruneEnabled):

loader/CachedImage.cpp: Moved decoded size tracking code from here up into the base class. Currently, only CachedImage has a use for that functionality, but other subclasses might need it in the future, and the base class is already responsible for similar code related to encoded size tracking. (WebCore::CachedImage::decodedSizeChanged):
loader/CachedImage.h:

loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::setDecodedSize): Move us in the LRU-SP list just like setEncodedSize does, since decoded size counts now, too. (WebCore::CachedResource::setEncodedSize): Changed slightly to match the style of setDecodedSize.

loader/CachedResource.h: (WebCore::CachedResource::decodedSize):

12:20 PM Changeset in webkit [25024] by ap

2 edits in trunk/WebKit

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=4648
Shockwave unable to load GZip'd text resources when server sends Content-Length header

Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream startStreamWithResponse:]): Don't trust -[NSURLResponse expectedContentLength] if Content-Encoding is not identity.

4:31 AM Changeset in webkit [25023] by aroben

2 edits in trunk/WebKitTools

Generate results for new tests in a more logical location

New platform-specific tests always have their results generated right
next to the test. New cross-platform tests will have their results
generated a) in the cross-platform directory, if they are text-only,
or b) in the least-specific platform directory, if they are render
tree dumps.

Reviewed by Lars.

Scripts/run-webkit-tests:

4:31 AM Changeset in webkit [25022] by aroben

2 edits in trunk/WebKitTools

Print the actual directory where new results are generated.

Before, we were printing an unpredictable, context-specific substring
of the directory.

Reviewed by Lars.

Scripts/run-webkit-tests:

4:31 AM Changeset in webkit [25021] by aroben

2 edits in trunk/WebKitTools

Factor some common code into a stripExtension() subroutine.

Reviewed by Lars.

Scripts/run-webkit-tests: Also removed some debugging output.

3:08 AM Changeset in webkit [25020] by antti

1 edit in trunk/LayoutTests/ChangeLog

Correct wrong URL in ChangeLog entry

3:05 AM Changeset in webkit [25019] by antti

1 edit
2 adds in trunk/LayoutTests

Reviewed by Darin.

Add test for http://bugs.webkit.org/attachment.cgi?id=15818&action=edit which
Mitz fixed in r24973.

I had a fix for <rdar://problem/5267021>
REGRESSION: Loading Slashdot Firehose is 9X slower on Safari 3.0 than Safari 2.0
which turned out to be a dublicate.

At least we can use the layout test I did.

http/tests/local/style-access-before-stylesheet-loaded-expected.txt: Added.
http/tests/local/style-access-before-stylesheet-loaded.html: Added.

2:18 AM Changeset in webkit [25018] by aroben

2 edits in trunk/WebKit/win

Fix <rdar://problem/5278790> Hole for find-on-page match in subframe isn't clipped by frame bounds

Reviewed by Maciej.

WebView.cpp: (WebView::rectsForTextMatches): Ported fix from r23586.

2:18 AM Changeset in webkit [25017] by aroben

2 edits in trunk/WebKit/win

Prevent an ASSERT on launch by initializing AtomicString in WebKitGraphics

Reviewed by Maciej.

WebKitGraphics.cpp: (makeFont):

Aug 11, 2007:

1:55 PM Changeset in webkit [25016] by pewtermoose

1 delete in trunk/LayoutTests/mac

Forgot to remove this directory

1:37 PM Changeset in webkit [25015] by pewtermoose

3 edits
3 moves
2 adds in trunk

LayoutTests:

Reviewed over and over and over by Adam Roben.

Bug 14740: Hierarchical layout tests and platform organization
http://bugs.webkit.org/show_bug.cgi?id=14740

Add support for platform-specific layout tests and results.
New platform structure is as follows:

platform: Added.
platform/mac: Added.
mac/leopard/ -> platform/mac-leopard
win/ -> platform/win
qt/ -> platform/qt

WebKitTools:

Reviewed over and over and over by Adam Roben.

Bug 14740: Hierarchical layout tests and platform organization
http://bugs.webkit.org/show_bug.cgi?id=14740

Add support for platform-specific layout tests and results.

Scripts/run-webkit-tests:

12:40 PM Changeset in webkit [25014] by ddkilzer

2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Adam.

Refactored svn-create-path to use a hash-of-hashes data structure to keep
track of changed files. In the top level hash, keys are paths to files and
values are 'fileData' hashes with the following keys and values:

isBinary: boolean value (set to true for non-text files like images, etc.)
isTestFile: boolean value (set to true if file exists within a known test directory)
modificationType: string equal to one of 'addition', 'additionWithHistory', 'modification' or 'deletion'
path: string equal to the path to the file (this may seem redundant, but it is required to use the second-level 'fileData' hash independent of the top-level hash)
sourceFile: [optional] string equal to the path of the original file that was copied or moved
sourceRevision: [optional] string equal to the revision of the original file that was copied or moved

Scripts/svn-create-patch: Moved call to GetOptions() to its own statement that saves the return value in $result, then checks it before printing help. Combined sourceFiles, %testFiles, and %binaryFiles into single %diffFiles hash and eliminated two for() loops. (binarycmp): Added. Used with sort() to order non-binary files before binary files. (findBaseUrl): Added. Extracted from findSourceFileAndRevision(). (findMimeType): Added optional second argument that takes a revision number. (generateDiff): Updated to take one fileData argument instead of three ($file, $modificationType, $isBinary). (generateFileList): Updated to take one hash ref argument (%diffFiles) instead of three (%sourceFiles, %testFiles, %binaryFiles). Populates %diffFiles using paths for keys and fileData hashes for values. (manufacturePatchForAdditionWithHistory): Updated to take one fileData argument. (pathcmp): Updated to take two fileData arguments instead of two strings. (testfilecmp): Added. Used with sort() to order non-test files before test files.

11:27 AM Changeset in webkit [25013] by darin

2 edits in trunk/WebKitTools

Scripts/run-webkit-tests: Give a different message when only the pixel test failed.

11:13 AM Changeset in webkit [25012] by zecke

2 edits in trunk/WebCore

2007-08-11 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Anders.

Implement passing events to a subframe. The code is copied from
the windows port and passSubframeEventToSubframe was removed as it
is not called and it is not avilable in the windows port as well.

page/gdk/EventHandlerGdk.cpp: (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe):

11:01 AM Changeset in webkit [25011] by darin

15 edits
34 adds in trunk

LayoutTests:

2007-08-11 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

tests and updated results for http://bugs.webkit.org/show_bug.cgi?id=13670 <rdar://problem/5399619> Table misrender when one of the TDs has width=100%

fast/table/100-percent-cell-width-expected.checksum: Added.
fast/table/100-percent-cell-width-expected.png: Added.
fast/table/100-percent-cell-width-expected.txt: Added.
fast/table/100-percent-cell-width.html: Added.
fast/table/percent-widths-stretch-expected.checksum: Added.
fast/table/percent-widths-stretch-expected.png: Added.
fast/table/percent-widths-stretch-expected.txt: Added.
fast/table/percent-widths-stretch.html: Added.
fast/text/whitespace/026-expected.checksum:
fast/text/whitespace/026-expected.png:
fast/text/whitespace/026-expected.txt:
tables/mozilla/bugs/bug35662-expected.checksum:
tables/mozilla/bugs/bug35662-expected.png:
tables/mozilla/bugs/bug35662-expected.txt:
tables/mozilla/bugs/bug5799-expected.checksum:
tables/mozilla/bugs/bug5799-expected.png:
tables/mozilla/bugs/bug5799-expected.txt:
tables/mozilla/core/col_span-expected.checksum:
tables/mozilla/core/col_span-expected.png:
tables/mozilla/core/col_span-expected.txt:

2007-08-11 Darin Adler <Darin Adler>

added a bunch of missing layout test results

editing/style/font-family-with-space-expected.checksum: Added.
editing/style/font-family-with-space-expected.png: Added.
fast/dom/frame-loading-via-document-write-expected.checksum: Added.
fast/dom/frame-loading-via-document-write-expected.png: Added.
fast/encoding/xmacroman-encoding-test-expected.checksum: Added.
fast/encoding/xmacroman-encoding-test-expected.png: Added.
fast/frames/frame-navigation-expected.checksum: Added.
fast/frames/frame-navigation-expected.png: Added.
fast/frames/frame-set-whitespace-attributes-expected.checksum: Added.
fast/frames/frame-set-whitespace-attributes-expected.png: Added.
fast/frames/inline-object-inside-frameset-expected.checksum: Added.
fast/frames/inline-object-inside-frameset-expected.png: Added.
fast/html/keygen-expected.checksum: Added.
fast/html/keygen-expected.png: Added.
fast/images/pdf-as-image-landscape-expected.checksum: Added.
fast/images/pdf-as-image-landscape-expected.png: Added.
fast/inline-block/14498-positionForCoordinates-expected.checksum: Added.
fast/inline-block/14498-positionForCoordinates-expected.png: Added.

WebCore:

2007-08-11 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13670 <rdar://problem/5399619> Table misrender when one of the TDs has width=100%

Tests: fast/table/100-percent-cell-width.html

fast/table/percent-widths-stretch.html

rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcPrefWidths): Changed the value used instead of 0% to avoid division by zero from 1% to less than 0.01%. Removed code that added 0.5px to non-percent widths when calculating the scaling factor. The latter change is covered by the percent-widths-stretch test, where the new results match both WinIE 7 and Firefox 3.

10:18 AM Changeset in webkit [25010] by darin

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Antti.

test for <rdar://problem/5266535> REGRESSION: <img> inside <map> no longer allowed in strict mode (breaks chemicalelements.com)

fast/parser/strict-img-in-map-expected.txt: Added.
fast/parser/strict-img-in-map.html: Added.

WebCore:

Reviewed by Antti.

fix <rdar://problem/5266535> REGRESSION: <img> inside <map> no longer allowed in strict mode (breaks chemicalelements.com)

Test: fast/parser/strict-img-in-map.html

html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::checkDTD): Removed FIXME saying this code is strange, since this code matches the HTML 4 specification almost exactly. Made <img> elements allowed even in strict mode and added small comments to clarify what comes from the DTD and what is non-standard.

6:53 AM Changeset in webkit [25009] by zecke

2 edits in trunk/WebCore

2007-08-11 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Lars.

GdkEventKey::string is not supposed to be used. The length
of this string is zero for non ascii charachters. Use the
gdk_unicode_to_keyval to convert the keyval to a UChar and construct
a String. This change makes it possible to input non ascii
charachters.

platform/gdk/KeyEventGdk.cpp: (WebCore::keyIdentifierForGdkKeyCode): (WebCore::singleCharacterString): (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

4:52 AM Changeset in webkit [25008] by andrew

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Mark Rowe.

Fix http://bugs.webkit.org/show_bug.cgi?id=14645
getPropertyValue should be case insensitive

Test for getPropertyValue, setProperty, removeProperty being case-insensitive

fast/css/css-properties-case-insensitive-expected.txt: Added.
fast/css/css-properties-case-insensitive.html: Added.

WebCore:

Reviewed by Mark Rowe.

Fix http://bugs.webkit.org/show_bug.cgi?id=14645
getPropertyValue should be case insensitive

When we get the propertyID for a given string we convert to lowercase.

This also applies to setProperty, removeProperty and others.

css/CSSStyleDeclaration.cpp: (WebCore::propertyID):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed