Timeline

Aug 14, 2007:

7:50 PM Changeset in webkit [25089] by kmccullo

• 2 edits in trunk/LayoutTests

Reviewed by Adam.

• Updated Skipped list to reflect recent fixes.

• platform/win/Skipped:

7:04 PM Changeset in webkit [25088] by sfalken

• 5 edits
  1 add in trunk

<rdar://problem/5411482> Windows user agent language always returns "en"

Reviewed by Oliver.

6:23 PM Changeset in webkit [25087] by weinig

• 4 edits
  2 adds in trunk

LayoutTests:

Reviewed by Geoff and Oliver.

Add test for <rdar://problem/5267870>
Mangleme: Reproducible assertion failure in -[WebCoreFrameBridge installInFrame:]

• http/tests/misc/embedCrasher-expected.txt: Added.
• http/tests/misc/embedCrasher.html: Added.

WebCore:

Reviewed by Geoff and Oliver.

Fix for <rdar://problem/5267870>
Mangleme: Reproducible assertion failure in -[WebCoreFrameBridge installInFrame:]

• Change embed/plugin code path to detach the frame on willRemove instead of detach. This matches what frame and iframe do.

Test: http/tests/misc/embedCrasher.html

• html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::willRemove):
• html/HTMLPlugInElement.h:

6:17 PM Changeset in webkit [25086] by adele

• 9 edits
  2 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test for <rdar://problem/5370059> REGRESSION: Cannot type into edit fields on a form (sccsheriff.org)

• editing/selection/user-select-text-inside-user-select-ignore-expected.txt: Added.
• editing/selection/user-select-text-inside-user-select-ignore.html: Added.
• fast/css/computed-style-expected.txt: Updated now that we've eliminated the auto value.
• fast/css/computed-style-without-renderer-expected.txt: ditto.

WebCore:

Reviewed by Maciej.

Fix for <rdar://problem/5370059> REGRESSION: Cannot type into edit fields on a form (sccsheriff.org)

This change makes -webkit-user-select an inherited css property. For "user-select: none" we were already
acting like it was an inheritable property, where we let user-select:text on the children override its parent's user-select:none.
By making user-select really inherited (instead of inherited for some values), we eliminate the need for crawling up the tree to see
if an ancestor has user-select ignore set.

• page/EventHandler.cpp: (WebCore::EventHandler::canMouseDownStartSelect): Now that user-select is inherited, you don't need to walk up the render tree looking for ancestors with user-select:ignore set.

• css/CSSStyleSelector.cpp: Eliminate SELECT_AUTO. (WebCore::CSSStyleSelector::adjustRenderStyle): (WebCore::CSSStyleSelector::applyProperty):
• css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

• rendering/RenderStyle.h: (WebCore::): Eliminate SELECT_AUTO. Make userSelect inherited. (WebCore::RenderStyle::userSelect): (WebCore::RenderStyle::setUserSelect): (WebCore::RenderStyle::initialUserSelect):
• rendering/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator==): (WebCore::RenderStyle::diff):

6:07 PM Changeset in webkit [25085] by andrew

• 15 edits in trunk

JavaScriptCore:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=14967 part 1 - Eliminate most implicit
conversions of wtf::Vector<T> to T* by explicitly calling .data()

• API/JSCallbackConstructor.cpp: (KJS::JSCallbackConstructor::construct):
• API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::callAsFunction):
• API/JSCallbackObject.cpp: (KJS::JSCallbackObject::construct): (KJS::JSCallbackObject::callAsFunction):
• bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::invokeMethod): (KJS::Bindings::CInstance::invokeDefaultMethod):
• kjs/number_object.cpp: (integer_part_noexp): (char_sequence):
• kjs/ustring.cpp: (KJS::UString::UTF8String):

WebCore:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=14967 part 1 - Eliminate most implicit
conversions of wtf::Vector<T> to T* by explicitly calling .data()

• html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::saveState):
• platform/KURL.cpp: (WebCore::KURL::KURL): (WebCore::KURL::init): (WebCore::KURL::decode_string): (WebCore::KURL::parse): (WebCore::KURL::encode_string):
• platform/cf/KURLCFNet.cpp: (WebCore::KURL::KURL):
• platform/mac/KURLMac.mm: (WebCore::KURL::KURL):
• rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layOutAxis):

win:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=14967 part 1 - Eliminate most implicit
conversions of wtf::Vector<T> to T* by explicitly calling .data()

• WebView.cpp: (getCompositionString):

5:23 PM Changeset in webkit [25084] by darin

• 2 edits in trunk/WebCore

Reviewed by Darin, Hyatt.

• fix <rdar://problem/5407795> -apple-line-clamp should never display less than one line

• rendering/RenderFlexibleBox.cpp:(WebCore::RenderFlexibleBox::layoutVerticalBox): Use max to make sure it never computes a minimum of less than one line.

4:46 PM Changeset in webkit [25083] by bdakin

• 1 edit
  2 adds in trunk/LayoutTests

Test for new support of empty style sheets.

• fast/css/emptyStyleTag-expected.txt: Added.
• fast/css/emptyStyleTag.html: Added.

4:30 PM Changeset in webkit [25082] by bdakin

• 27 edits in trunk/WebCore

Reviewed by Hyatt.

Refactor of change for <rdar://problem/5404899> REGRESSION: Mail
crash in WebCore::FontFallbackList::fontDataAt() after dragging
image into text multiple times

The original fix that I made last night prevents the pending style
sheet count from being incremented until the element is in the
document. This fix prevents the style sheet from loading at all
until it is in the document.

Here is the fix.

• dom/StyleElement.cpp: (WebCore::StyleElement::insertedIntoDocument): Call process. (WebCore::StyleElement::removedFromDocument): This can be reverted to its original state before my patch last night. (WebCore::StyleElement::process): childrenChanged is now called process. Return early if your not in the document. (WebCore::StyleElement::createSheet): Revert change from last night. The inDocument check is now in caller childrenChanged.
• dom/StyleElement.h: insertedIntoDocument() must now accept an element in addition to a document.

This is an optimization to prevent calling updateStyleSelector()
too frequently.

• dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startElementNs):
• html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::HTMLStyleElement): (WebCore::HTMLStyleElement::finishedParsing): (WebCore::HTMLStyleElement::insertedIntoDocument): (WebCore::HTMLStyleElement::childrenChanged): (WebCore::HTMLStyleElement::sheetLoaded):
• html/HTMLStyleElement.h:
• ksvg2/svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::SVGStyleElement): (WebCore::SVGStyleElement::finishedParsing): (WebCore::SVGStyleElement::insertedIntoDocument): (WebCore::SVGStyleElement::childrenChanged): (WebCore::SVGStyleElement::sheetLoaded):
• ksvg2/svg/SVGStyleElement.h: (WebCore::SVGStyleElement::setCreatedByParser):

This is a name change. Document::stylesheetLoaded()
is now Document::removePendingSheet()

• dom/Document.cpp: (WebCore::Document::removePendingSheet):
• dom/Document.h:
• dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::sheetLoaded):
• html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::~HTMLLinkElement): (WebCore::HTMLLinkElement::setDisabledState): (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::sheetLoaded):
• page/Frame.cpp: (WebCore::UserStyleSheetLoader::~UserStyleSheetLoader): (WebCore::UserStyleSheetLoader::setCSSStyleSheet):

This is another name change. closeRenderer() is now
finishedParsing()

• dom/Node.h: (WebCore::Node::finishedParsing):
• dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::endElementNs): (WebCore::):
• html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::finishedParsing):
• html/HTMLAppletElement.h:
• html/HTMLGenericFormElement.cpp: (WebCore::HTMLFormControlElementWithState::finishedParsing):
• html/HTMLGenericFormElement.h:
• html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::finishedParsing):
• html/HTMLObjectElement.h:
• html/HTMLParser.cpp: (WebCore::HTMLParser::insertNode): (WebCore::HTMLParser::popOneBlockCommon):
• html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::finishedParsing):
• html/HTMLScriptElement.h: (WebCore::HTMLStyleElement::setCreatedByParser):
• ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::finishedParsing):
• ksvg2/svg/SVGAnimationElement.h:
• ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::finishedParsing):
• ksvg2/svg/SVGElement.h:

4:08 PM Changeset in webkit [25081] by beidson

• 13 edits
  2 adds in trunk

WebCore:

Reviewed by Darin, John, Maciej, Oliver, and Tim

<rdar://problem/5394708> - Crash on launch with corrupt icon database

The main part of the fix is to not disable SQLite's default level of protection - to leave the sync options at their normal,
mostly safe levels.

But in case lightning strikes at the exact right moment and someone ends up with a corrupt database, add some support code to
detect that condition and recover from it.

This is mainly accomplished by exposing the "PRAGMA integrity_check;" facilities of sqlite through IconDatabase SPI as well as
running that integrity check if a journal file is detected at launch (a strong indication that the last quit was not clean).
There's also a method exposed to allow clients to tell the icon database "I suspect something bad happened, please check integrity"

• loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::checkIntegrityBeforeOpening): Allow clients to suggest an integrity check (WebCore::IconDatabase::open): Add a check to see if the journal file for the database exists. If it does, run the integrity check. Also run the check if a client has suggested it to be necessary. If the integrity-check fails, we sadly have to destroy the database and recreate from scratch. Also - quite importantly - do not adjust the default sync preferences for the SQLDatabase. They were an optimization that might have been valid at one time but no longer affects any benchmarks we care about. (WebCore::IconDatabase::checkIntegrity): Perform the SQLite integrity_check pragma
• loader/icon/IconDatabase.h:

• loader/icon/IconDatabaseNone.cpp: (WebCore::IconDatabase::checkIntegrity): Keep IconDatabaseNone users building (WebCore::IconDatabase::checkIntegrityBeforeOpening): Ditto

• loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::open): Make a copy of the path string so we don't accidentally mutate anyone else's string on ::close()

• platform/FileSystem.h: Added. Begin a long-needed platform file system abstraction
• platform/mac/FileSystemMac.mm: Added. (WebCore::fileExists): Check if a file exists (WebCore::deleteFile): Delete a file

• platform/gdk/TemporaryLinkStubs.cpp: (WebCore::fileExists): (WebCore::deleteFile):
• platform/qt/TemporaryLinkStubs.cpp: (WebCore::fileExists): (WebCore::deleteFile):
• platform/win/TemporaryLinkStubs.cpp: (WebCore::fileExists): (WebCore::deleteFile):

• WebCore.exp:
• WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Darin, John, Maciej, Oliver, and Tim

<rdar://problem/5394708> - Crash on launch with corrupt icon database

Expose some new SPI to help recover from this case should it happen again

• Misc/WebIconDatabase.mm: (-[WebIconDatabase init]): Use the new _databaseDirectory to determine where to open the database on disk (+[WebIconDatabase _checkIntegrityBeforeOpening]): Tell the icon database to check integrity when it opens (-[WebIconDatabase _databaseDirectory]): Moved the database-directory-determining logic here as it's now used in two places
• Misc/WebIconDatabasePrivate.h: Added _checkIntegrityBeforeOpening SPI for clients to give hints about when the integrity check should run

4:00 PM Changeset in webkit [25080] by honeycutt

• 2 edits in trunk/WebCore

2007-08-14 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Steve.

Build fix for Windows.

• html/HTMLFormElement.cpp:

3:37 PM Changeset in webkit [25079] by staikos

• 2 edits in trunk/WebCore

One-line obvious fix for context menus: don't connect the signal once for each
action, only once for the menu.

3:19 PM Changeset in webkit [25078] by darin

• 2 edits in trunk/JavaScriptCore

Reviewed by Sam.

• fix <rdar://problem/5410570> Global initializer introduced by use of std::numeric_limits in r24919

• kjs/ustring.cpp: (KJS::overflowIndicator): Turned into a function. (KJS::maxUChars): Ditto. (KJS::allocChars): Use the functions. (KJS::reallocChars): Ditto. (KJS::UString::expandedSize): Ditto.

3:10 PM Changeset in webkit [25077] by ggaren

• 2 edits in trunk/WebKitTools

Reviewed by Kevin Mccullough.

Removed special case that didn't belong. (It would allow a global
initializer to sneak into production builds, which would cause a
system-wide performance regression on Mac OS X.)

• Scripts/check-for-global-initializers:

3:05 PM Changeset in webkit [25076] by justing

• 5 edits
  4 adds in trunk

LayoutTests:

Reviewed by Tim.

<rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element

• editing/deleting/5408255.html: Added.
• editing/deleting/5408255-expected.checksum: Added.
• editing/deleting/5408255-expected.png: Added.
• editing/deleting/5408255-expected.txt: Added.

WebCore:

Reviewed by Tim.

<rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element

• editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::show): Use -webkit-user-select:ignore for the deletion UI.

WebKitTools:

Reviewed by Tim.

<rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element

• DumpRenderTree/EditingDelegate.m: (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Added, return YES only for elements with the class needsDeletionUI.

2:24 PM Changeset in webkit [25075] by aroben

• 3 edits in trunk/WebKit/win

Store user defaults in a non-mutable CFDictionaryRef

Also renamed WebPreferences' static members:

m_standardPreferences -> s_standardPreferences
m_standardUserDefaults -> s_defaultSettings

Reviewed by Darin and John.

• WebPreferences.cpp: (WebPreferences::getInstanceForIdentifier): (WebPreferences::initializeUserDefaults): Construct the dictionary as a local CFMutableDictionaryRef, then assign it to the non-mutable static member. (WebPreferences::valueForKey): (WebPreferences::removeDefaultsIfNeeded): (WebPreferences::standardPreferences):
• WebPreferences.h:

2:24 PM Changeset in webkit [25074] by aroben

• 4 edits in trunk/WebKit/win

Fix <rdar://problem/5214504> No way to change WebPreferences defaults (all preferences get written to disk)

We now only write to disk values that have been explicitly set, and
never write any default values.

This is not enough, however, as anyone who has used WebKit prior to
this change will have the default values sitting in their preferences
plist on disk. To remedy this, we perform a one-time removal of any
key-value pairs that match a pair in the defaults dictionary.

Reviewed by Steve, John, Ada, and Darin.

• WebPreferenceKeysPrivate.h: Added new key to ensure we only remove the defaults once.
• WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Renamed from initialize, and made sure we only set up the defaults dictionary once. Now that the defaults dictionary is never modified after creation, we don't need to check whether the keys are already present. (WebPreferences::setStringValue): Don't modify the defaults dictionary. (WebPreferences::setIntegerValue): Ditto. (WebPreferences::setBoolValue): Ditto. (WebPreferences::save): Write out the user's preferences, not the defaults. (WebPreferences::load):
  • Removed gotos and early declarations now that we're using RetainPtr everywhere.
  • Initialize m_privatePrefs with an empty dictionary if we didn't read in a plist.
  • Call migrateDefaultSettingsFromSafari3Beta after loading.

(WebPreferences::migrateDefaultSettingsFromSafari3Beta): Added.
(WebPreferences::removeValuesMatchingDefaultSettings): Added.
(WebPreferences::initWithIdentifier): Don't initialize m_privatePrefs
-- load() does this now.

• WebPreferences.h: Updated/added declarations.

2:24 PM Changeset in webkit [25073] by aroben

• 3 edits in trunk/WebKit/win

Use RetainPtr to store WebPreferences::m_privatePrefs

Reviewed by Darin.

• WebPreferences.cpp: (WebPreferences::setStringValue): (WebPreferences::setIntegerValue): (WebPreferences::setBoolValue): (WebPreferences::initWithIdentifier):
• WebPreferences.h:

1:20 PM Changeset in webkit [25072] by adele

• 1 edit
  3 adds in trunk/LayoutTests

Reviewed by Brady.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=14746
<rdar://problem/5401041> REGRESSION: Form state not saved for forms that submit via HTTPS even if they do not contain a password field

• http/tests/navigation/resources/restore-form-state-https-1.html: Added.
• http/tests/navigation/restore-form-state-https-expected.txt: Added.
• http/tests/navigation/restore-form-state-https.html: Added.

12:18 PM Changeset in webkit [25071] by antti

• 7 edits
  2 adds in trunk

LayoutTests:

Reviewed by Darin.

Add test for <rdar://problem/5143183>
Air Mail postmark shows up wrong in Firefox due to use of CSS background-position-x/y

Also update a few tests to expect background-position instead of background-position-x/y

• fast/css/background-position-serialize-expected.txt: Added.
• fast/css/background-position-serialize.html: Added.
• fast/css/computed-style-expected.txt:
• fast/css/computed-style-without-renderer-expected.txt:
• fast/css/remove-shorthand-expected.txt:

WebCore:

Reviewed by Darin.

Fix <rdar://problem/5143183>
Air Mail postmark shows up wrong in Firefox due to use of CSS background-position-x/y

Safari was using non-standard background-position-x/y properties when serializing style, both normal
and computed. As a result Safari generated CSS would not render correctly in Firefox.

Use standard background-position property instead.

• css/CSSComputedStyleDeclaration.cpp: (WebCore::):
• css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::cssText):

11:07 AM Changeset in webkit [25070] by ddkilzer

• 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=14965 svn-create-patch uses deprecated tail switch

• Scripts/svn-create-patch: Use 'tail -n +3' instead of 'tail +3'.

10:36 AM Changeset in webkit [25069] by weinig

• 2 edits in trunk/WebCore

Reviewed by Brady and Dr. Harrison.

Fix typo. 'whitespace' property is spelled 'white-space'.

• page/inspector/inspector.css:

Aug 13, 2007:

10:41 PM Changeset in webkit [25068] by bdakin

• 4 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/5404899> REGRESSION: Mail crash in
WebCore::FontFallbackList::fontDataAt() after dragging image into
text multiple times

We were crashing because style information was not up-to-date. This
patch fixes the problem in two ways:

Style information was not up to date at the time of the crash
because the document thought there was still a pending style sheet.
The pending style sheet counter was incremented when a call to
cloneNode from Mail cloned a style node with an imported style
sheet. Because Mail disables the cache, the style sheet did not
load immediately for the cloned node, and we do not check again to
see if it has loaded in time to decrement the pending style sheet
counter before the crash point. The fix here is only to increment
the pending style sheet counter for elements that are already in
the document.

• dom/StyleElement.cpp: (WebCore::StyleElement::insertedIntoDocument): If we have a CSS style sheet that is currently loading, increment the pending style sheet counter. This should keep the counter accurate in the case where a style node is cloned and then immediately inserted into the document. (WebCore::StyleElement::removedFromDocument): If we have a CSS style sheet that is currently loading, decrement the pending style sheet count. This is required to keep the correct balance, given the change above. (WebCore::StyleElement::createSheet): Only addPendingSheet() and checkLoaded() if we are in the document.

Here is Darin's original fix. It seems worth keeping this fix too.
Font style information should not cause a crash if there are still
pending style sheets. This is good belt-and-suspenders in case
there is another way to run into this bug with a wacky timing
issue.

• css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForElement): Update the font.

10:39 PM Changeset in webkit [25067] by ap

• 2 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=14635
rdar://problem/5340188
Uploading file with non-ASCII character in path fails

File upload cannot be tested in DumpRenderTree.

• html/HTMLFormElement.cpp: (WebCore::pathGetFilename): A cross-platform helper that extracts a file name from a path. (WebCore::HTMLFormElement::formData): Use the above helper instead of code that doesn't work on Windows.

10:24 PM Changeset in webkit [25066] by ap

• 3 edits
  2 adds in trunk

​http://bugs.webkit.org/show_bug.cgi?id=14951
REGRESSION: page interpreted as UTF-8 because of stray <?xml> after <head>

Test: fast/encoding/misplaced-xml-declaration.html

• loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset): Only honor XML declaration at the very beginning of the file.

7:04 PM Changeset in webkit [25065] by oliver

• 2 edits in trunk/WebCore

rs=sam

Correct accidentally modified code.

• platform/mac/FontDataMac.mm: (WebCore::FontData::platformInit):

6:52 PM Changeset in webkit [25064] by adele

• 5 edits in trunk/WebCore

Reviewed by Brady.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=14746
<rdar://problem/5401041> REGRESSION: Form state not saved for forms that submit via HTTPS even if they do not contain a password field

• loader/FrameLoader.cpp: (WebCore::FrameLoader::saveDocumentState): Restore our old behavior that will save form state for secure forms. This will also match Firefox behavior.

• dom/Document.cpp: Removed secureFormAdded(), secureFormRemoved(), hasSecureForm() which are no longer used.
• dom/Document.h:
• html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::attach): (WebCore::HTMLFormElement::parseMappedAttribute):

6:44 PM Changeset in webkit [25063] by oliver

• 2 edits in trunk/WebCore

Reviewed by Maciej.

<rdar://problem/5386183> REGRESSION (9A504-9A508): Underline of inline hole is too thin
on Japanese DotMac page

Hack the line metrics for the Hiragino font families so that they always allow space for
the marked text underline.

• platform/mac/FontDataMac.mm: (WebCore::FontData::platformInit):

5:19 PM Changeset in webkit [25062] by weinig

• 3 edits in trunk/LayoutTests

Reviewed by Kevin McCullough.

Another attempt at getting these to pass reliably.

• http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe-location-change.html:
• http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe.html:

5:13 PM Changeset in webkit [25061] by hyatt

• 2 edits in trunk/WebCore

Reviewed by aroben

<rdar://problem/5400446> messed up content on calendar.yahoo.com and my.yahoo.com

Fix some more bad assumptions about <html> being the first child of the document now that we
properly support HTML5's model (where a comment node preceding <html> will in fact be its sibling).

• html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): (WebCore::HTMLParser::createHead):

3:41 PM Changeset in webkit [25060] by weinig

• 5 edits in trunk/LayoutTests

Reviewed by Geoff.

Ensure that these tests don't fail intermittently.

• http/tests/security/dataURL/resources/foreign-domain-data-url-accessor-opened-frame.html:
• http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-window-open-expected.txt:
• http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe-location-change.html:
• http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe.html:

2:24 PM Changeset in webkit [25059] by sfalken

• 1 copy in tags/Safari-523.1b

New tag.

2:24 PM Changeset in webkit [25058] by sfalken

• 1 edit in trunk/WebKit/win/WebKit.vcproj/VERSION

Bump version for submit

12:14 PM Changeset in webkit [25057] by justing

• 8 edits
  4 adds in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/5333725> -webkit-user-select: none makes selection difficult

• editing/selection/5333725-expected.checksum: Added.
• editing/selection/5333725-expected.png: Added.
• editing/selection/5333725-expected.txt: Added.
• editing/selection/5333725.html: Added.

Added a workaround for a bug where -webkit-user-select:none
has no effect on the body if placed on the html element:

• editing/selection/select-all-user-select-none.html:

WebCore:

Reviewed by Darin.

<rdar://problem/5333725> -webkit-user-select: none makes selection difficult

Let users create selections if they mouse down in a -webkit-user-select:none
region, just (continue to) disallow selection endpoints in those regions, and
don't paint those regions as selected if they are fully enclosed by a selection.
For example, in xxyyyxx where x is -webkit-user-select:none, a user can mouse down
between the first two xs and drag across yyy to the second two xs to create a
selection xx^yyyxx.

• editing/SelectionController.cpp: (WebCore::SelectionController::selectAll): Allow selectAll inside a root that has -webkit-user-select:none, because it may contain content that is selectable (VisiblePosition and Selection creation will keep Selection endpoints out of -webkit-user-select:none regions).
• page/EventHandler.cpp: (WebCore::EventHandler::selectClosestWordFromMouseEvent): Use canMouseDownStartSelect instead of the ambiguously named shouldSelect(). (WebCore::EventHandler::handleMousePressEventTripleClick): Ditto. (WebCore::EventHandler::handleMousePressEventSingleClick): Ditto. (WebCore::EventHandler::updateSelectionForMouseDrag): Use canMouseDragExtendSelect. (WebCore::EventHandler::selectCursor): Paint an ibeam in -webkit-user-select:none regions, because you can click in those regions to create a selection. (WebCore::EventHandler::canMouseDownStartSelect): Now fires the selectStart event, and returns true in -webkit-user-select: none regions. (WebCore::EventHandler::canMouseDragExtendSelect): This is identical to canMouseDownStartSelect because of 12823, even though it seems strange that we would fire the selectStart event here.
• page/EventHandler.h:
• rendering/RenderObject.cpp: (WebCore::RenderObject::draggableNode): Only -webkit-user-select:ignore regions will prevent selection creation.
• rendering/RenderObject.h:

12:02 PM Changeset in webkit [25056] by andersca

• 5 edits in trunk

LayoutTests:

Reviewed by Maciej.

<rdar://problem/5360748>
REGRESSION (r21002-r21003): Flash widget sniffer doesn't work (affects iWeb)

Update test case to handle the case where the node list is accessed after
the document has finished loading.

• fast/dom/NodeList/invalidate-node-lists-when-parsing-expected.txt:
• fast/dom/NodeList/invalidate-node-lists-when-parsing.html:

WebCore:

Reviewed by Maciej.

<rdar://problem/5360748>
REGRESSION (r21002-r21003): Flash widget sniffer doesn't work (affects iWeb)

Don't check whether the document is being parsed or not, because the node list
could be accessed after the document has finished parsing.

• dom/Node.cpp: (WebCore::Node::registerNodeList):

11:02 AM Changeset in webkit [25055] by weinig

• 2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

Use the cygwin specific Apache config file under cygwin.

• Scripts/run-webkit-httpd:

5:06 AM Changeset in webkit [25054] by lars

• 2 edits in trunk/WebCore

no need to update regions that are not visible on the webpage.